D24744: Remove unneeded options in GTK KCM

gikari added a comment. In D24744#549450 , @GB_2 wrote > Well, it'll be gone completely soon and the GTK theme comboboxes will be in the Application Style KCM. Where would gtk theme installation buttons go? REPOSITORY R99 KDE Gtk

D24749: Fix build with older glibc: link there to librt for clock_gettime

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Only since glibc version 2.17 -lrt is no longer needed See same fix done for processui in

D24732: Rewrite AppChooser dialog

jgrulich added a comment. In D24732#549249 , @ngraham wrote: > Give the scrollview a frame and a white background or else apps look cut off and weird and there's a mysteriously hovering scroller: F7616694: Screenshot_20191017_111833.png

D24479: [KCM] Make multi-screen draggability more obvious

ngraham added a comment. Ping. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24479 To: ngraham, romangg, #plasma, #vdg Cc: GB_2, davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin,

D24711: KCM mouse: fix the bug with flat acceleration profile for libinput DDX driver

miraiko updated this revision to Diff 68109. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24711?vs=68084=68109 REVISION DETAIL https://phabricator.kde.org/D24711 AFFECTED FILES kcms/mouse/backends/x11/x11_libinput_dummydevice.cpp To: miraiko,

D24711: KCM mouse: fix the bug with flat acceleration profile for libinput DDX driver

miraiko added a comment. In D24711#548705 , @anthonyfieroni wrote: > https://phabricator.kde.org/source/plasma-desktop/browse/master/kcms/mouse/backends/x11/x11_libinput_dummydevice.cpp$126 > It should be changed also, right? I don't

D24687: [KCM] Add output selector ComboBox

broulik added inline comments. INLINE COMMENTS > romangg wrote in Panel.qml:33 > what does this FIXME mean? Ideally the heading would be `i18n("Settings for:")` but you can't do string changes in stable and I don't want to request an exception for a minor inconvenience. REPOSITORY R104

D24748: [containmentlayoutmanager] Don't accept button events that only start timers

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Otherwise we block containment actions on the left button BUG: 413104

D24688: [KCM] Disallow dropping screen outside of reachable area

ngraham added a comment. +1 for auto-zoom and making the screens bigger. Then we can remove the buttons that centers the view too. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24688 To: broulik, #plasma, #vdg, romangg Cc: ngraham, mart, plasma-devel, LeGast00n,

D24732: Rewrite AppChooser dialog

jgrulich added a comment. In D24732#548992 , @ognarb wrote: > I would add text on the button e.g "Show more", otherwise it's quite difficult to know how to show more apps There is a tooltip, but maybe showing text next to it might be

D24735: Gracefully replace outputModel

broulik added a comment. Oh I'm an idiot, I forgot to delete the model. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24735 To: broulik, #plasma, romangg, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D24737: Correctly highlight the icon in the system tray

kmaterka created this revision. kmaterka added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Icon is highlighted when CapsLock or NumLock are locked. It should not be

D24735: Gracefully replace outputModel

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. In D24735#549048 , @broulik wrote: > I call `release()` instead of `get()` so I reset the pointer to null so that when I signal

D24735: Gracefully replace outputModel

romangg added a comment. 5.17 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24735 To: broulik, #plasma, romangg, davidedmundson Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf,

D24735: Gracefully replace outputModel

This revision was automatically updated to reflect the committed changes. Closed by commit R104:2ab4c2f136c5: Gracefully replace outputModel (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24735?vs=68145=68149#toc REPOSITORY R104 KScreen CHANGES SINCE LAST

D24738: Highlight the icon in the system tray on mouse over

kmaterka created this revision. kmaterka added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Icon should be highlighted hover, as any other icons in the system tray.

D24715: Show a message indicating that no TB devices are connected when the list is empty

This revision was automatically updated to reflect the committed changes. Closed by commit R1044:cf47147b3c2b: Show a message indicating that no TB devices are connected when the list is… (authored by ngraham). REPOSITORY R1044 Plasma Thunderbolt Integration CHANGES SINCE LAST UPDATE

D24734: [KCM] remove the page indicator dots

romangg added a comment. I agree with Kai that the dots should stay. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24734 To: ngraham, romangg, broulik, #vdg, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D24734: [KCM] remove the page indicator dots

romangg added a comment. I didn't change mine. And I have mentioned it multiple times before and explicitly in the review request to add the combobox: I see the combobox only as an intermediate solution. By that we have now two different ways of selecting outputs, one through the graphical

D24740: [Media Controller] Multiple artists support

lesf0 created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. lesf0 requested review of this revision. REVISION SUMMARY According to the spec, xesam:artist should be a string array, but majority of players uses string instead. This patch adds support

D24732: Rewrite AppChooser dialog

ngraham added a comment. What's the best way to test this out? REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D24732 To: jgrulich, #plasma Cc: ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24711: KCM mouse: fix the bug with flat acceleration profile for libinput DDX driver

anthonyfieroni added a comment. https://phabricator.kde.org/source/plasma-desktop/browse/master/kcms/mouse/backends/x11/x11_libinput_dummydevice.cpp$126 It should be changed also, right? When you create a diff add a more context to it, like `git diff -U100 > patch` REPOSITORY R119

D24719: Fix laptop screen being off when opening the lid

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land.  5.17 REPOSITORY R104 KScreen BRANCH fixit REVISION DETAIL https://phabricator.kde.org/D24719 To: nicolasfella, #plasma, romangg Cc: plasma-devel, LeGast00n,

D24732: Rewrite AppChooser dialog

jgrulich updated this revision to Diff 68140. jgrulich added a comment. Add text to the button rather then using tooltip REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24732?vs=68137=68140 BRANCH new-app-dialog

D24732: Rewrite AppChooser dialog

jgrulich added a comment. Is this better? F7615448: Screenshot_20191017_155608.png REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D24732 To: jgrulich, #plasma Cc: ognarb, plasma-devel,

D24735: Gracefully replace outputModel

davidedmundson added a comment. Urgh, so the order of events is: KCMKScreen::~KCMKScreen() <-- deletes the config and exposed properties KCModuleQML::~KCModuleQML() <-- tears down the UI, which now references dangling things. I think thats's a sign of a more generic that it would

D24735: Gracefully replace outputModel

broulik added a comment. > But just destroying and recreating is much simpler. ;) And causes crashes by leaving things on the QML side in an inconsistent state. Not sure `deleteLater` will help you since `GetConfigOperation()` could take longer than that. We could perhaps delete the

D24738: Highlight the icon in the system tray on mouse over

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24738 To: kmaterka, #plasma, davidedmundson, #plasma_workspaces, broulik Cc:

D24720: [applets/systemtray] Rewrite popups with layouts

ngraham added a comment. In D24720#549139 , @kmaterka wrote: > In D24720#549097 , @kmaterka wrote: > > > Pin button is no longer working,which is surprising :) > > > In fact it is working, but

D24734: [KCM] remove the page indicator dots

ngraham added a comment. I guess we actually have three ways to switch the settings view: - Click on screen in the visualization (currently broken for some use cases) - Use the combobox - Click on one of the page indicator dots Of these three, I think the dots are by far the

D24734: [KCM] remove the page indicator dots

broulik added a comment. I would prefer they stay in. It's a swiping sliding view, they do no harm. Also I'm having trouble with the `ComboBox` right now, please hold this for now. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24734 To: ngraham, romangg,

D24732: Rewrite AppChooser dialog

ognarb added a comment. I would add text on the button e.g "Show more", otherwise it's quite difficult to know how to show more apps REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D24732 To: jgrulich, #plasma Cc: ognarb,

D24734: [KCM] remove the page indicator dots

ngraham created this revision. ngraham added reviewers: romangg, broulik, VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Now that D24687 has landed, settings

D24735: Gracefully replace outputModel

broulik created this revision. broulik added reviewers: Plasma, romangg, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This patch has it signal the disappearance of the `outputModel` and only

D24734: [KCM] remove the page indicator dots

broulik added a comment. Alright, convinced. See D24735 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24734 To: ngraham, romangg, broulik, #vdg, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D24735: Gracefully replace outputModel

romangg added a comment. But just destroying and recreating is much simpler. ;) Regarding the change: if we release without delete afterwards we leak memory. Maybe deleteLater? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24735 To: broulik, #plasma,

D24735: Gracefully replace outputModel

broulik added a comment. I call `release()` instead of `get()` so I reset the pointer to null so that when I signal `outputModelChanged` it returns `null` and QtQuick resets everything and only then I delete it. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24735

D24733: feedback kcm: Make it about Plasma

apol updated this revision to Diff 68153. apol marked an inline comment as done. apol added a comment. Remove duplicated text, disable when the kill switch is on REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24733?vs=68135=68153 BRANCH

D24691: Add support for WPA3

jgrulich updated this revision to Diff 68155. jgrulich added a comment. Simplify code REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24691?vs=68036=68155 BRANCH wpa3 REVISION DETAIL https://phabricator.kde.org/D24691

D24720: [applets/systemtray] Rewrite popups with layouts

ngraham added a comment. +1, let;s not change the paddings here. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24720 To: filipf, #plasma, #vdg Cc: ngraham, kmaterka, mart, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen,

D24683: [KWindowSystem] in icon() return realistic icon size

meven marked 5 inline comments as done. meven added inline comments. INLINE COMMENTS > anthonyfieroni wrote in windowsystem.cpp:173 > That's adjustment, 16, 32, 48, 64, 128, 256 are standard icon sizes, when you > got a value between 2 sizes you adjust it by lower bound. Say (256 - 128) / 2 >

D24720: [applets/systemtray] Rewrite popups with layouts

kmaterka added a comment. In D24720#549097 , @kmaterka wrote: > Pin button is no longer working,which is surprising :) In fact it is working, but there is no background change. Old version had blue background when pinned. REPOSITORY

D24738: Highlight the icon in the system tray on mouse over

This revision was automatically updated to reflect the committed changes. Closed by commit R120:532d4da7bfb5: Highlight the icon in the system tray on mouse over (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24732: Rewrite AppChooser dialog

jgrulich added a comment. This is the initial state of the dialog, which presents only apps associated with given mimetype. Then if you click at the button below, it will show all the apps and provide a search bar. F7615342: Screenshot_20191017_154506.png

D24734: [KCM] remove the page indicator dots

ngraham added a comment. Ok. However once you deem the combobox perfectly reliably I would like to remove these. They're redundant; their function is to give you a clickable method to change a swipe view's pages, but you've added a combobox which already provides that. We don't need

D24735: Gracefully replace outputModel

ngraham added a comment. For me this fixes the crash when unplugging a screen with the KCM open, FWIW. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24735 To: broulik, #plasma, romangg, davidedmundson Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24735: Gracefully replace outputModel

broulik updated this revision to Diff 68145. broulik added a comment. - Delete the old model REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24735?vs=68141=68145 REVISION DETAIL https://phabricator.kde.org/D24735 AFFECTED FILES kcm/kcm.cpp To:

D24734: [KCM] remove the page indicator dots

ngraham added a comment. D24735 just landed; can you and or @romangg approve this if you're okay with it? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24734 To: ngraham, romangg, broulik, #vdg, #plasma Cc: plasma-devel,

D24720: [applets/systemtray] Rewrite popups with layouts

kmaterka added a comment. Pin button is no longer working,which is surprising :) About padding: I would vote for **not** changing padding nor margins, at least not in this change. It will be easier to review and test it you split this into two changes. This popup size is pretty small,

D24734: [KCM] remove the page indicator dots

ngraham added a comment. But Kai changed his mind after reading https://phabricator.kde.org/D24734#549029 :-) REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24734 To: ngraham, romangg, broulik, #vdg, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24732: Rewrite AppChooser dialog

apol added a comment. +1 looks much better REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D24732 To: jgrulich, #plasma Cc: apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D24687: [KCM] Add output selector ComboBox

This revision was automatically updated to reflect the committed changes. Closed by commit R104:7811411c6425: [KCM] Add output selector ComboBox (authored by broulik). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24687?vs=68024=68136 REVISION DETAIL

D23578: Before requesting a scan, check the time threshold

This revision was automatically updated to reflect the committed changes. Closed by commit R116:96203335b408: Before requesting a scan, check the time threshold (authored by meven). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D24683: [KWindowSystem] in icon() return realistic icon size

anthonyfieroni added inline comments. INLINE COMMENTS > meven wrote in windowsystem.cpp:173 > @anthonyfieroni Hey Anthony > Do you remember where the if comparison width values come from in your commit > https://cgit.kde.org/kwindowsystem.git/commit/?id=e8762b96ae7a9fabc6af8fc5dcf2b82a7206053f

D24688: [KCM] Disallow dropping screen outside of reachable area

broulik updated this revision to Diff 68125. broulik added a comment. - No magic numbers REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24688?vs=68025=68125 REVISION DETAIL https://phabricator.kde.org/D24688 AFFECTED FILES

D22005: Accept local paths

meven updated this revision to Diff 68127. meven added a comment. Use QDir::isAbsolutePath and rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22005?vs=60372=68127 BRANCH arcpatch-D22005 REVISION DETAIL https://phabricator.kde.org/D22005

D24687: [KCM] Add output selector ComboBox

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Ok, let's push for 5.17 as an intermediate quick fix. Thanks Kai. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24687 To: broulik, #plasma, #vdg, romangg Cc:

D22005: Ensure url from KActivity resources are properly built

meven updated this revision to Diff 68132. meven added a comment. amend commit message REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22005?vs=68127=68132 BRANCH arcpatch-D22005 REVISION DETAIL https://phabricator.kde.org/D22005 AFFECTED

D24733: feedback kcm: Make it about Plasma

apol created this revision. apol added reviewers: Plasma, vkrause, davidedmundson, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY At the moment we were merging two different concepts into a same KCM and

D24733: feedback kcm: Make it about Plasma

ngraham added a comment. Indeed, this is much nicer. The explanatory text for "Disabled" appears to duplicate some of the text above it though: F7615296: Screenshot_20191017_074048.png REPOSITORY R120 Plasma Workspace REVISION DETAIL

D24729: remove unnecessary ; + add const to getter + typo in Roles declaration.

crossi created this revision. crossi added reviewers: Plasma, ervin, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24729 AFFECTED FILES

D23578: Before requesting a scan, check the time threshold

meven updated this revision to Diff 68120. meven added a comment. Rebasing REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23578?vs=67595=68120 BRANCH arcpatch-D23578 REVISION DETAIL https://phabricator.kde.org/D23578

D24719: Fix laptop screen being off when opening the lid

nicolasfella added a comment. I tested it. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24719 To: nicolasfella, #plasma, romangg Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D24688: [KCM] Disallow dropping screen outside of reachable area

romangg added a comment. There was also the idea to drop the `Center View` button and instead resize the view whenever an output is dropped to a different position. I feel this would be also a more elegant solution for the issue trying to be solved here, if we agree that this would be in

D24688: [KCM] Disallow dropping screen outside of reachable area

broulik added a comment. That could also work, however the view wastes a lot of space right now, the screens could be a lot bigger, if we were to auto-zoom. F7615211: Screenshot_20191017_153310.png REPOSITORY R104 KScreen REVISION DETAIL

D24727: Fix NOAA picture of the day provider

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY The webpage structure of NOAA changed so the old regular expression doesn't work anymore. Updated it. But it can break in future

D24728: Ensure url from KActivity resources are properly built

meven created this revision. meven added reviewers: broulik, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Relates to D22005 BUG: 401579 FIXED-IN: 5.18 TEST

D24719: Fix laptop screen being off when opening the lid

romangg added a comment. DId you test with the most recent revision? The code is right in theory here. But if there is a problem with it now, we have some other problem at some other position. I'm asking because there were reports in the past about the lid open configuration being broken.

D24732: Rewrite AppChooser dialog

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY The new version of dialog allows you to select any application if associated applications are not what users want. The dialog

D24733: feedback kcm: Make it about Plasma

davidedmundson added a comment. +++ INLINE COMMENTS > feedback.h:31 > > -Q_PROPERTY(bool feedbackEnabled READ feedbackEnabled WRITE > setFeedbackEnabled NOTIFY feedbackEnabledChanged) > Q_PROPERTY(int plasmaFeedbackLevel READ plasmaFeedbackLevel WRITE > setPlasmaFeedbackLevel

D24732: Rewrite AppChooser dialog

jgrulich updated this revision to Diff 68137. jgrulich added a comment. Do not duplicate desktop files REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24732?vs=68134=68137 BRANCH new-app-dialog REVISION DETAIL

D24717: [Advanced Settings] Clean up UI file

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Looks the same as in, the bug on Qt5.14 is still there. Though this is an improvement, so feel free to ship it. REPOSITORY R122 Powerdevil REVISION DETAIL

D7260: System tray icon's context menu isn't updated properly in plasma/x11

kmaterka added a comment. Please check my comment in BUG 383202 . Problem is on Qt side and most probably can be solved there: QTBUG-79287 REPOSITORY

D23578: Before requesting a scan, check the time threshold

jgrulich accepted this revision. jgrulich added a comment. Alright, I believe you are correct. REPOSITORY R116 Plasma Network Management Applet BRANCH arcpatch-D23578 REVISION DETAIL https://phabricator.kde.org/D23578 To: meven, #plasma, jgrulich Cc: plasma-devel, LeGast00n,

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

aspotashev added a comment. Before pushing new i18n strings into stable branches, you need to ask for permission in https://mail.kde.org/mailman/listinfo/kde-i18n-doc Altough one translator's approval is enough, writing to kde-i18n-doc is also important to notify the other translation

D24720: [applets/systemtray] Rewrite popups with layouts

GB_2 added a comment. > F761074 Can we align the header with the search field/content here? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24720 To: filipf, #plasma, #vdg Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D24720: [applets/systemtray] Rewrite popups with layouts

mart added a comment. In D24720#548745 , @GB_2 wrote: > > F7610748: Screenshot_20191017_013250.png > > Can we align the header with the search field/content here? ish: since they arrive from

D24723: Fix slideshow crashing in invalidate()

davidre updated this revision to Diff 68117. davidre added a comment. Simplify the logic. In configmode we don't need the random order. We just use the order of the underlying model. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24719: Fix laptop screen being off when opening the lid

nicolasfella updated this revision to Diff 68110. nicolasfella added a comment. - Fixes REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24719?vs=68099=68110 BRANCH fixit REVISION DETAIL https://phabricator.kde.org/D24719 AFFECTED FILES

D24694: fix part count

This revision was automatically updated to reflect the committed changes. Closed by commit R106:726e7b6d1815: fix nvidia line part count (authored by sitter). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24694?vs=68039=68111 REVISION DETAIL

D24723: Fix slideshow crashing in invalidate()

davidre created this revision. davidre added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY QSortFilterProxyModel uses std::stable_sort internally which requires that the comparison

D24723: Fix slideshow crashing in invalidate()

davidre updated this revision to Diff 68115. davidre added a comment. Need rebuild here, rowCount could have changed REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24723?vs=68114=68115 BRANCH Plasma/5.17 REVISION DETAIL

D24713: [RFC] [Updates page] use fancier logic for handling elided Old+New version strings

mart added inline comments. INLINE COMMENTS > UpdatesPage.qml:286 > // since the version strings there are > really really long > -return availableVersion > +return i18nc("Do not

D24720: [applets/systemtray] Rewrite popups with layouts

mart added a comment. code-wise i like it. It changes the look quite a bit, by adding a lot of padding. Is that ok for VDG? personally i liked that the blue line touched the separator line, same as kickoff INLINE COMMENTS > filipf wrote in ExpandedRepresentation.qml:93 > How do I use

D24683: [KWindowSystem] in icon() return realistic icon size

meven added a subscriber: anthonyfieroni. meven added a comment. ping @zzag @mart Any feedback INLINE COMMENTS > meven wrote in windowsystem.cpp:173 > I can't explain the current logic. > > @mart Do you think I should change the logic to give it more sense ? > > Perhaps make the 24, 40..

D24691: Add support for WPA3

meven added inline comments. INLINE COMMENTS > wifisecurity.cpp:403 > { > -if (index == 0) { > +if (index == 0) { // None > m_ui->stackedWidget->setCurrentIndex(0); It would be nice to convert use SecurityTypeIndex enum instead of hardcoded values. It seems to me those values

D24706: Don't use focus color on checkable button backgrounds

ndavis added a comment. This is starting to become more than just a usability fix for togglebuttons (I was hoping to make something that could be part of Plasma 5.17.1) and more of a general button highlight style patch. REPOSITORY R31 Breeze REVISION DETAIL

D24733: feedback kcm: Make it about Plasma

ngraham added a comment. In D24733#549185 , @apol wrote: > It's changed in the last iteration of the patch. You probably enabled the kill switch on the present version of the kcm. Yeah, I did. So now how do I turn it off?  Is there a

D24737: Correctly highlight the icon in the system tray

davidedmundson added a comment. Interestingly the very original code was +active: parent.containsMouse || root.capsLock The rationale, I assume was because number lock takes precedent over caps lock in the icon, so this gives you a way of seeing when you have both.

D24740: [Media Controller] Multiple artists support

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks for your patch! I am not sure if the property should be perhaps changed to a `property var` and always contain an `Array`. But that would mean changing the tooltip, full

D24723: Fix slideshow crashing in invalidate()

davidre added inline comments. INLINE COMMENTS > slidefiltermodel.cpp:51 > +if(sourceModel) { > +connect(sourceModel, ::rowsInserted, this, > ::invalidate); > +connect(sourceModel, ::rowsRemoved, this, > ::invalidate); Good point. No need to invalidate in the other cases.

D24732: Rewrite AppChooser dialog

ngraham added a comment. Give the scrollview a frame and a white background or else apps look cut off and weird and there's a mysteriously hovering scroller: F7616694: Screenshot_20191017_111833.png Also why are there duplicates in here?

D24683: [KWindowSystem] in icon() return realistic icon size

meven marked 2 inline comments as done. meven added a comment. Anyone to care to review and accept this small code change ? REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D24683 To: meven, #kwin, davidedmundson Cc:

D24734: [KCM] remove the page indicator dots

broulik added a comment. I don't think the complaints are about the dots, it's a complaint that they're the only means of accessing disabled outputs (discount swiping), which is rectified by the combo box. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24734 To:

D24719: Fix laptop screen being off when opening the lid

This revision was automatically updated to reflect the committed changes. Closed by commit R104:e47dc21a7b78: Fix laptop screen being off when opening the lid (authored by nicolasfella). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24719?vs=68110=68179

D24733: feedback kcm: Make it about Plasma

apol updated this revision to Diff 68181. apol added a comment. Ehm... REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24733?vs=68153=68181 BRANCH nokillswitch REVISION DETAIL https://phabricator.kde.org/D24733 AFFECTED FILES

D24733: feedback kcm: Make it about Plasma

ngraham added a comment. Ok, now I see this: F7616194: Screenshot_20191017_095308.png Is that caused by a change here, or did something truly change on my system in the last hour? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D24733: feedback kcm: Make it about Plasma

apol added a comment. It's changed in the last iteration of the patch. You probably enabled the kill switch on the present version of the kcm. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24733 To: apol, #plasma, vkrause, davidedmundson, ngraham Cc:

D24733: feedback kcm: Make it about Plasma

apol added a comment. In D24733#549186 , @ngraham wrote: > In D24733#549185 , @apol wrote: > > > It's changed in the last iteration of the patch. You probably enabled the kill switch on the present

D24733: feedback kcm: Make it about Plasma

ngraham added a comment. It already is: F7616320: Screenshot_20191017_101011.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24733 To: apol, #plasma, vkrause, davidedmundson, ngraham Cc: plasma-devel, LeGast00n,

  1   2   >