D25976: Use a default non-administrator user Type for new users in model

meven created this revision. meven added reviewers: ngraham, Plasma, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY If the administrator role was not set for the index assume the default normal user type.

D25978: Don't hardcode the margin of the CardsListView

davidedmundson added a comment. Makes sense, but I don't understand how this helps, given the path is "private/" ? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25978 To: apol, #kirigami Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos,

D25976: Use a default non-administrator user Type for new users in model

ngraham added a comment. Thanks Méven! This fixes the case of creating a non-admin user. However while testing it, I found a regression from D25439 : when I create an admin user that has a space in the Real Name field, the "Enable administror privileges

D24238: Port the pager applet away from QtWidgets

davidedmundson closed this revision. davidedmundson added a comment. @dfaure You can commandeer and then click close REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24238 To: davidedmundson, hein, apol, dfaure Cc: ognarb, broulik, plasma-devel, LeGast00n,

D24238: Port the pager applet away from QtWidgets

dfaure added a comment. Ah, right. Thanks. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24238 To: davidedmundson, hein, apol, dfaure Cc: ognarb, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D25984: Load translations

broulik created this revision. broulik added reviewers: Kirigami, Frameworks, kossebau, aacid. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The ECM QM Loader uses `Q_COREAPP_STARTUP_FUNCTION` which doesn't

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 315 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/315/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Dec 2019 09:21:20 + Build duration: 32 min and counting JUnit Tests Name: projectroot

D25978: Don't hardcode the margin of the CardsListView

apol added a comment. The path is private but the class is directly inherited. 路 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25978 To: apol, #kirigami Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, mart,

D25973: Make the theme info QuickWidget transparent

filipf added a comment. There might be an unfortunate side effect: https://forum.qt.io/topic/57634/qt-wa_alwaysstackontop-influences-font-rendering-in-qml/5 Which is acceptable here in my opinion since blending doesn't even exists with Breeze, but could become a problem if present

D25978: Don't hardcode the margin of the CardsListView

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Use the left/rightMargin properties with a default value, in case it makes sense to override it.

KDE CI: Plasma » kgamma5 » stable-kf5-qt5 SUSEQt5.12 - Build # 27 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kgamma5/job/stable-kf5-qt5%20SUSEQt5.12/27/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Sat, 14 Dec 2019 09:21:29 + Build duration: 53 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-integration » kf5-qt5 FreeBSDQt5.13 - Build # 20 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-integration/job/kf5-qt5%20FreeBSDQt5.13/20/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Dec 2019 09:21:04 + Build duration: 1 min 27 sec and counting JUnit Tests Name:

D25935: [Notifications] Add hint for showing a notification even in do not disturb mode

broulik added a comment. It was suggested to make it more semantic, i.e. be about "this is feedback for user-initiated task" which will then imply showing in dnd mode. Suggestions on how to phrase that as a key name? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

leinir updated this revision to Diff 71495. leinir added a comment. - Add the provider and service files (these use temp client data for now) - Actually install the service and provider files REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25983: Update size hint when font changes

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Ensures controls update their size when font changes. The Labels inside would but the control

D25983: Update size hint when font changes

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yup. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D25983 To: broulik, #plasma, ngraham Cc: ngraham, plasma-devel, LeGast00n,

D25978: Don't hardcode the margin of the CardsListView

This revision was automatically updated to reflect the committed changes. Closed by commit R169:2757a17bb089: Dont hardcode the margin of the CardsListView (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25978?vs=71491=71504 REVISION

D25986: Resize file dialog window before size restore

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY KDEPlatformDialogHelper explicitly resizes the window contents to the

D25374: [ResultDelegate] Fix bad text legiblity with certain 3rd party themes

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works for me, and the code looks like it's doing the right thing. Did you kill and relaunch krunner? REPOSITORY R112 Milou BRANCH fix-bad-text-legibility (branched from master)

D23876: [applets/kickoff] Tweak padding for lists

ngraham added a comment. Ping! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23876 To: filipf, #vdg, #plasma, ngraham Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D25989: Don't build and install app templates on android

This revision was automatically updated to reflect the committed changes. Closed by commit R169:3bc41934f9d6: Dont build and install app templates on android (authored by jbbgameich). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25989?vs=71517=71518

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

ngraham added a comment. It occurs to me that this is basically the exact use case for adding a launcher widget to the panel, and using it would be an almost identical final user experience. In both cases, you wind up with an immovable launcher that doesn't change its location in response

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

ngraham added a comment. I'm talking about an actual launcher widget in the panel, nothing to do with the Task Manager's own pinning support. Launcher widgets in the panel are used for launching apps and will never move around, which is exactly what this patch is implementing within the

D25991: [KFilePlacesModel] Fix supported scheme check for devices

broulik created this revision. broulik added reviewers: Frameworks, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY A device doesn't usually have a URL so we need to actutally check the underlying

D25991: [KFilePlacesModel] Fix supported scheme check for devices

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oh so nice. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25991 To: broulik, #frameworks, dfaure, ngraham Cc: ngraham, plasma-devel, LeGast00n,

D25986: Resize file dialog window before size restore

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Fantastic!!! This fixes the file dialogs being way too tiny by default. Marvelous. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL

D25989: Don't build and install app templates on android

jbbgameich created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY They increase apk sizes and are really not required in an apk. REPOSITORY R169 Kirigami BRANCH

D25889: Polish the "review this review" UI and presentation

ngraham added a comment. I find that the current one takes up too much vertical space and the top line of text blends too much into the review itself. I feel like those issues should be addressed somehow. Maybe this isn't the right way, so suggestions would be appreciated. REPOSITORY

D25990: Simplify android checks in cmake

nicolasfella created this revision. nicolasfella added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R169 Kirigami BRANCH andro REVISION DETAIL https://phabricator.kde.org/D25990

D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme

ngraham added a comment. How about this? F7818015: Screenshot_20191214_151602.png Here's a KDeclarative patch to add an optional subtitle that you can use if you think this looks good is is a good starting point: P508 KDeclarative patch in

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

ngraham added a comment. Oh, I see. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12463 To: Fuchs, hein Cc: fabianr, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai,

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

Fuchs added a comment. Then as soon as you actually run the app there will be a duplicate, the launcher and the entry in the task manager. If I understood correctly, pinned tabs in browsers avoid that. You have a small, icon only variant when not open and a full variant (at the same

D25970: [applet] Make details text fully opaque and normal style

This revision was automatically updated to reflect the committed changes. Closed by commit R116:00be92a520e6: [applet] Make details text fully opaque and normal style (authored by ngraham). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D25984: Load translations

sitter added a comment. Seems a bit meh to have a verbatim copy of the auto generated functions. Perhaps it'd be better to add an option to the ECM generator to export a loader function for use in plugins? Then we could just call that from the plugin init instead of having to copy it.

D25986: Resize file dialog window before size restore

ngraham added a comment. Could this go on the stable branch? REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D25986 To: davidedmundson, #plasma, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D25986: Resize file dialog window before size restore

This revision was automatically updated to reflect the committed changes. Closed by commit R135:2e9f96847432: Resize file dialog window before size restore (authored by davidedmundson). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D25989: Don't build and install app templates on android

nicolasfella added inline comments. INLINE COMMENTS > CMakeLists.txt:123 > add_subdirectory(src) > -add_subdirectory(templates) > +if (NOT CMAKE_SYSTEM_NAME STREQUAL "Android") > +add_subdirectory(templates) if(ANDROID) is enough REPOSITORY R169 Kirigami REVISION DETAIL

D25989: Don't build and install app templates on android

nicolasfella added inline comments. INLINE COMMENTS > nicolasfella wrote in CMakeLists.txt:123 > if(ANDROID) is enough if (NOT ANDROID) obviously REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25989 To: jbbgameich, #kirigami, #android Cc: nicolasfella,

D25989: Don't build and install app templates on android

jbbgameich updated this revision to Diff 71517. jbbgameich added a comment. Follow suggestion REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25989?vs=71516=71517 BRANCH android-no-app-templates (branched from master) REVISION DETAIL

D25984: Load translations

broulik added a comment. Sounds good to me lol REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson,

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

Fuchs added a comment. If I remember correctly, the main argument against the launcher was that pinned apps should be pinned and thus not change their location / order, but exactly that would happen with a launcher once you open the app (that, or a duplicate entry in the window list)

D25970: [applet] Make details text fully opaque and normal style

ngraham added a comment. And done in Bluedevil as well with 6f27fd5027a67b52f44222eb5e4a03dbaace4dd7 . REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D25970 To:

D26001: Fix rubberband selection outline position

ndavis created this revision. ndavis added reviewers: VDG, Breeze, Plasma, hpereiradacosta. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY Before this patch, the outline of the rubberband selection control was

D26001: Fix rubberband selection outline position

ndavis added a reviewer: broulik. ndavis added a comment. @broulik Does this fix the problem for you? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26001 To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, broulik Cc: broulik, plasma-devel, LeGast00n,

D26001: Fix rubberband selection outline position

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Fix is legit. Thanks ! I would avoid changing the alpha of the color though because: it makes no difference, and it is unrelated to the issue. Should be a different

D26001: Fix rubberband selection outline position

ndavis added a comment. In D26001#577830 , @hpereiradacosta wrote: > I would avoid changing the alpha of the color though because: it makes no difference, and it is unrelated to the issue. Should be a different commit (which you can do without

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

hpereiradacosta added a comment. As a side remark: did you check how it looks when one selects "text under icon" or "text beside icon" for toolbar button ? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19890 To: hallas, #vdg, #breeze, ngraham, abetts, ndavis Cc:

D26001: Fix rubberband selection outline position

ndavis updated this revision to Diff 71546. ndavis edited the test plan for this revision. ndavis added a comment. Remove opacity change REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26001?vs=71545=71546 BRANCH fix-rubberband (branched from master)

D26001: Fix rubberband selection outline position

This revision was automatically updated to reflect the committed changes. Closed by commit R31:80650e0e873d: Fix rubberband selection outline position (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26001?vs=71547=71548 REVISION DETAIL

D26001: Fix rubberband selection outline position

ndavis updated this revision to Diff 71547. ndavis added a comment. fix code style REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26001?vs=71546=71547 BRANCH fix-rubberband (branched from master) REVISION DETAIL https://phabricator.kde.org/D26001

D26002: [nightcolor] Fix 1-digit minutes representation

iasensio created this revision. iasensio added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. iasensio requested review of this revision. REVISION SUMMARY On automatic time modes, minutes 0-9 were represented only with 1-digit (i.e 8:0 instead

D26002: [KCMs/Night Color] Fix 1-digit minutes representation

This revision was automatically updated to reflect the committed changes. Closed by commit R119:275195373cf1: [KCMs/Night Color] Fix 1-digit minutes representation (authored by iasensio). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25998: [Panel] Use open/closed grabby hand to communicate that panel widgets are draggable

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3044e078458b: [Panel] Use open/closed grabby hand to communicate that panel widgets are… (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 256 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/256/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 14 Dec 2019 23:02:01 + Build duration: 4 min 5 sec and counting CONSOLE OUTPUT

D25976: Use a default non-administrator user Type for new users in model

meven updated this revision to Diff 71567. meven added a comment. Set always a default value for role Administrator in m_newUserData REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25976?vs=71489=71567 BRANCH master REVISION DETAIL

D25976: Use a default non-administrator user Type for new users in model

meven updated this revision to Diff 71568. meven added a comment. Code simplification REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25976?vs=71567=71568 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25976 AFFECTED FILES

D25976: Use a default non-administrator user Type for new users in model

meven added a comment. In D25976#577353 , @ngraham wrote: > Thanks Méven! This fixes the case of creating a non-admin user. However while testing it, I found a regression from D25439 : when I create an admin

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 SUSEQt5.12 - Build # 251 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20SUSEQt5.12/251/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Sat, 14 Dec 2019 23:02:01 + Build duration: 3 min 27 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 FreeBSDQt5.13 - Build # 121 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20FreeBSDQt5.13/121/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Dec 2019 23:02:01 + Build duration: 2 min 49 sec and counting CONSOLE

D25952: [applets/taskmanager] Keep tooltip open when clicking on a thumbnail

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D25952 To: ngraham, #plasma, #vdg, hein, ndavis Cc: ndavis, plasma-devel, LeGast00n,

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ndavis added a comment. In D19890#577833 , @hpereiradacosta wrote: > As a side remark: did you check how it looks when one selects "text under icon" or "text beside icon" for toolbar button ? There is no problem with text, even if you

D25971: Use text color for "No preview image" text

This revision was automatically updated to reflect the committed changes. Closed by commit R123:7e13183d044b: Use text color for No preview image text (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE

D23876: [applets/kickoff] Tweak padding for lists

filipf abandoned this revision. filipf added a comment. Don't want to go through with this anymore because I've had a look at other views and they always sharply cut off content horizontally. For example: F7818671: image.png REPOSITORY R119

D25584: [TabBar] Add a border property

filipf added a comment. Ping, anyone know if we can just delete this Rectangle I called "frame"? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D25584 To: filipf, #plasma, #vdg, ngraham, broulik Cc: mart, ahiemstra, broulik, ngraham,

D25584: [TabBar] Add a border property

ngraham added a comment. Well, there's a use case for a tab bar with a line below the tabs, but not a full frame. See for example tabs in Dolphin, Konsole, and Okular. I guess the question is whether it makes sense to have the tab bar draw the line itself. REPOSITORY R858 Qt Quick

D25967: Emit panelTakesFocus for other plamsashell types

apol added a comment. I'm not sure that I'm misunderstanding, does this mean that notifications might steal focus? REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D25967 To: davidedmundson, #plasma Cc: apol, plasma-devel,

D25992: [Wizard] Allow choosing device by double click

broulik created this revision. broulik added reviewers: Plasma, drosca, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Instead of having to select one and clicking "Next" TEST PLAN Clicked New device,

D25993: Use KQuickCharts to render notification timeout as a circular progress bar

ahiemstra created this revision. ahiemstra added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This uses the new KQuickCharts framework to render the notification timeout bar as

D25992: [Wizard] Allow choosing device by double click

ngraham added a comment. Is there anything you can do with an item here other than selecting it? If not, then we should just always choose by single-click. Double-click only makes sense for items that have a distinct selection state that lets you do more things with the item (or when using

D25992: [Wizard] Allow choosing device by double click

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. True enough. This is for sure a nice improvement. I always appreciate it when double-click is a shortcut for "select this thing and the open/apply it." REPOSITORY R97 Bluedevil

D25945: Sync dark theme preference for GTK3 applications

GB_2 added a comment. Works perfectly fine for me without waiting. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D25945 To: gikari, apol, cblack, broulik, #vdg Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen,

D25992: [Wizard] Allow choosing device by double click

broulik added a comment. I think you can't. It is potentially a long list, so not sure if just clicking it should advance the list, since it is clearly a "wizard" pattern page. If it were a bunch of "command links" it would be obvious that clicking a single item would advance the wizard.

D25945: Sync dark theme preference for GTK3 applications

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. Code looks fine to me. For flatpaks not respecting the setting preference, have you checked that the dark theme variant is installed? f-d-o runtime doesn't offer an Adwaita-dark stub,

D25670: Synchronize decorations buttons order in GTK headerbars

GB_2 added a comment. Works great! REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D25670 To: gikari, #vdg, cblack, #plasma Cc: GB_2, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin,

D25991: [KFilePlacesModel] Fix supported scheme check for devices

bruns added inline comments. INLINE COMMENTS > kfileplacesmodel.cpp:758 > +KFilePlacesItem *item = nullptr; > +if (deviceAvailable) { > +item = new KFilePlacesItem(bookmarkManager, > bookmark.address(), udi); you have dropped the

D25993: Use KQuickCharts to render notification timeout as a circular progress bar

ahiemstra updated this revision to Diff 71533. ahiemstra added a comment. - Remove limiting to just showing the last 10 seconds - Replace ToolButton IconItem with custom to fix alignment REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D25993: Use KQuickCharts to render notification timeout as a circular progress bar

ngraham added a comment. Yay, the alignment is perfect now. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25993 To: ahiemstra, #plasma, broulik Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D25993: Use KQuickCharts to render notification timeout as a circular progress bar

ngraham added inline comments. INLINE COMMENTS > NotificationHeader.qml:220 > + > +opacity: notificationHeading.remainingTime > 0 && > notificationHeading.remainingTime < notificationHeading.timeout > +Behavior on opacity { explicitly set to 0 and 1

D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme

ngraham added a comment. Never mind, I decided to submit it: D25999 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25785 To: filipf, #plasma, #vdg Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D25947: Add applet for controlling Night Color

zzag updated this revision to Diff 71537. zzag added a comment. Nate's suggestion. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25947?vs=71479=71537 BRANCH nightcolor-applet REVISION DETAIL https://phabricator.kde.org/D25947 AFFECTED FILES

D25993: Use KQuickCharts to render notification timeout as a circular progress bar

ahiemstra updated this revision to Diff 71539. ahiemstra added a comment. - Explicitly set opacity REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25993?vs=71534=71539 BRANCH circular_timeout REVISION DETAIL https://phabricator.kde.org/D25993

D25993: Use KQuickCharts to render notification timeout as a circular progress bar

broulik accepted this revision. broulik added a comment. Lovely REPOSITORY R120 Plasma Workspace BRANCH circular_timeout REVISION DETAIL https://phabricator.kde.org/D25993 To: ahiemstra, #plasma, broulik, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25993: Use KQuickCharts to render notification timeout as a circular progress bar

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Luuurvley! REPOSITORY R120 Plasma Workspace BRANCH circular_timeout REVISION DETAIL https://phabricator.kde.org/D25993 To: ahiemstra, #plasma, broulik, ngraham Cc: ngraham,

D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme

filipf updated this revision to Diff 71542. filipf added a comment. - Use grid delegate subtitle to state "Follows color scheme" - Consequently remove the icon tooltip that said the same REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25993: Use KQuickCharts to render notification timeout as a circular progress bar

ngraham added a comment. So lovely! Because the layout respects the font metrics, aligning it perfectly within the close button might be a bit of a bear though. I'm using Ubuntu 11 as my font and I see this: F7818159: Screenshot_20191214_170729.png

D25998: [Panel] Use open/closed grabby hand to communicate that panel widgets are draggable

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Improve the visual hints that widgets are draggable while in panel edit mode. Needed to

D25993: Use KQuickCharts to render notification timeout as a circular progress bar

ahiemstra updated this revision to Diff 71534. ahiemstra added a comment. - Re-add hiding behaviour on mouse over REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25993?vs=71533=71534 BRANCH circular_timeout REVISION DETAIL

D25945: Sync dark theme preference for GTK3 applications

gikari added a comment. In D25945#577677 , @cblack wrote: > For flatpaks not respecting the setting preference, have you checked that the dark theme variant is installed? Yes, I have installed the theme. But after changing the value in

D25947: Add applet for controlling Night Color

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. UI and functionality seem spot-on to me! REPOSITORY R114 Plasma Addons BRANCH nightcolor-applet REVISION DETAIL https://phabricator.kde.org/D25947 To: zzag, #plasma, #vdg,

D25991: [KFilePlacesModel] Fix supported scheme check for devices

broulik added inline comments. INLINE COMMENTS > bruns wrote in kfileplacesmodel.cpp:758 > you have dropped the `allowedHere` check. Probably just `if (!allowedHere) > continue`. > > And for reasons unknown to me, `tags:` is not filtered per app - move the > allowedHere check to the very