D26271: [Applet]Update layout based on T10470

gvgeo updated this revision to Diff 73238. gvgeo added a comment. Separate bug fixes. Change defaultButton visibility Change defaultButton's RowLayout height REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26271?vs=72914=73238 BRANCH

D26256: [Applet] Make 'raise maximum volume' global

gvgeo updated this revision to Diff 73239. gvgeo added a comment. rebase REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26256?vs=72915=73239 BRANCH raise (branched from master) REVISION DETAIL https://phabricator.kde.org/D26256

D26572: Always render checkbox/radiobutton background

ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY QQC2/Kirigami checkboxes and radio buttons can turn invisible when rendered over a selected

D25449: Start of the new Formats KCM

tcanabrava updated this revision to Diff 73236. tcanabrava added a comment. - Fix esc and click outside to close the overlay REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25449?vs=73209=73236 BRANCH arcpatch-D25449 REVISION DETAIL

D26574: [Applet]Hide hamburger menu when empty

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice. REPOSITORY R115 Plasma Audio Volume Applet BRANCH ports (branched from master) REVISION DETAIL https://phabricator.kde.org/D26574 To: gvgeo, #vdg, #plasma, drosca, ngraham

D26565: KCM/Component Revamp email config

ngraham added a comment. In D26565#591542 , @meven wrote: > Do you mean, we should drop command line text fields, like we have in the terminal and browser section ? Only comboxbox ? We don't want to lose this feature, but the text field

D26530: ScrollView: Do not overlay scrollbars over contents

ngraham added a comment. In D26530#591622 , @kmaterka wrote: > Example when current way looks bad: D22176 . We can live with that and add margins/padding when needed. Or not :) > > - Old-fashioned

D26571: Provide information about how we are using KUserFeedback

apol created this revision. apol added reviewers: Plasma, vkrause. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Implements --feedback See 26569 TEST PLAN Used the KCM happily REPOSITORY R134 Discover

D26570: Improve Plasma user feedback introspection

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Before loading the view, query all plasma processes and show why they're using KUserFeedback.

D26530: ScrollView: Do not overlay scrollbars over contents

kmaterka added a comment. Example when current way looks bad: D22176 . We can live with that and add margins/padding when needed. Or not :) - Old-fashioned scrollbars are also bad, they look old and sometimes ugly (especially when list has different

D26548: [Applet] Fix empty space and give correct size

This revision was automatically updated to reflect the committed changes. Closed by commit R115:f6a5ea079c39: [Applet] Fix empty space and give correct size (authored by gvgeo, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D26572: Always render checkbox/radiobutton background

ndavis updated this revision to Diff 73234. ndavis added a comment. remove .clangd/ REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26572?vs=73231=73234 BRANCH checkbox-radiobutton-background (branched from master) REVISION DETAIL

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

ngraham added a comment. In D26544#591418 , @leinir wrote: > Right, the functionality would all still exist (that is, install/uninstall/update/whatnot would function just fine), what would happen without the dependent patch is that the views

D26574: [Applet]Hide hamburger menu when empty

gvgeo added a comment. KCM is in a state of confusion. Doesn't see the port change from lock prevention, and shows the port that was selected(unavailable). While the volume and mute affect the active port. If these patches ever get accepted, can see at a later time this part. REPOSITORY

D26271: [Applet]Update layout based on T10470

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I'm good with this now as an initial implementation of the mockup. However we're a bit close to the Plasma 5.18 tagging date (January 16th). My gut instinct is to land these early in the

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

bcooksley added a comment. In the case of three Frameworks (namely plasma-framework, kwayland and kwindowsystem) I have on file requests from the Plasma and KWin developers informing me that their software does indeed require latest HEAD (with no delay) of those particular frameworks, hence

D25449: Start of the new Formats KCM

ngraham added a comment. Still needs more overlaySheet :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25449 To: tcanabrava, ervin, #vdg, #plasma, mart, ngraham Cc: mart, ngraham, broulik, ervin, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D26418: [Applet]Add global mute function

gvgeo updated this revision to Diff 73240. gvgeo added a comment. Removal of trailing space REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26418?vs=72916=73240 BRANCH mute (branched from master) REVISION DETAIL

D26574: [Applet]Hide hamburger menu when empty

gvgeo created this revision. gvgeo added reviewers: VDG, Plasma, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Don't show devices/applications hamburger menu when there are no options. Hide

D26570: Improve Plasma user feedback introspection

apol added a comment. F7876596: photo_2020-01-10_20-09-45.jpg REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26570 To: apol, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas,

D26271: [Applet]Update layout based on T10470

gvgeo added a comment. Can't include an untested patch because we are in a hurry. To clarify my comment's D26574#591702 part "If these patches ever get accepted". I wasn't aware of the release schedule, and my doubts are about code

D25925: Mark applications that play audio, for all task icon sizes

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0490f10187ab: Mark applications that play audio, for all task icon sizes (authored by gvgeo, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25449: Start of the new Formats KCM

anthonyfieroni added inline comments. INLINE COMMENTS > kcm.cpp:39 > +{ > +qmlRegisterType(); > +qmlRegisterUncreatableType("org.internal.kcm.formats", 1, > 0, "LocaleModel", QStringLiteral("Model to access the data")); https://doc.qt.io/qt-5/qqmlengine-obsolete.html > kcm.cpp:41 > +

D25449: Start of the new Formats KCM

mart added a comment. tested it: - i have al horizontal scroll of the left column that should never happen: F7874187: Screenshot_20200110_112412.png - opening it in kcmshell tries to resize the window to 100% height of the screen - it

D26531: [Wallpaper] Show author as subtitle in configuration

mart added a comment. In D26531#590729 , @broulik wrote: > > However I see a problem with the delegate cell size: > > That's unrelated and something I would have expected was tested when this feature was added. can you look into

D25449: Start of the new Formats KCM

tcanabrava updated this revision to Diff 73188. tcanabrava marked an inline comment as done. tcanabrava added a comment. - Remove code dependant on Qt 5.14 - Mark that we will use some text in the future - Remove uneeded virtual - Update role names to something more explicit -

D26506: [KDED KCM] Rewrite as KDeclarative ScrollViewKCM

mart accepted this revision as: mart. mart added a comment. This revision is now accepted and ready to land. Code wise is ok I think the checkbox for exabling/disabling the service is fine usability wise REPOSITORY R119 Plasma Desktop REVISION DETAIL

D25681: Get icon size from QStyle

victorr added a comment. This application, the master branch, has not been working for a long time. It just crashes when you try to create an application launch button. alex@asus:~$ kmenuedit kf5.kservice.services: The desktop entry file

D26354: Introduce ActionRow widget

mart added a comment. In D26354#590841 , @ngraham wrote: > In D26354#590815 , @mart wrote: > > > SwipeListItem should just trigger when there is only one action, really (and that one doesn't

D25449: Start of the new Formats KCM

tcanabrava marked 23 inline comments as done. tcanabrava added inline comments. INLINE COMMENTS > broulik wrote in kcm.cpp:37 > You're not importing this anywhere, and this still works? Makes me wonder why > Qt went through the trouble of introducing this when it makes no diference > over

D26525: Fix wallpaper destination path

mart added inline comments. INLINE COMMENTS > image.cpp:554 > + > +if (wallpaperDir.mkpath(wallpaperDir.absolutePath()) && > !url.fileName().isEmpty()) { > +KIO::FileCopyJob *job = KIO::file_copy(url, > QUrl::fromLocalFile(wallpaperPath), -1, KIO::HideProgressInfo | >

D26544: [WIP] Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir planned changes to this revision. leinir added a comment. i'm working on more of this (main reason for the status change, but thank you!), and there's a patch for KNS that wants to go in first (of course) - it's runtime, so it won't break the CI for this to go in first, but... still

D25449: Start of the new Formats KCM

tcanabrava added a comment. (Ignore my broken Theme - i'm trying to discover what's happening.) F7874644: Screenshot_20200110_121232.PNG F7874646: Screenshot_20200110_121252.PNG REPOSITORY R119 Plasma

D25449: Start of the new Formats KCM

mart added a comment. design wise i would go this way: left column: A FormLayout with labels and buttons aligned in the usual standard centered way right Column: Either an overlaysheet that opens over everything like the translations kcm, or if you want to keep the drag and drop

D26530: ScrollView: Do not overlay scrollbars over contents

mart added a comment. In D26530#590657 , @ngraham wrote: > It might be worth comparing with what other platforms do: > > - Windows: old apps use real separated always-visible scrollbars; new apps use real overlay scrollbars that overlap

D26037: feat(kded): add orientation sensor

romangg updated this revision to Diff 73185. romangg added a comment. - Fix seg fault on orientation sensor REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26037?vs=73148=73185 BRANCH orientation-sensor REVISION DETAIL

D25681: Get icon size from QStyle

davidedmundson added a comment. Sounds like 415699 which is unrelated to this change REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D25681 To: davidre, #plasma, davidedmundson Cc: victorr, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, davidre,

D26538: Don't anchor AbstractApplicationHeader blindly

This revision was automatically updated to reflect the committed changes. Closed by commit R169:e8fef85c138c: Dont anchor AbstractApplicationHeader blindly (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26538?vs=73111=73189 REVISION

D26529: [wallpapers/image] Put spinbox labels inside the spinboxes

This revision was automatically updated to reflect the committed changes. Closed by commit R120:276eac85cf80: [wallpapers/image] Put spinbox labels inside the spinboxes (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26528: [wallpapers/image] Add placeholder labels when wallpaper lists are empty

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b79f9967a5e9: [wallpapers/image] Add placeholder labels when wallpaper lists are empty (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26526: [Colors KCM] Correctly report whether saving is needed

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2cac05134dc0: [Colors KCM] Correctly report whether saving is needed (authored by davidre). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25681: Get icon size from QStyle

victorr added a comment. I'm sorry I wrote the wrong way. I saw this problem three weeks ago. I hoped that she would be quickly fixed. Version 5.17.90 is coming out in a week, but the problem is still present. I wanted to draw attention of one of the developers to this. REPOSITORY

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

ngraham added a comment. Since D26543 is listed as a dependent, but it's in Frameworks, and Plasma 5.18 is going to depend on Frameworks 5.66, but 5.66 has already been tagged, that means that this can't land in 5.18, so we'll ship 5.18 with only the

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir added a comment. In D26544#591398 , @ngraham wrote: > Since D26543 is listed as a dependent, but it's in Frameworks, and Plasma 5.18 is going to depend on Frameworks 5.66, but 5.66 has already been

D26354: Introduce ActionRow widget

ngraham added a comment. In D26354#591264 , @mart wrote: > needed probably a graphical way to make it obvious that this will trigger on release rather than just showing the action Yes, exactly REPOSITORY R169 Kirigami REVISION DETAIL

D26530: ScrollView: Do not overlay scrollbars over contents

ngraham added a comment. All the various pieces of software that use fake overlay-style scrollbars by simply making the track disappear and blend in with the background (e.g. Konsole, Dolphin, Plasma) appear to have successfully fooled everyone into believing that they're real overlay-style

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

davidedmundson added inline comments. INLINE COMMENTS > main.cpp:254 > > -void IconModule::getNewStuff(QQuickItem *ctx) > +void IconModule::ghnsEntriesChanged(const QQmlListReference ) > { FWIW, there is an alternative approach that we do in plasma-workspace

D26525: Fix wallpaper destination path

trmdi added inline comments. INLINE COMMENTS > mart wrote in image.cpp:554 > this is for first run when ~/.local/share/wallpapers isn't there yet? This is to check if the directory is available before copying, otherwise FileCopyJob would fail. REPOSITORY R120 Plasma Workspace REVISION

D26544: [WIP] Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir updated this revision to Diff 73190. leinir added a comment. This revision is now accepted and ready to land. - Only try and work on newly installed themes - Port the cursortheme kcm to KNSQuick - Port the plasma theme kcm's ghns support to KNSQuick - Port the Icons kcm to

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir requested review of this revision. leinir added a comment. Right, that's the lot of the qtquick kcms in plasma-desktop! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26544 To: leinir, mart Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D26510: [wallpapers/image] Disambiguate identical folder names in paths list

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c3242c1dc1da: [wallpapers/image] Disambiguate identical folder names in paths list (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26510?vs=73022=73194#toc REPOSITORY

D26522: [Colors KCM] Only move to next scheme if the selected one is marked for deletion

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fc1449991459: [Colors KCM] Only move to next scheme if the selected one is marked for… (authored by davidre). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26483: [wallpapers/image] Add default XDG wallpaper locations for slideshow

ngraham added a comment. Dependent patches have landed, is this okay now? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26483 To: ngraham, #plasma, #vdg, ndavis, davidedmundson Cc: davidre, broulik, davidedmundson, ndavis, plasma-devel, LeGast00n,

D25449: Start of the new Formats KCM

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Got this tested. I'm sorry to say that I really really really really don't like the pop-out drawer-style list at all. It's unlike the way we do pop-up lists anywhere else,

D26530: ScrollView: Do not overlay scrollbars over contents

ahiemstra added a comment. Also note that the intention is to have the scrollbar background match the view background. In the example case I didn't bother with any view specific styling, so it looks a little more ugly than necessary. This is what it would look like with fixed background

D26559: KCM/Component Update syscoca cache and protocols when default email client changes

meven created this revision. meven added reviewers: davidedmundson, ervin, Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY The xdg mime cache of default apps and ksyscoco was not update when the

D26530: ScrollView: Do not overlay scrollbars over contents

ngraham added a comment. Yeah, I really dislike the fully-disappearing scrollbars too, for the same reason. I also like the GNOME approach when overlay-style scrollbars absolutely have to be used. That seems like a genuine innovation. However I've found myself surprised by the volume of

D26525: Fix wallpaper destination path

trmdi added inline comments. INLINE COMMENTS > mart wrote in image.cpp:555 > I would prefer it to ask before owerwriting Do I need to modify this or just land it now? REPOSITORY R120 Plasma Workspace BRANCH fix-wallpaper REVISION DETAIL https://phabricator.kde.org/D26525 To: trmdi,

D26521: KCM/Component Make the email config default button work

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6e813bafa8c5: KCM/Component Make the email config default button work (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26565: KCM/Component Revamp email config

meven updated this revision to Diff 73212. meven added a comment. minor change REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26565?vs=73211=73212 BRANCH email-config REVISION DETAIL https://phabricator.kde.org/D26565 AFFECTED FILES

D26566: Fix layout for the reviews sheet

mart created this revision. mart added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY - the main contentitem of a sheet should have *always* an explicit implicitWidth - never use

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

crossi updated this revision to Diff 73215. crossi added a comment. Add API documentation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26082?vs=71783=73215 REVISION DETAIL https://phabricator.kde.org/D26082 AFFECTED FILES

D26047: Expose KConfig settings to allow registration in KCM Notification

crossi updated this revision to Diff 73214. crossi added a comment. Add API documentation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26047?vs=71676=73214 REVISION DETAIL https://phabricator.kde.org/D26047 AFFECTED FILES

D26525: Fix wallpaper destination path

trmdi updated this revision to Diff 73217. trmdi added a comment. - Switch from FileCopyJob to CopyJob to allow showing file overwrite dialog REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26525?vs=73115=73217 BRANCH fix-wallpaper (branched

D26525: Fix wallpaper destination path

trmdi added a comment. @mart Are you ok with this now ? REPOSITORY R120 Plasma Workspace BRANCH fix-wallpaper (branched from master) REVISION DETAIL https://phabricator.kde.org/D26525 To: trmdi, #plasma, mart Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D25449: Start of the new Formats KCM

tcanabrava updated this revision to Diff 73209. tcanabrava added a comment. - Fix some keyboard whoes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25449?vs=73188=73209 BRANCH arcpatch-D25449 REVISION DETAIL https://phabricator.kde.org/D25449

D26565: KCM/Component Revamp email config

meven created this revision. meven added reviewers: ngraham, ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Simplify UI: - Select option in the available email clients REPOSITORY R119

D26559: KCM/Component Update syscoca cache and protocols when default email client changes

meven abandoned this revision. meven added a comment. in favor of D26565 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26559 To: meven, davidedmundson, ervin, #plasma, ngraham Cc: plasma-devel, LeGast00n,

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

crossi updated this revision to Diff 73216. crossi added a comment. space REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26082?vs=73215=73216 REVISION DETAIL https://phabricator.kde.org/D26082 AFFECTED FILES

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

meven accepted this revision. meven added a comment. That seems good to me. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26082 To: crossi, #plasma, #frameworks, ervin, mart, davidedmundson, broulik, meven Cc: plasma-devel, meven, bport, LeGast00n,

D26566: Fix layout for the reviews sheet

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice, thanks! REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D26566 To: mart, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel,

D26565: KCM/Component Revamp email config

ngraham added a comment. Very nice, I think this is the way to go, not only for this component but for the others too. We should drop the group box too because with only one item, there's no longer anything to group! :) We can just switch it out for a label to the left of the combobox.

D26565: KCM/Component Revamp email config

meven added a comment. In D26565#591535 , @ngraham wrote: > Very nice, I think this is the way to go, not only for this component but for the others too. We should drop the group box too because with only one item, there's no longer anything to