Review Request: some cppcheck fixes

/main.cpp 2f2bacc applets/mediaplayer/dbus/rootdbushandler.cpp 2dd2874 containments/groupingdesktop/lib/groupexplorer/groupicon.cpp 120ead3 Diff: http://git.reviewboard.kde.org/r/105190/diff/ Testing --- I've using this patch too much time (too busy). Thanks, Jaime Torres

Re: Review Request: miscelaneous things for kdelibs/plasma

Thanks, Jaime Torres Amate ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: missing initializations in plasma

/declarativewidget.cpp 93d0438 Diff: http://git.reviewboard.kde.org/r/106781/diff/ Testing --- Thanks, Jaime Torres Amate ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: do not split the year in the clock tip

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102621/ --- Review request for Plasma. Summary --- The first version of this patc

Re: Review Request: do not split the year in the clock tip

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102621/ --- (Updated Sept. 15, 2011, 3:41 p.m.) Review request for Plasma. Changes -

Re: Review Request: do not split the year in the clock tip

/Golden_ratio) - Jaime Torres --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102621/#review6545 --- On Sept. 15, 2011, 3:41

Re: Review Request: do not split the year in the clock tip

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102621/ --- (Updated Sept. 21, 2011, 7:57 p.m.) Review request for Plasma. Changes -

Review Request: some fixes for cppcheck warnings

netbook/containments/sal/stripwidget.cpp cded4bc plasma/netbook/shell/plasmaapp.cpp b9d97cc Diff: http://git.reviewboard.kde.org/r/103324/diff/diff Testing --- the solarsystem change has been playing nice here one month without crashes. Thanks,

D10342: From 100% plasma cpu usage to normal when using vivaldi

jtamate updated this revision to Diff 36978. jtamate retitled this revision from "From 1.03% to 0.08% cpu usage moving 50.000 files" to "From 100% plasma cpu usage to normal when using vivaldi". jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate ad

D10342: From 100% plasma cpu usage to normal when using vivaldi

jtamate added a comment. In D10342#286023 , @hein wrote: > This patch doesn't make any sense. It's setting up a cache for something computed from data that's subject to change, and it's never evicting it when that data changes. To make i

D19500: [KDirModel] Fix job urls change signal connection

jtamate added a comment. +1. Just out of curiosity, Did you notice the problem because something was missing in execution? Unfortunately, neither the compiler nor I didn't noticed it. :-( REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19500 To: broulik,

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

jtamate created this revision. jtamate added a reviewer: Plasma: Workspaces. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. jtamate requested review of this revision. REVISION SUMMARY store the const iterator returned, not the address.

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

jtamate edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10342 To: jtamate, #plasma_workspaces Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

jtamate added a comment. In https://phabricator.kde.org/D10342#201979, @broulik wrote: > Interesting. I'm curious as to why it calls those functions that often in the first place while copying files. My guess is that it is used to fill the task completion in the task bar, but is

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

jtamate updated this revision to Diff 26692. jtamate edited the test plan for this revision. jtamate added a comment. What I've noticed is that with the first version of the patch, every time I changed konsole tabs, saved a file in kate, the appDataFromUrl (missed the cache) was called. Af

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

jtamate updated this revision to Diff 26937. jtamate edited the test plan for this revision. jtamate added a comment. In https://phabricator.kde.org/D9840 I noticed a high i/o and cpu usage when using the vivaldi browser, opening 10 tabs just caused a 40% cpu usage. Now, opening 10 tabs or

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

jtamate added a comment. In D10342#204465 , @jtamate wrote: > In https://phabricator.kde.org/D9840 I noticed a high i/o and cpu usage > when using the vivaldi browser, opening 10 tabs just caused a 40% cpu > usage. Now, opening 10 tabs or mo

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

jtamate updated this revision to Diff 27177. jtamate added a comment. - From 1.03% to 0.08% cpu usage moving 50.000 files fixed mwolf comment REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10342?vs=26937&id=27177 BRANCH vivaldi (branched fr

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

jtamate marked 2 inline comments as done. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10342 To: jtamate, #plasma_workspaces Cc: mwolff, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

jtamate edited the summary of this revision. jtamate edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10342 To: jtamate, #plasma_workspaces, hein Cc: mwolff, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohame

D10531: [QmlObjectIncubationController] Don't call incubate() while already incubating

jtamate added a comment. Also measured scientifically accurate with a stopwatch 2:34 minutes in callgrind wihtout the patch. I refs: 10,827,698,978 2:20 minutes in callgrind with the patch.I refs: 10,668,473,812 +1 REPOSITORY R242 Plasma Framework (Library) RE

D10538: Micro-optimise screenpool event filter by caching xcb extension offset

jtamate added inline comments. INLINE COMMENTS > broulik wrote in screenpool.cpp:44 > Needs x11 guard Shouldn't it be a #if HAVE_X11? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10538 To: davidedmundson, #plasma, broulik Cc: jtamate, mart, broulik, plasma

D10538: Micro-optimise screenpool event filter by caching xcb extension offset

jtamate accepted this revision. jtamate added a comment. F5713055: plasmashell_screenpool_after.png Even the number of calls registered are less, now most of the time is spent doing the eventType != "xcb_generic_event_t". REPOSITORY R120 Plasma W

D10627: Reduce plasma lock up time to almost nothing

jtamate created this revision. jtamate added reviewers: Frameworks, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. jtamate requested review of this revision. REVISION SUMMARY CCBUG: 358231 CCBUG: 342056 Even the icon with the

D10627: Reduce plasma lock up time to almost nothing

jtamate added a comment. May I do the other 2 commits without another revision? REPOSITORY R120 Plasma Workspace BRANCH polling (branched from master) REVISION DETAIL https://phabricator.kde.org/D10627 To: jtamate, #frameworks, #plasma, davidedmundson Cc: davidedmundson, plasma-devel,

D10629: Avoid a double emitResult()

jtamate created this revision. jtamate added reviewers: Frameworks, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. jtamate requested review of this revision. REVISION SUMMARY ServiceJob::setResult already does a emitResult. Disc

D10627: Reduce plasmashell frozen time to almost nothing

jtamate retitled this revision from "Reduce plasma lock up time to almost nothing" to "Reduce plasmashell frozen time to almost nothing". jtamate edited the summary of this revision. jtamate edited the test plan for this revision. REPOSITORY R120 Plasma Workspace BRANCH polling (branched fro

D10629: Avoid a double emitResult()

jtamate updated this revision to Diff 27523. jtamate added a comment. I haven't found more instances of setResult followed by emitResult. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10629?vs=27456&id=27523 REVISION DETAIL https://phabricator.

D10629: Avoid a double emitResult()

jtamate added a comment. In D10629#209358 , @broulik wrote: > I did a objdump -d to be sure: > dataengines/places/setupdevicejob.cpp setError is from KJob and it only sets a member value (d->error = errorCode;) > dataengines

D10629: Avoid a double emitResult()

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4b68374192ac: Avoid a double emitResult() (authored by jtamate). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10629?vs=27523&id=27571 REVISION DETAIL

D10669: Reduce plasmashell frozen time

jtamate created this revision. jtamate added reviewers: Plasma, Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. jtamate requested review of this revision. REVISION SUMMARY Second part of https://phabricator.kde.org/D

D10670: Reduce plasmashell frozen time

jtamate created this revision. jtamate added reviewers: Frameworks, Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. jtamate requested review of this revision. REVISION SUMMARY Third part of https://phabricator.kde.org/D1

D10627: Reduce plasmashell frozen time to almost nothing

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e1fe26f1fc78: Reduce plasmashell frozen time to almost nothing (authored by jtamate). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10627?vs=27453&id=2757

D10670: Reduce plasmashell frozen time

jtamate added a comment. In D10670#209823 , @mwolff wrote: > ok, looking at the reasoning in the other commit: > > - you need to extend the commit message here Will be done. > - you need to provide a comment in the code the clarif

D10670: Reduce plasmashell frozen time

jtamate updated this revision to Diff 27672. jtamate edited the summary of this revision. jtamate added a comment. Updated the summary and added a comment REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10670?vs=27576&id=27672 REVISION DE

D10670: Reduce plasmashell frozen time

jtamate added a comment. In D10670#210702 , @jtamate wrote: > Updated the summary and added a comment ping? I would like to use the same comment and commit message in https://phabricator.kde.org/D10669 REPOSITORY R242 Plasma Framework

D10669: Reduce plasmashell frozen time

This revision was automatically updated to reflect the committed changes. Closed by commit R278:ff6c795dcda7: Reduce plasmashell frozen time (authored by jtamate). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10669?vs=27575&id=29346#toc REPOSITORY R278 KWindowSystem CHANGES SINCE LA

D1231: Add Remote Access interface to KWayland

jtamate added a comment. As I don't see anything related to security in this patch, I have two questions. Could anyone with access to server:port manage the server wayland sessions or just create a new session? The access control should be done in the firewall? REPOSITORY R127 KWay

D10670: Reduce plasmashell frozen time

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:33ddaaa23f6b: Reduce plasmashell frozen time (authored by jtamate). REPOSITORY R242 Plasma Framework (Library) CHAN

D10670: Reduce plasmashell frozen time

jtamate added a comment. In D10670#230938 , @hein wrote: > > This revision was not accepted when it landed; it landed in state Needs Review. > > Weird, David accepted it though? Yes. Shouldn't this be reported as a bug to phabricator?