Re: Review Request 123426: Kickoff is not mounting removable devices and shows Invalid URL

2015-04-19 Thread Konrad Materka
works as expected. File Attachments Use VisualDataModel-modelIndex in openItem https://git.reviewboard.kde.org/media/uploaded/files/2015/04/19/4a0d0c4d-0f76-429b-8c4a-6f9ba9856816__Bug-346002.patch Thanks, Konrad Materka ___ Plasma

Re: Review Request 123426: Kickoff is not mounting removable devices and shows Invalid URL

2015-05-12 Thread Konrad Materka
/media/uploaded/files/2015/04/19/4a0d0c4d-0f76-429b-8c4a-6f9ba9856816__Bug-346002.patch Thanks, Konrad Materka ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123350: Kickoff is not mounting removable devices and shows Invalid URL

2015-04-15 Thread Konrad Materka
/123350/ --- (Updated Kwi 15, 2015, 7:37 rano) Review request for Plasma. Bugs: 346002 https://bugs.kde.org/show_bug.cgi?id=346002 Repository: plasma-desktop Description --- Patch by Konrad Materka adress

D23413: [System Tray] Unified data model for System Tray items

2019-08-24 Thread Konrad Materka
kmaterka added a comment. I spent some time testing it and I hope it is now bug free. I understand it is a big change that brings little value (now), but I'm working on further improvements and wanted to slip work into smaller patches. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D23413: [System Tray] Unified data model for System Tray items

2019-08-24 Thread Konrad Materka
kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Currently there are two different sources of SystemTray items: -

D22176: Rework system tray settings

2019-08-24 Thread Konrad Materka
kmaterka added a comment. @nicolasfella Correct me if I'm wrong. EntryModel is created on the first use and it is populated in the constructor. If user runs application that uses StatusNotifier (for example Skype, Dropbox, Electron apps, any Windows app via Wine, etc) later, it won't be

D22176: Rework system tray settings

2019-08-27 Thread Konrad Materka
kmaterka added a comment. In D22176#519600 , @nicolasfella wrote: > I think QQC1 TableView and the new TableView are quite different things. I had some issues with the QQC1 TableView and my new Model, so I decided to use something else, but I

D23413: [System Tray] Unified data model for System Tray items

2019-08-26 Thread Konrad Materka
kmaterka updated this revision to Diff 64669. kmaterka added a comment. Now the same model is used for: - rendering all items, both Plasmoids and StatusNotifications - "Entries" configuration page That should greatly simplify the https://phabricator.kde.org/D22176 (this is not my

D22176: Rework system tray settings

2019-08-26 Thread Konrad Materka
kmaterka added a comment. @nicolasfella I updated D23413 , now it can be used in configuration entries. Can you check if you can use this? I like the idea of removing "Categories", these are confusing and probably no-one uses them. **Important

D11352: [RFC] Auto ordered systray

2019-09-17 Thread Konrad Materka
kmaterka added a comment. Sorry for interrupting this late in the review. I like the idea of consistent ordering very much, I even planned to implement this myself :) I have few comments: In D11352#227354 , @Pitel wrote: > - [...] remove

D22767: Calculate first clickable point, from the top-left

2019-08-05 Thread Konrad Materka
kmaterka removed a reviewer: Plasma: Workspaces. kmaterka added inline comments. INLINE COMMENTS > davidedmundson wrote in sniproxy.cpp:576 > This point was marked as closed, but not changed. Probably my fault for not > expanding. > > We move the window so that it's at x-clickPoint > The

[System Tray]

2019-08-01 Thread Konrad Materka
almost 20 years. I'm a developer with 10 years of commercial experience, mostly in Java. One commercial project in QML and C++ - Map Downloader on subaru-maps.com. I live in Poland. -- Regards, Konrad Materka

D22804: [System Tray] Do not send ContextMenu signal twice

2019-07-29 Thread Konrad Materka
kmaterka created this revision. kmaterka added a reviewer: Plasma: Workspaces. kmaterka added a project: Plasma: Workspaces. Herald edited projects, added Plasma; removed Plasma: Workspaces. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY

D22804: [System Tray] Do not send ContextMenu signal twice

2019-07-29 Thread Konrad Materka
kmaterka added a comment. This fixes 27b1030756002e91b60ba51483efe9c2c477d16e , which reverts b9af99140365c8c8cf4e3744af7e13b35c35fa18

D22767: Calculate first clickable point, from the top-left

2019-07-29 Thread Konrad Materka
kmaterka updated this revision to Diff 62723. kmaterka marked 3 inline comments as done. kmaterka added a comment. Review changes. Call to the calculateClickPoint is local and on only on mouse click, not on every icon update. CHANGES SINCE LAST UPDATE

D22804: [System Tray] Do not send ContextMenu signal twice

2019-07-29 Thread Konrad Materka
kmaterka added a comment. In D22804#503733 , @broulik wrote: > > Yes, probably onPressed should be handled in PasmoidItem, not in the AbstractItem to avoid this kind of problems. > > Indeed, that would be the best solution. Should

D22804: [System Tray] Do not send ContextMenu signal twice

2019-07-29 Thread Konrad Materka
kmaterka updated this revision to Diff 62738. kmaterka added a comment. I simplified the patch. It moves handling of onPressed to PlasmoidItem. This way we can have context menu when mouse is pressed for plasmoids and on click for SNI. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST

D22804: [System Tray] Do not send ContextMenu signal twice

2019-07-29 Thread Konrad Materka
kmaterka added a comment. @apol SNI applications (including XembedSniProxy) are using StatusNotifierItem.qml, which already has onClick handled for right button. That why we had ContextMenu event's duplicated. @broulik Yes, probably onPressed should be handled in PasmoidItem, not in the

Re: [System Tray]

2019-08-05 Thread Konrad Materka
pon., 5 sie 2019 o 06:55 David Edmundson napisaƂ(a): > On Thu, Aug 1, 2019 at 10:30 AM Konrad Materka wrote: > > > > Hi, > > > > recently I was fixing two bugs related to SystemTray (in review: > > https://phabricator.kde.org/D22804, > > https://phabricat

D22767: Calculate first clickable point, from the top-left

2019-07-26 Thread Konrad Materka
kmaterka created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Wine is using XWindow Shape Extension for transparent tray icons. We need to find first clickable point starting from top-left.

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

2019-11-04 Thread Konrad Materka
kmaterka added a comment. Any chance to get this reviewed? :) REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D24843 To: kmaterka, apol, davidedmundson, #plasma, #frameworks, broulik, nicolasfella Cc: plasma-devel, LeGast00n,

D25223: Avoid side effects during menu initialization

2019-11-08 Thread Konrad Materka
kmaterka updated this revision to Diff 69489. kmaterka added a comment. Final version, ready for review. REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25223?vs=69484=69489 BRANCH master REVISION DETAIL

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

2019-11-08 Thread Konrad Materka
kmaterka added a comment. In D24843#560188 , @kmaterka wrote: > In D24843#560023 , @broulik wrote: > > > This causes menus (mostly submenus) to randomly show up when the SNI is updated, e.g. every

D25223: Avoid side effects during menu initialization

2019-11-08 Thread Konrad Materka
kmaterka created this revision. kmaterka added reviewers: Plasma, Frameworks, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Setting some attributes, like visible, enabled, etc has side effects. Do

D25223: Avoid side effects during menu initialization

2019-11-08 Thread Konrad Materka
kmaterka added a comment. The problem was with: m_menu->setVisible(m_visible); setters/getters should not have side effects or any logic, but this method has. Detached menu stayed as top level window and rendered itself. VLC has a bug, each systray menu update creates new

D25223: Avoid side effects during menu initialization

2019-11-08 Thread Konrad Materka
kmaterka added a comment. Too soon, it is still not finished. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D25223 To: kmaterka, #plasma, #frameworks, broulik Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

2019-11-08 Thread Konrad Materka
kmaterka added a comment. In D24843#560023 , @broulik wrote: > This causes menus (mostly submenus) to randomly show up when the SNI is updated, e.g. every time VLC changes a track I get its "speed (slower, normal, faster)" menu open: >

D25158: [Touchpad applet] Close query dialog on focus loss

2019-11-05 Thread Konrad Materka
This revision was automatically updated to reflect the committed changes. Closed by commit R119:76d9233bd932: [Touchpad applet] Close query dialog on focus loss (authored by kmaterka). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25158?vs=69324=69326

D25223: Avoid side effects during menu initialization

2019-11-18 Thread Konrad Materka
This revision was automatically updated to reflect the committed changes. Closed by commit R135:3c78453b: Avoid side effects during menu initialization (authored by kmaterka). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D25223: Avoid side effects during menu initialization

2019-11-12 Thread Konrad Materka
kmaterka added a comment. In D25223#561570 , @davidedmundson wrote: > I had this. I abandoned because we ended up forking some special wayland stuff in our DBus menu, so would always want our implementation. > > >

D25223: Avoid side effects during menu initialization

2019-11-12 Thread Konrad Materka
kmaterka marked an inline comment as done. kmaterka added a comment. Off-topic idea: This QPA integration uses KStatusNotifierItem, which then translates it to DBus. Wouldn't it be better to talk to DBus directly? From the other side, this may be a duplication of work... Was the idea

D25223: Avoid side effects during menu initialization

2019-11-12 Thread Konrad Materka
kmaterka marked an inline comment as done. kmaterka added a comment. I will send fixes in 5 minutes INLINE COMMENTS > broulik wrote in kdeplatformsystemtrayicon.cpp:33 > Is this explicit initialization neccessary? Not mandatory, works without this. I just wanted to be... explicit.

D25223: Avoid side effects during menu initialization

2019-11-12 Thread Konrad Materka
kmaterka updated this revision to Diff 69634. kmaterka marked an inline comment as done. kmaterka added a comment. QVariant related changes suggested in comments REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D23413: [System Tray] Unified data model for System Tray items

2019-11-15 Thread Konrad Materka
kmaterka updated this revision to Diff 69821. kmaterka edited the test plan for this revision. kmaterka added a comment. Rebased, but I need to test it REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23413?vs=64669=69821 BRANCH master REVISION

D23413: [System Tray] Unified data model for System Tray items

2019-11-15 Thread Konrad Materka
kmaterka updated this revision to Diff 69823. kmaterka added a comment. Fixed one mistake during rebase. I checked it, seems it is still working. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23413?vs=69821=69823 BRANCH master REVISION DETAIL

D23413: [System Tray] Unified data model for System Tray items

2019-11-16 Thread Konrad Materka
kmaterka marked an inline comment as done. kmaterka added inline comments. INLINE COMMENTS > anthonyfieroni wrote in PlasmoidItem.qml:85-87 > Remove that code as well. Done REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23413 To: kmaterka, #plasma, broulik

D23413: [System Tray] Unified data model for System Tray items

2019-11-16 Thread Konrad Materka
kmaterka updated this revision to Diff 69832. kmaterka marked an inline comment as done. kmaterka added a comment. Small code review change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23413?vs=69823=69832 BRANCH master REVISION DETAIL

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

2019-11-05 Thread Konrad Materka
This revision was automatically updated to reflect the committed changes. Closed by commit R135:bc1c85144adb: [KDEPlatformSystemTrayIcon] Recreate deleted menu (authored by kmaterka). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D24865: [SystemTray] Support for AttentionIcon

2019-11-05 Thread Konrad Materka
kmaterka marked an inline comment as done. kmaterka added a comment. In D24865#558933 , @davidedmundson wrote: > Alternative below. IMHO it might be cleaner. > > Otherwise, this is fine. I will check this. REPOSITORY R120 Plasma

D24865: [SystemTray] Support for AttentionIcon

2019-11-05 Thread Konrad Materka
kmaterka updated this revision to Diff 69321. kmaterka marked an inline comment as done. kmaterka added a comment. Simply the check, thanks for a tip! REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24865?vs=68598=69321 BRANCH master REVISION

D25158: [Touchpad applet] Close query dialog on focus loss

2019-11-05 Thread Konrad Materka
kmaterka created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Popup asking whether touchpad should be disabled stays open and can be covered by others, for example volume slider. It is

D24865: [SystemTray] Support for AttentionIcon

2019-11-05 Thread Konrad Materka
This revision was automatically updated to reflect the committed changes. kmaterka marked an inline comment as done. Closed by commit R120:2d7b6c2324c3: [SystemTray] Support for AttentionIcon (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24865: [SystemTray] Support for AttentionIcon

2019-11-05 Thread Konrad Materka
kmaterka marked 2 inline comments as done. kmaterka added a comment. I will do more tests. The initialization INLINE COMMENTS > davidedmundson wrote in StatusNotifierItem.qml:59 > Edit. ignore me. I had few worries about this approach but I tested with several combinations. Additional

D25223: Avoid side effects during menu initialization

2019-11-10 Thread Konrad Materka
kmaterka updated this revision to Diff 69548. kmaterka added a comment. Use QVariant for tri-state boolean. This way atributes are set only when they were really changed in the past. REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D25223: Avoid side effects during menu initialization

2019-11-10 Thread Konrad Materka
kmaterka added inline comments. INLINE COMMENTS > kdeplatformsystemtrayicon.cpp:191 > +if (!m_visible.isNull()) { > +m_menu->setVisible(m_visible.value()); > +} This line was causing issues, even if menu is (or should be) visible, setting true has side effects. I checked the

D25580: [System Tray] Unified data model for System Tray items

2019-12-10 Thread Konrad Materka
kmaterka updated this revision to Diff 71232. kmaterka added a comment. Review fix REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25580?vs=71231=71232 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25580 AFFECTED FILES

kquickcharts should be added to plasma-workspace as dependency

2019-12-17 Thread Konrad Materka
unavailable file:///home/user/kde/usr/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/CompactRepresentation.qml:27:1: module "org.kde.quickcharts" is not installed -- Regards: Konrad Materka

D25580: [System Tray] Unified data model for System Tray items

2019-12-17 Thread Konrad Materka
kmaterka added a comment. In D25580#578732 , @trmdi wrote: > Please make sure it would not bring this bug back: https://phabricator.kde.org/R120:6fcf9a5e03ba573fd0bfe30125f4c739b196a989 I double checked that. If I understand correctly

D25580: [System Tray] Unified data model for System Tray items

2019-12-16 Thread Konrad Materka
This revision was automatically updated to reflect the committed changes. Closed by commit R120:6d2fa8e6b812: [System Tray] Unified data model for System Tray items (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22176: Rework system tray settings

2019-12-16 Thread Konrad Materka
kmaterka added a comment. D25580 pushed, @nicolasfella, can you rebase? In addition, as we are basically removing categories, you need to remove: - `shownCategories` from `main.qml` - `categoryShown` from `AbstractItem.qml` -

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

2019-12-16 Thread Konrad Materka
https://bugs.kde.org/show_bug.cgi?id=350365 Konrad Materka changed: What|Removed |Added CC||mate...@gmail.com --- Comment #41 from Konrad

D25580: [System Tray] Unified data model for System Tray items

2019-12-10 Thread Konrad Materka
kmaterka marked 5 inline comments as done. kmaterka added inline comments. INLINE COMMENTS > nicolasfella wrote in ConfigEntries.qml:68 > You can try doing > > for (item of systemTrayModel) { > ] > > But I don't know if that will work Unfortunately model is not iterable. This code will be

D25580: [System Tray] Unified data model for System Tray items

2019-12-10 Thread Konrad Materka
kmaterka updated this revision to Diff 71231. kmaterka marked 5 inline comments as done. kmaterka added a comment. Review fix REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25580?vs=70464=71231 BRANCH master REVISION DETAIL

D24767: [SystemTray] Support for AttentionIcon

2019-10-19 Thread Konrad Materka
This revision was automatically updated to reflect the committed changes. Closed by commit R120:51964243ad40: [SystemTray] Support for AttentionIcon (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24767?vs=68268=68277 REVISION

D24853: [DigitalClock] Fix layout and QML warnings

2019-10-25 Thread Konrad Materka
This revision was automatically updated to reflect the committed changes. Closed by commit R120:82cfabd0a5c8: [DigitalClock] Fix layout and QML warnings (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24853?vs=68743=68745

D24853: [DigitalClock] Fix layout and QML warnings

2019-10-25 Thread Konrad Materka
kmaterka added inline comments. INLINE COMMENTS > ngraham wrote in configTimeZones.qml:58 > Don't use hardcoded margins. This should be `Kirigami.Units.smallSpacing` I just copied values form the original Rectangle. I will remove it entirely, probably it's not needed anymore. REPOSITORY

D24853: [DigitalClock] Fix layout and QML warnings

2019-10-25 Thread Konrad Materka
kmaterka updated this revision to Diff 68743. kmaterka added a comment. Remove hardcoded margins, these are not needed anymore. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24853?vs=68524=68743 BRANCH master REVISION DETAIL

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

2019-10-28 Thread Konrad Materka
kmaterka added a comment. This is a proper solution to BUG 365105. Can someone review it? Is everything OK with this? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D24843 To: kmaterka, apol, davidedmundson, #plasma, #frameworks,

D24843: [KDEPlatformSystemTrayIcon] Recreate menu when deleted

2019-10-21 Thread Konrad Materka
kmaterka created this revision. kmaterka added reviewers: apol, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Recreate internal menu when needed. It is possible that internal representation

D24530: [XembedSNIProxy] If available, always use 32-bit color.

2019-10-15 Thread Konrad Materka
kmaterka added a comment. In D24530#547085 , @ngraham wrote: > FWIW since you landed this on master rather than `Plasma/5.17`, it will only be in Plasma 5.18, not 5.17.1. > > At this point, if it's critical to go into 5.17.1, you should

D24853: [DigitalClock] Fix layout and QML warnings

2019-10-22 Thread Konrad Materka
kmaterka updated this revision to Diff 68524. kmaterka marked 3 inline comments as done. kmaterka added a comment. Review changes: Kirigami component, removed anchors REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24853?vs=68512=68524 BRANCH

D24853: [DigitalClock] Fix layout and QML warnings

2019-10-22 Thread Konrad Materka
kmaterka marked 3 inline comments as done. kmaterka added inline comments. INLINE COMMENTS > davidedmundson wrote in configTimeZones.qml:32 > Do you need these? > > Generally it's a sign of a problem or bad layering if the root item has > anchors in it. Ops, copy from HolidayConfig.qml. I'll

D24853: [DigitalClock] Fix layout and QML warnings

2019-10-22 Thread Konrad Materka
kmaterka created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Fixed issue when time zone configuration page was not scaling corrently. As a result two srollbars were rendered. Fixed few

D24853: [DigitalClock] Fix layout and QML warnings

2019-10-24 Thread Konrad Materka
kmaterka added a comment. It looks like there are some review changes required in D24798 . Maybe I can commit my changes first? D24798 needs changes anyway and it would be good to split QCC1 -> QCC2 migration from

D24865: [SystemTray] Support for AttentionIcon

2019-10-29 Thread Konrad Materka
kmaterka added inline comments. INLINE COMMENTS > broulik wrote in systemtray.cpp:354 > I think you don't need any of that. If you convert it to a `QIcon` which it > is not, it will return a default-constructed (null) `QIcon` You are of course correct, check will work without this. I wanted to

D24798: Migrate QQC1 to QQC2

2019-10-22 Thread Konrad Materka
kmaterka added inline comments. INLINE COMMENTS > ngraham wrote in configTimeZones.qml:53 > While you're doing some porting, this entire thing can be replaced with a > `Kirigami.InlineMessage` which will drastically reduce the amount of code > here, and you can also remove the

D24865: [SystemTray] Support for AttentionIcon

2019-10-22 Thread Konrad Materka
kmaterka updated this revision to Diff 68543. kmaterka added a comment. Use enum for status check REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24865?vs=68541=68543 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24865 AFFECTED

D24865: [SystemTray] Support for AttentionIcon

2019-10-22 Thread Konrad Materka
kmaterka added a comment. In D24865#552191 , @broulik wrote: > `PlasmaCore.IconItem` has a `status` property, so you probably need to explicitly check `taskIcon.status` then it should work with the proper enum Oh! Now it looks obvious! I

D24865: [SystemTray] Support for AttentionIcon

2019-10-22 Thread Konrad Materka
kmaterka added a comment. In D24865#552202 , @broulik wrote: > You might want to split that into a proper if statement otherwise it becomes somewhat hard to read. Something like > > source: { > if (taskIcon.status ===

D24767: [SystemTray] Support for AttentionIcon

2019-10-22 Thread Konrad Materka
kmaterka added a comment. In D24767#552096 , @broulik wrote: > Doesn't this break the binding for `source`? My tray icons don't update anymore Hmm, I will test that. It is possible :/ Definitely there is something wrong with

D24865: [SystemTray] Support for AttentionIcon

2019-10-22 Thread Konrad Materka
kmaterka added a comment. I need to add one more check: when AttentionIcon is not set, it should fallback to Icon(Name) REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24865 To: kmaterka, #plasma, broulik, #plasma_workspaces Cc: lbeltrame,

D24865: [SystemTray] Support for AttentionIcon

2019-10-22 Thread Konrad Materka
kmaterka created this revision. kmaterka added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Adding support for Attention Icon to StatusNotifier tray icons. Binding is working

D24853: [DigitalClock] Fix layout and QML warnings

2019-10-22 Thread Konrad Materka
kmaterka marked 3 inline comments as done. kmaterka added a comment. In D24853#552228 , @ngraham wrote: > Some of this partially conflicts with D24798 FWIW. I can wait and rebase later - your

D24767: [SystemTray] Support for AttentionIcon

2019-10-22 Thread Konrad Materka
kmaterka added a comment. In D24767#552096 , @broulik wrote: > Doesn't this break the binding for `source`? My tray icons don't update anymore Fix in D24865 , sorry... REPOSITORY R120 Plasma

D24861: Fix size of SpinBoxes

2019-10-22 Thread Konrad Materka
kmaterka created this revision. kmaterka added reviewers: martinkostolny, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY The numbers in the text entry box for "Manual Brightness Step" in the

D24865: [SystemTray] Support for AttentionIcon

2019-10-23 Thread Konrad Materka
kmaterka updated this revision to Diff 68598. kmaterka added a comment. Get rid of ugly and ridiculous nullness check. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24865?vs=68566=68598 BRANCH master REVISION DETAIL

D24865: [SystemTray] Support for AttentionIcon

2019-10-22 Thread Konrad Materka
kmaterka added inline comments. INLINE COMMENTS > StatusNotifierItem.qml:52 > +if (taskIcon.status === PlasmaCore.Types.NeedsAttentionStatus) { > +if (AttentionIcon && AttentionIcon != "QVariant(QIcon, > QIcon(null))") { > +return AttentionIcon I

D24861: Fix size of SpinBoxes

2019-10-22 Thread Konrad Materka
This revision was automatically updated to reflect the committed changes. kmaterka marked an inline comment as done. Closed by commit R885:2481a8eb6a22: Fix size of SpinBoxes (authored by kmaterka). REPOSITORY R885 Redshift Control for Plasma CHANGES SINCE LAST UPDATE

D24767: [SystemTray] Support for AttentionIcon

2019-10-18 Thread Konrad Materka
kmaterka created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Adding support for Attention Icon to StatusNotifier tray icons BUG: 341255 TEST PLAN As described in bug report,

D24767: [SystemTray] Support for AttentionIcon

2019-10-18 Thread Konrad Materka
kmaterka added a comment. As part of: https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/StatusNotifierItem/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24767 To: kmaterka, #plasma, #plasma_workspaces Cc: plasma-devel, LeGast00n,

D24737: Correctly highlight the icon in the system tray

2019-10-17 Thread Konrad Materka
kmaterka created this revision. kmaterka added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Icon is highlighted when CapsLock or NumLock are locked. It should not be

D24738: Highlight the icon in the system tray on mouse over

2019-10-17 Thread Konrad Materka
kmaterka created this revision. kmaterka added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Icon should be highlighted hover, as any other icons in the system tray.

D24720: [applets/systemtray] Rewrite popups with layouts

2019-10-17 Thread Konrad Materka
kmaterka added a comment. In D24720#549097 , @kmaterka wrote: > Pin button is no longer working,which is surprising :) In fact it is working, but there is no background change. Old version had blue background when pinned. REPOSITORY

D24738: Highlight the icon in the system tray on mouse over

2019-10-17 Thread Konrad Materka
This revision was automatically updated to reflect the committed changes. Closed by commit R120:532d4da7bfb5: Highlight the icon in the system tray on mouse over (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24720: [applets/systemtray] Rewrite popups with layouts

2019-10-17 Thread Konrad Materka
kmaterka added a comment. Pin button is no longer working,which is surprising :) About padding: I would vote for **not** changing padding nor margins, at least not in this change. It will be easier to review and test it you split this into two changes. This popup size is pretty small,

D7260: System tray icon's context menu isn't updated properly in plasma/x11

2019-10-17 Thread Konrad Materka
kmaterka added a comment. Please check my comment in BUG 383202 . Problem is on Qt side and most probably can be solved there: QTBUG-79287 REPOSITORY

D24737: Correctly highlight the icon in the system tray

2019-10-17 Thread Konrad Materka
This revision was automatically updated to reflect the committed changes. Closed by commit R114:7ad4b59b7047: Correctly highlight the icon in the system tray (authored by kmaterka). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24737?vs=68147=68190

D24865: [SystemTray] Support for AttentionIcon

2019-10-22 Thread Konrad Materka
kmaterka requested review of this revision. kmaterka added a comment. I added ugly way of checking if passed QVariant(QIcon) is null. Should I create native C++ method for that check or this can be done in QML, but in nicer way? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D24861: Fix size of SpinBoxes

2019-10-22 Thread Konrad Materka
kmaterka marked an inline comment as done. kmaterka added inline comments. INLINE COMMENTS > ngraham wrote in ConfigGeneral.qml:64 > Don't hardcode things like this; instead do `Kirigami.Units.gridUnit * 4` OK, I made it the same width as IconPicker, it should look nice REPOSITORY R885

D24861: Fix size of SpinBoxes

2019-10-22 Thread Konrad Materka
kmaterka updated this revision to Diff 68558. kmaterka added a comment. Do not use hardcoded values REPOSITORY R885 Redshift Control for Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24861?vs=68529=68558 BRANCH master REVISION DETAIL

D24865: [SystemTray] Support for AttentionIcon

2019-10-22 Thread Konrad Materka
kmaterka updated this revision to Diff 68566. kmaterka added a comment. Fallback to Icon if there is no AttentionIcon. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24865?vs=68543=68566 BRANCH master REVISION DETAIL

D25580: [System Tray] Unified data model for System Tray items

2019-11-27 Thread Konrad Materka
kmaterka created this revision. kmaterka added reviewers: Plasma, broulik. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY Currently there are two different sources of SystemTray items: - Plasmoids - Status Notifier Thi change adds new

D25580: [System Tray] Unified data model for System Tray items

2019-11-27 Thread Konrad Materka
kmaterka added a comment. This is a simplified version of D23413 needed for the D22176 to move forward. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25580 To: kmaterka, #plasma,

D22176: Rework system tray settings

2019-11-27 Thread Konrad Materka
kmaterka added a comment. As mentioned earlier: this is a great idea, but has issues with the model. Please check D25580 as a per-requirement. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22176 To: nicolasfella,

D25603: [XembedSNIProxy] Send all container windows to background on KWin restart

2019-11-28 Thread Konrad Materka
kmaterka updated this revision to Diff 70528. kmaterka added a comment. Empty line removed REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25603?vs=70527=70528 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25603 AFFECTED FILES

Add D24530 to 5.17.4

2019-11-28 Thread Konrad Materka
Hi, I fixed one issue in D24530 but it didn't manage to be in the 5.17 release. I thought it is not important but seems it is quite annoying for users. How can I add this fix to Plasma 5.17.4? Can I just cherry-pick and push or some official approval is needed? -- Regards: Konrad Materka

D25603: [XembedSNIProxy] Send all container windows to background on KWin restart

2019-11-28 Thread Konrad Materka
kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY For each tray icon XEmbedSNIProxy is creating container window 32x32 in size. It is black with

D25603: [XembedSNIProxy] Send all container windows to background on KWin restart

2019-11-29 Thread Konrad Materka
kmaterka added a comment. In D25603#569113 , @davidedmundson wrote: > Alternatively, if we need to reset something when our window gets moved...could we watch for our window getting moved? > It'll be the more technically correct, and keeps

D25603: [XembedSNIProxy] Send all container windows to background on KWin restart

2019-11-29 Thread Konrad Materka
This revision was automatically updated to reflect the committed changes. Closed by commit R120:02bbef3b506a: [XembedSNIProxy] Send all container windows to background on KWin restart (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D25223: Avoid side effects during menu initialization

2019-11-14 Thread Konrad Materka
kmaterka added a comment. In D25223#561638 , @nicolasfella wrote: > My long-term goal is to get rid of the application side KStatusNotifierItem and amend the QSystemTrayIcon API OK, I will think about this. This change is only to fix

  1   2   3   >