D28360: cmake: make xsettingsd check an option

eszlari abandoned this revision. eszlari added a comment. OK, found it. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28360 To: eszlari, gikari Cc: rikmills, kossebau, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28360: cmake: make xsettingsd check an option

eszlari added a comment. How can I close this? (phabricator UI really sucks, I hope the move to Gitlab is completed soon) REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28360 To: eszlari, gikari Cc: rikmills, kossebau, ngraham, plasma-devel,

D28360: cmake: make xsettingsd check an option

kossebau added a comment. Yes, I would just do a patch for the 'PURPOSE' text, mentioning "Required" or "Optional" (whatever you decide on), based on previously discussions with packagers on similar cases. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D28360: cmake: make xsettingsd check an option

gikari added a comment. In D28360#636687 , @kossebau wrote: > Edit: and yes, I agree CMake has awful flaws here when it comes to our needs to properly communicate dependencies to fellow developers & packagers. I am trying to give you best

D28360: cmake: make xsettingsd check an option

kossebau added a comment. Sadly Cmake does not have separate "RUNTIME-OPTIONAL" & "RUNTIME-REQUIRED" so far. Previously that was solved by noting the required vs. optional in the purpose text, so the info still arrived with packagers. Just "REQUIRED" means, it is required for the build.

D28360: cmake: make xsettingsd check an option

gikari added a comment. In D28360#636610 , @kossebau wrote: > Edit: The proposed solution to make it simply required only forces packagers to add that and all what it pulls in as build-time dependency to their package creation, even if not

D28360: cmake: make xsettingsd check an option

rikmills added a comment. In D28360#636615 , @eszlari wrote: > https://packages.ubuntu.com/focal/kde-config-gtk-style > https://src.fedoraproject.org/rpms/kde-gtk-config/blob/master/f/kde-gtk-config.spec >

D28360: cmake: make xsettingsd check an option

kossebau added a comment. See how it is done across KDE repos here: https://lxr.kde.org/search?_filestring=CMakeLists.txt&_string=TYPE+RUNTIME&_casesensitive=1 There should be no reason the same works here as well. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D28360: cmake: make xsettingsd check an option

kossebau added a comment. In D28360#636615 , @eszlari wrote: > In D28360#636610 , @kossebau wrote: > > > Can you tell which packagers missed that this is a required runtime dependency? > > >

D28360: cmake: make xsettingsd check an option

eszlari added a comment. In D28360#636448 , @gikari wrote: > Again, why not just make XSettingsd required? It's simpler. To quote yourself: "We cannot add mandatory dependencies to the stable branches/releases." I think it's

D28360: cmake: make xsettingsd check an option

kossebau added a comment. Can you tell which packagers missed that this is a required runtime dependency? Noting runtime dependencies as done so far here, by not having it required and tagging it as "RUNTIME" is a pattern everywhere else in KDE code, so the proposed patch or just

D28360: cmake: make xsettingsd check an option

ngraham added a comment. +1 for just making it a required dependency REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28360 To: eszlari, gikari Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D28360: cmake: make xsettingsd check an option

gikari added a comment. In D28360#636435 , @eszlari wrote: > In D28360#636418 , @gikari wrote: > > > But the option is enabled by default and needs to be explicitly disabled. This seems to be an

D28360: cmake: make xsettingsd check an option

eszlari added a comment. In D28360#636418 , @gikari wrote: > But the option is enabled by default and needs to be explicitly disabled. This seems to be an overengineered solution. It basically says, that XSettingsd is an optional dependency,

D28360: cmake: make xsettingsd check an option

gikari added a comment. But the option is enabled by default and needs to be explicitly disabled. This seems to be an overengineered solution. It basically says, that XSettingsd is an optional dependency, which already is. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D28360: cmake: make xsettingsd check an option

eszlari added a comment. In D28360#636406 , @gikari wrote: > In D28360#636404 , @eszlari wrote: > > > I would like to have this in 5.18 > > > We cannot add mandatory dependencies to the stable

D28360: cmake: make xsettingsd check an option

gikari added a comment. In D28360#636404 , @eszlari wrote: > I would like to have this in 5.18 We cannot add mandatory dependencies to the stable branches/releases. Currently it's an optional dependency. If you want to make it mandatory,

D28360: cmake: make xsettingsd check an option

eszlari added a comment. In D28360#636403 , @gikari wrote: > Why just not make xsettingsd required? It is set to REQUIRED (and ON by default), but can be disabled, mainly because I would like to have this in 5.18, and it seems safer that

D28360: cmake: make xsettingsd check an option

gikari added a comment. Why just not make xsettingsd required? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28360 To: eszlari, gikari Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D28360: cmake: make xsettingsd check an option

eszlari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. eszlari requested review of this revision. REVISION SUMMARY This way, packagers won't miss this new runtime dependency. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL