Re: [platform-dev] Github workflow

2022-03-24 Thread Hannes Wellmann
I'm glad this topic is discussed because I also questioned myself which workflow should be followed exactly.   I agree with Alexander that not every commit/PR needs an issue. It always felt a bit cumbersome to me that each Gerrit needed (or at least should had) an Bugzilla entry, because for cha

[platform-dev] eclipse.platform.runtime & eclipse.platform.resources moved to GitHub

2022-03-24 Thread Mickael Istria
Those Git repository are now moved to GitHub: https://github.com/eclipse-platform/eclipse.platform.runtime and https://github.com/eclipse-platform/eclipse.platform.resources . Please immediately set you `upstream` repo url to use GitHub instead of Gerrit $ cd /path/to/eclipse.platform.runtime $ git

Re: [platform-dev] Github workflow

2022-03-24 Thread Jonah Graham
Andrey, I am pretty sure all of this can be done with github, but requires writing bots to handle it. For example, we could make it so only bot has write access under normal circumstances and instead of pressing "merge" in github ui a committer adds an /approve comment. That bot can do things lik

Re: [platform-dev] Github workflow

2022-03-24 Thread Christoph Läubrich
If you don't like to suggest to Egit to add some magic, you can suggest to Github to add a similar header: https://github.community/ Am 24.03.22 um 17:30 schrieb Andrey Loskutov: Gesendet: Donnerstag, 24. März 2022 um 17:03 Uhr Von: "Christoph Läubrich" An: platform-dev@eclipse.org Betreff: R

Re: [platform-dev] Github workflow

2022-03-24 Thread Christoph Läubrich
Sorry for confusion then I probably don't get it. What has Egit/Eclipse Ui to do with gerrit? If I check with with my eclipse SDK things like "Bug " are not linked even though they are on git-eclipse or do you mean Reviewed-on:? in the commit message if it was merged through gerrit? Git

Re: [platform-dev] Github workflow

2022-03-24 Thread Andrey Loskutov
Am 24. März 2022 16:37:20 MEZ schrieb "Christoph Läubrich" : >This describes all automatically discovered references by Github: > >https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/autolinked-references-and-urls#issues-and-pull-requests > >You can automati

Re: [platform-dev] Github workflow

2022-03-24 Thread Christoph Läubrich
This describes all automatically discovered references by Github: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/autolinked-references-and-urls#issues-and-pull-requests You can automatically link issues with cour commit/pr: https://docs.github.com/en/i

Re: [platform-dev] Github workflow

2022-03-24 Thread Andrey Loskutov
Am 24. März 2022 14:07:12 MEZ schrieb Aleksandar Kurtakov : >>1. All the commits should have an issue, created in the same >>repository, number associated with them >> 1. # >> >> I don't think it is necessary to have issues for each commit(more of an PR >as it may be multiple commi

Re: [platform-dev] Github workflow

2022-03-24 Thread Aleksandar Kurtakov
On Thu, Mar 24, 2022 at 3:01 PM Sravan K Lakkimsetti < sravankum...@in.ibm.com> wrote: > >> It is unclear / undocumented how to *properly* refer to bugs in commits > (full url? repo-name/id? just id?). > >> It is unclear if we should now use dedicated github bug trackers *per > repository* to repo

Re: [platform-dev] Github workflow

2022-03-24 Thread Sravan K Lakkimsetti
>> It is unclear / undocumented how to *properly* refer to bugs in commits >> (full url? repo-name/id? just id?). >> It is unclear if we should now use dedicated github bug trackers *per >> repository* to report bugs, or will be there some higher level bug tracker >> for entire platform organiza

Re: [platform-dev] Github workflow

2022-03-24 Thread Wim Jongman
I like all this. I don't like forks and used to have branches on main repo - not recommended. > > Indeed. The "upstream" repo shouldn't be used as a workspace for ongoing work. Your workspace is your fork. Also, this is free to choose from. If one wants to work with a fork (e.g. to stash WIP), t

Re: [platform-dev] Github workflow

2022-03-24 Thread Mickael Istria
Hi, I'm putting a few answers here, but those could go to the document pointed out by Sravan (which by the way could be renamed to CONTRIBUTING.md) > I don't like forks and used to have branches on main repo - not > recommended. > Indeed. The "upstream" repo shouldn't be used as a workspace for

Re: [platform-dev] Github workflow

2022-03-24 Thread Wim Jongman
Yes, a great starting point Sravan. This workflow matches my preferred way of working. In this way, contributors and committers follow the same workflow. Cheers, Wim Eclipse Github Workflow On