Re: First attempt at ports: password-store

2015-01-09 Thread David Dahlberg
Am Donnerstag, den 08.01.2015, 16:33 + schrieb Mikolaj Kucharski: As tree(1) is already run depends, I would stay below with it. Any reason you are changing it to find(1)? Yes. The tree in OpenBSD ports is http://spootnik.org/tree/tree-0.61.tgz by Pierre-Ives Ritschard, the password-store

Re: First attempt at ports: password-store

2015-01-08 Thread Stefan Sperling
On Thu, Jan 08, 2015 at 09:52:31AM +, David Dahlberg wrote: Hi *, this is my first attempt at porting an application (password-store) to OpenBSD. Would you please comment on whether it is usable and/or where and how to improve it? Cheers David Hi David, the Makefile is

Re: First attempt at ports: password-store

2015-01-08 Thread Stuart Henderson
On 2015/01/08 13:17, Stefan Sperling wrote: On Thu, Jan 08, 2015 at 09:52:31AM +, David Dahlberg wrote: Hi *, this is my first attempt at porting an application (password-store) to OpenBSD. Would you please comment on whether it is usable and/or where and how to improve it?

Re: First attempt at ports: password-store

2015-01-08 Thread Mikolaj Kucharski
On Thu, Jan 08, 2015 at 01:17:31PM +0100, Stefan Sperling wrote: BUILD_DEPENDS = devel/gmake archivers/xz Also, I see you have USE_GMAKE=Yes, so I don't think you need to build depends on devel/gmake. That dependency will be added automatically by bsd.port.mk(5). I also concur

Re: First attempt at ports: password-store

2015-01-08 Thread Mikolaj Kucharski
On Thu, Jan 08, 2015 at 09:52:31AM +, David Dahlberg wrote: Hi *, this is my first attempt at porting an application (password-store) to OpenBSD. Would you please comment on whether it is usable and/or where and how to improve it? I didn't look at the distfile of password-store, but

Re: First attempt at ports: password-store

2015-01-08 Thread Stuart Henderson
On 2015/01/08 12:38, Mikolaj Kucharski wrote: In post-extract I would use ${INSTALL_SCRIPT} or ${INSTALL_DATA} instead of cp(1), depending should openbsd.sh have executable bit set or not. Not for post-extract, ${INSTALL_xx} sets permissions/ownership which is not wanted in extract. Manpages

Re: First attempt at ports: password-store

2015-01-08 Thread Antoine Jacoutot
On Thu, Jan 08, 2015 at 12:56:30PM +, Stuart Henderson wrote: On 2015/01/08 12:38, Mikolaj Kucharski wrote: In post-extract I would use ${INSTALL_SCRIPT} or ${INSTALL_DATA} instead of cp(1), depending should openbsd.sh have executable bit set or not. Not for post-extract, ${INSTALL_xx}

Re: First attempt at ports: password-store

2015-01-08 Thread David Dahlberg
Am Donnerstag, den 08.01.2015, 13:17 +0100 schrieb Stefan Sperling: [some remarks] [x] changed it. Have you tried talking to upstream about using more portable command line flags in their Makefile so you can drop the -v flag patches in a future update? Yes, I am in conversation with him.

Re: First attempt at ports: password-store

2015-01-08 Thread David Dahlberg
Am Donnerstag, den 08.01.2015, 12:38 + schrieb Mikolaj Kucharski: Looking at README file in password-store's git repo, it looks like content for pkg/DESCR and you have already good description for it, so I don't think there is a need for post-install part at all, as I wouldn't include

Re: First attempt at ports: password-store

2015-01-08 Thread Stuart Henderson
On 2015/01/08 13:58, Antoine Jacoutot wrote: On Thu, Jan 08, 2015 at 12:56:30PM +, Stuart Henderson wrote: On 2015/01/08 12:38, Mikolaj Kucharski wrote: In post-extract I would use ${INSTALL_SCRIPT} or ${INSTALL_DATA} instead of cp(1), depending should openbsd.sh have executable bit

Re: First attempt at ports: password-store

2015-01-08 Thread Antoine Jacoutot
Out of curiosity, why? In case people have stupid PATHs.. Then you can start to fix the ports tree for constructs like: #!/usr/bin/env perl (and probably others) IMHO it's not worth patching for that. (#!/bin/bash is another matter of course) -- Antoine

First attempt at ports: password-store

2015-01-08 Thread David Dahlberg
Hi *, this is my first attempt at porting an application (password-store) to OpenBSD. Would you please comment on whether it is usable and/or where and how to improve it? Cheers David -- David Dahlberg Fraunhofer FKIE, Dept. Communication Systems (KOM) | Tel: +49-228-9435-845

Re: First attempt at ports: password-store

2015-01-08 Thread Mikolaj Kucharski
On Thu, Jan 08, 2015 at 01:11:59PM +, Dahlberg, David wrote: In post-extract I would use ${INSTALL_SCRIPT} or ${INSTALL_DATA} instead of cp(1), depending should openbsd.sh have executable bit set or not. Please, use ${FILESDIR}/openbsd.sh instead of files/openbsd.sh to copy the file to

#!/usr/bin/env (was: First attempt at ports: password-store)

2015-01-08 Thread Matthias Kilian
On Thu, Jan 08, 2015 at 02:17:50PM +0100, Antoine Jacoutot wrote: Out of curiosity, why? In case people have stupid PATHs.. Then you can start to fix the ports tree for constructs like: #!/usr/bin/env perl (and probably others) What I *wanted* to write: Well, we usually

Re: First attempt at ports: password-store

2015-01-08 Thread David Dahlberg
Am Donnerstag, den 08.01.2015, 12:48 + schrieb Mikolaj Kucharski: I didn't look at the distfile of password-store, but only to upstream's git repo. You may considering to include the completion files for bash and zsh. For now, I packaged those scripts to

Re: First attempt at ports: password-store

2015-01-08 Thread Mikolaj Kucharski
On Thu, Jan 08, 2015 at 03:44:40PM +, David Dahlberg wrote: Attached is a new version, which addresses all (non-controversial) remarks. As for Linux and OSX, the OpenBSD-specific script is now also able to edit temporarily decypted passwords in a ramdisk instead of regular /tmp. Empty

Re: #!/usr/bin/env (was: First attempt at ports: password-store)

2015-01-08 Thread Antoine Jacoutot
Well, IMHO it's worth having determined behaviour of scripts contained in packages, even if people use strange PATHs. I consider this a MAINTAINER^case-by-base basis. We've sent a lot of patches to GNOME upstream so they stop hardcoding /bin/bash and use env bash instead (or /bin/sh when

Re: #!/usr/bin/env (was: First attempt at ports: password-store)

2015-01-08 Thread Matthias Kilian
On Thu, Jan 08, 2015 at 07:42:34PM +0100, Antoine Jacoutot wrote: Well, IMHO it's worth having determined behaviour of scripts contained in packages, even if people use strange PATHs. I consider this a MAINTAINER^case-by-base basis. In this case, if you find a #!/usr/bin/env in some of the

Re: #!/usr/bin/env (was: First attempt at ports: password-store)

2015-01-08 Thread Antoine Jacoutot
On Thu, Jan 08, 2015 at 07:52:16PM +0100, Matthias Kilian wrote: In this case, if you find a #!/usr/bin/env in some of the ports maintained by me, please tell me ;-) I will never find them. I check runtime issues, not nazi paths ;-) -- Antoine