Re: [NEW] net/profanity and net/libstrophe

2016-04-26 Thread Stuart Henderson
On 2016/04/26 10:36, Stuart Henderson wrote:
> What problem do you see with tests? They work for me as-is, even
> if cmocka was not installed during 'make configure'.
> 
> It's not a LIB_DEPENDS.

Oh,  it all becomes clear :)



Re: [NEW] net/profanity and net/libstrophe

2016-04-26 Thread Stuart Henderson
What problem do you see with tests? They work for me as-is, even
if cmocka was not installed during 'make configure'.

It's not a LIB_DEPENDS.



Re: [NEW] net/profanity and net/libstrophe

2016-04-25 Thread Theo Buehler
> one little tweak:
> 

I went for this one:

> Option 2:
> 
> add cmocka as LIB_DEPENDS to running regression tests and remove

but since devel/cmocka is only used in the tests, I added a TEST_DEPENDS
instead.

> whitspaces.
> 
> Index: Makefile
> ===
> RCS file: /cvs/ports/net/profanity/Makefile,v
> retrieving revision 1.1.1.1
> diff -u -p -u -p -r1.1.1.1 Makefile
> --- Makefile  25 Apr 2016 17:46:38 -  1.1.1.1
> +++ Makefile  25 Apr 2016 19:05:32 -
> @@ -18,7 +18,9 @@ WANTLIB += otr strophe uuid
>  BUILD_DEPENDS +=${MODGNU_AUTOCONF_DEPENDS} \
>   ${MODGNU_AUTOMAKE)DEPENDS} \
>  
> +# cmocka for tests
>  LIB_DEPENDS +=   net/curl \
> + devel/cmocka \
>   devel/readline>=6.1p2 \
>   devel/glib2 \
>   net/libstrophe \
> @@ -43,6 +45,6 @@ AUTOMAKE_VERSION =  1.11
>  post-patch:
>   find ${WRKSRC} -type f -name "*.c" \
>   -exec sed -i '/stub\_ui.h/d' "{}" \;
> - sed -i s,/usr/local,${LOCALBASE}, ${WRKSRC}/configure.ac 
> + sed -i s,/usr/local,${LOCALBASE}, ${WRKSRC}/configure.ac
>  
>  .include 
> 



Re: [NEW] net/profanity and net/libstrophe

2016-04-25 Thread Rafael Sadowski
On Mon Apr 25, 2016 at 06:19:34PM +0200, Theo Buehler wrote:
> On Mon, Apr 25, 2016 at 06:06:43PM +0200, Theo Buehler wrote:
> > On Sun, Jan 24, 2016 at 12:13:47PM +0100, Theo Buehler wrote:
> > > On Sat, Jan 23, 2016 at 05:20:06PM +0100, Rafael Sadowski wrote:
> > > > New updated profanity tarball. Source and changelog on github:
> > > > https://github.com/jasperla/openbsd-wip/tree/master/net/profanity
> > > >
> > > > Thanks for the advice from sthen@ and Raf Czlonka.
> > > >
> > > > Best regards,
> > > >
> > > > Rafael
> > > 
> > > libstrophe now looks fine to me and seems to be ready to go in.
> > 
> > I've been running the following version of Rafael's net/profanity port
> > for quite a while now. The net/libstrophe port is still the same as the
> > one submitted by Rafael.
> > 
> > Does this look ok now?
> 
> sorry, i mangled the libstrophe archive. here's a good version of it

Thanks Theo and best regards to France.

one little tweak:

Option 1:

Disbale regression tests and remove whitspaces.

Index: Makefile
===
RCS file: /cvs/ports/net/profanity/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -u -p -r1.1.1.1 Makefile
--- Makefile25 Apr 2016 17:46:38 -  1.1.1.1
+++ Makefile25 Apr 2016 19:04:32 -
@@ -39,10 +39,12 @@ MAKE_FLAGS =CC="${CC}" CFLAGS="${CFLAGS
 AUTOCONF_VERSION = 2.69
 AUTOMAKE_VERSION = 1.11
 
+NO_TEST =  Yes
+
 # there is no stub_ui.h and is not needed
 post-patch:
find ${WRKSRC} -type f -name "*.c" \
-exec sed -i '/stub\_ui.h/d' "{}" \;
-   sed -i s,/usr/local,${LOCALBASE}, ${WRKSRC}/configure.ac 
+   sed -i s,/usr/local,${LOCALBASE}, ${WRKSRC}/configure.ac
 
 .include 


Option 2:

add cmocka as LIB_DEPENDS to running regression tests and remove
whitspaces.

Index: Makefile
===
RCS file: /cvs/ports/net/profanity/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -u -p -r1.1.1.1 Makefile
--- Makefile25 Apr 2016 17:46:38 -  1.1.1.1
+++ Makefile25 Apr 2016 19:05:32 -
@@ -18,7 +18,9 @@ WANTLIB += otr strophe uuid
 BUILD_DEPENDS +=${MODGNU_AUTOCONF_DEPENDS} \
${MODGNU_AUTOMAKE)DEPENDS} \
 
+# cmocka for tests
 LIB_DEPENDS += net/curl \
+   devel/cmocka \
devel/readline>=6.1p2 \
devel/glib2 \
net/libstrophe \
@@ -43,6 +45,6 @@ AUTOMAKE_VERSION =1.11
 post-patch:
find ${WRKSRC} -type f -name "*.c" \
-exec sed -i '/stub\_ui.h/d' "{}" \;
-   sed -i s,/usr/local,${LOCALBASE}, ${WRKSRC}/configure.ac 
+   sed -i s,/usr/local,${LOCALBASE}, ${WRKSRC}/configure.ac
 
 .include 



Re: [NEW] net/profanity and net/libstrophe

2016-04-25 Thread Stuart Henderson
On 2016/04/25 17:24, Stuart Henderson wrote:
> This struck me as being a bit odd, some of the configure.ac patches
> change from FOO+= to FOO=, like these:
> 
> - PC_REQUIRES+=(libxml-2.0)
> + PC_REQUIRES="libxml-2.0 ${PC_REQUIRES}"
> 
> but others retain the +
> 
> -  PC_LIBS+=($openssl_LIBS)
> +  PC_LIBS+="${openssl_LIBS} ${PC_LIBS}"
> 
> Shouldn't those + go away as well? (Untested due to lack of
> usable Makefile ;)
> 
> 

Tested now, it didn't break the build with them, but they should all
go away, they're a bash-ism and don't work with our shell so even if
they work now, they might trip us up later.

Otherwise ok for libstrophe, will look at profanity next.



Re: [NEW] net/profanity and net/libstrophe

2016-04-25 Thread Stuart Henderson
On 2016/04/25 18:06, Theo Buehler wrote:
> On Sun, Jan 24, 2016 at 12:13:47PM +0100, Theo Buehler wrote:
> > On Sat, Jan 23, 2016 at 05:20:06PM +0100, Rafael Sadowski wrote:
> > > New updated profanity tarball. Source and changelog on github:
> > > https://github.com/jasperla/openbsd-wip/tree/master/net/profanity
> > >
> > > Thanks for the advice from sthen@ and Raf Czlonka.
> > >
> > > Best regards,
> > >
> > > Rafael
> > 
> > libstrophe now looks fine to me and seems to be ready to go in.
> 
> I've been running the following version of Rafael's net/profanity port
> for quite a while now. The net/libstrophe port is still the same as the
> one submitted by Rafael.
> 
> Does this look ok now?




The libstrophe tar is broken, when you extract it Makefile is a tar.gz of
every file except for Makefile.

This struck me as being a bit odd, some of the configure.ac patches
change from FOO+= to FOO=, like these:

- PC_REQUIRES+=(libxml-2.0)
+ PC_REQUIRES="libxml-2.0 ${PC_REQUIRES}"

but others retain the +

-  PC_LIBS+=($openssl_LIBS)
+  PC_LIBS+="${openssl_LIBS} ${PC_LIBS}"

Shouldn't those + go away as well? (Untested due to lack of
usable Makefile ;)




Re: [NEW] net/profanity and net/libstrophe

2016-04-25 Thread Theo Buehler
On Mon, Apr 25, 2016 at 06:06:43PM +0200, Theo Buehler wrote:
> On Sun, Jan 24, 2016 at 12:13:47PM +0100, Theo Buehler wrote:
> > On Sat, Jan 23, 2016 at 05:20:06PM +0100, Rafael Sadowski wrote:
> > > New updated profanity tarball. Source and changelog on github:
> > > https://github.com/jasperla/openbsd-wip/tree/master/net/profanity
> > >
> > > Thanks for the advice from sthen@ and Raf Czlonka.
> > >
> > > Best regards,
> > >
> > > Rafael
> > 
> > libstrophe now looks fine to me and seems to be ready to go in.
> 
> I've been running the following version of Rafael's net/profanity port
> for quite a while now. The net/libstrophe port is still the same as the
> one submitted by Rafael.
> 
> Does this look ok now?

sorry, i mangled the libstrophe archive. here's a good version of it


libstrophe.tgz
Description: application/tar-gz


Re: [NEW] net/profanity and net/libstrophe

2016-04-25 Thread Theo Buehler
On Sun, Jan 24, 2016 at 12:13:47PM +0100, Theo Buehler wrote:
> On Sat, Jan 23, 2016 at 05:20:06PM +0100, Rafael Sadowski wrote:
> > New updated profanity tarball. Source and changelog on github:
> > https://github.com/jasperla/openbsd-wip/tree/master/net/profanity
> >
> > Thanks for the advice from sthen@ and Raf Czlonka.
> >
> > Best regards,
> >
> > Rafael
> 
> libstrophe now looks fine to me and seems to be ready to go in.

I've been running the following version of Rafael's net/profanity port
for quite a while now. The net/libstrophe port is still the same as the
one submitted by Rafael.

Does this look ok now?


profanity.tgz
Description: application/tar-gz


libstrophe.tgz
Description: application/tar-gz


Re: [NEW] net/profanity and net/libstrophe

2016-01-24 Thread Theo Buehler
On Sat, Jan 23, 2016 at 05:20:06PM +0100, Rafael Sadowski wrote:
> New updated profanity tarball. Source and changelog on github:
> https://github.com/jasperla/openbsd-wip/tree/master/net/profanity
> 
> Thanks for the advice from sthen@ and Raf Czlonka.
> 
> Best regards,
> 
> Rafael

libstrophe now looks fine to me and seems to be ready to go in.

As already discussed at length with Rafael off-list, I'm running into
problems with profanity, though.  Everything up to and including
"make port-lib-depends-check" works as expected, but "make package"
errors out on my amd64 laptop with:

$ make package
===>  Looking for profanity-0.4.7.tgz in $PKG_PATH - not found
*** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:1949 
'/usr/ports/packages/amd64/cache//profanity-0.4.7.tgz': @if /usr/bin/env -i ...)
`/usr/ports/pobj/profanity-0.4.7/fake-amd64/.fake_done' is up to date.
===>  Building package for profanity-0.4.7
Create /usr/ports/packages/amd64/all/profanity-0.4.7.tgz
LIB_DEPENDS devel/cmocka not needed for net/profanity ?
LIB_DEPENDS devel/libnotify not needed for net/profanity ?
|library glib-2.0.4200.2 not found
| not found anywhere
Direct dependencies for profanity-0.4.7 resolve to libstrophe-0.8.8 
e2fsprogs-1.42.12p1 curl-7.46.0 libotr-4.1.0 gpgme-1.5.1p1 readline-6.3
Full dependency tree is nghttp2-1.6.0 libassuan-2.1.1 gettext-0.19.7 
bzip2-1.0.6p7 libgcrypt-1.6.4 libgpg-error-1.21 curl-7.46.0 libiconv-1.14p3 
gnupg-1.4.19p0 gpgme-1.5.1p1 libidn-1.32 readline-6.3 e2fsprogs-1.42.12p1 
libstrophe-0.8.8 libotr-4.1.0
Fatal error: can't continue
 at /usr/libdata/perl5/OpenBSD/PkgCreate.pm line 1543.
*** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:1963 
'/usr/ports/packages/amd64/all/profanity-0.4.7.tgz')
*** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:1957 
'/usr/ports/packages/amd64/all/profanity-0.4.7.tgz')
*** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2515 
'_internal-package')
*** Error 1 in /usr/ports/net/profanity 
(/usr/ports/infrastructure/mk/bsd.port.mk:2495 'package')
$

I suppose the mistake is at my end, but I really don't know where to
start.  I updated all packages and the ports tree yesterday before
trying.  I would appreciate if somebody more familiar with ports could
look into this.



Re: [NEW] net/profanity and net/libstrophe

2016-01-23 Thread Rafael Sadowski
On Wed Jan 20, 2016 at 01:01:34PM +0100, Rafael Sadowski wrote:
> On Thu Dec 31, 2015 at 04:37:29PM +0100, Theo Buehler wrote:
> > On Tue, Dec 29, 2015 at 12:09:38PM +0100, Rafael Sadowski wrote:
> > > On Sun Dec 20, 2015 at 05:00:06PM +0100, Rafael Sadowski wrote:
> > > > Hey @ports,
> > > > 
> > > > my second try to push my favorite XMPP console client (with dependency
> > > > lib). The port based on Brian Callahan work in openbsd-wip. (Okay to
> > > > take maintainer).  All tests passed and worked well over months for me.
> > > > 
> > > > I rewrite some patches more generic sent upstream with good feedback
> > > > from libstrophe (advice from Antoine Jacoutot).
> > > > 
> > > > 
> > > > Best regards,
> > > > 
> > > > Rafael
> > > > 
> > > > net/profanity:
> > > > 
> > > > Profanity is a console based XMPP client written in C using ncurses and
> > > > libstrophe, inspired by irssi.
> > > > 
> > > > Features:
> > > > 
> > > > * Supports XMPP chat services, including Google Talk and Facebook.
> > > > * Command driven user interface.
> > > > * Customizable functionality and user interface.
> > > > * OTR (Off The Record) message encryption.
> > > > * Chat room support.
> > > > * Roster management.
> > > > * Flexible resource and priority settings.
> > > > * Desktop notifications.
> > > > * Unicode support.
> > > > * Integrated DuckDuckGo searching.
> > > > * Send tiny URLs.
> > > > 
> > > > net/libstrophe:
> > > > 
> > > > libstrophe is a minimal XMPP library written in C. It has almost no
> > > > external dependencies, only an XML parsing library (expat or libxml are
> > > > both supported). It is designed for both POSIX and Windows systems.
> > 
> 
> Sorry, no CC me no attention :(
> 
> > I think net/libstrophe is almost ready to go.  It would be nice to
> > make a brief annotation why you removed rc/thread.{c,h} in Makefile.am.
> > While there, I would omit the second part of that patch (this removes
> > only trailing whitespace, so it is only noise).
> > 
> > 'make lib-depends-check' notes that 'pthread' is extra, so I think it
> > should be removed from WANTLIB.
> 
> Fixed version as attachment. 
> 
> src/thread.{c,h} is not in use...
> 
> "I thought src/thread.[ch] are not included in Makefile.am. I don't know
> the original purpose of those functions and only can guess that author
> wanted to write parallel version of libstrophe.  Proper solution should
> be removing thread.[ch] from the Makefile.am"
> 
> -- https://github.com/strophe/libstrophe/pull/72
> 
> > 
> > 
> > As for profanity, I can confirm that it works fine, but there is a bit
> > more work to do:
> > 
> > $ make lib-depend-dest
> > 
> > gives me quite a few remarks, so that should be cleaned up:
> > 
> > [...]
> > profanity-0.4.7(net/profanity):
> > Missing lib: uuid.14 (/usr/local/bin/profanity) (NOT REACHABLE)
> > Extra:  X11.16 Xss.6 crypto.37 expat.11 gdk_pixbuf-2.0.3200
> > Extra:  gio-2.0.4200 gobject-2.0.4200 iconv.6 notify.4 ssl.38
> > *** Error 1 in target 'port-lib-depends-check' (ignored)
> 
> I'm totally lost with this.
> 
> profanity links with uuid:
> 
> cc -Wall -Wno-deprecated-declarations -O2 -pipe -I/usr/local/include
> -I/usr/include -L/usr/local/lib  -L/usr/local/lib -L/usr/X11R6/lib -o
> profanity src/contact.o src/log.o  src/common.o src/profanity.o
> src/chat_session.o src/muc.o src/jid.o  src/chat_state.o src/resource.o
> src/roster_list.o src/xmpp/capabilities.o  src/xmpp/connection.o
> src/xmpp/iq.o  src/xmpp/message.o src/xmpp/presence.o  src/xmpp/stanza.o
> src/xmpp/roster.o  src/xmpp/bookmark.o src/xmpp/form.o
> src/event/server_events.o  src/event/client_events.o
> src/event/ui_events.o src/ui/window.o  src/ui/core.o src/ui/titlebar.o
> src/ui/statusbar.o src/ui/inputwin.o  src/ui/console.o src/ui/notifier.o
> src/window_list.o src/ui/rosterwin.o  src/ui/occupantswin.o
> src/ui/buffer.o  src/command/command.o src/command/commands.o
> src/tools/parser.o src/tools/p_sha1.o  src/tools/autocomplete.o
> src/tools/tinyurl.o  src/config/accounts.o src/config/account.o
> src/config/preferences.o src/config/theme.o  src/pgp/gpg.o
> src/otr/otrlibv4.o src/otr/otr.o src/main.o  -L/usr/local/lib -lglib-2.0
> -lintl -L/usr/local/lib -lcurl  -lotr -L/usr/local/lib -lgpgme -lassuan
> -lgpg-error -luuid -lereadline  -lncursesw -L/usr/local/lib -lstrophe
> ^^
> and profanity runs fine. `objdump -s` says me:
> 
> Dynamic Section:
>   NEEDED  libglib-2.0.so.4200.2
>   NEEDED  libintl.so.6.0
>   NEEDED  libcurl.so.25.2
>   NEEDED  libotr.so.4.1
>   NEEDED  libgpgme.so.19.0
>   NEEDED  libassuan.so.1.1
>   NEEDED  libgpg-error.so.3.9
>   NEEDED  libuuid.so.14.0
>   NEEDED  libereadline.so.1.0
>   NEEDED  libncursesw.so.14.0
>   NEEDED  libstrophe.so.0.0
>   NEEDED  libc.so.84.2
>   NEEDED  libpthread.so.20.1
> 
> At the end, I don't understand the output from "port-lib-depends-check".
> Any feedback or helpful hand?
> 
> Best Regards,
> 
> Rafael

New updated 

Re: [NEW] net/profanity and net/libstrophe

2016-01-20 Thread Rafael Sadowski
On Thu Dec 31, 2015 at 04:37:29PM +0100, Theo Buehler wrote:
> On Tue, Dec 29, 2015 at 12:09:38PM +0100, Rafael Sadowski wrote:
> > On Sun Dec 20, 2015 at 05:00:06PM +0100, Rafael Sadowski wrote:
> > > Hey @ports,
> > > 
> > > my second try to push my favorite XMPP console client (with dependency
> > > lib). The port based on Brian Callahan work in openbsd-wip. (Okay to
> > > take maintainer).  All tests passed and worked well over months for me.
> > > 
> > > I rewrite some patches more generic sent upstream with good feedback
> > > from libstrophe (advice from Antoine Jacoutot).
> > > 
> > > 
> > > Best regards,
> > > 
> > > Rafael
> > > 
> > > net/profanity:
> > > 
> > > Profanity is a console based XMPP client written in C using ncurses and
> > > libstrophe, inspired by irssi.
> > > 
> > > Features:
> > > 
> > > * Supports XMPP chat services, including Google Talk and Facebook.
> > > * Command driven user interface.
> > > * Customizable functionality and user interface.
> > > * OTR (Off The Record) message encryption.
> > > * Chat room support.
> > > * Roster management.
> > > * Flexible resource and priority settings.
> > > * Desktop notifications.
> > > * Unicode support.
> > > * Integrated DuckDuckGo searching.
> > > * Send tiny URLs.
> > > 
> > > net/libstrophe:
> > > 
> > > libstrophe is a minimal XMPP library written in C. It has almost no
> > > external dependencies, only an XML parsing library (expat or libxml are
> > > both supported). It is designed for both POSIX and Windows systems.
> 

Sorry, no CC me no attention :(

> I think net/libstrophe is almost ready to go.  It would be nice to
> make a brief annotation why you removed rc/thread.{c,h} in Makefile.am.
> While there, I would omit the second part of that patch (this removes
> only trailing whitespace, so it is only noise).
> 
> 'make lib-depends-check' notes that 'pthread' is extra, so I think it
> should be removed from WANTLIB.

Fixed version as attachment. 

src/thread.{c,h} is not in use...

"I thought src/thread.[ch] are not included in Makefile.am. I don't know
the original purpose of those functions and only can guess that author
wanted to write parallel version of libstrophe.  Proper solution should
be removing thread.[ch] from the Makefile.am"

-- https://github.com/strophe/libstrophe/pull/72

> 
> 
> As for profanity, I can confirm that it works fine, but there is a bit
> more work to do:
> 
> $ make lib-depend-dest
> 
> gives me quite a few remarks, so that should be cleaned up:
> 
> [...]
> profanity-0.4.7(net/profanity):
> Missing lib: uuid.14 (/usr/local/bin/profanity) (NOT REACHABLE)
> Extra:  X11.16 Xss.6 crypto.37 expat.11 gdk_pixbuf-2.0.3200
> Extra:  gio-2.0.4200 gobject-2.0.4200 iconv.6 notify.4 ssl.38
> *** Error 1 in target 'port-lib-depends-check' (ignored)

I'm totally lost with this.

profanity links with uuid:

cc -Wall -Wno-deprecated-declarations -O2 -pipe -I/usr/local/include
-I/usr/include -L/usr/local/lib  -L/usr/local/lib -L/usr/X11R6/lib -o
profanity src/contact.o src/log.o  src/common.o src/profanity.o
src/chat_session.o src/muc.o src/jid.o  src/chat_state.o src/resource.o
src/roster_list.o src/xmpp/capabilities.o  src/xmpp/connection.o
src/xmpp/iq.o  src/xmpp/message.o src/xmpp/presence.o  src/xmpp/stanza.o
src/xmpp/roster.o  src/xmpp/bookmark.o src/xmpp/form.o
src/event/server_events.o  src/event/client_events.o
src/event/ui_events.o src/ui/window.o  src/ui/core.o src/ui/titlebar.o
src/ui/statusbar.o src/ui/inputwin.o  src/ui/console.o src/ui/notifier.o
src/window_list.o src/ui/rosterwin.o  src/ui/occupantswin.o
src/ui/buffer.o  src/command/command.o src/command/commands.o
src/tools/parser.o src/tools/p_sha1.o  src/tools/autocomplete.o
src/tools/tinyurl.o  src/config/accounts.o src/config/account.o
src/config/preferences.o src/config/theme.o  src/pgp/gpg.o
src/otr/otrlibv4.o src/otr/otr.o src/main.o  -L/usr/local/lib -lglib-2.0
-lintl -L/usr/local/lib -lcurl  -lotr -L/usr/local/lib -lgpgme -lassuan
-lgpg-error -luuid -lereadline  -lncursesw -L/usr/local/lib -lstrophe
^^
and profanity runs fine. `objdump -s` says me:

Dynamic Section:
  NEEDED  libglib-2.0.so.4200.2
  NEEDED  libintl.so.6.0
  NEEDED  libcurl.so.25.2
  NEEDED  libotr.so.4.1
  NEEDED  libgpgme.so.19.0
  NEEDED  libassuan.so.1.1
  NEEDED  libgpg-error.so.3.9
  NEEDED  libuuid.so.14.0
  NEEDED  libereadline.so.1.0
  NEEDED  libncursesw.so.14.0
  NEEDED  libstrophe.so.0.0
  NEEDED  libc.so.84.2
  NEEDED  libpthread.so.20.1

At the end, I don't understand the output from "port-lib-depends-check".
Any feedback or helpful hand?

Best Regards,

Rafael


libstrophe.tar.gz
Description: application/tar-gz


Re: [NEW] net/profanity and net/libstrophe

2016-01-20 Thread Stuart Henderson
On 2016/01/20 13:01, Rafael Sadowski wrote:
> Sorry, no CC me no attention :(

Your ports@ mails are sent with Mail-Followup-To, don't do this
if you want CCs. I have added it manually for this one but it's a
pain to do. (group reply, notice this request, go back to the
index, reply singly, re-add ports@ by hand ...)

> > Missing lib: uuid.14 (/usr/local/bin/profanity) (NOT REACHABLE)

This means there is no path to libuuid via LIB_DEPENDS so you need
to add one. (If you have multiple 'NOT REACHABLE' lines then adding
one of them may pull in other ports via *their* LIB_DEPENDS so just
one may be enough; this is particularly the case for things using
some of the larger libraries like gtk+, so in those cases add
that one first).

> > Extra:  X11.16 Xss.6 crypto.37 expat.11 gdk_pixbuf-2.0.3200
> > Extra:  gio-2.0.4200 gobject-2.0.4200 iconv.6 notify.4 ssl.38

Here you have various WANTLIB listed in the Makefile that aren't
showing in objdump -p. In most cases you want to remove these
(but there are exceptions with dlopen() etc).

Also noticed:

MAKE_FLAGS =CC="${CC}" CFLAGS="${CFLAGS}"

These should be passed to autoconf. This is important because
it may add/remove flags at build time depending on the chosen
compiler. Those are usually (but not always) passed on to make,
so you might be able to remove the MAKE_FLAGS line as well.



Re: [NEW] net/profanity and net/libstrophe

2016-01-20 Thread Raf Czlonka
On Sun, Dec 20, 2015 at 04:00:06PM GMT, Rafael Sadowski wrote:

> Hey @ports,

Hi Rafael,

> my second try to push my favorite XMPP console client (with dependency
> lib). The port based on Brian Callahan work in openbsd-wip. (Okay to
> take maintainer).  All tests passed and worked well over months for me.
> 
> I rewrite some patches more generic sent upstream with good feedback
> from libstrophe (advice from Antoine Jacoutot).
> 
> 
> Best regards,
> 
> Rafael
> 
> net/profanity:
> 
> Profanity is a console based XMPP client written in C using ncurses and
> libstrophe, inspired by irssi.
> 
> Features:
> 
> * Supports XMPP chat services, including Google Talk and Facebook.
   
Tiny nit - Facebook not longer supports XMPP[0]. Profanity already
adjusted it on their website[1] ;^)

So that, even though it is still based on XMPP, it doesn't talk to other
XMPP servers.

> * Command driven user interface.
> * Customizable functionality and user interface.
> * OTR (Off The Record) message encryption.
> * Chat room support.
> * Roster management.
> * Flexible resource and priority settings.
> * Desktop notifications.
> * Unicode support.
> * Integrated DuckDuckGo searching.
> * Send tiny URLs.
> 
> net/libstrophe:
> 
> libstrophe is a minimal XMPP library written in C. It has almost no
> external dependencies, only an XML parsing library (expat or libxml are
> both supported). It is designed for both POSIX and Windows systems.

Regards,

Raf

[0] https://developers.facebook.com/docs/chat
[1] http://www.profanity.im/



Re: [NEW] net/profanity and net/libstrophe

2015-12-31 Thread Theo Buehler
On Tue, Dec 29, 2015 at 12:09:38PM +0100, Rafael Sadowski wrote:
> On Sun Dec 20, 2015 at 05:00:06PM +0100, Rafael Sadowski wrote:
> > Hey @ports,
> > 
> > my second try to push my favorite XMPP console client (with dependency
> > lib). The port based on Brian Callahan work in openbsd-wip. (Okay to
> > take maintainer).  All tests passed and worked well over months for me.
> > 
> > I rewrite some patches more generic sent upstream with good feedback
> > from libstrophe (advice from Antoine Jacoutot).
> > 
> > 
> > Best regards,
> > 
> > Rafael
> > 
> > net/profanity:
> > 
> > Profanity is a console based XMPP client written in C using ncurses and
> > libstrophe, inspired by irssi.
> > 
> > Features:
> > 
> > * Supports XMPP chat services, including Google Talk and Facebook.
> > * Command driven user interface.
> > * Customizable functionality and user interface.
> > * OTR (Off The Record) message encryption.
> > * Chat room support.
> > * Roster management.
> > * Flexible resource and priority settings.
> > * Desktop notifications.
> > * Unicode support.
> > * Integrated DuckDuckGo searching.
> > * Send tiny URLs.
> > 
> > net/libstrophe:
> > 
> > libstrophe is a minimal XMPP library written in C. It has almost no
> > external dependencies, only an XML parsing library (expat or libxml are
> > both supported). It is designed for both POSIX and Windows systems.

I think net/libstrophe is almost ready to go.  It would be nice to
make a brief annotation why you removed rc/thread.{c,h} in Makefile.am.
While there, I would omit the second part of that patch (this removes
only trailing whitespace, so it is only noise).

'make lib-depends-check' notes that 'pthread' is extra, so I think it
should be removed from WANTLIB.


As for profanity, I can confirm that it works fine, but there is a bit
more work to do:

$ make lib-depend-dest

gives me quite a few remarks, so that should be cleaned up:

[...]
profanity-0.4.7(net/profanity):
Missing lib: uuid.14 (/usr/local/bin/profanity) (NOT REACHABLE)
Extra:  X11.16 Xss.6 crypto.37 expat.11 gdk_pixbuf-2.0.3200
Extra:  gio-2.0.4200 gobject-2.0.4200 iconv.6 notify.4 ssl.38
*** Error 1 in target 'port-lib-depends-check' (ignored)



Re: [NEW] net/profanity and net/libstrophe

2015-12-31 Thread Theo Buehler
On Thu, Dec 31, 2015 at 04:37:29PM +0100, Theo Buehler wrote:
> On Tue, Dec 29, 2015 at 12:09:38PM +0100, Rafael Sadowski wrote:
> > On Sun Dec 20, 2015 at 05:00:06PM +0100, Rafael Sadowski wrote:
> > > Hey @ports,
> > > 
> > > my second try to push my favorite XMPP console client (with dependency
> > > lib). The port based on Brian Callahan work in openbsd-wip. (Okay to
> > > take maintainer).  All tests passed and worked well over months for me.
> > > 
> > > I rewrite some patches more generic sent upstream with good feedback
> > > from libstrophe (advice from Antoine Jacoutot).
> > > 
> > > 
> > > Best regards,
> > > 
> > > Rafael
> > > 
> > > net/profanity:
> > > 
> > > Profanity is a console based XMPP client written in C using ncurses and
> > > libstrophe, inspired by irssi.
> > > 
> > > Features:
> > > 
> > > * Supports XMPP chat services, including Google Talk and Facebook.
> > > * Command driven user interface.
> > > * Customizable functionality and user interface.
> > > * OTR (Off The Record) message encryption.
> > > * Chat room support.
> > > * Roster management.
> > > * Flexible resource and priority settings.
> > > * Desktop notifications.
> > > * Unicode support.
> > > * Integrated DuckDuckGo searching.
> > > * Send tiny URLs.
> > > 
> > > net/libstrophe:
> > > 
> > > libstrophe is a minimal XMPP library written in C. It has almost no
> > > external dependencies, only an XML parsing library (expat or libxml are
> > > both supported). It is designed for both POSIX and Windows systems.
> 
> I think net/libstrophe is almost ready to go.  It would be nice to
> make a brief annotation why you removed rc/thread.{c,h} in Makefile.am.
> While there, I would omit the second part of that patch (this removes
> only trailing whitespace, so it is only noise).
> 
> 'make lib-depends-check' notes that 'pthread' is extra, so I think it
> should be removed from WANTLIB.
> 
> 
> As for profanity, I can confirm that it works fine, but there is a bit
> more work to do:
> 
> $ make lib-depend-dest

sorry, that would be
$ make port-lib-depends-check

> 
> gives me quite a few remarks, so that should be cleaned up:
> 
> [...]
> profanity-0.4.7(net/profanity):
> Missing lib: uuid.14 (/usr/local/bin/profanity) (NOT REACHABLE)
> Extra:  X11.16 Xss.6 crypto.37 expat.11 gdk_pixbuf-2.0.3200
> Extra:  gio-2.0.4200 gobject-2.0.4200 iconv.6 notify.4 ssl.38
> *** Error 1 in target 'port-lib-depends-check' (ignored)
> 



Re: [NEW] net/profanity and net/libstrophe

2015-12-29 Thread Rafael Sadowski
On Sun Dec 20, 2015 at 05:00:06PM +0100, Rafael Sadowski wrote:
> Hey @ports,
> 
> my second try to push my favorite XMPP console client (with dependency
> lib). The port based on Brian Callahan work in openbsd-wip. (Okay to
> take maintainer).  All tests passed and worked well over months for me.
> 
> I rewrite some patches more generic sent upstream with good feedback
> from libstrophe (advice from Antoine Jacoutot).
> 
> 
> Best regards,
> 
> Rafael
> 
> net/profanity:
> 
> Profanity is a console based XMPP client written in C using ncurses and
> libstrophe, inspired by irssi.
> 
> Features:
> 
> * Supports XMPP chat services, including Google Talk and Facebook.
> * Command driven user interface.
> * Customizable functionality and user interface.
> * OTR (Off The Record) message encryption.
> * Chat room support.
> * Roster management.
> * Flexible resource and priority settings.
> * Desktop notifications.
> * Unicode support.
> * Integrated DuckDuckGo searching.
> * Send tiny URLs.
> 
> net/libstrophe:
> 
> libstrophe is a minimal XMPP library written in C. It has almost no
> external dependencies, only an XML parsing library (expat or libxml are
> both supported). It is designed for both POSIX and Windows systems.


fix profanity attachment. Thanks Theo B.

Rafael



profanity.tar.gz
Description: application/tar-gz


[NEW] net/profanity and net/libstrophe

2015-12-20 Thread Rafael Sadowski
Hey @ports,

my second try to push my favorite XMPP console client (with dependency
lib). The port based on Brian Callahan work in openbsd-wip. (Okay to
take maintainer).  All tests passed and worked well over months for me.

I rewrite some patches more generic sent upstream with good feedback
from libstrophe (advice from Antoine Jacoutot).


Best regards,

Rafael

net/profanity:

Profanity is a console based XMPP client written in C using ncurses and
libstrophe, inspired by irssi.

Features:

* Supports XMPP chat services, including Google Talk and Facebook.
* Command driven user interface.
* Customizable functionality and user interface.
* OTR (Off The Record) message encryption.
* Chat room support.
* Roster management.
* Flexible resource and priority settings.
* Desktop notifications.
* Unicode support.
* Integrated DuckDuckGo searching.
* Send tiny URLs.

net/libstrophe:

libstrophe is a minimal XMPP library written in C. It has almost no
external dependencies, only an XML parsing library (expat or libxml are
both supported). It is designed for both POSIX and Windows systems.


libstrophe.tar.gz
Description: application/tar-gz


libstrophe.tar.gz
Description: application/tar-gz


Re: [NEW] net/profanity and net/libstrophe

2015-06-10 Thread Antoine Jacoutot
On Wed, Jun 10, 2015 at 10:40:04PM +0200, Rafael Sadowski wrote:
 Hey @ports,
 
 here is my favorite XMPP console client (with dependency lib). The port
 based on Brian Callahan work in openbsd-wip. (Okay to take maintainer).
 All tests passed and worked well over months for me. (Tested 5.6, 5.7
 and current @amd64)

You don't need pre-configure not the BUILD_DEPENDS on AUTO_* for net/profanity 
-- you can just use CONFIGURE_STYLE=autoconf
I think you should actualy fix the configure.ac patch and send it upstream 
(just make it match openbsd like it does for freebsd).

-- 
Antoine



[NEW] net/profanity and net/libstrophe

2015-06-10 Thread Rafael Sadowski
Hey @ports,

here is my favorite XMPP console client (with dependency lib). The port
based on Brian Callahan work in openbsd-wip. (Okay to take maintainer).
All tests passed and worked well over months for me. (Tested 5.6, 5.7
and current @amd64)

Best,

Rafael

net/profanity:

Profanity is a console based XMPP client written in C using ncurses and
libstrophe, inspired by irssi.

Features:

* Supports XMPP chat services, including Google Talk and Facebook.
* Command driven user interface.
* Customizable functionality and user interface.
* OTR (Off The Record) message encryption.
* Chat room support.
* Roster management.
* Flexible resource and priority settings.
* Desktop notifications.
* Unicode support.
* Integrated DuckDuckGo searching.
* Send tiny URLs.

net/libstrophe:

libstrophe is a minimal XMPP library written in C. It has almost no
external dependencies, only an XML parsing library (expat or libxml are
both supported). It is designed for both POSIX and Windows systems.


profanity.tar.gz
Description: application/tar-gz


libstrophe.tar.gz
Description: application/tar-gz


Re: [NEW] net/profanity and net/libstrophe

2015-06-10 Thread Rafael Sadowski
On Wed Jun 10, 2015 at 11:00:30PM +0200, Rafael Sadowski wrote:
 On Wed Jun 10, 2015 at 10:49:38PM +0200, Antoine Jacoutot wrote:
  On Wed, Jun 10, 2015 at 10:40:04PM +0200, Rafael Sadowski wrote:
   Hey @ports,
   
   here is my favorite XMPP console client (with dependency lib). The port
   based on Brian Callahan work in openbsd-wip. (Okay to take maintainer).
   All tests passed and worked well over months for me. (Tested 5.6, 5.7
   and current @amd64)
  
  You don't need pre-configure not the BUILD_DEPENDS on AUTO_* for 
  net/profanity -- you can just use CONFIGURE_STYLE=autoconf
  I think you should actualy fix the configure.ac patch and send it upstream 
  (just make it match openbsd like it does for freebsd).
  
  -- 
  Antoine
 
 Thanks Antoine,
 
 fix pre-configure-version as attachment. I'll fix it and send upstream.
 This version okay for commit?
 
 Rafael

... attachment :-/


profanity.tar.gz
Description: application/tar-gz


Re: [NEW] net/profanity and net/libstrophe

2015-06-10 Thread Rafael Sadowski
On Wed Jun 10, 2015 at 10:49:38PM +0200, Antoine Jacoutot wrote:
 On Wed, Jun 10, 2015 at 10:40:04PM +0200, Rafael Sadowski wrote:
  Hey @ports,
  
  here is my favorite XMPP console client (with dependency lib). The port
  based on Brian Callahan work in openbsd-wip. (Okay to take maintainer).
  All tests passed and worked well over months for me. (Tested 5.6, 5.7
  and current @amd64)
 
 You don't need pre-configure not the BUILD_DEPENDS on AUTO_* for 
 net/profanity -- you can just use CONFIGURE_STYLE=autoconf
 I think you should actualy fix the configure.ac patch and send it upstream 
 (just make it match openbsd like it does for freebsd).
 
 -- 
 Antoine

Thanks Antoine,

fix pre-configure-version as attachment. I'll fix it and send upstream.
This version okay for commit?

Rafael