Re: style rule: space around variables

2010-11-03 Thread Stuart Henderson
On 2010/11/03 00:19, Antoine Jacoutot wrote: On Tue, 2 Nov 2010, Steven Mestdagh wrote: Marc Espie [2010-10-31, 12:26:43]: I finally made up my mind about it. Those are the rules. Don't commit new ports without proper spacing. Whenever you update ports, if you have the time, please

Re: style rule: space around variables

2010-11-03 Thread Antoine Jacoutot
On Wed, 3 Nov 2010, Stuart Henderson wrote: On 2010/11/03 00:19, Antoine Jacoutot wrote: On Tue, 2 Nov 2010, Steven Mestdagh wrote: Marc Espie [2010-10-31, 12:26:43]: I finally made up my mind about it. Those are the rules. Don't commit new ports without proper spacing.

Re: style rule: space around variables

2010-11-03 Thread Marc Espie
On Wed, Nov 03, 2010 at 09:43:17AM +0100, Antoine Jacoutot wrote: On Wed, 3 Nov 2010, Stuart Henderson wrote: On 2010/11/03 00:19, Antoine Jacoutot wrote: On Tue, 2 Nov 2010, Steven Mestdagh wrote: Marc Espie [2010-10-31, 12:26:43]: I finally made up my mind about it. Those

Re: style rule: space around variables

2010-11-03 Thread Antoine Jacoutot
On Wed, 3 Nov 2010, Marc Espie wrote: Fix your eyes, seriously. It's a case of habit. I used to see VAR=value as more natural. But the bad consequences made me change that habit, and now I have absolutely no problem with the new style. Like I said, it's not an aesthetic choice.

Re: style rule: space around variables

2010-11-03 Thread Jasper Lievisse Adriaanse
On Wed, Nov 03, 2010 at 02:50:59PM +0100, Antoine Jacoutot wrote: On Wed, 3 Nov 2010, Marc Espie wrote: Fix your eyes, seriously. It's a case of habit. I used to see VAR=value as more natural. But the bad consequences made me change that habit, and now I have absolutely no

Re: style rule: space around variables

2010-11-03 Thread Federico G. Schwindt
On Wed, Nov 03, 2010 at 06:33:01PM +0100, Jasper Lievisse Adriaanse wrote: On Wed, Nov 03, 2010 at 02:50:59PM +0100, Antoine Jacoutot wrote: On Wed, 3 Nov 2010, Marc Espie wrote: Fix your eyes, seriously. It's a case of habit. I used to see VAR=value as more natural. But the

Re: style rule: space around variables

2010-11-03 Thread Landry Breuil
On Wed, Nov 03, 2010 at 06:33:01PM +0100, Jasper Lievisse Adriaanse wrote: On Wed, Nov 03, 2010 at 02:50:59PM +0100, Antoine Jacoutot wrote: On Wed, 3 Nov 2010, Marc Espie wrote: Fix your eyes, seriously. It's a case of habit. I used to see VAR=value as more natural. But the

Re: style rule: space around variables

2010-11-03 Thread Brad
On Wednesday 03 November 2010 09:50:59 Antoine Jacoutot wrote: Don't think that it's just me. Everyone has always been annoyed by this, it's not like I'm ranting alone in my corner. Far from it. The people who like this are the exception. -- This message has been scanned for viruses and

Re: style rule: space around variables

2010-11-03 Thread Jacob Meuser
On Wed, Nov 03, 2010 at 06:28:47PM +, Federico G. Schwindt wrote: On Wed, Nov 03, 2010 at 06:33:01PM +0100, Jasper Lievisse Adriaanse wrote: On Wed, Nov 03, 2010 at 02:50:59PM +0100, Antoine Jacoutot wrote: On Wed, 3 Nov 2010, Marc Espie wrote: Fix your eyes, seriously.

Re: style rule: space around variables

2010-11-03 Thread patrick keshishian
On Wed, Nov 3, 2010 at 4:38 PM, Brad b...@comstyle.com wrote: On Wednesday 03 November 2010 09:50:59 Antoine Jacoutot wrote: Don't think that it's just me. Everyone has always been annoyed by this, it's not like I'm ranting alone in my corner. Far from it. The people who like this are the

Re: style rule: space around variables

2010-11-03 Thread Marc Espie
On Wed, Nov 03, 2010 at 06:33:01PM +0100, Jasper Lievisse Adriaanse wrote: As expressed before, I concur. It's annoying. I understand the need for spaces with 'X=' (replace X with ! or whatever), but not for regular '='. So then you have to think when you really need the space, or worse, wait

Re: style rule: space around variables

2010-11-02 Thread Steven Mestdagh
Marc Espie [2010-10-31, 12:26:43]: I finally made up my mind about it. Those are the rules. Don't commit new ports without proper spacing. Whenever you update ports, if you have the time, please add the spacing. I don't have a problem with this, but I notice people send in diffs which mix

Re: style rule: space around variables

2010-11-02 Thread Antoine Jacoutot
On Tue, 2 Nov 2010, Steven Mestdagh wrote: Marc Espie [2010-10-31, 12:26:43]: I finally made up my mind about it. Those are the rules. Don't commit new ports without proper spacing. Whenever you update ports, if you have the time, please add the spacing. I don't have a problem with

style rule: space around variables

2010-10-31 Thread Marc Espie
I thought some more about it, and I'm going to be even more picky about this. I don't like A=value I really want to have: A = value in a Makefile. Or A = value if you want to indent stuff. Notice the spaces. They are here to make things totally unambiguous for make, and for a human. Our