Re: new: productivity/vit
28.10.2013 10:34 пользователь Brian Callahan bcal...@devio.us написал: On 10/28/2013 1:39 AM, Kent R. Spillner wrote: Attached is a tarball for productivity/vit; extract in /usr/ports/productivity. Vit is an ncurses front-end to taskwarrior with vi keybindings. HOMEPAGE = http://taskwarrior.org/projects/1/wiki/Vit Tested on amd64. If you get a blank screen when running, exit (ZZ or CTRL-C) and create a new task (task add Hello world). I'll work with upstream to ensure future releases handle an initial empty task database more gracefully. Notes: License is GPLv3+ DEPENDS list should look like this: RUN_DEPENDS = cat1/port1 \ cat2/port2 That comma doesn't mean what you think it means. So much whitespace. You can remove a lot of the newlines. Missing NO_TEST=Yes in the port Makefile. USE_GMAKE=Yes appears to be unneeded? Your patch is wrong. The files won't install with the correct mode or owner/group pair. You should use a do-install routine instead, since you only have two items in your PLIST. You will then be able to remove the patch (and patches/ directory) entirely. In the same vein, don't install things to /etc. You should install vit-commands instead to share/vit/vit-commands (using the do-install routine) and @sample it in the PLIST. No pkg/README, please. Merge the features list into pkg/DESCR and remove pkg/README. pkg/DESCR should be run through 'fmt -72' (incidentally, portcheck didn't pick this up... maybe it's worth adding?) Good catch, thanks. I'll add this check when I'll become fully online. Non-sampled things under /etc should be checked, probably, too, with exception of firmwares... You may want to keep http://www.openbsd.org/faq/ports/guide.html#PortsChecklist handy as you go through everything. ~Brian
Re: new: productivity/vit
On 10/31/2013 12:16 AM, Kent R. Spillner wrote:
Attached is another update based on your feedback:
Just some nitpicks:
Not quite with the @sample.
vit-commands is supposed to live in /etc, right?
Yeah, I completely messed that up, but I don't think that file belongs in /etc
or /usr/local/etc. It is only used for the help display inside vit; it's not
actually a configuration file (e.g. changing the keys assigned to functions
doesn't actually change the keymappings in vit).
In this version I install commands to ${PREFIX}/share/vit/commands, and added a
patch for vit.pl to look there when the user enters :help. I'm not @sample'ing
it because there's really no point in users editing it. Whaddya think?
I think putting it in share/vit/ is fine.
While it's not wrong, I think I'd prefer the first line of the
do-install use WRKSRC instead of WRKBUILD; for consistency if nothing else.
Done.
Besides that, it looks good to me and seems to work from my (admittedly
light) testing - caveat from your first mail heeded - perhaps that
should be added to the README if not resolved in a timely manner.
Done; I added a patch to README, which is installed to
$PREFIX/share/doc/vit/README.
This works for me (tested on amd64/macppc); I'm ok with it if someone
wants to give me the ok to import (or someone else can import it with ok
bcallah@)
~Brian
Re: new: productivity/vit
Attached is another update based on your feedback:
Just some nitpicks:
Not quite with the @sample.
vit-commands is supposed to live in /etc, right?
Yeah, I completely messed that up, but I don't think that file belongs in /etc
or /usr/local/etc. It is only used for the help display inside vit; it's not
actually a configuration file (e.g. changing the keys assigned to functions
doesn't actually change the keymappings in vit).
In this version I install commands to ${PREFIX}/share/vit/commands, and added a
patch for vit.pl to look there when the user enters :help. I'm not @sample'ing
it because there's really no point in users editing it. Whaddya think?
While it's not wrong, I think I'd prefer the first line of the
do-install use WRKSRC instead of WRKBUILD; for consistency if nothing else.
Done.
Besides that, it looks good to me and seems to work from my (admittedly
light) testing - caveat from your first mail heeded - perhaps that
should be added to the README if not resolved in a timely manner.
Done; I added a patch to README, which is installed to
$PREFIX/share/doc/vit/README.
vit.tar.gz
Description: application/gzip
Re: new: productivity/vit
On 10/28/2013 1:39 AM, Kent R. Spillner wrote: Attached is a tarball for productivity/vit; extract in /usr/ports/productivity. Vit is an ncurses front-end to taskwarrior with vi keybindings. HOMEPAGE = http://taskwarrior.org/projects/1/wiki/Vit Tested on amd64. If you get a blank screen when running, exit (ZZ or CTRL-C) and create a new task (task add Hello world). I'll work with upstream to ensure future releases handle an initial empty task database more gracefully. Notes: License is GPLv3+ DEPENDS list should look like this: RUN_DEPENDS = cat1/port1 \ cat2/port2 That comma doesn't mean what you think it means. So much whitespace. You can remove a lot of the newlines. Missing NO_TEST=Yes in the port Makefile. USE_GMAKE=Yes appears to be unneeded? Your patch is wrong. The files won't install with the correct mode or owner/group pair. You should use a do-install routine instead, since you only have two items in your PLIST. You will then be able to remove the patch (and patches/ directory) entirely. In the same vein, don't install things to /etc. You should install vit-commands instead to share/vit/vit-commands (using the do-install routine) and @sample it in the PLIST. No pkg/README, please. Merge the features list into pkg/DESCR and remove pkg/README. pkg/DESCR should be run through 'fmt -72' (incidentally, portcheck didn't pick this up... maybe it's worth adding?) You may want to keep http://www.openbsd.org/faq/ports/guide.html#PortsChecklist handy as you go through everything. ~Brian
Re: new: productivity/vit
On 2013/10/28 02:32, Brian Callahan wrote: No pkg/README, please. Merge the features list into pkg/DESCR and remove pkg/README. yes, pkg/README is not a place to copy upstream's README (maybe it makes sense to install that into /usr/local/share/doc/vit via post-install/do-install) it's for OpenBSD-specific information and should be based on the template in ports/infrastructure/templates/README.template.
Re: new: productivity/vit
On 10/29/2013 12:01 AM, Kent R. Spillner wrote:
yes, pkg/README is not a place to copy upstream's README (maybe it makes sense
to install that into /usr/local/share/doc/vit via post-install/do-install)
it's for OpenBSD-specific information and should be based on the template
in ports/infrastructure/templates/README.template.
Attached is a new version incorporating Brian's feedback. After reviewing the README I
decided the features list doesn't add much, so I decided not to roll it into
pkg/DESCR. I am installing it into /usr/local/share/doc/vit, though.
Just some nitpicks:
Not quite with the @sample.
vit-commands is supposed to live in /etc, right? Then it should look
like this:
share/vit/vit-commands
@sample ${SYSCONFDIR}/vit-commands
(this ensures that you never replace or modify existing files in /etc
and that vit-commands will end up in the package - see point 14 of the
ports checklist I linked to in my previous email)
While it's not wrong, I think I'd prefer the first line of the
do-install use WRKSRC instead of WRKBUILD; for consistency if nothing else.
Besides that, it looks good to me and seems to work from my (admittedly
light) testing - caveat from your first mail heeded - perhaps that
should be added to the README if not resolved in a timely manner.
~Brian
Re: new: productivity/vit
yes, pkg/README is not a place to copy upstream's README (maybe it makes sense to install that into /usr/local/share/doc/vit via post-install/do-install) it's for OpenBSD-specific information and should be based on the template in ports/infrastructure/templates/README.template. Attached is a new version incorporating Brian's feedback. After reviewing the README I decided the features list doesn't add much, so I decided not to roll it into pkg/DESCR. I am installing it into /usr/local/share/doc/vit, though. vit.tar.gz Description: application/gzip
