Re: [Potlatch-dev] State of play

[Steve Bennett]

On Mon, Mar 5, 2012 at 11:54 AM, Richard Fairhurst  wrote:
> Today's commit log is at:
> https://github.com/systemed/potlatch2/commits/master

Thanks for the update. It's nice to get acknowledgement of our work,
even if it's not merged yet.

> I've not yet merged in Steve's highway=proposed/construction addition, the

I think this one is actually pretty straightforward, surprisingly. It
would be nice to make the proposed/construction stuff work like a
dropdown on every normal highway, but this basic implementation is
still a lot better than nothing. Although my bulldozer artwork could
be improved :)

> "undo on creating way" fix,

Definitely worthy of review - it's totally possible that I broke
something else. Anyone else want to have a look at it? I guess we
don't have any tests?

and the two combined commits which need to be
> cherry-picked and merged in individually
> (https://github.com/systemed/potlatch2/pull/24 and
> https://github.com/systemed/potlatch2/pull/25) - I'll look at these when I
> have time and sufficient git-fu.

My Git-fu is gradually improving to the point where I think I can
probably decompose them. I'll try and cherry pick them apart and
resubmit as individual pull requests.

> Current most obvious bug that I can see is that (in en-GB at least) the
> dreaded "[object Object]" is back on the GPS menu.

Yeah, I've had that intermittently on my XP/firefox desktop. Only
intermittently though...

Steve

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev

Re: [Potlatch-dev] State of play

[Richard Fairhurst]

Current most obvious bug that I can see is that (in en-GB at least) the
dreaded "[object Object]" is back on the GPS menu.


Oh, and landuse=cemetery renders as a black opaque area. Appropriate I 
guess but probably not great for editing. :)


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev

[Potlatch-dev] State of play

[Richard Fairhurst]

Today's commit log is at:
https://github.com/systemed/potlatch2/commits/master

I've merged all the stuff that could be obviously merged in without a 
whole bunch of head-scratching. Thanks to Andy, Steve and Tom for a 
whole bunch of fixes. This should all be live now (thanks Tom).


I've not yet merged in Steve's highway=proposed/construction addition, 
the "undo on creating way" fix, and the two combined commits which need 
to be cherry-picked and merged in individually 
(https://github.com/systemed/potlatch2/pull/24 and 
https://github.com/systemed/potlatch2/pull/25) - I'll look at these when 
I have time and sufficient git-fu.


I've added a spinner to make the "loading data" incantation more obvious 
(this is a fairly commonly requested feature). This is also live.


I've merged Andy's excellent form-layout branch, which uses Flex forms 
for laying out the simple tag editor - both faster and better-looking. 
Two particular issues with this (Flex's fault, not Andy's) took up 
pretty much all the afternoon, but it's done now. Hopefully live soon.


I've also got three or four branches that I've been working on that are 
almost ready to merge.


Current most obvious bug that I can see is that (in en-GB at least) the 
dreaded "[object Object]" is back on the GPS menu.


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev

Re: [Potlatch-dev] [OpenStreetMap] #3775: please move tag "sports_centre" from "buildings" section to "sport and leisure" section

[OpenStreetMap]

#3775: please move tag "sports_centre" from "buildings" section to "sport and
leisure" section
+---
  Reporter:  kjon   |   Owner:  potlatch-dev@…
  Type:  defect |  Status:  closed
  Priority:  major  |   Milestone:
 Component:  potlatch2  | Version:
Resolution:  fixed  |Keywords:  leisure=sports_centre 
+---
Changes (by stevage):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 Done. https://github.com/systemed/potlatch2/pull/37

-- 
Ticket URL: 
OpenStreetMap 
OpenStreetMap is a free editable map of the whole world

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev

Re: [Potlatch-dev] [OpenStreetMap] #4045: Problems with P2 after multiselecting ways

[OpenStreetMap]

#4045: Problems with P2 after multiselecting ways
---+
 Reporter:  EdLoach|   Owner:  potlatch-dev@…
 Type:  defect |  Status:  new   
 Priority:  trivial|   Milestone:
Component:  potlatch2  | Version:
 Keywords: |  
---+

Comment(by stevage):

 Fix trac formatting:

  1. Create ways tagged "note=1" and "note=2"
  2. Multi-select both (ie, ctrl+click) [you'll see note=]
  3. Change "note" to "ref"
  4. When you press enter after "note", the focus shifts to the tag value,
 which  contains the text ""
  5. Clicking away to deselect seems to cause the actual value
 "" to be  stored on each way
  6. Select one way, and type a value instead of , say "11"
  7. The other way, even though it's not selected, also receives this new
 value.

-- 
Ticket URL: 
OpenStreetMap 
OpenStreetMap is a free editable map of the whole world

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev

Re: [Potlatch-dev] [OpenStreetMap] #4080: Potlatch does not understand building types

[OpenStreetMap]

#4080: Potlatch does not understand building types
+---
  Reporter:  Zverik |   Owner:  potlatch-dev@…
  Type:  defect |  Status:  closed
  Priority:  major  |   Milestone:
 Component:  potlatch2  | Version:  2.0   
Resolution:  fixed  |Keywords:  building  
+---
Changes (by stevage):

  * status:  new => closed
  * resolution:  => fixed


-- 
Ticket URL: 
OpenStreetMap 
OpenStreetMap is a free editable map of the whole world

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev

Re: [Potlatch-dev] [OpenStreetMap] #3700: Arrow Keys change Tags when moving map

[OpenStreetMap]

#3700: Arrow Keys change Tags when moving map
---+
 Reporter:  Peter W34  |   Owner:  potlatch-dev@…
 Type:  defect |  Status:  new   
 Priority:  major  |   Milestone:
Component:  potlatch2  | Version:  2.0   
 Keywords: |  
---+

Comment(by stevage):

 I can't reproduce this at all - I can't find any situation where arrow
 keys cause the feature type to change. The closest I can find is if you
 stop editing a field in the advanced tag editor, then up/down will
 simultaneously move the mouse and also move to a different tag. It doesn't
 change any values though.

-- 
Ticket URL: 
OpenStreetMap 
OpenStreetMap is a free editable map of the whole world

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev

[Potlatch-dev] [OpenStreetMap] #4265: Unconnected roads

[OpenStreetMap]

#4265: Unconnected roads
---+
 Reporter:  Maetma |   Owner:  potlatch-dev@…
 Type:  defect |  Status:  new   
 Priority:  major  |   Milestone:
Component:  potlatch2  | Version:
 Keywords: |  
---+
 Many new users add roads that are not connected to any other road with
 Potlatch. Potlatch should avert them of the mistake. It takes a lot of
 time to fix.

-- 
Ticket URL: 
OpenStreetMap 
OpenStreetMap is a free editable map of the whole world

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev

[Potlatch-dev] [OpenStreetMap] #4264: Incorrect road

[OpenStreetMap]

#4264: Incorrect road
---+
 Reporter:  Maetma |   Owner:  potlatch-dev@…
 Type:  defect |  Status:  new   
 Priority:  major  |   Milestone:
Component:  potlatch2  | Version:  2.0   
 Keywords: |  
---+
 Many new users add roads that are superposed with Potlatch. Create this
 roads should be forbidden by Potlacth. It takes a lot of time to fix.

-- 
Ticket URL: 
OpenStreetMap 
OpenStreetMap is a free editable map of the whole world

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev

Re: [Potlatch-dev] [OpenStreetMap] #3529: Support for proposed/construction

[OpenStreetMap]

#3529: Support for proposed/construction
--+-
  Reporter:  stevage  |   Owner:  potlatch-dev@…
  Type:  enhancement  |  Status:  closed
  Priority:  major|   Milestone:
 Component:  potlatch2| Version:
Resolution:  fixed|Keywords:
--+-
Changes (by stevage):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 Did it the obvious way here:

 https://github.com/systemed/potlatch2/pull/36

-- 
Ticket URL: 
OpenStreetMap 
OpenStreetMap is a free editable map of the whole world

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev

Re: [Potlatch-dev] [OpenStreetMap] #4045: Problems with P2 after multiselecting ways

[OpenStreetMap]

#4045: Problems with P2 after multiselecting ways
---+
 Reporter:  EdLoach|   Owner:  potlatch-dev@…
 Type:  defect |  Status:  new   
 Priority:  trivial|   Milestone:
Component:  potlatch2  | Version:
 Keywords: |  
---+

Comment(by stevage):

 I had trouble understanding this at first, but can reproduce it, so for
 the benefit of others:

 1. Create ways tagged "note=1" and "note=2"
 2. Multi-select both (ie, ctrl+click) [you'll see note=]
 3. Change "note" to "ref"
 4. When you press enter after "note", the focus shifts to the tag value,
 which contains the text ""
 5. Clicking away to deselect seems to cause the actual value ""
 to be stored on each way
 6. Select one way, and type a value instead of , say "11"
 7. The other way, even though it's not selected, also receives this new
 value.

-- 
Ticket URL: 
OpenStreetMap 
OpenStreetMap is a free editable map of the whole world

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev