[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218554481 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -328,7 +356,6 @@ else if (useStrictConsistency) * Get a map of all

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218547456 --- Diff: src/java/org/apache/cassandra/locator/RangesAtEndpoint.java --- @@ -302,6 +303,11 @@ public static RangesAtEndpoint toDummyList(Collection>

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218547170 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -600,39 +628,38 @@ public StreamResultFuture fetchAsync()

[GitHub] cassandra-dtest pull request #37: Add tests for CASSANDRA-14145

2018-09-18 Thread jrwest
Github user jrwest commented on a diff in the pull request: https://github.com/apache/cassandra-dtest/pull/37#discussion_r218529082 --- Diff: repair_tests/incremental_repair_test.py --- @@ -207,6 +208,7 @@ def test_manual_session_fail(self):

[GitHub] cassandra pull request #272: CASSANDRA-14757 Fix accessing java.nio.Bits.tot...

2018-09-18 Thread snazy
GitHub user snazy opened a pull request: https://github.com/apache/cassandra/pull/272 CASSANDRA-14757 Fix accessing java.nio.Bits.totalCapacity/TOTAL_CAPACITY and AtomicLong You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cassandra pull request #225: Fix NPE, CASSANDRA-14444

2018-09-18 Thread xiaodong-xie
Github user xiaodong-xie closed the pull request at: https://github.com/apache/cassandra/pull/225 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail:

[GitHub] cassandra pull request #270: 14759

2018-09-18 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/270#discussion_r218488201 --- Diff: src/java/org/apache/cassandra/locator/ReplicaLayout.java --- @@ -275,7 +275,24 @@ public ForTokenWrite(EndpointsForToken natural,

[GitHub] cassandra pull request #270: 14759

2018-09-18 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/270#discussion_r218483495 --- Diff: src/java/org/apache/cassandra/locator/ReplicaLayout.java --- @@ -275,7 +275,24 @@ public ForTokenWrite(EndpointsForToken natural,

[GitHub] cassandra pull request #270: 14759

2018-09-18 Thread belliottsmith
GitHub user belliottsmith opened a pull request: https://github.com/apache/cassandra/pull/270 14759 You can merge this pull request into a Git repository by running: $ git pull https://github.com/belliottsmith/cassandra 14759 Alternatively you can review and apply these

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218470693 --- Diff: src/java/org/apache/cassandra/streaming/StreamPlan.java --- @@ -70,6 +70,16 @@ public StreamPlan(StreamOperation streamOperation, int

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218462328 --- Diff: src/java/org/apache/cassandra/streaming/StreamPlan.java --- @@ -70,6 +70,16 @@ public StreamPlan(StreamOperation streamOperation, int

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218432647 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -87,8 +85,8 @@ private final InetAddressAndPort address; /*

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218388108 --- Diff: src/java/org/apache/cassandra/dht/StreamStateStore.java --- @@ -54,8 +56,10 @@ public RangesAtEndpoint getAvailableRanges(String

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218383166 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -337,165 +364,167 @@ else if (useStrictConsistency)

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218387370 --- Diff: src/java/org/apache/cassandra/streaming/StreamPlan.java --- @@ -70,6 +70,16 @@ public StreamPlan(StreamOperation streamOperation, int

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218387701 --- Diff: src/java/org/apache/cassandra/db/SystemKeyspace.java --- @@ -1288,24 +1288,25 @@ public static synchronized void

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218383055 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -337,165 +364,167 @@ else if (useStrictConsistency)

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218382891 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -87,8 +85,8 @@ private final InetAddressAndPort address; /*

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218382719 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -328,7 +356,6 @@ else if (useStrictConsistency) * Get a map of all

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread belliottsmith
Github user belliottsmith commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218371266 --- Diff: test/unit/org/apache/cassandra/dht/BootStrapperTest.java --- @@ -125,21 +125,19 @@ public boolean isAlive(InetAddressAndPort ep)

[GitHub] cassandra-dtest pull request #37: Add tests for CASSANDRA-14145

2018-09-18 Thread beobal
Github user beobal commented on a diff in the pull request: https://github.com/apache/cassandra-dtest/pull/37#discussion_r218336047 --- Diff: repair_tests/incremental_repair_test.py --- @@ -918,3 +931,196 @@ def test_subrange(self):

[GitHub] cassandra-dtest pull request #37: Add tests for CASSANDRA-14145

2018-09-18 Thread beobal
Github user beobal commented on a diff in the pull request: https://github.com/apache/cassandra-dtest/pull/37#discussion_r218336062 --- Diff: repair_tests/incremental_repair_test.py --- @@ -918,3 +931,196 @@ def test_subrange(self):

[GitHub] cassandra-dtest pull request #37: Add tests for CASSANDRA-14145

2018-09-18 Thread beobal
Github user beobal commented on a diff in the pull request: https://github.com/apache/cassandra-dtest/pull/37#discussion_r218336071 --- Diff: repair_tests/incremental_repair_test.py --- @@ -207,6 +208,7 @@ def test_manual_session_fail(self):

[GitHub] cassandra-dtest pull request #37: Add tests for CASSANDRA-14145

2018-09-18 Thread beobal
Github user beobal commented on a diff in the pull request: https://github.com/apache/cassandra-dtest/pull/37#discussion_r218336055 --- Diff: repair_tests/incremental_repair_test.py --- @@ -918,3 +931,196 @@ def test_subrange(self):