[GitHub] cassandra pull request #276: Repair job tests

2018-10-08 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/276#discussion_r223013279 --- Diff: test/unit/org/apache/cassandra/repair/RepairJobTest.java --- @@ -0,0 +1,569 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #278: Avoid running query to self through messaging s...

2018-10-08 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/278#discussion_r223398346 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1078,7 +1078,7 @@ public void sendOneWay(MessageOut message, int id,

[GitHub] cassandra pull request #278: Avoid running query to self through messaging s...

2018-10-08 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/278#discussion_r223396208 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1078,7 +1078,7 @@ public void sendOneWay(MessageOut message, int id,

[GitHub] cassandra pull request #277: 12106 - blacklisting bad partitions for point r...

2018-10-08 Thread vinaykumarchella
Github user vinaykumarchella commented on a diff in the pull request: https://github.com/apache/cassandra/pull/277#discussion_r223517674 --- Diff: src/java/org/apache/cassandra/repair/SystemDistributedKeyspace.java --- @@ -307,6 +320,42 @@ public static void setViewRemoved(String

[GitHub] cassandra pull request #277: 12106 - blacklisting bad partitions for point r...

2018-10-08 Thread vinaykumarchella
Github user vinaykumarchella commented on a diff in the pull request: https://github.com/apache/cassandra/pull/277#discussion_r223516968 --- Diff: src/java/org/apache/cassandra/cache/BlacklistedPartition.java --- @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #277: 12106 - blacklisting bad partitions for point r...

2018-10-08 Thread vinaykumarchella
Github user vinaykumarchella commented on a diff in the pull request: https://github.com/apache/cassandra/pull/277#discussion_r223518337 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -1545,6 +1546,18 @@ public static PartitionIterator

[GitHub] cassandra pull request #277: 12106 - blacklisting bad partitions for point r...

2018-10-08 Thread vinaykumarchella
Github user vinaykumarchella commented on a diff in the pull request: https://github.com/apache/cassandra/pull/277#discussion_r223517840 --- Diff: src/java/org/apache/cassandra/repair/SystemDistributedKeyspace.java --- @@ -307,6 +320,42 @@ public static void setViewRemoved(String

[GitHub] cassandra pull request #277: 12106 - blacklisting bad partitions for point r...

2018-10-08 Thread vinaykumarchella
Github user vinaykumarchella commented on a diff in the pull request: https://github.com/apache/cassandra/pull/277#discussion_r223517462 --- Diff: src/java/org/apache/cassandra/config/Config.java --- @@ -257,6 +257,9 @@ public volatile int counter_cache_save_period = 7200;

[GitHub] cassandra pull request #277: 12106 - blacklisting bad partitions for point r...

2018-10-08 Thread vinaykumarchella
Github user vinaykumarchella commented on a diff in the pull request: https://github.com/apache/cassandra/pull/277#discussion_r223518571 --- Diff: test/unit/org/apache/cassandra/cache/BlacklistedPartitionsCacheTest.java --- @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache

[GitHub] cassandra pull request #277: 12106 - blacklisting bad partitions for point r...

2018-10-08 Thread sumanth-pasupuleti
Github user sumanth-pasupuleti commented on a diff in the pull request: https://github.com/apache/cassandra/pull/277#discussion_r223545254 --- Diff: src/java/org/apache/cassandra/repair/SystemDistributedKeyspace.java --- @@ -307,6 +320,42 @@ public static void

[GitHub] cassandra pull request #277: 12106 - blacklisting bad partitions for point r...

2018-10-08 Thread sumanth-pasupuleti
Github user sumanth-pasupuleti commented on a diff in the pull request: https://github.com/apache/cassandra/pull/277#discussion_r223544939 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -1545,6 +1546,18 @@ public static PartitionIterator

[GitHub] cassandra pull request #277: 12106 - blacklisting bad partitions for point r...

2018-10-08 Thread sumanth-pasupuleti
Github user sumanth-pasupuleti commented on a diff in the pull request: https://github.com/apache/cassandra/pull/277#discussion_r223545187 --- Diff: test/unit/org/apache/cassandra/cache/BlacklistedPartitionsCacheTest.java --- @@ -0,0 +1,175 @@ +/* + * Licensed to the

[GitHub] cassandra pull request #277: 12106 - blacklisting bad partitions for point r...

2018-10-08 Thread sumanth-pasupuleti
Github user sumanth-pasupuleti commented on a diff in the pull request: https://github.com/apache/cassandra/pull/277#discussion_r223544527 --- Diff: src/java/org/apache/cassandra/config/Config.java --- @@ -257,6 +257,9 @@ public volatile int counter_cache_save_period =

[GitHub] cassandra-dtest pull request #39: Add no-read assert to read-repair test

2018-10-08 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra-dtest/pull/39#discussion_r223397826 --- Diff: read_repair_test.py --- @@ -495,6 +495,9 @@ def test_normal_read_repair(self): assert storage_proxy.speculated_rr_read

[GitHub] cassandra pull request #278: Avoid running query to self through messaging s...

2018-10-08 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/278#discussion_r223421365 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1078,7 +1078,7 @@ public void sendOneWay(MessageOut message, int id,