[GitHub] cassandra-dtest pull request #9: 10857 trunk

2017-11-07 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra-dtest/pull/9#discussion_r149322322 --- Diff: upgrade_tests/upgrade_compact_storage.py --- @@ -0,0 +1,177 @@ +# coding: utf-8 + +import time + +from cassandra.query

[GitHub] cassandra-dtest pull request #9: 10857 trunk

2017-11-07 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra-dtest/pull/9#discussion_r149320134 --- Diff: requirements.txt --- @@ -3,7 +3,7 @@ # http://datastax.github.io/python-driver/installation.html#cython-based-extensions

[GitHub] cassandra-dtest pull request #9: 10857 trunk

2017-11-06 Thread ifesdjeen
GitHub user ifesdjeen opened a pull request: https://github.com/apache/cassandra-dtest/pull/9 10857 trunk You can merge this pull request into a Git repository by running: $ git pull https://github.com/ifesdjeen/cassandra-dtest 10857-trunk Alternatively you can review

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197126256 --- Diff: src/java/org/apache/cassandra/db/ConsistencyLevel.java --- @@ -242,11 +249,11 @@ public boolean isSufficientLiveNodes(Keyspace keyspace

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197156136 --- Diff: src/java/org/apache/cassandra/service/StorageService.java --- @@ -4231,53 +4211,53 @@ private void calculateToFromStreams(Collection

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197156892 --- Diff: src/java/org/apache/cassandra/locator/TokenMetadata.java --- @@ -733,19 +733,19 @@ public InetAddressAndPort getEndpoint(Token token

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197131214 --- Diff: src/java/org/apache/cassandra/locator/ReplicationFactor.java --- @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197130790 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,270 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197133241 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -344,47 +343,43 @@ private static void recordCasContention(int contentions

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197149200 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -1275,36 +1272,38 @@ private static WriteResponseHandlerWrapper

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197156422 --- Diff: src/java/org/apache/cassandra/service/StorageService.java --- @@ -4231,53 +4211,53 @@ private void calculateToFromStreams(Collection

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197124802 --- Diff: src/java/org/apache/cassandra/db/ConsistencyLevel.java --- @@ -148,40 +150,45 @@ public boolean isLocal(InetAddressAndPort endpoint

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197136141 --- Diff: src/java/org/apache/cassandra/service/StorageService.java --- @@ -4231,53 +4211,53 @@ private void calculateToFromStreams(Collection

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197131513 --- Diff: src/java/org/apache/cassandra/locator/ReplicationFactor.java --- @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197129915 --- Diff: src/java/org/apache/cassandra/locator/NetworkTopologyStrategy.java --- @@ -90,41 +98,53 @@ public NetworkTopologyStrategy(String keyspaceName

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197126709 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -259,36 +266,36 @@ private boolean useStrictSourcesForRanges(String keyspaceName

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197125691 --- Diff: src/java/org/apache/cassandra/db/ConsistencyLevel.java --- @@ -190,50 +197,50 @@ public int countLocalEndpoints(Iterable liveEndpoints

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197161771 --- Diff: test/microbench/org/apache/cassandra/test/microbench/PendingRangesBench.java --- @@ -97,13 +103,13 @@ public void

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197153506 --- Diff: src/java/org/apache/cassandra/db/view/ViewUtils.java --- @@ -58,46 +57,55 @@ private ViewUtils() * * @return

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197132925 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -344,47 +343,43 @@ private static void recordCasContention(int contentions

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197159962 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,270 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197136522 --- Diff: src/java/org/apache/cassandra/service/StorageService.java --- @@ -4231,53 +4211,53 @@ private void calculateToFromStreams(Collection

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197128495 --- Diff: src/java/org/apache/cassandra/locator/AbstractReplicationStrategy.java --- @@ -329,6 +335,10 @@ public static void

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197129440 --- Diff: src/java/org/apache/cassandra/locator/NetworkTopologyStrategy.java --- @@ -90,41 +98,53 @@ public NetworkTopologyStrategy(String keyspaceName

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197154559 --- Diff: src/java/org/apache/cassandra/locator/AbstractReplicationStrategy.java --- @@ -202,61 +204,65 @@ private Keyspace getKeyspace

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197125767 --- Diff: src/java/org/apache/cassandra/db/ConsistencyLevel.java --- @@ -190,50 +197,50 @@ public int countLocalEndpoints(Iterable liveEndpoints

[GitHub] cassandra pull request #224: 14405 replicas

2018-06-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r197130296 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,270 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #257: Allow transient range owner to serve as repair ...

2018-09-05 Thread ifesdjeen
GitHub user ifesdjeen opened a pull request: https://github.com/apache/cassandra/pull/257 Allow transient range owner to serve as repair coordinator You can merge this pull request into a Git repository by running: $ git pull https://github.com/ifesdjeen/cassandra tr-followup

[GitHub] cassandra pull request #257: Allow transient range owner to serve as repair ...

2018-09-05 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/257#discussion_r215442476 --- Diff: src/java/org/apache/cassandra/repair/RepairRunnable.java --- @@ -651,7 +651,7 @@ private static void addRangeToNeighbors(List

[GitHub] cassandra pull request #261: Tr followup 4

2018-09-07 Thread ifesdjeen
GitHub user ifesdjeen opened a pull request: https://github.com/apache/cassandra/pull/261 Tr followup 4 cc @belliottsmith You can merge this pull request into a Git repository by running: $ git pull https://github.com/ifesdjeen/cassandra tr-followup-4 Alternatively you can

[GitHub] cassandra pull request #259: Cleanup repair path after Transient Replication

2018-09-06 Thread ifesdjeen
GitHub user ifesdjeen opened a pull request: https://github.com/apache/cassandra/pull/259 Cleanup repair path after Transient Replication You can merge this pull request into a Git repository by running: $ git pull https://github.com/ifesdjeen/cassandra tr-followup-3

[GitHub] cassandra pull request #257: Allow transient range owner to serve as repair ...

2018-09-06 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/257#discussion_r215776606 --- Diff: src/java/org/apache/cassandra/repair/LocalSyncTask.java --- @@ -39,43 +40,60 @@ import org.apache.cassandra.tracing.TraceState

[GitHub] cassandra pull request #257: Allow transient range owner to serve as repair ...

2018-09-06 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/257#discussion_r215776645 --- Diff: src/java/org/apache/cassandra/repair/RepairJob.java --- @@ -165,107 +166,116 @@ private boolean isTransient(InetAddressAndPort ep

[GitHub] cassandra pull request #257: Allow transient range owner to serve as repair ...

2018-09-06 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/257#discussion_r215776814 --- Diff: src/java/org/apache/cassandra/service/ActiveRepairService.java --- @@ -20,10 +20,25 @@ import java.io.IOException; import

[GitHub] cassandra issue #257: Allow transient range owner to serve as repair coordin...

2018-09-06 Thread ifesdjeen
Github user ifesdjeen commented on the issue: https://github.com/apache/cassandra/pull/257 @aweisberg fixed imports and spelling. Thank you for spotting those. --- - To unsubscribe, e-mail: pr-unsubscr

[GitHub] cassandra pull request #262: Replicalayout followup

2018-09-07 Thread ifesdjeen
GitHub user ifesdjeen opened a pull request: https://github.com/apache/cassandra/pull/262 Replicalayout followup You can merge this pull request into a Git repository by running: $ git pull https://github.com/belliottsmith/cassandra replicalayout-followup Alternatively you

[GitHub] cassandra pull request #271: 14726

2018-09-27 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220951620 --- Diff: src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java --- @@ -58,45 +63,332

[GitHub] cassandra pull request #271: 14726

2018-09-27 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220966312 --- Diff: src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java --- @@ -58,45 +63,332

[GitHub] cassandra pull request #271: 14726

2018-09-27 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220986153 --- Diff: src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java --- @@ -58,45 +63,332

[GitHub] cassandra-dtest pull request #39: Add no-read assert to read-repair test

2018-10-05 Thread ifesdjeen
GitHub user ifesdjeen opened a pull request: https://github.com/apache/cassandra-dtest/pull/39 Add no-read assert to read-repair test You can merge this pull request into a Git repository by running: $ git pull https://github.com/ifesdjeen/cassandra-dtest avoid-querying-self

[GitHub] cassandra issue #276: Repair job tests

2018-10-05 Thread ifesdjeen
Github user ifesdjeen commented on the issue: https://github.com/apache/cassandra/pull/276 I've fixed your suggestions @krummas, should I commit? --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

[GitHub] cassandra pull request #276: Repair job tests

2018-10-08 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/276#discussion_r223013279 --- Diff: test/unit/org/apache/cassandra/repair/RepairJobTest.java --- @@ -0,0 +1,569 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #281: Sep worker shutdown

2018-10-11 Thread ifesdjeen
GitHub user ifesdjeen opened a pull request: https://github.com/apache/cassandra/pull/281 Sep worker shutdown You can merge this pull request into a Git repository by running: $ git pull https://github.com/ifesdjeen/cassandra sep-worker-shutdown Alternatively you can review

[GitHub] cassandra pull request #282: Implement in-jvm distributed tests prototype / ...

2018-10-12 Thread ifesdjeen
GitHub user ifesdjeen opened a pull request: https://github.com/apache/cassandra/pull/282 Implement in-jvm distributed tests prototype / MVP You can merge this pull request into a Git repository by running: $ git pull https://github.com/ifesdjeen/cassandra in-jvm-distributed

[GitHub] cassandra issue #278: Avoid running query to self through messaging service

2018-10-12 Thread ifesdjeen
Github user ifesdjeen commented on the issue: https://github.com/apache/cassandra/pull/278 Thank you for the review! --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail

[GitHub] cassandra pull request #278: Avoid running query to self through messaging s...

2018-10-12 Thread ifesdjeen
Github user ifesdjeen closed the pull request at: https://github.com/apache/cassandra/pull/278 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra-dtest issue #39: Add no-read assert to read-repair test

2018-10-12 Thread ifesdjeen
Github user ifesdjeen commented on the issue: https://github.com/apache/cassandra-dtest/pull/39 Thank you for the review, committed the latest version manually --- - To unsubscribe, e-mail: pr-unsubscr

[GitHub] cassandra-dtest pull request #39: Add no-read assert to read-repair test

2018-10-12 Thread ifesdjeen
Github user ifesdjeen closed the pull request at: https://github.com/apache/cassandra-dtest/pull/39 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h

[GitHub] cassandra pull request #282: Implement in-jvm distributed tests prototype / ...

2018-10-12 Thread ifesdjeen
Github user ifesdjeen closed the pull request at: https://github.com/apache/cassandra/pull/282 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra pull request #276: Repair job tests

2018-10-05 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/276#discussion_r222952584 --- Diff: test/unit/org/apache/cassandra/repair/RepairJobTest.java --- @@ -0,0 +1,569 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #276: Repair job tests

2018-10-05 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/276#discussion_r222954234 --- Diff: test/unit/org/apache/cassandra/repair/RepairJobTest.java --- @@ -0,0 +1,569 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #276: Repair job tests

2018-10-05 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/276#discussion_r222953530 --- Diff: test/unit/org/apache/cassandra/repair/RepairJobTest.java --- @@ -0,0 +1,569 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #276: Repair job tests

2018-10-05 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/276#discussion_r222953487 --- Diff: test/unit/org/apache/cassandra/repair/RepairJobTest.java --- @@ -0,0 +1,569 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #276: Repair job tests

2018-10-05 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/276#discussion_r222952614 --- Diff: test/unit/org/apache/cassandra/repair/RepairJobTest.java --- @@ -0,0 +1,569 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #276: Repair job tests

2018-10-05 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/276#discussion_r222952423 --- Diff: src/java/org/apache/cassandra/repair/LocalSyncTask.java --- @@ -52,15 +52,9 @@ private static final Logger logger

[GitHub] cassandra-dtest pull request #39: Add no-read assert to read-repair test

2018-10-09 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra-dtest/pull/39#discussion_r223734988 --- Diff: read_repair_test.py --- @@ -495,6 +495,9 @@ def test_normal_read_repair(self): assert storage_proxy.speculated_rr_read

[GitHub] cassandra pull request #271: 14726

2018-10-01 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r221529863 --- Diff: src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java --- @@ -58,45 +63,332

[GitHub] cassandra pull request #271: 14726

2018-10-01 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r221529971 --- Diff: src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java --- @@ -58,45 +63,332

[GitHub] cassandra pull request #278: Avoid running query to self through messaging s...

2018-10-10 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/278#discussion_r224060251 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1078,7 +1078,7 @@ public void sendOneWay(MessageOut message, int id

[GitHub] cassandra pull request #276: Repair job tests

2018-10-02 Thread ifesdjeen
GitHub user ifesdjeen opened a pull request: https://github.com/apache/cassandra/pull/276 Repair job tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/ifesdjeen/cassandra repair-job-tests Alternatively you can review

[GitHub] cassandra pull request #267: Consolidate batch write code

2018-10-04 Thread ifesdjeen
Github user ifesdjeen closed the pull request at: https://github.com/apache/cassandra/pull/267 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra pull request #278: Avoid running query to self through messaging s...

2018-10-08 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/278#discussion_r223421365 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1078,7 +1078,7 @@ public void sendOneWay(MessageOut message, int id

[GitHub] cassandra pull request #278: Avoid running query to self through messaging s...

2018-10-09 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/278#discussion_r223868092 --- Diff: src/java/org/apache/cassandra/service/reads/repair/AbstractReadRepair.java --- @@ -102,12 +104,24 @@ void sendReadCommand(Replica

[GitHub] cassandra pull request #276: Repair job tests

2018-10-09 Thread ifesdjeen
Github user ifesdjeen closed the pull request at: https://github.com/apache/cassandra/pull/276 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r219410357 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -446,16 +447,14 @@ else if (useStrictConsistency

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r219488342 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -436,6 +436,7 @@ else if (useStrictConsistency) Set

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r219488550 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -446,16 +447,14 @@ else if (useStrictConsistency

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r219488307 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -265,10 +318,11 @@ public void addRanges(String keyspaceName, ReplicaCollection

[GitHub] cassandra pull request #266: Add a check for receiving digest response from ...

2018-09-21 Thread ifesdjeen
Github user ifesdjeen closed the pull request at: https://github.com/apache/cassandra/pull/266 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r219488654 --- Diff: src/java/org/apache/cassandra/service/RangeRelocator.java --- @@ -0,0 +1,326 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r219488682 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -338,165 +386,152 @@ else if (useStrictConsistency

[GitHub] cassandra pull request #267: Consolidate batch write code

2018-09-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/267#discussion_r219508033 --- Diff: src/java/org/apache/cassandra/locator/ReplicaPlans.java --- @@ -61,26 +73,62 @@ return forSingleReplicaWrite(keyspace, token

[GitHub] cassandra pull request #267: Consolidate batch write code

2018-09-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/267#discussion_r219508092 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -780,8 +780,9 @@ public static void mutateMV(ByteBuffer dataKey, Collection

[GitHub] cassandra pull request #267: Consolidate batch write code

2018-09-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/267#discussion_r219518994 --- Diff: src/java/org/apache/cassandra/locator/ReplicaPlans.java --- @@ -61,26 +73,62 @@ return forSingleReplicaWrite(keyspace, token

[GitHub] cassandra pull request #267: Consolidate batch write code

2018-09-21 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/267#discussion_r219518928 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -1021,18 +1021,18 @@ private static void syncWriteToBatchlog(Collection

[GitHub] cassandra issue #267: Consolidate batch write code

2018-09-24 Thread ifesdjeen
Github user ifesdjeen commented on the issue: https://github.com/apache/cassandra/pull/267 @belliottsmith I've addressed your comments, rebased and pushed for one more round of CI. --- - To unsubscribe, e-mail: pr

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-26 Thread ifesdjeen
Github user ifesdjeen closed the pull request at: https://github.com/apache/cassandra/pull/269 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra pull request #275: 14727

2018-09-26 Thread ifesdjeen
GitHub user ifesdjeen opened a pull request: https://github.com/apache/cassandra/pull/275 14727 You can merge this pull request into a Git repository by running: $ git pull https://github.com/belliottsmith/cassandra 14727 Alternatively you can review and apply these changes

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-26 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r220455656 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -424,62 +440,58 @@ else if (useStrictConsistency

[GitHub] cassandra pull request #267: Consolidate batch write code

2018-09-20 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/267#discussion_r219137918 --- Diff: src/java/org/apache/cassandra/locator/ReplicaPlans.java --- @@ -61,26 +73,62 @@ return forSingleReplicaWrite(keyspace, token

[GitHub] cassandra pull request #267: Consolidate batch write code

2018-09-20 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/267#discussion_r219140446 --- Diff: src/java/org/apache/cassandra/locator/ReplicaPlans.java --- @@ -61,26 +73,62 @@ return forSingleReplicaWrite(keyspace, token

[GitHub] cassandra pull request #271: 14726

2018-09-27 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220869142 --- Diff: src/java/org/apache/cassandra/locator/EndpointsForRange.java --- @@ -40,13 +37,13 @@ public class EndpointsForRange extends Endpoints

[GitHub] cassandra pull request #271: 14726

2018-09-27 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220874274 --- Diff: test/unit/org/apache/cassandra/locator/ReplicaCollectionTest.java --- @@ -141,28 +147,37 @@ public void testOrderOfIteration

[GitHub] cassandra pull request #271: 14726

2018-09-27 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220871228 --- Diff: src/java/org/apache/cassandra/locator/Endpoints.java --- @@ -36,13 +33,16 @@ */ public abstract class Endpoints> exte

[GitHub] cassandra pull request #271: 14726

2018-09-27 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/271#discussion_r220871785 --- Diff: test/unit/org/apache/cassandra/locator/ReplicaCollectionTest.java --- @@ -141,28 +147,37 @@ public void testOrderOfIteration

[GitHub] cassandra pull request #281: Sep worker shutdown

2019-01-08 Thread ifesdjeen
Github user ifesdjeen closed the pull request at: https://github.com/apache/cassandra/pull/281 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra pull request #259: Cleanup repair path after Transient Replication

2018-09-12 Thread ifesdjeen
Github user ifesdjeen closed the pull request at: https://github.com/apache/cassandra/pull/259 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra pull request #261: Tr followup 4

2018-09-12 Thread ifesdjeen
Github user ifesdjeen closed the pull request at: https://github.com/apache/cassandra/pull/261 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra pull request #257: Allow transient range owner to serve as repair ...

2018-09-12 Thread ifesdjeen
Github user ifesdjeen closed the pull request at: https://github.com/apache/cassandra/pull/257 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra pull request #262: Replicalayout followup

2018-09-12 Thread ifesdjeen
Github user ifesdjeen closed the pull request at: https://github.com/apache/cassandra/pull/262 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-17 Thread ifesdjeen
GitHub user ifesdjeen opened a pull request: https://github.com/apache/cassandra/pull/269 Review tr range movements CASSANDRA-14756 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ifesdjeen/cassandra review-tr-range-movements

[GitHub] cassandra-dtest pull request #38: Transient Replication and Cheap Quorums te...

2018-09-17 Thread ifesdjeen
Github user ifesdjeen closed the pull request at: https://github.com/apache/cassandra-dtest/pull/38 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h

[GitHub] cassandra-dtest issue #38: Transient Replication and Cheap Quorums tests

2018-09-17 Thread ifesdjeen
Github user ifesdjeen commented on the issue: https://github.com/apache/cassandra-dtest/pull/38 Merged, thank you! --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail

[GitHub] cassandra pull request #266: Add a check for receiving digest response from ...

2018-09-14 Thread ifesdjeen
GitHub user ifesdjeen opened a pull request: https://github.com/apache/cassandra/pull/266 Add a check for receiving digest response from transient node for CASSANDRA-14750 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ifesdjeen

[GitHub] cassandra pull request #269: Review tr range movements

2018-09-18 Thread ifesdjeen
Github user ifesdjeen commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218432647 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -87,8 +85,8 @@ private final InetAddressAndPort address