Re: [prometheus-developers] Adding a CODEOWNERS file to prometheus/prometheus?

2021-03-02 Thread Frederic Branczyk
Yeah, I was thinking the same as Julius said, but maybe it's fair to see who wants to opt-in to this and who doesn't. FWIW I added myself as codeowner of the Kubernetes service discovery just like it's mentioned in the maintainers file. https://github.com/prometheus/prometheus/pull/8553 On Mon,

Re: [prometheus-developers] Adding a CODEOWNERS file to prometheus/prometheus?

2021-03-01 Thread Julius Volz
Great - I made a PR at https://github.com/prometheus/prometheus/pull/8552. I added /storage/remote, but at that point maybe we want to add all the other dirs with specific maintainers as well? On Mon, Mar 1, 2021 at 9:10 PM Tom Wilkie wrote: > Yes! I was chatting to Beorn about this the other

Re: [prometheus-developers] Adding a CODEOWNERS file to prometheus/prometheus?

2021-03-01 Thread Julien Pivotto
On 01 Mar 21:05, Julius Volz wrote: > Heya all, > > Julien often helpfully pings me on PRs that touch the React UI, but it > would be much nicer if I could somehow get auto-notified by GitHub > specifically of those that touch anything under /web/ui/. Others might feel > the same about their

Re: [prometheus-developers] Adding a CODEOWNERS file to prometheus/prometheus?

2021-03-01 Thread Tom Wilkie
Yes! I was chatting to Beorn about this the other week... Big +1 from me. Mind adding a line for /storage/remote too? Thanks Tom On Mon, Mar 1, 2021 at 8:05 PM Julius Volz wrote: > Heya all, > > Julien often helpfully pings me on PRs that touch the React UI, but it > would be much nicer if I

[prometheus-developers] Adding a CODEOWNERS file to prometheus/prometheus?

2021-03-01 Thread Julius Volz
Heya all, Julien often helpfully pings me on PRs that touch the React UI, but it would be much nicer if I could somehow get auto-notified by GitHub specifically of those that touch anything under /web/ui/. Others might feel the same about their areas of purview. GitHub has a CODEOWNERS file