[protobuf] intern strings in java

2010-01-19 Thread Kalle Kärkkäinen
Hi, I'm modeling contracts that need to reside in a group. Groups are strings, basically. I've got rather many contracts, and I was thinking if it was possible to have strings interned so they would take less memory. Since this would be a load time change (load string up, intern it, and use what

Re: [protobuf] intern strings in java

2010-01-19 Thread Kenton Varda
I'm not sure I understand. I think you are using the word group to mean something different than what it means in the .proto language. At least, I hope so, because the group in the .proto language is deprecated. Are you suggesting that the parser should automatically intern every String that it

[protobuf] Re: A new ActionScript 3 protobuf implementation

2010-01-19 Thread elenzil
Hi Atry - i am curious to try out your new protobuf plugin. however i encountered a problem running the plugin, and also a problem reporting a new issue on the protoc-gen-as3 homepage, so i'm putting the report here. best, Orion issue report:

Re: [protobuf] intern strings in java

2010-01-19 Thread Oliver Jowett
2010/1/20 Kenton Varda ken...@google.com: Are you suggesting that the parser should automatically intern every String that it parses?  That sounds like it could be expensive for those who don't need it. More than expensive - it's a permanent memory leak for any app that passes around many

[protobuf] Re: Issue 155 in protobuf: Compiler complains with 'error: extra qualification'

2010-01-19 Thread protobuf
Updates: Status: Fixed Comment #1 on issue 155 by ken...@google.com: Compiler complains with 'error: extra qualification' http://code.google.com/p/protobuf/issues/detail?id=155 How strange. That never should have compiled, but it passed testing on MSVC, MinGW, and Cygwin (GCC 3.x

[protobuf] Re: Issue 159 in protobuf: 2.3.0 build fails under QNX fails

2010-01-19 Thread protobuf
Updates: Status: Fixed Labels: FixedIn-2.3.1 Comment #1 on issue 159 by ken...@google.com: 2.3.0 build fails under QNX fails http://code.google.com/p/protobuf/issues/detail?id=159 Thanks, committed as revision 309. -- You received this message because you are listed in the

Re: [protobuf] shared library opened with dlopen, crash in google::protobuf::MessageFactory::InternalRegisterGeneratedFile

2010-01-19 Thread Kenton Varda
Can you create a small, self-contained program that demonstrates this bug? Ideally it would contain a simple .proto file, a simple .cc file for the dynamic library, a simple .cc file with a main() function that dlopens the library, and a simple Makefile to build it all. Each of these files

Re: [protobuf] shared library opened with dlopen, crash in google::protobuf::MessageFactory::InternalRegisterGeneratedFile

2010-01-19 Thread Kenton Varda
Oh, and please verify that the problem still exists with 2.3.0 before doing any of this. Also, if the problem is Solaris-specific I won't be able to help you, as I don't have access to this platform. But if I can repro on Linux I will try to fix it. On Tue, Jan 19, 2010 at 6:07 PM, Kenton Varda

[protobuf] Re: Issue 156 in protobuf: extension_set.h needs GetMessage / GetMessageA / GetMessageW workaround

2010-01-19 Thread protobuf
Updates: Status: Fixed Labels: FixedIn-2.3.1 Comment #1 on issue 156 by ken...@google.com: extension_set.h needs GetMessage / GetMessageA / GetMessageW workaround http://code.google.com/p/protobuf/issues/detail?id=156 Your revision 305 fixed this. Thanks! -- You received

[protobuf] Re: Issue 155 in protobuf: Compiler complains with 'error: extra qualification'

2010-01-19 Thread protobuf
Updates: Labels: FixedIn-2.3.1 Comment #2 on issue 155 by ken...@google.com: Compiler complains with 'error: extra qualification' http://code.google.com/p/protobuf/issues/detail?id=155 (No comment was entered for this change.) -- You received this message because you are listed in

[protobuf] Re: Issue 153 in protobuf: 2.3 Python code not importing

2010-01-19 Thread protobuf
Updates: Status: CannotReproduce Comment #5 on issue 153 by ken...@google.com: 2.3 Python code not importing http://code.google.com/p/protobuf/issues/detail?id=153 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of

Re: [protobuf] Java UTF-8 encoding/decoding: possible performance improvements

2010-01-19 Thread Kenton Varda
I think the 30-80% speed boost would be well worth the extra code size / memory overhead. Please send me the patch! On Sun, Jan 17, 2010 at 9:33 AM, Evan Jones ev...@mit.edu wrote: I've implemented a rough prototype of an optimization to the Java implementation that serializes Java strings

[protobuf] Re: STL_HASH.m4

2010-01-19 Thread vikram
Thanks Kenton, I configured correctly using following configure string ./configure CC=/compiler/xlcpp/usr/vac/bin/xlc_r CXX=/compiler/ xlcpp/usr/vacpp/bin/xlC_r CXXFLAGS=-g -qlanglvl=extended - D__IBMCPP_TR1__ -qidirfirst -I/compiler/xlcpp/usr/vacpp/include CFLAGS=-g -qlanglvl=extc99

Re: [protobuf] Re: STL_HASH.m4

2010-01-19 Thread Kenton Varda
This sounds like another problem with your compiler -- it can't find std::string. Note that in common.h we use using namespace std; to import all of std into the google::protobuf namespace. This is not good practice but we didn't think it was worth the effort to fix it. On Tue, Jan 19, 2010 at

Re: [protobuf] Re: WriteDelimited/parseDelimited in python

2010-01-19 Thread Kenton Varda
On Tue, Jan 5, 2010 at 3:57 AM, Graham Cox cox.gra...@gmail.com wrote: I was saying the user *could* do that, and that it's currently what I'm doing in my server-side code. The reason being, as you said, if you naively read from a stream and the message isn't all present then you need to block

Re: [protobuf] Re: STL_HASH.m4

2010-01-19 Thread Kenton Varda
It just looks up the type name in a hash_map: http://code.google.com/p/protobuf/source/browse/trunk/src/google/protobuf/compiler/parser.cc#1007 http://code.google.com/p/protobuf/source/browse/trunk/src/google/protobuf/compiler/parser.cc#1007kTypeNames is initialized here:

Re: [protobuf] Re: STL_HASH.m4

2010-01-19 Thread vikram patil
Thanks Kenton. I will try to debug it and will let you know. Did anyone successfully compiled protocol buffer on AIX ? I've seen couple of posts but never saw some reply with success. Thanks Regards, Vikram On Tue, Jan 19, 2010 at 7:56 PM, Kenton Varda ken...@google.com wrote: It just looks

Re: [protobuf] Re: STL_HASH.m4

2010-01-19 Thread Kenton Varda
I have no idea. On Tue, Jan 19, 2010 at 7:58 PM, vikram patil patilvik...@gmail.com wrote: Thanks Kenton. I will try to debug it and will let you know. Did anyone successfully compiled protocol buffer on AIX ? I've seen couple of posts but never saw some reply with success. Thanks