TextFormat and optional fields.

2009-08-07 Thread Brice Figureau
Hi, I have the following message, under Protobuf 2.0.3: message Message { required string name = 1; optional string nonce = 2; } When I call toString() on this message it throws a NullPointerException: Exception in thread "main" java.lang.NullPointerException at com.google.protobuf.

Re: TextFormat and optional fields.

2009-08-07 Thread Brice Figureau
Hi, Oops, sorry, I was plain wrong. It turns out the code was setting the nonce parameter to null. Anyway, maybe it should be necessary to change the TextFormat to better deal with null fields? On Fri, 2009-08-07 at 12:07 +0200, Brice Figureau wrote: > Hi, > > I have the following message, und

Re: 2.2.0 release candidate

2009-08-07 Thread Holger Hoffstaette
On Thu, 06 Aug 2009 17:50:57 -0700, Kenton Varda wrote: > http://groups.google.com/group/protobuf/files Please test it out and let > me know if you have any problems. > > http://protobuf.googlecode.com/svn/trunk/CHANGES.txt The new thread-local freelist will very likely create a number of issue

Can't seem to make Extension parsing working...

2009-08-07 Thread Brice Figureau
Hi, Using Protobuf 2.1 with the following proto file: message Message { enum Type { AUTH = 100; } required Type type = 1; optional int32 id = 2; extensions 100 to max; } message AuthRequest { extend Message {

Re: Can't seem to make Extension parsing working...

2009-08-07 Thread Brice Figureau
Hi, See below for more information. On Fri, 2009-08-07 at 16:58 +0200, Brice Figureau wrote: > Hi, > > Using Protobuf 2.1 with the following proto file: > > message Message { > enum Type { > AUTH = 100; > } > > required Type type = 1; > optional int32 id

Re: 2.2.0 release candidate

2009-08-07 Thread Kenton Varda
What kind of issues? On Fri, Aug 7, 2009 at 4:42 AM, Holger Hoffstaette < holger.hoffstae...@googlemail.com> wrote: > > On Thu, 06 Aug 2009 17:50:57 -0700, Kenton Varda wrote: > > > http://groups.google.com/group/protobuf/files Please test it out and let > > me know if you have any problems. > >

Re: TextFormat and optional fields.

2009-08-07 Thread Kenton Varda
Protobuf 2.1.0 throws NPE when you try to set a field to null. So, this has been long fixed. On Fri, Aug 7, 2009 at 4:30 AM, Brice Figureau > wrote: > > Hi, > > Oops, sorry, I was plain wrong. > It turns out the code was setting the nonce parameter to null. > Anyway, maybe it should be necessar

Re: Can't seem to make Extension parsing working...

2009-08-07 Thread Jon Skeet
Have you tried using the overload of parseFrom which takes an extension registry? Make sure you register all the extensions first, of course - call the appropriate registerAllExtensions static method, passing in the extension registry, before calling parseFrom(src.toByteArray(), registry). Jon -

Re: 2.2.0 release candidate

2009-08-07 Thread Holger Hoffstätte
Kenton Varda wrote: > What kind of issues? Unless the ThreadLocals are explicitly cleared, the classloader can not be unloaded/GCed and jars redeployed. The retained memory is not so much an issue for protobuf, but other people have not been so lucky and ended up with leaks of many megabytes of r

Re: 2.2.0 release candidate

2009-08-07 Thread Kenton Varda
Good points. I wasn't a big fan of this change in the first place but apparently it was a big performance win on Android (which does not have a very advanced garbage collector at the moment). I guess we should make it optional, off-by-default. I'll make that change today and try to get another r

Re: 'Search this group' isn't very helpful

2009-08-07 Thread Scott Stafford
I'm having zero results too, searching for "DescriptorPool" for instance. On Aug 4, 7:54 pm, Kenton Varda wrote: > Interesting.  I'll file a bug against google groups. > > > > On Tue, Aug 4, 2009 at 3:25 PM, Adam wrote: > > > On Aug 4, 5:16 pm, Kenton Varda wrote: > > > What were you searching

Re: 'Search this group' isn't very helpful

2009-08-07 Thread Kenton Varda
The groups people are working on fixing this. On Fri, Aug 7, 2009 at 12:51 PM, Scott Stafford wrote: > > I'm having zero results too, searching for "DescriptorPool" for > instance. > > On Aug 4, 7:54 pm, Kenton Varda wrote: > > Interesting. I'll file a bug against google groups. > > > > > > > >

Python BuildFile functionality

2009-08-07 Thread Scott Stafford
Hi - We need DescriptorPool::BuildFile-like functionality in the protobuf Python library. In other words, something that can take a FileDescriptorProto object and create a bunch of descriptor.Descriptor's that can be made into dynamic loaded classes. We haven't looked very closely at this probl

Re: Python BuildFile functionality

2009-08-07 Thread Kenton Varda
Well, note that soon (hopefully in the next major release after 2.2.0 -- we actually have someone actively working on it now) the Python implementation will be able to wrap C++ classes for better performance. At that point it will probably be easy to accomplish what you want by handing off most of

Re: Python BuildFile functionality

2009-08-07 Thread Scott Stafford
Interesting... Are you using SWIG to wrap the C++? Would you have to actually compile something to use a message in Python (god forbid)? Thinking about it a bit, I guess you'd just SWIG the static (non- generated) interfaces and the Python classes would all operate exclusively through reflection

Re: Python BuildFile functionality

2009-08-07 Thread Kenton Varda
On Fri, Aug 7, 2009 at 1:54 PM, Scott Stafford wrote: > > Interesting... Are you using SWIG to wrap the C++? No, straight C extensions. (SWIG is just a code generator that generates C extensions.) > Would you have to > actually compile something to use a message in Python (god forbid)? You

Re: 2.2.0 release candidate

2009-08-07 Thread Kenton Varda
I've put up 2.2.0rc2, same place: http://groups.google.com/group/protobuf/files 2009/8/7 Kenton Varda > Good points. I wasn't a big fan of this change in the first place but > apparently it was a big performance win on Android (which does not have a > very advanced garbage collector at the mome