[GitHub] qpid-proton pull request: PROTON-984: Document proton-j time units

2015-09-10 Thread bozzzzo
Github user boo closed the pull request at: https://github.com/apache/qpid-proton/pull/50 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] qpid-proton pull request: Proton 980

2015-09-10 Thread bozzzzo
Github user boo commented on the pull request: https://github.com/apache/qpid-proton/pull/49#issuecomment-139454327 rebased to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] qpid-proton pull request: Proton 980

2015-09-10 Thread bozzzzo
Github user boo closed the pull request at: https://github.com/apache/qpid-proton/pull/49 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] qpid-proton pull request: PROTON-984: Document proton-j time units

2015-08-18 Thread bozzzzo
GitHub user boo opened a pull request: https://github.com/apache/qpid-proton/pull/50 PROTON-984: Document proton-j time units Can somebody help me fill out the blanks here? I think proton-j uses milliseconds throughout, and what does Reactor#setTimeout() do? You can merge

[GitHub] qpid-proton pull request: Proton 980

2015-08-18 Thread bozzzzo
GitHub user boo opened a pull request: https://github.com/apache/qpid-proton/pull/49 Proton 980 You can merge this pull request into a Git repository by running: $ git pull https://github.com/boo/qpid-proton proton-980 Alternatively you can review and apply

[GitHub] qpid-proton pull request: PROTON-964: Proton-J extensible event ty...

2015-08-07 Thread bozzzzo
Github user boo commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/48#discussion_r36522686 --- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/impl/CollectorImpl.java --- @@ -57,9 +58,16 @@ public void pop

[GitHub] qpid-proton pull request: PROTON-964: Proton-J extensible event ty...

2015-08-06 Thread bozzzzo
Github user boo commented on the pull request: https://github.com/apache/qpid-proton/pull/48#issuecomment-128358421 @gemmellr I think I have managed to eliminate almost all casts by delegating half of the dispatch to the handler -- the handler already knows it's type, no need

[GitHub] qpid-proton pull request: PROTON-964: Proton-J extensible event ty...

2015-08-04 Thread bozzzzo
Github user boo commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/48#discussion_r36181146 --- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EventImpl.java --- @@ -217,6 +101,19 @@ public void dispatch(Handler handler

[GitHub] qpid-proton pull request: PROTON-964: Proton-J extensible event ty...

2015-08-04 Thread bozzzzo
Github user boo commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/48#discussion_r36182863 --- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/impl/CollectorImpl.java --- @@ -57,9 +58,13 @@ public void pop

[GitHub] qpid-proton pull request: PROTON-964: Proton-J extensible event ty...

2015-08-04 Thread bozzzzo
Github user boo commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/48#discussion_r36180019 --- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EventImpl.java --- @@ -53,9 +54,9 @@ this.type = null

[GitHub] qpid-proton pull request: PROTON-964: Proton-J extensible event ty...

2015-08-04 Thread bozzzzo
Github user boo commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/48#discussion_r36178995 --- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/Event.java --- @@ -80,15 +83,46 @@ SELECTABLE_WRITABLE

[GitHub] qpid-proton pull request: PROTON-964: Proton-J extensible event ty...

2015-08-04 Thread bozzzzo
Github user boo commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/48#discussion_r36179005 --- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/Record.java --- @@ -29,6 +29,10 @@ public interface Record

[GitHub] qpid-proton pull request: PROTON-964: Proton-J extensible event ty...

2015-08-04 Thread bozzzzo
Github user boo commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/48#discussion_r36179169 --- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/impl/BuiltinEventTypeImpl.java --- @@ -0,0 +1,144 @@ +package

[GitHub] qpid-proton pull request: PROTON-964: Proton-J extensible event ty...

2015-08-04 Thread bozzzzo
Github user boo commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/48#discussion_r36179236 --- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/impl/CollectorImpl.java --- @@ -57,9 +58,13 @@ public void pop

[GitHub] qpid-proton pull request: PROTON-964: Proton-J extensible event ty...

2015-08-04 Thread bozzzzo
Github user boo commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/48#discussion_r36179971 --- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/impl/CollectorImpl.java --- @@ -57,9 +58,13 @@ public void pop

[GitHub] qpid-proton pull request: PROTON-964: Proton-J extensible event ty...

2015-07-29 Thread bozzzzo
GitHub user boo opened a pull request: https://github.com/apache/qpid-proton/pull/48 PROTON-964: Proton-J extensible event types You can merge this pull request into a Git repository by running: $ git pull https://github.com/boo/qpid-proton proton-964 Alternatively

[GitHub] qpid-proton pull request: PROTON-838: proton-hawtdispatch cannot c...

2015-03-13 Thread bozzzzo
GitHub user boo opened a pull request: https://github.com/apache/qpid-proton/pull/12 PROTON-838: proton-hawtdispatch cannot connect with SSL Remove one of calls to transport.connecting() as this causes an assert with SslTransport You can merge this pull request into a Git