Re: Qpid-specific logging facade(s) for Proton etc

2013-07-09 Thread Phil Harvey
I have just committed the first revision [1] of the Proton logging Java classes under PROTON-343. Among the tasks remaining, the bulk of the work will be in proton-c and proton-jni: 1. Defining and implementing proton-c logging functions in line with the new Java API. 2. Implementing

Re: Qpid-specific logging facade(s) for Proton etc

2013-07-09 Thread Ted Ross
Phil, Since this commit, I can't build proton. I get the following: /.../proton/proton-j/proton-api/src/main/java/org/apache/qpid/proton/logging/SLF4JCategoryLogger.java:21: error: package org.slf4j does not exist import org.slf4j.Logger; I checked and slf4j is installed on my system

Re: Qpid-specific logging facade(s) for Proton etc

2013-07-09 Thread Rafael Schloming
I'm seeing this same problem also. --Rafael On Tue, Jul 9, 2013 at 10:36 AM, Ted Ross tr...@redhat.com wrote: Phil, Since this commit, I can't build proton. I get the following: /.../proton/proton-j/proton-**api/src/main/java/org/apache/**

Re: Qpid-specific logging facade(s) for Proton etc

2013-06-25 Thread Phil Harvey
I've created a skeleton Java implementation of the Proton logging design and attached it as a patch to https://issues.apache.org/jira/browse/PROTON-343. I think the next steps are: - Gather comments from folks about the design. - Sketch out the corresponding proton-c and proton-jni code. I'd

Re: Qpid-specific logging facade(s) for Proton etc

2013-06-25 Thread Rob Godfrey
So, my main comment would be that I think the Factories should not be depending on the MessageLoggerSpi as you've defined it, but instead purely on EngineLogger. The MessageLogger stuff is a convenience but I don't think it should be mandatory to use it. My other comment would be that I don't

Qpid-specific logging facade(s) for Proton etc

2013-06-05 Thread Phil Harvey
An interesting discussion about logging has emerged from the mailing thread AMQP 1.0 JMS client - supplementary coding standards. I'm starting a new thread for this specific topic and am including the proton list. To recap, Rob, Rajith, Rafi and Gordon have expressed a desire for Proton and the