Re: review request: patch to cmake for windows builds

2012-10-31 Thread Cliff Jansen
I would personally just use the settings Steve came up with for the main qpid cpp build. Those should serve us well. The only obvious addition is the flag that forces C++ compilation from files named foo.c. Cliff On Wed, Oct 31, 2012 at 12:05 PM, Ken Giusti wrote: > Ah, almost forgot: > > The

Re: review request: patch to cmake for windows builds

2012-10-31 Thread Andrew Stitcher
On Wed, 2012-10-31 at 13:46 -0400, Ken Giusti wrote: > Hi Cliff/Mary, > > I'm trying to add support for building proton using Microsoft Visual C++ > express. This patch updates cmake to enable generation of the VC++ project > files for proton. Can you review and try it out - let me know what y

RE: review request: patch to cmake for windows builds

2012-10-31 Thread Mary Hinton
Maybe this will help. In my project file for the dll, the command lines in the debugger are: C/C++ compiler: /I"include" /I"C:/qpid/qpid/proton/proton-c" /I"C:/qpid/qpid/proton/proton-c/include" /Zi /nologo /Wall /WX- /Od /Ob0 /Oy- /D "qpid_proton_python_EXPORTS" /D "WIN32" /D "_WINDOWS" /D "W

Re: review request: patch to cmake for windows builds

2012-10-31 Thread Ken Giusti
Ah, almost forgot: The patch modifies the CMakeLists.txt file by adding compiler flags for the VC++ compiler. The flags differ based on each type of target build (Debug/Release/etc). Now, IANAVCP (I Am Not a VC Programmer), so I have no idea what the appropriate flags should be for the windo

Re: review request: patch to cmake for windows builds

2012-10-31 Thread Ken Giusti
Ah, then this patch is for *you*! :) It -should- fix it so you don't have to modify the project files at all, and it should fix those header files too. You should just be able to run cmake, then pull the result into VS and build. It doesn't go so far as to run the tests though - we'll need to

Re: delivery vs tracker

2012-10-31 Thread Justin Ross
On Wed, 31 Oct 2012, Darryl L. Pierce wrote: On Tue, Oct 30, 2012 at 08:15:42AM -0400, Rafael Schloming wrote: My inclination is to persue option 2 for the following reasons: - Option 1 introduces more burden since users need to explicitly manage the lifecycle of the returned objects.

[jira] [Resolved] (PROTON-113) Fixes for packaging issues

2012-10-31 Thread Darryl L. Pierce (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darryl L. Pierce resolved PROTON-113. - Resolution: Fixed > Fixes for packaging issues > -- > >

RE: review request: patch to cmake for windows builds

2012-10-31 Thread Mary Hinton
I used cmake to create Visual Studio 10 projects files and solution workspace. Then I modified the project files to add what I needed. I hadn't used cmake before this project. So I'm not an expert. I'll be happy to have your help with creating good support for building proton from cmake. The

Re: delivery vs tracker

2012-10-31 Thread Darryl L. Pierce
On Tue, Oct 30, 2012 at 08:15:42AM -0400, Rafael Schloming wrote: > My inclination is to persue option 2 for the following reasons: > > - Option 1 introduces more burden since users need to explicitly > manage the lifecycle of the returned objects. While this burden > might be mitigated

[jira] [Updated] (PROTON-113) Fixes for packaging issues

2012-10-31 Thread Darryl L. Pierce (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darryl L. Pierce updated PROTON-113: Attachment: 0004-Added-some-boiler-plate-text-to-the-TODO-file.patch 0003-Pr

[jira] [Updated] (PROTON-113) Fixes for packaging issues

2012-10-31 Thread Darryl L. Pierce (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darryl L. Pierce updated PROTON-113: Attachment: (was: 0002-Sets-the-soversion-for-the-qpid-proton-library.patch) > Fix

[jira] [Updated] (PROTON-113) Fixes for packaging issues

2012-10-31 Thread Darryl L. Pierce (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darryl L. Pierce updated PROTON-113: Attachment: (was: 0003-Provides-the-ability-to-disable-rpath-in-libraries.patch) >

[jira] [Updated] (PROTON-113) Fixes for packaging issues

2012-10-31 Thread Darryl L. Pierce (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darryl L. Pierce updated PROTON-113: Attachment: (was: 0001-Added-the-version-to-the-share-directory-name.patch) > Fixe

[jira] [Updated] (PROTON-113) Fixes for packaging issues

2012-10-31 Thread Darryl L. Pierce (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darryl L. Pierce updated PROTON-113: Attachment: (was: 0004-Added-some-boiler-plate-text-to-the-TODO-file.patch) > Fixe

review request: patch to cmake for windows builds

2012-10-31 Thread Ken Giusti
Hi Cliff/Mary, I'm trying to add support for building proton using Microsoft Visual C++ express. This patch updates cmake to enable generation of the VC++ project files for proton. Can you review and try it out - let me know what you think? Note that the patch only adds build support - the pr

[jira] [Commented] (PROTON-113) Fixes for packaging issues

2012-10-31 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487951#comment-13487951 ] Andrew Stitcher commented on PROTON-113: I don't think marking the so version as 1

[jira] [Commented] (PROTON-113) Fixes for packaging issues

2012-10-31 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487943#comment-13487943 ] Andrew Stitcher commented on PROTON-113: in qpid the *release* version is in a fil

[jira] [Commented] (PROTON-113) Fixes for packaging issues

2012-10-31 Thread Darryl L. Pierce (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487872#comment-13487872 ] Darryl L. Pierce commented on PROTON-113: - Just isolating the value similar to how

[jira] [Commented] (PROTON-113) Fixes for packaging issues

2012-10-31 Thread Rafael H. Schloming (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487858#comment-13487858 ] Rafael H. Schloming commented on PROTON-113: There are no stability guarantees

Re: [VOTE] RC8

2012-10-31 Thread Darryl L. Pierce
On Wed, Oct 31, 2012 at 10:21:41AM -0400, Rafael Schloming wrote: > I pushed out the 0.1 release last night when the 24 hours was up. It's > still propagating to the mirrors. I expect to have a 0.2 ready very soon, > so we can get the packaging tweaks into that. Very good. -- Darryl L. Pierce, S

[jira] [Commented] (PROTON-113) Fixes for packaging issues

2012-10-31 Thread Darryl L. Pierce (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487853#comment-13487853 ] Darryl L. Pierce commented on PROTON-113: - I would say the version number should c

[jira] [Commented] (PROTON-113) Fixes for packaging issues

2012-10-31 Thread Rafael H. Schloming (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487839#comment-13487839 ] Rafael H. Schloming commented on PROTON-113: What's the guidance on when to ch

[jira] [Commented] (PROTON-113) Fixes for packaging issues

2012-10-31 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487834#comment-13487834 ] Andrew Stitcher commented on PROTON-113: In this case 1.0 is talking about the ABI

[jira] [Commented] (PROTON-113) Fixes for packaging issues

2012-10-31 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487832#comment-13487832 ] Andrew Stitcher commented on PROTON-113: I strongly recommend not using the same v

[jira] [Assigned] (PROTON-113) Fixes for packaging issues

2012-10-31 Thread Darryl L. Pierce (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darryl L. Pierce reassigned PROTON-113: --- Assignee: Darryl L. Pierce > Fixes for packaging issues > ---

[jira] [Updated] (PROTON-113) Fixes for packaging issues

2012-10-31 Thread Darryl L. Pierce (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darryl L. Pierce updated PROTON-113: Attachment: 0004-Added-some-boiler-plate-text-to-the-TODO-file.patch 0003-Pr

Re: [VOTE] RC8

2012-10-31 Thread Rafael Schloming
I pushed out the 0.1 release last night when the 24 hours was up. It's still propagating to the mirrors. I expect to have a 0.2 ready very soon, so we can get the packaging tweaks into that. --Rafael On Wed, Oct 31, 2012 at 9:13 AM, Darryl L. Pierce wrote: > On Mon, Oct 29, 2012 at 09:32:55PM -0

[jira] [Created] (PROTON-113) Fixes for packaging issues

2012-10-31 Thread Darryl L. Pierce (JIRA)
Darryl L. Pierce created PROTON-113: --- Summary: Fixes for packaging issues Key: PROTON-113 URL: https://issues.apache.org/jira/browse/PROTON-113 Project: Qpid Proton Issue Type: Improvement

Re: [VOTE] RC8

2012-10-31 Thread Darryl L. Pierce
On Mon, Oct 29, 2012 at 09:32:55PM -0400, Rafael Schloming wrote: > I'm optimistically starting an official release vote for RC8 here. I'm > hoping if there is enough support and no procedural objections we can fudge > the 72 hour formal vote process down to 24 hours. I personally think this > is r

[jira] [Assigned] (PROTON-112) Expose api to set the local error on a link.

2012-10-31 Thread Ted Ross (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross reassigned PROTON-112: --- Assignee: Ted Ross > Expose api to set the local error on a link. > -

[jira] [Resolved] (PROTON-112) Expose api to set the local error on a link.

2012-10-31 Thread Ted Ross (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross resolved PROTON-112. - Resolution: Fixed Fix Version/s: 0.2 > Expose api to set the local error on a link. >