Re: landing events branch
I wasn't able to run the tests via cmake or maven after updating and doing
a clean build, getting complaint: AttributeError: type object
'org.apache.qpid.proton.engine.Event$Category' has no attribute 'PROTOCOL'
As I saw that the CI job completed ok and knew that this was an area being
changed in the latest comits, I figured that there must be some erroneous
stale files left in my checkout since the main difference is Jenkins being
set to clear away such files before updating to the latest revision. A
little git-clean usage showed that to be the case, with various .pyc and
py.class files lying around in the tests dir particularly.
To do a git-clean dry run and see the files/dirs that would be removed:
git clean -n -d -x -e *.classpath -e *.project -e *.settings .
To actually remove them:
git clean -f -d -x -e *.classpath -e *.project -e *.settings .
The -e options are just making it ignore some IDE related files/dirs from
being nuked after the -x makes it consider things it normally ignores, so
update or remove the -e flags according to your own needs.
After cleanup, running the tests worked fine. I can only presume this
happened due to leaving stale files around after playing around on branches
previously. Perhaps the tests module needs updated to clear away such files
when doing a clean build.
Robbie
On 17 July 2014 21:07, Rafael Schloming r...@alum.mit.edu wrote:
FYI, the events branch is now landed on trunk. Please let me know if you
run into any issues.
--Rafael
On Thu, Jul 10, 2014 at 2:10 PM, Božo Dragojevič bo...@digiverse.si
wrote:
On Jul 10, 2014 6:41 PM, Rafael Schloming r...@alum.mit.edu wrote:
Hi Everyone,
I wanted to give people a quick heads up. I would like to land the
events
branch soon. If you don't use the events API then this probably won't
impact you, however if you do then you may experience some compilation
failures. This is because of the following changes:
The PN_{CONNECTION,SESSION,LINK}_LOCAL_STATE events have been
decomposed
into two distinct events:
PN_{CONNECTION,SESSION,LINK}_OPEN and
PN_{CONNECTION,SESSION,LINK}_CLOSE
Similarly, PN_{CONNECTION,SESSION,LINK}_REMOTE_STATE has been
decomposed
into:
PN_{CONNECTION,SESSION,LINK}_REMOTE_OPEN and
PN_{CONNECTION,SESSION,LINK}_REMOTE_CLOSE
To fix your code all you need to do is adjust your switch statements to
match on the new names, e.g. something like this:
...
case PN_CONNECTION_REMOTE_STATE:
...
Would become something like this:
...
case PN_CONNECTION_REMOTE_OPEN: // fall through
case PN_CONNECTION_REMOTE_CLOSE:
...
Please give me a shout if this will cause a problem for you, otherwise
I
will land the branch in a day or two.
When speed reading the new event api the other day, the change seemed
quite large, but such a mechanic change seems easy to adapt.
Bozzo
Re: landing events branch
FYI, the events branch is now landed on trunk. Please let me know if you
run into any issues.
--Rafael
On Thu, Jul 10, 2014 at 2:10 PM, Božo Dragojevič bo...@digiverse.si wrote:
On Jul 10, 2014 6:41 PM, Rafael Schloming r...@alum.mit.edu wrote:
Hi Everyone,
I wanted to give people a quick heads up. I would like to land the events
branch soon. If you don't use the events API then this probably won't
impact you, however if you do then you may experience some compilation
failures. This is because of the following changes:
The PN_{CONNECTION,SESSION,LINK}_LOCAL_STATE events have been decomposed
into two distinct events:
PN_{CONNECTION,SESSION,LINK}_OPEN and
PN_{CONNECTION,SESSION,LINK}_CLOSE
Similarly, PN_{CONNECTION,SESSION,LINK}_REMOTE_STATE has been decomposed
into:
PN_{CONNECTION,SESSION,LINK}_REMOTE_OPEN and
PN_{CONNECTION,SESSION,LINK}_REMOTE_CLOSE
To fix your code all you need to do is adjust your switch statements to
match on the new names, e.g. something like this:
...
case PN_CONNECTION_REMOTE_STATE:
...
Would become something like this:
...
case PN_CONNECTION_REMOTE_OPEN: // fall through
case PN_CONNECTION_REMOTE_CLOSE:
...
Please give me a shout if this will cause a problem for you, otherwise I
will land the branch in a day or two.
When speed reading the new event api the other day, the change seemed
quite large, but such a mechanic change seems easy to adapt.
Bozzo
landing events branch
Hi Everyone,
I wanted to give people a quick heads up. I would like to land the events
branch soon. If you don't use the events API then this probably won't
impact you, however if you do then you may experience some compilation
failures. This is because of the following changes:
The PN_{CONNECTION,SESSION,LINK}_LOCAL_STATE events have been decomposed
into two distinct events:
PN_{CONNECTION,SESSION,LINK}_OPEN and PN_{CONNECTION,SESSION,LINK}_CLOSE
Similarly, PN_{CONNECTION,SESSION,LINK}_REMOTE_STATE has been decomposed
into:
PN_{CONNECTION,SESSION,LINK}_REMOTE_OPEN and
PN_{CONNECTION,SESSION,LINK}_REMOTE_CLOSE
To fix your code all you need to do is adjust your switch statements to
match on the new names, e.g. something like this:
...
case PN_CONNECTION_REMOTE_STATE:
...
Would become something like this:
...
case PN_CONNECTION_REMOTE_OPEN: // fall through
case PN_CONNECTION_REMOTE_CLOSE:
...
Please give me a shout if this will cause a problem for you, otherwise I
will land the branch in a day or two.
--Rafael
Re: landing events branch
On Jul 10, 2014 6:41 PM, Rafael Schloming r...@alum.mit.edu wrote:
Hi Everyone,
I wanted to give people a quick heads up. I would like to land the events
branch soon. If you don't use the events API then this probably won't
impact you, however if you do then you may experience some compilation
failures. This is because of the following changes:
The PN_{CONNECTION,SESSION,LINK}_LOCAL_STATE events have been decomposed
into two distinct events:
PN_{CONNECTION,SESSION,LINK}_OPEN and PN_{CONNECTION,SESSION,LINK}_CLOSE
Similarly, PN_{CONNECTION,SESSION,LINK}_REMOTE_STATE has been decomposed
into:
PN_{CONNECTION,SESSION,LINK}_REMOTE_OPEN and
PN_{CONNECTION,SESSION,LINK}_REMOTE_CLOSE
To fix your code all you need to do is adjust your switch statements to
match on the new names, e.g. something like this:
...
case PN_CONNECTION_REMOTE_STATE:
...
Would become something like this:
...
case PN_CONNECTION_REMOTE_OPEN: // fall through
case PN_CONNECTION_REMOTE_CLOSE:
...
Please give me a shout if this will cause a problem for you, otherwise I
will land the branch in a day or two.
When speed reading the new event api the other day, the change seemed
quite large, but such a mechanic change seems easy to adapt.
Bozzo
