[GitHub] qpid-proton pull request: NO-JIRA: Measure size of encoded data.

2015-03-10 Thread alanconway
GitHub user alanconway opened a pull request: https://github.com/apache/qpid-proton/pull/11 NO-JIRA: Measure size of encoded data. Introduce pn_data_encode2 which allows you to both encode data and, if you don't have enough space, find out how much space you need. You can

[GitHub] qpid-proton pull request: NO-JIRA: Measure size of encoded data.

2015-03-11 Thread alanconway
Github user alanconway commented on the pull request: https://github.com/apache/qpid-proton/pull/11#issuecomment-78339832 On Wed, 2015-03-11 at 08:00 -0700, Andrew Stitcher wrote: > Thinking about it a bit more, I think I particularly object to the new > public API.

[GitHub] qpid-proton pull request: NO-JIRA: Measure size of encoded data.

2015-03-11 Thread alanconway
Github user alanconway commented on the pull request: https://github.com/apache/qpid-proton/pull/11#issuecomment-78340239 On Wed, 2015-03-11 at 14:26 -0400, Alan Conway wrote: > On Wed, 2015-03-11 at 08:00 -0700, Andrew Stitcher wrote: > > Thinking about it a bit more

[GitHub] qpid-proton pull request: NO-JIRA: Measure size of encoded data.

2015-03-12 Thread alanconway
Github user alanconway commented on the pull request: https://github.com/apache/qpid-proton/pull/11#issuecomment-78482514 On Thu, 2015-03-12 at 00:52 -0700, Andrew Stitcher wrote: > I'd love to hear some details. Are you suggesting we > accumulate

[GitHub] qpid-proton pull request: NO-JIRA: Measure size of encoded data.

2015-03-16 Thread alanconway
Github user alanconway commented on the pull request: https://github.com/apache/qpid-proton/pull/11#issuecomment-81791421 Comitted the suggested API upstream. Doesn't do the suggested caching yet. commit fac7c86c8bc818ea845d6426fd85095a189522d6 Author: Alan C

[GitHub] qpid-proton pull request: NO-JIRA: Measure size of encoded data.

2015-03-16 Thread alanconway
Github user alanconway closed the pull request at: https://github.com/apache/qpid-proton/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] qpid-proton pull request: NO-JIRA: Measure size of encoded data.

2015-03-17 Thread alanconway
Github user alanconway commented on the pull request: https://github.com/apache/qpid-proton/pull/11#issuecomment-82366307 On Mon, 2015-03-16 at 12:31 -0700, Andrew Stitcher wrote: > I think you new pn_data_size() possibly has the wrong side effects - > it seems to lo

[GitHub] qpid-proton pull request: C++ binding for proton.

2015-06-03 Thread alanconway
GitHub user alanconway opened a pull request: https://github.com/apache/qpid-proton/pull/35 C++ binding for proton. Cliff Jansen has been working on an event-driven C++ binding for proton, similar to the python binding. The work is not complete but I think it is almost ready to

[GitHub] qpid-proton pull request: C++ binding for proton.

2015-06-05 Thread alanconway
Github user alanconway commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/35#discussion_r31840954 --- Diff: examples/cpp/example_test.py --- @@ -0,0 +1,105 @@ +# --- End diff -- No, it is a test script that runs the C++ examples and

[GitHub] qpid-proton pull request: C++ binding for proton.

2015-06-05 Thread alanconway
Github user alanconway commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/35#discussion_r31842586 --- Diff: CMakeLists.txt --- @@ -20,16 +20,15 @@ cmake_minimum_required (VERSION 2.6) project (Proton C) +# Enable C++ now for

[GitHub] qpid-proton pull request: C++ binding for proton.

2015-06-05 Thread alanconway
Github user alanconway commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/35#discussion_r31842778 --- Diff: proton-c/bindings/CMakeLists.txt --- @@ -109,6 +109,11 @@ if (EMSCRIPTEN_FOUND) set (DEFAULT_JAVASCRIPT ON) endif

[GitHub] qpid-proton pull request: C++ binding for proton.

2015-06-05 Thread alanconway
Github user alanconway commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/35#discussion_r31842854 --- Diff: proton-c/bindings/cpp/README.md --- @@ -0,0 +1,24 @@ +# C++ binding for proton. + +This is a C++ wrapper for the proton reactor

[GitHub] qpid-proton pull request: C++ binding for proton.

2015-06-05 Thread alanconway
Github user alanconway commented on the pull request: https://github.com/apache/qpid-proton/pull/35#issuecomment-109412800 On Fri, 2015-06-05 at 11:13 -0700, Andrew Stitcher wrote: > Some overall comments (from a not yet thorough) read through: > I really don't lik

[GitHub] qpid-proton pull request: C++ binding for proton.

2015-06-05 Thread alanconway
Github user alanconway commented on the pull request: https://github.com/apache/qpid-proton/pull/35#issuecomment-109413137 On Fri, 2015-06-05 at 10:37 -0700, Andrew Stitcher wrote: > There seem to be a couple of extraneous go example files that have > snuck into t

[GitHub] qpid-proton pull request: C++ binding for proton.

2015-06-05 Thread alanconway
Github user alanconway commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/35#discussion_r31844238 --- Diff: proton-c/bindings/cpp/include/proton/cpp/Acceptor.h --- @@ -0,0 +1,50 @@ +#ifndef PROTON_CPP_ACCEPTOR_H +#define

[GitHub] qpid-proton pull request: C++ binding for proton.

2015-06-05 Thread alanconway
Github user alanconway commented on the pull request: https://github.com/apache/qpid-proton/pull/35#issuecomment-109426860 On Fri, 2015-06-05 at 13:05 -0700, Andrew Stitcher wrote: > There are a number of places in the API where the API has something > like: > vo

[GitHub] qpid-proton pull request: C++ binding for proton.

2016-01-15 Thread alanconway
Github user alanconway commented on the pull request: https://github.com/apache/qpid-proton/pull/35#issuecomment-172062911 Out of date, latest is on master branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] qpid-proton pull request: C++ binding for proton.

2016-01-15 Thread alanconway
Github user alanconway closed the pull request at: https://github.com/apache/qpid-proton/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] qpid-proton pull request: Event tidying

2016-01-19 Thread alanconway
Github user alanconway commented on the pull request: https://github.com/apache/qpid-proton/pull/63#issuecomment-173013404 Ship it! Neater and cleaner, I rebased my connection_engine branch on it, the only changes I had to make were simpifications to the dispatch loop, everything

[GitHub] qpid-proton pull request: Schema parsing should not be so greedy

2016-02-15 Thread alanconway
Github user alanconway commented on the pull request: https://github.com/apache/qpid-proton/pull/65#issuecomment-184307353 The problem is that the addresses used by proton are modelled on URLs, and those characters are not safe in a URL path: From RFC 1738 specification

[GitHub] qpid-proton pull request: Fixing broken documentation links

2016-02-24 Thread alanconway
Github user alanconway commented on the pull request: https://github.com/apache/qpid-proton/pull/68#issuecomment-188279273 What Andrew said. Sphinx handles this properly, the source .rst files have links to other .rst files - works nicely for dispatch docs. The HTML generator