[Prototype-core] Re: Why are all children of an 'update'd element being purged?

2010-07-03 Thread Viktor Kojouharov
Position (usually appended, but insertion options are available). http://api.prototypejs.org/dom/element/insert/ This same question came up some months ago. Hopefully that clarification helps. -joe t. On Jul 2, 5:24 am, Viktor Kojouharov vkojouha...@gmail.com wrote: This behaviour is a bit

[Prototype-core] Why are all children of an 'update'd element being purged?

2010-07-02 Thread Viktor Kojouharov
This behaviour is a bit unexpected, and caused some debugging time to figure out why some elements were losing their storage. Why isn't this only done during page unload? -- You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group,

[Prototype-core] Re: Proto 1.7rc1, problem with measuring width of elements with display: none

2010-04-27 Thread Viktor Kojouharov
. The 'position' is also absolute, so it could also go into the else if, but it won't, since the width is null. On Apr 22, 1:40 pm, Viktor Kojouharov vkojouha...@gmail.com wrote: I'm having a bit of a problem with measuring the width of a hidden (with display: none) element, that has the 'body

[Prototype-core] Proto 1.7rc1, problem with measuring width of elements with display: none

2010-04-22 Thread Viktor Kojouharov
I'm having a bit of a problem with measuring the width of a hidden (with display: none) element, that has the 'body' as its parent. I don't have a set width for this element (which is a div), but the browsers do calculate a finite width for it, which is much smaller than the size of the page body.

[Prototype-core] Element.Methods.absolutize throws an error in Proto 1.7rc1

2010-04-21 Thread Viktor Kojouharov
Hi, There's a small typo in the newest rc of prototype, here's the small diff: --- a/prototype.js +++ b/prototype.js @@ -4779,7 +4779,7 @@ delete Prototype._original_property; offsetParent.viewportOffset(); var offset = eOffset.relativeTo(pOffset); -var layout =

[Prototype-core] Re: Possible bug when adding additional element methods in IE8

2009-09-10 Thread Viktor Kojouharov
, Could you put together a small, self-contained test case that demonstrates what you're seeing and open a ticket in Lighthouse with it?[1] [1]http://prototypejs.org/contribute Thanks in advance, -- T.J. Crowder tj / crowder software / comwww.crowdersoftware.com On Sep 10, 11:56 am, Viktor

[Prototype-core] Re: Possible bug when adding additional element methods in IE8

2009-09-10 Thread Viktor Kojouharov
actually, looking at this further, I needed to add this line to my Element function: if (element) global.Element.prototype = element.prototype; it looks like it was added recently in prototype as well, maybe for IE8 specifically. On Sep 10, 9:09 pm, Viktor Kojouharov vkojouha...@gmail.com

[Prototype-core] Re: Roadmap for 1.6.1 (My take)

2008-07-03 Thread Viktor Kojouharov
Ken, wouldn't Enumerable.addMethods be just a wrapper around Class.addMethods? Like Class.addMethods(Enumerable, methods) On Jul 3, 7:31 am, Ken Snyder [EMAIL PROTECTED] wrote: Yes, those escapeHTML fixes are what I was thinking. I'm excited to see Event delegation! Also, I wanted to

[Prototype-core] typeof returning object for certain 'native' functions in IE

2008-06-06 Thread Viktor Kojouharov
Here's quite the problem in IE. For certain 'native' functions, like window.close, or document.getElementById, typeof for those functions returns on object in IE. Consequently, Object.isFunction will actually return false for those functions. Though there's probably little that can be done, I

[Prototype-core] Re: emitting normal HTML events with Event.fire

2008-05-14 Thread Viktor Kojouharov
No, the patch defines default values per event, including bubbling and cancelling. They can be modified by passing another object argument after the memo. On May 13, 6:16 pm, John-David Dalton [EMAIL PROTECTED] wrote: I think Prototype should support something like this, though I am not sure

[Prototype-core] emitting normal HTML events with Event.fire

2008-05-13 Thread Viktor Kojouharov
Hi, I've posted a bug ( http://prototype.lighthouseapp.com/projects/8886-prototype/tickets/96-patch-event-fire-emits-normal-html-events ) with a patch for making Event.fire work with regular events. As the description says, I've tested it with IE6, FF2, FF3, O9.26 and S3, without any problems.

[Prototype-core] Object.isHash fails with null objects in IE6

2008-05-07 Thread Viktor Kojouharov
As the subject says, if the object, passed to the isHash function is null, IE6 will throw an exception. This simple diff fixes the problem: http://pastie.caboo.se/192906 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google

[Prototype-core] Re: Object.isHash fails with null objects in IE6

2008-05-07 Thread Viktor Kojouharov
Hi again, Try testing it in IE(6) with this: Object.isHash(document.createEventObject().recordset) On May 7, 1:16 pm, Viktor Kojouharov [EMAIL PROTECTED] wrote: I can't reproduce it with 'regular' nulls, but it fails every time, if I pass it event.recordset. I don't know what that event

[Prototype-core] Re: Object.isHash fails with null objects in IE6

2008-05-07 Thread Viktor Kojouharov
[EMAIL PROTECTED] wrote: Please open a bug report for this (http://prototypejs.org/contribute) and submit a failing test case. Thank you. Tobie On May 7, 12:49 pm, Viktor Kojouharov [EMAIL PROTECTED] wrote: That was just to illustrate the problem. I'm not actually calling

[Prototype-core] Re: Array slices and Object.isObject|isBoolean

2007-11-29 Thread Viktor Kojouharov
On Nov 28, 7:07 pm, Mislav Marohnić [EMAIL PROTECTED] wrote: On Nov 28, 2007 4:54 PM, Viktor Kojouharov [EMAIL PROTECTED] wrote: If a function can take an argument, and you'd expect to get a boolean in some cases, but an object in others, what would you do? In my opinion, a function

[Prototype-core] Re: Array slices and Object.isObject|isBoolean

2007-11-26 Thread Viktor Kojouharov
I must've missed this one. The second patch still stands though. On Nov 26, 1:00 am, Sam Stephenson [EMAIL PROTECTED] wrote: On Nov 24, 2007, at 11:32 AM, Viktor Kojouharov wrote: I've submitted a patch to trac for your consideration, which adds array slices a' la Ruby http

[Prototype-core] The new Hash can no longer be used as an Ajax parameter

2007-11-24 Thread Viktor Kojouharov
I've posted a bug about this here, with an appropriate patch and testcase: http://dev.rubyonrails.org/ticket/10266 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send

[Prototype-core] Array slices and Object.isObject|isBoolean

2007-11-24 Thread Viktor Kojouharov
I've submitted a patch to trac for your consideration, which adds array slices a' la Ruby http://dev.rubyonrails.org/ticket/10268 And another one which adds the missing isObject and isBoolean methods http://dev.rubyonrails.org/ticket/10269 --~--~-~--~~~---~--~~

[Prototype-core] Re: features request

2007-11-22 Thread Viktor Kojouharov
I've made a ticket with an attached patch that adds a script insertion method a few months ago, right here: http://dev.rubyonrails.org/ticket/9871 I also believe that this method works with Safari 2 (It works with Konqueror). And so far, It has worked very well for me. On Nov 22, 11:56 am,

[Prototype-core] Re: features request

2007-11-22 Thread Viktor Kojouharov
be a good addition? On Nov 22, 1:20 pm, Mislav Marohnić [EMAIL PROTECTED] wrote: On Nov 22, 2007 11:57 AM, Viktor Kojouharov [EMAIL PROTECTED] wrote: I've made a ticket with an attached patch that adds a script insertion method a few months ago, right here: http://dev.rubyonrails.org/ticket

[Prototype-core] Re: features request

2007-11-22 Thread Viktor Kojouharov
:07 PM, Viktor Kojouharov [EMAIL PROTECTED] wrote: This is a bit off topic, but what would be the ideal process of submitting patches for you guys? It seems to me that the trac bugtracker is pretty much ignored, so should I send patches to this ML. And should I send multiple patches

[Prototype-core] Event.fire not firing DOM events

2007-11-01 Thread Viktor Kojouharov
Is there a reason why Event.fire is not firing regular DOM events, like 'click'? Or is this a planned features, but not one has the time to implement it yet? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups

[Prototype-core] a few more additions to Element._attributeTranslations

2007-10-25 Thread Viktor Kojouharov
Currently, cellspacing|padding cannot be set using writeAttribute (or new Element) in Internet explorer, since it expects cellSpacing| Padding instead. I suggest the following be added to Element._attributeTranslations.write (and maybe .read too). This is what I'm currently using until the issue

[Prototype-core] Re: a few more additions to Element._attributeTranslations

2007-10-25 Thread Viktor Kojouharov
? Thanks, Tobie On Oct 25, 11:12 am, Viktor Kojouharov [EMAIL PROTECTED] wrote: Currently, cellspacing|padding cannot be set using writeAttribute (or new Element) in Internet explorer, since it expects cellSpacing| Padding instead. I suggest the following be added to Element

[Prototype-core] String.prototype.evalScripts and script src=foo.js

2007-10-24 Thread Viktor Kojouharov
Since currently prototype can't eval such scripts, I've a patch, which 'evals' such script tags. It includes a modified evalScripts method, a document.insertScript method, and tests for those methods. I've uploaded the patch as the second patch to this bug: http://dev.rubyonrails.org/ticket/9871

[Prototype-core] Re: `new Element' does not take care to properly set up event attributes in IE

2007-10-19 Thread Viktor Kojouharov
On Oct 19, 6:58 pm, Mislav Marohnić [EMAIL PROTECTED] wrote: On 10/19/07, Viktor Kojouharov [EMAIL PROTECTED] wrote: That being said, this is my drop-in replacement: ... Viktor, After giving it a second thought, I realize that the general direction of your solution might not be so

[Prototype-core] Creating unit tests for asynchronous operations

2007-10-15 Thread Viktor Kojouharov
Currently, the only way to create unit tests for such operations is to use the wait function. However, async operations have a nasty habit of always finishing after the waiting time is over, which causes an unjust test failure. So I've made extension to the unittest library, which allows me to

[Prototype-core] Event methods' bug in Internet Explorer

2007-10-02 Thread Viktor Kojouharov
With the current style of extending the event object and using the newly methods in prototype itself can lead to errors in internet explorer. The reason being that, even though the event object is extended if the observe element method was used, it is not when the event was triggered from the

[Prototype-core] keypress remapped as keydown in prototype 1.6rc0

2007-09-25 Thread Viktor Kojouharov
Why has the keypress been remapped as keydown in the rc? AFAIK, keypress is the only key event that fires as the button is held pressed. With this remap, it's impossible to create continuous actions. Is there any particular reason why this remap has been introduced?

[Prototype-core] Re: General global element events and prototype 1.6.0_rc0

2007-08-20 Thread Viktor Kojouharov
, Mislav Marohnić [EMAIL PROTECTED] wrote: On 8/17/07, Viktor Kojouharov [EMAIL PROTECTED] wrote: However, there's still the issue of having support for global element events, like 'mousewheel', 'mouseenter', and 'mouseout', that would work with all elements, and reuse existing event

[Prototype-core] General global element events and prototype 1.6.0_rc0

2007-08-17 Thread Viktor Kojouharov
Hello, Before 1.6, I had a set of functions on top of the Event.observe family of functions, which dealt with registering callbacks for events, like this: signalConnect: function(element, name, observer) { if (!element || !name || !observer) return; if (!element.signals)

[Prototype-core] Re: General global element events and prototype 1.6.0_rc0

2007-08-17 Thread Viktor Kojouharov
On Aug 17, 1:24 pm, Mislav Marohnić [EMAIL PROTECTED] wrote: On 8/17/07, Viktor Kojouharov [EMAIL PROTECTED] wrote: However, there's still the issue of having support for global element events, like 'mousewheel', 'mouseenter', and 'mouseout', that would work with all elements