[Prototype-core] Adding Prototype.Revision

2008-02-03 Thread Nick Stakenburg
I recently wrote a patch for Scriptaculous that allows version checking beyond the x.x.x scope. It allows to check for 1.6.0.2 instead of just 1.6.0, this will help to inform people when they use incompatible version of prototype/scriptaculous. http://dev.rubyonrails.org/ticket/10966 Tobie

[Prototype-core] Re: Adding Prototype.Revision

2008-02-03 Thread artemy tregoubenko
Latest Prototype here: http://prototypejs.org/assets/2008/1/25/prototype-1.6.0.2.js has following lines at the top: var Prototype = { Version: '1.6.0.2', Isn't this enough? I think using revision number is mostly replacing one readable number with another unreadable. I believe versions are

[Prototype-core] Starting noconflict support - putting $() into a namespace [reposted from Spinoffs group]

2008-02-03 Thread DK
Changing topic :-) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL

[Prototype-core] Re: Adding Prototype.Revision

2008-02-03 Thread Nick Stakenburg
A build number based on both version and svn changeset could prevent those issues with backported bugfixes. A suggestion: Prototype.Build: 1602.8769 On 3 feb, 17:13, Tobie Langel [EMAIL PROTECTED] wrote: Hi Artemy, The version number is just a pain to parse. A build number also happens to

[Prototype-core] Re: Adding Prototype.Revision

2008-02-03 Thread Nick Stakenburg
I think we should have both version string and SVN revision from which it was built. Also, Prototype versions could simply be compared like integers in this fashion: function vnum(vstring) { return parseInt(vstring.replace(/\./g, '') + '0'.times(4-(vstring.length/2).ceil())) } vnum('1.6')

[Prototype-core] Re: Adding Prototype.Revision

2008-02-03 Thread artemy tregoubenko
I previously had success at comparing version numbers as string like that: '1.6' '1.6.0.2' true '1.5.0.1' '1.6' true Thus I am surprised that you parse these strings On Sun, 03 Feb 2008 21:39:56 +0300, Nick Stakenburg [EMAIL PROTECTED] wrote: I think we should have both version string

[Prototype-core] Re: Adding Prototype.Revision

2008-02-03 Thread Fabian Lange
Hi, You will have problems in a few releases: '1.6' '1.10.1' false However I don't see a reason for Nicks patch. If you need to check the 4th digit of version number due to compatibility issues then we have an issue .: Fabian -Original Message- From: [EMAIL PROTECTED] om

[Prototype-core] Re: Adding Prototype.Revision

2008-02-03 Thread Tobie Langel
Artemy, 1.6.0 1.6.0_rc1 false Best, Tobie On Feb 3, 8:22 pm, artemy tregoubenko [EMAIL PROTECTED] wrote: I previously had success at comparing version numbers as string like that: '1.6' '1.6.0.2' true '1.5.0.1' '1.6' true Thus I am surprised that you parse these strings On

[Prototype-core] Re: Adding Prototype.Revision

2008-02-03 Thread artemy tregoubenko
I see, thanks Artemy, 1.6.0 1.6.0_rc1 false Best, Tobie On Feb 3, 8:22 pm, artemy tregoubenko [EMAIL PROTECTED] wrote: I previously had success at comparing version numbers as string like that: '1.6' '1.6.0.2' true '1.5.0.1' '1.6' true Thus I am surprised that you parse

[Prototype-core] Re: Adding Prototype.Revision

2008-02-03 Thread Nick Stakenburg
However I don't see a reason for Nicks patch. If you need to check the 4th digit of version number due to compatibility issues then we have an issue .: Fabian A lot of questions on irc #prototype relate to people not using the correct version of prototype/scriptaculous together. Even

[Prototype-core] Re: Adding Prototype.Revision

2008-02-03 Thread artemy tregoubenko
On Sun, 03 Feb 2008 22:47:59 +0300, Fabian Lange [EMAIL PROTECTED] wrote: You will have problems in a few releases: '1.6' '1.10.1' false On Sun, 03 Feb 2008 20:00:47 +0300, Mislav Marohnić [EMAIL PROTECTED] wrote: That is because none of the version fragments will ever be bigger than 9. --

[Prototype-core] Re: Cross-browser Event.simulateMouse [bump via kangax]

2008-02-03 Thread Dr Nic
Since the existing Event.simulateMouse code is labelled experimental, then this code with its suite of tests must be an improvement worth patching in? Even if it retains its experimental label, it will be an enhancement/bug fix patch for existing code. Whilst the ticket is categorised