Re: [ptxdist] [PATCH] Add persistant iptable-rules via systemd

2016-04-12 Thread Michael Olbrich
On Mon, Apr 11, 2016 at 07:46:10PM +0200, Uwe Kleine-König wrote: > Hello, > > even though I said for (implict) v2 that I'm lucky now, > I still found a few things to critize/ask. > > You could be a still better ptxdist citizen if you used -v3 for > git format-patch (or git send-email if you

Re: [ptxdist] [PATCH] Add persistant iptable-rules via systemd

2016-04-11 Thread Uwe Kleine-König
Hello, even though I said for (implict) v2 that I'm lucky now, I still found a few things to critize/ask. You could be a still better ptxdist citizen if you used -v3 for git format-patch (or git send-email if you didn't do the explicit format-patch step). For additional karma add a section like:

Re: [ptxdist] [PATCH] Add persistant iptable-rules via systemd

2016-04-11 Thread Michael Olbrich
Hi, On Mon, Apr 11, 2016 at 12:08:51PM +, Schenk, Gavin wrote: > > > +for table in $( > > > This does not work with a busybox /bin/sh. I think that's bashism. > > > > This should work: > > > > for table in $(cat /proc/net/ip6_tables_names); do ... > > > > Note: It doesn't fail! The list

[ptxdist] [PATCH] Add persistant iptable-rules via systemd

2016-04-11 Thread Gavin Schenk
Supports ipv4 and ipv6 and both options can be selected in menuconfig by IPTABLES_IPV6_SYSTEMD_UNIT and/or IPTABLES_IPV4_SYSTEMD_UNIT If you select IPTABLES_IPV4_SYSTEMD_UNIT a systemd unit is started on multiuser.target that set the iptable rules from file: /etc/iptables/rules.v4 If you select

Re: [ptxdist] [PATCH] Add persistant iptable-rules via systemd

2016-04-11 Thread Michael Olbrich
On Fri, Apr 08, 2016 at 03:04:10PM +0200, Gavin Schenk wrote: > Supports ipv4 and ipv6 and both options can be selected in menuconfig > by IPTABLES_IPV6_SYSTEMD_UNIT and/or IPTABLES_IPV4_SYSTEMD_UNIT > > If you select IPTABLES_IPV4_SYSTEMD_UNIT a systemd unit is started on > multiuser.target that

[ptxdist] [PATCH] Add persistant iptable-rules via systemd

2016-04-08 Thread Gavin Schenk
Supports ipv4 and ipv6 and both options can be selected in menuconfig by IPTABLES_IPV6_SYSTEMD_UNIT and/or IPTABLES_IPV4_SYSTEMD_UNIT If you select IPTABLES_IPV4_SYSTEMD_UNIT a systemd unit is started on multiuser.target that set the iptable rules from file: /etc/iptables/rules.v4 If you select

Re: [ptxdist] [PATCH] Add persistant iptable-rules via systemd

2016-04-07 Thread Michael Olbrich
On Thu, Apr 07, 2016 at 12:10:04PM +0200, Gavin Schenk wrote: > Supports ipv4 and ipv6 and both options can be selected in menuconfig > IPTABLES_IPV6_SYSTEMD_UNIT and IPTABLES_IPV4_SYSTEMD_UNIT > > If you select IPTABLES_IPV4_SYSTEMD_UNIT a systemd unit is started on > multiuser.target that set

[ptxdist] [PATCH] Add persistant iptable-rules via systemd

2016-04-07 Thread Gavin Schenk
Supports ipv4 and ipv6 and both options can be selected in menuconfig by IPTABLES_IPV6_SYSTEMD_UNIT and/or IPTABLES_IPV4_SYSTEMD_UNIT If you select IPTABLES_IPV4_SYSTEMD_UNIT a systemd unit is started on multiuser.target that set the iptable rules from file: /etc/iptables/rules.v4 If you select

Re: [ptxdist] [PATCH] Add persistant iptable-rules via systemd

2016-04-07 Thread Uwe Kleine-König
Hello, git format-patch helps you to add a version to your patch. In this case -v2 would have been nice. This makes it easier for Michael to pick up the right patch. On Thu, Apr 07, 2016 at 12:10:04PM +0200, Gavin Schenk wrote: > Supports ipv4 and ipv6 and both options can be selected in

[ptxdist] [PATCH] Add persistant iptable-rules via systemd

2016-04-07 Thread Gavin Schenk
Supports ipv4 and ipv6 and both options can be selected in menuconfig IPTABLES_IPV6_SYSTEMD_UNIT and IPTABLES_IPV4_SYSTEMD_UNIT If you select IPTABLES_IPV4_SYSTEMD_UNIT a systemd unit is started on multiuser.target that set the iptable rules from file /etc/iptables/rules.v4. If you select

Re: [ptxdist] [PATCH] Add persistant iptable-rules via systemd

2016-04-07 Thread Schenk, Gavin
Hi, > > Assuming this does the trick, this has the added benefit that module loading > is tried. > Ok. > > > > If [ $IPTABLES_SUPPORT -gt 0 ]; then > > echo "iptables is not supported by your kernel" > > exit $IPTABLES_SUPPORT > > fi > > I'd use: > > if ! iptables --list

Re: [ptxdist] [PATCH] Add persistant iptable-rules via systemd

2016-04-07 Thread Uwe Kleine-König
Hello, On Thu, Apr 07, 2016 at 09:14:01AM +, Schenk, Gavin wrote: > > > +diff --git a/scripts/ip6tables-flush b/scripts/ip6tables-flush new > > > +file mode 100755 index ..95086b0470d3 > > > +--- /dev/null > > > b/scripts/ip6tables-flush > > > +@@ -0,0 +1,13 @@ > > >

Re: [ptxdist] [PATCH] Add persistant iptable-rules via systemd

2016-04-07 Thread Schenk, Gavin
Hi, > > If you select IPTABLES_IPV4_SYSTEMD_UNIT a systemd unit is started on > > multiuser.target that set the iptable rules from file > > /etc/iptables/rules.v4. > > If you select IPTABLES_IPV6_SYSTEMD_UNIT a systemd unit is started on > > multiuser.target that set the iptable rules from the

Re: [ptxdist] [PATCH] Add persistant iptable-rules via systemd

2016-04-07 Thread Uwe Kleine-König
Hello, On Thu, Apr 07, 2016 at 09:24:26AM +0200, Gavin Schenk wrote: > Supports ipv4 and ipv6 and both options can be selected in menuconfig > IPTABLES_IPV6_SYSTEMD_UNIT and IPTABLES_IPV4_SYSTEMD_UNIT > > If you select IPTABLES_IPV4_SYSTEMD_UNIT a systemd unit is started on > multiuser.target

[ptxdist] [PATCH] Add persistant iptable-rules via systemd

2016-04-07 Thread Gavin Schenk
Supports ipv4 and ipv6 and both options can be selected in menuconfig IPTABLES_IPV6_SYSTEMD_UNIT and IPTABLES_IPV4_SYSTEMD_UNIT If you select IPTABLES_IPV4_SYSTEMD_UNIT a systemd unit is started on multiuser.target that set the iptable rules from file /etc/iptables/rules.v4. If you select