Re: [Pulp-dev] Proposal to remove 'notes' fields from the Pulp 3 RC

[Dana Walker]

+1

Dana Walker

Associate Software Engineer

Red Hat





On Tue, Dec 4, 2018 at 1:52 PM Tatiana Tereshchenko 
wrote:

> +1
>
> On Tue, Dec 4, 2018 at 4:49 PM Brian Bouterse  wrote:
>
>> +1. Ty for bringing this up @dalley
>>
>> On Tue, Dec 4, 2018 at 10:47 AM Jeff Ortel  wrote:
>>
>>> no objection
>>>
>>> On 12/3/18 10:32 PM, Daniel Alley wrote:
>>>
>>> *Background:*
>>>
>>> "Notes" are a generic key value store where data can be attached to
>>> repositories and content and publications and so forth.  The eventual plan
>>> is to use this to enable adding tags to those sorts of objects, which is
>>> important for Katello.
>>>
>>> Most of the code for this is located in pulp/app/models/generic.py
>>>
>>> *Motivation:*
>>>
>>> "Notes" have been in Pulp 3 for a very very long time and are completely
>>> unchanged for the last 12 months (the git history doesn't go back further
>>> because the file was moved).  The data model behind it is extremely complex
>>> and while we have a few unit tests around it, we have no functional tests
>>> for it whatsoever, and (to my knowledge) we haven't been using/exercising
>>> this functionality manually in a meaningful way (if at all).  I could be
>>> wrong here, but I haven't seen it discussed  or any issues related to it
>>> filed in quite some time.
>>>
>>> *Proposal:*
>>>
>>> We should pull out all of the "notes" code (models/generic.py + the
>>> fields on the aforementioned models) until we've had a chance to properly
>>> evaluate our needs and whether the current design fits them.
>>>
>>> ___
>>> Pulp-dev mailing 
>>> listPulp-dev@redhat.comhttps://www.redhat.com/mailman/listinfo/pulp-dev
>>>
>>>
>>> ___
>>> Pulp-dev mailing list
>>> Pulp-dev@redhat.com
>>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>>
>> ___
>> Pulp-dev mailing list
>> Pulp-dev@redhat.com
>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>
> ___
> Pulp-dev mailing list
> Pulp-dev@redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev
>
___
Pulp-dev mailing list
Pulp-dev@redhat.com
https://www.redhat.com/mailman/listinfo/pulp-dev

Re: [Pulp-dev] Proposal to remove 'notes' fields from the Pulp 3 RC

[Tatiana Tereshchenko]

+1

On Tue, Dec 4, 2018 at 4:49 PM Brian Bouterse  wrote:

> +1. Ty for bringing this up @dalley
>
> On Tue, Dec 4, 2018 at 10:47 AM Jeff Ortel  wrote:
>
>> no objection
>>
>> On 12/3/18 10:32 PM, Daniel Alley wrote:
>>
>> *Background:*
>>
>> "Notes" are a generic key value store where data can be attached to
>> repositories and content and publications and so forth.  The eventual plan
>> is to use this to enable adding tags to those sorts of objects, which is
>> important for Katello.
>>
>> Most of the code for this is located in pulp/app/models/generic.py
>>
>> *Motivation:*
>>
>> "Notes" have been in Pulp 3 for a very very long time and are completely
>> unchanged for the last 12 months (the git history doesn't go back further
>> because the file was moved).  The data model behind it is extremely complex
>> and while we have a few unit tests around it, we have no functional tests
>> for it whatsoever, and (to my knowledge) we haven't been using/exercising
>> this functionality manually in a meaningful way (if at all).  I could be
>> wrong here, but I haven't seen it discussed  or any issues related to it
>> filed in quite some time.
>>
>> *Proposal:*
>>
>> We should pull out all of the "notes" code (models/generic.py + the
>> fields on the aforementioned models) until we've had a chance to properly
>> evaluate our needs and whether the current design fits them.
>>
>> ___
>> Pulp-dev mailing 
>> listPulp-dev@redhat.comhttps://www.redhat.com/mailman/listinfo/pulp-dev
>>
>>
>> ___
>> Pulp-dev mailing list
>> Pulp-dev@redhat.com
>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>
> ___
> Pulp-dev mailing list
> Pulp-dev@redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev
>
___
Pulp-dev mailing list
Pulp-dev@redhat.com
https://www.redhat.com/mailman/listinfo/pulp-dev

Re: [Pulp-dev] Proposal to remove 'notes' fields from the Pulp 3 RC

[Brian Bouterse]

+1. Ty for bringing this up @dalley

On Tue, Dec 4, 2018 at 10:47 AM Jeff Ortel  wrote:

> no objection
>
> On 12/3/18 10:32 PM, Daniel Alley wrote:
>
> *Background:*
>
> "Notes" are a generic key value store where data can be attached to
> repositories and content and publications and so forth.  The eventual plan
> is to use this to enable adding tags to those sorts of objects, which is
> important for Katello.
>
> Most of the code for this is located in pulp/app/models/generic.py
>
> *Motivation:*
>
> "Notes" have been in Pulp 3 for a very very long time and are completely
> unchanged for the last 12 months (the git history doesn't go back further
> because the file was moved).  The data model behind it is extremely complex
> and while we have a few unit tests around it, we have no functional tests
> for it whatsoever, and (to my knowledge) we haven't been using/exercising
> this functionality manually in a meaningful way (if at all).  I could be
> wrong here, but I haven't seen it discussed  or any issues related to it
> filed in quite some time.
>
> *Proposal:*
>
> We should pull out all of the "notes" code (models/generic.py + the fields
> on the aforementioned models) until we've had a chance to properly evaluate
> our needs and whether the current design fits them.
>
> ___
> Pulp-dev mailing 
> listPulp-dev@redhat.comhttps://www.redhat.com/mailman/listinfo/pulp-dev
>
>
> ___
> Pulp-dev mailing list
> Pulp-dev@redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev
>
___
Pulp-dev mailing list
Pulp-dev@redhat.com
https://www.redhat.com/mailman/listinfo/pulp-dev

Re: [Pulp-dev] Proposal to remove 'notes' fields from the Pulp 3 RC

[Daniel Alley]

Issue filed and added to sprint https://pulp.plan.io/issues/4222

On Tue, Dec 4, 2018 at 9:14 AM Dennis Kliban  wrote:

> +1 to removing it
>
> On Tue, Dec 4, 2018 at 8:34 AM Austin Macdonald 
> wrote:
>
>> +1, nice catch Daniel.
>>
>> On Tue, Dec 4, 2018, 7:14 AM David Davis >
>>> Big +1. This seems like something we could add later on at any time when
>>> we need it. Hopefully we can get Katello and our users involved in sussing
>>> out the requirements for how this field should work too.
>>>
>>> David
>>>
>>>
>>> On Mon, Dec 3, 2018 at 11:34 PM Daniel Alley  wrote:
>>>
 *Background:*

 "Notes" are a generic key value store where data can be attached to
 repositories and content and publications and so forth.  The eventual plan
 is to use this to enable adding tags to those sorts of objects, which is
 important for Katello.

 Most of the code for this is located in pulp/app/models/generic.py

 *Motivation:*

 "Notes" have been in Pulp 3 for a very very long time and are
 completely unchanged for the last 12 months (the git history doesn't go
 back further because the file was moved).  The data model behind it is
 extremely complex and while we have a few unit tests around it, we have no
 functional tests for it whatsoever, and (to my knowledge) we haven't been
 using/exercising this functionality manually in a meaningful way (if at
 all).  I could be wrong here, but I haven't seen it discussed  or any
 issues related to it filed in quite some time.

 *Proposal:*

 We should pull out all of the "notes" code (models/generic.py + the
 fields on the aforementioned models) until we've had a chance to properly
 evaluate our needs and whether the current design fits them.
 ___
 Pulp-dev mailing list
 Pulp-dev@redhat.com
 https://www.redhat.com/mailman/listinfo/pulp-dev

>>> ___
>>> Pulp-dev mailing list
>>> Pulp-dev@redhat.com
>>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>>
>> ___
>> Pulp-dev mailing list
>> Pulp-dev@redhat.com
>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>
> ___
> Pulp-dev mailing list
> Pulp-dev@redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev
>
___
Pulp-dev mailing list
Pulp-dev@redhat.com
https://www.redhat.com/mailman/listinfo/pulp-dev

Re: [Pulp-dev] Proposal to remove 'notes' fields from the Pulp 3 RC

[Jeff Ortel]

no objection

On 12/3/18 10:32 PM, Daniel Alley wrote:

*Background:*

"Notes" are a generic key value store where data can be attached to 
repositories and content and publications and so forth.  The eventual 
plan is to use this to enable adding tags to those sorts of objects, 
which is important for Katello.


Most of the code for this is located in pulp/app/models/generic.py

*Motivation:*

"Notes" have been in Pulp 3 for a very very long time and are 
completely unchanged for the last 12 months (the git history doesn't 
go back further because the file was moved). The data model behind it 
is extremely complex and while we have a few unit tests around it, we 
have no functional tests for it whatsoever, and (to my knowledge) we 
haven't been using/exercising this functionality manually in a 
meaningful way (if at all).  I could be wrong here, but I haven't seen 
it discussed  or any issues related to it filed in quite some time.


*Proposal:*

We should pull out all of the "notes" code (models/generic.py + the 
fields on the aforementioned models) until we've had a chance to 
properly evaluate our needs and whether the current design fits them.


___
Pulp-dev mailing list
Pulp-dev@redhat.com
https://www.redhat.com/mailman/listinfo/pulp-dev


___
Pulp-dev mailing list
Pulp-dev@redhat.com
https://www.redhat.com/mailman/listinfo/pulp-dev

Re: [Pulp-dev] Proposal to remove 'notes' fields from the Pulp 3 RC

[Dennis Kliban]

+1 to removing it

On Tue, Dec 4, 2018 at 8:34 AM Austin Macdonald  wrote:

> +1, nice catch Daniel.
>
> On Tue, Dec 4, 2018, 7:14 AM David Davis 
>> Big +1. This seems like something we could add later on at any time when
>> we need it. Hopefully we can get Katello and our users involved in sussing
>> out the requirements for how this field should work too.
>>
>> David
>>
>>
>> On Mon, Dec 3, 2018 at 11:34 PM Daniel Alley  wrote:
>>
>>> *Background:*
>>>
>>> "Notes" are a generic key value store where data can be attached to
>>> repositories and content and publications and so forth.  The eventual plan
>>> is to use this to enable adding tags to those sorts of objects, which is
>>> important for Katello.
>>>
>>> Most of the code for this is located in pulp/app/models/generic.py
>>>
>>> *Motivation:*
>>>
>>> "Notes" have been in Pulp 3 for a very very long time and are completely
>>> unchanged for the last 12 months (the git history doesn't go back further
>>> because the file was moved).  The data model behind it is extremely complex
>>> and while we have a few unit tests around it, we have no functional tests
>>> for it whatsoever, and (to my knowledge) we haven't been using/exercising
>>> this functionality manually in a meaningful way (if at all).  I could be
>>> wrong here, but I haven't seen it discussed  or any issues related to it
>>> filed in quite some time.
>>>
>>> *Proposal:*
>>>
>>> We should pull out all of the "notes" code (models/generic.py + the
>>> fields on the aforementioned models) until we've had a chance to properly
>>> evaluate our needs and whether the current design fits them.
>>> ___
>>> Pulp-dev mailing list
>>> Pulp-dev@redhat.com
>>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>>
>> ___
>> Pulp-dev mailing list
>> Pulp-dev@redhat.com
>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>
> ___
> Pulp-dev mailing list
> Pulp-dev@redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev
>
___
Pulp-dev mailing list
Pulp-dev@redhat.com
https://www.redhat.com/mailman/listinfo/pulp-dev

Re: [Pulp-dev] Proposal to remove 'notes' fields from the Pulp 3 RC

[Austin Macdonald]

+1, nice catch Daniel.

On Tue, Dec 4, 2018, 7:14 AM David Davis  Big +1. This seems like something we could add later on at any time when
> we need it. Hopefully we can get Katello and our users involved in sussing
> out the requirements for how this field should work too.
>
> David
>
>
> On Mon, Dec 3, 2018 at 11:34 PM Daniel Alley  wrote:
>
>> *Background:*
>>
>> "Notes" are a generic key value store where data can be attached to
>> repositories and content and publications and so forth.  The eventual plan
>> is to use this to enable adding tags to those sorts of objects, which is
>> important for Katello.
>>
>> Most of the code for this is located in pulp/app/models/generic.py
>>
>> *Motivation:*
>>
>> "Notes" have been in Pulp 3 for a very very long time and are completely
>> unchanged for the last 12 months (the git history doesn't go back further
>> because the file was moved).  The data model behind it is extremely complex
>> and while we have a few unit tests around it, we have no functional tests
>> for it whatsoever, and (to my knowledge) we haven't been using/exercising
>> this functionality manually in a meaningful way (if at all).  I could be
>> wrong here, but I haven't seen it discussed  or any issues related to it
>> filed in quite some time.
>>
>> *Proposal:*
>>
>> We should pull out all of the "notes" code (models/generic.py + the
>> fields on the aforementioned models) until we've had a chance to properly
>> evaluate our needs and whether the current design fits them.
>> ___
>> Pulp-dev mailing list
>> Pulp-dev@redhat.com
>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>
> ___
> Pulp-dev mailing list
> Pulp-dev@redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev
>
___
Pulp-dev mailing list
Pulp-dev@redhat.com
https://www.redhat.com/mailman/listinfo/pulp-dev

Re: [Pulp-dev] Proposal to remove 'notes' fields from the Pulp 3 RC

[David Davis]

Big +1. This seems like something we could add later on at any time when we
need it. Hopefully we can get Katello and our users involved in sussing out
the requirements for how this field should work too.

David


On Mon, Dec 3, 2018 at 11:34 PM Daniel Alley  wrote:

> *Background:*
>
> "Notes" are a generic key value store where data can be attached to
> repositories and content and publications and so forth.  The eventual plan
> is to use this to enable adding tags to those sorts of objects, which is
> important for Katello.
>
> Most of the code for this is located in pulp/app/models/generic.py
>
> *Motivation:*
>
> "Notes" have been in Pulp 3 for a very very long time and are completely
> unchanged for the last 12 months (the git history doesn't go back further
> because the file was moved).  The data model behind it is extremely complex
> and while we have a few unit tests around it, we have no functional tests
> for it whatsoever, and (to my knowledge) we haven't been using/exercising
> this functionality manually in a meaningful way (if at all).  I could be
> wrong here, but I haven't seen it discussed  or any issues related to it
> filed in quite some time.
>
> *Proposal:*
>
> We should pull out all of the "notes" code (models/generic.py + the fields
> on the aforementioned models) until we've had a chance to properly evaluate
> our needs and whether the current design fits them.
> ___
> Pulp-dev mailing list
> Pulp-dev@redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev
>
___
Pulp-dev mailing list
Pulp-dev@redhat.com
https://www.redhat.com/mailman/listinfo/pulp-dev