On Wed, 1 Nov 2017 13:47:04 +0200, Tanu Kaskinen wrote:
Hi,
> remove unnecessary RefPtr wrapping of PavuApplication
> remove unnecessary Window -> MainWindow casting
Seems all well to me!
--
Colin
___
pulseaudio-discuss mailing
On Wed, 01 Nov 2017 13:50:02 +0200, Tanu Kaskinen wrote:
> Thanks! I applied your patch now.
Hi Tanu,
Thanks ! and thanks for your patches on top of it :)
--
Colin
___
pulseaudio-discuss mailing list
rently a lot of magic happening behind
> the scenes, and it would be good to have a comment that explains how
> the magic works.
I've added comments on every Gtk::Application aspect of the thing. I
hope they make things more clear.
Thanks,
--
Colin
>From 6326135813c0ec95739
On 30 October 2017 at 16h15, Tanu Kaskinen wrote:
Hi,
> This is a weird function. [...]
> I think it would be better if this function was only called when the
> caller really wants to apply the heuristics.
I'll update the patch to do that.
Below are answers to the rest of your questions:
> >
Aand, I sent the wrong patch. Here's the correct one.
--
Colin
From 2120613fa5bd68ebbdd0e9428357030736fce013 Mon Sep 17 00:00:00 2001
From: Colin Leroy <co...@colino.net>
Date: Thu, 26 Oct 2017 22:20:36 +0200
Subject: [PATCH] Implement single-launch with Gtk::Application
This intr
at start time.
I hope you'll consider it for inclusion :)
--
Colin
From: Colin Leroy <co...@colino.net>
Date: Thu, 26 Oct 2017 22:20:36 +0200
Subject: [PATCH 2/2] Implement single-launch with Gtk::Application
This introduces a new file for clarity. Options
handling changes so that --tab c
Hello,
I very often end up with six or more instances of pavucontrol running,
because I click on its launcher to set things up, and then go back to
whatever I was doing without closing the pavucontrol window.
Would a single-instance launch patch be welcome ? If so, I could cook
up something
On 12 October 2017 at 22h04, Colin Leroy wrote:
Hi,
> I would really appreciate if owners of different AirPlay hardware
> (like Apple's hardware) could test with PulseAudio's git master
I forgot to say: Alternatively, you can also test with PulseAudio 11.0
or 11.1, but you'll have to
Hello,
In the last monthes I've worked a bit on Pulseaudio's RAOP module, to
make it work better with various AirPlay servers. My latest work has
been to announce the correct latency needed to play synchronized
audio/video system-wide.
Unfortunately I could only test with my own hardware (a
This will make it easier for testers to report latency offset for
their specific hardware.
--
Colin
>From af1470e2c46189a7a735e0d50a8fd6deaecc0f4b Mon Sep 17 00:00:00 2001
From: Colin Leroy <co...@colino.net>
Date: Mon, 9 Oct 2017 09:26:42 +0200
Subject: [PATCH 1/2] RAOP: Show device
f3c Mon Sep 17 00:00:00 2001
From: Colin Leroy <co...@colino.net>
Date: Mon, 9 Oct 2017 09:42:27 +0200
Subject: [PATCH 2/2] RAOP: Init dummy port and card for latency change
This adds a port, card and profile to RAOP sinks to make it
possible to change the latency at runtime (and have it persi
Hi folks, hi Tanu,
Here's the v3 of the patches that allow user-setting of RAOP's latency
offset.
Hope this helps!
--
Colin
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
On 08 October 2017 at 21h21, Tanu Kaskinen wrote:
Hi,
> > +} else if (pa_streq(model, "ShairportSync")) {
> > +/* Shairport - software AirPort server */
> > +default_latency = 2352;
> > }
> >
> > pa_log_debug("Default latency is %u ms for device model %s.",
> >
Hi,
Here's a new version of my last patchset after Tanu's partial review.
The first one adds a device.model property to the sink; the second one
adds a port to the sink so that its latency can be controlled at
runtime; and the last one adds the correct latency value for
the Shairport server.
From: Colin Leroy <co...@colino.net>
Date: Sat, 7 Oct 2017 20:04:42 +0200
Subject: [PATCH 1/3] RAOP: Show device codename in sink properties
This will make it easier for testers to report latency offset for their
specific hardware.
Also, remove the IP:port part from the device descr
This adds a port, card and profile to RAOP sinks to make it
possible to change the latency at runtime (and have it persist)
using pavucontrol or pactl set-port-latency-offset.
--
Colin
From bd815a400ad280627083cbce3ef9b927f669faa0 Mon Sep 17 00:00:00 2001
From: Colin Leroy <co...@colino.net>
After testing, Shairport server's latency is the same as Pioneer N30.
--
Colin
From 5882bd15c528a0e9987a02f9ddcdd093087ae548 Mon Sep 17 00:00:00 2001
From: Colin Leroy <co...@colino.net>
Date: Sat, 7 Oct 2017 20:11:49 +0200
Subject: [PATCH 3/3] RAOP: Add latency value for Shairport RAOP
and Airplay using iTunes on my Mac is fine
>
> I assumed my Airport would be on an 192.168.0.* address, so I don’t
> know where 169.254.13.13 is coming from. Do you think this could be
> the problem then?
>
> Regards,
>
> John
>
> > On 6 Oct 2017, at 13:47, Colin
On 06 October 2017 at 09h14, Colin Leroy wrote:
Hi folks,
> I'm not sure I understand correctly, but it looks like to me
> setLatencyOffset() is only called if the sink has more than one port?
>
> I would love if someone could enlighten me: did I understand the
> pavucontrol
Hi,
Airplay hardware has a inherent latency of at least 2 seconds, with
2350ms being a common value.
--
Colin
From a08262dcf1b4d0c5251070b1b78e0ab6cbc63a58 Mon Sep 17 00:00:00 2001
From: Colin Leroy <co...@colino.net>
Date: Fri, 6 Oct 2017 20:20:16 +0200
Subject: [PATCH] Set latency of
aa6c6de3304a0834d3c1ebcf1a5b3780498216fe Mon Sep 17 00:00:00 2001
From: Colin Leroy <co...@colino.net>
Date: Fri, 6 Oct 2017 20:11:32 +0200
Subject: [PATCH 2/2] RAOP: Add latency value for Shairport RAOP server
After testing, Shairport server's latency is the same as Pioneer N30.
---
src/modules/raop/module-raop-discover
Hi,
This adds a port, card and profile to RAOP sinks to make it
possible to change the latency at runtime (and have it persist)
using pavucontrol or pactl set-port-latency-offset.
--
Colin
From d4549b517930975d0c637fb685f6ae147018f8a4 Mon Sep 17 00:00:00 2001
From: Colin Leroy <co...@colino.
On Fri, 06 Oct 2017 14:00:55 +0100, John Clare wrote:
> I assumed my Airport would be on an 192.168.0.* address, so I don’t
> know where 169.254.13.13 is coming from. Do you think this could be
> the problem then?
Yes, very probably. Check what your IP is on your Linux
On Fri, 06 Oct 2017 12:37:52 +0100, John Clare wrote:
Hi John,
The log doesn't seem to indicate much wrong, apart from the obvious
> E: [pulseaudio] rtsp_client.c: Connection failed: Connection timed out
It seems your Airport Express's IP address is the "failed DHCP request"
Hello,
While working on the previously posted patch, I've noticed (it was
about time!) a little "Advanced" section in my internal sound card's
Output Device entry in pavucontrol. Clicking it I discovered a
latency offset setter.
I thought that would be ideal to have that in RAOP sinks too, and
Hi,
Tanu, here's the patch you were suggesting earlier.
This will make it easier for testers to report latency offset for their
specific hardware.
--
Colin
From 4ee8ecffad804f48ba38984299fc0a3289d56941 Mon Sep 17 00:00:00 2001
From: Colin Leroy <co...@colino.net>
Date: Thu, 5 Oct 2017 21
On 05 October 2017 at 21h19, Tanu Kaskinen wrote:
Hi,
> Yes, that seems like a fine idea. I'd like to first make the device
> model string easily available for testers. Digging it up from the
> verbose log isn't really user-friendly. It could be simply added to
> the raop sink proplist, so
On Thu, 21 Sep 2017 16:00:28 +0200, Colin Leroy <co...@colino.net>
wrote:
> > Thanks! Applied. I took the liberty to remove the
> > pa_modargs_get_value() from raop-sink.c, because it wasn't necessary
> > there.
>
> Yay! Thank you for your guidance :)
Do you
On Thu, 21 Sep 2017 16:54:14 +0300, Tanu Kaskinen wrote:
Hi,
>Thanks! Applied. I took the liberty to remove the
>pa_modargs_get_value() from raop-sink.c, because it wasn't necessary
>there.
Yay! Thank you for your guidance :)
--
Colin
t as I didn't need a temporary variable
in fact.
> If the argument is set, but parsing it fails, you should log an error
> message and fail. (Somehow it didn't occur to me to complain about
> this earlier.)
Thanks, done.
--
Colin
From 6712ac7078659626516bf6f56fdfb64a35d8fcf5 Mon Sep 17 00:00:00
ds) set the parameter to 0 if
it's not present, returning -1 only in case of integer conversion error.
> Nitpicking: the convention is to use the PA_USEC_PER_MSEC constant
> instead of bare "1000".
Fixed too :)
I attached an updated patch.
--
Colin
From ed8d46e28280dbb435d6c1f5a854e532b
001
From: Colin Leroy <co...@colino.net>
Date: Sat, 22 Jul 2017 14:50:40 +0200
Subject: [PATCH] RAOP: Announce real latency
Use predefined values depending on the server, and make it configurable.
AirPlay is supposed to have 2s of latency. With my hardware, this is
more 2.352 seconds after
which I now consider to work
well and would like to submit for inclusion (after addressing the
team's remarks of course).
Thanks again to both of you for your help :)
--
Colin
From e9ac9ae71f9ef134f69757bbe481983374c08b04 Mon Sep 17 00:00:00 2001
From: Colin Leroy <co...@colino.net>
Date: Sat,
On 09 September 2017 at 20h16, Tanu Kaskinen wrote:
Hi,
> Well I definitely wrote things, but Evolution did act strange while
> composing the message, and my "sent" folder confirms your
> observation... I supposed I'll have to write it all again :(
Oh damn :( Bugs with user data loss suck.
On 09 September 2017 at 18h07, Colin Leroy wrote:
Hi,
> I don't understand why, and if you have some pointers on how pa_rtpoll
> and pa_smoother work, I guess that'd help.
So, instead of understanding what's wrong after a pause, for now I use
this instead.
--
Coli
On 09 September 2017 at 18h00, Tanu Kaskinen wrote:
Hi Tanu,
Your mail's empty :)
Anyway, after this patch, there still is a bug left (which was not
visible with the previous patch where I did
if (latency < 0) {
latency = 0;
}
in sink_get_latency().
The bug is that latency's all wrong
.
Advice is welcome :)
--
Colin
From 84aff2424129a18b14d96b6fc4645428ea2739e0 Mon Sep 17 00:00:00 2001
From: Colin Leroy <co...@colino.net>
Date: Sat, 22 Jul 2017 14:50:40 +0200
Subject: [PATCH 1/2] RAOP: Announce real latency
Use predefined values depending on the server, and make it config
On 07 September 2017 at 14h54, Tanu Kaskinen wrote:
Hi,
> A parameter for the latency constant would be nice indeed.
There's also an header, Audio-Latency, in Airplay protocol, which is
not documented in the unofficial doc.
Some servers send 2205, mine sends 4096, it seems (from the internet)
On 06 September 2017 at 14h59, Tanu Kaskinen wrote:
Hi Tanu,
> > + latency += 200; /* RAOP default latency */
> > + latency += pa_raop_client_get_rtp_diff(u->raop) * 1000; /*
> > plus last packet length in usec */
>
> pa_raop_client_get_rtp_diff() returns the size of the last audio
On 06 September 2017 at 08h35, Alexander E. Patrakov wrote:
Hi,
> That's with the default settings. Please read about the
> --video-sync=... option of mpv.
All methods work great, apart 'desync' of course where the sound and
the video are out of sync, but audio still plays.
--
Colin
On Wed, 6 Sep 2017 08:35:37 +0500, "Alexander E. Patrakov"
wrote:
Hi,
>> Basically it seems only VLC tries to sync audio to video instead of
>> the contrary :)
>
>That's with the default settings. Please read about the
>--video-sync=... option of mpv.
Oh, I wasn't aware
On 05 September 2017 at 16h50, Tanu Kaskinen wrote:
Hi,
> Sorry for not responding earlier. I intended to reply to this mail,
> but I accidentally marked it as read and forgot about it.
>
> It's VLC's problem if it can't handle big latencies. VLC will be quite
> useless anyway regardless of
On Wed, 30 Aug 2017 18:30:25 +0300, Tanu Kaskinen wrote:
Hi,
>Thanks! I applied the patch to the "next" branch with some
>modifications: even though the pa_error_code_t type exists, errors are
>still reported as unsigned ints. I also added some more explanation to
>the commit
On 27 August 2017 at 19h07, Colin Leroy wrote:
Hi,
> > The solution seems good to me. Just a couple of minor issues:
>
> Here's a patch addressing your remarks. I squashed the two commits in
> one for clarity.
He, sorry, I changed the return code of two pa__init() funct
17 00:00:00 2001
From: Colin Leroy <co...@colino.net>
Date: Sat, 26 Aug 2017 11:21:15 +0200
Subject: [PATCH] CLI: Don't exit on "module already loaded" errors.
Some modules may only be loaded once, and trying to load them
twice currently aborts PulseAudio.
This patch adds a way to d
On 27 August 2017 at 12h56, Tanu Kaskinen wrote:
Hi Tanu,
Thank you for your review :)
> We don't have a whole lot of functions that need to both allocate a
> new object and report the reason on failure, but there is some
> precedent. At least pa_sink_input_new() and pa_source_output_new()
>
t
would be worth it to mention this problem to you, gather your input
on the subject and come up with an idea to handle it.
Thanks,
--
Colin
From 7e82e6e4367238b211c932c5baf98a69a268 Mon Sep 17 00:00:00 2001
From: Colin Leroy <co...@colino.net>
Date: Sat, 26 Aug 2017 11:21:15 +0
On 05 August 2017 at 10h24, Colin Leroy wrote:
Hi,
> > I think I've figured out how to cleanly synchronise audio and video
> > with RAOP with relying on my empirical "shifting audio 2300ms in
> > mplayer works".
>
> Hmmm, weirdly enough, that patch breaks V
On 22 July 2017 at 14h53, Colin Leroy wrote:
Hi,
> I think I've figured out how to cleanly synchronise audio and video
> with RAOP with relying on my empirical "shifting audio 2300ms in
> mplayer works".
Hmmm, weirdly enough, that patch breaks VLC as I've just discovered
On 25 July 2017 at 22h49, Hajime Fujita wrote:
Hi Hajime,
> I haven’t had a chance to actually test the patch, but just skimmed
> it. The idea seems reasonable. Will try to see if I can test it this
> weekend.
Have you been able to test ? :)
--
Colin
pgp2sxBRY5JCD.pgp
Description: OpenPGP
On 22 July 2017 at 14h53, Colin Leroy wrote:
Hi,
> I think I've figured out how to cleanly synchronise audio and video
> with RAOP with relying on my empirical "shifting audio 2300ms in
> mplayer works".
*without*relying on, obviously :)
--
Colin
pgpXjMhc_qoTC.pgp
D
On Fri, 13 Jan 2017 04:00:11 +, Toby Haynes
wrote:
> So glad to hear this is landing in the main branch, having run
> Hajime's code for at least a couple of years.
>
> Thanks to everyone involved in getting this landed.
Oh that's great ! I'll be happy to see it shipped
On Thu, 5 Jan 2017 22:34:29 +0100, Anton Lundin
wrote:
> I've tested and glanced at the raop-code and it ain't perfect but its
> way better than the current code for anything modern, so I'd suggest
> merging this.
Yay :) That's good news !
--
Colin
On 24 October 2016 at 20h58, Tanu Kaskinen wrote:
Hi,
> It would be great to have more people reviewing patches, but I don't
> know how to acquire those people. I don't think the reviews have to
> necessarily be done by someone with a title of "maintainer", but on
> the other hand, giving much
Hello everybody, Hajime,
> I truly understand that there's a huge shortage in manpower to review
> the patches, and that raop is not a high priority thing in the
> project.
Thanks a lot, again, for your persistence with this patchset :) I still
use it daily and with no adverse effect rebased
On 12 November 2014 at 21h17, Martin Blanchard wrote:
Hi,
RAOP has a ~2sec latency by design. Anyway, the current pulseaudio
sink does not correctly report this latency. This results in
synchronization problem between player (mpv here) and output stream.
This is a known issue; mpv is not to
On Mon, 10 Nov 2014 15:32:15 +0530, Arun Raghavan a...@accosted.net
wrote:
I'd like to freeze master for 6.0 in a couple of days (tentatively
morning of Nov 13th). If you have any patches pending that you'd like
included for the next release, please scream and shout now.
RAOP2!! That would be
[re-sending to the list]
On 28 September 2014 at 13h47, Tanu Kaskinen wrote:
Hi,
Subject: [PATCH] raop: Remove unimplemented code (PCM and AAC)
Thanks, applied pushed to my branch.
Note that the patch review status page[1] refers to a fixed set of
commits to make it clear
On Thu, 25 Sep 2014 17:25:58 +0200, Martin Blanchard tch...@gmx.com
wrote:
Hi Martin,
Subject: [PATCH] raop: Remove unimplemented code (PCM and AAC)
Thanks, applied pushed to my branch.
--
Colin
signature.asc
Description: PGP signature
___
On Thu, 18 Sep 2014 14:28:12 +0530, Arun Raghavan a...@accosted.net
wrote:
Hi,
So what's needed to start looking at pushing this upstream? I don't
have any ROAP devices to test with, but can try to help with reviews
(and maybe hunt for something that can do ROAP ... XBMC?).
I just have to
On Thu, 18 Sep 2014 11:10:30 +0200, Colin Leroy co...@colino.net
wrote:
So what's needed to start looking at pushing this upstream? I don't
have any ROAP devices to test with, but can try to help with reviews
(and maybe hunt for something that can do ROAP ... XBMC?).
I just have
On Thu, 18 Sep 2014 16:43:05 +0530, Arun Raghavan a...@accosted.net
wrote:
On 18 Sep 2014 15:35, Colin Leroy co...@colino.net wrote:
On Thu, 18 Sep 2014 11:10:30 +0200, Colin Leroy co...@colino.net
wrote:
So what's needed to start looking at pushing this upstream? I
don't have
On Thu, 18 Sep 2014 19:17:53 +0600, Alexander E. Patrakov
patra...@gmail.com wrote:
I had a look at the diff between the master and the end result. Too
much whitespace changes and other non-functional changes (e.g. I
don't understand why the definition of struct userdata has to be
moved up in
On Thu, 18 Sep 2014 19:37:49 +0600, Alexander E. Patrakov
patra...@gmail.com wrote:
Well, if you prefer to have them, then OK, let's have them (and only
them) at the beginning and only functional changes at the end. If
some patch adds badly-formatted code only to be fixed up later,
please
On Thu, 18 Sep 2014 19:52:15 +0600, Alexander E. Patrakov
patra...@gmail.com wrote:
That would be perfect.
[...]
Then git rebase -i master is your friend.
Thanks, that helped :)
Here's the updated result :
https://github.com/colinleroy/pulseaudio/compare/raop2-v2
HTH,
--
Colin
and Tanu asking for some news about this code makes me feel that
there is still some interest in the RAOP backend. I still got some
time to spend on this, and of course you're more than welcome if
you want to help !
Martin
On Mon, 2014-09-15 at 11:08 +0200, Colin Leroy wrote:
Hello
From 19e99a550cda012d2c1654a246c0381c0db8b9fc Mon Sep 17 00:00:00 2001
From: Colin Leroy co...@colino.net
Date: Tue, 16 Sep 2014 18:42:16 +0200
Subject: [PATCH] raop: Fix sink getting destroyed after one use
It is expected to get disconnected after switching back to a
different sink.
---
src/modules
On 16 September 2014 at 18h53, Colin Leroy wrote:
Hi,
Done. Please let me know if you have difficulties rebasing this on
top of 5.0.
I've rebased everything to my branch, it seems to work fine for me.
Almost fine - the client's seq number, being uint16_t, wraps around
0x in less
68 matches
Mail list logo