Re: [pulseaudio-discuss] [RAOP] [PATCH] Fix audio synchronisation

2017-09-07 Thread Colin Leroy
On 07 September 2017 at 14h54, Tanu Kaskinen wrote: Hi, > A parameter for the latency constant would be nice indeed. There's also an header, Audio-Latency, in Airplay protocol, which is not documented in the unofficial doc. Some servers send 2205, mine sends 4096, it seems (from the internet)

Re: [pulseaudio-discuss] [RAOP] [PATCH] Fix audio synchronisation

2017-09-07 Thread Tanu Kaskinen
On Wed, 2017-09-06 at 19:17 +0200, Colin Leroy wrote: > On 06 September 2017 at 14h59, Tanu Kaskinen wrote: > > Hi Tanu, > > > > +    latency += 200; /* RAOP default latency */ > > > +    latency += pa_raop_client_get_rtp_diff(u->raop) * 1000; /* > > > plus last packet length in usec */ >

Re: [pulseaudio-discuss] [RAOP] [PATCH] Fix audio synchronisation

2017-09-06 Thread Colin Leroy
On 06 September 2017 at 14h59, Tanu Kaskinen wrote: Hi Tanu, > > +    latency += 200; /* RAOP default latency */ > > +    latency += pa_raop_client_get_rtp_diff(u->raop) * 1000; /* > > plus last packet length in usec */ > > pa_raop_client_get_rtp_diff() returns the size of the last audio

Re: [pulseaudio-discuss] [RAOP] [PATCH] Fix audio synchronisation

2017-09-06 Thread Colin Leroy
On 06 September 2017 at 08h35, Alexander E. Patrakov wrote: Hi, > That's with the default settings. Please read about the > --video-sync=... option of mpv. All methods work great, apart 'desync' of course where the sound and the video are out of sync, but audio still plays. -- Colin pgpXfO4

Re: [pulseaudio-discuss] [RAOP] [PATCH] Fix audio synchronisation

2017-09-06 Thread Tanu Kaskinen
On Tue, 2017-09-05 at 21:16 +0200, Colin Leroy wrote: > On 05 September 2017 at 16h50, Tanu Kaskinen wrote: > > Hi, > > > Sorry for not responding earlier. I intended to reply to this mail, > > but I accidentally marked it as read and forgot about it. > > > > It's VLC's problem if it can't hand

Re: [pulseaudio-discuss] [RAOP] [PATCH] Fix audio synchronisation

2017-09-06 Thread Tanu Kaskinen
On Sat, 2017-07-22 at 14:53 +0200, Colin Leroy wrote: > diff --git a/src/modules/raop/raop-sink.c b/src/modules/raop/raop-sink.c > index e5d219e..108f855 100644 > --- a/src/modules/raop/raop-sink.c > +++ b/src/modules/raop/raop-sink.c > @@ -118,6 +118,13 @@ static int64_t sink_get_latency(const str

Re: [pulseaudio-discuss] [RAOP] [PATCH] Fix audio synchronisation

2017-09-05 Thread Colin Leroy
On Wed, 6 Sep 2017 08:35:37 +0500, "Alexander E. Patrakov" wrote: Hi, >> Basically it seems only VLC tries to sync audio to video instead of >> the contrary :) > >That's with the default settings. Please read about the >--video-sync=... option of mpv. Oh, I wasn't aware of this option. I'll t

Re: [pulseaudio-discuss] [RAOP] [PATCH] Fix audio synchronisation

2017-09-05 Thread Alexander E. Patrakov
On 09/06/2017 12:16 AM, Colin Leroy wrote: - Audacity works - mPlayer and mpv work - Parole works - Totem works - Rhythmbox works Basically it seems only VLC tries to sync audio to video instead of the contrary :) That's with the default settings. Please read about the --video-sync=... option

Re: [pulseaudio-discuss] [RAOP] [PATCH] Fix audio synchronisation

2017-09-05 Thread Colin Leroy
On 05 September 2017 at 16h50, Tanu Kaskinen wrote: Hi, > Sorry for not responding earlier. I intended to reply to this mail, > but I accidentally marked it as read and forgot about it. > > It's VLC's problem if it can't handle big latencies. VLC will be quite > useless anyway regardless of wha

Re: [pulseaudio-discuss] [RAOP] [PATCH] Fix audio synchronisation

2017-09-05 Thread Tanu Kaskinen
On Sat, 2017-08-12 at 09:47 +0200, Colin Leroy wrote: > On 05 August 2017 at 10h24, Colin Leroy wrote: > > Hi, > > > > I think I've figured out how to cleanly synchronise audio and video > > > with RAOP with relying on my empirical "shifting audio 2300ms in > > > mplayer works". > > > > Hmmm,

Re: [pulseaudio-discuss] [RAOP] [PATCH] Fix audio synchronisation

2017-08-12 Thread Colin Leroy
On 05 August 2017 at 10h24, Colin Leroy wrote: Hi, > > I think I've figured out how to cleanly synchronise audio and video > > with RAOP with relying on my empirical "shifting audio 2300ms in > > mplayer works". > > Hmmm, weirdly enough, that patch breaks VLC as I've just discovered, After i

Re: [pulseaudio-discuss] [RAOP] [PATCH] Fix audio synchronisation

2017-08-05 Thread Colin Leroy
On 22 July 2017 at 14h53, Colin Leroy wrote: Hi, > I think I've figured out how to cleanly synchronise audio and video > with RAOP with relying on my empirical "shifting audio 2300ms in > mplayer works". Hmmm, weirdly enough, that patch breaks VLC as I've just discovered, with PA logs full of t

Re: [pulseaudio-discuss] [RAOP] [PATCH] Fix audio synchronisation

2017-08-03 Thread Colin Leroy
On 25 July 2017 at 22h49, Hajime Fujita wrote: Hi Hajime, > I haven’t had a chance to actually test the patch, but just skimmed > it. The idea seems reasonable. Will try to see if I can test it this > weekend. Have you been able to test ? :) -- Colin pgp2sxBRY5JCD.pgp Description: OpenPGP d

Re: [pulseaudio-discuss] [RAOP] [PATCH] Fix audio synchronisation

2017-07-25 Thread Colin Leroy
Hi Hajime, I suppose, yes. I didn't work on that part but that's what makes sense to me. Le 26 juillet 2017 05:49:18 GMT+02:00, Hajime Fujita a écrit : >Hi Colin, > >Thank you for working on this! > >I haven’t had a chance to actually test the patch, but just skimmed it. >The idea seems reaso

Re: [pulseaudio-discuss] [RAOP] [PATCH] Fix audio synchronisation

2017-07-25 Thread Hajime Fujita
Hi Colin, Thank you for working on this! I haven’t had a chance to actually test the patch, but just skimmed it. The idea seems reasonable. Will try to see if I can test it this weekend. > -c->rtptime += length / 4; > +c->rtpdiff = length / 4; > +c->rtptime += c->rtpdiff; Could you

Re: [pulseaudio-discuss] [RAOP] [PATCH] Fix audio synchronisation

2017-07-22 Thread Colin Leroy
On 22 July 2017 at 14h53, Colin Leroy wrote: Hi, > I think I've figured out how to cleanly synchronise audio and video > with RAOP with relying on my empirical "shifting audio 2300ms in > mplayer works". *without*relying on, obviously :) -- Colin pgpXjMhc_qoTC.pgp Description: OpenPGP digit