Re: [pve-devel] [PATCH] increase zfs default timeout to 30sec

2018-04-12 Thread Dominik Csapak
On 04/12/2018 02:13 PM, Fabian Grünbichler wrote: On Thu, Apr 12, 2018 at 02:59:22PM +0300, Lauri Tirkkonen wrote: On Thu, Apr 12 2018 12:59:13 +0200, Fabian Grünbichler wrote: On Tue, Apr 10, 2018 at 05:40:50PM +0300, Lauri Tirkkonen wrote: Hi, On Tue, Mar 13 2018 10:25:47 +0100, Thomas Lamp

Re: [pve-devel] [PATCH] increase zfs default timeout to 30sec

2018-04-12 Thread Fabian Grünbichler
On Thu, Apr 12, 2018 at 02:59:22PM +0300, Lauri Tirkkonen wrote: > On Thu, Apr 12 2018 12:59:13 +0200, Fabian Grünbichler wrote: > > On Tue, Apr 10, 2018 at 05:40:50PM +0300, Lauri Tirkkonen wrote: > > > Hi, > > > > > > On Tue, Mar 13 2018 10:25:47 +0100, Thomas Lamprecht wrote: > > > > What Fabia

Re: [pve-devel] [PATCH] increase zfs default timeout to 30sec

2018-04-12 Thread Lauri Tirkkonen
On Thu, Apr 12 2018 12:59:13 +0200, Fabian Grünbichler wrote: > On Tue, Apr 10, 2018 at 05:40:50PM +0300, Lauri Tirkkonen wrote: > > Hi, > > > > On Tue, Mar 13 2018 10:25:47 +0100, Thomas Lamprecht wrote: > > > What Fabian meant with: > > > > [...] our API has a timeout per request, [...] > > > >

Re: [pve-devel] [PATCH] increase zfs default timeout to 30sec

2018-04-12 Thread Fabian Grünbichler
On Tue, Apr 10, 2018 at 05:40:50PM +0300, Lauri Tirkkonen wrote: > Hi, > > On Tue, Mar 13 2018 10:25:47 +0100, Thomas Lamprecht wrote: > > What Fabian meant with: > > > [...] our API has a timeout per request, [...] > > > > is that our API already has 30 seconds as timeout for response, > > so us

Re: [pve-devel] [PATCH] increase zfs default timeout to 30sec

2018-04-10 Thread Lauri Tirkkonen
Hi, On Tue, Mar 13 2018 10:25:47 +0100, Thomas Lamprecht wrote: > What Fabian meant with: > > [...] our API has a timeout per request, [...] > > is that our API already has 30 seconds as timeout for response, > so using 30 seconds here can be problematic. > > As a quick easy improvement we could

Re: [pve-devel] [PATCH] increase zfs default timeout to 30sec

2018-03-14 Thread Fabian Grünbichler
On Tue, Mar 13, 2018 at 04:28:17PM +0200, Lauri Tirkkonen wrote: > On Tue, Mar 13 2018 16:12:27 +0200, Lauri Tirkkonen wrote: > > On Tue, Mar 13 2018 16:06:12 +0200, Lauri Tirkkonen wrote: > > > Hi, > > > > > > On Tue, Mar 13 2018 09:45:18 +0100, Fabian Grünbichler wrote: > > > > if you haven't al

Re: [pve-devel] [PATCH] increase zfs default timeout to 30sec

2018-03-13 Thread Thomas Lamprecht
On 03/13/2018 09:53 AM, Lauri Tirkkonen wrote: > On Tue, Mar 13 2018 09:45:18 +0100, Fabian Grünbichler wrote: >> On Mon, Mar 12, 2018 at 04:06:47PM +0200, Lauri Tirkkonen wrote: >>> busy pools can easily take more than 5 seconds for eg. zfs create >>> --- >>> PVE/Storage/ZFSPoolPlugin.pm | 2 +- >

Re: [pve-devel] [PATCH] increase zfs default timeout to 30sec

2018-03-13 Thread Lauri Tirkkonen
On Tue, Mar 13 2018 09:45:18 +0100, Fabian Grünbichler wrote: > On Mon, Mar 12, 2018 at 04:06:47PM +0200, Lauri Tirkkonen wrote: > > busy pools can easily take more than 5 seconds for eg. zfs create > > --- > > PVE/Storage/ZFSPoolPlugin.pm | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [pve-devel] [PATCH] increase zfs default timeout to 30sec

2018-03-13 Thread Fabian Grünbichler
first off, thanks for the patch! if you haven't already, please send a signed CLA[1] to off...@proxmox.com, and include a "Signed-Off-By" tag in your commits/patches! On Mon, Mar 12, 2018 at 04:06:47PM +0200, Lauri Tirkkonen wrote: > busy pools can easily take more than 5 seconds for eg. zfs

[pve-devel] [PATCH] increase zfs default timeout to 30sec

2018-03-13 Thread Lauri Tirkkonen
busy pools can easily take more than 5 seconds for eg. zfs create --- PVE/Storage/ZFSPoolPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZFSPoolPlugin.pm index e864a58..7ba035f 100644 --- a/PVE/Storage/ZFSPoolPlugin.pm +++ b/