[issue37224] test__xxsubinterpreters fails randomly

2020-01-14 Thread Kyle Stanley
Kyle Stanley added the comment: I just made a rather interesting discovery. Instead of specifically focusing my efforts on the logic with interp_destroy(), I decided to take a closer look at the failing unit test itself. The main test within DestroyTests that's failing is the following:

[issue39327] shutil.rmtree using vagrant synched folder fails

2020-01-14 Thread Peter Liedholm
Peter Liedholm added the comment: Problem is also reported in virtualbox https://www.virtualbox.org/ticket/19004 >From that ticket some more analysis is done; strace reveals that Python has kept an open fd for the directory being removed. -- ___

[issue37224] test__xxsubinterpreters fails randomly

2020-01-14 Thread Kyle Stanley
Kyle Stanley added the comment: > I also just realized that I can run > "test.test__xxsubinterpreters.DestroyTests" by itself with: > ./python -m test test__xxsubinterpreters.DestroyTests -j200 -F -v Oops, the correct syntax is: ./python -m test test__xxsubinterpreters --match DestroyTests

[issue8800] add threading.RWLock

2020-01-14 Thread Éric Larivière
Éric Larivière added the comment: Hi, Sorry to wake up a 10 years old discussion But I think that you might be interested in the following Python package that I created and maintain since few years now: https://pypi.org/project/readerwriterlock/ 1- It implements the three type of

[issue37224] test__xxsubinterpreters fails randomly

2020-01-14 Thread Kyle Stanley
Kyle Stanley added the comment: I also just realized that I can run "test.test__xxsubinterpreters.DestroyTests" by itself with: ./python -m test test__xxsubinterpreters.DestroyTests -j200 -F -v For some reason, I hadn't thought of running that class of tests by itself to isolate the

[issue37224] test__xxsubinterpreters fails randomly

2020-01-14 Thread Kyle Stanley
Kyle Stanley added the comment: Update: I have a bit of good news and not so great news. The good news is that I had some time to work on this again, specifically with isolating the failure in test__xxsubinterpreters.DestroyTests. Locally, I added a few temporary "@unittest.skip()"

[issue25872] multithreading traceback KeyError when modifying file

2020-01-14 Thread Michael Graczyk
Change by Michael Graczyk : -- pull_requests: +17408 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18007 ___ Python tracker ___

[issue39207] concurrent.futures.ProcessPoolExecutor does not properly reap jobs and spawns too many workers

2020-01-14 Thread Kyle Stanley
Kyle Stanley added the comment: > It would certainly be better to start the worker processes on demand. It > probably also requires careful thought about how to detect that more workers > are required. Alright. In that case, I'll do some experimentation when I get the chance and see if I

[issue17005] Add a topological sort algorithm

2020-01-14 Thread Tim Peters
Tim Peters added the comment: Oh, it's fine! Kahn's algorithm is what I meant when I wrote the "bog-standard implementation" before. I don't believe I've ever seen a context in real life where topsort speed made a lick of real difference, so I expect any linear-time (in the sum of the

[issue39335] round Decimal edge case

2020-01-14 Thread Benjamin Peterson
Benjamin Peterson added the comment: On Python 2, round just converts the decimal to a float. So, this is a consequence of: >>> float(Decimal('-123.49')) -123.5 -- nosy: +benjamin.peterson resolution: -> not a bug stage: -> resolved status:

[issue17005] Add a topological sort algorithm

2020-01-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Disregarding the API, what do you think about the approach of https://github.com/python/cpython/pull/11583 for the implementation? Under my benchmarks (check previous comments) it seems to perform very good with regards to memory and time.

[issue17005] Add a topological sort algorithm

2020-01-14 Thread Tim Peters
Tim Peters added the comment: I'll add ts.py, which was a work-in-progress that implements a minor variation of most everything I typed about. If nothing else, its _find_cycle is useful as a non-recursive linear-time cycle finder (recursion is deadly here because recursive depth-first

[issue17005] Add a topological sort algorithm

2020-01-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Fair enough, I will read this carefully again and try to sketch a prototype soon :) -- ___ Python tracker ___

[issue17005] Add a topological sort algorithm

2020-01-14 Thread Tim Peters
Tim Peters added the comment: > I am slightly confused about what .prepare() should do. Why > is this step necessary? To say "I'm done adding edges". Any call to add() after prepare() should raise an exception. Likewise, e.g., any call to get_ready() before prepare() should raise an

[issue17005] Add a topological sort algorithm

2020-01-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Am I seriously suggesting this for Python? Sure. It's fun to advance the > practical state of the art :-) I think this API looks very interesting! I have some questions before start implementing it to play a bit with it: - I am slightly

[issue39338] Data lost randomly from dictionary after creating the dictionary

2020-01-14 Thread Tim Peters
Tim Peters added the comment: No problem! If you are trying to swap the values in two variables `x` and `y`, in most languages that's spelled: temp = x x = y y = temp and that works in Python too. But in Python it's more common to do it with a one-liner: x, y = y, x

[issue38901] [venv] Add a CLI flag to venv to use the pwd basename as the prompt

2020-01-14 Thread Vinay Sajip
Change by Vinay Sajip : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue39336] Immutable module type can't be used as package in custom loader

2020-01-14 Thread Dino Viehland
Dino Viehland added the comment: I think the warning shouldn't be too bad. It looks like ImportWarnings are filtered by default already, and the extra overhead of raising a warning in this case probably is nothing compared to the actual work in loading the module. --

[issue39336] Immutable module type can't be used as package in custom loader

2020-01-14 Thread Dino Viehland
Change by Dino Viehland : -- keywords: +patch pull_requests: +17406 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/18006 ___ Python tracker

[issue39295] usage of bitfields in ctypes structures changed between 3.7.5 and 3.7.6

2020-01-14 Thread Matthew Newville
Matthew Newville added the comment: @eryksun Sorry for the imprecision -- I was mixing what we do on Linux and Windows. A minimum verifiable example for Linux/MacOS would be import ctypes class bitstruct(ctypes.Structure): _fields_ = [('addr', ctypes.c_long),

[issue39305] Merge nntplib._NNTPBase and nntplib.NNTP

2020-01-14 Thread Dong-hee Na
Dong-hee Na added the comment: @lucianamarques Good news, if you submit the patch. Please ping me and @vstinner :) -- ___ Python tracker ___

[issue39338] Data lost randomly from dictionary after creating the dictionary

2020-01-14 Thread Y3Kv Bv
Y3Kv Bv added the comment: I'm a newbie at Python, also obviously not thinking hard enough over Python's mechanics. Shame on me. -- ___ Python tracker ___

[issue39338] Data lost randomly from dictionary after creating the dictionary

2020-01-14 Thread Tim Peters
Change by Tim Peters : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker ___ ___

[issue39338] Data lost randomly from dictionary after creating the dictionary

2020-01-14 Thread Tim Peters
Tim Peters added the comment: What, exactly, in the output shows "the problem"? When I run it, the `a == b` part is always True, while `len(x)` and `len(crazyQuilt2)` are always 30. The other three (len(coordinates), len(x2), len(x3)) are always equal to each other, but are monotonically

[issue34922] hashlib segmentation fault

2020-01-14 Thread Ned Deily
Ned Deily added the comment: Since there has been no further discussion on this since the fixes were pushed over a year ago, I am declaring this issue resolved. Thanks for everyone's help! -- assignee: ned.deily -> resolution: -> fixed stage: patch review -> resolved status: open

[issue39338] Data lost randomly from dictionary after creating the dictionary

2020-01-14 Thread Zachary Ware
Zachary Ware added the comment: I suspect your `useAmp` branch is not doing what you think it's doing: it's effectively replacing a random number of entries in your `crazyQuilt2` list with a duplicate entry (try `print`ing the list every time around the main loop to see what's happening to

[issue39338] Data lost randomly from dictionary after creating the dictionary

2020-01-14 Thread Y3Kv Bv
New submission from Y3Kv Bv : Windows 7 x64, Python 3.8.1 I've encountered a very weird issue where after creating a dictionary from a list the dictionary ends up being shorter/data is lost from it. It's absolutely random when it loses, how many and which items are lost. I've attached the

[issue39336] Immutable module type can't be used as package in custom loader

2020-01-14 Thread Brett Cannon
Brett Cannon added the comment: So I think this is way too marginal a use-case to expand the API to let loaders inject themselves into the semantics of it. I assume going with option 1 but raising an ImportWarning would be too noisy for your use-case? If not I'm totally fine with that

[issue38901] [venv] Add a CLI flag to venv to use the pwd basename as the prompt

2020-01-14 Thread Brett Cannon
Brett Cannon added the comment: Can this now be closed, Vinay? -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue37751] In codecs, function 'normalizestring' should convert both spaces and hyphens to underscores.

2020-01-14 Thread STINNER Victor
STINNER Victor added the comment: I created bpo-39337: codecs.lookup() ignores non-ASCII characters, whereas encodings.normalize_encoding() copies them. -- ___ Python tracker

[issue39337] codecs.lookup() ignores non-ASCII characters, whereas encodings.normalize_encoding() copies them

2020-01-14 Thread STINNER Victor
New submission from STINNER Victor : bpo-37751 changed codecs.lookup() in a subtle way: non-ASCII characters are now ignored, whereas they were copied unmodified previously. I would prefer that codecs.lookup() and encodings.normalize_encoding() behave the same. Either always ignore or always

[issue39329] smtplib.LMTP needs timeout parameter

2020-01-14 Thread STINNER Victor
STINNER Victor added the comment: PR merged, thanks. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue39329] smtplib.LMTP needs timeout parameter

2020-01-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset 65a5ce247f177c4c52cfd104d9df0c2f3b1c91f0 by Victor Stinner (Dong-hee Na) in branch 'master': bpo-39329: Add timeout parameter for smtplib.LMTP constructor (GH-17998)

[issue39336] Immutable module type can't be used as package in custom loader

2020-01-14 Thread Dino Viehland
Change by Dino Viehland : -- nosy: +brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39336] Immutable module type can't be used as package in custom loader

2020-01-14 Thread Dino Viehland
New submission from Dino Viehland : I'm trying to create a custom module type for a custom loader where the returned modules are immutable. But I'm running into an issue where the immutable module type can't be used as a module for a package. That's because the import machinery calls

[issue39335] round Decimal edge case

2020-01-14 Thread Hrvoje Abraham
New submission from Hrvoje Abraham : >>> from decimal import Decimal >>> round(Decimal('-123.49')) -124.0 I would expect -123.0, even considering Py2 rounding convention details (away from zero), Decimal rounding convention (default

[issue39295] usage of bitfields in ctypes structures changed between 3.7.5 and 3.7.6

2020-01-14 Thread Eryk Sun
Eryk Sun added the comment: > With Python 3.7.6 this raises an exception at the ctypes.CFUNCTYPE() > call with > ... > TypeError: item 1 in _argtypes_ passes a struct/union with a bitfield > by value, which is unsupported. I cannot reproduce the problem as stated in 3.7.6 in Windows. The

[issue39333] argparse should offer an alternative to SystemExit in case a parse fails

2020-01-14 Thread Jack Orenstein
Jack Orenstein added the comment: Yes! I didn't know about that method, thank you. -- stage: -> resolved status: open -> closed ___ Python tracker ___

[issue39334] python specific index directives in our doc has been deprecated 10 years ago

2020-01-14 Thread Julien Palard
Change by Julien Palard : -- keywords: +patch pull_requests: +17405 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18004 ___ Python tracker ___

[issue39334] python specific index directives in our doc has been deprecated 10 years ago

2020-01-14 Thread Julien Palard
New submission from Julien Palard : see: https://github.com/sphinx-doc/sphinx/pull/6970 -- assignee: mdk components: Documentation messages: 359996 nosy: mdk priority: normal severity: normal status: open title: python specific index directives in our doc has been deprecated 10 years

[issue39333] argparse should offer an alternative to SystemExit in case a parse fails

2020-01-14 Thread Eric V. Smith
Eric V. Smith added the comment: Maybe argparse could raise an exception derived from SystemExit, then you could catch that. -- nosy: +eric.smith ___ Python tracker ___

[issue39333] argparse should offer an alternative to SystemExit in case a parse fails

2020-01-14 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Does overriding exit help here? https://docs.python.org/3.8/library/argparse.html#argparse.ArgumentParser.exit -- nosy: +paul.j3, xtreak ___ Python tracker

[issue38901] [venv] Add a CLI flag to venv to use the pwd basename as the prompt

2020-01-14 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 7d6378051feeadf45b4ce45b4b406b65df255648 by Vinay Sajip in branch 'master': bpo-38901: Allow setting a venv's prompt to the basename of the current directory. (GH-17946)

[issue39333] argparse should offer an alternative to SystemExit in case a parse fails

2020-01-14 Thread Zachary Ware
Change by Zachary Ware : -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38921] Max Recursion Depth Reached in Logging Library

2020-01-14 Thread Joy
Joy added the comment: This script should produce the following error: Traceback (most recent call last): File "logging_test_script.py", line 70, in testobj.main() File "logging_test_script.py", line 62, in main Logger.main_logger.info('Adding a line into {}'.format(source))

[issue39333] argparse should offer an alternative to SystemExit in case a parse fails

2020-01-14 Thread Jack Orenstein
New submission from Jack Orenstein : If parse_args fails, SystemExit is raised, carrying an exit code of 2, and the help message is printed. For an embedded usage of argparse, this behavior is undesirable. I am writing an interactive console application, using argparse to parse input. When

[issue39206] Modulefinder does not consider source file encoding

2020-01-14 Thread Luciana
Luciana added the comment: Hi there, can somebody who is a core dev please review my PR? Thanks :) -- ___ Python tracker ___ ___

[issue39305] Merge nntplib._NNTPBase and nntplib.NNTP

2020-01-14 Thread Luciana
Luciana added the comment: Hey, I'm taking a look into this! -- nosy: +lucianamarques ___ Python tracker ___ ___ Python-bugs-list

[issue39296] Windows register keys

2020-01-14 Thread Tony
Tony added the comment: Hi Steve, Thank you for this. I know about the working of WOW64 and the redirection to the (HKEY_LOCAL_MACHINE) ..\Wow6432Node, that is explained on md.docs. The HKEY_CURRENT_USER redirection is not well explained, and so it appears I’m not the only one (Google) who

[issue39332] Python 3.6 compiler protections from Ubuntu distros

2020-01-14 Thread Benjamin Peterson
Benjamin Peterson added the comment: You should take it up on the Ubuntu issue tracker. -- nosy: +benjamin.peterson resolution: -> third party stage: -> resolved status: open -> closed ___ Python tracker

[issue39332] Python 3.6 compiler protections from Ubuntu distros

2020-01-14 Thread Jason Culligan
New submission from Jason Culligan : The python3.6 binary supplied in Ubuntu distros is not compiled with Position Independent Code (PIE) protection enabled. Python2 does. Is this not seen as a problem? Example 1: (checksec) FILE: /usr/bin/python2 RELRO: Full RELRO STACK

[issue39312] Expose placeholder reparse points in Windows

2020-01-14 Thread Eryk Sun
Eryk Sun added the comment: Okay, a well-known third-party library will work if a script/application really needs this information. I just wanted to bring it up for consideration because I saw an issue for cross-platform PowerShell 6 [1] where it was decided to disable placeholder

[issue38361] syslog: Default "ident" in syslog.openlog() shouldn't contain slash

2020-01-14 Thread miss-islington
miss-islington added the comment: New changeset f04750bb7af45cb6efab8d92d1ff063f0bf2833d by Miss Islington (bot) (Václav Bartoš) in branch 'master': bpo-38361: syslog: fixed making default "ident" from sys.argv[0] (GH-16557)

[issue39322] Add gc.is_finalized to check if an object has been finalised by the gc

2020-01-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset b6791375b2ff86ea07f068fb53d9575c337eaa5b by Pablo Galindo in branch 'master': bpo-39322: Add gc.is_finalized to the gc module docstring (GH-18000) https://github.com/python/cpython/commit/b6791375b2ff86ea07f068fb53d9575c337eaa5b

[issue39322] Add gc.is_finalized to check if an object has been finalised by the gc

2020-01-14 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +17404 pull_request: https://github.com/python/cpython/pull/18000 ___ Python tracker ___

[issue39312] Expose placeholder reparse points in Windows

2020-01-14 Thread Steve Dower
Steve Dower added the comment: Given the minimum version requirement, I'd rather this support go into a third-party library. (Seems like a great candidate for a context manager, too.) Recalling our debates about symlinks, I'd have to say that nothing about placeholder files qualifies them

[issue39318] NamedTemporaryFile could cause double-close on an fd if _TemporaryFileWrapper throws

2020-01-14 Thread Eryk Sun
Eryk Sun added the comment: > I afraid that removing a file while the file descriptor is open > may not work on Windows. Seems this case is not well tested. os.remove will succeed on a file that's opened with O_TEMPORARY, which shares delete access (i.e. FILE_SHARE_DELETE). With classic

[issue39330] Way to build without IDLE

2020-01-14 Thread Reece Dunham
Reece Dunham added the comment: Okay, closing it then. Thanks for the info. -- stage: -> resolved status: pending -> closed ___ Python tracker ___

[issue39330] Way to build without IDLE

2020-01-14 Thread Zachary Ware
Zachary Ware added the comment: I'm not sure what you mean here. IDLE is a pure-Python application, though it does depend on the optional tkinter package. If you're on a UNIX platform and Tcl/Tk headers and libraries can't be found, _tkinter won't be built and you won't be able to run

[issue39331] 2to3 mishandles indented imports

2020-01-14 Thread Guy Galun
New submission from Guy Galun : When encountering an import that should be removed in Python 3 (e.g. "from itertools import izip"), 2to3 changes it a blank line, which may cause a runtime error if that import was indented: error: module importing failed: expected an indented block

[issue39330] Way to build without IDLE

2020-01-14 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +taleinat, terry.reedy ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue38530] Offer suggestions on AttributeError

2020-01-14 Thread STINNER Victor
STINNER Victor added the comment: Related issue: PEP 534 -- Improved Errors for Missing Standard Library Modules https://www.python.org/dev/peps/pep-0534/ -- ___ Python tracker

[issue39330] Way to build without IDLE

2020-01-14 Thread Reece Dunham
New submission from Reece Dunham : It would just be better in my opinion if there was a way to build without IDLE, for people that are building from source and don't want it. This doesn't have to be implemented, it is just something I think would make the build system a bit better.

[issue39329] smtplib.LMTP needs timeout parameter

2020-01-14 Thread Dong-hee Na
Change by Dong-hee Na : -- pull_requests: +17403 pull_request: https://github.com/python/cpython/pull/17999 ___ Python tracker ___

[issue39329] smtplib.LMTP needs timeout parameter

2020-01-14 Thread Dong-hee Na
Change by Dong-hee Na : -- keywords: +patch pull_requests: +17402 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17998 ___ Python tracker ___

[issue39329] smtplib.LMTP needs timeout parameter

2020-01-14 Thread Dong-hee Na
New submission from Dong-hee Na : see: https://github.com/python/cpython/pull/17958#issuecomment-573390867 I've noticed that LMTP does not support the timeout parameter. See: https://docs.python.org/3.9/library/smtplib.html#smtplib.LMTP However, LMTP also able to use the socket which is

[issue37751] In codecs, function 'normalizestring' should convert both spaces and hyphens to underscores.

2020-01-14 Thread STINNER Victor
STINNER Victor added the comment: > Please note that external codec packages should not rely on the semantics of > the Python stdlib encodings package's search function. latexcodec does register a search function. > It's good practice to always only use ASCII lower case chars and the >

[issue37751] In codecs, function 'normalizestring' should convert both spaces and hyphens to underscores.

2020-01-14 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Just to clarify: the change in the C implementation was the breaking change. The patch just restores the previous behavior: https://github.com/python/cpython/blob/master/Lib/encodings/__init__.py#L43 Please note that external codec packages should not

[issue37751] In codecs, function 'normalizestring' should convert both spaces and hyphens to underscores.

2020-01-14 Thread STINNER Victor
STINNER Victor added the comment: It seems quite easy to update latexcodec project to support Python 3.9. I proposed a solution there: https://bugzilla.redhat.com/show_bug.cgi?id=1789613#c6 -- ___ Python tracker

[issue37751] In codecs, function 'normalizestring' should convert both spaces and hyphens to underscores.

2020-01-14 Thread STINNER Victor
STINNER Victor added the comment: > The change is backwards incompatible and a backport would break things. See > for example how it breaks latexcodec: I reopen the issue. I proposed PR 17997 to *document* the incompatible change in What's New in Python 3.8. IMO it's a deliberate change and

[issue37751] In codecs, function 'normalizestring' should convert both spaces and hyphens to underscores.

2020-01-14 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +17401 pull_request: https://github.com/python/cpython/pull/17997 ___ Python tracker ___

[issue37751] In codecs, function 'normalizestring' should convert both spaces and hyphens to underscores.

2020-01-14 Thread Miro Hrončok
Miro Hrončok added the comment: The change is backwards incompatible and a backport would break things. See for example how it breaks latexcodec: https://bugzilla.redhat.com/show_bug.cgi?id=1789613#c2 -- nosy: +hroncok ___ Python tracker

[issue39048] Look up __aenter__ before __aexit__ in the async with statement

2020-01-14 Thread Géry
Change by Géry : -- title: Look up __aenter__ before __aexit__ in async with -> Look up __aenter__ before __aexit__ in the async with statement ___ Python tracker ___

[issue39037] Look up __enter__ before __exit__ in the with statement documentation

2020-01-14 Thread Géry
Change by Géry : -- title: Fix the trial order of the __exit__ and __enter__ methods in the with statement documentation -> Look up __enter__ before __exit__ in the with statement documentation ___ Python tracker

[issue39048] Look up __aenter__ before __aexit__ in async with

2020-01-14 Thread Géry
Change by Géry : -- title: Change the lookup order of __aenter__ and __aexit__ for async with -> Look up __aenter__ before __aexit__ in async with ___ Python tracker ___

[issue39322] Add gc.is_finalized to check if an object has been finalised by the gc

2020-01-14 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue39259] poplib.POP3/POP3_SSL should reject timeout = 0 (non-blocking mode)

2020-01-14 Thread STINNER Victor
STINNER Victor added the comment: Thanks Dong-hee Na for all these nice changes! -- ___ Python tracker ___ ___ Python-bugs-list

[issue39322] Add gc.is_finalized to check if an object has been finalised by the gc

2020-01-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset a2ec3f07f7f028ff6229d6be2a7cfbda1f4efaeb by Pablo Galindo in branch 'master': bpo-39322: Add gc.is_finalized to check if an object has been finalised by the gc (GH-17989)

[issue39259] poplib.POP3/POP3_SSL should reject timeout = 0 (non-blocking mode)

2020-01-14 Thread STINNER Victor
Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue39048] Change the lookup order of __aenter__ and __aexit__ for async with

2020-01-14 Thread Nick Coghlan
Change by Nick Coghlan : -- resolution: -> fixed stage: -> resolved status: open -> closed type: behavior -> enhancement versions: -Python 3.8 ___ Python tracker ___

[issue39048] Change the lookup order of __aenter__ and __aexit__ for async with

2020-01-14 Thread Nick Coghlan
Nick Coghlan added the comment: New changeset 1d1b97ae643dd8b22d87785ed7bd2599c6c8dc8d by Nick Coghlan (Géry Ogam) in branch 'master': bpo-39048: Look up __aenter__ before __aexit__ in async with (GH-17609) https://github.com/python/cpython/commit/1d1b97ae643dd8b22d87785ed7bd2599c6c8dc8d

[issue39328] Allow filename mismatch in local and central directories in zipfile.py

2020-01-14 Thread Cheryl Sabella
New submission from Cheryl Sabella : This is being opened from the report on GH3035. During malware research I bumped int problem with my Python based file analyzer: miscreants are modifying ZIP file header parts so, that python based automated analysis tools are unable to process the

[issue39033] zipimport raises NameError: name '_boostrap_external' is not defined

2020-01-14 Thread Petr Viktorin
Petr Viktorin added the comment: Thank you, Mihail and Karthikeyan! -- nosy: +petr.viktorin stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue39033] zipimport raises NameError: name '_boostrap_external' is not defined

2020-01-14 Thread miss-islington
miss-islington added the comment: New changeset 9955f33cdbf27de270038dfbad37d15b160ecca2 by Miss Islington (bot) (Karthikeyan Singaravelan) in branch '3.8': [3.8] bpo-39033: Fix NameError in zipimport during hash validation (GH-17588) (GH-17642)

[issue39156] Break up COMPARE_OP into logically distinct operations.

2020-01-14 Thread Mark Shannon
Mark Shannon added the comment: New changeset 9af0e47b1705457bb6b327c197f2ec5737a1d8f6 by Mark Shannon in branch 'master': bpo-39156: Break up COMPARE_OP into four logically distinct opcodes. (GH-17754) https://github.com/python/cpython/commit/9af0e47b1705457bb6b327c197f2ec5737a1d8f6

[issue39156] Break up COMPARE_OP into logically distinct operations.

2020-01-14 Thread Mark Shannon
Change by Mark Shannon : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue39207] concurrent.futures.ProcessPoolExecutor does not properly reap jobs and spawns too many workers

2020-01-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: It would certainly be better to start the worker processes on demand. It probably also requires careful thought about how to detect that more workers are required. -- ___ Python tracker

[issue39327] shutil.rmtree using vagrant synched folder fails

2020-01-14 Thread Peter Liedholm
New submission from Peter Liedholm : Python 3.6.9 Ubuntu 18.04 python3 -c 'import shutil; shutil.rmtree("1a")' Traceback (most recent call last): File "", line 1, in File "/usr/lib/python3.6/shutil.py", line 486, in rmtree _rmtree_safe_fd(fd, path, onerror) File

[issue39207] concurrent.futures.ProcessPoolExecutor does not properly reap jobs and spawns too many workers

2020-01-14 Thread Kyle Stanley
Kyle Stanley added the comment: > I think this should be fixed like ThreadPoolExecutor. Are there are any downsides or complications with changing this behavior for ProcessPoolExecutor to consider, such as what I mentioned above? From my understanding, there would be a performance penalty

[issue39207] concurrent.futures.ProcessPoolExecutor does not properly reap jobs and spawns too many workers

2020-01-14 Thread Inada Naoki
Inada Naoki added the comment: Uh, my understanding "But ProcessPoolExecutor starts worker processes on demand from old." was wrong. I think this should be fixed like ThreadPoolExecutor. -- ___ Python tracker

[issue39318] NamedTemporaryFile could cause double-close on an fd if _TemporaryFileWrapper throws

2020-01-14 Thread Albert Zeyer
Albert Zeyer added the comment: Why is `except BaseException` better than `except Exception` here? With `except Exception`, you will never run into the problem of possibly closing the fd twice. This is the main important thing which we want to fix here. This is more important than missing

[issue39318] NamedTemporaryFile could cause double-close on an fd if _TemporaryFileWrapper throws

2020-01-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Problems: 1. In general, it is hard to avoid leaks because an exception like KeyboardInterrupt or MemoryError can be raised virtually anywhere, even before we save a file descriptor. We may rewrite the code so that it will use few simple bytecode

[issue39295] usage of bitfields in ctypes structures changed between 3.7.5 and 3.7.6

2020-01-14 Thread Vinay Sajip
Vinay Sajip added the comment: The change has now been reverted, including on 3.8 and 3.7, so I think that this issue can be closed. Any naysayers? -- ___ Python tracker ___

[issue36078] argparse: positional with type=int, default=SUPPRESS raise ValueError

2020-01-14 Thread yang
yang added the comment: I ran into the same issue and looked into the code, and found it more complicated than I thought. The more I went on, more issues occur. I wonder if I should open a new issue, but I will first comment here. If you feel like this should be a new issue, I will open one

[issue39259] poplib.POP3/POP3_SSL should reject timeout = 0 (non-blocking mode)

2020-01-14 Thread Dong-hee Na
Dong-hee Na added the comment: > Can we now close this issue? Or is there still something to do? There is no case on xxlib series except LMTP. I am going to open a new issue about LMTP. So let's close this :) -- ___ Python tracker