Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20078
___
___
Python-bugs-list
Changes by Chris Calloway c...@chriscalloway.org:
Removed file: http://bugs.python.org/file30040/issue-15518-1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
Chris Calloway added the comment:
The promised comments have been added to the patch. The refactoring of the
pre-existing tests is not part of this patch. But I'm uploading this now as the
patch does fix the issue.
--
Added file: http://bugs.python.org/file32960/issue-15518-1.patch
Changes by Chris Calloway c...@chriscalloway.org:
Removed file: http://bugs.python.org/file29745/test_filecmp_layouts.rst
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
Chris Calloway added the comment:
Reformat the filecmpdata directory layouts diagram.
--
Added file: http://bugs.python.org/file32961/test_filecmp_layouts.rst
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
Changes by Chris Calloway c...@chriscalloway.org:
Removed file: http://bugs.python.org/file29746/test_filecmp_reports.rst
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
Chris Calloway added the comment:
Reformat the filecmp test report matrix.
--
Added file: http://bugs.python.org/file32962/test_filecmp_reports.rst
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
Chris Calloway added the comment:
Formatted test directory layout.
--
Added file: http://bugs.python.org/file32963/layouts.html
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
Chris Calloway added the comment:
Format the martix of test reports.
--
Added file: http://bugs.python.org/file32964/reports.html
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
Chris added the comment:
I would be interested in tackling this as a first patch, can you give me some
more information?
--
nosy: +chrishood
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19624
Chris added the comment:
I think I'll look for some other issues, this one looks a bit deep for a first
patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19624
New submission from Chris Angelico:
In an interactive session, typing 'import this' a second time doesn't produce
output (as the module's already imported). Peeking into the module shows a
string and what looks like a translation dictionary, but doing the obvious
thing:
this.s.translate
Chris Cooper added the comment:
Here's a patch that focuses on the json module, with a smaller pickle section
including the warning from the pickle docs.
--
nosy: +ChrisCooper
Added file: http://bugs.python.org/file32513/issue18840
___
Python
New submission from Chris Angelico:
IDLE tries to be helpful, but it errors on something that isn't yet an error.
Pasting in this code works fine:
def a():
def b():
nonlocal q
q+=1
q=1
b()
return q
a()
2
But typing it, line
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17359
___
___
Python-bugs-list
New submission from Chris Adams:
If you use detect_types=sqlite3.PARSE_DECLTYPES with sqlite3 and insert a
timezone-aware datetime instance, you will get a ValueError if you attempt to
read it back out:
File
/usr/local/Cellar/python3/3.3.2/Frameworks/Python.framework/Versions/3.3/lib
New submission from Chris Lambacher:
The use case for this is that when you are in a template and you want to use
the Enum instances in a conditional, then you need to pass the Enum class to
the template or start using someenumvariable.__class__.someenumvalue. Instead
it would be useful
Chris Lambacher added the comment:
You are not comparing the same thing. Normally when there is a class parameter,
those are available from instances of the class.
class Test:
...pass
...
Test.this = Test()
Test.that = Test()
Test.this.that
__main__.Test instance at 0x7ff681bd3560
Chris Lambacher added the comment:
For what it's worth, I was confused by the inability to access the class
members from the instance for like 3 or 4 weeks until I realized that the
instances were not actually on the class and the implications of that for class
attribute access
Chris Lambacher added the comment:
My use case is a generic mixin for Enums and a generic mixin for Django ORM
fields that uses the Enums to generate choices.
The Enum mixin has to call cls.__class__._get_mixins_(cls.__bases__) to get the
member_type so that it can call the member_type
New submission from Chris Lambacher:
It would be useful to set the discovered member_type to the Enum class and not
just the instance. Attached is a patch to add _member_type_ to the enum_class.
--
files: enum_member_type_on_class.patch
keywords: patch
messages: 194199
nosy: lambacck
New submission from Chris Curvey:
on http://docs.python.org/2/library/multiprocessing.html, there is a bit about
how to use a Pool properly, which looks like this
pool = Pool(processes=4) # start 4 worker processes
result = pool.apply_async(f, [10])
What this neglects to mention
New submission from Chris Lambacher:
Starting at line 153 in enum.py there is:
153 if not use_args:
154 enum_member = __new__(enum_class)
155 original_value = value
156 else:
157 enum_member = __new__
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18436
___
___
Python-bugs-list
New submission from Chris Lambacher:
When an Enum is being created, the _value2member_map class property is defined
to speed lookup of Enum values later on. If the value does not exist then it
falls back to a linear search through the _member_map.values() looking for
member.value == value
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18264
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18369
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18406
___
___
Python-bugs-list
New submission from Chris Siebenmann:
socket.fromfd() requires you to supply at least the family and type of
the file descriptor that you are turning into a Python socket object.
However the socket module provides no documented way to determine what
these actually are and there are any number
Chris Siebenmann added the comment:
As far as I know, you can recover everything except the protocol
portably on Unix (and fromfd() will already handwave the protocol).
getsockopt() with SO_TYPE will give you the type. The family can be
recovered by calling getsockname() with a plain struct
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18335
___
___
Python-bugs-list
Chris AtLee added the comment:
Thanks, your patch is definitely much simpler!
I was worried about the case where you have interrupted \r\n that appears in
the middle of the content. But that case is handled by the next readline(),
which returns a single \n.
One question about the tests
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18163
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18166
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18162
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18170
___
___
Python-bugs-list
Chris AtLee added the comment:
To demonstrate how to hit this in a real use case, run the attached script
which implements a simple http server that saves POSTed files to a local file
got_data. It returns the sha1sum of the POSTed file as the http response.
Then, create a test file consisting
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10581
___
___
Python-bugs-list
New submission from Chris AtLee:
cgi.FieldStorage uses fp.readline(1 16) to read in POSTed file data if no
content length has been specified. All HTTP clients I've looked at terminate
the file body with CRLF and then the final MIME boundary. If the file body is
65,535 bytes, and doesn't
Chris AtLee added the comment:
This is a possible fix to this issue. It's not as clean as I'd like, but the
simpler versions I tried could end up with the entire file contents in memory
for degenerate (or malicious) inputs.
The trick is handling the case where the current line ends with \r
Changes by Chris Calloway c...@chriscalloway.org:
Removed file: http://bugs.python.org/file29758/issue-15518-1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
Chris Calloway added the comment:
I'm uploading a new patch which gets rid of the temp_cwd calls as suggested in
the review. The patch is not complete in that the explanatory comments
suggested in the review and revising the pre-existing tests have not been
completed yet. However, I want
Changes by Chris Calloway c...@chriscalloway.org:
Removed file: http://bugs.python.org/file29749/issue-15518-1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
Chris Calloway added the comment:
I replaced issue-15518-1.patch. I believe it now addresses all the concerns
expressed thus far. If reviewed favorably, I will extend it to clean-up the
pre-existing tests to address the concerns noted about them, especially since
the filecmpdata directory
Changes by Chris Calloway c...@chriscalloway.org:
Removed file: http://bugs.python.org/file29682/issue-15518-1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
Chris Calloway added the comment:
The attached file test_filecmp_layouts.rst documents the directory and file
layouts for complete test coverage of filecmp.dircmp report methods to aid in
review discussion of patch.
--
Added file: http://bugs.python.org/file29745
Chris Calloway added the comment:
The attached file test_filecmp_reports.rst documents the reports generated by
filecmp.dircmp test methods if the directory and file layouts in
test_filecmp_layouts.rst are followed to aid in review discussion of patch.
--
Added file: http
Chris Calloway added the comment:
The attached patch issue-15518-1.patch replaces previous patch proposals for
this issue.
The patch implements the suggestion to factor code common to report TestCase
classes into a common base class BaseReportTestCase. Apologies for not having
Changes by Chris Calloway c...@chriscalloway.org:
Removed file: http://bugs.python.org/file29747/issue-15518-1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
Chris Calloway added the comment:
Fix calls to BaseReportTestCase methods in subclasses. Not an override so don't
need super().
--
Added file: http://bugs.python.org/file29749/issue-15518-1.patch
___
Python tracker rep...@bugs.python.org
http
Changes by Chris Calloway c...@chriscalloway.org:
Removed file: http://bugs.python.org/file26635/issue-15518-1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
Chris Calloway added the comment:
OK, I got to participate in my Python user group hack night this week where I
actually got to work on my projects instead of spending all night helping
newbies on their projects. I used the time to refactor all the previous patches
for this issue on which I
Changes by Chris Calloway c...@chriscalloway.org:
Removed file: http://bugs.python.org/file29681/issue-15518-1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
Chris Calloway added the comment:
Replaced patch to fix a few under-informative test messages.
--
Added file: http://bugs.python.org/file29682/issue-15518-1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
Changes by Chris Kaynor ckay...@zindagigames.com:
--
nosy: +DragonFireCK
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17263
___
___
Python-bugs
New submission from Chris Angelico:
As of PEP 393, a string's width is recorded in its header - effectively, a
marker that says whether the highest codepoint in the string is 0x, 0xFF,
or =0xFF. This is, on some occasions, useful to know; for instance, when
testing string performance
Chris Angelico added the comment:
And of course, I make a copy/paste error in a trivial piece of example code.
def str_width(s):
width=1
for ch in map(ord,s):
if ch 0x: return 4
if ch 0xFF: width=2
return width
--
___
Python
Chris Angelico added the comment:
CPython also knows the length of a string, which means that len(s) is a fast
operation. I wouldn't expect anyone to rewrite len() as:
def get_string_length(s):
length=0
for ch in s:
length+=1
return length
even though that works. No, we have a built
Changes by Chris Calloway c...@chriscalloway.org:
--
nosy: +cbc
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15351
___
___
Python-bugs-list
Changes by Chris Angelico ros...@gmail.com:
--
nosy: +Rosuav
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17575
___
___
Python-bugs-list mailing
New submission from Chris Angelico:
The timeit module is commonly used via the convenience function timeit.timeit,
which is listed in the documentation as the recommended Python Interface:
http://docs.python.org/3/library/timeit.html
However, this function is not listed in __all__, meaning
Chris Calloway added the comment:
Yes, that's why I opened it. Feel free to submit patches if you think I'm
moving too slowly.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15518
Chris Adams added the comment:
Ezio: given the non-obvious failure, what do you think of at least documenting
this and issuing a warning any time both re.UNICODE and re.IGNORECASE are set?
--
___
Python tracker rep...@bugs.python.org
http
New submission from Chris Tandiono:
Currently, random.sample(population, k) raises a ValueError if k is out of the
range of [0, len(population)], inclusive. However, the message says Sample
larger than population even when the real problem is that k 0. The attached
patch fixes
Changes by Chris Tandiono chris.tandi...@gmail.com:
--
title: Providing invalid value to - Providing invalid value to random.sample
can result in incorrect error message
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17388
Chris Tandiono added the comment:
Hmm. I'm not sure I buy the argument that the new message is less useful
(wouldn't you like to know the exact values that caused the problem? that's
what int() does when you provide it garbage). I guess it could be less
informative, since you have to decide
Chris Adams added the comment:
Ah, that explains it - I'd been hoping based on the re.DEBUG output that the
explicit unicode ranges were preserved.
I found #3511 before opening this one but don't believe the decision should be
the same since this isn't a mixed numeric/alphabetic range
New submission from Chris Adams:
I noticed an interesting failure while using re.match / re.sub to look for
non-Cyrillic characters in allegedly Russian text:
re.sub(r'[\s\u0400-\u0527]+', ' ', 'Архангельская губерния',
flags=re.IGNORECASE)
'Архангельская губерния'
re.sub(r'[\s\u0400
New submission from Chris Jerdonek:
This issue is to improve the organization of the PyPI section of the Distutils
documentation, now that the information has been combined into one page.
A patch is attached.
Improvements include:
(1) Creating a section for command options common to both
Chris Jerdonek added the comment:
The refs output also complicates testing in some cases, e.g.
http://hg.python.org/cpython/file/bc4458493024/Lib/test/test_subprocess.py#l61
http://hg.python.org/cpython/file/bc4458493024/Lib/test/test_subprocess.py#l786
--
nosy: +chris.jerdonek
Chris Jerdonek added the comment:
The file gets created in the current working directory. You won't see it when
using regrtest since regrtest creates and then deletes a temp working directory.
To see it easier, try running instead:
./python.exe -m unittest test.test_posixpath
Chris Jerdonek added the comment:
Similar to as I stated in issue 17315, you won't see it when using regrtest
since regrtest creates and then deletes a temp working directory.
The file gets created and is left behind in the current working directory. Try
running using unittest, e.g
Chris Jerdonek added the comment:
Thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17312
___
___
Python-bugs-list mailing list
Unsubscribe
Chris Jerdonek added the comment:
Thanks, I confirmed the fix.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17315
___
___
Python-bugs-list
Chris Jerdonek added the comment:
The first and/or main place that recommends hg graft should link to the
section with more detail for cases where users experience problems with graft.
I also agree that the section should mention the case-folding error. I'm using
a pretty new version of hg
Chris Jerdonek added the comment:
Extending regrtest to support unittest test discovery directly is also a
worthwhile specific proposal.
Updating the tests to support discovery in all cases is discussed in (meta)
issue 16748. There are also many individual issues in the tracker (one per
Chris Jerdonek added the comment:
Ezio, did you delete the section on null-merging in your commits? I don't see
it in the devguide anymore.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14468
Chris Jerdonek added the comment:
Currently the section covers all the fundamental Mercurial-related operations
that a committers needs to know (set up, commit, merge, push), not just
committing.
The point of the change in section title is to have a title so non-committers
know they can
Chris Jerdonek added the comment:
Why must we mention graft at all? I've never had a need for it. It seems
simpler and just as effective to run `hg import` on the original patch.
I think it's preferable that the steps we recommend to work on all systems.
Then we won't have to worry about
Chris Jerdonek added the comment:
AFAICT, the recommendation to use hg git format is currently only mentioned
in the Committing section
(http://docs.python.org/devguide/committing.html#minimal-configuration) but
not elsewhere, in particular, not http://docs.python.org/devguide/patch.html
Chris Jerdonek added the comment:
I think making the sections more focused helps because sections are the
linkable units, and sections can be freely moved around once they are more
stand-alone (e.g. into or out of the FAQ).
In issue 16931 in response to Ned, I suggested adding a general
Chris Jerdonek added the comment:
If you start with a patch against 3.x, which is the normal case, why go to the
trouble of grafting from the patch modified for 2.7? It seems you're just
creating more trouble for yourself (introducing more conflicts you have to
resolve, etc) when you already
Chris Jerdonek added the comment:
Reapplying the patch means that I have to do import + commit at least, and
possibly reapply manually changes that I've already done on 2.7.
Since 2.7 is more different from 3.2 than is 3.4, it seems more likely that
grafting from 2.7 to 3.x will result
Chris Jerdonek added the comment:
Thanks a lot for the review, Petri.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17283
Chris Jerdonek added the comment:
The fix for issue 17283 has been committed now, which should make this slightly
easier to fix (e.g. change one place instead of two).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15305
Chris Jerdonek added the comment:
Thanks a lot for taking the time to review, guys.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16406
New submission from Chris Jerdonek:
As suggested by Éric in a Rietveld comment to issue 16406, this issue is to
make the PyPI package display section of the distutils docs use the right
terminology:
It’s too bad this part of the documentation use “package” with the meaning
used on PyPI
Chris Jerdonek added the comment:
I created issue 17311 for a suggestion Éric made on Rietveld.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16406
Chris Jerdonek added the comment:
Here is a patch that updates Geoff's patch to the latest code, and addresses
the directory creation issue.
--
Added file: http://bugs.python.org/file29269/issue15305-3.patch
___
Python tracker rep...@bugs.python.org
Changes by Chris Jerdonek chris.jerdo...@gmail.com:
--
stage: - patch review
type: - enhancement
versions: +Python 3.4 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15305
New submission from Chris Jerdonek:
test_aifc's AIFCLowLevelTest.test_write_aiff_by_extension() leaves a test file
behind. I'm not sure what other versions are affected.
--
keywords: easy
messages: 183175
nosy: chris.jerdonek, r.david.murray
priority: normal
severity: normal
stage
Changes by Chris Jerdonek chris.jerdo...@gmail.com:
--
components: +Tests
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17312
___
___
Python-bugs
New submission from Chris Jerdonek:
test_logging leaves behind a file called test.log in the current working
directory. I haven't narrowed down to the specific test, and I'm not sure what
other versions are affected.
--
components: Tests
messages: 183176
nosy: chris.jerdonek
New submission from Chris Jerdonek:
test_posixpath leaves behind a file of the following form when running on Mac
OS X:
lrwxr-xr-x @test_17700_tmpa - @test_17700_tmpa/b
I'm not sure which test it is or which other versions are affected.
--
components: Tests
messages: 183178
nosy
Chris Jerdonek added the comment:
The link for convenience:
http://docs.python.org/dev/distutils/packageindex.html#pypi-package-display
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17311
Chris Jerdonek added the comment:
Thanks for investigating.
Yes, currently regrtest.py deletes the containing directory. But this doesn't
happen when running with plain unittest. If each test cleans up after itself,
this will give us more flexibility in moving from regrtest to a unittest
Chris Jerdonek added the comment:
I still fail to understand what are you trying to achieve.
My goal is to reach consensus on changes and have them committed. In its
current form, I don't agree with the patch. The length of the comment thread
and the length of the patch has discouraged me
Chris Jerdonek added the comment:
For the record, I don't recall *any* changes being made to any of the patches
in response to mine or others' comments, other than dividing them up. So we're
not talking about perfection. If they're going to be committed as is, it might
as well be one patch
Chris Jerdonek added the comment:
But, surely at this point, it would be easier to get meaningful additional
review after the current set of changes are committed rather than continually
redoing a large set of patches.
This was my reason for asking early on that the changes be proposed
New submission from Chris Jerdonek:
As discussed in issue 14468, this issue is to reorder the sections in the
devguide's committing.rst to create a section dedicated to using Mercurial when
committing. The attached patch is adapted from the 2-move_two_sections.diff
patch of that issue
901 - 1000 of 2739 matches
Mail list logo
