Eric Snow added the comment:
Hi Ma Lin! Thanks for the suggestion. We appreciate your interest in making
Python better.
It's unclear from your messages what is motivating your request. You mentioned
middle school students, but that didn't sound like your actual motivator.
Kn
Change by Eric Snow :
--
pull_requests: +11360, 11361
___
Python tracker
<https://bugs.python.org/issue33608>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
pull_requests: +11360, 11361, 11362
___
Python tracker
<https://bugs.python.org/issue33608>
___
___
Python-bugs-list mailing list
Unsub
Change by Eric Snow :
--
pull_requests: +11360
___
Python tracker
<https://bugs.python.org/issue33608>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Eric Snow :
--
keywords: +patch, patch
pull_requests: +11123, 11124
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Eric Snow :
--
keywords: +patch
pull_requests: +11123
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Eric Snow added the comment:
New changeset fdf282d609fd172d52b59a6f1f062eb701494528 by Eric Snow in branch
'master':
bpo-35423: Stop using the "pending calls" machinery for signals. (gh-10972)
https://github.com/python/cpython/commit/fdf282d609fd172d52b5
New submission from Eric Snow :
The code in Modules/signalsmodule.c (as well as a few other places in the code)
has a concept of a "main" thread. It's the OS thread where Py_Initialize() was
called (and likely the process's original thread). For various good reasons,
w
Eric Snow added the comment:
Thanks, Michael.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Eric Snow added the comment:
New changeset a909460a09cca79bd051c45b02e650862a57dbd9 by Eric Snow (Michael
Felt) in branch 'master':
bpo-34569: Fix subinterpreter 32-bit ABI, pystate.c/_new_long_object()
(gh-9127)
https://github.com/python/cpyt
Change by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue35381>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue34522>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
nosy: +barry, brett.cannon
___
Python tracker
<https://bugs.python.org/issue35526>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
nosy: +eric.snow
type: -> behavior
versions: +Python 3.6
___
Python tracker
<https://bugs.python.org/issue35470>
___
___
Python-
New submission from Eric Snow :
In _imp_create_dynamic_impl() [1] the case where
_PyImport_FindExtensionObject() returns NULL may leave an error set. Either
the error should be raised (like _imp_create_builtin() does) or it should be
cleared (via PyErr_Clear()).
--
components
New submission from Eric Snow :
In the C-API documentation the entry for PyImport_AddModuleObject[1] does not
indicate that it returns a borrowed reference.
[1] https://docs.python.org/3/c-api/import.html#c.PyImport_AddModuleObject
--
assignee: docs@python
components: Documentation
Change by Eric Snow :
--
nosy: +emilyemorehouse
___
Python tracker
<https://bugs.python.org/issue35423>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
I suppose performance could have been a motivator originally. However, I don't
see a benefit now that signals handlers are no longer pending calls. If it's a
real problem then we can leverage a free list.
As to complexity, the motivator for this
Change by Eric Snow :
--
pull_requests: -10353
___
Python tracker
<https://bugs.python.org/issue35446>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
keywords: +patch
pull_requests: +10354
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Eric Snow :
--
pull_requests: +10353
___
Python tracker
<https://bugs.python.org/issue35446>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Eric Snow :
Currently the list of pending calls (see Include/internal/pycore_ceval.h) is
implemented as a circular buffer. A linked list would be easier to understand
and modify. It also allows for removing the restriction on the number of
pending calls
Eric Snow added the comment:
Correct. The remaining call to Py_AddPendingCall in the signal-handling code
is fine.
This issue is only indirectly related. I suppose you could consider it a
follow-up to #30703. The PR for that issue (GH-2415) switches from using
pending calls for signal
Change by Eric Snow :
--
keywords: +patch
pull_requests: +10214
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
New submission from Eric Snow :
For a while now the signal handling machinery has piggy-backed on ceval's
"pending calls" machinery (e.g. Py_AddPendingCall). This is a bit confusing.
It also increases the risk with unrelated changes to the pending calls code.
--
assi
Change by Eric Snow :
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.org/issue35420>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue35059>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue35081>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue26558>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
> Conversion is happens when type() (or metaclass()) is called.
Right. So an extra test to cover the __prepare__ case is somewhat redundant.
I only suggested it because type() is called implicitly and the test would make
the conversion case clear. However,
Eric Snow added the comment:
There is a conversion. See builtin___build_class__ in Python/bltinmodule.c
(and the LOAD_BUILD_CLASS target in Python/ceval.c). Specifically, the
metaclass (e.g. the builtin type) is instantiated using the namespace from the
class definition. The metaclass
Eric Snow added the comment:
As Serhiy said, this is the correct behavior. Nearly all builtin operations
are made using the appropriate "dunder" method from the object's type (not
looked up on the object itself). So the following (based on your example) are
equivalent:
Eric Snow added the comment:
> one of the things we want to fix is to eliminate non-PyObject
> pointer types from public APIs entirely.
A notable exception is Py_buffer. [1] As well, cross-interpreter data must not
be PyObject, though that isn't much of an issue (yet). :) At so
Eric Snow added the comment:
FWIW, the PEP 520 example isn't exactly right. PEP 520 is about the class
definition namespace, not the namespace object passed to type(). That always
does the right thing, since the default class definition namespace is dict
(which happens to be order
Change by Eric Snow :
--
Removed message: https://bugs.python.org/msg325897
___
Python tracker
<https://bugs.python.org/issue34320>
___
___
Python-bugs-list m
Eric Snow added the comment:
FWIW, the PEP 520 example isn't exactly right. PEP 520 is about the class
definition namespace, not the namespace object passed to type(). That always
does the right thing, since the default class definition namespace is dict
(which happens to be order
Change by Eric Snow :
--
nosy: +benjamin.peterson
___
Python tracker
<https://bugs.python.org/issue34722>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
Also see PEP 432 ("Restructuring the CPython startup sequence"), which is still
in the process of fine-tuning.
--
nosy: +eric.snow, ncoghlan, vstinner
___
Python tracker
<https://bugs.python.o
Eric Snow added the comment:
@Neil, we're definitely on the same page. In fact, in a world where
subinterpreters do not share a GIL, we can't ever use an object in one
interpreter that was created in another (due to thread safety on refcounts).
The role of "tightly contr
Change by Eric Snow :
--
keywords: +patch
pull_requests: +8758
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue33608>
___
_
Change by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue34690>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Eric Snow added the comment:
New changeset 5903296045b586b9cd1fce0b1e02caf896028d1d by Eric Snow in branch
'master':
bpo-34651: Only allow the main interpreter to fork. (gh-9279)
https://github.com/python/cpython/commit/5903296045b586b9cd1fce0b1e02ca
Change by Eric Snow :
--
keywords: +patch
pull_requests: +8710
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue34651>
___
_
New submission from Eric Snow :
os.fork() potentially has some problematic behavior when called from a
subinterpreter. In additional to the normal fork+threads madness, there's the
question of what to do with existing subinterpreters. The simplest solution is
to simply disallow fork
Change by Eric Snow :
--
nosy: +eric.snow, vstinner
___
Python tracker
<https://bugs.python.org/issue34579>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
Thanks for bringing this up, Michael. I'll give you a review on the PR
sometime this week (while at the core sprint).
--
___
Python tracker
<https://bugs.python.org/is
Change by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue4921>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
Thanks for the proposal. At first glance I actually kind of like the idea,
though I can't offer much more feedback than that without taking some time to
think it through. :)
That said, proposals like this for new syntax and other new language features
are
Change by Eric Snow :
--
status: open -> pending
___
Python tracker
<https://bugs.python.org/issue6531>
___
___
Python-bugs-list mailing list
Unsubscrib
Eric Snow added the comment:
Fair enough. Having the note in the 3.5 docs should be fine. :)
--
resolution: -> rejected
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Eric Snow added the comment:
There are several issues at hand here, Phillip. I'll enumerate them below.
Thanks for taking the time to let us know about this. However, I'm closing
this issue since realistically the behavior of imp.find_module() isn't going to
change, particu
Eric Snow added the comment:
FYI, I opened bpo-34413 to address how the bytecode change is not mentioned in
the porting section of the 3.5 "What's New" doc. In retrospect (I didn't
notice that this issue was still open), I suppose that doesn't need a separate
is
Eric Snow added the comment:
FTR, the change was introduced by the PEP 448 implementation. [1]
[1] https://github.com/python/cpython/pull/8338#issuecomment-406256152
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue33
New submission from Eric Snow :
In the 3.5 "What's New" doc, the porting section [1] does not mention the
bytecode changes resulting from the PEP 448 implementation. [2][3] It should.
I've marked this issue for the versions past 3.5 because each branch has its
own &quo
Eric Snow added the comment:
I'm not too invested in any changes happening at this point, actually. :)
Mostly I happened to be reading through the commit and noticed the
inconsistency. If I had reviewed the PR then I would have asked that it be
fixed. So I figured I'd mention
Eric Snow added the comment:
I'm not sure that this is a duplicate of #5322. That one's about a warning
when arguments are passed to object.__new__(). Yours is about using an
incompatible __new__ when creating a new class in Python. I agree that
behavior you're seeing is
Eric Snow added the comment:
FWIW, the C implementation of Task.__init__ is not exactly equivalent to the
Python implementation (nor to both the C and Python implementation of
Task.set_name). In the C impl of Task.__init__ the provided name is used as-is
if it's an instance o
Eric Snow added the comment:
I've changed the issue title to reflect where things stand.
Hmm, doing so reminded me of an important consideration here. A module object
is effectively a fairly light wrapper around a dict. When you call
importlib.reload() the loader from the module'
Eric Snow added the comment:
@chris, I can't promise that anything will happen right away, but I'll be sure
to look into this further when I work on improving extension module usage in
subinterpreters in the next few months.
--
___
Pyth
Eric Snow added the comment:
Also, PEP 3121 provides a good summary of some of the issues at hand.
--
___
Python tracker
<https://bugs.python.org/issue34
Eric Snow added the comment:
Also, part of the motivation for PEP 489 (extension module initialization) was
to help with reloading extension modules.
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.org/issue34
Eric Snow added the comment:
Ah, thanks for clarifying. So which of these is the main thing you really want:
1. reload extension modules
2. completely restart Python
It sounds like #1. If that's the case then there are a number of issues to
resolve to make it work. However, ther
Eric Snow added the comment:
Regarding your 3 points:
> a) Py_Finalize cannot be used reliably
Note that unloading extension modules is not the only thing that Py_Finalize
isn't doing that it probably should be. I expect that you would find a number
of memory leaks and potential
Eric Snow added the comment:
The matter of unloading extension modules is partly covered in bpo-401713.
However, note that a few things have changed in the last 18 years. :) I think
it would be worth revisiting the decision in that issue at this point.
If that were sorted out would there
Change by Eric Snow :
--
nosy: +emilyemorehouse
___
Python tracker
<https://bugs.python.org/issue34206>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue34206>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue34099>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
nosy: +emilyemorehouse, eric.snow
___
Python tracker
<https://bugs.python.org/issue16822>
___
___
Python-bugs-list mailing list
Unsub
Eric Snow added the comment:
@barry, make sure you take a look at https://bugs.python.org/issue14803.
--
___
Python tracker
<https://bugs.python.org/issue33
Eric Snow added the comment:
> I looked quickly at _Py_InitializeCore() and I'm not sure
> that it's designed to replace an existing configuration.
> ...
> So maybe for this specific case, _Py_InitializeCore() should
> always set Py_HashRandomizationFlag.
+1
At the
Change by Eric Snow :
--
nosy: +emilyemorehouse, eric.snow
___
Python tracker
<https://bugs.python.org/issue33919>
___
___
Python-bugs-list mailing list
Unsub
Change by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue31558>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
nosy: +emilyemorehouse
___
Python tracker
<https://bugs.python.org/issue33608>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
nosy: +emilyemorehouse
___
Python tracker
<https://bugs.python.org/issue33607>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
nosy: +emilyemorehouse
___
Python tracker
<https://bugs.python.org/issue33868>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
I'll take a look.
--
___
Python tracker
<https://bugs.python.org/issue33868>
___
___
Python-bugs-list mailing list
Unsubscr
Eric Snow added the comment:
Note that bpo-32604 is strongly related.
--
___
Python tracker
<https://bugs.python.org/issue24553>
___
___
Python-bugs-list mailin
Eric Snow added the comment:
Also see #24553.
--
___
Python tracker
<https://bugs.python.org/issue32604>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Eric Snow added the comment:
New changeset 9e7c92193cc98fd3c2d4751c87851460a33b9118 by Eric Snow in branch
'master':
bpo-17045: Improve C-API doc for PyTypeObject. (gh-7413)
https://github.com/python/cpython/commit/9e7c92193cc98fd3c2d4751c878514
Change by Eric Snow :
--
status: pending -> closed
___
Python tracker
<https://bugs.python.org/issue33615>
___
___
Python-bugs-list mailing list
Unsubscrib
Eric Snow added the comment:
Would it be possible to re-use the __reverse__() support that exists for
OrderedDict? Doing so could help avoid adding a bunch of duplicated code.
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.
Eric Snow added the comment:
As to the docs, the entry for tp_alloc in Doc/c-api/typeobj.rst does not
mention initialization. The tp_new entry does say that it should call tp_alloc
and then do the minimum initialization possible. That implies (weakly) that
tp_alloc should do the minimum
Eric Snow added the comment:
Thanks for bringing this up, Hristo!
"Initialization" (in this context, and hopefully everywhere in the C-API docs)
is referring specifically to setting fields on a custom instance, much as you
would expect in __init__ (or sometimes even __new__)
Eric Snow added the comment:
@Cheryl, thanks for pointing that out. I'll take a look.
--
___
Python tracker
<https://bugs.python.org/issue17045>
___
___
Eric Snow added the comment:
I've re-enabled the subinterpreter tests, but left the one problem test
(ChannelTests.test_run_string_arg_resolved) disabled. I also changed all uses
of %lld to use PRId64 instead. (Thanks, Victor, for the suggestion.)
The buildbots look good. I'
Eric Snow added the comment:
New changeset ab4a1988fd4347484a7928394b94e2cdf5f8f2a7 by Eric Snow in branch
'master':
bpo-33615: Re-enable subinterpreter tests. (#7552)
https://github.com/python/cpython/commit/ab4a1988fd4347484a7928394b94e2
Change by Eric Snow :
--
pull_requests: +7184
___
Python tracker
<https://bugs.python.org/issue33615>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
Yeah, I did a custom build the other day. Sorry about the delay in disabling
the test again and thanks for getting it done.
--
___
Python tracker
<https://bugs.python.org/issue33
Eric Snow added the comment:
@Christian, you can use the "blurb" tool to create the NEWS entry. You can use
pip to install it. See:
https://devguide.python.org/committing/?highlight=blurb#what-s-new-and-news-entries
--
nosy:
Eric Snow added the comment:
I found some time to at least get the patch to apply cleanly to master and to
make a PR. :)
--
___
Python tracker
<https://bugs.python.org/issue17
Change by Eric Snow :
--
pull_requests: +7038
___
Python tracker
<https://bugs.python.org/issue17045>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
FTR, bpo-33724 is related
--
___
Python tracker
<https://bugs.python.org/issue33615>
___
___
Python-bugs-list mailing list
Unsub
Eric Snow added the comment:
I'll definitely take a look. It might not be until Friday though.
--
___
Python tracker
<https://bugs.python.org/is
Eric Snow added the comment:
That email thread contains multiple references to scripts that may be used to
identify ABI issues, among other good points. FWIW, when consolidating the C
globals last year I added a tool to track the remaining globals:
Tools/c-globals
It is similar (at
Eric Snow added the comment:
FTR, the issue of ABI breakage has come up quite a few times on the mailing
list. Most recently:
https://mail.python.org/pipermail/python-dev/2018-June/153775.html
--
___
Python tracker
<https://bugs.python.
Eric Snow added the comment:
Sorry for any confusion. This issue is still resolved. It is bpo-33615 that
had an unexpected recurrence. I've re-opened that one.
--
resolution: -> fixed
status: open -> closed
___
Python trac
Eric Snow added the comment:
This appears to be recurring on the "x86 Gentoo Refleaks 3.x" builder still. I
was thrown off by the success of the first run after I landed my fix:
http://buildbot.python.org/all/#/builders/1/builds/241
FYI, the other buildbots having this issue b
801 - 900 of 2629 matches
Mail list logo