[issue15532] for line in file is *still* broken in Python 2.7 on pipes

2012-08-01 Thread Andy Lutomirski
Changes by Andy Lutomirski l...@amacapital.net: -- title: for line in file is *still* broken in Python 2.7 - for line in file is *still* broken in Python 2.7 on pipes ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15532

[issue15502] Meta path finders and path entry finders are different, but share an ABC

2012-08-01 Thread Nick Coghlan
Nick Coghlan added the comment: The problem with path importer is it's just plain *wrong*. That object is not an importer and thus calling it one makes it much harder to learn the finder/loader/importer distinctions correctly. import finder is only slightly longer than importer and has the huge

[issue15502] Meta path finders and path entry finders are different, but share an ABC

2012-08-01 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Aug 01, 2012, at 10:44 PM, Nick Coghlan wrote: The problem with path importer is it's just plain *wrong*. That object is not an importer and thus calling it one makes it much harder to learn the finder/loader/importer distinctions correctly. The term

[issue15321] bdist_wininst installers may terminate with close failed in file object destructor:\nsys.excepthook is missing\nlost sys.stderr

2012-08-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 014b36383a54 by Eli Bendersky in branch '3.2': Issue #15321: update PyPI upload doc to say --no-raw passed to rst2html.py http://hg.python.org/cpython/rev/014b36383a54 -- ___ Python tracker

[issue15231] update PyPI upload doc to say --no-raw passed to rst2html.py

2012-08-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 29bdbcadf299 by Eli Bendersky in branch '2.7': Issue #15231: update PyPI upload doc to say --no-raw passed to rst2html.py http://hg.python.org/cpython/rev/29bdbcadf299 -- ___ Python tracker

[issue15231] update PyPI upload doc to say --no-raw passed to rst2html.py

2012-08-01 Thread Eli Bendersky
Eli Bendersky added the comment: Backported in 014b36383a54 and 29bdbcadf299 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15231 ___ ___

[issue15518] Provide test coverage for filecmp.dircmp.report methods.

2012-08-01 Thread Chris Calloway
Chris Calloway added the comment: There are at least two ways you could deal with this. You could change the working directory to the temp directory in setUp() and change it back in tearDown(). This is a common pattern in the tests [...] Alternatively, you could save the temp directory

[issue15518] Provide test coverage for filecmp.dircmp.report methods.

2012-08-01 Thread Chris Jerdonek
Chris Jerdonek added the comment: However, I would like your blessing to continue with assertRegex in this case. Sure, you can proceed that way. :) My suggestions were just that -- suggestions for you to consider. And I am not a core developer, so my approval won't necessarily get your

[issue15521] Dev Guide should say how to run tests in 2.7

2012-08-01 Thread Chris Jerdonek
Chris Jerdonek added the comment: It is a relatively large section (nine paragraphs + six code snippets) and is primarily about the in-development branch, so I did not want to interrupt the flow with a remark specific to 2.7. I also liked that the instructions in a subsection could be linked

[issue15526] regrtest crash on Windows 7 AMD64

2012-08-01 Thread Jeremy Kloth
Jeremy Kloth added the comment: I have just completed an upgrade of the Win64 buildbot slave with a faster hard drive and the issue is now much more pronounced. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15526

[issue15502] Meta path finders and path entry finders are different, but share an ABC

2012-08-01 Thread Eric Snow
Eric Snow added the comment: The patch will have Finder break all subclasses that don't define find_loader which is backwards-incompatible. How so? Finder is registered against PathEntryFinder. It doesn't inherit, so it doesn't get the abc.ABCMeta as a metaclass and thereby there is no

[issue15502] Meta path finders and path entry finders are different, but share an ABC

2012-08-01 Thread Eric Snow
Changes by Eric Snow ericsnowcurren...@gmail.com: Removed file: http://bugs.python.org/file26642/issue15502_new_abc.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15502 ___

[issue15502] Meta path finders and path entry finders are different, but share an ABC

2012-08-01 Thread Eric Snow
Eric Snow added the comment: Regarding deprecating importlib.abc.Finder, I'll add a DeprecationWarning to the patch later. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15502 ___

[issue15526] regrtest crash on Windows 7 AMD64

2012-08-01 Thread Chris Jerdonek
Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- nosy: +cjerdonek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15526 ___ ___

[issue15496] harden directory removal for tests on Windows

2012-08-01 Thread Chris Jerdonek
Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- nosy: +cjerdonek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15496 ___ ___

[issue7443] test.support.unlink issue on Windows platform

2012-08-01 Thread Chris Jerdonek
Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- nosy: +cjerdonek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7443 ___ ___

[issue15502] Meta path finders and path entry finders are different, but share an ABC

2012-08-01 Thread Nick Coghlan
Nick Coghlan added the comment: As far as path import finder goes, it's no more wrong than meta path finder and path entry finder. A meta path finder is a finder that gets installed on sys.meta_path, a path entry finder is one that finds loaders based on a specific path entry, and the path

[issue15502] Meta path finders and path entry finders are different, but share an ABC

2012-08-01 Thread Eric Snow
Eric Snow added the comment: Okay, while the dust clears, I am going to separate the two parts into different patches. :) -- Added file: http://bugs.python.org/file26654/issue15502_new_abc.diff ___ Python tracker rep...@bugs.python.org

[issue15502] Meta path finders and path entry finders are different, but share an ABC

2012-08-01 Thread Eric Snow
Changes by Eric Snow ericsnowcurren...@gmail.com: Removed file: http://bugs.python.org/file26653/issue15502_new_abc.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15502 ___

[issue15502] Meta path finders and path entry finders are different, but share an ABC

2012-08-01 Thread Eric Snow
Changes by Eric Snow ericsnowcurren...@gmail.com: Added file: http://bugs.python.org/file26655/issue15502_windows_registry_finder.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15502 ___

[issue15502] Meta path finders and path entry finders are different, but share an ABC

2012-08-01 Thread Eric Snow
Changes by Eric Snow ericsnowcurren...@gmail.com: Removed file: http://bugs.python.org/file26654/issue15502_new_abc.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15502 ___

[issue15502] Meta path finders and path entry finders are different, but share an ABC

2012-08-01 Thread Eric Snow
Changes by Eric Snow ericsnowcurren...@gmail.com: Added file: http://bugs.python.org/file26656/issue15502_new_abc.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15502 ___

[issue15496] harden directory removal for tests on Windows

2012-08-01 Thread Nick Coghlan
Changes by Nick Coghlan ncogh...@gmail.com: -- nosy: +ncoghlan ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15496 ___ ___ Python-bugs-list

[issue15532] for line in file is *still* broken in Python 2.7 on pipes

2012-08-01 Thread Ned Deily
Ned Deily added the comment: Notice in the reply to Issue3907, with 2.6, you have to use io.open() explicitly. This is still true in Python 2.7, i.e. the new 3.x-compatible io library is not used by default in Python 2. If you want to use it with subprocess.Popen, one way is to supply a

[issue15502] Meta path finders and path entry finders are different, but share an ABC

2012-08-01 Thread Eric Snow
Eric Snow added the comment: While ungainly a name change, this patch at least demonstrates the places that the name would have to change. -- Added file: http://bugs.python.org/file26657/issue15502_file_path_entry_finder_of_doom.diff ___ Python

[issue15502] Meta path finders and path entry finders are different, but share an ABC

2012-08-01 Thread Eric Snow
Changes by Eric Snow ericsnowcurren...@gmail.com: Added file: http://bugs.python.org/file26658/issue15502_new_abc.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15502 ___

[issue15502] Meta path finders and path entry finders are different, but share an ABC

2012-08-01 Thread Eric Snow
Changes by Eric Snow ericsnowcurren...@gmail.com: Removed file: http://bugs.python.org/file26656/issue15502_new_abc.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15502 ___

[issue7443] test.support.unlink issue on Windows platform

2012-08-01 Thread Nick Coghlan
Nick Coghlan added the comment: See #15496 for an alternative approach to solving this problem, at least in the test suite - as noted in that issue, the rename dance isn't sufficient when the problem gets triggered by a different sequence like: unlink(file_in_parent_dir) unlink(parent_dir) #

[issue15502] Meta path finders and path entry finders are different, but share an ABC

2012-08-01 Thread Eric Snow
Changes by Eric Snow ericsnowcurren...@gmail.com: Removed file: http://bugs.python.org/file26655/issue15502_windows_registry_finder.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15502 ___

[issue15502] Meta path finders and path entry finders are different, but share an ABC

2012-08-01 Thread Eric Snow
Eric Snow added the comment: didn't mean to yank that one. -- Added file: http://bugs.python.org/file26659/issue15502_windows_registry_finder.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15502

[issue13119] Newline for print() is \n on Windows, and not \r\n as expected

2012-08-01 Thread Atsuo Ishimoto
Atsuo Ishimoto added the comment: Test for this issue. Tested on Windows7, Ubuntu linux 12.04. I wonder why print(1, file=sys.stderr) returns '1' instead of '1\n'. But in Python2.7, print sys.stderr, 1 also returns '1', so this might not be a problem. -- Added file:

[issue15533] subprocess.Popen(cwd) documentation

2012-08-01 Thread Chris Jerdonek
New submission from Chris Jerdonek: The sentence describing Popen()'s cwd argument in the subprocess documentation seems reversed to me: http://docs.python.org/dev/library/subprocess.html#subprocess.Popen It says, If cwd is not None, the child’s current directory will be changed to cwd

<    1   2