Serhiy Storchaka added the comment:
It would be more helpful to split the patch on three independent patches for
three modules.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20182
___
Stefan Krah added the comment:
Sadly, for political reasons, it's best that we not convert collections,
itertools, or random for now.
Well, there are also technical reasons. For example, when reviewing a huge
patch at the beginning of this year, the sections that touched AC took me 10
Tal Einat added the comment:
Here's a new patch for Objects/unicodeobject.c with all of Serhiy's suggestions
integrated.
--
Added file: http://bugs.python.org/file39190/unicodeobject.c.v4.patch
___
Python tracker rep...@bugs.python.org
Behdad Esfahbod added the comment:
Thanks Marc-Andre. If the x_ was indeed added for that reason, it's quite a
coincidence, because the MIME name of these encodings also starts with
x-mac-..., so I assumed that's where the x_ comes from.
The mappings are available at the Unicode website:
Tal Einat added the comment:
Hurrah!
And that seems to be it for this group, since collections, itertools and random
are not to be converted at this point, as well as the Modules/xx*.c files, and
the stringlib files probably require overly extensive changes for conversion.
--
Serhiy Storchaka added the comment:
The patch causes a lot of warnings like
Objects/unicodeobject.c: In function ‘unicode_title_impl’:
Objects/unicodeobject.c:10581:5: warning: passing argument 1 of
‘_PyUnicode_Ready’ from incompatible pointer type [enabled by default]
if
appidman added the comment:
I created a issue for paramiko: https://github.com/paramiko/paramiko/issues/515
I'm trying to create a script which reproduces the bug, but it might be a bit
tough, because as I said it's not happening all the time.
--
Berker Peksag added the comment:
LGTM
--
assignee: docs@python - berker.peksag
nosy: +berker.peksag
stage: - commit review
type: performance - enhancement
versions: +Python 3.5
___
Python tracker rep...@bugs.python.org
Tal Einat added the comment:
Version of patch with PyUnicodeObject * warnings fixed.
--
Added file: http://bugs.python.org/file39191/unicodeobject.c.v5.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
Marc-Andre Lemburg added the comment:
On 23.04.2015 21:02, Behdad Esfahbod wrote:
They are used in OpenType fonts, but not implemented by Python at this time.
Here's are the Unicode mappings for them:
http://unicode.org/Public/MAPPINGS/VENDORS/APPLE/ROMANIAN.TXT
Marc-Andre Lemburg added the comment:
The x_ prefix was added as reminder and way to document the desire to look
into this at some point:
https://github.com/python/cpython/commit/c696b47b10db1fa22b77ecfe1af392b3d62aab61
Before adding more codecs, we always ask whether these are in actual use.
Changes by Prince prince0...@gmail.com:
--
nosy: +roger.serwy, terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24039
___
___
Serhiy Storchaka added the comment:
unicodeobject.c.v5.patch LGTM.
--
stage: needs patch - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
Marc-Andre Lemburg added the comment:
On 24.04.2015 10:34, Behdad Esfahbod wrote:
Thanks Marc-Andre. If the x_ was indeed added for that reason, it's quite a
coincidence, because the MIME name of these encodings also starts with
x-mac-..., so I assumed that's where the x_ comes from.
Thomas Wouters added the comment:
Rewriting the tests shouldn't block this specific issue, no. Also, don't use
multiprocessing for it. I would just use subprocess to start a separate process
(which might after all be OOM-killed,) check the exitcode, and record its
stderr in case of failure.
Skip Montanaro added the comment:
Can you provide a trimmed down example which provokes the segmentation fault?
--
nosy: +skip.montanaro
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24050
New submission from Nick Craig-Wood:
Here is a patch to remove some unused code in `symtable.c`
In Python3 `from x import *` was banned from use in functions completely.
This is detected by `symtable_visit_alias`
if (st-st_cur-ste_type != ModuleBlock) {
int lineno =
Shinto Peter added the comment:
check this this link :
http://jodal.no/post/5779178001/log-from-the-debugging-of-a-segfault/
tells about Segfault
--
nosy: +shinto
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24050
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file39193/tkinter_getxxx_tclobj-2.7.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23880
___
Serhiy Storchaka added the comment:
2. Does the change break existing code?
Usually not.
I meant that the only difference (except that now Tkinter can work in cases
where it failed before) is that that some exceptions can change its type from
ValueError to TclError. But first, these
New submission from nivin:
Got an error as Segmentation fault (core dumped) when executed a python script
. Error getting only for a specific python script only
--
components: Interpreter Core
messages: 241940
nosy: nivin
priority: normal
severity: normal
status: open
title:
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file39192/tkinter_getxxx_tclobj-3.4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23880
___
Ma Lin added the comment:
Andre Lemburg,
We don't need any modify, A844 is in GBK but not in GB2312, so no need to add
it into GB2312.
Your logic is right, it's hard to judge which one is wrong.
But U+30FB (· KATAKANA MIDDLE DOT) and U+2015 (— HORIZONTAL BAR) have no reason
among these
Changes by Serhiy Storchaka storch...@gmail.com:
--
dependencies: +Argument Clinic no longer works with single optional argument
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20168
___
New submission from Serhiy Storchaka:
Argument Clinic no longer works single optional argument. For example see
_tkinter.tkapp.wantobjects in the patch in issue20168.
/*[clinic input]
_tkinter.tkapp.wantobjects
[
value: int
]
/
[clinic start generated code]*/
It is converted
Tal Einat added the comment:
Here's a patch just for Modules/signalmodule.c (and related files), based on
Georg's patch, updated to apply against current default, including fixes thanks
to Serhiy's review.
This include one minor doc change, since I changed the name of the second
parameter to
eryksun added the comment:
-- import sys
-- sys.exit(2**63)
9223372036854775808
The above is only Python 2.x behavior. On Windows, sys.maxint is 2147483647
(even for 64-bit Windows), so 2**63 is a Python long. Thus handle_system_exit
takes the PyFile_WriteObject branch, with the actual
Serhiy Storchaka added the comment:
Unfortunately this will not help for re, because the trace passes through three
files: Lib/sre_parse.py, Lib/sre_compile.py and Lib/re.py.
--
___
Python tracker rep...@bugs.python.org
Behdad Esfahbod added the comment:
They are a rather minor change on top of the existing Asian encodings. So
implementing them in Python might be easier. I have a half-done version of
those. I can try finishing and post it back here.
--
___
Marc-Andre Lemburg added the comment:
On 24.04.2015 20:34, Behdad Esfahbod wrote:
They are a rather minor change on top of the existing Asian encodings. So
implementing them in Python might be easier. I have a half-done version of
those. I can try finishing and post it back here.
If
Ethan Furman added the comment:
Windows 7
C:\Python27python
Python 2.7.5 (default, May 15 2013, 22:43:36) [MSC v.1500 32 bit (Intel)] on
win32
Type help, copyright, credits or license for more information.
-- import sys
-- sys.exit(2**63)
9223372036854775808
C:\Python27python
Python 2.7.5
Alexander Belopolsky added the comment:
-- sys.exit(2**63)
9223372036854775808
Interesting. So it is probably not unheard of in the Windows world to use
errors codes like 1000,1001,..1024,.. to avoid conflicts with system codes.
Maybe on POSIX systems, sys.code(code) should print code and
STINNER Victor added the comment:
I've updated the patch with the comments from the review
Thanks William for your contribution, I commited your fix.
I just made a minor change on if (cwd use_bytes) {: you forgot to remove
test now useless test on cwd, and I dropped { and } to make to short
STINNER Victor added the comment:
tokenizeV2.patch and tokenize.patch have issues, I reviewed them. Can someone
please write a new patch taking my comments in account?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23840
Roundup Robot added the comment:
New changeset abf1f3ae4fa8 by Victor Stinner in branch '3.4':
Issue #9246: On POSIX, os.getcwd() now supports paths longer than 1025 bytes
https://hg.python.org/cpython/rev/abf1f3ae4fa8
New changeset b871ace5c58f by Victor Stinner in branch 'default':
(Merge
Tal Einat added the comment:
Here's a patch just for Modules/selectmodule.c (and related files), based on
Georg's patch, updated to apply against current default, including fixes thanks
to Serhiy's review.
It took a while since I had to get a Linux VM up to run the epoll tests. And it
was
Matt Chung added the comment:
Hey Haypo,
I'm working on submitting the new patch now. Still getting used to the
workflow and tools here. Thanks for being patient.
You should see the new file in the next 30 minutes.
--
___
Python tracker
STINNER Victor added the comment:
diverging discussion: Go re-read the documentation on os.times().
We don't have the same definition of the unit seconds :-)
print(os.times()); time.sleep(1); print(os.times())
(0.04, 0.01, 0.0, 0.0, 4731691.68)
(0.04, 0.01, 0.0, 0.0, 4731692.68)
My watch
STINNER Victor added the comment:
We don't have the same definition of the unit seconds :-)
Or, please forget my comment, I watched the first 4 items of os.times(). I
didn't notice the difference of the 5th item, os.times()[4].
The bad news is that only the first two items of os.times() are
Tim Pierce added the comment:
Adding Python 2.7 to the affected versions (from #23341 which was closed as a
duplicate of this bug). We are very interested to know whether this will be
fixed in a Python 2.7 patch as well.
--
nosy: +twpierce
versions: +Python 2.7
New submission from Alexander Belopolsky:
Python defines some BSDish exit codes in the os module:
EX_CANTCREAT = 73
EX_CONFIG = 78
EX_DATAERR = 65
EX_IOERR = 74
EX_NOHOST = 68
EX_NOINPUT = 66
EX_NOPERM = 77
EX_NOUSER = 67
EX_OK = 0
EX_OSERR = 71
Changes by Brett Cannon br...@python.org:
--
assignee: brett.cannon -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Stefan Krah added the comment:
At first glance the return values look right to me:
The value of exit returned to the parent should be status 0377.
--
nosy: +skrah
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24052
Changes by Brett Cannon br...@python.org:
--
status: open - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24050
___
___
Python-bugs-list
Changes by Brett Cannon br...@python.org:
--
nosy: +brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24049
___
___
Python-bugs-list
Ethan Furman added the comment:
I previously wrote:
--
Gareth, please ignore my comments about adding guards on the return value --
it is up
to the O/S to use or adjust whatever Python returns.
Let me clarify that a bit: we need to protect against overflow from long to
int;
New submission from Alexander Belopolsky:
$ python3
Python 3.4.3 (default, Mar 2 2015, 11:08:35)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-4)] on linux
Type help, copyright, credits or license for more information.
import sys
import subprocess
subprocess.call([sys.executable, '-c', import
Alexander Belopolsky added the comment:
Alexander, create a new issue for the problem of converting non-zero values
to zero.
See #24052.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14376
Changes by Brett Cannon br...@python.org:
--
nosy: +brett.cannon, eric.snow, ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24048
___
___
Brett Cannon added the comment:
Here is a private function in warnings for calculating the stack depth to the
first frame not referencing some key string. Can someone look at it to make
sure it looks reasonable?
I'm starting with it being private since it uses sys._getframe() and I don't
Brett Cannon added the comment:
I've decided that having the module exist in Python 2.7 and 3.5 but not 3.0 -
3.4 is just asking for trouble.
--
resolution: - rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 135d5a3e415b by Benjamin Peterson in branch '3.4':
remove dead *-import checking code (closes #24049)
https://hg.python.org/cpython/rev/135d5a3e415b
New changeset 5c0247a6f98a by Benjamin Peterson in branch 'default':
merge 3.4 (#24049)
Terry J. Reedy added the comment:
The link appears to be about a bug in the C code of mopidy-spotify, which was
properly reported to the github mopidy site. This tracker is only for bugs in
the Python-CPython docs and CPython implmentation, as maintained in the cpython
repository at
James Edwards added the comment:
It looks like this is a bug in pyreadlines as suggested by eryksun, but for a
different reason.
Even though the Caps Lock + Shift combination is recognized correctly (as lower
case), the logic in the pyreadlines module forces it to upper case.
See lines 44-45
Changes by Alexander Belopolsky alexander.belopol...@gmail.com:
--
nosy: +skrah
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24053
___
___
Changes by Alexander Belopolsky alexander.belopol...@gmail.com:
--
title: sys.exit(code) returns success to the OS for some values of code -
sys.exit(code) returns success to the OS for some nonzero values of code
___
Python tracker
Ethan Furman added the comment:
If anything changes here it needs to be O/S dependent. MS Windows can work
with DWORD return values, so truncating to 8-bits is wrong for that platform.
--
nosy: +ethan.furman
___
Python tracker
New submission from David D. Riddle:
test_linecache.py reads from three files namely inspect_fodder.py,
inspect_fodder2.py, and mapping_tests.py. It reads the py files directly as
text files. This patch copies these files to linecache_fodder,
linecache_fodder2, and linecache_mapping_fodder
Ethan Furman added the comment:
Where are EXIT_FAILURE and EXIT_SUCCESS defined?
And we should probably call them EX_FAILURE and EX_SUCESS to match what's
already there.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24053
Alexander Belopolsky added the comment:
I agree that the truncation limits should be OS dependent and preserve the
values to the extent possible on a given platform. I just want to avoid a
situation when sys.exit(code) returns zero for a non-zero code.
BTW, what does sys.exit(2**63) return
Changes by Wolfgang Maier wolfgang.ma...@biologie.uni-freiburg.de:
--
nosy: +wolma
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23356
___
___
eryksun added the comment:
I believe a better behavior for sys.exit() would be to truncate
the code values to 8-bit range so that non-zero status would
always be returned as non-zero, but possibly different value.
OK, so long as it's just for POSIX systems. Windows ExitProcess, ExitThread,
Alexander Belopolsky added the comment:
I am attaching a patch implementing these constants. If this is well-received,
I will add documentation.
--
assignee: - belopolsky
keywords: +easy, patch
stage: - patch review
versions: +Python 3.5
Added file:
Changes by Alexander Belopolsky alexander.belopol...@gmail.com:
--
nosy: +ethan.furman, mark.dickinson, serhiy.storchaka, terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24053
___
Alexander Belopolsky added the comment:
The value of exit returned to the parent should be status 0377.
Apparently, this is not so on Windows. See msg241903 in #24045.
POSIX defines [1] exit to return status 0377, but that does not mean that
sys.exit(256) must return 0 without a warning.
Stefan Behnel added the comment:
Searching for Python code that seems to implement the Generator protocol
doesn't return much:
https://code.openhub.net/search?s=%22def%20throw%28%22%20%22def%20send%28%22%20%22def%20close%28%22pp=0fl=Pythonmp=1ml=1me=1md=1ff=1filterChecked=true
But at least it
Changes by William Orr w...@worrbase.com:
Removed file: http://bugs.python.org/file39005/max_getcwd.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9246
___
Changes by William Orr w...@worrbase.com:
Removed file: http://bugs.python.org/file39154/max_getcwd.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9246
___
William Orr added the comment:
I've updated the patch with the comments from the review
--
Added file: http://bugs.python.org/file39199/max_getcwd.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9246
Alexander Belopolsky added the comment:
Where are EXIT_FAILURE and EXIT_SUCCESS defined?
In C stdlib:
$ grep EXIT_ /usr/include/stdlib.h
#define EXIT_FAILURE1
#define EXIT_SUCCESS0
we should probably call them EX_FAILURE and EX_SUCESS to match what's already
there.
No. EX_ macros
James Edwards added the comment:
If you start the interactive interpreter with the -S switch, e.g.
python.exe -S
Do you still see this behavior?
--
nosy: +jedwards
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24035
Ethan Furman added the comment:
Sounds good, I have no objections.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24053
___
___
Python-bugs-list
Behdad Esfahbod added the comment:
Very valid question. Let me ask and get back to you.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24043
___
Serhiy Storchaka added the comment:
Guido's time machine strikes back.
'π–∆'.encode('mac_romanian')
b'\xb9\xd0\xc6'
'π–∆'.encode('mac_croatian')
b'\xf9\xe0\xb4'
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
Aren't EXIT_SUCCESS and EXIT_FAILURE needed only for support VMS?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24053
___
Behdad Esfahbod added the comment:
Huh. So they are implemented, even though they are not in aliases.py. Sorry
about the noise! Please add them to aliases.py.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24043
Serhiy Storchaka added the comment:
What aliases have these encodings?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24043
___
___
Serhiy Storchaka added the comment:
And it would be more helpful to use self-descriptive converter names instead of
cryptic format units.
--
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
This proposition conflicts with optional parameters of str.startswith().
'test'.startswith(('a', 'b', 'c'), 1, 3)
False
--
nosy: +serhiy.storchaka
resolution: - rejected
stage: - resolved
status: open - closed
Tal Einat added the comment:
Serhiy, I agree on both points. I can easily replace all of the converters and
upload it as three separate patches. If you haven't started reviewing the patch
yet, let me know and I'll do these things ASAP.
--
___
Marc-Andre Lemburg added the comment:
Hi Ma Lin,
thank you for your investigation. In order to fix these tables, we'd need an
official reference which shows that there is in fact an error. If most
programming languages you have tested use the wrong version, then maybe it's
not wrong after
Marc-Andre Lemburg added the comment:
On 24.04.2015 04:54, aixtools wrote:
Rather than wait for that to happen I decided to experiment with LibreSSL. If
you are not familiar with LibreSSL - I shall be quick - openbsd (who also
maintains openssh) has been cutting out insecure and/or
Serhiy Storchaka added the comment:
I already have reviewed changes to select and signal.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20182
___
William Orr added the comment:
Updated the patch based on review
--
Added file: http://bugs.python.org/file39200/max_fd.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23852
___
Changes by William Orr w...@worrbase.com:
Removed file: http://bugs.python.org/file39097/max_fd.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23852
___
Ethan Furman added the comment:
We can already do
-- some_string.starts_with(('innie','minnie', 'minie', 'moe'))
Your proposal appears to be equivalent to:
-- 'test'.startswith(('a', 'b', 'c'))
How often do you check to see if a string starts with only a single character?
-1
tuple() is the
Behdad Esfahbod added the comment:
Similar encodings have an alias that removes the underscore:
https://github.com/python/cpython/blob/master/Lib/encodings/aliases.py#L435
--
___
Python tracker rep...@bugs.python.org
Marc-Andre Lemburg added the comment:
On 24.04.2015 21:25, Serhiy Storchaka wrote:
Serhiy Storchaka added the comment:
Guido's time machine strikes back.
'π–∆'.encode('mac_romanian')
b'\xb9\xd0\xc6'
'π–∆'.encode('mac_croatian')
b'\xf9\xe0\xb4'
Ah, I should have looked in the
Alexander Belopolsky added the comment:
I would say, they are there to support *humans*. I am not aware of any human
language where success is spelled 0. (1 is a failing mark in some schools -
so there is a precedent for that. :-)
--
___
Python
Terry J. Reedy added the comment:
I changed the title to generalize this issue.
The modal Options = Configure IDLE box does not have minimize or maximize
buttons and cannot be resized. (Ditto for About Idle.) This is typical of
Windows dialogs, even though horizontal expansion would often be
Brett Cannon added the comment:
Skipping the source stat makes no difference in startup time even if you import
django.http as part of the work. This would definitely be mostly for people who
launch so many processes that they actually gain from collecting microseconds
worth of benefit from
New submission from Demian Brecht:
There's a feature available via nose that might be nice to have in unittest:
package-level setup and teardown functions.
Using nose, I can define a setUpModule() method in a test package's __init__.py
and it will execute it during the test run. This is
Robert Collins added the comment:
Thanks, I shall look at this Monday.
--
nosy: +rbcollins
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24054
___
93 matches
Mail list logo
