[issue28092] Build failure for 3.6 on Centos 5.11

Benjamin Peterson added the comment: I changed the dtrace stubs to static inline. Probably should reopen an investigation for 3.7. I would like to have exportable inlines. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue28092] Build failure for 3.6 on Centos 5.11

Roundup Robot added the comment: New changeset fd9a4bd16587 by Benjamin Peterson in branch '3.6': mark dtrace stubs as static inline; remove stubs https://hg.python.org/cpython/rev/fd9a4bd16587 -- nosy: +python-dev ___ Python tracker

[issue28092] Build failure for 3.6 on Centos 5.11

Ned Deily added the comment: "*** WARNING: renaming "_sqlite3" since importing it failed: build/lib.linux-x86_64-3.6/_sqlite3.cpython-36m-x86_64-linux-gnu.so: undefined symbol: sqlite3_stmt_readonly" That's a different issue: most likely you are building with an old version of libsqlite3.

[issue28092] Build failure for 3.6 on Centos 5.11

Robin Becker added the comment: for what it's worth I tried reverse patching https://hg.python.org/cpython/rev/63ae310b60ff/ and https://hg.python.org/cpython/rev/2f77a9f0b9d6/ in the manylinux docker and the make then proceeds fine with one warning at the end *** WARNING: renaming

[issue28092] Build failure for 3.6 on Centos 5.11

Robin Becker added the comment: After some searching I tried adding -std=gnu99 and the config goes through OK, but running make produces [root@d3cce9786c2e Python-3.6.0b2]# make -j2 gcc -pthread -c -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -Wformat

[issue28092] Build failure for 3.6 on Centos 5.11

Robin Becker added the comment: benjamin.peterson: I tried adding that option -fno-gnu89-inline conditionally for the 3.6.0b2 build, but it goes wrong in config with an error configure:3913: $? = 4 configure:3933: checking whether the C compiler works configure:3955: gcc -Wformat

[issue28092] Build failure for 3.6 on Centos 5.11

Robin Becker added the comment: I'm not able to access my work computer, I'll try later today at home. -- ___ Python tracker ___

[issue28092] Build failure for 3.6 on Centos 5.11

Benjamin Peterson added the comment: Any different results with CFLAGS="-fno-gnu89-inline"? -- ___ Python tracker ___

[issue28092] Build failure for 3.6 on Centos 5.11

Nathaniel Smith added the comment: > 3.6 currently compiles correctly with gcc4.2, the default on Mac OS X 10.5 > (Leopard). So to summarize our current understanding: gcc 4.3 added support for C99 inline, which explains why gcc 4.2 works and gcc 4.8 doesn't. WTF is going on. --

[issue28092] Build failure for 3.6 on Centos 5.11

Ned Deily added the comment: "while non-static inline has problems with the default compilers on both CentOS 5 and OS X." The changes introduced in 3.6 prevent compilation with gcc4.0 which was the default Apple-supplied compiler on Mac OS X 10.4 (Tiger). 3.6 currently compiles correctly

[issue28092] Build failure for 3.6 on Centos 5.11

Nathaniel Smith added the comment: Yeah, the config.log there clearly shows that configure is using gcc 4.8.2 on the failed builds. Very odd. Stepping back for a moment, is there any point in continuing to debug this? Given Benjamin's comment up-thread: > I mainly converted them to see if it

[issue28092] Build failure for 3.6 on Centos 5.11

Robin Becker added the comment: tds333, the config says that 4.8.2 is being used, configure:3902: gcc --version >&5 gcc (GCC) 4.8.2 20140120 (Red Hat 4.8.2-15) Copyright (C) 2013 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty;

[issue28092] Build failure for 3.6 on Centos 5.11

Wolfgang Langner added the comment: Also verified on CentOS 6.8 with devtoolset2 installed, gcc 4.8.2 Python 3.6b2 builds fine, all unittest ok. This is the same devtoolset as used on CentOS 5 manylinux1. Have no CentOS 5 VM available to do more tests. But gcc 4.8 is able to build Python 3.6.

[issue28092] Build failure for 3.6 on Centos 5.11

Wolfgang Langner added the comment: Please check if you have enabled the compiler as default by enabling the devtoolset on CentOS 5. I have compiled Python 3.6b2 on Ubuntu 14.04 with gcc 4.8.4 without any problems. Therefore gcc 4.8.2 should not be that different. Also keep in mind the

[issue28092] Build failure for 3.6 on Centos 5.11

Robin Becker added the comment: Hi njs, my manylinux diffs https://www.reportlab.com/media/manylinux-diff.txt full output of the docker command docker build -f Dockerfile-x86_64 -t rl/manylinux-x86_64 . &> ~/tmp/ttt https://www.reportlab.com/media/manylinux-docker-run-output.txt the end

[issue28092] Build failure for 3.6 on Centos 5.11

STINNER Victor added the comment: "Don't want to add too much noise, but this issue also affects the manylinux project build compiler (gcc 4.8.2)." Can you elaborate on these issues? Are you getting the same errors than the error described in the initial message with GCC 4.2? If not, you may

[issue28092] Build failure for 3.6 on Centos 5.11

Nathaniel Smith added the comment: @rgbecker: Are you able to pull out the config.log generated by running python's ./configure script, and post that somewhere? -- ___ Python tracker

[issue28092] Build failure for 3.6 on Centos 5.11

Robin Becker added the comment: I executed gcc --version ( --version) in the do_cpython_build function immediately prior to the make -j2 that builds python noth show 4.8.2. I see the exact same errors as in the initial report. If the makefile or the configure is doing something special then I

[issue28092] Build failure for 3.6 on Centos 5.11

Changes by thewtex : -- nosy: +thewtex ___ Python tracker ___ ___ Python-bugs-list

[issue28092] Build failure for 3.6 on Centos 5.11

Nathaniel Smith added the comment: > Would it be possible to upgrade the "manylinux" compiler (take a more recent > GCC version)? No, it's possible :-(. 4.8.2 is the very most modern version of GCC you can use if you want to build binaries to run on CentOS/RHEL 5. (And "binaries should run

[issue28092] Build failure for 3.6 on Centos 5.11

STINNER Victor added the comment: > Don't want to add too much noise, but this issue also affects the manylinux > project build compiler (gcc 4.8.2). Would it be possible to upgrade the "manylinux" compiler (take a more recent GCC version)? -- ___

[issue28092] Build failure for 3.6 on Centos 5.11

Robin Becker added the comment: Don't want to add too much noise, but this issue also affects the manylinux project build compiler (gcc 4.8.2). -- nosy: +rgbecker ___ Python tracker

[issue28092] Build failure for 3.6 on Centos 5.11

Martin Panter added the comment: For replacing macros, I think “static inline” may be fine, even with older compilers. Maybe these PyDTrace_ functions could also be static inline, since they were originally macros. Or do they really need to be linkable inline functions? --

[issue28092] Build failure for 3.6 on Centos 5.11

Benjamin Peterson added the comment: On Mon, Sep 12, 2016, at 10:34, Łukasz Langa wrote: > > Łukasz Langa added the comment: > > Benjamin, what's the rationale behind switching those to inline > functions? Does it improve runtime performance or build speed? If not, I > don't understand why the

[issue28092] Build failure for 3.6 on Centos 5.11

Ned Deily added the comment: [discussion with Steven about compiler versions taken off-list] -- ___ Python tracker ___

[issue28092] Build failure for 3.6 on Centos 5.11

Steven D'Aprano added the comment: Ned, I know my system is old so I understand if 3.6 no longer supports gcc 4.1. Tell me what minimum version I should use (4.8?) and I'll find a way to upgrade or use another system. Shouldn't the build system explicitly report that the compiler is too old,

[issue28092] Build failure for 3.6 on Centos 5.11

STINNER Victor added the comment: For the specific case of Dtrace, #define are just fine. But for unicodeobject.h, it would be nice to be able to use inline functions. -- ___ Python tracker

[issue28092] Build failure for 3.6 on Centos 5.11

Łukasz Langa added the comment: Benjamin, what's the rationale behind switching those to inline functions? Does it improve runtime performance or build speed? If not, I don't understand why the additional complexity. -- ___ Python tracker

[issue28092] Build failure for 3.6 on Centos 5.11

STINNER Victor added the comment: I created the issue #28099 "Drop Mac OS X Tiger support in Python 3.6. -- nosy: +haypo ___ Python tracker ___

[issue28092] Build failure for 3.6 on Centos 5.11

Ned Deily added the comment: Thanks for the info, Nick. With that in mind, I"m removing this as a "release blocker" for now. Steven, would it be possible to upgrade gcc on your system? We'll have to deal with the Tiger buildbot separately. -- priority: release blocker ->

[issue28092] Build failure for 3.6 on Centos 5.11

Nick Coghlan added the comment: While manylinux1 requires that compliant binaries *run* when linked against the GCC 4.2 binaries, the actual recommended compiler version (and the one used in the reference Docker image) is 4.8.2:

[issue28092] Build failure for 3.6 on Centos 5.11

Ned Deily added the comment: Do we know for sure that the manylinux1 builds are affected by this, i.e. can someone try building manylinux1 for 3.6? On the one hand, it is clear that many core developers would like to use these newer features of C, features that have been available for many

[issue28092] Build failure for 3.6 on Centos 5.11

Wolfgang Langner added the comment: This can be related to building manylinux1 binaries where the Centos 5.11 is used. There can be a possibility to break manaylinux1 builds for Python 3.6, they are used to distribute packages for every Linux distribution.

[issue28092] Build failure for 3.6 on Centos 5.11

Benjamin Peterson added the comment: GCC 4.3 was released in March 2008, so I think we are within our rights to drop support for older toolchains. -- ___ Python tracker

[issue28092] Build failure for 3.6 on Centos 5.11

Martin Panter added the comment: Benjamin changed PEP 7 to allow static inline functions directly in Python 3.6. But later he added program-wide, linkable inline functions in the Python 3.6 code: 2f77a9f0b9d6: add plain “inline” to header file 63ae310b60ff: add “extern inline” stubs in a new

[issue28092] Build failure for 3.6 on Centos 5.11

Changes by R. David Murray : -- nosy: +lukasz.langa ___ Python tracker ___ ___

[issue28092] Build failure for 3.6 on Centos 5.11

Ned Deily added the comment: (The OS X Tiger buildbot uses a version of GCC 4.0.) -- ___ Python tracker ___

[issue28092] Build failure for 3.6 on Centos 5.11

Martin Panter added the comment: This is like the OS X Tiger buildbot failure. http://buildbot.python.org/all/builders/x86%20Tiger%203.x/builds/11323/steps/compile/logs/stdio /usr/bin/ld: multiple definitions of symbol _PyDTrace_FUNCTION_ENTRY Python/ceval.o definition of

[issue28092] Build failure for 3.6 on Centos 5.11

New submission from Steven D'Aprano: On Centos 5.11, building fails with: Python/dtrace_stubs.o: In function `PyDTrace_LINE': /home/steve/python/python-dev/cpython/Include/pydtrace.h:28: multiple definition of `PyDTrace_LINE'