Changes by Neil Girdhar mistersh...@gmail.com:
Added file: http://bugs.python.org/file37821/starunpack14.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2292
___
Changes by Neil Girdhar mistersh...@gmail.com:
Removed file: http://bugs.python.org/file37817/starunpack14.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2292
___
Steve Dower added the comment:
That change modified pythoncore, so I'd expect to see most projects rebuild.
Especially under Release, where we don't have some of the build optimizations
enabled (because they hurt runtime performance).
--
___
Python
Neil Girdhar added the comment:
By the way, Joshua if you wanted to edit the text of the PEP, it might be nice
to point out that this replaces itertools.chain.from_iterable. I know you
mention one use of itertools.chain, but I think this nicely replaces all uses
of both:
itertools.chain(a,
Joshua Landau added the comment:
I've looked at BUILD_MAP(n). It seems to work and has speed improvements but:
- I was wrong about the 16-bit int thing. It turns out CPython is happily
treating them as 32 bit as long as they are prefixed by an EXTENDED_ARG bytecode
aruseni added the comment:
@Eric You’re right. I thought it should be «was» instead of «is», but it’s
actually OK.
--
resolution: - not a bug
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23294
New submission from Guohua Ouyang:
Following the issue 7776, there is a patch for 2.7 version.
Which changes the method of class HTTPConnection from _set_hostport to
_get_hostport[1], it seems introduce in some incompatibility issues.
On my system, the file
Martijn Pieters added the comment:
Indeed, the 2.7 backport was not correctly applied for _elementtree.c, leaving
files open because the close_source flag is set to False *again* when opening a
filename.
Should a new issue be opened or should this ticket be re-opened?
--
nosy:
STINNER Victor added the comment:
test_asyncio hangs on AMD64 Windows7 SP1 3.x buildbot:
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/5562
The most significant change of this build is the changeset d3804307cce4:
IocpProactor.close() must not cancel pending
STINNER Victor added the comment:
A different hang on AMD64 Windows7 SP1 3.4/ buildbot:
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.4/builds/805/steps/test/logs/stdio
This build is also related to the changeset
d3804307cce44f7f02e38166daf6d8227aa45021:
Changes by STINNER Victor victor.stin...@gmail.com:
--
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23295
___
___
Neil Girdhar added the comment:
BUILD_MAP(n)
--
Added file: http://bugs.python.org/file37817/starunpack14.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2292
___
Roundup Robot added the comment:
New changeset d3a27a27e008 by Victor Stinner in branch '3.4':
Issue #23009: Skip test_selectors.test_empty_select() on Windows
https://hg.python.org/cpython/rev/d3a27a27e008
--
___
Python tracker
STINNER Victor added the comment:
I don't understand why do you consider that this issue is a bug. Can you show
an example where detect_encoding() raises an exception?
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 4f928c70f135 by Victor Stinner in branch '3.4':
Issue #23009: Add missing import sys in test_selectors
https://hg.python.org/cpython/rev/4f928c70f135
--
___
Python tracker rep...@bugs.python.org
New submission from Liang Zhang:
This was copied from Chapter 5 Data Structure in Python language tutorial.
The link I was looking for:
https://docs.python.org/2.7/tutorial/datastructures.html
Some thing might be incorrect and need you to update them in
(5.1.4. List Comprehensions)
It
Claudiu Popa added the comment:
Ups, the last patch included an extra file.
--
Added file: http://bugs.python.org/file37819/issue21518_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21518
Changes by Claudiu Popa pcmantic...@gmail.com:
Added file: http://bugs.python.org/file37820/issue21518_4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21518
___
Claudiu Popa added the comment:
Here's a patch which does this. One problem could be that
staticmethod(some_callable) or classmethod(some_callable) aren't callable per
se, but given the fact that users expects Foo.staticmethod or Foo.klassmethod
to be callable when patching them, it's
Alessio added the comment:
Not working patch, if I use this method on append I've all messages with 1970
year
--
nosy: +Pilessio
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11024
___
Berker Peksag added the comment:
Should a new issue be opened or should this ticket be re-opened?
It's a 3 years old backport, I'd say open a new issue.
--
nosy: +berker.peksag
___
Python tracker rep...@bugs.python.org
Demian Brecht added the comment:
@Senthil: If you're fixing this today, can you also correct the typo here:
https://hg.python.org/cpython/rev/568041fd8090/#l1.27 (s/HTML/HTTP)? Just
caught my eye going through the review that Mark linked.
--
nosy: +demian.brecht
Senthil Kumaran added the comment:
Demian, sure, will do.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23300
___
___
Python-bugs-list mailing
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: -giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2292
___
___
R. David Murray added the comment:
This is a duplicate of issue 20923, which was rejected. To argue against the
rejection you probably need to provide evidence that this is something that is
actually supported by other common ini parsers. And that evidence should be
posted to issue 20923.
R. David Murray added the comment:
vec has not been changed. The example is correct. Give it a try :)
--
nosy: +r.david.murray
resolution: - not a bug
stage: - resolved
status: open - closed
type: resource usage - behavior
___
Python tracker
New submission from Sebastian Bank:
ConfigParser parses section lines containing square brackets like '[spam [eggs]
spam]' up to the first instead of the last occurrence of ']' preventing
roundtrips:
s = StringIO()
c1 = ConfigParser()
c1.add_section('spam [eggs]')
c1.write(s)
s.seek(0)
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +berker.peksag
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21862
___
New submission from STINNER Victor:
test_license_exists_at_url() of test_site fails on x86 XP-4 3.4 buildbot. I
don't understand why the test pass on x86 XP-4 3.x, is it the same server?
http://buildbot.python.org/all/builders/x86%20XP-4%203.4/builds/747/steps/test/logs/stdio
STINNER Victor added the comment:
The URL is http://www.python.org/psf/license/
wget tells me that the URL is directed to https://www.python.org/psf/license/
which is redirected to https://docs.python.org/license.html which is redirected
to https://docs.python.org/2/license.html.
According
New submission from CliffM:
calendar.py ( lines 17,18 ) is not used :
# Exception raised for bad input (with string parameter for details)
error = ValueError
This could either be deleted OR used as the superclass in the next two class
declarations as the comment suggests.
--
Joshua Landau added the comment:
Why would that simplify things?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2292
___
___
Python-bugs-list
Neil Girdhar added the comment:
Sorry, I don't know enough about how you were planning on using the stack
pointer difference to produce good errors. I thought that if you waited for
the CALL_FUNCTION to be happening before reporting errors about duplicate
parameters it might simplify that
Changes by SilentGhost ghost@gmail.com:
--
keywords: +easy
versions: +Python 3.5 -Python 3.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23304
___
Joshua Landau added the comment:
I phrased that badly. Whilst I can see minor simplifications to
BUILD_MAP_UNPACK, the only way to add more information to CALL_FUNCTION_XXX
would be through EXTENDED_ARG. This seems like it would outweigh any benefits,
and the tiny duplication of error
STINNER Victor added the comment:
Currently test_largefile is failing on the Windows buildbots
Oh yes, I just noticed the following bug on AMD64 Windows8 3.x:
http://buildbot.python.org/all/builders/AMD64%20Windows8%203.x/builds/307/steps/test/logs/stdio
[352/391/1] test_largefile
Assertion
Berker Peksag added the comment:
Here's a doc patch.
--
nosy: +berker.peksag
Added file: http://bugs.python.org/file37824/issue5309-doc.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5309
Neil Girdhar added the comment:
In that case, another option would be to use that to send the number of maps
to CALL_FUNCTION and let it do the BUILD_MAP_UNPACK stuff itself. Would that
simplify your ideas regarding error handling?
--
___
Python
Roundup Robot added the comment:
New changeset 1e3a1af0705f by Victor Stinner in branch '3.4':
Issue #23293, asyncio: Rewrite IocpProactor.connect_pipe()
https://hg.python.org/cpython/rev/1e3a1af0705f
--
nosy: +python-dev
___
Python tracker
STINNER Victor added the comment:
Issue fixed: IocpProactor.connect_pipe() doesn't use blocking operations
anymore, it's now implemented as polling with non blocking operations.
--
resolution: - fixed
status: open - closed
___
Python tracker
Brett Cannon added the comment:
That leading underscore in the method name means it is not a public API and
thus changes are allowed without any backwards-compatibility guarantees.
Mercurial will need to update their code to handle this if they want to
continue to use the method.
--
Changes by R. David Murray rdmur...@bitdance.com:
--
versions: -Python 2.7, Python 3.2, Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23298
___
R. David Murray added the comment:
Well, it doesn't make much sense in the English language sense. If I got that
error message I'd have no idea what was wrong.
It sounds like what you want to do is dynamically make some arguments be
required, depending on whether or not other arguments are
Joshua Landau added the comment:
We wouldn't actually need to raise it from somewhere else; the line numbering
and frame are already correct. The only difficulty is that the traceback
currently says
# func(a=1, **{'a': 1})
TypeError: func() got multiple values for keyword argument
Joshua Landau added the comment:
The function object that's on the stack.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2292
___
___
Neil Girdhar added the comment:
when does that get pushed on the stack?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2292
___
___
Joshua Landau added the comment:
Just before any arguments to the function.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2292
___
___
Joshua Landau added the comment:
No, that happens in CALL_FUNCTION_KW:
import dis
dis.dis(f(x=1, **{'x': 1}))
1 0 LOAD_NAME0 (f)
3 LOAD_CONST 0 ('x')
6 LOAD_CONST 1 (1)
9 LOAD_CONST
Neil Girdhar added the comment:
Oh, thanks I see, by the LOAD_BUILD_CLASS or VISIT(c, expr, e-v.Call.func)
?
Ok, I see. Why do the errors work now for f(x=1, **{'x': 2}) — these are
happening at BUILD_MAP_UNPACK without a stack pointer adjustment. For me, the
error message mentions 'f'
Demian Brecht added the comment:
I'm not opposed to that either. The only downside really (at least as far as
I'm aware) is the potential substantial influx of packets should an iterable
comprised of small chunks of data be passed in as the body, although I would
consider that quite a strange
Joshua Landau added the comment:
I imagine it like (in the map unpacking code)
func_offset = (oparg 8) 0xFF;
num_maps = oparg 0xFF;
// later
if (func_offset) {
// do checks
if (repeated_argument) {
raise_error_from_function(PEEK(func_offset +
Charles-François Natali added the comment:
Or we should acknowledge that this is overkill, and take the same approach as
all major web browser: disable the Nagle algorithm.
For a protocol like http which is transaction oriented it's probably the best
thing to do.
--
nosy: +neologix,
Neil Girdhar added the comment:
That's true. But wouldn't the offset always be one (or three or whatever)
since if we do BUILD_MAP_UNPACK in a function call it's always right before
CALL_FUNCTION?
--
___
Python tracker rep...@bugs.python.org
Neil Girdhar added the comment:
Okay, I didn't realize it was so simple to raise the error from somewhere else.
Regarding duplicate the (large) dictionary merging function — of course we
would just factor it out into a function.
--
___
Python
Charles-François Natali added the comment:
Interestingly, there is no close() method on SimpleQueue...
--
nosy: +neologix
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23267
___
Mark Grandi added the comment:
I Attempted to modify Reg2Py and Py2Reg to handle the QWORDs, this is assuming
that the only thing that needs to change is just using
PyLong_AsUnsignedLongLong()/FromUnsignedLongLong() instead of just
UnsignedLong()
the patch has the same changes as the 'part1'
Eric V. Smith added the comment:
No problem! Thanks for looking at the documentation with an inquisitive eye.
--
stage: - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23294
___
Antoine Pitrou added the comment:
Thanks. Now it needs someone to submit a patch.
--
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20188
___
Joshua Landau added the comment:
The stack will have the function, then any number of positional arguments, then
optionally an *args, then any number (= 2) of maps to unpack. To get to the
function, you need to know the sum count of all of these.
--
Neil Girdhar added the comment:
What do you mean by the stack will have the function? At the point that
you're doing BUILD_MAP_UNPACK, CALL_FUNCTION hasn't been executed…
--
___
Python tracker rep...@bugs.python.org
Nikolaus Rath added the comment:
Serhiy, did you add me to Cc just for information, or is there anything I
should be doing (having written the patch that introduced this bug)?
--
___
Python tracker rep...@bugs.python.org
STINNER Victor added the comment:
See also https://code.google.com/p/tulip/issues/detail?id=187
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23295
___
STINNER Victor added the comment:
Running runtests.py test_cancel_post_init test_shell and runtests.py
test_wait_for_handle test_wait_for_handle_cancel of Tulip show a different
behaviour of _WaitHandleFuture. In one case, the cancelled wait is still
signaled, on other case, it's never
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
assignee: - rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23282
___
___
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
assignee: - rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23290
___
___
Senthil Kumaran added the comment:
Nikolaus, nothing might be required from your end. Just a good protocol to keep
the interested parties in CC.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23300
Liang Zhang added the comment:
Oh my god! You're right!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23299
___
___
Python-bugs-list mailing
Changes by era era+pyt...@iki.fi:
--
nosy: +era
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17254
___
___
Python-bugs-list mailing list
Neil Girdhar added the comment:
Ah, sorry, yes, this is what I meant (and I see what your'e trying to fix now!):
import dis
def f(x,y): pass
...
dis.dis(f(y=1, **{'x': 1}, x=2))
1 0 LOAD_NAME0 (f)
3 LOAD_CONST 0 ('y')
6
Neil Girdhar added the comment:
I was also thinking of unifying it all, but I couldn't find a way to ensure
that the most common case (which I assume is f(x, y, z=0, w=0, *args,
**kwargs)) produces no additional opcodes. If you have a nice unification, I
look forward to it.
--
New submission from Demian Brecht:
There are a couple of small issues with the determination of whether or not a
request can fit in a single TCP/IP packet in http.client.
1. The MSS is hardcoded
2. The TCP data size is calculated as only the message body. This is incorrect
as the size of the
Berker Peksag added the comment:
Looks like b6ea3dc89a78 is not a valid changeset. Could you attach a patch from
the Mercurial repo?
--
nosy: +berker.peksag
versions: -Python 2.7
___
Python tracker rep...@bugs.python.org
Cory Benfield added the comment:
Updating to note that OpenSSL 1.0.2 has been released[0], which makes this
feature supportable.
[0]: https://mta.openssl.org/pipermail/openssl-announce/2015-January/19.html
--
___
Python tracker
Changes by Claudiu Popa pcmantic...@gmail.com:
Added file: http://bugs.python.org/file37823/issue23078.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23078
___
Claudiu Popa added the comment:
Ups, sorry about that, I'll update the patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23078
___
___
Changes by Demian Brecht demianbre...@gmail.com:
--
components: +Library (Lib)
keywords: +patch
versions: +Python 3.5
Added file: http://bugs.python.org/file37822/issue23302.patch
___
Python tracker rep...@bugs.python.org
Mark Lawrence added the comment:
This is a bug first reported here
https://mail.python.org/pipermail/python-list/2015-January/697228.html. The
problem is that in #7776 r90728 568041fd8090 _set_hostport was renamed to
_get_hostport but there is still a call to the former at line 1132 in
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +nikratio, serhiy.storchaka
stage: - needs patch
title: An improper change in httplib.py - httplib is using a method that
doesn't exist
type: enhancement - behavior
___
Python tracker
Senthil Kumaran added the comment:
Ouch. Will fix this today. Strange, I think, no coverage exists for that and it
has escaped our testing.
--
assignee: - orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23300
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23302
___
___
Python-bugs-list
Benjamin Peterson added the comment:
There's definitely a bug because httplib is now using a method that doesn't
exist.
--
nosy: +benjamin.peterson, orsenthil
resolution: wont fix -
status: closed - open
___
Python tracker rep...@bugs.python.org
Demian Brecht added the comment:
I've attached a new patch disabling Nagle by default, but doing so in connect()
as to allow users to override it if they really want to. I've also removed the
use of mss in HTTPConnection. This is a backwards incompatible change in two
ways:
1. Removing mss
82 matches
Mail list logo
