Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-18 Thread Terry Reedy
On 6/18/2018 2:37 PM, Brett Cannon wrote: On Mon, 18 Jun 2018 at 11:17 Antoine Pitrou > wrote: Le 14/06/2018 à 04:30, Terry Reedy a écrit : > On 6/13/2018 7:03 PM, Carol Willing wrote: >> +1 With Victor's mentoring (1 or 2 months), I believe that it

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-18 Thread Antoine Pitrou
Thanks for correcting me. (by the way I'm 8th in that list... Serhiy is 2nd, not me ;-)) Regards Antoine. Le 18/06/2018 à 20:37, Brett Cannon a écrit : > > > On Mon, 18 Jun 2018 at 11:17 Antoine Pitrou > wrote: > > > Le 14/06/2018 à 04:30, Terry Reedy a

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-18 Thread Brett Cannon
On Mon, 18 Jun 2018 at 11:17 Antoine Pitrou wrote: > > Le 14/06/2018 à 04:30, Terry Reedy a écrit : > > On 6/13/2018 7:03 PM, Carol Willing wrote: > >> +1 With Victor's mentoring (1 or 2 months), I believe that it is > >> reasonable to promote Pablo to a core developer either now or after 3 > >>

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-18 Thread Antoine Pitrou
Le 14/06/2018 à 19:25, Gregory P. Smith a écrit : > Quick response: > > +0.5 > > But Pablo shows drive and desire to do good things and an > ability to eventually do it even if there are learning bumps along the > way. This is my impression as well, having interacted with Pablo on a single PR

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-18 Thread Antoine Pitrou
Le 14/06/2018 à 04:30, Terry Reedy a écrit : > On 6/13/2018 7:03 PM, Carol Willing wrote: >> +1 With Victor's mentoring (1 or 2 months), I believe that it is >> reasonable to promote Pablo to a core developer either now or after 3 >> months of coaching. >> >> I would also like to see Cheryl

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-15 Thread Serhiy Storchaka
13.06.18 23:46, Victor Stinner пише: It's not like Pablo proposed the idea himself and force to get this feature merged. Pablo just implemented an idea proposed by two other core developers. It looks like Pablo implements ideas for which he does not fully understand the consequences and the

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-14 Thread Brett Cannon
I just wanted to say I agree with everything Eric said, for +1 from me. On Thu, Jun 14, 2018, 14:34 Eric Snow, wrote: > On Wed, Jun 13, 2018 at 10:16 AM Victor Stinner > wrote: > > I propose to promote Pablo Salingo Salgado as a core developer and so > > open a vote during one week. If there

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-14 Thread Eric Snow
On Wed, Jun 13, 2018 at 10:16 AM Victor Stinner wrote: > I propose to promote Pablo Salingo Salgado as a core developer and so > open a vote during one week. If there is no strong opposition, I will > promote him but also continue to mentor him for a least one month. > > [snip] > > I am mentoring

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-14 Thread Gregory P. Smith
Quick response: +0.5 My first reaction was "really?" given the amount of iteration required due to lack of CPython extension module API experience demonstrated in the os.posix_spawn PRs. (I am not surprised to see Serhiy's negative reaction) But Pablo shows drive and desire to do good things

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-14 Thread Victor Stinner
Oh, I forgot to mention that Pablo is already helping me on triagging buildbot failures since 1 month.See my email to python-dev for the context: "[Python-Dev] How to watch buildbots?" https://mail.python.org/pipermail/python-dev/2018-May/153754.html You can see his emails on the buildbot-status

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-14 Thread Berker Peksağ
On Thu, Jun 14, 2018 at 11:46 AM, Victor Stinner wrote: > 2018-06-14 0:26 GMT+02:00 Berker Peksağ : >> I don't care about total number of commits to be honest. It's not so >> hard to get 50 PRs merged into master in a month or so. > > Wait, what? No developer got more than 50 commits merged into

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-14 Thread Victor Stinner
2018-06-14 0:26 GMT+02:00 Berker Peksağ : > I don't care about total number of commits to be honest. It's not so > hard to get 50 PRs merged into master in a month or so. Wait, what? No developer got more than 50 commits merged into master in less than one month. Stats between May, 1st and today

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-13 Thread Carol Willing
> On Jun 13, 2018, at 7:30 PM, Terry Reedy wrote: > > On 6/13/2018 7:03 PM, Carol Willing wrote: >> +1 With Victor's mentoring (1 or 2 months), I believe that it is reasonable >> to promote Pablo to a core developer either now or after 3 months of >> coaching. >> I would also like to see

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-13 Thread Terry Reedy
On 6/13/2018 7:03 PM, Carol Willing wrote: +1 With Victor's mentoring (1 or 2 months), I believe that it is reasonable to promote Pablo to a core developer either now or after 3 months of coaching. I would also like to see Cheryl Sabella who has been very active on the bug tracker to also be

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-13 Thread Carol Willing
+1 With Victor's mentoring (1 or 2 months), I believe that it is reasonable to promote Pablo to a core developer either now or after 3 months of coaching. I would also like to see Cheryl Sabella who has been very active on the bug tracker to also be promoted to a core developer as well as Emily

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-13 Thread Berker Peksağ
On Wed, Jun 13, 2018 at 10:38 PM, Serhiy Storchaka wrote: > I think Pablo will be good core developer and agree with the description > given by Victor. But it seems that he still needs to learn something about > what changes are good for Python. I agree with Serhiy. Count me -1 for now. I don't

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-13 Thread Victor Stinner
2018-06-13 21:38 GMT+02:00 Serhiy Storchaka : >> Pablo's merged PR: >> https://github.com/python/cpython/pulls?utf8=%E2%9C%93=is%3Aclosed+is%3Apr+author%3Apablogsal+ > > This includes closed without merging. (sorry again, bad link.) > And reverted PRs. Adding ensure_disabled() (bpo-31356) was

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-13 Thread Victor Stinner
2018-06-13 18:43 GMT+02:00 Terry Reedy : >> Pablo's merged PR: >> >> https://github.com/python/cpython/pulls?utf8=%E2%9C%93=is%3Aclosed+is%3Apr+author%3Apablogsal+ > > This includes closed without merging. > >> He got 22 commits merged into master between September 2017 and June 2018. > >

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-13 Thread Serhiy Storchaka
13.06.18 19:43, Terry Reedy пише: On 6/13/2018 12:16 PM, Victor Stinner wrote: I propose to promote Pablo Salingo Salgado as a core developer and so open a vote during one week. If there is no strong opposition, I will promote him but also continue to mentor him for a least one month. Pablo is

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-13 Thread Terry Reedy
On 6/13/2018 12:16 PM, Victor Stinner wrote: Hi, I propose to promote Pablo Salingo Salgado as a core developer and so open a vote during one week. If there is no strong opposition, I will promote him but also continue to mentor him for a least one month. Pablo is contributing frequently to

[python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-13 Thread Victor Stinner
Hi, I propose to promote Pablo Salingo Salgado as a core developer and so open a vote during one week. If there is no strong opposition, I will promote him but also continue to mentor him for a least one month. Pablo is contributing frequently to Python since almost one year. He added