Re: Draft: Macros to tell what Python versions to package for

2018-03-02 Thread Jason L Tibbitts III
> "MH" == Miro Hrončok writes: MH> I expect it to be called for both 2 and 3 unconditionally. Hiding MH> the condition in the maro makes things too magical for me. I don't think that stance holds up well as we increasingly hide things in macros and will continue to hide

Re: Draft: Macros to tell what Python versions to package for

2018-03-02 Thread Jason L Tibbitts III
> "PV" == Petr Viktorin writes: PV> %install PV> %install PV> %if %{with python2} PV> %py2_install PV> %endif PV> %if %{with python3} PV> %py3_install PV> %endif So... why not just make %py2_install and %py3_install just do the %{with python*} internally, so the

Re: Draft: Macros to tell what Python versions to package for

2018-03-02 Thread Miro Hrončok
On 2.3.2018 16:23, Richard W.M. Jones wrote: On Fri, Mar 02, 2018 at 10:36:36AM +0100, Miro Hrončok wrote: Hello Pythonistas, I've prepared a draft for Python packaging that introduces some new macros that should ease packaging for Fedoras, EPELs and even potential new RHELs, when it comes to

Re: Draft: Macros to tell what Python versions to package for

2018-03-02 Thread Miro Hrončok
On 2.3.2018 11:54, Petr Viktorin wrote: I like to use bconds, i.e. "%if %{with python2}". They're easy to override for local builds, allowing easy experimentation with, for example, dropping Python 2. I'd be happy if our official recommendation used bconds. If we want people to copy-paste

Re: Draft: Macros to tell what Python versions to package for

2018-03-02 Thread Miro Hrončok
On 2.3.2018 11:50, Pavel Raiskup wrote: On Friday, March 2, 2018 11:32:40 AM CET Miro Hrončok wrote: On 2.3.2018 11:25, Pavel Raiskup wrote: On Friday, March 2, 2018 10:36:36 AM CET Miro Hrončok wrote: I've prepared a draft for Python packaging that introduces some new macros that should ease

Re: Draft: Macros to tell what Python versions to package for

2018-03-02 Thread Petr Viktorin
I like to use bconds, i.e. "%if %{with python2}". They're easy to override for local builds, allowing easy experimentation with, for example, dropping Python 2. I'd be happy if our official recommendation used bconds. If we want people to copy-paste something, let's make it good. Also,

Re: Draft: Macros to tell what Python versions to package for

2018-03-02 Thread Miro Hrončok
On 2.3.2018 11:25, Pavel Raiskup wrote: On Friday, March 2, 2018 10:36:36 AM CET Miro Hrončok wrote: I've prepared a draft for Python packaging that introduces some new macros that should ease packaging for Fedoras, EPELs and even potential new RHELs, when it comes to python stacks. I don't do

Draft: Macros to tell what Python versions to package for

2018-03-02 Thread Miro Hrončok
Hello Pythonistas, I've prepared a draft for Python packaging that introduces some new macros that should ease packaging for Fedoras, EPELs and even potential new RHELs, when it comes to python stacks. I don't do much ifs in specfiles and prefer to leverage git branches for this, so I don't