[Pywikipedia-bugs] [Maniphest] [Created] T101829: make pwb.py cwd-insensitive

2015-06-09 Thread valhallasw
valhallasw created this task. valhallasw added a subscriber: valhallasw. valhallasw added a project: pywikibot-core. Restricted Application added subscribers: Aklapper, pywikibot-bugs. TASK DESCRIPTION ``` (pywikibot)valhallasw@tools-bastion-01:~/pywikibot$ /shared/pywikipedia/core/pwb.py

[Pywikipedia-bugs] [Maniphest] [Created] T103069: requests version on labs fails with (x, y) timeout argument

2015-06-19 Thread valhallasw
valhallasw created this task. valhallasw added a subscriber: valhallasw. valhallasw added a project: pywikibot-core. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION This happens both on precise and trusty. ``` ERROR: Traceback (most recent call last): File

[Pywikipedia-bugs] [Maniphest] [Commented On] T100265: category.py: implement collation-aware sorting

2015-06-11 Thread valhallasw
valhallasw added a comment. Rough implementation on the sorting end: import icu locale = icu.Locale(cs_CZ) locale.getDisplayName() u'Czech (Czech Republic)' collator = icu.Collator.createInstance(locale) list = [[Kategorie:Česko]] ... [[Kategorie:Čeština

[Pywikipedia-bugs] [Maniphest] [Commented On] T100264: Cosmetic changes: sort template parameters

2015-06-11 Thread valhallasw
valhallasw added a comment. @Danny_B: as far as I can see, _cswiktionary_preklady_sort.py already implements this? I also don't immediately see any existing sort in cosmetic_changes.py, so I'm not entirely sure anymore what the issue was here... TASK DETAIL https://phabricator.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Updated] T102174: Add support for translated dates/times

2015-06-11 Thread valhallasw
valhallasw added a project: pywikibot-core. Restricted Application added a subscriber: pywikibot-bugs-list. TASK DETAIL https://phabricator.wikimedia.org/T102174 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: pywikibot-bugs-list

[Pywikipedia-bugs] [Maniphest] [Commented On] T100265: category.py: implement collation-aware sorting

2015-06-11 Thread valhallasw
valhallasw added a comment. But I'm confused by this one as well. As far as I can see, category.py doesn't sort at all...? it just adds sort keys for MW, as far as I can see. TASK DETAIL https://phabricator.wikimedia.org/T100265 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Pywikipedia-bugs] [Maniphest] [Commented On] T102462: [break] request library isn't stable

2015-06-15 Thread valhallasw
valhallasw added a subscriber: valhallasw. valhallasw added a comment. I haven't checked our code for details, but based on the lack of response to ctrl-c, I'm guessing this is a blocking wait() without timeout. Googling shows that requests doesn't set a timeout by default, so that's consistent

[Pywikipedia-bugs] [Maniphest] [Commented On] T102462: [break] request library isn't stable

2015-06-15 Thread valhallasw
valhallasw added a comment. Is this on tool labs, and is one of these processes still running? Then I can take a look to check in detail. TASK DETAIL https://phabricator.wikimedia.org/T102462 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Pywikipedia-bugs] [Maniphest] [Commented On] T102462: [break] request library isn't stable

2015-06-15 Thread valhallasw
valhallasw added a comment. And, looking at our code, we indeed do not set a timeout: https://github.com/wikimedia/pywikibot-core/blob/master/pywikibot/comms/http.py#L249 Even if that's not the root cause, setting it sounds like a sane plan. TASK DETAIL https://phabricator.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Created] T104809: impossible to respond to captchas when using put_async

2015-07-05 Thread valhallasw
valhallasw created this task. valhallasw added a subscriber: valhallasw. valhallasw added a project: pywikibot-core. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION Because the put happens in a different thread, the message will be printed, but the response

[Pywikipedia-bugs] [Maniphest] [Closed] T102314: google package problems

2015-07-03 Thread valhallasw
valhallasw closed this task as Resolved. valhallasw claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T102314 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: valhallasw, gerritbot, Aklapper, jayvdb, pywikibot-bugs-list

[Pywikipedia-bugs] [Maniphest] [Up For Grabs] T102314: google package problems

2015-07-02 Thread valhallasw
valhallasw placed this task up for grabs. valhallasw added a subscriber: valhallasw. TASK DETAIL https://phabricator.wikimedia.org/T102314 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: valhallasw, gerritbot, Aklapper, jayvdb

[Pywikipedia-bugs] [Maniphest] [Commented On] T109210: [RFC] featured.py is outdated for wm projects

2015-08-16 Thread valhallasw
valhallasw added a comment. We can import the bot to bots/misc including history (takes a bit of git magic, but it's not impossible). Changing it in such a way that it keeps wikidata up to date also makes sense. TASK DETAIL https://phabricator.wikimedia.org/T109210 EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Commented On] T109208: [RFC] considering step parameter on several site methods

2015-08-16 Thread valhallasw
valhallasw added a comment. I'd be OK with removing the parameter altogether. The only useful parameter would be 'this is the amount of results I expect to process'. If I'm only interested in the first (or the first five) results, there is no need to get 50. If I'm interested in all results

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T93474: input encoding is switched to plain ascii when redirecting output to a file or other commands, mangling non-ascii characters

2015-08-01 Thread valhallasw
valhallasw added a subscriber: Vituzzu. valhallasw merged a task: T107512: weird behavior of listpages.py. TASK DETAIL https://phabricator.wikimedia.org/T93474 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: Vituzzu, elyashiv

[Pywikipedia-bugs] [Maniphest] [Merged] T107512: weird behavior of listpages.py

2015-08-01 Thread valhallasw
valhallasw closed this task as a duplicate of T93474: input encoding is switched to plain ascii when redirecting output to a file or other commands, mangling non-ascii characters. TASK DETAIL https://phabricator.wikimedia.org/T107512 EMAIL PREFERENCES https://phabricator.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T93474: input encoding is switched to plain ascii when redirecting output to a file or other commands, mangling non-ascii characters

2015-08-02 Thread valhallasw
valhallasw added subscribers: Ladsgroup, Huji. valhallasw merged a task: T107713: Encoding issue with jsub. TASK DETAIL https://phabricator.wikimedia.org/T93474 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: Huji, Ladsgroup, Vituzzu

[Pywikipedia-bugs] [Maniphest] [Retitled] T108238: Page.text does not raise exception for nonexistent pages

2015-08-06 Thread valhallasw
valhallasw changed the title from pywikibot.text does not raise exception for nonexistent pages to Page.text does not raise exception for nonexistent pages. valhallasw added a project: pywikibot-core. valhallasw set Security to None. Herald added a subscriber: pywikibot-bugs-list. TASK DETAIL

[Pywikipedia-bugs] [Maniphest] [Closed] T93474: input encoding is switched to plain ascii when redirecting output to a file or other commands, mangling non-ascii characters

2015-08-14 Thread valhallasw
valhallasw closed this task as Resolved. valhallasw claimed this task. valhallasw added a comment. We now fall back to utf-8 by default. TASK DETAIL https://phabricator.wikimedia.org/T93474 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw

[Pywikipedia-bugs] [Maniphest] [Created] T108820: data.api.Request.submit: log submitted request

2015-08-12 Thread valhallasw
valhallasw created this task. valhallasw added a subscriber: valhallasw. valhallasw added projects: pywikibot-core, Easy. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION We do log the returned data: ``` pywikibot.debug((uAPI response received from %s

[Pywikipedia-bugs] [Maniphest] [Commented On] T106311: pywikipedia.org is not responding; pywikibot.org is not registered

2015-08-10 Thread valhallasw
valhallasw added a comment. In https://phabricator.wikimedia.org/T106311#1523595, @siebrand wrote: Please make a change request without a question mark. After checking with #wikimedia-operations: the correct CNAME is wikimedia.org., so please change it to that :-) Thanks! pywikipedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T106311: pywikipedia.org down?

2015-07-23 Thread valhallasw
valhallasw added a comment. valhallasw@maeglin:operations-puppet$ nslookup production 2 set type=CNAME pywikipedia.org Server

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T106311: pywikipedia.org down?

2015-07-23 Thread valhallasw
valhallasw added a subscriber: BBlack. valhallasw added a comment. Was removed with https://github.com/wikimedia/operations-dns/commit/a782e3adcb9cdd046b9709870ad4f49dcc992890 So the cname is wrong; the question is: what should it be replaced with...? TASK DETAIL https

[Pywikipedia-bugs] [Maniphest] [Commented On] T104306: Manage Appveyor account

2015-11-08 Thread valhallasw
valhallasw added a subscriber: valhallasw. valhallasw added a comment. Pywikibot does, for running tests on Windows: https://ci.appveyor.com/project/wikimedia/pywikibot-core TASK DETAIL https://phabricator.wikimedia.org/T104306 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Pywikipedia-bugs] [Maniphest] [Created] T117570: jenkins output is unreadable

2015-11-03 Thread valhallasw
valhallasw created this task. valhallasw added a subscriber: valhallasw. valhallasw added projects: pywikibot-core, Jenkins. Herald added subscribers: pywikibot-bugs-list, StudiesWorld, Aklapper. TASK DESCRIPTION For example: https://integration.wikimedia.org/ci/job/tox-jessie/1169/console

[Pywikipedia-bugs] [Maniphest] [Commented On] T117570: jenkins output is unreadable

2015-11-03 Thread valhallasw
valhallasw added a comment. valhallasw@maeglin:pywikibot-core$ grep consoleText -P -e ':\d+:\d+:\s[A-Z]+[0-9]+' | sed -e 's:^./::' | sort | uniq pywikibot/__init__.py:469:1: E303 too many blank lines (3) tests/wikibase_tests.py:187:5: E303 too many blank lines (2) TASK DETAIL https

[Pywikipedia-bugs] [Maniphest] [Commented On] T110354: Login credentials are not kept between runs

2015-08-26 Thread valhallasw
valhallasw added a subscriber: valhallasw. valhallasw added a comment. What's the output of pwb.py version? TASK DETAIL https://phabricator.wikimedia.org/T110354 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: valhallasw, Aklapper

[Pywikipedia-bugs] [Maniphest] [Commented On] T110354: Login credentials are not kept between runs

2015-08-26 Thread valhallasw
valhallasw added a comment. What's the output of pwb.py version? TASK DETAIL https://phabricator.wikimedia.org/T110354 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: valhallasw, Aklapper, Malafaya, pywikibot-bugs-list, jayvdb

[Pywikipedia-bugs] [Maniphest] [Commented On] T110637: requests 0.8.2 does not have Session.close()

2015-08-28 Thread valhallasw
valhallasw added a comment. ...except your output shows it doesn't. Not sure why tools-precise-dev has 2.0 installed, then -- maybe WMF-packaged. TASK DETAIL https://phabricator.wikimedia.org/T110637 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Pywikipedia-bugs] [Maniphest] [Commented On] T110637: requests 0.8.2 does not have Session.close()

2015-08-28 Thread valhallasw
valhallasw added a subscriber: valhallasw. valhallasw added a comment. Requests 0.8 is ancient (2011), and the API changed regularly before 1.0. Even Ubuntu Precise bundles 2.0, so I think that would be a reasonable base version to use. TASK DETAIL https://phabricator.wikimedia.org/T110637

[Pywikipedia-bugs] [Maniphest] [Created] T111498: l10n_tests doesn't update __doc__

2015-09-04 Thread valhallasw
valhallasw created this task. valhallasw added a subscriber: valhallasw. valhallasw added projects: pywikibot-core, Pywikibot-i18n. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION https://gerrit.wikimedia.org/r/#/c/235978/ Resulting in ``` $ nosetests

[Pywikipedia-bugs] [Maniphest] [Created] T111608: wowwiki returns non-JSON api response (api help page)

2015-09-05 Thread valhallasw
valhallasw created this task. valhallasw added a subscriber: valhallasw. valhallasw added a project: pywikibot-core. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION ``` >>> import pywikibot >>> s=pywikibot.Site('en', 'wowwiki') >>> p=p

[Pywikipedia-bugs] [Maniphest] [Created] T111615: pywikibot.__all__ is unicode, causing `TypeError: Item in ``from list'' not a string`

2015-09-05 Thread valhallasw
valhallasw created this task. valhallasw added a subscriber: valhallasw. valhallasw added a project: pywikibot-core. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION ``` >>> from pywikibot import * Traceback (most recent call last): File &

[Pywikipedia-bugs] [Maniphest] [Created] T111610: page.botMayEdit() causes requests to all pages in interwiki map

2015-09-05 Thread valhallasw
valhallasw created this task. valhallasw added subscribers: valhallasw, XZise. valhallasw added a project: pywikibot-core. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION And because not all family files work correctly (T111608), this breaks editing (because page.save

[Pywikipedia-bugs] [Maniphest] [Commented On] T111608: wowwiki returns non-JSON api response (api help page)

2015-09-06 Thread valhallasw
valhallasw added a comment. I think it's because of the redirect from www.wowwiki.com to wowwiki.wikia.com... TASK DETAIL https://phabricator.wikimedia.org/T111608 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: jayvdb, Aklapper

[Pywikipedia-bugs] [Maniphest] [Unblock] T74118: Pywikibot 3.0 changes [tracking]

2015-09-06 Thread valhallasw
valhallasw closed blocking task T57192: Repetitive API userinfo queries as "Resolved". Herald added a subscriber: Aklapper. TASK DETAIL https://phabricator.wikimedia.org/T74118 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc

[Pywikipedia-bugs] [Maniphest] [Created] T112578: login.check_user_exists does not work on private wiki

2015-09-14 Thread valhallasw
valhallasw created this task. valhallasw added a subscriber: valhallasw. valhallasw added a project: pywikibot-core. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION self.check_user_exists calls self.site.allusers which requires paraminfo to be loaded. A direct

[Pywikipedia-bugs] [Maniphest] [Commented On] T114534: release 2.0rc4

2015-10-04 Thread valhallasw
valhallasw added a comment. I don't think we should introduce unicode_literals either, unless this is important for later cherry-picking (e.g. we expect to introduce code that assumes unicode_literals is used later). I'm also not sure how this relates to the patches you suggested to backport

[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T111602: Install python-enum34 on toollabs

2015-10-04 Thread valhallasw
valhallasw moved this task to Backlog on the Tool-Labs workboard. TASK DETAIL https://phabricator.wikimedia.org/T111602 WORKBOARD https://phabricator.wikimedia.org/project/board/539/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc

[Pywikipedia-bugs] [Maniphest] [Edited] T114534: release 2.0rc4

2015-10-04 Thread valhallasw
valhallasw edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T114534 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: XZise, jayvdb, Aklapper, pywikibot-bugs-list, valhallasw

[Pywikipedia-bugs] [Maniphest] [Edited] T114534: release 2.0rc4

2015-10-04 Thread valhallasw
valhallasw edited the task description. valhallasw set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T114534 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: XZise, jayvdb, Aklapper, pywikibot-bugs-list, valhallasw

[Pywikipedia-bugs] [Maniphest] [Edited] T114534: release 2.0rc4

2015-10-04 Thread valhallasw
valhallasw edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T114534 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: XZise, jayvdb, Aklapper, pywikibot-bugs-list, valhallasw

[Pywikipedia-bugs] [Maniphest] [Commented On] T114534: release 2.0rc4

2015-10-04 Thread valhallasw
valhallasw added a comment. I backported most of them, but several of them change so much stuff in different places I'm not sure if the backport is actually correct. Several of them also get -1'ed by Jenkins. I'm not going to fix those -- I feel I put in my fair share by doing the initial

[Pywikipedia-bugs] [Maniphest] [Edited] T114534: release 2.0rc4

2015-10-04 Thread valhallasw
valhallasw edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T114534 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: XZise, jayvdb, Aklapper, pywikibot-bugs-list, valhallasw

[Pywikipedia-bugs] [Maniphest] [Closed] T114420: Invalid version number (ValueError exception) for newest pypi version

2015-10-02 Thread valhallasw
valhallasw closed this task as "Resolved". valhallasw claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T114420 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: hashar, gerritbot, JeanFred, pywikibot-bugs-l

[Pywikipedia-bugs] [Maniphest] [Created] T114534: release 2.0rc4

2015-10-02 Thread valhallasw
valhallasw created this task. valhallasw added a subscriber: valhallasw. valhallasw added a project: pywikibot-core. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION Changes to backport (as compared to rc3 = 1ff1cec): [x] 1f8d57e [FIX] Stop crashing item loads due

[Pywikipedia-bugs] [Maniphest] [Updated] T114534: release 2.0rc4

2015-10-02 Thread valhallasw
valhallasw added a blocked task: T1315: Release 2.0. TASK DETAIL https://phabricator.wikimedia.org/T114534 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: Aklapper, pywikibot-bugs-list, valhallasw

[Pywikipedia-bugs] [Maniphest] [Updated] T1315: Release 2.0

2015-10-02 Thread valhallasw
valhallasw added a blocking task: T114534: release 2.0rc4. Herald added a subscriber: Aklapper. TASK DETAIL https://phabricator.wikimedia.org/T1315 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb, valhallasw Cc: Aklapper, Ricordisamoa, Xqt

[Pywikipedia-bugs] [Maniphest] [Closed] T114464: Pywikibot 2.0 should be Python 2.7, 3.3 and 3.4 only

2015-10-02 Thread valhallasw
valhallasw closed this task as "Resolved". valhallasw claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T114464 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: gerritbot, XZise, Aklapper, jayvdb, pywikibot

[Pywikipedia-bugs] [Maniphest] [Unblock] T1315: Release 2.0

2015-10-02 Thread valhallasw
valhallasw closed blocking task T76262: Release 2.0 RC1 as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T1315 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb, valhallasw Cc: Aklapper, Ricordisamoa, Xqt, jayvdb, pywikibot

[Pywikipedia-bugs] [Maniphest] [Closed] T76262: Release 2.0 RC1

2015-10-02 Thread valhallasw
valhallasw closed this task as "Resolved". valhallasw claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T76262 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: Xqt, jayvdb, Ricordisamoa, pywikibot-bugs-list,

[Pywikipedia-bugs] [Maniphest] [Updated] T114464: Pywikibot 2.0 should be Python 2.7, 3.3 and 3.4 only

2015-10-02 Thread valhallasw
valhallasw added a blocked task: T1315: Release 2.0. TASK DETAIL https://phabricator.wikimedia.org/T114464 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: gerritbot, XZise, Aklapper, jayvdb, pywikibot-bugs-list

[Pywikipedia-bugs] [Maniphest] [Edited] T114534: release 2.0rc4

2015-10-06 Thread valhallasw
valhallasw edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T114534 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: XZise, jayvdb, Aklapper, pywikibot-bugs-list, valhallasw

[Pywikipedia-bugs] [Maniphest] [Commented On] T120222: Error installing pywikibot on Windows 10 (No handlers could be found for logger "pywiki")

2015-12-08 Thread valhallasw
valhallasw added a comment. System error code 2 / The system cannot find the file specified. This is localized, so it's 'Het systeem kan het opgegeven bestand niet vinden' in Dutch and e.g. 'Le système ne trouve pas le fichier spécifié.' in French. On Python 2, that's a str encoded

[Pywikipedia-bugs] [Maniphest] [Updated] T121684: Pywikibot gives script termination on page delete

2015-12-16 Thread valhallasw
valhallasw edited projects, added pywikibot-core; removed MediaWiki-General-or-Unknown. valhallasw set Security to None. Herald added a subscriber: pywikibot-bugs-list. TASK DETAIL https://phabricator.wikimedia.org/T121684 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Pywikipedia-bugs] [Maniphest] [Commented On] T123092: mandatory dependency on bz2

2016-01-07 Thread valhallasw
valhallasw added a subscriber: valhallasw. valhallasw added a comment. I think this is a fringe case we should not put too much effort in. I would assume people who compile their own python know what they are doing, and otherwise documentation on what to do for `ImportError: No module named bz2

[Pywikipedia-bugs] [Maniphest] [Created] T122091: fixing_redirects.py / replace_links fails on links such as [[{{2001}}]]

2015-12-21 Thread valhallasw
valhallasw created this task. valhallasw added subscribers: valhallasw, Glavkos. valhallasw added projects: pywikibot-core, Pywikibot-textlib.py. Herald added subscribers: pywikibot-bugs-list, StudiesWorld, Aklapper. TASK DESCRIPTION Via IRC: ``` ERROR: InvalidTitle: u'{{2001}}' contains

[Pywikipedia-bugs] [Maniphest] [Commented On] T115929: Duplicate keys in transliteration of Cyrillic

2016-01-11 Thread valhallasw
valhallasw added a comment. re: ҿ -- that indeed looks wrong. I'm not sure why I didn't remove the entry altogether. The same is true for "Ä"->"Ä". > The ұӹ combination above was added by > https://phabricator.wikimedia.org/rPWBO172007a84109c7b1e61a0b6297

[Pywikipedia-bugs] [Maniphest] [Commented On] T137628: pyflakes-py3 and pyflakes-pypy commands failes

2016-06-11 Thread valhallasw
valhallasw added a comment.If I read the output correctly, pyflakes is parsing the entire python standard library, which of course does not follow pyflakes standardsTASK DETAILhttps://phabricator.wikimedia.org/T137628EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T125505: Tool Labs: shared Pywikibot code not available

2016-05-27 Thread valhallasw
valhallasw moved this task from Triage to Backlog on the Tool-Labs board. TASK DETAIL https://phabricator.wikimedia.org/T125505 WORKBOARD https://phabricator.wikimedia.org/project/board/539/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: scfc

[Pywikipedia-bugs] [Maniphest] [Closed] T125505: Tool Labs: shared Pywikibot code not available

2016-05-27 Thread valhallasw
valhallasw closed this task as "Resolved". valhallasw removed scfc as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T125505 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: jayvdb, Urbanecm, russb

[Pywikipedia-bugs] [Maniphest] [Commented On] T125779: pywikibot OAuth should properly handle expired tokens, instead of endless loop.

2016-02-04 Thread valhallasw
valhallasw added a comment. > Well, you cannot get an valid crsf token from an invalid oauth token. In that case, I would expect an error 'Can't retrieve CSRF token, API returned ...' rather than a badtoken error -- or more specifically: I would expect a `mwoauth-invalid-authorization` er

[Pywikipedia-bugs] [Maniphest] [Commented On] T125779: pywikibot OAuth should properly handle expired tokens, instead of endless loop.

2016-02-04 Thread valhallasw
valhallasw added a comment. Probably. Pywikibot uses the `logging` module, which you can reconfigure the logging using the standard features it provides (see the python documentation <https://docs.python.org/2/library/logging.html>), so running import logging logging.basicConfig

[Pywikipedia-bugs] [Maniphest] [Commented On] T125779: pywikibot OAuth should properly handle expired tokens, instead of endless loop.

2016-02-08 Thread valhallasw
valhallasw added a comment. > Yes. I'm not entirely sure about cookies, but from the logs it seems every > Api calls are OAuth-signed. @valhallasw you can explain this :) Well, I don't know the specific oauth implementation, but we do handle cookies as one would expect in a browser. T

[Pywikipedia-bugs] [Maniphest] [Commented On] T125779: pywikibot OAuth should properly handle expired tokens, instead of endless loop.

2016-02-04 Thread valhallasw
valhallasw added a subscriber: valhallasw. valhallasw added a comment. Why do you think this has something to do with OAuth? The log just shows pywikibot retrying after the API returns a 'badtoken' response, as it's supposed to. I'm not sure why it's continuously failing, but that might have

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T126666: pywikibot broken on wikimedia labs

2016-02-11 Thread valhallasw
valhallasw added subscribers: valhallasw, Ladsgroup. valhallasw added a comment. I manually ran the crontab, and this seems to have fixed it (at least for now). The underlying issues seems to be something like this: The code to update runs: # Current version of core cd /data/project

[Pywikipedia-bugs] [Maniphest] [Commented On] T99370: httplib2 0.6.0 is required

2016-02-13 Thread valhallasw
valhallasw added a comment. Try `pwb.py generate_user_files` ? TASK DETAIL https://phabricator.wikimedia.org/T99370 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, valhallasw Cc: MarcoAurelio, valhallasw, pywikibot-bugs-list, Xqt, Aklapper

[Pywikipedia-bugs] [Maniphest] [Commented On] T99370: httplib2 0.6.0 is required

2016-02-13 Thread valhallasw
valhallasw added a comment. Very odd. Try removing the directory and re-installing from a nightly: http://tools.wmflabs.org/pywikibot/core_stable.zip If the problem persists, please create a //new// task, and please add the output of pwb.py version therein. TASK DETAIL https

[Pywikipedia-bugs] [Maniphest] [Commented On] T126880: Error: Python module httplib2 >= 0.6.0 is required.

2016-02-13 Thread valhallasw
valhallasw added a comment. This is with 2.0rc3 downloaded from https://tools.wmflabs.org/pywikibot, correct? Which Python version are you running it on? (python --version) TASK DETAIL https://phabricator.wikimedia.org/T126880 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Pywikipedia-bugs] [Maniphest] [Updated] T126880: Error: Python module httplib2 >= 0.6.0 is required.

2016-02-13 Thread valhallasw
valhallasw added a comment. Ok, with Python 3.4.0 and 2.0rc3 I can reproduce the issue in a virtualenv. The traceback is roughly what you might expect: (venv) C:\Users\Merlijn van Deen\Downloads\core\core>python -i generate_user_files.py WARNING: Running on Wind

[Pywikipedia-bugs] [Maniphest] [Commented On] T126880: Error: Python module httplib2 >= 0.6.0 is required.

2016-02-13 Thread valhallasw
valhallasw added a comment. Mostly, you can just skip the `generate_user_files.py` step, and directly go to `python pwb.py login` (without generating a user-config.py file). That will automatically start `generate_user_files.py` for you, with the correct paths set. TASK DETAIL https

[Pywikipedia-bugs] [Maniphest] [Commented On] T125059: unexprected status 404 while using liverecentchanges

2016-01-28 Thread valhallasw
valhallasw added a comment. Seems to work for me -- maybe this is a socket.io 0.9 vs 1.0 incompatibility? I have this version installed: -e git+https://github.com/invisibleroads/socketIO-client@c1e49247178681c828a5e91134a4ace4582cca19#egg=socketIO_client-master (dixit pip freeze) TASK

[Pywikipedia-bugs] [Maniphest] [Created] T128025: 2.0 branch setup.py calls itself 2.0rc3 while it is 2.0rc4+

2016-02-24 Thread valhallasw
valhallasw created this task. Herald added subscribers: pywikibot-bugs-list, StudiesWorld, Aklapper. TASK DESCRIPTION (the version on pypi is 2.0rc4) TASK DETAIL https://phabricator.wikimedia.org/T128025 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Pywikipedia-bugs] [Maniphest] [Created] T124466: Support logging in with Special:BotPassword passwords

2016-01-22 Thread valhallasw
valhallasw created this task. valhallasw added a subscriber: valhallasw. valhallasw added a project: pywikibot-core. Herald added subscribers: pywikibot-bugs-list, StudiesWorld, Aklapper. TASK DESCRIPTION The basic machinery works (as long as you work around check_user_exists), but the login

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T124466: Support logging in with Special:BotPassword passwords

2016-01-22 Thread valhallasw
valhallasw added a subscriber: Alkamid. TASK DETAIL https://phabricator.wikimedia.org/T124466 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: Alkamid, Aklapper, StudiesWorld, valhallasw, pywikibot-bugs-list

[Pywikipedia-bugs] [Maniphest] [Commented On] T101587: Convert wiki pages for 2.0 into phabricator tasks

2016-01-24 Thread valhallasw
valhallasw added a subscriber: valhallasw. valhallasw added a comment. I removed the 'easy' tag, as I don't think this task is really suitable for new people -- it requires quite some insight into what should/shouldn't be ported. I'm also inclined to reject/resolve this task -- I think all API

[Pywikipedia-bugs] [Maniphest] [Updated] T101587: Convert wiki pages for 2.0 into phabricator tasks

2016-01-24 Thread valhallasw
valhallasw removed a project: Easy. valhallasw set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T101587 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: Rajdeep05, pywikibot-bugs-list, jayvdb, Aklapper, droid

[Pywikipedia-bugs] [Maniphest] [Updated] T121948: Pywikibot 2.0rc5

2016-02-16 Thread valhallasw
valhallasw added a subscriber: valhallasw. valhallasw added a comment. Is there anything left that needs to go into 2.0 (in other words, can we just release it as 2.0?)? https://phabricator.wikimedia.org/T72936 seems to have been re-classified as 2.1. TASK DETAIL https

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T125505: Tool Labs: shared Pywikibot code not available

2016-02-02 Thread valhallasw
valhallasw added a subscriber: Ladsgroup. valhallasw added a project: pywikibot-core. valhallasw set Security to None. Herald added a subscriber: pywikibot-bugs-list. TASK DETAIL https://phabricator.wikimedia.org/T125505 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Pywikipedia-bugs] [Maniphest] [Created] T129526: revertbot uses myRevertBot class by default, which has an odd default page filter

2016-03-10 Thread valhallasw
valhallasw created this task. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION def callback(self, item): """Callback funktion for 'private' revert bot.""" if 'top' in item: page = pywikibot.Page(self.site, i

[Pywikipedia-bugs] [Maniphest] [Commented On] T119855: Attempting to login with pwb.py results in Permission denied on Mac OS X

2016-03-07 Thread valhallasw
valhallasw added a comment. Yep, that file should be chmod 644, not 600. You can (probably) fix it by running sudo chmod 644 /Library/Python/2.7/site-packages/httplib2-0.9.2-py2.7.egg/httplib2/cacerts.txt Seems like an issue in httplib2, and I remember reporting it/finding

[Pywikipedia-bugs] [Maniphest] [Commented On] T114574: Create an alias "mul" for -lang: syntax in pywikibot

2016-03-01 Thread valhallasw
valhallasw added a comment. No, it should be reflected somewhere in the wikisource family file, where 'mul' should be an alias for '-'. I'm not entirely sure if this is supported yet -- if not, it also needs some code added in family.py to handle aliases (but in that case the tag 'easy

[Pywikipedia-bugs] [Maniphest] [Commented On] T131614: checkimages.py incorrectly casts many command line arguments to str()

2016-04-02 Thread valhallasw
valhallasw added a comment. For some reason, checkimages.py runs `str(arg[5:])`, which of course fails if `arg` is non-ascii. I'm not sure why it does that -- we can probably just remove those str()s. TASK DETAIL https://phabricator.wikimedia.org/T131614 EMAIL PREFERENCES https

[Pywikipedia-bugs] [Maniphest] [Retitled] T131614: checkimages.py incorrectly casts many command line arguments to str()

2016-04-02 Thread valhallasw
valhallasw changed the title from "-cat option fails with UnicodeDecodeError" to "checkimages.py incorrectly casts many command line arguments to str()". TASK DETAIL https://phabricator.wikimedia.org/T131614 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/pa

[Pywikipedia-bugs] [Maniphest] [Created] T132659: Conda-based packaging for Windows

2016-04-14 Thread valhallasw
valhallasw created this task. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION (not a full-featured plan yet). Currently, installing dependencies on Windows is difficult for many of our users. Conda allows for relatively easy 'virtual environments' (sort

[Pywikipedia-bugs] [Maniphest] [Commented On] T135992: manually-assisted replace.py seems throttled

2016-05-23 Thread valhallasw
valhallasw added a comment. The main background issue seems to be that `pywikibot.throttle.Throttle.__call__` 1. locks the Throttle object, 2. sleeps, 3. unlocks the Throttle object so even though the putthread is in the background, the Throttle blocks both threads. I'm

[Pywikipedia-bugs] [Maniphest] [Commented On] T135992: manually-assisted replace.py seems throttled

2016-05-23 Thread valhallasw
valhallasw added a comment. Further issue: the self.botMayEdit() template check check in page.save() is not async, and blocks in the same way as the protection request. TASK DETAIL https://phabricator.wikimedia.org/T135992 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Pywikipedia-bugs] [Maniphest] [Commented On] T125505: Tool Labs: shared Pywikibot code not available

2016-05-22 Thread valhallasw
valhallasw added a comment. I have rewritten parts of the the nightly code <https://github.com/pywikibot/Pywikibot-nightly-creator/commit/d0192941b267a98b26021d6d1d55b7c0d6e14086> to be more fault-resistant, and I hope this will solve the issues. I may have introduced other

[Pywikipedia-bugs] [Maniphest] [Commented On] T125505: Tool Labs: shared Pywikibot code not available

2016-05-22 Thread valhallasw
valhallasw added a comment. There was indeed a permissions mixup on /data/project/pywikibot/public_html, which should now also be fixed... TASK DETAIL https://phabricator.wikimedia.org/T125505 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: scfc

[Pywikipedia-bugs] [Maniphest] [Commented On] T125505: Tool Labs: shared Pywikibot code not available

2016-05-22 Thread valhallasw
valhallasw added a comment. I think the main issue is a combination of delete-then-clone plus slow NFS. It's not entirely clear to me whether the script fails halfway or whether it's just very slow. I think we should do the following: 1. clone, git gc, tar in /tmp rather than

[Pywikipedia-bugs] [Maniphest] [Created] T135984: diff view with background colors lack contrast

2016-05-23 Thread valhallasw
valhallasw created this task. Herald added subscribers: pywikibot-bugs-list, Zppix, Aklapper. TASK DESCRIPTION F4045498: pasted_file <https://phabricator.wikimedia.org/F4045498> I'm a big fan of the concept, but we should probably spend some time to figure out what the best

[Pywikipedia-bugs] [Maniphest] [Lowered Priority] T124537: revertbot doesn't write changes to server

2016-05-23 Thread valhallasw
valhallasw lowered the priority of this task from "High" to "Normal". TASK DETAIL https://phabricator.wikimedia.org/T124537 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: Wesalius, jayvdb, Aklapper, pywikibo

[Pywikipedia-bugs] [Maniphest] [Created] T135992: manually-assisted replace.py seems throttled

2016-05-23 Thread valhallasw
valhallasw created this task. Herald added subscribers: pywikibot-bugs-list, Zppix, Aklapper. TASK DESCRIPTION From the debug log, this is what seems to happen: - there is a save() background request which is throttled - this means no other requests are served - replace.py tries

[Pywikipedia-bugs] [Maniphest] [Commented On] T135992: manually-assisted replace.py seems throttled

2016-05-23 Thread valhallasw
valhallasw added a comment. 1. on itself does not seem to solve the issue. TASK DETAIL https://phabricator.wikimedia.org/T135992 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: Aklapper, Zppix, pywikibot-bugs-list, valhallasw

[Pywikipedia-bugs] [Maniphest] [Created] T134563: Implement 'mark for deletion' for ItemPage

2016-05-06 Thread valhallasw
valhallasw created this task. Herald added subscribers: pywikibot-bugs-list, Zppix, Aklapper. TASK DESCRIPTION Currently, this throws an unclear error message Can't delete [[en:Item:Q112]]; do you want to mark it for deletion instead? ([y]es, [N]o, [a]ll): y WARNING: /usr/lib

[Pywikipedia-bugs] [Maniphest] [Commented On] T142021: Error mysqlquery

2016-08-03 Thread valhallasw
valhallasw added a comment. pip install oursql python-mysql should install the required packages.TASK DETAILhttps://phabricator.wikimedia.org/T142021EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: valhallaswCc: valhallasw, Aklapper, pywikibot-bugs-list

[Pywikipedia-bugs] [Maniphest] [Commented On] T139842: Restartable bot framework

2016-07-11 Thread valhallasw
valhallasw added a comment. Why does it not apply in that case?TASK DETAILhttps://phabricator.wikimedia.org/T139842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: valhallaswCc: Mpaa, valhallasw, Aklapper, jayvdb, Zppix, DrTrigon, pywikibot-bugs-list

[Pywikipedia-bugs] [Maniphest] [Commented On] T139842: Restartable bot framework

2016-07-10 Thread valhallasw
valhallasw added a comment. I think the simplest option is to stop after a given page has been processed, and continuing there the next time.TASK DETAILhttps://phabricator.wikimedia.org/T139842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: valhallaswCc

[Pywikipedia-bugs] [Maniphest] [Updated] T142155: Bot can't login. keyError in GetCookie

2016-08-07 Thread valhallasw
valhallasw added a comment. In T142155#2531460, @Udo_T wrote: But if I switch to OAuth, then the bot can perform edits only in German Wiktionary (where it has the local IP block exempt, too). In all other languages of Wiktionarys comes an error message: "WARNING: API error globalblo

[Pywikipedia-bugs] [Maniphest] [Commented On] T124466: Support logging in with Special:BotPassword passwords

2016-08-19 Thread valhallasw
valhallasw added a comment. I think your patch makes a lot of sense. The current situation already is a bit of a mess (because everything is split through three classes without a clear separation of concerns). On the one hand having self.login_name feels like storing that information in the wrong

  1   2   >