[Pywikipedia-bugs] [Maniphest] [Commented On] T124005: Create tests for fake user agent

2016-12-01 Thread gerritbot
gerritbot added a comment. Change 324633 merged by jenkins-bot: Add fake user agent test case https://gerrit.wikimedia.org/r/324633TASK DETAILhttps://phabricator.wikimedia.org/T124005EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jayvdb, gerritbotCc: Dargase

[Pywikipedia-bugs] [Maniphest] [Triaged] T152075: Extraneous config toggle for fake user agent

2016-12-01 Thread Dargasea
Dargasea triaged this task as "Low" priority. TASK DETAILhttps://phabricator.wikimedia.org/T152075EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DargaseaCc: Aklapper, TerraCodes, pywikibot-bugs-list, Dargasea, Magul, MayS, Mdupont, JJMC89, MuhammadShuaib, jay

[Pywikipedia-bugs] [Maniphest] [Updated] T152075: Extraneous config toggle for fake user agent

2016-12-01 Thread jayvdb
jayvdb edited projects, added Pywikibot-network; removed Easy.jayvdb added a comment. The main problem is that the default is None in config2.py. This task needs a little analysis to determine why the default is None, and what this currently does as the default for a user who doesnt modify this se

[Pywikipedia-bugs] [Maniphest] [Reassigned] T124005: Create tests for fake user agent

2016-12-01 Thread jayvdb
jayvdb reassigned this task from jayvdb to Dargasea. TASK DETAILhttps://phabricator.wikimedia.org/T124005EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dargasea, jayvdbCc: Dargasea, TerraCodes, darthbhyrava, Aklapper, pywikibot-bugs-list, jayvdb, Nemo_bis, Mt

[Pywikipedia-bugs] [Maniphest] [Unblock] T113596: reflinks.py work with old user agent

2016-12-01 Thread jayvdb
jayvdb closed subtask T124005: Create tests for fake user agent as "Resolved".Herald added a subscriber: TerraCodes. TASK DETAILhttps://phabricator.wikimedia.org/T113596EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MtDu, jayvdbCc: TerraCodes, gerritbot, MtDu

[Pywikipedia-bugs] [Maniphest] [Closed] T124005: Create tests for fake user agent

2016-12-01 Thread jayvdb
jayvdb closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T124005EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dargasea, jayvdbCc: Dargasea, TerraCodes, darthbhyrava, Aklapper, pywikibot-bugs-list, jayvdb, Nemo_bis, MtDu, gerritbot,

[Pywikipedia-bugs] [Maniphest] [Commented On] T152075: Extraneous config toggle for fake user agent

2016-12-01 Thread Dargasea
Dargasea added a comment. This task needs a little analysis to determine why the default is None None behaves the same way as True (if set a value, UA becomes that value. if False, default UA returned). The default is Introduced since the patch was submitted and unchanged since then. Potential ac

[Pywikipedia-bugs] [Maniphest] [Updated] T113596: reflinks.py work with old user agent

2016-12-01 Thread Dargasea
Dargasea added a subtask: T152075: Extraneous config toggle for fake user agent . TASK DETAILhttps://phabricator.wikimedia.org/T113596EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MtDu, DargaseaCc: TerraCodes, gerritbot, MtDu, Nemo_bis, 8ohit.dua, jayvdb, Ak

[Pywikipedia-bugs] [Maniphest] [Updated] T152075: Extraneous config toggle for fake user agent

2016-12-01 Thread Dargasea
Dargasea added a parent task: T113596: reflinks.py work with old user agent. TASK DETAILhttps://phabricator.wikimedia.org/T152075EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DargaseaCc: jayvdb, Aklapper, TerraCodes, pywikibot-bugs-list, Dargasea, Magul, May

[Pywikipedia-bugs] [Maniphest] [Commented On] T152075: Extraneous config toggle for fake user agent

2016-12-01 Thread jayvdb
jayvdb added a comment. I like these two combined: Change reflinks and weblinkchecker to retry with fake UA if first request gets rejected (need to decide what errors/status codes constitute as a rejection). Maintain a list of problematic sites in the configuration file (or should this be hosted

[Pywikipedia-bugs] [Maniphest] [Retitled] T152075: Automatic use of fake user agent for bot-unfriendly sites

2016-12-01 Thread Dargasea
Dargasea changed the title from "Extraneous config toggle for fake user agent " to "Automatic use of fake user agent for bot-unfriendly sites". TASK DETAILhttps://phabricator.wikimedia.org/T152075EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DargaseaCc: jayv

[Pywikipedia-bugs] [Maniphest] [Commented On] T152075: Automatic use of fake user agent for bot-unfriendly sites

2016-12-01 Thread Dargasea
Dargasea added a comment. In T152075#2837739, @jayvdb wrote: i.e. we would add a use_fake_user_agent parameter to methods in http.comms, which is False by default, True forces a fake user-agent, and None means automatic use of fallback logic (use fake if in the config list, otherwise try with real

[Pywikipedia-bugs] [Maniphest] [Commented On] T152075: Automatic use of fake user agent for bot-unfriendly sites

2016-12-01 Thread jayvdb
jayvdb added a comment. In T152075#2837748, @Dargasea wrote: In T152075#2837739, @jayvdb wrote: i.e. we would add a use_fake_user_agent parameter to methods in http.comms, which is False by default, True forces a fake user-agent, and None means automatic use of fallback logic (use fake if in the

[Pywikipedia-bugs] [Maniphest] [Commented On] T140624: redirect.py: please add deletion template to Meta

2016-12-01 Thread MarcoAurelio
MarcoAurelio added a comment. Thank you. However Meta uses {{delete}} as speedy deletion template. But for English, {{db-r1}} seems to be the default. Is there a way to conciliate both templates or can we create an exception for Meta & Commons in the file instead?TASK DETAILhttps://phabricator.wiki

[Pywikipedia-bugs] [Maniphest] [Commented On] T152075: Automatic use of fake user agent for bot-unfriendly sites

2016-12-01 Thread jayvdb
jayvdb added a comment. https://codein.withgoogle.com/tasks/4719662784839680/ will be the GCI task for this, when it is publish - waiting for admin to press the buttonTASK DETAILhttps://phabricator.wikimedia.org/T152075EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferenc

[Pywikipedia-bugs] [Maniphest] [Commented On] T130805: Create some tests for pywikibot.diff.PatchManager

2016-12-01 Thread gerritbot
gerritbot added a comment. Change 324724 had a related patch set uploaded (by Sn1per): Basic PatchManager unit tests https://gerrit.wikimedia.org/r/324724TASK DETAILhttps://phabricator.wikimedia.org/T130805EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Sn1pe

[Pywikipedia-bugs] [Maniphest] [Updated] T130805: Create some tests for pywikibot.diff.PatchManager

2016-12-01 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T130805EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Sn1per, gerritbotCc: gerritbot, Vennela0212, TerraCodes, Aklapper, pywikibot-bugs-list, Mpaa, jayvdb, Ramalepe, Liu

[Pywikipedia-bugs] [Maniphest] [Claimed] T152075: Automatic use of fake user agent for bot-unfriendly sites

2016-12-01 Thread Dargasea
Dargasea claimed this task.Dargasea added a comment. Thanks!TASK DETAILhttps://phabricator.wikimedia.org/T152075EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DargaseaCc: jayvdb, Aklapper, TerraCodes, pywikibot-bugs-list, Dargasea, Magul, MayS, Mdupont, JJMC8

[Pywikipedia-bugs] [Maniphest] [Commented On] T130805: Create some tests for pywikibot.diff.PatchManager

2016-12-01 Thread Sn1per
Sn1per added a comment. I was a little confused as to how to implement tests for the following from the diff_tests page: {{}}Pywikipediabot{{{}}} ? ?{}Pywikipediabot? +{yellow}Pywikipediabot -{black}Pywikipediabot Pywikipediabot{color}Pywikipediabot {color}Pywikipediabot {red}Pywikipediabot{red}

[Pywikipedia-bugs] [Maniphest] [Commented On] T130805: Create some tests for pywikibot.diff.PatchManager

2016-12-01 Thread jayvdb
jayvdb added a comment. You've looked through T130572? Just do the ones you can, and supplement the tests with other types of interesting cases you can see will be helpful, even basic ones.TASK DETAILhttps://phabricator.wikimedia.org/T130805EMAIL PREFERENCEShttps://phabricator.wikimedia.org/setting

[Pywikipedia-bugs] [Maniphest] [Commented On] T150521: pywikibot.data.sparql SparqlQuery.select() crashes on OPTIONAL values

2016-12-01 Thread gerritbot
gerritbot added a comment. Change 322648 merged by jenkins-bot: T150521: Don't crash on queries with optional values https://gerrit.wikimedia.org/r/322648TASK DETAILhttps://phabricator.wikimedia.org/T150521EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerri

[Pywikipedia-bugs] [Maniphest] [Closed] T150521: pywikibot.data.sparql SparqlQuery.select() crashes on OPTIONAL values

2016-12-01 Thread Multichill
Multichill claimed this task.Multichill closed this task as "Resolved".Multichill removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T150521EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MultichillCc: gerritbot, Aklapper, Smalys

[Pywikipedia-bugs] [Maniphest] [Commented On] T151943: textlib.replaceExcept should handle also tags like

2016-12-01 Thread Mpaa
Mpaa added a comment. @Aklapper, this is the second time I "think" I added a tag but it wasn't saved. Hhmm ... what am I doing wrong? I could see in tags.TASK DETAILhttps://phabricator.wikimedia.org/T151943EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MpaaCc

[Pywikipedia-bugs] [Maniphest] [Closed] T146996: Running a core script fails with 'permission denied' creating a logfile folder

2016-12-01 Thread scfc
scfc assigned this task to valhallasw.scfc closed this task as "Resolved".scfc added a comment. The cause with the ownership/permissions of the directory and a solution has been explained by @valhallasw, so resolving this issue here. @MuhammadShuaib, if you need further help setting the ownership/

[Pywikipedia-bugs] [Maniphest] [Commented On] T130805: Create some tests for pywikibot.diff.PatchManager

2016-12-01 Thread gerritbot
gerritbot added a comment. Change 324724 merged by jenkins-bot: Basic PatchManager unit tests https://gerrit.wikimedia.org/r/324724TASK DETAILhttps://phabricator.wikimedia.org/T130805EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Sn1per, gerritbotCc: gerritb

[Pywikipedia-bugs] [Maniphest] [Closed] T130805: Create some tests for pywikibot.diff.PatchManager

2016-12-01 Thread jayvdb
jayvdb closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T130805EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Sn1per, jayvdbCc: gerritbot, Vennela0212, TerraCodes, Aklapper, pywikibot-bugs-list, Mpaa, jayvdb, Ramalepe, Liugev6, Mag

[Pywikipedia-bugs] [Maniphest] [Lowered Priority] T151856: test_recentchanges_timespan is failing on Travis-CI

2016-12-01 Thread Xqt
Xqt lowered the priority of this task from "Unbreak Now!" to "Low".Xqt added a comment. Does not break anything except one test.TASK DETAILhttps://phabricator.wikimedia.org/T151856EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Magul, XqtCc: gerritbot, TerraCo