[Qemu-block] [PATCH v9 12/13] Add UUID files to MAINTAINERS

I understand that we've been keeping eyes on the uncovered files. Since I'm adding some more files I volunteer to look after them in the futuer. Signed-off-by: Fam Zheng Reviewed-by: Jeff Cody --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff

[Qemu-block] [PATCH v9 13/13] tests: Ignore test-uuid

Signed-off-by: Fam Zheng --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index b4a9cfc..24ac6cf 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -70,6 +70,7 @@ test-string-output-visitor test-thread-pool

[Qemu-block] [PATCH v9 06/13] crypto: Switch to QEMU UUID API

The uuid generation doesn't return error, so update the function signature and calling code accordingly. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Reviewed-by: Jeff Cody --- crypto/block-luks.c | 26 +++--- 1

[Qemu-block] [PATCH v9 03/13] vhdx: Use QEMU UUID API

This removes our dependency to libuuid, so that the driver can always be built. Similar to how we handled data plane configure options, --enable-vhdx and --disable-vhdx are also changed to a nop with a message saying it's obsolete. Signed-off-by: Fam Zheng Reviewed-by: Eric

[Qemu-block] [PATCH v9 11/13] tests: Add uuid tests

Signed-off-by: Fam Zheng Reviewed-by: Jeff Cody --- tests/Makefile.include | 2 + tests/test-uuid.c | 177 + 2 files changed, 179 insertions(+) create mode 100644 tests/test-uuid.c diff --git

[Qemu-block] [PATCH v9 09/13] vl: Switch qemu_uuid to QemuUUID

Update all qemu_uuid users as well, especially get rid of the duplicated low level g_strdup_printf, sscanf and snprintf calls with QEMU UUID API. Since qemu_uuid_parse is quite tangled with qemu_uuid, its switching to QemuUUID is done here too to keep everything in sync and avoid code churn.

[Qemu-block] [PATCH v9 05/13] vpc: Use QEMU UUID API

Previously we conditionally generated footer->uuid, when libuuid was available. Now that we have a built-in implementation, we can switch to it. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Reviewed-by: Jeff Cody --- block/vpc.c | 10

[Qemu-block] [PATCH v9 04/13] vdi: Use QEMU UUID API

The UUID operations we need from libuuid are fully supported by QEMU UUID implementation. Use it, and remove the unused code. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Reviewed-by: Jeff Cody --- block/vdi.c | 73

[Qemu-block] [PATCH v9 00/13] UUID clean ups for 2.8

v9: Add .gitignore patch. [Eric] Add Jeff's and Eric's r-b in other patches. The facts how we use libuuid now are not particularly pleasant. - VHDX driver depends on uuid, but is unconditionally checked in iotests 109. If it is not built, the test would fail, leaving no hint about that. In

Re: [Qemu-block] [PATCH v8 11/12] tests: Add uuid tests

On Tue, 09/20 10:37, Eric Blake wrote: > On 09/17/2016 11:25 PM, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > tests/Makefile.include | 2 + > > tests/test-uuid.c | 177 > > + > > 2 files changed, 179

Re: [Qemu-block] [PATCH 3/7] block/qapi: Move 'aio' option to file driver

On 09/20/2016 04:08 PM, Kevin Wolf wrote: > The option whether or not to use a native AIO interface really isn't a > generic option for all drivers, but only applies to the native file > protocols. This patch moves the option in blockdev-add to the > appropriate places (raw-posix and raw-win32). >

Re: [Qemu-block] [PATCH 2/7] block/qapi: Use separate options type for curl driver

On 09/20/2016 04:08 PM, Kevin Wolf wrote: > We're going to add an option to the file drivers which doesn't apply to > the curl drivers, so give them a separate option type. > > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 25 ++--- > 1 file

Re: [Qemu-block] [PATCH 1/7] block: Drop aio/cache consistency check from qmp_blockdev_add()

On 09/20/2016 04:08 PM, Kevin Wolf wrote: > The TODO comment has been addressed a while ago and this is now checked > in raw-posix, so we don't have to special case this in blockdev-add any > more. > > Signed-off-by: Kevin Wolf > --- > blockdev.c | 15

Re: [Qemu-block] [PATCH v2 11/11] block: Remove BB interface from blockdev-add/del

On 09/20/2016 08:03 AM, Kevin Wolf wrote: > With this patch, blockdev-add always works on a node level, i.e. it > creates a BDS, but no BB. Consequently, x-blockdev-del doesn't need the > 'device' option any more, but 'node-name' becomes mandatory. How close are we to promoting x-blockdev-del out

Re: [Qemu-block] [PATCH v2 10/11] qemu-iotests/141: Avoid blockdev-add with id

On 09/20/2016 08:03 AM, Kevin Wolf wrote: > We want to remove the 'id' option for blockdev-add. This removes one > user of the option and makes it use only node names. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/141 | 24 ++-- >

Re: [Qemu-block] [PATCH v2 09/11] qemu-iotests/139: Avoid blockdev-add with id

On 09/20/2016 08:03 AM, Kevin Wolf wrote: > We want to remove the 'id' option for blockdev-add. This removes one > user of the option and makes it use only node names. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/139 | 178 >

[Qemu-block] [PATCH 7/7] block: Remove qemu_root_bds_opts

The remaining options in qemu_root_bds_opts (aio and copy-on-read) aren't used any more, the QAPI schema doesn't contain them. Therefore all the code processing qemu_root_bds_opts options is dead and can be removed. Signed-off-by: Kevin Wolf --- blockdev.c | 54

[Qemu-block] [PATCH 6/7] block: Move 'discard' option to bdrv_open_common()

This enables its use for nested child nodes. The compatibility between the 'discard' and 'detect-zeroes' setting is checked in bdrv_open_common() now as the former setting isn't available before calling bdrv_open() any more. Signed-off-by: Kevin Wolf --- block.c

[Qemu-block] [PATCH 3/7] block/qapi: Move 'aio' option to file driver

The option whether or not to use a native AIO interface really isn't a generic option for all drivers, but only applies to the native file protocols. This patch moves the option in blockdev-add to the appropriate places (raw-posix and raw-win32). We still have to keep the flag BDRV_O_NATIVE_AIO

Re: [Qemu-block] [PATCH v2 07/11] qemu-iotests/118: Avoid blockdev-add with id

On 09/20/2016 08:03 AM, Kevin Wolf wrote: > We want to remove the 'id' option for blockdev-add. This removes one > user of the option and makes it use only node names. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/118 | 6 +- > 1 file changed, 1 insertion(+), 5

[Qemu-block] [PATCH 1/7] block: Drop aio/cache consistency check from qmp_blockdev_add()

The TODO comment has been addressed a while ago and this is now checked in raw-posix, so we don't have to special case this in blockdev-add any more. Signed-off-by: Kevin Wolf --- blockdev.c | 15 --- tests/qemu-iotests/087.out | 2 +- 2 files

[Qemu-block] [PATCH 2/7] block/qapi: Use separate options type for curl driver

We're going to add an option to the file drivers which doesn't apply to the curl drivers, so give them a separate option type. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git

[Qemu-block] [PATCH 0/7] block: Make more blockdev-add options work

This series moves a few more options from flags to the appropriate place. This doesn't only result in cleaner code, but also allows using these options in nested node definitions. After this series, bds_tree_init() is only a thin wrapper around bdrv_open() which sets the right defaults for cache

Re: [Qemu-block] [PATCH v2 06/11] qemu-iotests/117: Avoid blockdev-add with id

On 09/20/2016 08:03 AM, Kevin Wolf wrote: > We want to remove the 'id' option for blockdev-add. This removes one > user of the option and makes it use only node names. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/117 | 4 ++-- > 1 file changed, 2 insertions(+), 2

[Qemu-block] [PATCH 5/7] block: Use 'detect-zeroes' option for 'blockdev-change-medium'

Instead of modifying the new BDS after it has been opened, use the newly supported 'detect-zeroes' option in bdrv_open_common() so that all requirements are checked (detect-zeroes=unmap requires discard=unmap). Signed-off-by: Kevin Wolf --- block/block-backend.c | 9

[Qemu-block] [PATCH 4/7] block: Parse 'detect-zeroes' in bdrv_open_common()

Amonst others, this means that you can now use the 'detect-zeroes' option for non-top-level nodes in blockdev-add, like the QAPI schema promises. Signed-off-by: Kevin Wolf --- block.c| 33 + blockdev.c | 9 + 2 files changed, 34

[Qemu-block] [PULL v4 8/8] iotest 055: refactor and speed up

From: Vladimir Sementsov-Ogievskiy Source disk is created and filled with test data before each test case. Instead initialize it once for the whole unit. Test disk filling patterns are merged into one pattern. Also TestSetSpeed used different image_len for source and

[Qemu-block] [PULL v4 7/8] commit: get the overlay node before manipulating the backing chain

From: Alberto Garcia The 'block-commit' command has a 'top' parameter to specify the topmost node from which the data is going to be copied. [E] <- [D] <- [C] <- [B] <- [A] In this case if [C] is the top node then this is the result: [E] <- [B] <- [A] [B] must be

[Qemu-block] [PULL v4 3/8] blockdev: prepare iSCSI block driver for dynamic loading

From: Colin Lord This commit moves the initialization of the QemuOptsList qemu_iscsi_opts struct out of block/iscsi.c in order to allow the iscsi module to be dynamically loaded. Signed-off-by: Colin Lord Reviewed-by: Fam Zheng Reviewed-by:

[Qemu-block] [PULL v4 2/8] qemu-img: add skip option to dd

From: Reda Sallahi This adds the skip option which allows qemu-img dd to skip a number of blocks before copying the input. A test case was added to test the skip option. Signed-off-by: Reda Sallahi Message-id:

[Qemu-block] [PULL v4 5/8] blockdev: Add dynamic module loading for block drivers

From: Marc Mari Extend the current module interface to allow for block drivers to be loaded dynamically on request. The only block drivers that can be converted into modules are the drivers that don't perform any init operation except for registering themselves. In addition,

[Qemu-block] [PULL v4 1/8] qemu-img: add the 'dd' subcommand

From: Reda Sallahi This patch adds a basic dd subcommand analogous to dd(1) to qemu-img. For the start, this implements the bs, if, of and count options and requires both if and of to be specified (no stdin/stdout if not specified) and doesn't support tty, pipes, etc. The

[Qemu-block] [PULL v4 6/8] blockdev: Modularize nfs block driver

From: Colin Lord Modularizes the nfs block driver so that it gets dynamically loaded. Signed-off-by: Colin Lord Reviewed-by: Stefan Hajnoczi Message-id: 1471008424-16465-5-git-send-email-cl...@redhat.com Reviewed-by: Max Reitz

[Qemu-block] [PULL v4 4/8] blockdev: Add dynamic generation of module_block.h

From: Marc Mari To simplify the addition of new block modules, add a script that generates module_block.h automatically from the modules' source code. This script assumes that the QEMU coding style rules are followed. Signed-off-by: Marc Marí

[Qemu-block] [PULL v4 0/8] Block layer patches

The following changes since commit a008535b9fa396226ff9cf78b8ac5f3584bda58e: build-sys: fix make install regression (2016-09-20 11:32:43 +0100) are available in the git repository at: git://github.com/XanClic/qemu.git tags/pull-block-2016-09-20 for you to fetch changes up to

Re: [Qemu-block] [PATCH v2 04/11] qemu-iotests/081: Avoid blockdev-add with id

On 09/20/2016 08:03 AM, Kevin Wolf wrote: > We want to remove the 'id' option for blockdev-add. This removes one > user of the option and makes it use only node names. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/081 | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [Qemu-block] [PATCH v2 03/11] qemu-iotests/071: Avoid blockdev-add with id

On 09/20/2016 08:03 AM, Kevin Wolf wrote: > We want to remove the 'id' option for blockdev-add. This removes one > user of the option and makes it use only node names. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/071 | 8 > 1 file changed, 4 insertions(+),

Re: [Qemu-block] [PATCH v2 02/11] qemu-iotests/067: Avoid blockdev-add with id

On 09/20/2016 08:03 AM, Kevin Wolf wrote: > We want to remove the 'id' option for blockdev-add. This removes one > user of the option and makes it use only node names. > > In order to keep the test meaningful, some instances of query-block that > want to check whether the node still exists and

Re: [Qemu-block] [PATCH v3 00/10] block: Accept qdev IDs in device level QMP commands

On 09/20/2016 06:38 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the external > API, > we already converted all block layer QMP commands on the node level to accept > node names instead of BlockBackend names. This series converts the second > part, >

Re: [Qemu-block] [PATCH v3 04/10] block: Accept device model name for blockdev-open/close-tray

On 09/20/2016 06:38 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the What you have works, but still feels a bit awkward to this native speaker. You could get away with the shorter: In order to remove the need for BlockBackend names... Up to you if you

Re: [Qemu-block] [Qemu-devel] [PATCH v3 2/8] block: set snapshot option for block devices in blkreplay module

> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 20.09.2016 um 14:31 hat Pavel Dovgalyuk geschrieben: > > This patch adds overlay option for blkreplay filter. > > It allows creating persistent overlay file for saving and reloading > > VM snapshots in record/replay modes. > > > > Signed-off-by:

Re: [Qemu-block] [PATCH v8 11/12] tests: Add uuid tests

On 09/17/2016 11:25 PM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/Makefile.include | 2 + > tests/test-uuid.c | 177 > + > 2 files changed, 179 insertions(+) > create mode 100644 tests/test-uuid.c >

Re: [Qemu-block] [Qemu-devel] [PATCH 1/6] iotests: throw away test timings if args change

On Tue, Sep 20, 2016 at 09:06:17AM -0500, Eric Blake wrote: > On 09/20/2016 04:36 AM, Daniel P. Berrange wrote: > >> Rather than completely throwing things away, would it be worth updating > >> the check.time file format to track multiple entries? For every distinct > >> args seen, track a timing

Re: [Qemu-block] [Qemu-devel] [PATCH 1/6] iotests: throw away test timings if args change

On 09/20/2016 09:15 AM, Daniel P. Berrange wrote: >>> I guess we could keep things simple by not inventing a new format, >>> but instead of using 'check.time', use 'check.time.$FORMAT-$PROTOCOL' >>> eg 'check.time.qcow2-file' >> >> Seems more palatable. Lots of files rather than lots of lines in a

Re: [Qemu-block] [Qemu-devel] [PATCH v3 2/8] block: set snapshot option for block devices in blkreplay module

[ Cc: qemu-block ] Am 20.09.2016 um 14:31 hat Pavel Dovgalyuk geschrieben: > This patch adds overlay option for blkreplay filter. > It allows creating persistent overlay file for saving and reloading > VM snapshots in record/replay modes. > > Signed-off-by: Pavel Dovgalyuk

Re: [Qemu-block] [Qemu-devel] [PATCH 1/6] iotests: throw away test timings if args change

On 09/20/2016 04:36 AM, Daniel P. Berrange wrote: >> Rather than completely throwing things away, would it be worth updating >> the check.time file format to track multiple entries? For every distinct >> args seen, track a timing for that combination of args, then when >> starting a test, if a

[Qemu-block] [PATCH v2 08/11] qemu-iotests/124: Avoid blockdev-add with id

We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/124 | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git

[Qemu-block] [PATCH v2 09/11] qemu-iotests/139: Avoid blockdev-add with id

We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/139 | 178 +++-- tests/qemu-iotests/139.out | 4 +- 2 files

[Qemu-block] [PATCH v2 10/11] qemu-iotests/141: Avoid blockdev-add with id

We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/141 | 24 ++-- tests/qemu-iotests/141.out | 24 2 files

[Qemu-block] [PATCH v2 11/11] block: Remove BB interface from blockdev-add/del

With this patch, blockdev-add always works on a node level, i.e. it creates a BDS, but no BB. Consequently, x-blockdev-del doesn't need the 'device' option any more, but 'node-name' becomes mandatory. Signed-off-by: Kevin Wolf --- blockdev.c| 127

[Qemu-block] [PATCH v2 03/11] qemu-iotests/071: Avoid blockdev-add with id

We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/071 | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/071

[Qemu-block] [PATCH v2 05/11] qemu-iotests/087: Avoid blockdev-add with id

We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. The test cases that test conflicts between the 'id' option to blockdev-add and existing block devices or the 'node-name' of the same command can be removed because it won't be

[Qemu-block] [PATCH v2 04/11] qemu-iotests/081: Avoid blockdev-add with id

We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/081 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/081

[Qemu-block] [PATCH v2 00/11] block: Remove BB interface from blockdev-add/del

This series makes the next step towards a QAPI interface that doesn't require clients to know about BlockBackends. By removing the support for 'id' from blockdev-add, it becomes a command that always only creates a BDS (with a node name). Existing interfaces have already been changed to accept

[Qemu-block] [PATCH v2 06/11] qemu-iotests/117: Avoid blockdev-add with id

We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/117 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/117

[Qemu-block] [PATCH v2 01/11] qemu-iotests/041: Avoid blockdev-add with id

We want to remove the 'id' option for blockdev-add. This removes one user of the option and makes it use only node names. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/041 | 71 +++--- 1 file changed, 32 insertions(+), 39

Re: [Qemu-block] [PATCH v4 0/2] block: allow flush on devices with open tray

Am 19.09.2016 um 22:58 hat Max Reitz geschrieben: > On 19.09.2016 18:44, John Snow wrote: > > Final re-send for wording. > > > > The move to blk_flush altered the behavior of migration and flushing > > nodes that are not reachable via the guest, but are still reachable > > via QEMU and may or may

[Qemu-block] [PATCH v3 04/10] block: Accept device model name for blockdev-open/close-tray

In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts blockdev-open/close-tray to accept a qdev device name. Signed-off-by: Kevin Wolf --- blockdev.c| 61

[Qemu-block] [PATCH v3 05/10] block: Accept device model name for x-blockdev-insert-medium

In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts x-blockdev-insert-medium to accept a qdev device name. As the command is experimental, we can still remove the 'device' option that

[Qemu-block] [PATCH v3 06/10] block: Accept device model name for x-blockdev-remove-medium

In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts x-blockdev-remove-medium to accept a qdev device name. As the command is experimental, we can still remove the 'device' option that

[Qemu-block] [PATCH v3 09/10] block: Accept device model name for block_set_io_throttle

In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts block_set_io_throttle to accept a qdev device name. Signed-off-by: Kevin Wolf --- blockdev.c| 12

[Qemu-block] [PATCH v3 10/10] qemu-iotests/118: Test media change with qdev name

We just added the option to use qdev device names in all device related block QMP commands. This patch converts some of the test cases in 118 to use qdev device names instead of BlockBackend names to cover the new way. It converts cases for each of the media change commands, but only for CD-ROM

[Qemu-block] [PATCH v3 08/10] block: Accept device model name for blockdev-change-medium

In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts blockdev-change-medium to accept a qdev device name. Signed-off-by: Kevin Wolf --- blockdev.c| 18

[Qemu-block] [PATCH v3 07/10] block: Accept device model name for eject

In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts eject to accept a qdev device name. Signed-off-by: Kevin Wolf --- blockdev.c| 10 +++---

[Qemu-block] [PATCH v3 03/10] qdev-monitor: Add blk_by_qdev_id()

This finds the BlockBackend attached to the device model identified by its qdev ID. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- include/sysemu/block-backend.h | 1 + qdev-monitor.c | 18 ++ 2 files changed, 19

[Qemu-block] [PATCH v3 00/10] block: Accept qdev IDs in device level QMP commands

In order to remove the necessity to use BlockBackend names in the external API, we already converted all block layer QMP commands on the node level to accept node names instead of BlockBackend names. This series converts the second part, device level commands, to allow qdev device names instead of

[Qemu-block] [PATCH v3 02/10] qdev-monitor: Factor out find_device_state()

Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- qdev-monitor.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index e19617f..bc0213f 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c

Re: [Qemu-block] [Qemu-devel] [PATCH 1/6] iotests: throw away test timings if args change

On Mon, Sep 19, 2016 at 02:53:36PM -0500, Eric Blake wrote: > On 09/19/2016 12:35 PM, Daniel P. Berrange wrote: > > The 'check' program records timings for each test that > > is run. These timings are only valid, however, for a > > particular format/protocol combination. So if frequently > >

Re: [Qemu-block] [PATCH v3 1/2] block: sync bdrv_co_get_block_status_above() with bdrv_is_allocated_above()

On Tue, Sep 20, 2016 at 01:18:12AM +0200, Max Reitz wrote: > On 2016-09-15 at 18:34, Denis V. Lunev wrote: > >They should work very similar, covering same areas if backing store is > >shorter than the image. This change is necessary for the followup patch > >switching to