Re: [Qemu-devel] [PATCH RFC] virtio: put last seen used index into ring itself

2010-05-20 Thread Avi Kivity
On 05/20/2010 01:33 AM, Michael S. Tsirkin wrote: Virtio is already way too bouncy due to the indirection between the avail/used rings and the descriptor pool. A device with out of order completion (like virtio-blk) will quickly randomize the unused descriptor indexes, so every descriptor

Re: [Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare

2010-05-20 Thread Avi Kivity
On 05/20/2010 12:09 AM, Kevin Wolf wrote: Actually it's not that obvious. If the actual problem here (besides the mis-comparison) is due to missing barriers or flushes. Avi asked a good question in that thread. It's obvious that it's a hack. It doesn't fix anything, it just disables a

[Qemu-devel] Re: [PATCH 10/12] kvm: enable smp 1

2010-05-20 Thread Avi Kivity
On 05/19/2010 11:02 PM, Udo Lembke wrote: Unrelated, what are your smp issues? If i use one cpu i got a good io-performance: e.g. over 500MB/s at the profile install of the io-benchmark h2benchw.exe. ( aio=threads | SAS-Raid-0 | ftp://ftp.heise.de/pub/ct/ctsi/h2benchw.zip | hwbenchw.exe -p

[Qemu-devel] [PATCH] pc: fix segfault introduced by 3d53f5c36ff6

2010-05-20 Thread Eduard - Gabriel Munteanu
Commit 3d53f5c36ff6 introduced a segfault by erroneously making fw_cfg a 'void **' and passing it around in different ways. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro --- hw/pc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pc.c

Re: [Qemu-devel] [PATCH RFC] virtio: put last seen used index into ring itself

2010-05-20 Thread Avi Kivity
On 05/20/2010 08:01 AM, Rusty Russell wrote: A device with out of order completion (like virtio-blk) will quickly randomize the unused descriptor indexes, so every descriptor fetch will require a bounce. In contrast, if the rings hold the descriptors themselves instead of pointers, we bounce

Re: [Qemu-devel] [PATCH] Add QEMU DirectFB display driver

2010-05-20 Thread Gerd Hoffmann
On 05/19/10 18:30, Jamie Lokier wrote: Julian Pidancet wrote: So after all, why not implementing our own VT switching and using directly the fbdev interface. It's a good idea. VT switching isn't hard to track reliably. Indeed, only problem is that the fbdev libs usually want to do that

Re: [Qemu-devel] [PATCH] Fix %lld or %llx printf format use

2010-05-20 Thread Markus Armbruster
I had a look at the first few, and they're all fine. Thanks!

Re: [Qemu-devel] [RFC] Bug Day - June 1st, 2010

2010-05-20 Thread Jes Sorensen
On 05/19/10 02:58, Natalia Portillo wrote: Hi, - We'll try to migrate as many confirmable bugs from the Source Forge tracker to Launchpad. I think that part of the bug day should also include retesting OSes that appear in OS Support List as having bug and confirming if the bug is still

Re: [Qemu-devel] [RFC] Bug Day - June 1st, 2010

2010-05-20 Thread Jes Sorensen
On 05/19/10 15:34, Anthony Liguori wrote: On 05/19/2010 12:04 AM, Aurelien Jarno wrote: The idea is nice, but would it be possible to hold this on a week-end, I personally won't be able to attend such thing on a day week. Or maybe holding that on two days: friday and saturday so that people

Re: [Qemu-devel] [PATCH] pc: fix segfault introduced by 3d53f5c36ff6

2010-05-20 Thread Isaku Yamahata
Thank you for fixing it. Probably I was too in hurry when rebasing the patches. Acked-by: Isaku Yamahata yamah...@valinux.co.jp On Thu, May 20, 2010 at 09:14:04AM +0300, Eduard - Gabriel Munteanu wrote: Commit 3d53f5c36ff6 introduced a segfault by erroneously making fw_cfg a 'void **' and

Re: [Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare

2010-05-20 Thread Kevin Wolf
Am 20.05.2010 08:09, schrieb Avi Kivity: On 05/20/2010 12:09 AM, Kevin Wolf wrote: Actually it's not that obvious. If the actual problem here (besides the mis-comparison) is due to missing barriers or flushes. Avi asked a good question in that thread. It's obvious that it's a hack.

Re: [Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare

2010-05-20 Thread Avi Kivity
On 05/20/2010 11:19 AM, Kevin Wolf wrote: Am 20.05.2010 08:09, schrieb Avi Kivity: On 05/20/2010 12:09 AM, Kevin Wolf wrote: Actually it's not that obvious. If the actual problem here (besides the mis-comparison) is due to missing barriers or flushes. Avi asked a good

[Qemu-devel] Re: [PATCH 10/12] kvm: enable smp 1

2010-05-20 Thread Udo Lembke
Avi Kivity schrieb: On 05/19/2010 11:02 PM, Udo Lembke wrote: Unrelated, what are your smp issues? If i use one cpu i got a good io-performance: e.g. over 500MB/s at the profile install of the io-benchmark h2benchw.exe. ( aio=threads | SAS-Raid-0 |

[Qemu-devel] [PATCH] vvfat: More build fixes with DEBUG

2010-05-20 Thread Kevin Wolf
Casting a pointer to an int doesn't work on 64 bit platforms. Use the %p printf conversion specifier instead. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/vvfat.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index

[Qemu-devel] Re: [PATCH] block: Fix compilation with DEBUG defined

2010-05-20 Thread Kevin Wolf
Am 19.05.2010 22:53, schrieb Riccardo Magliocchetti: gcc does not like passing a NULL where an int value is expected: block/vvfat.c: In function ‘checkpoint’: block/vvfat.c:2868: error: passing argument 2 of ‘remove_mapping’ makes integer from pointer without a cast Signed-off-by:

[Qemu-devel] [PATCH 2/2] hxtool: Add syntax error detection

2010-05-20 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com Add basic imbalance detection for STEXT/ETEXI. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hxtool | 16 +++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/hxtool b/hxtool index 0fdbc64..8f65532 100644 --- a/hxtool

[Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare

2010-05-20 Thread Kevin Wolf
Am 19.05.2010 20:53, schrieb Christoph Hellwig: The difference between the start sectors of two requests can be larger than the size of the int type, which can lead to a not correctly sorted multiwrite array and thus spurious I/O errors and filesystem corruption due to incorrect request

[Qemu-devel] Re: [PATCH] block: Fix compilation with DEBUG defined

2010-05-20 Thread Riccardo Magliocchetti
Il 20/05/2010 10:43, Kevin Wolf ha scritto: Am 19.05.2010 22:53, schrieb Riccardo Magliocchetti: gcc does not like passing a NULL where an int value is expected: block/vvfat.c: In function ‘checkpoint’: block/vvfat.c:2868: error: passing argument 2 of ‘remove_mapping’ makes integer from

[Qemu-devel] [PATCH] QEMU: change default disk cache behavior

2010-05-20 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com We seem to get into the discussion of what is the correct default setting disk images in QEMU. The libvirt team is reluctant to change specified for newly created images without the default setting matching it, and everybody seems to agree that the

[Qemu-devel] [PATCH] QEMU: Change default disk caching to nocache

2010-05-20 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Change default disk image caching to nocache (O_DIRECT). However in case it fails (ramfs, NFS etc.). fall back and retry with write-back. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- vl.c | 25 +++-- 1 files changed, 19

[Qemu-devel] [Bug 267542] Re: MINIX 3 won't boot in qemu 0.9.1

2010-05-20 Thread Andre Przywara
Is that still a problem? What was the exact error? I quickly tried the 3.1.2a on qemu 0.12.4 (with and without KVM) and I could easily login. ** Changed in: qemu Status: New = Incomplete -- MINIX 3 won't boot in qemu 0.9.1 https://bugs.launchpad.net/bugs/267542 You received this bug

[Qemu-devel] [PATCH] Name the default PCI bus pci.0 on all architectures (v2)

2010-05-20 Thread Daniel P. Berrange
The system emulators for each arch are using inconsistent naming for the default PCI bus pci vs pci.0. Since it is conceivable we'll have multiple PCI buses in the future standardize on pci.0 for all architectures. This ensures mgmt apps can rely on a name when assigning PCI devices an address on

Re: [Qemu-devel] [PATCH] Name the default PCI bus pci.0 on all architectures

2010-05-20 Thread Daniel P. Berrange
On Wed, May 19, 2010 at 10:19:06PM +0300, Blue Swirl wrote: On 5/19/10, Daniel P. Berrange berra...@redhat.com wrote: The system emulators for each arch are using inconsistent naming for the default PCI bus pci vs pci.0. Since it is conceivable we'll have multiple PCI buses in the future

Re: [Qemu-devel] [PATCH RFC] virtio: put last seen used index into ring itself

2010-05-20 Thread Michael S. Tsirkin
On Thu, May 20, 2010 at 02:31:50PM +0930, Rusty Russell wrote: Can we do better? The obvious idea is to try to get rid of last_used and used, and use the ring itself. We would use an invalid entry to mark the head of the ring. Any other thoughts? Rusty. We also need a way to avoid

[Qemu-devel] Do qemu support ARM1176JZ(F)-S chip?

2010-05-20 Thread w ql
Where can I find the last list about arm? Thanks a lot. wql

Re: [Qemu-devel] [Bug 267542] Re: MINIX 3 won't boot in qemu 0.9.1

2010-05-20 Thread Mohammed Gamal
On Thu, May 20, 2010 at 12:44 PM, Andre Przywara andre.przyw...@amd.com wrote: Is that still a problem? What was the exact error? I quickly tried the 3.1.2a on qemu 0.12.4 (with and without KVM) and I could easily login. This happens with MINIX 3.1.6, during boot it briefly goes into an

[Qemu-devel] [PATCH] Add dependency of JSON unit tests on config-host.h

2010-05-20 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- Makefile |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index 110698e..aa81d9b 100644 --- a/Makefile +++ b/Makefile @@ -144,6 +144,8 @@ qemu-io$(EXESUF):

[Qemu-devel] [Bug 583296] Re: I/O errors with qemu-nbd/qcow2

2010-05-20 Thread David Weber
** Attachment added: dmesg http://launchpadlibrarian.net/48810728/kern.log -- I/O errors with qemu-nbd/qcow2 https://bugs.launchpad.net/bugs/583296 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: New Bug

[Qemu-devel] [Bug 583296] [NEW] I/O errors with qemu-nbd/qcow2

2010-05-20 Thread David Weber
Public bug reported: I tried to open a qcow2 file with qemu-nbd and backup the files in it. After some coping I get lot of I/O errors in dmesg and the system hangs. One time I got even a kernel panic (Of course on a productive Server ;-) ) How to reproduce: 1. Connect nbd to a qcow2 file, a

[Qemu-devel] [Bug 583296] Re: I/O errors with qemu-nbd/qcow2

2010-05-20 Thread David Weber
I forgot: this is on Ubuntu 10.04, Qemu 0.12.3. -- I/O errors with qemu-nbd/qcow2 https://bugs.launchpad.net/bugs/583296 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: New Bug description: I tried to open a qcow2 file

Re: [Qemu-devel] [PATCH] QEMU: change default disk cache behavior

2010-05-20 Thread Anthony Liguori
On 05/20/2010 04:32 AM, jes.soren...@redhat.com wrote: From: Jes Sorensenjes.soren...@redhat.com We seem to get into the discussion of what is the correct default setting disk images in QEMU. The libvirt team is reluctant to change specified for newly created images without the default setting

[Qemu-devel] [PATCH 1/2] Fix TEXI section mark imbalance in qemu-img-cmd.hx

2010-05-20 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- qemu-img-cmds.hx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index c079019..c4cf3e7 100644 --- a/qemu-img-cmds.hx +++ b/qemu-img-cmds.hx

Re: [Qemu-devel] Re: [PATCH 1/3] cursor: add cursor functions.

2010-05-20 Thread Gerd Hoffmann
Hi, Well. You can't have both. We can have a efficiently packed format (i.e. two bitmaps). Or we can do it in a way which doesn't need parsing, but that wouldn't be the most compact format ... You're right, so packing or introducing a small conversion function is not critical. I'd still

[Qemu-devel] vgabios plans ( Re: [PATCH 1/5] Makefile cleanup)

2010-05-20 Thread Gerd Hoffmann
On 05/07/10 12:09, Gerd Hoffmann wrote: Use a single rule for building bios binaries. Use target specific variables to set compile flags. This makes it more obvious what the differences between the versions are. It also makes it easier to add new bios binaries with slightly different settings.

[Qemu-devel] Re: vgabios plans ( Re: [PATCH 1/5] Makefile cleanup)

2010-05-20 Thread Anthony Liguori
On 05/20/2010 07:57 AM, Gerd Hoffmann wrote: On 05/07/10 12:09, Gerd Hoffmann wrote: Use a single rule for building bios binaries. Use target specific variables to set compile flags. This makes it more obvious what the differences between the versions are. It also makes it easier to add new

[Qemu-devel] [PULL 0/8] Block patches

2010-05-20 Thread Kevin Wolf
Hi Anthony, this bunch of patches contains some fixes that I think qualify for stable, especially the first two. Please cherry-pick them into stable-0.12 when you have pulled: 468f932 block: fix sector comparism in multiwrite_req_compare 49eb7b7 virtio-blk: fix barrier support 5fdf2a6 block: fix

[Qemu-devel] [PATCH 3/8] virtio-blk: fix barrier support

2010-05-20 Thread Kevin Wolf
From: Christoph Hellwig h...@lst.de Before issuing the barrier to the block driver we need to flush our oustanding queue of write requests, as the flush is supposed to be issued after them. Signed-off-by: Christoph Hellwig h...@lst.de Signed-off-by: Kevin Wolf kw...@redhat.com ---

[Qemu-devel] [PATCH 4/8] block: fix sector comparism in multiwrite_req_compare

2010-05-20 Thread Kevin Wolf
From: Christoph Hellwig h...@lst.de The difference between the start sectors of two requests can be larger than the size of the int type, which can lead to a not correctly sorted multiwrite array and thus spurious I/O errors and filesystem corruption due to incorrect request merges. So instead

[Qemu-devel] [PATCH 5/8] block: Make find_image_format() return 'raw' BlockDriver for SG_IO devices

2010-05-20 Thread Kevin Wolf
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds a special BlockDriverState-sg check in block.c:find_image_format() after bdrv_file_open() - block/raw-posix.c:hdev_open() has been called to determine if we are dealing with a Linux host scsi-generic device. The patch then returns

[Qemu-devel] [PATCH 2/8] virtio-blk: Avoid zeroing every request structure

2010-05-20 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com The VirtIOBlockRequest structure is about 40 KB in size. This patch avoids zeroing every request by only initializing fields that are read. The other fields are either written to or may not be used at all. Oprofile shows about 10% of CPU samples

[Qemu-devel] [PATCH 1/8] block: fix aio_flush segfaults for read-only protocols (e.g. curl)

2010-05-20 Thread Kevin Wolf
From: Avi Kivity a...@redhat.com Not all block format drivers expose an io_flush method (reasonable for read-only protocols), so calling io_flush there will immediately segfault. Fix by checking for the method's existence before calling it. Signed-off-by: Avi Kivity a...@redhat.com

[Qemu-devel] [PATCH 6/8] block: Add SG_IO device check in refresh_total_sectors()

2010-05-20 Thread Kevin Wolf
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds a special case check for scsi-generic devices in refresh_total_sectors() to skip the subsequent BlockDriver-bdrv_getlength() that will be returning -ESPIPE from block/raw-posic.c:raw_getlength() for BlockDriverState-sg=1 devices.

[Qemu-devel] [PATCH 8/8] vvfat: More build fixes with DEBUG

2010-05-20 Thread Kevin Wolf
Casting a pointer to an int doesn't work on 64 bit platforms. Use the %p printf conversion specifier instead. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/vvfat.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index

[Qemu-devel] [PATCH 7/8] vvfat: Fix compilation with DEBUG defined

2010-05-20 Thread Kevin Wolf
From: Riccardo Magliocchetti riccardo.magliocche...@gmail.com gcc does not like passing a NULL where an int value is expected: block/vvfat.c: In function ‘checkpoint’: block/vvfat.c:2868: error: passing argument 2 of ‘remove_mapping’ makes integer from pointer without a cast Signed-off-by:

Re: [Qemu-devel] [RFC] Bug Day - June 1st, 2010

2010-05-20 Thread Andre Przywara
Michael Tokarev wrote: 20.05.2010 02:30, Anthony Liguori wrote: On 05/19/2010 05:29 PM, Andre Przywara wrote: Michael Tokarev wrote: ... Also, thanks to Andre Przywara, whole winNT thing works but it requires -cpu qemu64,level=1 (or level=2 or =3), -- _not_ with default CPU. This [] It'd

Re: [Qemu-devel] Re: [PATCH 1/3] cursor: add cursor functions.

2010-05-20 Thread Anthony Liguori
On 05/20/2010 07:49 AM, Gerd Hoffmann wrote: Hi, Well. You can't have both. We can have a efficiently packed format (i.e. two bitmaps). Or we can do it in a way which doesn't need parsing, but that wouldn't be the most compact format ... You're right, so packing or introducing a small

Re: [Qemu-devel] [PATCH 0/2] Fix scsi-generic breakage in upstream qemu-kvm.git

2010-05-20 Thread Kevin Wolf
Am 17.05.2010 18:45, schrieb Nicholas A. Bellinger: From: Nicholas Bellinger n...@linux-iscsi.org Greetings, Attached are the updated patches following hch's comments to fix scsi-generic device breakage with find_image_format() and refresh_total_sectors(). These are being resent as the

[Qemu-devel] [PATCH] check for active_console before using it

2010-05-20 Thread Gerd Hoffmann
Other vga_hw_* functions do the same. Fixes a segmentation fault. Trigger: boot with -nodefaults, then connect via vnc. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/console.c b/console.c index

Re: [Qemu-devel] [PATCH 0/6]: QMP: Fix issues in parser/lexer

2010-05-20 Thread Luiz Capitulino
On Wed, 19 May 2010 16:43:08 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 05/19/2010 04:15 PM, Luiz Capitulino wrote: Hi Anthony, While investigating a QMP bug reported by a user, I've found a few issues in our parser/lexer. The patches in this series fix the problems

Re: [Qemu-devel] [PATCH 03/22] tcg-i386: Tidy ext8u and ext16u operations.

2010-05-20 Thread Aurelien Jarno
On Wed, May 19, 2010 at 11:31:27AM -0700, Richard Henderson wrote: On 05/18/2010 11:47 PM, Aurelien Jarno wrote: The reg allocator is able to issue move if needed, so the only improvement this patch is for doing a ext8u on both q registers. OTOH the reg allocator knows this situation and

Re: [Qemu-devel] [PATCH] QEMU: change default disk cache behavior

2010-05-20 Thread Jes Sorensen
On 05/20/10 14:30, Anthony Liguori wrote: On 05/20/2010 04:32 AM, jes.soren...@redhat.com wrote: Therefore, here is a patch that does two things: - default to nocache - in case of failure with nocache, retry with write-back This sort of change requires performance data in a variety

Re: [Qemu-devel] [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Luiz Capitulino
On Wed, 19 May 2010 16:44:47 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 05/19/2010 04:15 PM, Luiz Capitulino wrote: The JSON escape sequence \/ and \\ are valid and should be handled. Signed-off-by: Luiz Capitulinolcapitul...@redhat.com Good catch. I think there's

Re: [Qemu-devel] [PATCH] QEMU: change default disk cache behavior

2010-05-20 Thread Jes Sorensen
On 05/20/10 15:40, Anthony Liguori wrote: On 05/20/2010 08:36 AM, Jes Sorensen wrote: And I strongly suspect that such a blanket change would be wrong but that a more targeted change like making cache=none default for physical devices would satisfy mostly everyone. Is there any other

[Qemu-devel] [RFC PATCH] AMD IOMMU emulation

2010-05-20 Thread Eduard - Gabriel Munteanu
This is preliminary work for AMD IOMMU emulation support. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro --- Makefile.target |2 + configure |9 + hw/amd_iommu.c | 442 +++ hw/pc.c |2 + hw/pc.h

Re: [Qemu-devel] [PATCH 03/22] tcg-i386: Tidy ext8u and ext16u operations.

2010-05-20 Thread Aurelien Jarno
On Thu, May 20, 2010 at 03:39:08PM +0200, Aurelien Jarno wrote: On Wed, May 19, 2010 at 11:31:27AM -0700, Richard Henderson wrote: On 05/18/2010 11:47 PM, Aurelien Jarno wrote: The reg allocator is able to issue move if needed, so the only improvement this patch is for doing a ext8u on

Re: [Qemu-devel] [PATCH] QEMU: change default disk cache behavior

2010-05-20 Thread Stefan Hajnoczi
On Thu, May 20, 2010 at 2:49 PM, Jes Sorensen jes.soren...@redhat.com wrote: On 05/20/10 15:40, Anthony Liguori wrote: On 05/20/2010 08:36 AM, Jes Sorensen wrote: And I strongly suspect that such a blanket change would be wrong but that a more targeted change like making cache=none default for

Re: [Qemu-devel] [PATCH RFC] virtio: put last seen used index into ring itself

2010-05-20 Thread Rusty Russell
On Thu, 20 May 2010 04:30:56 pm Avi Kivity wrote: On 05/20/2010 08:01 AM, Rusty Russell wrote: A device with out of order completion (like virtio-blk) will quickly randomize the unused descriptor indexes, so every descriptor fetch will require a bounce. In contrast, if the rings hold

Re: [Qemu-devel] [PATCH 03/22] tcg-i386: Tidy ext8u and ext16u operations.

2010-05-20 Thread Richard Henderson
On 05/20/2010 07:04 AM, Aurelien Jarno wrote: Do you have tried to compare the generated code before and after your patch? I expect a few cases where your patch has some drawbacks, so I don't know if there is a net gain on the size of the translated code. I have done a quick test on

[Qemu-devel] [PATCH 2/2] qcow2: Fix error handling in l2_allocate

2010-05-20 Thread Kevin Wolf
l2_allocate has some intermediate states in which the image is inconsistent. Change the order to write to the L1 table only after the new L2 table has successfully been initialized. Also reset the L2 cache in failure case, it's very likely wrong. Signed-off-by: Kevin Wolf kw...@redhat.com ---

[Qemu-devel] [PATCH 1/2] qcow2: Clear L2 table cache after write error

2010-05-20 Thread Kevin Wolf
If the L2 table was already updated in cache, but writing it to disk has failed, we must not continue using the changed version in the cache to stay consistent with what's on the disk. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c |1 + 1 files changed, 1

[Qemu-devel] [PATCH 02/10] target-mips: add microMIPS-specific bits to mips-defs.h

2010-05-20 Thread Nathan Froyd
There's a new ASE_MICROMIPS instruction flag, and some extra CP0_Config3 fields. The ISA and ISA_ON_EXC fields are specific to microMIPS. The DSP2P is for version 2 of the DSP ASE. Signed-off-by: Nathan Froyd froy...@codesourcery.com --- target-mips/cpu.h |3 +++

[Qemu-devel] [PATCH 10/10] hw: honor low bit in mipssim machine

2010-05-20 Thread Nathan Froyd
Signed-off-by: Nathan Froyd froy...@codesourcery.com --- hw/mips_mipssim.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/mips_mipssim.c b/hw/mips_mipssim.c index a747de5..cd6c2be 100644 --- a/hw/mips_mipssim.c +++ b/hw/mips_mipssim.c @@ -106,7 +106,9 @@ static

[Qemu-devel] [PATCH 00/10] target-mips: add microMIPS ASE support

2010-05-20 Thread Nathan Froyd
This patch series adds support for the microMIPS ASE. microMIPS is a new ASE similar to MIPS16, but re-encodes the entire instruction set into 16-bit and 32-bit instructions--in contrast to MIPS16, which re-encodes only integer instructions. The mechanisms for going in and out of microMIPS mode

[Qemu-devel] [PATCH 07/10] target-mips: add microMIPS CPUs

2010-05-20 Thread Nathan Froyd
Signed-off-by: Nathan Froyd froy...@codesourcery.com --- target-mips/translate_init.c | 61 ++ 1 files changed, 61 insertions(+), 0 deletions(-) diff --git a/target-mips/translate_init.c b/target-mips/translate_init.c index b79ed56..8e17f4b 100644 ---

[Qemu-devel] [PATCH 05/10] target-mips: small changes to use new FMT_ enums

2010-05-20 Thread Nathan Froyd
Signed-off-by: Nathan Froyd froy...@codesourcery.com --- target-mips/translate.c | 17 + 1 files changed, 9 insertions(+), 8 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 8a7f3e9..c42d8dd 100644 --- a/target-mips/translate.c +++

[Qemu-devel] [PATCH 01/10] target-mips: break out [ls][wd]c1 and rdhwr insn generation

2010-05-20 Thread Nathan Froyd
Signed-off-by: Nathan Froyd froy...@codesourcery.com --- target-mips/translate.c | 106 ++- 1 files changed, 59 insertions(+), 47 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index c95ecb1..2075d09 100644 ---

[Qemu-devel] [PATCH 09/10] linux-user: honor low bit of entry PC for MIPS

2010-05-20 Thread Nathan Froyd
Signed-off-by: Nathan Froyd froy...@codesourcery.com --- linux-user/main.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 18b52c0..76d443b 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -3192,7 +3192,9 @@ int

[Qemu-devel] [PATCH 04/10] target-mips: refactor {c, abs}.cond.fmt insns

2010-05-20 Thread Nathan Froyd
Move all knowledge about coprocessor-checking and register numbering into the gen_cmp* helper functions. Signed-off-by: Nathan Froyd froy...@codesourcery.com --- target-mips/translate.c | 232 ++- 1 files changed, 149 insertions(+), 83 deletions(-)

[Qemu-devel] [PATCH 08/10] target-mips: add microMIPS exception handler support

2010-05-20 Thread Nathan Froyd
Unlike MIPS16, microMIPS lets you choose the ISA mode for your exception handlers. Signed-off-by: Nathan Froyd froy...@codesourcery.com --- target-mips/helper.c | 21 +++-- 1 files changed, 15 insertions(+), 6 deletions(-) diff --git a/target-mips/helper.c

[Qemu-devel] [PATCH 03/10] target-mips: add enum constants for various invocations of FOP

2010-05-20 Thread Nathan Froyd
Tweak gen_farith and its caller to use them. Signed-off-by: Nathan Froyd froy...@codesourcery.com --- target-mips/translate.c | 266 --- 1 files changed, 180 insertions(+), 86 deletions(-) diff --git a/target-mips/translate.c

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Paolo Bonzini
On 05/20/2010 03:44 PM, Luiz Capitulino wrote: I think there's another issue in the handling of strings. The spec says that valid unescaped chars are in the following range: unescaped = %x20-21 / %x23-5B / %x5D-10 But we do: [IN_DQ_STRING] = { [1 ... 0xFF] =

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Paolo Bonzini
On 05/20/2010 05:25 PM, Luiz Capitulino wrote: On Thu, 20 May 2010 17:16:01 +0200 Paolo Bonzinipbonz...@redhat.com wrote: On 05/20/2010 03:44 PM, Luiz Capitulino wrote: I think there's another issue in the handling of strings. The spec says that valid unescaped chars are in the

[Qemu-devel] Re: [PATCH] QEMU: Change default disk caching to nocache

2010-05-20 Thread Paolo Bonzini
On 05/20/2010 11:32 AM, jes.soren...@redhat.com wrote: +if (bdrv_flags BDRV_O_NOCACHE) { +fprintf(stderr, qemu: failed to open disk image %s as +nocache (O_DIRECT) retrying as write-back\n, file); +bdrv_flags = BDRV_O_NOCACHE; Missing ~

[Qemu-devel] Re: [PATCH 0/6]: QMP: Fix issues in parser/lexer

2010-05-20 Thread Paolo Bonzini
On 05/19/2010 11:43 PM, Anthony Liguori wrote: 4. Lexer expects a 'terminal' char to process a token Which means clients must send a sort of end of line char, so that we process their input. Maybe I'm missing something here, but I thought that the whole point of writing our

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Luiz Capitulino
On Thu, 20 May 2010 17:16:01 +0200 Paolo Bonzini pbonz...@redhat.com wrote: On 05/20/2010 03:44 PM, Luiz Capitulino wrote: I think there's another issue in the handling of strings. The spec says that valid unescaped chars are in the following range: unescaped = %x20-21 /

[Qemu-devel] Re: [PATCH 0/6]: QMP: Fix issues in parser/lexer

2010-05-20 Thread Luiz Capitulino
On Thu, 20 May 2010 17:18:23 +0200 Paolo Bonzini pbonz...@redhat.com wrote: On 05/19/2010 11:43 PM, Anthony Liguori wrote: 4. Lexer expects a 'terminal' char to process a token Which means clients must send a sort of end of line char, so that we process their input.

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Luiz Capitulino
On Thu, 20 May 2010 17:26:03 +0200 Paolo Bonzini pbonz...@redhat.com wrote: On 05/20/2010 05:25 PM, Luiz Capitulino wrote: On Thu, 20 May 2010 17:16:01 +0200 Paolo Bonzinipbonz...@redhat.com wrote: On 05/20/2010 03:44 PM, Luiz Capitulino wrote: I think there's another issue in the

Re: [Qemu-devel] [PATCH 04/10] target-mips: refactor {c, abs}.cond.fmt insns

2010-05-20 Thread Richard Henderson
On 05/20/2010 07:52 AM, Nathan Froyd wrote: +/* Tests */ +#define OP_COND(name, cond) \ +static inline void glue(gen_op_, name) (TCGv ret, TCGv t0, TCGv t1) \ +{ \ +int l1 =

Re: [Qemu-devel] [PATCH RFC] virtio: put last seen used index into ring itself

2010-05-20 Thread Avi Kivity
On 05/20/2010 05:34 PM, Rusty Russell wrote: Have just one ring, no indexes. The producer places descriptors into the ring and updates the head, The consumer copies out descriptors to be processed and copies back in completed descriptors. Chaining is always linear. The descriptors contain

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Anthony Liguori
On 05/20/2010 10:16 AM, Paolo Bonzini wrote: On 05/20/2010 03:44 PM, Luiz Capitulino wrote: I think there's another issue in the handling of strings. The spec says that valid unescaped chars are in the following range: unescaped = %x20-21 / %x23-5B / %x5D-10 That's a spec bug

[Qemu-devel] Re: [PATCH 0/6]: QMP: Fix issues in parser/lexer

2010-05-20 Thread Anthony Liguori
On 05/20/2010 10:18 AM, Paolo Bonzini wrote: On 05/19/2010 11:43 PM, Anthony Liguori wrote: 4. Lexer expects a 'terminal' char to process a token Which means clients must send a sort of end of line char, so that we process their input. Maybe I'm missing something here, but I

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Anthony Liguori
On 05/20/2010 10:35 AM, Luiz Capitulino wrote: I meant that we're just accepting some invalid JSON and that's not a big deal. It can become a big deal if clients rely on it and for some reason we decide we should drop it. Ie. after QMP is declared stable such changes won't be allowed.

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Luiz Capitulino
On Thu, 20 May 2010 10:50:41 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 05/20/2010 10:16 AM, Paolo Bonzini wrote: On 05/20/2010 03:44 PM, Luiz Capitulino wrote: I think there's another issue in the handling of strings. The spec says that valid unescaped chars are in the

Re: [Qemu-devel] [PATCH 04/10] target-mips: refactor {c, abs}.cond.fmt insns

2010-05-20 Thread Nathan Froyd
On Thu, May 20, 2010 at 08:34:16AM -0700, Richard Henderson wrote: On 05/20/2010 07:52 AM, Nathan Froyd wrote: +/* Tests */ +#define OP_COND(name, cond) \ +#define OP_CONDI(name, cond) \ +#define

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Luiz Capitulino
On Thu, 20 May 2010 10:54:42 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 05/20/2010 10:35 AM, Luiz Capitulino wrote: I meant that we're just accepting some invalid JSON and that's not a big deal. It can become a big deal if clients rely on it and for some reason we

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Anthony Liguori
On 05/20/2010 11:27 AM, Luiz Capitulino wrote: On Thu, 20 May 2010 10:50:41 -0500 Anthony Liguorianth...@codemonkey.ws wrote: On 05/20/2010 10:16 AM, Paolo Bonzini wrote: On 05/20/2010 03:44 PM, Luiz Capitulino wrote: I think there's another issue in the handling of

[Qemu-devel] [Bug 391879] Re: migrate exec ignores exit status

2010-05-20 Thread Dave Walker
This is a bug and has been reported upstream, it is unlikely to be fixed at the distribution level and therefore anyone interested in working on this bug should contribute a patch to the upstream project. This will then filter down to Ubuntu when it is merged mainline. Marking Won't Fix against

Re: [Qemu-devel] [Bug 391879] Re: migrate exec ignores exit status

2010-05-20 Thread Daniel P. Berrange
On Thu, May 20, 2010 at 04:50:59PM -, Dave Walker wrote: This is a bug and has been reported upstream, it is unlikely to be fixed at the distribution level and therefore anyone interested in working on this bug should contribute a patch to the upstream project. This will then filter down

Re: [Qemu-devel] [Bug 391879] Re: migrate exec ignores exit status

2010-05-20 Thread Dustin Kirkland
On Thu, May 20, 2010 at 12:11 PM, Daniel P. Berrange berra...@redhat.com wrote: This bug appears to be filed against the Ubuntu qemu component, rather than the upstream qemu component. Are we supposed to be getting notifications for all Ubuntu distro qemu bugs too, rather than just usptream

[Qemu-devel] Re: [PATCH 1/2] arm_timer: reload timer when enabled

2010-05-20 Thread Rabin Vincent
On Sun, May 02, 2010 at 03:20:51PM +0530, Rabin Vincent wrote: Reload the timer when TimerControl is written, if the timer is to be enabled. Otherwise, if an earlier write to TimerLoad was done while periodic mode was not set, s-delta may incorrectly still have the value of the maximum limit

[Qemu-devel] Re: [PATCH 0/6]: QMP: Fix issues in parser/lexer

2010-05-20 Thread Luiz Capitulino
On Thu, 20 May 2010 10:52:58 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 05/20/2010 10:18 AM, Paolo Bonzini wrote: On 05/19/2010 11:43 PM, Anthony Liguori wrote: 4. Lexer expects a 'terminal' char to process a token Which means clients must send a sort of end of line

[Qemu-devel] [Bug 241119] Re: usb_add of a Creative ZEN unrecognized in guest

2010-05-20 Thread Dave Walker
** Also affects: qemu Importance: Undecided Status: New -- usb_add of a Creative ZEN unrecognized in guest https://bugs.launchpad.net/bugs/241119 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: New Status in

[Qemu-devel] [Bug 583462] [NEW] qemu disables screensaver

2010-05-20 Thread Jaap Versteegh
Public bug reported: lucid, with compiz and fglrx: Screensaver on host will not kick in when qemu is running (kvm or no kvm). It seems to be related to the fact that the idle time reported by libXss.so on the host is being reset every four seconds or so when qemu is running, eventhough there is

[Qemu-devel] [Bug 583462] Re: qemu disables screensaver

2010-05-20 Thread Jaap Versteegh
** Attachment added: Code used to check idle time. http://launchpadlibrarian.net/48825708/idletime -- qemu disables screensaver https://bugs.launchpad.net/bugs/583462 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU:

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Luiz Capitulino
On Thu, 20 May 2010 11:55:00 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 05/20/2010 11:27 AM, Luiz Capitulino wrote: On Thu, 20 May 2010 10:50:41 -0500 Anthony Liguorianth...@codemonkey.ws wrote: On 05/20/2010 10:16 AM, Paolo Bonzini wrote: On 05/20/2010 03:44

Re: [Qemu-devel] [PATCH 03/22] tcg-i386: Tidy ext8u and ext16u operations.

2010-05-20 Thread Aurelien Jarno
On Thu, May 20, 2010 at 07:40:59AM -0700, Richard Henderson wrote: On 05/20/2010 07:04 AM, Aurelien Jarno wrote: Do you have tried to compare the generated code before and after your patch? I expect a few cases where your patch has some drawbacks, so I don't know if there is a net gain on

Re: [Qemu-devel] [PATCH 04/22] tcg-i386: Tidy ext8s and ext16s operations.

2010-05-20 Thread Aurelien Jarno
On Tue, Apr 13, 2010 at 04:13:49PM -0700, Richard Henderson wrote: Define OPC_MOVSBL and OPC_MOVSWL. Factor opcode emission to separate functions. Don't restrict the input register to the low 4 q registers; emit shifts instead if needed. Given this patch is of the same type as the previous

[Qemu-devel] Re: [PATCH 2/6] json-lexer: Handle missing escapes

2010-05-20 Thread Anthony Liguori
On 05/20/2010 01:47 PM, Luiz Capitulino wrote: On Thu, 20 May 2010 11:55:00 -0500 Anthony Liguorianth...@codemonkey.ws wrote: On 05/20/2010 11:27 AM, Luiz Capitulino wrote: On Thu, 20 May 2010 10:50:41 -0500 Anthony Liguorianth...@codemonkey.ws wrote: On 05/20/2010

Re: [Qemu-devel] [Bug 391879] Re: migrate exec ignores exit status

2010-05-20 Thread Anthony Liguori
On 05/20/2010 12:11 PM, Daniel P. Berrange wrote: On Thu, May 20, 2010 at 04:50:59PM -, Dave Walker wrote: This is a bug and has been reported upstream, it is unlikely to be fixed at the distribution level and therefore anyone interested in working on this bug should contribute a patch

Re: [Qemu-devel] Re: [PATCH] QEMU: Change default disk caching to nocache

2010-05-20 Thread Anthony Liguori
On 05/20/2010 10:24 AM, Paolo Bonzini wrote: On 05/20/2010 11:32 AM, jes.soren...@redhat.com wrote: +if (bdrv_flags BDRV_O_NOCACHE) { +fprintf(stderr, qemu: failed to open disk image %s as +nocache (O_DIRECT) retrying as write-back\n, file); +

  1   2   >