[Qemu-devel] Qemu contribution but out the GSoC

2011-03-21 Thread Devang S
Hello, This year i am not eligible to participate in gsoc. But really want to contribute to qemu project. Do i have any chance? Do you mentor projects outside gsoc? Can I somehow contribute to qemu project, out of the gsoc? Can I get mentor outside of the gsoc, like

[Qemu-devel] Re: [PATCH 0/2] avoid races on exec migration

2011-03-21 Thread Paolo Bonzini
On 03/09/2011 06:21 PM, Paolo Bonzini wrote: QEMU has a sigchld handler that reaps any child process. -smb is the only user of it and, in fact, QEMU inherited it from slirp. However, this handler causes 'exec' based migration to randomly return 'status: failed' in the monitor. This happens

Re: [Qemu-devel] [PATCH] cocoa: do not create a spurious window for -version

2011-03-21 Thread Tristan Gingold
On Mar 19, 2011, at 2:44 PM, Andreas Färber wrote: Hello Tristan, Am 15.03.2011 um 14:18 schrieb Tristan Gingold: When invoked with -version, qemu will exit just after displaying the version, so there is no need to create a window. Also handles --XXX options. Signed-off-by: Tristan

[Qemu-devel] [PATCH 2/4] vnc: don't mess up with iohandlers in the vnc thread

2011-03-21 Thread Corentin Chary
The threaded VNC servers messed up with QEMU fd handlers without any kind of locking, and that can cause some nasty race conditions. Using qemu_mutex_lock_iothread() won't work because vnc_dpy_cpy(), which will wait for the current job queue to finish, can be called with the iothread lock held.

[Qemu-devel] [PATCH 4/4] vnc: Limit r/w access to size of allocated memory

2011-03-21 Thread Corentin Chary
From: Stefan Weil w...@mail.berlios.de This fixes memory reads and writes which exceeded the upper limit of allocated memory vd-guest.ds-data and vd-server-data. Cc: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Stefan Weil w...@mail.berlios.de Signed-off-by: Corentin Chary

[Qemu-devel] [PATCH 0/4] VNC fixs collection

2011-03-21 Thread Corentin Chary
Hi Anthony, Here are some vnc related patchs that should be merged. Thanks, Corentin Chary (1): vnc: don't mess up with iohandlers in the vnc thread Michael Tokarev (1): vnc: tight: Fix crash after 2GB of output Stefan Weil (1): vnc: Limit r/w access to size of allocated memory Wen

[Qemu-devel] [PATCH 1/4] vnc: tight: Fix crash after 2GB of output

2011-03-21 Thread Corentin Chary
From: Michael Tokarev m...@tls.msk.ru fix 2Gb integer overflow in in VNC tight and zlib encodings As found by Roland Dreier rol...@purestorage.com (excellent catch!), when amount of VNC compressed data produced by zlib and sent to client exceeds 2Gb, integer overflow occurs because currently, we

[Qemu-devel] [PATCH 3/4] fix vnc regression

2011-03-21 Thread Corentin Chary
From: Wen Congyang we...@cn.fujitsu.com This patch fix the following regression: 1. we should use bitmap_set() and bitmap_clear() to replace vnc_set_bits(). Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Corentin Chary corentin.ch...@gmail.com --- ui/vnc.c |8 ++-- 1

[Qemu-devel] Re: [PATCH 3/4] fix vnc regression

2011-03-21 Thread Wen Congyang
At 03/21/2011 04:34 PM, Corentin Chary Write: From: Wen Congyang we...@cn.fujitsu.com This patch fix the following regression: 1. we should use bitmap_set() and bitmap_clear() to replace vnc_set_bits(). Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Corentin Chary

[Qemu-devel] [PATCH] vnc: segmentation fault caused by incorrect 'bytes' count calculated in tight_compress_data()

2011-03-21 Thread Ulrich Obergfell
tight_compress_data() calculates an incorrect 'bytes' count if 'zstream-total_out' is greater than 0x7fff, because the type of the variable 'previous_out' is 'int'. 852 int previous_out; : 872 previous_out = zstream-total_out; : 881 bytes = zstream-total_out

Re: [Qemu-devel] [PATCH] vnc: segmentation fault caused by incorrect 'bytes' count calculated in tight_compress_data()

2011-03-21 Thread Corentin Chary
On Mon, Mar 21, 2011 at 8:48 AM, Ulrich Obergfell uober...@redhat.com wrote: tight_compress_data() calculates an incorrect 'bytes' count if 'zstream-total_out' is greater than 0x7fff, because the type of the variable 'previous_out' is 'int'.    852     int previous_out;     :    872    

Re: [Qemu-devel] Qemu contribution but out the GSoC

2011-03-21 Thread Alexander Graf
Hi Devang, On 21.03.2011, at 09:17, Devang S wrote: Hello, This year i am not eligible to participate in gsoc. But really want to contribute to qemu project. Do i have any chance? Do you mentor projects outside gsoc? Can I somehow contribute to qemu project, out of the gsoc? Can I

Re: [Qemu-devel] Qemu contribution but out the GSoC

2011-03-21 Thread Corentin Chary
On Mon, Mar 21, 2011 at 9:08 AM, Alexander Graf ag...@suse.de wrote: Hi Devang, On 21.03.2011, at 09:17, Devang S wrote: Hello, This year i am not eligible to participate in gsoc. But really want to contribute to qemu project. Do i have any chance? Do you mentor projects outside gsoc?

Re: [Qemu-devel] Qemu contribution but out the GSoC

2011-03-21 Thread Stefan Hajnoczi
On Mon, Mar 21, 2011 at 9:18 AM, Corentin Chary corentin.ch...@gmail.com wrote: On Mon, Mar 21, 2011 at 9:08 AM, Alexander Graf ag...@suse.de wrote: Hi Devang, On 21.03.2011, at 09:17, Devang S wrote: Hello, This year i am not eligible to participate in gsoc. But really want to contribute

[Qemu-devel] [PATCH] vmmouse: Fix initialization

2011-03-21 Thread Jan Kiszka
Latest refactorings left vmmouse nonfunctional behind. Fix it by adding the required device initialization. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/pc.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 4d67d9f..6939c04 100644 ---

[Qemu-devel] [PATCH] vmmouse: Register vmstate via qdev

2011-03-21 Thread Jan Kiszka
Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/vmmouse.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/vmmouse.c b/hw/vmmouse.c index ab8dbd6..1113f33 100644 --- a/hw/vmmouse.c +++ b/hw/vmmouse.c @@ -265,7 +265,6 @@ static int vmmouse_initfn(ISADevice *dev)

[Qemu-devel] [PATCH] vmmouse: Fix typo preventing x86-64 build

2011-03-21 Thread Jan Kiszka
Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- default-configs/x86_64-softmmu.mak |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/default-configs/x86_64-softmmu.mak b/default-configs/x86_64-softmmu.mak index 59b7893..8895028 100644 ---

[Qemu-devel] [PATCH] enable kvm for ppc(32) on ppc64

2011-03-21 Thread René Rebe
ppc64 is backward compatible, likewise. Signed-off-by: René Rebe r...@exactcode.de --- qemu-0.14.0/configure 2011-02-16 14:44:04.0 + +++ qemu-0.14.0-fixed/configure 2011-03-18 16:46:14.0 + @@ -3038,6 +3038,8 @@ \( $target_arch2 = $cpu -o \ \(

Re: [Qemu-devel] [PATCH] vnc: segmentation fault caused by incorrect 'bytes' count calculated in tight_compress_data()

2011-03-21 Thread Ulrich Obergfell
Hi Ulrich, Looks a lot like vnc: tight: Fix crash after 2GB of output, right ? -- Corentin Chary http://xf.iksaif.net Hi Corentin, yes, this appears to be the same issue as: http://lists.gnu.org/archive/html/qemu-devel/2011-03/msg02044.html You posted your patch only a few minutes

[Qemu-devel] [PATCH] fix applesmc REV key

2011-03-21 Thread René Rebe
Fix applesmc REV key string literal hex encoding. Signed-off-by: René Rebe r...@exactcode.de --- qemu-kvm-0.14.0/hw/applesmc.c.vanilla 2011-02-22 18:55:03.73225 + +++ qemu-kvm-0.14.0/hw/applesmc.c 2011-02-22 18:56:08.89225 + @@ -188,7 +188,7 @@

[Qemu-devel] Re: [PATCH] enable kvm for ppc(32) on ppc64

2011-03-21 Thread Alexander Graf
On 21.03.2011, at 11:18, René Rebe wrote: ppc64 is backward compatible, likewise. Signed-off-by: René Rebe r...@exactcode.de Acked-by: Alexander Graf ag...@suse.de --- qemu-0.14.0/configure 2011-02-16 14:44:04.0 + +++ qemu-0.14.0-fixed/configure 2011-03-18

[Qemu-devel] Re: [PATCH] fix applesmc REV key

2011-03-21 Thread Alexander Graf
On 21.03.2011, at 11:33, René Rebe wrote: Fix applesmc REV key string literal hex encoding. Signed-off-by: René Rebe r...@exactcode.de Acked-by: Alexander Graf ag...@suse.de Alex --- qemu-kvm-0.14.0/hw/applesmc.c.vanilla 2011-02-22 18:55:03.73225 + +++

[Qemu-devel] Query: gdbstub software breakpoint removal

2011-03-21 Thread Bhushan Bharat-R65777
Hi All, I can see that the software breakpoint queue is cleared in kvm_remove_breakpoint() in kvm-all.c. I.e QTAILQ_REMOVE(current_env-kvm_state-kvm_sw_breakpoints, bp, entry); is called when the breakpoint is cleared. While the queue is not cleared on kvm_remove_all_breakpoints(); Is there

[Qemu-devel] Re: Query: gdbstub software breakpoint removal

2011-03-21 Thread Jan Kiszka
On 2011-03-21 12:01, Bhushan Bharat-R65777 wrote: Hi All, I can see that the software breakpoint queue is cleared in kvm_remove_breakpoint() in kvm-all.c. I.e QTAILQ_REMOVE(current_env-kvm_state-kvm_sw_breakpoints, bp, entry); is called when the breakpoint is cleared. While the queue

Re: [Qemu-devel] [PATCH v21 00/11] usb-ccid

2011-03-21 Thread Stefan Hajnoczi
On Thu, Mar 17, 2011 at 2:49 PM, Alon Levy al...@redhat.com wrote: This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. It also

[Qemu-devel] Re: [PATCH v3 3/3] piix_pci: optimize set irq path

2011-03-21 Thread Michael S. Tsirkin
On Sat, Mar 19, 2011 at 10:24:52PM +0900, Isaku Yamahata wrote: optimize irq routing in piix_pic.c which has been a TODO. So far piix3 tracks each pirq level and checks whether a given pic pins is asserted by seeing if each pirq is mapped into the pic pin. This is independent on irq routing,

[Qemu-devel] vnc: severe memory leak caused by broken palette_destroy() function

2011-03-21 Thread Ulrich Obergfell
The following commit breaks the code of the function palette_destroy(). http://git.kernel.org/?p=virt/kvm/qemu-kvm.git;a=commit;h=e31e3694afef58ba191cbcc6875ec243e5971268 The broken code causes a severe memory leak of 'VncPalette' structures because it never frees anything: 70 void

Re: [Qemu-devel] [PATCH v21 00/11] usb-ccid

2011-03-21 Thread Alon Levy
On Mon, Mar 21, 2011 at 11:33:57AM +, Stefan Hajnoczi wrote: On Thu, Mar 17, 2011 at 2:49 PM, Alon Levy al...@redhat.com wrote: This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card

[Qemu-devel] Trip Report -- 1st QEMU Users Forum, Grenoble, 18 March 2011

2011-03-21 Thread Peter Maydell
I went to the first QEMU Users Forum in Grenoble last week; this is my impressions and summary of what happened. I posted this to linaro-toolchain and it was suggested that qemu-devel folks might be interested in it too. Sorry if it's a bit TLDR... == Summary and general observations == This was

[Qemu-devel] Re: [PATCH v3 3/3] piix_pci: optimize set irq path

2011-03-21 Thread Isaku Yamahata
On Mon, Mar 21, 2011 at 01:37:07PM +0200, Michael S. Tsirkin wrote: +static int piix3_post_load(void *opaque, int version_id) +{ +PIIX3State *piix3 = opaque; +piix3_update_irq_levels(piix3); Couldn't figure out why would we not want to propagate the interrupts here. Could you

Re: [Qemu-devel] [PATCH] block: Flush image after open

2011-03-21 Thread Avi Kivity
On 03/09/2011 07:38 PM, Anthony Liguori wrote: On 03/09/2011 11:27 AM, Christoph Hellwig wrote: On Wed, Mar 09, 2011 at 05:15:53PM +0100, Kevin Wolf wrote: Quoting the bug report: qemu ensures that guest writes and qemu metadata writes hit the disk when necessary to prevent data

Re: [Qemu-devel] [PATCH v21 00/11] usb-ccid

2011-03-21 Thread Alon Levy
On Mon, Mar 21, 2011 at 11:33:57AM +, Stefan Hajnoczi wrote: On Thu, Mar 17, 2011 at 2:49 PM, Alon Levy al...@redhat.com wrote: This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card

[Qemu-devel] Re: [PATCH v3 3/3] piix_pci: optimize set irq path

2011-03-21 Thread Isaku Yamahata
On Mon, Mar 21, 2011 at 01:37:07PM +0200, Michael S. Tsirkin wrote: +/* irq routing is changed. so rebuild bitmap */ +static void piix3_update_irq_levels(PIIX3State *piix3) +{ +int pirq; + +piix3-pic_levels = 0; +for (pirq = 0; pirq PIIX_NUM_PIRQS; pirq++) { +

Re: [Qemu-devel] [PATCH v21 01/11] trace: move trace objects from Makefile to Makefile.objs

2011-03-21 Thread Stefan Hajnoczi
On Thu, Mar 17, 2011 at 5:23 PM, Alon Levy al...@redhat.com wrote: On Thu, Mar 17, 2011 at 04:45:15PM +, Stefan Hajnoczi wrote: On Thu, Mar 17, 2011 at 3:00 PM, Alon Levy al...@redhat.com wrote: On Thu, Mar 17, 2011 at 04:49:26PM +0200, Alon Levy wrote: ---  Makefile      |   32

[Qemu-devel] Re: [PATCH v3 3/3] piix_pci: optimize set irq path

2011-03-21 Thread Michael S. Tsirkin
On Mon, Mar 21, 2011 at 09:10:32PM +0900, Isaku Yamahata wrote: On Mon, Mar 21, 2011 at 01:37:07PM +0200, Michael S. Tsirkin wrote: +static int piix3_post_load(void *opaque, int version_id) +{ +PIIX3State *piix3 = opaque; +piix3_update_irq_levels(piix3); Couldn't figure

[Qemu-devel] Re: [PATCH master, stable] virtio-pci: fix bus master work around on load

2011-03-21 Thread Alexander Graf
On 19.03.2011, at 23:30, Michael S. Tsirkin wrote: Commit c81131db15dd1844d0db1d51f3cd7a105cfd2cf3 detects old guests by comparing virtio and PCI status. It attempts to do this on load, as well, but load_config callback in a binding is invoked too early and so the virtio status isn't set

Re: [Qemu-devel] vnc: severe memory leak caused by broken palette_destroy() function

2011-03-21 Thread Stefan Hajnoczi
On Mon, Mar 21, 2011 at 11:52 AM, Ulrich Obergfell uober...@redhat.com wrote: The following commit breaks the code of the function palette_destroy(). http://git.kernel.org/?p=virt/kvm/qemu-kvm.git;a=commit;h=e31e3694afef58ba191cbcc6875ec243e5971268 The broken code causes a severe memory leak

[Qemu-devel] Re: [PATCH v3 3/3] piix_pci: optimize set irq path

2011-03-21 Thread Isaku Yamahata
On Mon, Mar 21, 2011 at 02:31:11PM +0200, Michael S. Tsirkin wrote: On Mon, Mar 21, 2011 at 09:10:32PM +0900, Isaku Yamahata wrote: On Mon, Mar 21, 2011 at 01:37:07PM +0200, Michael S. Tsirkin wrote: +static int piix3_post_load(void *opaque, int version_id) +{ +PIIX3State *piix3

Re: [Qemu-devel] [PATCH] block: Flush image after open

2011-03-21 Thread Kevin Wolf
Am 21.03.2011 13:23, schrieb Avi Kivity: On 03/09/2011 07:38 PM, Anthony Liguori wrote: On 03/09/2011 11:27 AM, Christoph Hellwig wrote: On Wed, Mar 09, 2011 at 05:15:53PM +0100, Kevin Wolf wrote: Quoting the bug report: qemu ensures that guest writes and qemu metadata writes hit the

[Qemu-devel] KVM call agenda for Mars 21th

2011-03-21 Thread Juan Quintela
Please, send in any agenda items you are interested in covening. - Merge patches speed. I just feel, that patches are not being handled fast enough, so ... I looked how much patches have been integrated since Mars 1st: (master)$ g log --pretty=fuller

[Qemu-devel] Re: [PATCH v3 3/3] piix_pci: optimize set irq path

2011-03-21 Thread Michael S. Tsirkin
On Mon, Mar 21, 2011 at 09:56:56PM +0900, Isaku Yamahata wrote: On Mon, Mar 21, 2011 at 02:31:11PM +0200, Michael S. Tsirkin wrote: On Mon, Mar 21, 2011 at 09:10:32PM +0900, Isaku Yamahata wrote: On Mon, Mar 21, 2011 at 01:37:07PM +0200, Michael S. Tsirkin wrote: +static int

[Qemu-devel] [PATCH 1/7] virtio-serial: Use a struct to pass config information from proxy

2011-03-21 Thread Amit Shah
Instead of using a single variable to pass to the virtio_serial_init function, use a struct so that expanding the number of variables to be passed on later is easier. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-pci.c| 12 ++-- hw/virtio-serial-bus.c | 16

[Qemu-devel] [PULL #7 0/7] virtio-serial fixes, enhancements

2011-03-21 Thread Amit Shah
Hello, This series fixes a few bugs reported against virtio-serial. Please apply. The following changes since commit e0efb993b817564ef84e462ac1fe35f89b57ad7b: Fix conversions from pointer to int and vice versa (2011-03-20 21:39:23 +) are available in the git repository at:

[Qemu-devel] [PATCH 2/7] virtio-serial: Disallow generic ports at id 0

2011-03-21 Thread Amit Shah
Port 0 is reserved for virtconsole devices for backward compatibility with the old -virtioconsole (from qemu 0.12) device type. libvirt prior to commit 8e28c5d40200b4c5d483bd585d237b9d870372e5 used port 0 for generic ports. libvirt will no longer do that, but disallow instantiating generic ports

[Qemu-devel] [PATCH 4/7] virtio-serial-bus: Simplify handle_output() function

2011-03-21 Thread Amit Shah
There's no code change, just re-arrangement to simplify the function after recent modifications. Reported-by: Juan Quintela quint...@redhat.com Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-serial-bus.c | 12 +++- 1 files changed, 3 insertions(+), 9 deletions(-) diff

[Qemu-devel] [PATCH 3/7] virtio-serial: Enable ioeventfd

2011-03-21 Thread Amit Shah
Enable ioeventfd for virtio-serial devices by default. Commit 25db9ebe15125deb32958c6df74996f745edf1f9 lists the benefits of using ioeventfd. Copying a file from guest to host over a virtio-serial channel didn't show much difference in time or io_exit rate. Signed-off-by: Amit Shah

[Qemu-devel] [PATCH 7/7] char: Prevent multiple devices opening same chardev

2011-03-21 Thread Amit Shah
Prevent: -chardev socket,path=/tmp/foo,server,nowait,id=c0 \ -device virtserialport,chardev=c0,id=vs0 \ -device virtserialport,chardev=c0,id=vs1 Reported-by: Mike Cao b...@redhat.com Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/qdev-properties.c |7 ++- qemu-char.c |

[Qemu-devel] [PATCH 6/7] virtio-console: Keep chardev open for other users after hot-unplug

2011-03-21 Thread Amit Shah
After a hot-unplug operation, the previous behaviour was to close the chardev. That meant the chardev couldn't be re-used. Also, since chardev hot-plug isn't possible so far, this means virtio-console hot-plug isn't feasible as well. With this change, the chardev is kept around. A new

[Qemu-devel] [PATCH 5/7] virtio-serial: Don't clear -have_data() pointer after unplug

2011-03-21 Thread Amit Shah
After a port unplug operation, the port-info-have_data() pointer was set to NULL. The problem is, the -info struct is shared by all ports, effectively disabling writes to other ports. Reported-by: juzhang juzh...@redhat.com Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-console.c |

Re: [Qemu-devel] [PATCH] block: Flush image after open

2011-03-21 Thread Avi Kivity
On 03/21/2011 03:02 PM, Kevin Wolf wrote: Am 21.03.2011 13:23, schrieb Avi Kivity: On 03/09/2011 07:38 PM, Anthony Liguori wrote: On 03/09/2011 11:27 AM, Christoph Hellwig wrote: On Wed, Mar 09, 2011 at 05:15:53PM +0100, Kevin Wolf wrote: Quoting the bug report: qemu ensures that

Re: [Qemu-devel] [PATCH v21 00/11] usb-ccid

2011-03-21 Thread Stefan Hajnoczi
On Mon, Mar 21, 2011 at 12:24 PM, Alon Levy al...@redhat.com wrote: Thanks, this should fix it: diff --git a/Makefile.target b/Makefile.target index baa5c3f..fef56b4 100644 --- a/Makefile.target +++ b/Makefile.target Thanks it fixes it. I didn't have libnss3-dev installed. Stefan

Re: [Qemu-devel] [PATCH v21 00/11] usb-ccid

2011-03-21 Thread Hans de Goede
Ack series Acked-by: Hans de Goede hdego...@redhat.com On 03/17/2011 03:49 PM, Alon Levy wrote: This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone

[Qemu-devel] Re: [PULL 0/9] Block patches

2011-03-21 Thread Kevin Wolf
Am 16.03.2011 11:47, schrieb Kevin Wolf: The following changes since commit cc015e9a5dde2f03f123357fa060acbdfcd570a4: add Win32 IPI service (2011-03-13 14:44:22 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Brian Wheeler (1): Fix

[Qemu-devel] [PULL] allow arbitrary scaling of timers

2011-03-21 Thread Paolo Bonzini
On 03/14/2011 08:14 AM, Paolo Bonzini wrote: On 03/13/2011 12:33 AM, Anthony Liguori wrote: Really nice series. The whole thing Reviewed-by: Anthony Liguori aligu...@us.ibm.com Did you really mean to RFC this? I don't think there's any sort of problem applying this as it's mostly

[Qemu-devel] re: PRoot: A Step Forward for QEMU User-Mode

2011-03-21 Thread Riku Voipio
Hi, First, thanks for the report! On Mon, Mar 21, 2011 at 12:09:10PM +, Peter Maydell wrote: == Talk 11: PRoot: A Step Forward for QEMU User-Mode == STMicroelectronics again, presenting an alternative to the usual chroot plus binfmt_misc approach for running target binaries seamlessly

Re: [Qemu-devel] [PATCH] target-arm/helper.c: For float-int conversion helpers pass ints as ints

2011-03-21 Thread Nathan Froyd
On Mon, Mar 14, 2011 at 05:23:11PM +, Peter Maydell wrote: Correct the argument and return types for the float-int conversion helper functions so that integer arguments and return values are declared as uint32_t/uint64_t, not float32/float64. This allows us to remove the hand-rolled

Re: [Qemu-devel] [PATCH] target-arm/helper.c: For float-int conversion helpers pass ints as ints

2011-03-21 Thread Peter Maydell
On 21 March 2011 13:48, Nathan Froyd froy...@codesourcery.com wrote: On Mon, Mar 14, 2011 at 05:23:11PM +, Peter Maydell wrote: Correct the argument and return types for the float-int conversion helper functions so that integer arguments and return values are declared as uint32_t/uint64_t,

Re: [Qemu-devel] [PATCH] target-arm/helper.c: For float-int conversion helpers pass ints as ints

2011-03-21 Thread Nathan Froyd
On Mon, Mar 21, 2011 at 02:04:31PM +, Peter Maydell wrote: On 21 March 2011 13:48, Nathan Froyd froy...@codesourcery.com wrote: I like the direction this patch goes; you aren't by any chance going to convert the passing/returning of float* to their appropriate int* types too, are you?

[Qemu-devel] Re: [PATCH v3 3/3] piix_pci: optimize set irq path

2011-03-21 Thread Michael S. Tsirkin
On Sat, Mar 19, 2011 at 10:24:52PM +0900, Isaku Yamahata wrote: optimize irq routing in piix_pic.c which has been a TODO. So far piix3 tracks each pirq level and checks whether a given pic pins is asserted by seeing if each pirq is mapped into the pic pin. This is independent on irq routing,

Re: [Qemu-devel] [PATCH] target-arm/helper.c: For float-int conversion helpers pass ints as ints

2011-03-21 Thread Peter Maydell
On 21 March 2011 14:09, Nathan Froyd froy...@codesourcery.com wrote: I'm just concerned about what would happen if we turned on softfloat's float types are structure types bit; I'm pretty sure everything would break horribly on targets that don't pass small structures in registers.  

[Qemu-devel] Moving beyond image files

2011-03-21 Thread Anthony Liguori
We've been evaluating block migration in a real environment to try to understand what the overhead of it is compared to normal migration. The results so far are pretty disappointing. The speed of local disks ends up becoming a big bottleneck even before the network does. This has got me

Re: [Qemu-devel] [PATCH] [PPC] Add support for 6 SPE instructions (evmra, evmwsmi{a{a}}, evmwumi{a{a}})

2011-03-21 Thread Nathan Froyd
On Wed, Mar 16, 2011 at 11:21:22AM +0100, Fabien Chouteau wrote: Signed-off-by: Fabien Chouteau chout...@adacore.com Reviewed-by: Nathan Froyd froy...@codesourcery.com -Nathan

Re: [Qemu-devel] Moving beyond image files

2011-03-21 Thread Alexander Graf
On 21.03.2011, at 16:05, Anthony Liguori wrote: We've been evaluating block migration in a real environment to try to understand what the overhead of it is compared to normal migration. The results so far are pretty disappointing. The speed of local disks ends up becoming a big

Re: [Qemu-devel] Moving beyond image files

2011-03-21 Thread Anthony Liguori
On 03/21/2011 10:16 AM, Alexander Graf wrote: On 21.03.2011, at 16:05, Anthony Liguori wrote: 5) Copy-on-write references potentially become very interesting for image streaming because you can avoid any I/O for blocks that are already stored locally. This is not fully baked yet but I

[Qemu-devel] RE: Query: gdbstub software breakpoint removal

2011-03-21 Thread Bhushan Bharat-R65777
Hi Jan, I will send a patch. Thanks -Bharat -Original Message- From: Jan Kiszka [mailto:jan.kis...@siemens.com] Sent: Monday, March 21, 2011 5:04 PM To: Bhushan Bharat-R65777 Cc: qemu-devel@nongnu.org Subject: Re: Query: gdbstub software breakpoint removal On 2011-03-21 12:01,

[Qemu-devel] [PATCH 0/2] Let boards state maximum RAM limits in QEMUMachine struct

2011-03-21 Thread Peter Maydell
This fairly simple patchset adds a new 'max_ram' field to the QEMUMachine structure so that a board model can specify the maximum RAM it will accept. We can then produce a friendly diagnostic message when the user tries to start qemu with a '-m' option asking for more RAM than that. (Currently

[Qemu-devel] [PATCH 2/2] hw: Add maximum RAM specifications for ARM devboard models

2011-03-21 Thread Peter Maydell
Specify the maximum memory permitted for the various ARM devboard models (integratorcp, realview-eb, realview-eb-mpcore, realview-pb-a8, realview-pbx-a9, versatilepb, versatileab). This means we now handle attempts to specify too much RAM gracefully rather than causing the guest to crash in an

[Qemu-devel] [PATCH 1/2] Allow boards to specify maximum RAM size

2011-03-21 Thread Peter Maydell
Allow boards to specify their maximum RAM size in the QEMUMachine struct. This allows us to provide a useful diagnostic if the user tries to specify a RAM size that the board cannot support. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/boards.h |1 + vl.c| 16

[Qemu-devel] OVMF, SeaBIOS non-CSM based legacy boot

2011-03-21 Thread Jordan Justen
This weekend I spent some time working on loading SeaBIOS from OVMF to start a legacy boot. I was able to get x86 x86-64 Linux to legacy boot using this method. Unfortunately, (I think) it is not nearly as nice a having a true CSM. Basically, you have to decide at some point in the OVMF boot

Re: [Qemu-devel] OVMF, SeaBIOS non-CSM based legacy boot

2011-03-21 Thread Anthony Liguori
On 03/21/2011 01:14 PM, Jordan Justen wrote: This weekend I spent some time working on loading SeaBIOS from OVMF to start a legacy boot. I was able to get x86 x86-64 Linux to legacy boot using this method. Unfortunately, (I think) it is not nearly as nice a having a true CSM. Basically, you

[Qemu-devel] [PATCH] v9fs_walk: As per 9p2000 RFC, MAXWELEM = nwnames = 0.

2011-03-21 Thread Harsh Prateek Bora
The nwnames field in TWALK message is assumed to be =0 and = MAXWELEM which is defined as macro P9_MAXWELEM (16) in virtio-9p.h as per 9p2000 RFC. Appropriate changes are required in V9fsWalkState and v9fs_walk. Signed-off-by: Harsh Prateek Bora ha...@linux.vnet.ibm.com --- hw/9pfs/virtio-9p.c |

Re: [Qemu-devel] [PATCH 0/2] Let boards state maximum RAM limits in QEMUMachine struct

2011-03-21 Thread Anthony Liguori
On 03/21/2011 12:47 PM, Peter Maydell wrote: This fairly simple patchset adds a new 'max_ram' field to the QEMUMachine structure so that a board model can specify the maximum RAM it will accept. We can then produce a friendly diagnostic message when the user tries to start qemu with a '-m'

Re: [Qemu-devel] [PATCH v3 1/2] hw/arm_sysctl.c: Add the Versatile Express system registers

2011-03-21 Thread Aurelien Jarno
On Mon, Mar 07, 2011 at 11:10:31AM +, Peter Maydell wrote: Add support for the Versatile Express SYS_CFG registers, which provide a generic means of reading or writing configuration information from various parts of the board. We only implement shutdown and reset. Also make the RESETCTL

Re: [Qemu-devel] [PATCH v3 2/2] hw/vexpress.c: Add model of ARM Versatile Express board

2011-03-21 Thread Aurelien Jarno
On Mon, Mar 07, 2011 at 11:10:32AM +, Peter Maydell wrote: Add a model of the ARM Versatile Express board (with A9MPx4 daughterboard). Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- Makefile.target |1 + hw/vexpress.c | 224

Re: [Qemu-devel] [PATCH v2] e1000: Fix multi-descriptor packet checksum offload

2011-03-21 Thread Aurelien Jarno
On Mon, Mar 07, 2011 at 08:04:07PM +, Stefan Hajnoczi wrote: The PCI/PCI-X Family of Gigabit Ethernet Controllers Software Developer’s Manual states the following about the POPTS field: Provides a number of options which control the handling of this packet. This field is ignored

Re: [Qemu-devel] [PULL] allow arbitrary scaling of timers

2011-03-21 Thread Aurelien Jarno
On Mon, Mar 21, 2011 at 02:35:32PM +0100, Paolo Bonzini wrote: On 03/14/2011 08:14 AM, Paolo Bonzini wrote: On 03/13/2011 12:33 AM, Anthony Liguori wrote: Really nice series. The whole thing Reviewed-by: Anthony Liguori aligu...@us.ibm.com Did you really mean to RFC this? I don't

Re: [Qemu-devel] Re: [PULL 0/9] Block patches

2011-03-21 Thread Aurelien Jarno
On Mon, Mar 21, 2011 at 02:31:37PM +0100, Kevin Wolf wrote: Am 16.03.2011 11:47, schrieb Kevin Wolf: The following changes since commit cc015e9a5dde2f03f123357fa060acbdfcd570a4: add Win32 IPI service (2011-03-13 14:44:22 +) are available in the git repository at:

Re: [Qemu-devel] [PATCH 0/2] Let boards state maximum RAM limits in QEMUMachine struct

2011-03-21 Thread Brad Hards
On Tue, 22 Mar 2011 04:47:18 am Peter Maydell wrote: This fairly simple patchset adds a new 'max_ram' field to the QEMUMachine structure so that a board model can specify the maximum RAM it will accept. We can then produce a friendly diagnostic message when the user tries to start qemu with a

Re: [Qemu-devel] OVMF, SeaBIOS non-CSM based legacy boot

2011-03-21 Thread Stefan Hajnoczi
On Mon, Mar 21, 2011 at 6:27 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 03/21/2011 01:14 PM, Jordan Justen wrote: This weekend I spent some time working on loading SeaBIOS from OVMF to start a legacy boot.  I was able to get x86  x86-64 Linux to legacy boot using this method.

Re: [Qemu-devel] [PATCH v5 04/10] softfloat: Drop [u]int16 types in favor of [u]int_fast16_t

2011-03-21 Thread Aurelien Jarno
On Tue, Mar 08, 2011 at 07:54:39PM +0100, Andreas Färber wrote: Am 08.03.2011 um 09:29 schrieb Peter Maydell: Maybe we should have a patchset that does the uncontroversial change (bits32-uint32_t c, which I think should be purely mechanical) while we argue about this bit? That should be

Re: [Qemu-devel] [PATCH] v9fs_walk: As per 9p2000 RFC, MAXWELEM = nwnames = 0.

2011-03-21 Thread Stefan Hajnoczi
On Mon, Mar 21, 2011 at 6:31 PM, Harsh Prateek Bora ha...@linux.vnet.ibm.com wrote: The nwnames field in TWALK message is assumed to be =0 and = MAXWELEM which is defined as macro P9_MAXWELEM (16) in virtio-9p.h as per 9p2000 RFC. Appropriate changes are required in V9fsWalkState and v9fs_walk.

Re: [Qemu-devel] OVMF, SeaBIOS non-CSM based legacy boot

2011-03-21 Thread Michael Brown
On Monday 21 Mar 2011 21:06:24 Stefan Hajnoczi wrote: On Mon, Mar 21, 2011 at 6:27 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 03/21/2011 01:14 PM, Jordan Justen wrote: This weekend I spent some time working on loading SeaBIOS from OVMF to start a legacy boot. I was able to get

Re: [Qemu-devel] [PATCH v3 2/2] hw/vexpress.c: Add model of ARM Versatile Express board

2011-03-21 Thread Peter Maydell
On 21 March 2011 20:41, Aurelien Jarno aurel...@aurel32.net wrote: On Mon, Mar 07, 2011 at 11:10:32AM +, Peter Maydell wrote: +    /* 0x4e00 LAN9118 Ethernet */ +    if (nd_table[0].vlan) { +        lan9118_init(nd_table[0], 0x4e00, pic[15]); +    } It basically means we

Re: [Qemu-devel] OVMF, SeaBIOS non-CSM based legacy boot

2011-03-21 Thread Jordan Justen
On Mon, Mar 21, 2011 at 11:27, Anthony Liguori anth...@codemonkey.ws wrote: On 03/21/2011 01:14 PM, Jordan Justen wrote: This weekend I spent some time working on loading SeaBIOS from OVMF to start a legacy boot.  I was able to get x86  x86-64 Linux to legacy boot using this method.

Re: [Qemu-devel] OVMF, SeaBIOS non-CSM based legacy boot

2011-03-21 Thread Jordan Justen
On Mon, Mar 21, 2011 at 14:17, Michael Brown mbr...@fensystems.co.uk wrote: On Monday 21 Mar 2011 21:06:24 Stefan Hajnoczi wrote: On Mon, Mar 21, 2011 at 6:27 PM, Anthony Liguori anth...@codemonkey.ws Is there gPXE for UEFI yet? I have never tried it myself, but I think it should work.  CCed

Re: [Qemu-devel] [PATCH] v9fs_walk: As per 9p2000 RFC, MAXWELEM = nwnames = 0.

2011-03-21 Thread Venkateswararao Jujjuri (JV)
On 3/21/2011 2:16 PM, Stefan Hajnoczi wrote: On Mon, Mar 21, 2011 at 6:31 PM, Harsh Prateek Bora ha...@linux.vnet.ibm.com wrote: The nwnames field in TWALK message is assumed to be =0 and = MAXWELEM which is defined as macro P9_MAXWELEM (16) in virtio-9p.h as per 9p2000 RFC. Appropriate

Re: [Qemu-devel] Moving beyond image files

2011-03-21 Thread Stefan Hajnoczi
On Mon, Mar 21, 2011 at 3:05 PM, Anthony Liguori aligu...@us.ibm.com wrote: 2) The daemon maintains metadata for each image that includes an extent mapping and then a clustered allocated bitmap within each extent (similar to FVD). s/clustered allocated bitmap/cluster allocation bitmap/ ? 3)

Re: [Qemu-devel] [PATCH] v9fs_walk: As per 9p2000 RFC, MAXWELEM = nwnames = 0.

2011-03-21 Thread Venkateswararao Jujjuri (JV)
On 3/21/2011 2:34 PM, Venkateswararao Jujjuri (JV) wrote: On 3/21/2011 2:16 PM, Stefan Hajnoczi wrote: On Mon, Mar 21, 2011 at 6:31 PM, Harsh Prateek Bora ha...@linux.vnet.ibm.com wrote: The nwnames field in TWALK message is assumed to be =0 and = MAXWELEM which is defined as macro

Re: [Qemu-devel] OVMF, SeaBIOS non-CSM based legacy boot

2011-03-21 Thread Stefan Hajnoczi
On Mon, Mar 21, 2011 at 9:17 PM, Michael Brown mbr...@fensystems.co.uk wrote: On Monday 21 Mar 2011 21:06:24 Stefan Hajnoczi wrote: On Mon, Mar 21, 2011 at 6:27 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 03/21/2011 01:14 PM, Jordan Justen wrote: This weekend I spent some time

[Qemu-devel] Re: CPU type qemu64 breaks guest code

2011-03-21 Thread Andre Przywara
On 03/14/2011 03:13 PM, Alexander Graf wrote: Hi guys, While I was off on vacation a pretty nasty bug emerged. It's our old friend the non-existent -cpu qemu64 CPU type. To refresh your memories, this is the definition of the default 64-bit CPU type in Qemu: { .name = qemu64,

Re: [Qemu-devel] eepro100 and qemu0.14: unknown word write

2011-03-21 Thread Alex Williamson
2011/3/21 Sébastien BRICE s...@so-sweet.org: Hi everyone I have been using qemu-kvm with success the last two years and its really amazing. I am new to this mailing list and i am requesting your assistance because i struggle to have my virtual card working with an 'exotic' virtual System

[Qemu-devel] [PATCH v22 01/11] trace: move trace objects from Makefile to Makefile.objs

2011-03-21 Thread Alon Levy
--- Makefile | 32 Makefile.objs | 32 2 files changed, 32 insertions(+), 32 deletions(-) diff --git a/Makefile b/Makefile index 89e88b4..209e14d 100644 --- a/Makefile +++ b/Makefile @@ -112,38 +112,6 @@ ui/vnc.o:

[Qemu-devel] [PATCH v22 02/11] qemu-thread.h: include inttypes.h

2011-03-21 Thread Alon Levy
qemu-thread.h relies on uint64_t being defined, but doesn't include inttypes.h explicitly. This makes it easier to use it from vscclient (part of libcacard). --- qemu-thread.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/qemu-thread.h b/qemu-thread.h index

[Qemu-devel] [PATCH v22 00/11] usb-ccid

2011-03-21 Thread Alon Levy
This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. It also introduces a new directory libcaccard with CAC card emulation, CAC is a type of

[Qemu-devel] [PATCH v22 09/11] libcacard: add docs

2011-03-21 Thread Alon Levy
From: Robert Relyea rrel...@redhat.com --- docs/libcacard.txt | 483 1 files changed, 483 insertions(+), 0 deletions(-) create mode 100644 docs/libcacard.txt diff --git a/docs/libcacard.txt b/docs/libcacard.txt new file mode 100644 index

[Qemu-devel] [PATCH v22 04/11] introduce libcacard/vscard_common.h

2011-03-21 Thread Alon Levy
--- Signed-off-by: Alon Levy al...@redhat.com v20-v21 changes: (Jes Sorenson review) * license set to 2+ * long comment fixes, remove empty line at eof. * add reference to COPYING v19-v20 changes: * checkpatch.pl v15-v16 changes: Protocol change: * VSCMsgInit capabilities and magic *

[Qemu-devel] [PATCH v22 03/11] usb-ccid: add CCID bus

2011-03-21 Thread Alon Levy
A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1]

[Qemu-devel] [PATCH v22 11/11] ccid: add docs

2011-03-21 Thread Alon Levy
Add documentation for the usb-ccid device and accompanying two card devices, ccid-card-emulated and ccid-card-passthru. Signed-off-by: Alon Levy al...@redhat.com --- docs/ccid.txt | 135 + 1 files changed, 135 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH v22 08/11] libcacard: add passthru

2011-03-21 Thread Alon Levy
From: Robert Relyea rrel...@redhat.com In this mode libcacard doesn't emulate a card, but just passes apdu's straight to the underlying card. Not to be confused with ccid-card-passthru, which doesn't use libcacard at all. So with this functionality in libcacard you can talk directly to the host

[Qemu-devel] [PATCH v22 07/11] libcacard: add vscclient

2011-03-21 Thread Alon Levy
From: Robert Relyea rrel...@redhat.com client to talk to ccid-card-passthru and use smartcard on client to perform actual operations. --- libcacard/Makefile|7 +- libcacard/vscclient.c | 730 + 2 files changed, 736 insertions(+), 1

  1   2   >