Re: [Qemu-devel] Para-virtualized ram-based filesystem?

2011-04-18 Thread Avi Kivity
On 04/18/2011 06:28 AM, Ritchie, Stuart wrote: On 4/17/11 5:43 AM, Avi Kivitya...@redhat.com wrote: On 04/16/2011 02:58 AM, Ritchie, Stuart wrote: You can do this with ivshmem today. You give it a path to a shared memory file, and then there's a path in sysfs that you can mmap() in

Re: [Qemu-devel] [PATCH 5/5] target-alpha: Emulate Alpha SX164.

2011-04-18 Thread Paolo Bonzini
On 04/17/2011 08:31 PM, Alexander Graf wrote: On 17.04.2011, at 20:26, Richard Henderson wrote: On 04/17/2011 11:23 AM, Alexander Graf wrote: We try to keep a reference in pc-bios/README on where it comes from and Anthony usually wants you to also add git submodule magic for easy cloning :).

[Qemu-devel] [PATCH] Don't zero out buffer in sched_getaffinity

2011-04-18 Thread Mike McCormack
The kernel doesn't fill the buffer provided to sched_getaffinity with zero bytes, so neither should QEMU. Depends on sched_getaffinity buffer overrun fix, but submitted separately to make rollback easier. --- linux-user/syscall.c | 13 + 1 files changed, 1 insertions(+), 12

Re: [Qemu-devel] [PATCH 24/26] acpi, acpi_piix: factor out GPE logic

2011-04-18 Thread Isaku Yamahata
On Sun, Apr 17, 2011 at 06:53:12PM +0300, Avi Kivity wrote: On 04/17/2011 04:50 PM, Isaku Yamahata wrote: On Sun, Apr 17, 2011 at 04:17:51PM +0300, Avi Kivity wrote: On 03/16/2011 11:29 AM, Isaku Yamahata wrote: factor out ACPI GPE logic. Later it will be used by ICH9 ACPI. I think

Re: [Qemu-devel] [PATCH 24/26] acpi, acpi_piix: factor out GPE logic

2011-04-18 Thread Avi Kivity
On 04/18/2011 10:47 AM, Isaku Yamahata wrote: Hmm but it seems that there is another issue. With the previous patch, I confirmed sts and en are saved as expected. The related VMStateDescription are defined in acpi_piix.c in the following order. vmstate_acpi calls vmstate_gpe. andvmstate_gpe

Re: [Qemu-devel] [PATCH v3] hw/pc: Support system flash memory with -pflash parameter

2011-04-18 Thread Aurelien Jarno
On Thu, Mar 31, 2011 at 11:25:26AM -0700, Jordan Justen wrote: If -pflash is specified and -bios is specified then pflash will be mapped just below the system rom using hw/pflash_cfi01.c. If -pflash is specified on the command line, but -bios is not specified, then 'bios.bin' will NOT be

Re: [Qemu-devel] [PATCH] Don't zero out buffer in sched_getaffinity

2011-04-18 Thread Stefan Hajnoczi
On Mon, Apr 18, 2011 at 8:03 AM, Mike McCormack mj.mccorm...@samsung.com wrote: The kernel doesn't fill the buffer provided to sched_getaffinity with zero bytes, so neither should QEMU. Depends on sched_getaffinity buffer overrun fix, but submitted separately to make rollback easier. ---  

Re: [Qemu-devel] [PATCH 5/5] target-alpha: Emulate Alpha SX164.

2011-04-18 Thread Peter Maydell
On 17 April 2011 18:11, Richard Henderson r...@twiddle.net wrote: On 04/17/2011 10:03 AM, Peter Maydell wrote: On 17 April 2011 17:14, Richard Henderson r...@twiddle.net wrote:  pc-bios/palcode-sx164             |  Bin 0 - 107781 bytes My personal opinion is that if we have the binary blob in

Re: [Qemu-devel] Question about vpc 004 testcase of qemu-iotests

2011-04-18 Thread Stefan Hajnoczi
On Sun, Apr 17, 2011 at 8:21 AM, Lyu Mitnick mitnick@gmail.com wrote:  write at image boundary -write failed: Input/output error +wrote 4096/4096 bytes at offset 134217728 +4 KiB, 1 ops; 0. sec (28.678 KiB/sec and 7.1694 ops/sec) The point of this test is to check that I/O past the

Re: [Qemu-devel] iPXE/Etherboot prompts twice for booting?

2011-04-18 Thread Stefan Hajnoczi
On Sat, Apr 16, 2011 at 8:41 PM, Michael Tokarev m...@tls.msk.ru wrote: I'm playing with iPXE ROM images again, and see iPXE prompts two times during bootup.  Once like this: Press Ctrl-B to configure, at early stage, even if -boot n is not selected.  And second time when it actually tries to

[Qemu-devel] KVM call agenda for April 19th

2011-04-18 Thread Juan Quintela
Please, send in any agenda items you are interested in covering. Later, Juan.

[Qemu-devel] Enhancing qemu-img convert format compatibility

2011-04-18 Thread Stefan Hajnoczi
qemu-img is a pretty good Rosetta stone for image formats but it is missing support some format versions. In order to bring qemu-img up-to-date with the latest disk image formats we will need to find specific image files and/or software versions that produce image files that qemu-img cannot

Re: [Qemu-devel] Enhancing qemu-img convert format compatibility

2011-04-18 Thread Richard W.M. Jones
On Mon, Apr 18, 2011 at 11:18:42AM +0100, Stefan Hajnoczi wrote: qemu-img is a pretty good Rosetta stone for image formats but it is missing support some format versions. In order to bring qemu-img up-to-date with the latest disk image formats we will need to find specific image files and/or

Re: [Qemu-devel] Enhancing qemu-img convert format compatibility

2011-04-18 Thread Stefan Hajnoczi
On Mon, Apr 18, 2011 at 12:03 PM, Richard W.M. Jones rjo...@redhat.com wrote: On Mon, Apr 18, 2011 at 11:18:42AM +0100, Stefan Hajnoczi wrote: qemu-img is a pretty good Rosetta stone for image formats but it is missing support some format versions.  In order to bring qemu-img up-to-date with

[Qemu-devel] [PATCH V13 00/17] Xen device model support

2011-04-18 Thread anthony.perard
From: Anthony PERARD anthony.per...@citrix.com Hi all, Here is the few change made since the v12: - There are few changes in the xen init code. A xen_hvm_init function is new in this patch set and is call from xenfv:machine-init. - So -xen-create -M xenpv will continue to work as before

[Qemu-devel] [PATCH V13 02/17] xen: Make Xen build once.

2011-04-18 Thread anthony.perard
From: Anthony PERARD anthony.per...@citrix.com xen_domainbuild and xen_machine_pv are built only for i386 targets. Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- Makefile.target |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.target

[Qemu-devel] [PATCH V13 05/17] pc_memory_init: Move memory calculation to the caller.

2011-04-18 Thread anthony.perard
From: Anthony PERARD anthony.per...@citrix.com This patch moves above_4g_mem_size and below_4g_mem_size calculation in the caller of pc_memory_init (pc_init1). And the prototype of pc_memory_init is changed because there is no need anymore to have variable pointer. Signed-off-by: Anthony PERARD

[Qemu-devel] [PATCH V13 08/17] xen: Introduce Xen Interrupt Controller

2011-04-18 Thread anthony.perard
From: Anthony PERARD anthony.per...@citrix.com Every set_irq call makes a Xen hypercall. Signed-off-by: Anthony PERARD anthony.per...@citrix.com Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- hw/pc_piix.c |8 ++-- hw/xen.h |2 ++ xen-all.c| 12

[Qemu-devel] [PATCH V13 09/17] xen: Introduce the Xen mapcache

2011-04-18 Thread anthony.perard
From: Jun Nakajima jun.nakaj...@intel.com On IA32 host or IA32 PAE host, at present, generally, we can't create an HVM guest with more than 2G memory, because generally it's almost impossible for Qemu to find a large enough and consecutive virtual address space to map an HVM guest's whole

[Qemu-devel] [PATCH V13 06/17] xen: Add xenfv machine

2011-04-18 Thread anthony.perard
From: Anthony PERARD anthony.per...@citrix.com Introduce the Xen FV (Fully Virtualized) machine to Qemu, some more Xen specific call will be added in further patches. Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- hw/pc_piix.c | 41 +++--

Re: [Qemu-devel] [PATCH 02/17] s390x: s390x-linux-user support

2011-04-18 Thread Riku Voipio
Hi, The patch looks OK, but I'd like to have a try with some s390x static binaries. Such binaries are also useful for me to test that new patches for linxu-user don't break targets I don't usually use. Riku On Fri, Apr 15, 2011 at 05:32:43PM +0200, Alexander Graf wrote: From: Ulrich Hecht

[Qemu-devel] [PATCH V13 10/17] xen: Adds a cap to the number of map cache entries.

2011-04-18 Thread anthony.perard
From: John Baboval john.babo...@virtualcomputer.com Adds a cap to the number of map cache entries. This prevents the map cache from overwhelming system memory. I also removed the bitmap macros and #included bitmap.h instead. Signed-off-By: John Baboval john.babo...@virtualcomputer.com

[Qemu-devel] [PATCH V13 03/17] xen: Support new libxc calls from xen unstable.

2011-04-18 Thread anthony.perard
From: Anthony PERARD anthony.per...@citrix.com This patch updates the libxenctrl calls in Qemu to use the new interface, otherwise Qemu wouldn't be able to build against new versions of the library. We check libxenctrl version in configure, from Xen 3.3.0 to Xen unstable. Signed-off-by: Anthony

[Qemu-devel] [PATCH V13 13/17] pci: Use of qemu_put_ram_ptr in pci_add_option_rom.

2011-04-18 Thread anthony.perard
From: John Baboval john.babo...@virtualcomputer.com Prevent a deadlock caused by leaving a map cache bucket locked by the preceding qemu_get_ram_ptr() call. Signed-off-By: John Baboval john.babo...@virtualcomputer.com Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- hw/pci.c |2

[Qemu-devel] [PATCH V13 04/17] xen: Add initialisation of Xen

2011-04-18 Thread anthony.perard
From: Anthony PERARD anthony.per...@citrix.com The xenpv machine use the common init function. Signed-off-by: Anthony PERARD anthony.per...@citrix.com Acked-by: Alexander Graf ag...@suse.de --- Makefile.target |9 + hw/xen.h| 13 + hw/xen_backend.c|

[Qemu-devel] [PATCH V13 17/17] xen: Add Xen hypercall for sleep state in the cmos_s3 callback.

2011-04-18 Thread anthony.perard
From: Anthony PERARD anthony.per...@citrix.com Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- hw/pc_piix.c |6 +- hw/xen.h |1 + xen-all.c|9 + xen-stub.c |4 4 files changed, 19 insertions(+), 1 deletions(-) diff --git a/hw/pc_piix.c

[Qemu-devel] [PATCH V13 07/17] piix_pci: Introduces Xen specific call for irq.

2011-04-18 Thread anthony.perard
From: Anthony PERARD anthony.per...@citrix.com This patch introduces Xen specific call in piix_pci. The specific part for Xen is in write_config, set_irq and get_pirq. Signed-off-by: Anthony PERARD anthony.per...@citrix.com Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com

[Qemu-devel] [PATCH V13 15/17] xen: Initialize event channels and io rings

2011-04-18 Thread anthony.perard
From: Arun Sharma arun.sha...@intel.com Open and bind event channels; map ioreq and buffered ioreq rings. Signed-off-by: Arun Sharma arun.sha...@intel.com Signed-off-by: Anthony PERARD anthony.per...@citrix.com Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by:

[Qemu-devel] [PATCH V13 11/17] Introduce qemu_put_ram_ptr

2011-04-18 Thread anthony.perard
From: Anthony PERARD anthony.per...@citrix.com This function allows to unlock a ram_ptr give by qemu_get_ram_ptr. After a call to qemu_put_ram_ptr, the pointer may be unmap from QEMU when used with Xen. Signed-off-by: Anthony PERARD anthony.per...@citrix.com Acked-by: Alexander Graf

[Qemu-devel] [PATCH V13 16/17] xen: Set running state in xenstore.

2011-04-18 Thread anthony.perard
From: Anthony PERARD anthony.per...@citrix.com This tells to the xen management tool that the machine can begin run. Signed-off-by: Anthony PERARD anthony.per...@citrix.com Acked-by: Alexander Graf ag...@suse.de --- xen-all.c | 23 +++ 1 files changed, 23 insertions(+), 0

[Qemu-devel] [PATCH V13 12/17] configure: Always use 64bits target physical addresses with xen enabled.

2011-04-18 Thread anthony.perard
From: Anthony PERARD anthony.per...@citrix.com With MapCache, we can handle a 64b target, even with a 32b host/qemu. So, we need to have target_phys_addr_t to 64bits. Signed-off-by: Anthony PERARD anthony.per...@citrix.com Acked-by: Alexander Graf ag...@suse.de --- configure |1 + 1 files

[Qemu-devel] [PATCH V13 14/17] vl.c: Introduce getter for shutdown_requested and reset_requested.

2011-04-18 Thread anthony.perard
From: Anthony PERARD anthony.per...@citrix.com Introduce two functions qemu_shutdown_requested_get and qemu_reset_requested_get to get the value of shutdown/reset_requested without reset it. Signed-off-by: Anthony PERARD anthony.per...@citrix.com Signed-off-by: Stefano Stabellini

[Qemu-devel] [PATCH] atapi: Add 'medium ready' to 'medium not ready' transition on cd change

2011-04-18 Thread Amit Shah
MMC-5 Table F.1 lists errors that can be thrown for the TEST_UNIT_READY command. Going from medium not ready to medium ready states is communicated by throwing an error. This adds the missing 'tray opened' event that we fail to report to guests. After doing this, older Linux guests properly

Re: [Qemu-devel] [PATCH] atapi: Add 'medium ready' to 'medium not ready' transition on cd change

2011-04-18 Thread Jes Sorensen
On 04/18/11 13:45, Amit Shah wrote: MMC-5 Table F.1 lists errors that can be thrown for the TEST_UNIT_READY command. Going from medium not ready to medium ready states is communicated by throwing an error. This adds the missing 'tray opened' event that we fail to report to guests. After

Re: [Qemu-devel] [PATCH 02/17] s390x: s390x-linux-user support

2011-04-18 Thread Alexander Graf
On 18.04.2011, at 13:38, Riku Voipio wrote: Hi, The patch looks OK, but I'd like to have a try with some s390x static binaries. Such binaries are also useful for me to test that new patches for linxu-user don't break targets I don't usually use. Sure - what exactly would you like there? I

Re: [Qemu-devel] [PATCH V13 05/17] pc_memory_init: Move memory calculation to the caller.

2011-04-18 Thread Jan Kiszka
On 2011-04-18 13:37, anthony.per...@citrix.com wrote: From: Anthony PERARD anthony.per...@citrix.com This patch moves above_4g_mem_size and below_4g_mem_size calculation in the caller of pc_memory_init (pc_init1). And the prototype of pc_memory_init is changed because there is no need

Re: [Qemu-devel] [PATCH 02/17] s390x: s390x-linux-user support

2011-04-18 Thread Riku Voipio
On Mon, Apr 18, 2011 at 02:06:02PM +0200, Alexander Graf wrote: The patch looks OK, but I'd like to have a try with some s390x static binaries. Such binaries are also useful for me to test that new patches for linxu-user don't break targets I don't usually use. Sure - what exactly would

Re: [Qemu-devel] Question about total_sectors in block/vpc.c

2011-04-18 Thread Kevin Wolf
Am 15.04.2011 22:40, schrieb Lyu Mitnick: Hello Kevin, 2011/4/14 Kevin Wolf kw...@redhat.com mailto:kw...@redhat.com Am 13.04.2011 22:59, schrieb Lyu Mitnick: Hello Stefan, I have a question about get_option_parameter(). I am wondering whether

Re: [Qemu-devel] [PATCH] atapi: Add 'medium ready' to 'medium not ready' transition on cd change

2011-04-18 Thread Kevin Wolf
Am 18.04.2011 13:45, schrieb Amit Shah: MMC-5 Table F.1 lists errors that can be thrown for the TEST_UNIT_READY command. Going from medium not ready to medium ready states is communicated by throwing an error. This adds the missing 'tray opened' event that we fail to report to guests.

Re: [Qemu-devel] [PATCH 02/17] s390x: s390x-linux-user support

2011-04-18 Thread Jan-Simon Möller
Am Montag, 18. April 2011, 14:19:26 schrieb Riku Voipio: On Mon, Apr 18, 2011 at 02:06:02PM +0200, Alexander Graf wrote: The patch looks OK, but I'd like to have a try with some s390x static binaries. Such binaries are also useful for me to test that new patches for linxu-user don't

Re: [Qemu-devel] [PATCH] atapi: Add 'medium ready' to 'medium not ready' transition on cd change

2011-04-18 Thread Markus Armbruster
Amit Shah amit.s...@redhat.com writes: MMC-5 Table F.1 lists errors that can be thrown for the TEST_UNIT_READY command. Going from medium not ready to medium ready states is communicated by throwing an error. This adds the missing 'tray opened' event that we fail to report to guests.

Re: [Qemu-devel] [PATCH 02/17] s390x: s390x-linux-user support

2011-04-18 Thread Alexander Graf
On 18.04.2011, at 15:21, Jan-Simon Möller wrote: Am Montag, 18. April 2011, 14:19:26 schrieb Riku Voipio: On Mon, Apr 18, 2011 at 02:06:02PM +0200, Alexander Graf wrote: The patch looks OK, but I'd like to have a try with some s390x static binaries. Such binaries are also useful for me to

Re: [Qemu-devel] [PATCH 02/17] s390x: s390x-linux-user support

2011-04-18 Thread Aurelien Jarno
On Mon, Apr 18, 2011 at 03:21:54PM +0200, Jan-Simon Möller wrote: Am Montag, 18. April 2011, 14:19:26 schrieb Riku Voipio: On Mon, Apr 18, 2011 at 02:06:02PM +0200, Alexander Graf wrote: The patch looks OK, but I'd like to have a try with some s390x static binaries. Such binaries are

Re: [Qemu-devel] [PATCH 02/17] s390x: s390x-linux-user support

2011-04-18 Thread Alexander Graf
On 18.04.2011, at 15:36, Aurelien Jarno wrote: On Mon, Apr 18, 2011 at 03:21:54PM +0200, Jan-Simon Möller wrote: Am Montag, 18. April 2011, 14:19:26 schrieb Riku Voipio: On Mon, Apr 18, 2011 at 02:06:02PM +0200, Alexander Graf wrote: The patch looks OK, but I'd like to have a try with some

Re: [Qemu-devel] [PATCH 24/26] acpi, acpi_piix: factor out GPE logic

2011-04-18 Thread Isaku Yamahata
On Mon, Apr 18, 2011 at 11:22:40AM +0300, Avi Kivity wrote: Are you using qemu-kvm.git or qemu.git? I think there are indeed two issues, your patch fixes the first and there is another that is specific to qemu-kvm. I'm using qemu.git. I've start to have a look at qemu-kvm.git, --

Re: [Qemu-devel] [PATCH 02/17] s390x: s390x-linux-user support

2011-04-18 Thread Aurelien Jarno
On Mon, Apr 18, 2011 at 03:42:25PM +0200, Alexander Graf wrote: On 18.04.2011, at 15:36, Aurelien Jarno wrote: On Mon, Apr 18, 2011 at 03:21:54PM +0200, Jan-Simon Möller wrote: Am Montag, 18. April 2011, 14:19:26 schrieb Riku Voipio: On Mon, Apr 18, 2011 at 02:06:02PM +0200, Alexander

[Qemu-devel] [PATCH] acpi_piix4: fix save/load of PIIX4PMState

2011-04-18 Thread Isaku Yamahata
It's vmstate parameter was wrong. This patch fixes it. Reported-by: Avi Kivity a...@redhat.com Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/acpi_piix4.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index

Re: [Qemu-devel] [PATCH 1/3] slirp: Implement TFTP Blocksize option

2011-04-18 Thread Aurelien Jarno
On Mon, Apr 11, 2011 at 07:10:52PM +, Herve Poussineau wrote: From: Herv? Poussineau hpous...@reactos.org This option is described in RFC 1783. As this is only an optional field, we may ignore it in some situations and handle it in some others. Here, if client requests a block size

Re: [Qemu-devel] [PATCH 2/3] slirp: Handle more than 65535 blocks in TFTP transfers

2011-04-18 Thread Aurelien Jarno
On Mon, Apr 11, 2011 at 07:10:53PM +, Herve Poussineau wrote: From: Herv? Poussineau hpous...@reactos.org RFC 1350 does not mention block count-roll over. However, a lot of TFTP servers implement it to be able to transmit big files, so do it also Signed-off-by: Herv? Poussineau

Re: [Qemu-devel] [PATCH 3/3] slirp: improve TFTP performance

2011-04-18 Thread Aurelien Jarno
On Mon, Apr 11, 2011 at 07:10:54PM +, Herve Poussineau wrote: From: Herv? Poussineau hpous...@reactos.org When transfering a file, keep it open during the whole transfer, instead of opening/closing it for each block. Signed-off-by: Herv? Poussineau hpous...@reactos.org ---

Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-18 Thread Hannes Reinecke
On 04/15/2011 10:56 PM, Paolo Bonzini wrote: On 04/15/2011 05:04 PM, Stefan Hajnoczi wrote: The way I approached virtio-scsi was to look at the SCSI Architecture Model document and some of the Linux SCSI code. I'm not sure if letting virtio-blk SCSI pass-through or scsi-generic guide us is a

[Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync.

2011-04-18 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This is quivalent to snapshot_blkdev in the human monitor, with _sync added to the command name to make it explicit that the command is synchronous and leave space for a future async version. Signed-off-by: Jes Sorensen jes.soren...@redhat.com ---

[Qemu-devel] [PATCH v2 0/1] Add QMP bits for blockdev-snapshot-sync.

2011-04-18 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This is an old patch I am resurrecting, adding a QMP command for live snapshot support. I have tried to address the comments received in the previous emails around March 9th. Please let me know if you have further issues with this. Jes Sorensen (1):

[Qemu-devel] [RFC][PATCH v2 00/11] QEMU Guest Agent: QMP-based host/guest communication (virtagent)

2011-04-18 Thread Michael Roth
These apply on top of Anthony's glib tree, commit 03d5927deb5e6baebaade1b4c8ff2428a85e125c currently, and can also be obtained from: git://repo.or.cz/qemu/mdroth.git qga_v2 Patches 1-8 are general json/QAPI-related fixes. Anthony, please consider pulling these into your glib tree. The json

[Qemu-devel] [RFC][PATCH v2 07/17] qapi: qmp-gen.py, use basename of path for guard/core prefix

2011-04-18 Thread Michael Roth
To avoid errors when generating output to a seperate subdirectory, use only the filename, minus any leading directories, when passing it into functions to be used as a prefix for header guards, includes, etc. Also, trim file extensions based on . seperator instead of assuming a single-char

[Qemu-devel] [RFC][PATCH v2 09/17] qmp proxy: core code for proxying qmp requests to guest

2011-04-18 Thread Michael Roth
This provides a QmpProxy class, 1 instance of which is shared by all QMP servers/sessions to send/receive QMP requests/responses between QEMU and the QEMU guest agent. A single qmp_proxy_send_request() is the only interface currently needed by a QMP session, QAPI/QMP's existing async support

[Qemu-devel] [RFC][PATCH v2 08/17] qapi: fix Error usage in qemu-sockets.c

2011-04-18 Thread Michael Roth
Fix spurious errors due to not initializing Error pointer to NULL before checking for errors. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- qemu-sockets.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-sockets.c b/qemu-sockets.c index dc8beeb..e709e5f

[Qemu-devel] [RFC][PATCH v2 04/17] qapi: fix function name typo in qmp-gen.py

2011-04-18 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- qmp-gen.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qmp-gen.py b/qmp-gen.py index 90069ca..4164692 100644 --- a/qmp-gen.py +++ b/qmp-gen.py @@ -2328,7 +2328,7 @@ void qga_init_marshal(void) if

[Qemu-devel] [RFC][PATCH v2 06/17] qapi: fix memory leak for async marshalling code

2011-04-18 Thread Michael Roth
When generating the callback function for an async command, if we expect a QString we copy it into a native char* type, then call the completion function. We should free it after calling the completion function, since the completion function will later copy it into a new QString before adding it

[Qemu-devel] [RFC][PATCH v2 16/17] guest agent: add guest agent RPCs/commands

2011-04-18 Thread Michael Roth
This adds the initial set of QMP/QAPI commands provided by the guest agent: guest-ping guest-file-open guest-file-read guest-file-write guest-file-seek guest-file-close The input/output specification for these commands are documented in the schema. Signed-off-by: Michael Roth

[Qemu-devel] [RFC][PATCH v2 12/17] guest agent: worker thread class

2011-04-18 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- qga/guest-agent-worker.c | 173 ++ 1 files changed, 173 insertions(+), 0 deletions(-) create mode 100644 qga/guest-agent-worker.c diff --git a/qga/guest-agent-worker.c

[Qemu-devel] [RFC][PATCH v2 10/17] qmp proxy: add qmp_proxy chardev

2011-04-18 Thread Michael Roth
This allows qemu to be started with guest agent support via: qemu -chardev qmp_proxy,id=qmp_proxy -device ...,chardev=qmp_proxy Writes to the guest agent are buffered, with deferred work handled by a timer. Writes from the guest agent to host/proxy are passed directly into a JSON streamer

[Qemu-devel] [RFC][PATCH v2 02/17] json-streamer: add handling for JSON_ERROR token/state

2011-04-18 Thread Michael Roth
This allows a JSON_ERROR state to be passed to the streamer to force a flush of the current tokens and pass a NULL token list to the parser rather that have it churn on bad data. (Alternatively we could just not pass it to the parser at all, but it may be useful to push there errors up the stack.

[Qemu-devel] [RFC][PATCH v2 13/17] guest agent: command state class

2011-04-18 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- qga/guest-agent-command-state.c | 73 +++ 1 files changed, 73 insertions(+), 0 deletions(-) create mode 100644 qga/guest-agent-command-state.c diff --git a/qga/guest-agent-command-state.c

[Qemu-devel] [RFC][PATCH v2 01/17] json-lexer: make lexer error-recovery more deterministic

2011-04-18 Thread Michael Roth
Currently when we reach an error state we effectively flush everything fed to the lexer, which can put us in a state where we keep feeding tokens into the parser at arbitrary offsets in the stream. This makes it difficult for the lexer/tokenizer/parser to get back in sync when bad input is made by

[Qemu-devel] [RFC][PATCH v2 05/17] qapi: fix handling for null-return async callbacks

2011-04-18 Thread Michael Roth
Async commands like 'guest-ping' have NULL retvals. Handle these by inserting an empty dictionary in the response's return field. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- qmp-core.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/qmp-core.c

[Qemu-devel] [RFC][PATCH v2 03/17] json-parser: add handling for NULL token list

2011-04-18 Thread Michael Roth
Currently a NULL token list will crash the parser, instead we have it pass back a NULL QObject. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- json-parser.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/json-parser.c b/json-parser.c index

[Qemu-devel] [RFC][PATCH v2 15/17] guest agent: qemu-ga daemon

2011-04-18 Thread Michael Roth
This is the actual guest daemon, it listens for requests over a virtio-serial/isa-serial/unix socket channel and routes them through to dispatch routines, and writes the results back to the channel in a manner similar to QMP. A shorthand invocation: qemu-ga -d Is equivalent to: qemu-ga -c

[Qemu-devel] [RFC][PATCH v2 14/17] guest agent: core marshal/dispatch interfaces

2011-04-18 Thread Michael Roth
These are basically a stripped-down, guest-side analogue to what's in qmp_core.c: definitions used by qmp-gen.py-generated marshalling code to handle dispatch and a registration of command-function mappings (minus all the bits related to Qmp sessions/server/events). As a result of that, there is

[Qemu-devel] [RFC][PATCH v2 17/17] guest agent: build qemu-ga, add QEMU-wide gio dep

2011-04-18 Thread Michael Roth
This allows us to build qemu-ga with make qemu-ga. It pulls in the qemu-tools deps, but does not currently build by default. This may change to avoid bitrot and help with host-side-only unit tests. This also pulls in gio dependences for all of qemu, currently we only pull in gthread. In general

[Qemu-devel] [RFC][PATCH v2 11/17] qmp proxy: build QEMU with qmp proxy

2011-04-18 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- Makefile.objs |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index df7e670..f143bd8 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -103,6 +103,7 @@ common-obj-y +=

Re: [Qemu-devel] [PULL] Migration of misc devices

2011-04-18 Thread Anthony Liguori
On 04/17/2011 03:08 PM, Juan Quintela wrote: The following changes since commit a0102082de4026833afbd2525e8a6320d1f92885: usb: fix spelling errors in usb-linux.c (2011-04-16 12:24:28 +0100) are available in the git repository at: git://repo.or.cz/qemu/quintela.git

Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-18 Thread Stefan Hajnoczi
On Mon, Apr 18, 2011 at 3:05 PM, Hannes Reinecke h...@suse.de wrote: On 04/15/2011 10:56 PM, Paolo Bonzini wrote: On 04/15/2011 05:04 PM, Stefan Hajnoczi wrote: The way I approached virtio-scsi was to look at the SCSI Architecture Model document and some of the Linux SCSI code. I'm not sure

[Qemu-devel] [PATCH 1/3] linux-user: Don't use MAP_FIXED in do_brk()

2011-04-18 Thread Peter Maydell
Since mmap() with MAP_FIXED will map over the top of existing mappings, it's a bad idea to use it to implement brk(), because brk() with a large size is likely to overwrite important things like qemu itself or the host libc. So we drop MAP_FIXED and handle mapped but at different address as an

[Qemu-devel] [PATCH 2/3] arm-semi.c: Use correct check for failure of do_brk()

2011-04-18 Thread Peter Maydell
In the ARM semihosting implementation of SYS_HEAPINFO, use the correct check for whether do_brk() has failed -- it does not return -1 but the previous value of the break limit. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- arm-semi.c |5 +++-- 1 files changed, 3 insertions(+), 2

[Qemu-devel] [PATCH 0/3] Fix ARM semihosting SYS_HEAPINFO issues

2011-04-18 Thread Peter Maydell
This patchset is intended to fix some problems with the ARM semihosting SYS_HEAPINFO call. Patch 1 fixes a bug in do_brk() which meant that using SYS_HEAPINFO tended to result in our accidentally unmapping the host libc. Patch 2 fixes the bug https://bugs.launchpad.net/qemu/+bug/656285 by

Re: [Qemu-devel] KVM call agenda for April 19th

2011-04-18 Thread Antonio Galindo Castro
Tools for resource accounting the virtual machines. Fingerprint 35C0 49D6 E879 1F30 2FC3 0313 58C0 8857 4681 A236 Luis Antonio Galindo Castro (FunkyM0nk3y) funkymons...@gmail.com On Mon, Apr 18, 2011 at 04:46, Juan Quintela quint...@redhat.com wrote: Please, send in any agenda items you are

Re: [Qemu-devel] [PULL] Migration of misc devices

2011-04-18 Thread Jan Kiszka
On 2011-04-18 17:12, Anthony Liguori wrote: On 04/17/2011 03:08 PM, Juan Quintela wrote: The following changes since commit a0102082de4026833afbd2525e8a6320d1f92885: usb: fix spelling errors in usb-linux.c (2011-04-16 12:24:28 +0100) are available in the git repository at:

Re: [Qemu-devel] [PATCH] set VIRTIO_BALLOON_F_MUST_TELL_HOST unconditionally

2011-04-18 Thread Dave Hansen
On Fri, 2011-04-15 at 14:20 -0500, Anthony Liguori wrote: On 04/15/2011 02:15 PM, Dave Hansen wrote: On Fri, 2011-04-15 at 12:17 -0500, Anthony Liguori wrote: If you're in OOM and you need memory, you can't ask the host for more and wait for a response. You have to reclaim it immediately.

Re: [Qemu-devel] [PULL] Migration of misc devices

2011-04-18 Thread Anthony Liguori
On 04/18/2011 10:36 AM, Jan Kiszka wrote: On 2011-04-18 17:12, Anthony Liguori wrote: On 04/17/2011 03:08 PM, Juan Quintela wrote: The following changes since commit a0102082de4026833afbd2525e8a6320d1f92885: usb: fix spelling errors in usb-linux.c (2011-04-16 12:24:28 +0100) are

[Qemu-devel] [PATCH 3/3] m68k-semi.c: Use correct check for failure of do_brk()

2011-04-18 Thread Peter Maydell
In the m68k semihosting implementation of HOSTED_INIT_SIM, use the correct check for whether do_brk() has failed -- it does not return -1 but the previous value of the break limit. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- m68k-semi.c |5 +++-- 1 files changed, 3

Re: [Qemu-devel] [PULL] Migration of misc devices

2011-04-18 Thread Jan Kiszka
On 2011-04-18 17:44, Anthony Liguori wrote: On 04/18/2011 10:36 AM, Jan Kiszka wrote: On 2011-04-18 17:12, Anthony Liguori wrote: On 04/17/2011 03:08 PM, Juan Quintela wrote: The following changes since commit a0102082de4026833afbd2525e8a6320d1f92885: usb: fix spelling errors in

[Qemu-devel] [Bug 656285] Re: arm-semi mishandling SYS_HEAPINFO

2011-04-18 Thread Peter Maydell
I've just submitted a patchset which I think fixes this bug (among others): http://patchwork.ozlabs.org/patch/91789/ [1/3] linux-user: Don't use MAP_FIXED in do_brk() http://patchwork.ozlabs.org/patch/91790/ [2/3] arm-semi.c: Use correct check for failure of do_brk()

Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device

2011-04-18 Thread Paolo Bonzini
On 04/18/2011 04:05 PM, Hannes Reinecke wrote: My proposal would be to implement a full virtio-scsi _host_, and extend the proposal to be able to handle the transport layer too. Yes, I have added this independently from Friday to today, and it is why I haven't sent the proposal yet. At the

Re: [Qemu-devel] iPXE/Etherboot prompts twice for booting?

2011-04-18 Thread Alex Williamson
On Mon, 2011-04-18 at 10:45 +0100, Stefan Hajnoczi wrote: On Sat, Apr 16, 2011 at 8:41 PM, Michael Tokarev m...@tls.msk.ru wrote: I'm playing with iPXE ROM images again, and see iPXE prompts two times during bootup. Once like this: Press Ctrl-B to configure, at early stage, even if -boot

Re: [Qemu-devel] [PATCH] acpi_piix4: fix save/load of PIIX4PMState

2011-04-18 Thread Juan Quintela
Isaku Yamahata yamah...@valinux.co.jp wrote: It's vmstate parameter was wrong. This patch fixes it. Reported-by: Avi Kivity a...@redhat.com Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/acpi_piix4.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 03/17] linux-user: define a couple of syscalls for non-uid16 targets

2011-04-18 Thread Riku Voipio
On Fri, Apr 15, 2011 at 05:32:44PM +0200, Alexander Graf wrote: From: Ulrich Hecht u...@suse.de Quite a number of syscalls are only defined on systems with USE_UID16 defined; this patch defines them on other systems as well. Fixes a large number of uid/gid-related testcases on the s390x

Re: [Qemu-devel] [PATCH] Remove unneeded function parameter from gen_pc_load

2011-04-18 Thread Stefan Weil
Am 17.04.2011 23:43, schrieb Aurelien Jarno: On Sun, Apr 17, 2011 at 10:34:47PM +0100, Peter Maydell wrote: On 17 April 2011 22:07, Stefan Weil w...@mail.berlios.de wrote: Am 17.04.2011 20:27, schrieb Aurelien Jarno: On Thu, Apr 14, 2011 at 08:50:00PM +0200, Stefan Weil wrote: Am

[Qemu-devel] [PATCH 1/2] Remove unused function parameters from gen_pc_load and rename the function

2011-04-18 Thread Stefan Weil
Function gen_pc_load was introduced in commit d2856f1ad4c259e5766847c49acbb4e390731bd4. The only reason for parameter searched_pc was a debug statement in target-i386/translate.c. Parameter puc was needed by target-sparc until commit d2856f1ad4c259e5766847c49acbb4e390731bd4. Remove searched_pc

[Qemu-devel] [PATCH 2/2] Remove unused function parameter from cpu_restore_state

2011-04-18 Thread Stefan Weil
The previous patch removed the need for parameter puc. Is is now unused, so remove it. Cc: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Stefan Weil w...@mail.berlios.de --- cpu-exec.c|2 +- exec-all.h|3 +-- exec.c|

Re: [Qemu-devel] [PULL] Migration of misc devices

2011-04-18 Thread Juan Quintela
Anthony Liguori anth...@codemonkey.ws wrote: On 04/17/2011 03:08 PM, Juan Quintela wrote: The following changes since commit a0102082de4026833afbd2525e8a6320d1f92885: usb: fix spelling errors in usb-linux.c (2011-04-16 12:24:28 +0100) are available in the git repository at:

Re: [Qemu-devel] [PATCH 1/2] Remove unused function parameters from gen_pc_load and rename the function

2011-04-18 Thread Peter Maydell
On 18 April 2011 17:39, Stefan Weil w...@mail.berlios.de wrote: Function gen_pc_load was introduced in commit d2856f1ad4c259e5766847c49acbb4e390731bd4. The only reason for parameter searched_pc was a debug statement in target-i386/translate.c. Parameter puc was needed by target-sparc until

Re: [Qemu-devel] [PATCH v2 0/3] pc-bios: Use iPXE ROMs

2011-04-18 Thread Alex Williamson
On Mon, 2011-04-11 at 13:57 -0600, Alex Williamson wrote: On Mon, 2011-04-11 at 14:48 -0500, Anthony Liguori wrote: On 04/11/2011 02:35 PM, Alex Williamson wrote: This series replaces our current gPXE based PXE ROMs with iPXE versions from the iPXE project (http://ipxe.org). This version

Re: [Qemu-devel] [PATCH 2/2] Remove unused function parameter from cpu_restore_state

2011-04-18 Thread Peter Maydell
On 18 April 2011 17:39, Stefan Weil w...@mail.berlios.de wrote: The previous patch removed the need for parameter puc. Is is now unused, so remove it. Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

[Qemu-devel] [PATCH 0/6] linux-user: pending patches

2011-04-18 Thread Riku Voipio
Apart from the last patch, all patches have been seen on the list. If no problems are found in reviews, I'll send these as the next pull request. Changes can also be pulled by git from: git://gitorious.org/qemu-maemo/qemu.git linux-user-for-upstream notice that linux-user git will move soon

[Qemu-devel] [PATCH 2/6] linux-user: improve traces

2011-04-18 Thread Riku Voipio
From: Laurent Vivier laur...@vivier.eu Add trace details for getpid(), kill(), _llseek(), rt_sigaction(), rt_sigprocmask(), clone(). Signed-off-by: Laurent Vivier laur...@vivier.eu Signed-off-by: Riku Voipio riku.voi...@iki.fi --- linux-user/strace.c| 161

[Qemu-devel] [PATCH 1/6] [v2] linux-user: bigger default stack

2011-04-18 Thread Riku Voipio
From: Riku Voipio riku.voi...@nokia.com PTHREAD_STACK_MIN (16KB) is somewhat inadequate for a new stack for new QEMU threads. Set new limit to 256K which should be enough, yet doesn't increase memory pressure significantly. Signed-off-by: Riku Voipio riku.voi...@nokia.com Reviewed-by: Nathan

[Qemu-devel] [PATCH 4/6] linux-user: add ioctl(SIOCGIWNAME, ...) support.

2011-04-18 Thread Riku Voipio
From: Laurent Vivier laur...@vivier.eu Allow to run properly following program from linux-user: /* cc -o wifi wifi.c */ #include stdio.h #include sys/ioctl.h #include sys/types.h #include sys/socket.h #include linux/wireless.h #include netinet/in.h #include arpa/inet.h #include string.h

[Qemu-devel] [PATCH 5/6] linux-user: add s390x to llseek list

2011-04-18 Thread Riku Voipio
From: Alexander Graf ag...@suse.de We keep a list of host architectures that do llseek with the same syscall as lseek. S390x is one of them, so let's add it to the list. Original-patch-by: Ulrich Hecht u...@suse.de Signed-off-by: Alexander Graf ag...@suse.de Signed-off-by: Riku Voipio

[Qemu-devel] [PATCH 3/6] linux-user: convert ioctl(SIOCGIFCONF, ...) result.

2011-04-18 Thread Riku Voipio
From: Laurent Vivier laur...@vivier.eu The result needs to be converted as it is stored in an array of struct ifreq and sizeof(struct ifreq) differs according to target and host alignment rules. This patch allows to execute correctly the following program on arm and m68k: #include stdio.h

  1   2   >