[Qemu-devel] [Patch 0/12] Pciinit redesign and 64bit PCI support

2012-04-24 Thread Alexey Korolev
This patch series redesigns and adds new features to pciinit.c code. [Patches 1-4] There are no more arrays of bases and counts in new implementation. The new implementation is based on dynamic allocation of pci_region_entry structures which are grouped into lists. Each pci_region_entry structure

[Qemu-devel] [PATCH 01/12] pciinit: Introduction of pci_region_entry structure

2012-04-24 Thread Alexey Korolev
The pci_region_entry structure is introduced. The pci_device-bars are removed. The information from pci_region_entry is used to program pci bars. Signed-off-by: Alexey Korolev alexey.koro...@endace.com Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/pci.h |5 -- src/pciinit.c

[Qemu-devel] [PATCH 02/12] pciinit: Move bus bar asignment

2012-04-24 Thread Alexey Korolev
Perform bus bar assignment at same time as normal bar assignment Signed-off-by: Kevin O'Connor ke...@koconnor.net Signed-off-by: Alexey Korolev alexey.koro...@endace.com --- src/pciinit.c | 53 ++--- 1 files changed, 18 insertions(+), 35

[Qemu-devel] [PATCH 03/12] pciinit: Remove size element from pci_bus-r structure

2012-04-24 Thread Alexey Korolev
The 'size' element of pci_bus-r structure is no longer need as the information about bridge region size is already stored in pci_region_entry structure. Signed-off-by: Alexey Korolev alexey.koro...@endace.com Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/pciinit.c | 20

[Qemu-devel] [PATCH 04/12] pciinit: Use sorted order allocation

2012-04-24 Thread Alexey Korolev
Use sorted order allocation scheme instead of array based count scheme. Signed-off-by: Alexey Korolev alexey.koro...@endace.com Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/pciinit.c | 71 +--- 1 files changed, 7 insertions(+), 64

[Qemu-devel] [PATCH 05/12] pciinit: Track region alignment explicitly.

2012-04-24 Thread Alexey Korolev
Don't round up bridge regions to the next highest size - instead track alignment explicitly. This should improve the memory layout for bridge regions. Also, unused bridge regions will no longer be allocated any space. Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/pciinit.c | 41

[Qemu-devel] [PATCH 06/12] pciinit: bridges can have two regions too

2012-04-24 Thread Alexey Korolev
Patch takes into account PCI bar and ROM regions of PCI bridges Original patch by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Kevin O'Connor ke...@koconnor.net Signed-off-by: Alexey Korolev alexey.koro...@endace.com --- src/pci.h |1 + src/pciinit.c |8 +--- 2 files changed,

[Qemu-devel] [PATCH 07/12] pciinit: Switch to 64bit variable types.

2012-04-24 Thread Alexey Korolev
Switch to 64bit variable types. Add parsing 64bit bars. Original patch by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/pciinit.c | 116 ++--- 1 files changed, 61 insertions(+), 55 deletions(-)

[Qemu-devel] [PATCH 08/12] pciinit: Add pci_region structure.

2012-04-24 Thread Alexey Korolev
The pci_region structure is added. Move setting of bus base address to pci_region_map_entries. Signed-off-by: Alexey Korolev alexey.koro...@endace.com --- src/pciinit.c | 50 -- 1 files changed, 28 insertions(+), 22 deletions(-) diff --git

[Qemu-devel] [PATCH 09/12] pciinit: 64bit capability discovery for pci bridges

2012-04-24 Thread Alexey Korolev
Add discovery if bridge region is 64bit is capable. Signed-off-by: Alexey Korolev alexey.koro...@endace.com --- src/pciinit.c | 26 +- 1 files changed, 25 insertions(+), 1 deletions(-) diff --git a/src/pciinit.c b/src/pciinit.c index f185cbd..0d66dbe 100644 ---

[Qemu-devel] [PATCH 10/12] Calculate pci region stats on demand

2012-04-24 Thread Alexey Korolev
Do not store pci region stats - instead calulate the sum and alignment on demand. Signed-off-by: Alexey Korolev alexey.koro...@endace.com --- src/pciinit.c | 57 +++-- 1 files changed, 35 insertions(+), 22 deletions(-) diff --git

[Qemu-devel] [PATCH 10/12] Calculate pci region stats on demand

2012-04-24 Thread Alexey Korolev
Do not store pci region stats - instead calulate the sum and alignment on demand. Signed-off-by: Alexey Korolev alexey.koro...@endace.com --- src/pciinit.c | 57 +++-- 1 files changed, 35 insertions(+), 22 deletions(-) diff --git

[Qemu-devel] [PATCH 11/12] Migrate 64bit entries to 64bit pci regions

2012-04-24 Thread Alexey Korolev
Migrate 64bit entries to 64bit pci regions if they do not fit in 32bit range. Signed-off-by: Alexey Korolev alexey.koro...@endace.com --- src/config.h |2 ++ src/pciinit.c | 50 ++ 2 files changed, 48 insertions(+), 4 deletions(-) diff

[Qemu-devel] [PATCH 12/12] Fix 64bit PCI issues on Windows

2012-04-24 Thread Alexey Korolev
This patch solves issues on Windows guests, when 64bit BAR's are present. It is also helpful on Linux guests when use_crs kernel boot option is set. Signed-off-by: Alexey Korolev alexey.koro...@endace.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- src/acpi-dsdt.dsl |7 +

[Qemu-devel] [PATCH 0/1] Add support for iSCSI thin-provisioning

2012-04-24 Thread Ronnie Sahlberg
List, Please find a patch that updates the iscsi block device to provide support for 1, LUNs bigger than 2TB by switching to READCAPACITY16 2, Thin-provisioning by implementing bdrv_aio_discard using SCSI UNMAP commands. The unmapping/discard of blocks was done by booting a guest and using

[Qemu-devel] [PATCH] ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs

2012-04-24 Thread Ronnie Sahlberg
Update the configure test for libiscsi support to detect version 1.3 or later. Version 1.3 of libiscsi provides both READCAPACITY16 as well as UNMAP commands. Update the iscsi block layer to use READCAPACITY16 to detect the size of the LUN instead of READCAPACITY10. This allows support for LUNs

Re: [Qemu-devel] [SeaBIOS] [PATCH 10/12] Calculate pci region stats on demand

2012-04-24 Thread Alexey Korolev
A flowed text. Please apply another [10/12] in this series. On Tue, 2012-04-24 at 18:23 +1200, Alexey Korolev wrote: Do not store pci region stats - instead calulate the sum and alignment on demand. Signed-off-by: Alexey Korolev alexey.koro...@endace.com --- src/pciinit.c | 57

Re: [Qemu-devel] [PATCH] scsi refcounting fix?

2012-04-24 Thread Paolo Bonzini
Il 24/04/2012 07:02, David Gibson ha scritto: So the patch below fixes my assertion failure, but again, I can't say I understand this well enough to be confident - it might be leaking scsi reqs instead. But if this isn't the right fix, I hope one of you can help me find where the real

Re: [Qemu-devel] [PATCH] ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs

2012-04-24 Thread Paolo Bonzini
Il 24/04/2012 08:29, Ronnie Sahlberg ha scritto: Update the configure test for libiscsi support to detect version 1.3 or later. Version 1.3 of libiscsi provides both READCAPACITY16 as well as UNMAP commands. Update the iscsi block layer to use READCAPACITY16 to detect the size of the LUN

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Paolo Bonzini
Il 23/04/2012 18:06, Pavel Hrdina ha scritto: Hi, this is the patch to fix incorrect handling of IDE floppy drive controller emulation when no media is present. If the guest is booted without a media then the drive was not being emulated at all but this patch enables the emulation with no

Re: [Qemu-devel] [SeaBIOS] [PATCH 05/12] pciinit: Track region alignment explicitly.

2012-04-24 Thread Gerd Hoffmann
On 04/24/12 08:17, Alexey Korolev wrote: Don't round up bridge regions to the next highest size - instead track alignment explicitly. This should improve the memory layout for bridge regions. This one got mangled too: Applying: pciinit: Track region alignment explicitly. fatal: corrupt patch

Re: [Qemu-devel] [PATCH v6 2/5] Implement i.MX31 Clock Control Module

2012-04-24 Thread Paolo Bonzini
Il 23/04/2012 22:54, Peter Chubb ha scritto: Peter What is this calculation supposed to do? It doesn't convert a Peter 10-bit signed twos-complement number into an int32_t, unless Peter I'm confused... Also, it's a rather opaque way to write mfn = Peter 0x200;. I'll use a different way to

Re: [Qemu-devel] [PATCH] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-24 Thread Christoph Hellwig
On Tue, Apr 24, 2012 at 01:26:43AM +0900, MORITA Kazutaka wrote: SD_FLAG_CMD_CACHE is ignored in the older version of Sheepdog, so, even if we specify cache=writeback or cache=none, the data is written with O_DSYNC always and cannot be cached in the server's page cache or volatile disk cache

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-24 Thread Paolo Bonzini
Il 24/04/2012 06:21, ronnie sahlberg ha scritto: Hi Stefan, A little bit off-topic but When you design the proper place and API to plug virt-scsi into an external SCSI parser outside of qemu like the target in the kernel ... It would be very nice if one could also plug virt-scsi into

[Qemu-devel] [PATCH] docs: fix one issue in qcow2 specs

2012-04-24 Thread zwu . kernel
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- docs/specs/qcow2.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt index b6adcad..ae68a6e 100644 --- a/docs/specs/qcow2.txt

Re: [Qemu-devel] [PATCH v6 2/5] Implement i.MX31 Clock Control Module

2012-04-24 Thread Peter Chubb
Paolo == Paolo Bonzini pbonz...@redhat.com writes: Paolo Il 23/04/2012 22:54, Peter Chubb ha scritto: Peter What is this calculation supposed to do? It doesn't convert a Peter 10-bit signed twos-complement number into an int32_t, unless Peter I'm confused... Also, it's a rather opaque way to

[Qemu-devel] Fwd: buildbot failure in qemu on rhel5-default

2012-04-24 Thread Gerd Hoffmann
Original Message Subject: buildbot failure in qemu on rhel5-default Date: Mon, 23 Apr 2012 23:31:44 +0200 From: build...@spunk.home.kraxel.org To: kra...@gmail.com The Buildbot has detected a failed build on builder rhel5-default while building qemu. Full details are available

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Pavel Hrdina
On 04/24/2012 08:55 AM, Paolo Bonzini wrote: Il 23/04/2012 18:06, Pavel Hrdina ha scritto: Hi, this is the patch to fix incorrect handling of IDE floppy drive controller emulation when no media is present. If the guest is booted without a media then the drive was not being emulated at all but

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Andreas Färber
Am 23.04.2012 18:06, schrieb Pavel Hrdina: Hi, this is the patch to fix incorrect handling of IDE floppy drive controller emulation when no media is present. If the guest is booted without a media then the drive was not being emulated at all but this patch enables the emulation with no

Re: [Qemu-devel] [PATCH v6 0/5] FreeSCALE i.MX31 support

2012-04-24 Thread Andreas Färber
Am 23.04.2012 01:31, schrieb Peter Chubb: Hi all, Most of the files are unchanged since last time. Indeed... On v5 I had asked you to shorten the subjects to conform to our commit message scheme and to make patches better readable. There were even suggestions. Also I implicitly suggested to

Re: [Qemu-devel] [PATCH] ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs

2012-04-24 Thread ronnie sahlberg
On Tue, Apr 24, 2012 at 4:46 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 24/04/2012 08:29, Ronnie Sahlberg ha scritto: Update the configure test for libiscsi support to detect version 1.3 or later. Version 1.3 of libiscsi provides both READCAPACITY16 as well as UNMAP commands. Update

Re: [Qemu-devel] [PATCH] ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs

2012-04-24 Thread Kevin Wolf
Am 24.04.2012 08:46, schrieb Paolo Bonzini: Il 24/04/2012 08:29, Ronnie Sahlberg ha scritto: Update the configure test for libiscsi support to detect version 1.3 or later. Version 1.3 of libiscsi provides both READCAPACITY16 as well as UNMAP commands. Update the iscsi block layer to use

Re: [Qemu-devel] [RFC PATCH 0/9] ACPI memory hotplug

2012-04-24 Thread Gleb Natapov
On Mon, Apr 23, 2012 at 02:31:15PM +0200, Vasilis Liaskovitis wrote: Hi, On Sun, Apr 22, 2012 at 05:20:59PM +0300, Gleb Natapov wrote: On Sun, Apr 22, 2012 at 05:13:27PM +0300, Avi Kivity wrote: On 04/22/2012 05:09 PM, Gleb Natapov wrote: On Sun, Apr 22, 2012 at 05:06:43PM +0300, Avi

Re: [Qemu-devel] [PATCH] docs: fix one issue in qcow2 specs

2012-04-24 Thread Kevin Wolf
Am 24.04.2012 09:11, schrieb zwu.ker...@gmail.com: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- docs/specs/qcow2.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt

Re: [Qemu-devel] [PATCH] ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs

2012-04-24 Thread Paolo Bonzini
Il 24/04/2012 10:02, ronnie sahlberg ha scritto: So ignore this patch for now. I will redo UNMAP in the patch to instead use the generic scsi function inside libiscsi. That will serve the purpose to verify that the public API in libiscsi is sufficient for accessing the generic transport and

Re: [Qemu-devel] [PATCH] scsi refcounting fix?

2012-04-24 Thread David Gibson
On Tue, Apr 24, 2012 at 08:37:22AM +0200, Paolo Bonzini wrote: Il 24/04/2012 07:02, David Gibson ha scritto: So the patch below fixes my assertion failure, but again, I can't say I understand this well enough to be confident - it might be leaking scsi reqs instead. But if this isn't the

Re: [Qemu-devel] [PATCHv2 0/3] virtio: fix memory access races

2012-04-24 Thread Stefan Hajnoczi
On Mon, Apr 23, 2012 at 2:19 PM, Michael S. Tsirkin m...@redhat.com wrote: This is a follow-up to my previous patch: it turns out that a single mb() isn't sufficient as network loss could still be triggered under stress. Patch 1 is repost of v1. The following two patches fix more races

Re: [Qemu-devel] [RFC PATCH 0/9] ACPI memory hotplug

2012-04-24 Thread Gleb Natapov
On Mon, Apr 23, 2012 at 04:31:04PM +0300, Avi Kivity wrote: On 04/22/2012 05:20 PM, Gleb Natapov wrote: On Sun, Apr 22, 2012 at 05:13:27PM +0300, Avi Kivity wrote: On 04/22/2012 05:09 PM, Gleb Natapov wrote: On Sun, Apr 22, 2012 at 05:06:43PM +0300, Avi Kivity wrote: On 04/22/2012

Re: [Qemu-devel] [PATCH v6 0/5] FreeSCALE i.MX31 support

2012-04-24 Thread Peter Chubb
Andreas == Andreas Färber afaer...@suse.de writes: Andreas Am 23.04.2012 01:31, schrieb Peter Chubb: Hi all, Most of the files are unchanged since last time. Andreas Indeed... On v5 I had asked you to shorten the subjects to Andreas conform to our commit message scheme and to make patches

Re: [Qemu-devel] [PATCH] block/qcow2: Add missing GCC_FMT_ATTR to function report_unsupported()

2012-04-24 Thread Kevin Wolf
Am 23.04.2012 22:54, schrieb Stefan Weil: Cc: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Weil s...@weilnetz.de --- block/qcow2.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index ad46c03..d03e31c 100644 ---

Re: [Qemu-devel] [RFC PATCH 3/9][SeaBIOS] acpi: generate hotplug memory devices.

2012-04-24 Thread Vasilis Liaskovitis
Hi, On Mon, Apr 23, 2012 at 07:37:51PM -0400, Kevin O'Connor wrote: On Thu, Apr 19, 2012 at 04:08:41PM +0200, Vasilis Liaskovitis wrote: The memory device generation is guided by qemu paravirt info. Seabios first uses the info to setup SRAT entries for the hotplug-able memory slots.

Re: [Qemu-devel] [RFC PATCH 0/9] ACPI memory hotplug

2012-04-24 Thread Gleb Natapov
On Tue, Apr 24, 2012 at 10:24:51AM +0200, Vasilis Liaskovitis wrote: Hi, On Tue, Apr 24, 2012 at 10:52:24AM +0300, Gleb Natapov wrote: On Mon, Apr 23, 2012 at 02:31:15PM +0200, Vasilis Liaskovitis wrote: The 440fx spec mentions: The address range from the top of main DRAM to 4 Gbytes

Re: [Qemu-devel] copy benchmarks onto qemu

2012-04-24 Thread Mulyadi Santosa
On Tue, Apr 24, 2012 at 02:09, Xin Tong xerox.time.t...@gmail.com wrote: I am not too sure what you mean by raw image. what i have is an *.img file that is bootable by QEMU. will kpartx  work ? try to use qemu-img info to find what format the file uses... -- regards, Mulyadi Santosa

Re: [Qemu-devel] [PATCH 2/4] block: use Error mechanism instead of -errno for block_job_set_speed()

2012-04-24 Thread Stefan Hajnoczi
On Mon, Apr 23, 2012 at 7:01 PM, Luiz Capitulino lcapitul...@redhat.com wrote: On Mon, 23 Apr 2012 17:47:09 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 23/04/2012 17:39, Stefan Hajnoczi ha scritto: There are at least two different errors that can occur in block_job_set_speed(): the

Re: [Qemu-devel] [PATCH 00/15] QOM'ify x86 CPU, part 2: properties

2012-04-24 Thread Andreas Färber
Am 19.04.2012 20:27, schrieb Eduardo Habkost: By the way, do you still plan to make cpudefs register new classes/types? I remember that you did that on a previous series. Generally I do, yes. However the CPU QOM'ification is not making as much progress as I would've liked, specifically there's

Re: [Qemu-devel] Generating cachegrind output with qemu

2012-04-24 Thread Wacha Gábor
Dear Stefan, Thanks for your quick answer, I'll look into it. Regards, Gabor Wacha 2012.04.24. 6:33, Stefan Weil s...@weilnetz.de ezt írta: Am 23.04.2012 18:18, schrieb Wacha Gábor: Dear developers, I am a Hungarian student trying to use qemu for profiling bare metal ARM programs for my

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Stefan Hajnoczi
On Mon, Apr 23, 2012 at 5:06 PM, Pavel Hrdina phrd...@redhat.com wrote: Hi, this is the patch to fix incorrect handling of IDE floppy drive controller emulation s/IDE// It's unrelated to IDE. @@ -937,6 +940,9 @@ static int fdctrl_media_changed(FDrive *drv)     if (!drv-bs)        

Re: [Qemu-devel] [PATCH 2/4] block: use Error mechanism instead of -errno for block_job_set_speed()

2012-04-24 Thread Paolo Bonzini
Il 24/04/2012 10:49, Stefan Hajnoczi ha scritto: The error is specific to block job speeds so we can add a speed argument to block-stream in the future and clearly identify the invalid parameter. I added the new error to avoid having to change the InvalidParameter 'name' field. It becomes

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-24 Thread Stefan Hajnoczi
On Tue, Apr 24, 2012 at 8:05 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 24/04/2012 06:21, ronnie sahlberg ha scritto: Hi Stefan, A little bit off-topic but When you design the proper place and API to plug virt-scsi into an external SCSI parser outside of qemu like the target in the

[Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Amit Shah
From: Alon Levy al...@redhat.com guest_connected should be false before guest driver initialization, and true after, both for multiport aware and non multiport aware drivers. Don't set it before the guest_features are available; instead use set_status which is called by io to VIRTIO_PCI_STATUS

[Qemu-devel] [PATCH v2 09/15] target-i386: Add property getter for CPU model

2012-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- target-i386/cpu.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 9479717..643289f 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -640,6 +640,18 @@

[Qemu-devel] [PATCH v2 12/15] target-i386: Introduce level property for X86CPU

2012-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com --- target-i386/cpu.c | 38 +- 1 files changed, 37 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 490db76..f2df8d0 100644

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Pavel Hrdina
On 04/24/2012 11:06 AM, Stefan Hajnoczi wrote: On Mon, Apr 23, 2012 at 5:06 PM, Pavel Hrdinaphrd...@redhat.com wrote: Hi, this is the patch to fix incorrect handling of IDE floppy drive controller emulation s/IDE// It's unrelated to IDE. @@ -937,6 +940,9 @@ static int

[Qemu-devel] [PATCH v2 04/15] target-i386: Add family property to X86CPU

2012-04-24 Thread Andreas Färber
Add the property early in the initfn so that it can be used in helpers such as mce_init(). Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com [AF: Add an error_free(), spotted by Michael Roth] --- target-i386/cpu.c | 39

[Qemu-devel] [PATCH v2 14/15] target-i386: Prepare vendor property for X86CPU

2012-04-24 Thread Andreas Färber
Using it now would incur converting the three x86_def_t vendor words into a string for object_property_set_str(), then back to three words in the vendor setter. The built-in CPU definitions use numeric preprocessor defines to initialize the three words in a charset-safe way, so do not change the

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Kevin Wolf
Am 23.04.2012 18:06, schrieb Pavel Hrdina: Hi, this is the patch to fix incorrect handling of IDE floppy drive controller emulation when no media is present. If the guest is booted without a media then the drive was not being emulated at all but this patch enables the emulation with no

Re: [Qemu-devel] [PATCH] spice: require spice-protocol = 0.8.1

2012-04-24 Thread Gerd Hoffmann
On 04/23/12 15:52, Peter Maydell wrote: Ping? This patch doesn't seem to have made it into master yet and I don't think it was in the last spice pullreq... Somehow overlooked it in my inbox. Added to the spice patch queue now. Thanks for the reminder, Gerd

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Pavel Hrdina
On 04/24/2012 11:32 AM, Kevin Wolf wrote: Am 23.04.2012 18:06, schrieb Pavel Hrdina: Hi, this is the patch to fix incorrect handling of IDE floppy drive controller emulation when no media is present. If the guest is booted without a media then the drive was not being emulated at all but this

[Qemu-devel] [PULL] virtio-serial: fix probing for features before driver init

2012-04-24 Thread Amit Shah
Hi, Please pull for a virtio-serial fix. The following changes since commit 3c30dd5a68e9fee6af67cfd0d14ed7520820f36a: target-arm: Move reset handling to arm_cpu_reset (2012-04-21 18:13:22 +) are available in the git repository at:

[Qemu-devel] [PATCH v2 15/15] target-i386: Introduce tsc-frequency property for X86CPU

2012-04-24 Thread Andreas Färber
Use Hz as unit. Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com --- target-i386/cpu.c | 37 - 1 files changed, 36 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index

[Qemu-devel] [PATCH v2 07/15] target-i386: Add model-id property to X86CPU

2012-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com --- target-i386/cpu.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 2f843be..1b8053a 100644 --- a/target-i386/cpu.c +++

[Qemu-devel] [PATCH v2 02/15] target-i386: Pass X86CPU to cpu_x86_register()

2012-04-24 Thread Andreas Färber
Avoids an x86_env_get_cpu() call there, to work with QOM properties. Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com --- target-i386/cpu.c|3 ++- target-i386/cpu.h|2 +- target-i386/helper.c |2 +- 3 files changed, 4

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Amit Shah
On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote: From: Alon Levy al...@redhat.com guest_connected should be false before guest driver initialization, and true after, both for multiport aware and non multiport aware

[Qemu-devel] [PATCH v2 03/15] target-i386: Add range check for -cpu , family=x

2012-04-24 Thread Andreas Färber
A family field value of 0xf and extended family field value of 0xff is the maximum representable unsigned family number. All other CPUID property values are bounds-checked, so add a check here for symmetry before we adopt it in a property setter. Signed-off-by: Andreas Färber afaer...@suse.de

[Qemu-devel] [PATCH v2 00/15] QOM'ify x86 CPU, part 2: properties

2012-04-24 Thread Andreas Färber
Hello, This series introduces some QOM properties for X86CPU, so that our built-in init code exercises the same code paths as QMP, as suggested by Eduardo: * family, * model, * stepping and * model-id (rather than model_id) This QOM'ifies my previously introduced helper functions, adding getters.

[Qemu-devel] [PATCH v2 05/15] target-i386: Add model property to X86CPU

2012-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com --- target-i386/cpu.c | 26 +++--- 1 files changed, 23 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index ebe9c7e..3a8141b 100644 ---

[Qemu-devel] [PATCH v2 10/15] target-i386: Add property getter for CPU stepping

2012-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com --- target-i386/cpu.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 643289f..f1d3827 100644 --- a/target-i386/cpu.c

[Qemu-devel] [PATCH v2 06/15] target-i386: Add stepping property to X86CPU

2012-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com --- target-i386/cpu.c | 27 --- 1 files changed, 24 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 3a8141b..2f843be 100644 ---

[Qemu-devel] [PATCH v2 11/15] target-i386: Add property getter for CPU model-id

2012-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com --- target-i386/cpu.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index f1d3827..490db76 100644 ---

Re: [Qemu-devel] [PATCH v2 00/15] QOM'ify x86 CPU, part 2: properties

2012-04-24 Thread Andreas Färber
Am 24.04.2012 11:33, schrieb Andreas Färber: Hello, This series introduces some QOM properties for X86CPU, so that our built-in init code exercises the same code paths as QMP, as suggested by Eduardo: * family, * model, * stepping and * model-id (rather than model_id) This QOM'ifies my

[Qemu-devel] [PATCH v2 01/15] target-i386: Fix x86_cpuid_set_model_id()

2012-04-24 Thread Andreas Färber
Don't assume zeroed cpuid_model[] fields. This doesn't break anything yet but QOM properties should be able to set the value to something else without setting an intermediate zero string. Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com ---

[Qemu-devel] [PATCH v2 08/15] target-i386: Add property getter for CPU family

2012-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com --- target-i386/cpu.c | 16 +++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 1b8053a..9479717 100644 ---

[Qemu-devel] [PATCH v2 13/15] target-i386: Introduce xlevel property for X86CPU

2012-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com --- target-i386/cpu.c | 38 +- 1 files changed, 37 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index f2df8d0..89a1855 100644

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Michael S. Tsirkin
On Tue, Apr 24, 2012 at 03:56:44PM +0530, Amit Shah wrote: On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote: From: Alon Levy al...@redhat.com guest_connected should be false before guest driver initialization, and

Re: [Qemu-devel] [RFC PATCH 0/9] ACPI memory hotplug

2012-04-24 Thread Avi Kivity
On 04/24/2012 10:21 AM, Gleb Natapov wrote: I was thinking about not having tons of 128MB slots, so we don't have a configuration that is far from reality. But maybe this thinking is too conservative. I think it is good interface to make memory that is specified with -m to be one

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Pavel Hrdina
On 04/24/2012 09:48 AM, Andreas Färber wrote: Am 23.04.2012 18:06, schrieb Pavel Hrdina: Hi, this is the patch to fix incorrect handling of IDE floppy drive controller emulation when no media is present. If the guest is booted without a media then the drive was not being emulated at all but

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Amit Shah
On (Tue) 24 Apr 2012 [13:49:53], Michael S. Tsirkin wrote: On Tue, Apr 24, 2012 at 03:56:44PM +0530, Amit Shah wrote: On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote: From: Alon Levy al...@redhat.com

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Michael S. Tsirkin
On Tue, Apr 24, 2012 at 04:44:10PM +0530, Amit Shah wrote: On (Tue) 24 Apr 2012 [13:49:53], Michael S. Tsirkin wrote: On Tue, Apr 24, 2012 at 03:56:44PM +0530, Amit Shah wrote: On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah

[Qemu-devel] [PATCH] xen_disk: remove syncwrite option

2012-04-24 Thread Stefano Stabellini
Use the BDRV_O_CACHE_* flags instead. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- hw/xen_disk.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/hw/xen_disk.c b/hw/xen_disk.c index 4a6d89c..3e4a47b 100644 --- a/hw/xen_disk.c +++

[Qemu-devel] [PULL] xen patches

2012-04-24 Thread Stefano Stabellini
Hi Anthony, please pull: git://xenbits.xen.org/people/sstabellini/qemu-dm.git for_anthony it contains a couple of xen_disk improvements and Xen HVM reboot support. John V. Baboval (1): xen: Support guest reboots Stefano Stabellini (2): xen_disk: use bdrv_aio_flush instead of

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Andreas Färber
Am 24.04.2012 12:26, schrieb Amit Shah: On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote: From: Alon Levy al...@redhat.com guest_connected should be false before guest driver initialization, and true after, both for

Re: [Qemu-devel] [PATCH v2 01/15] target-i386: Fix x86_cpuid_set_model_id()

2012-04-24 Thread Igor Mammedov
On 04/24/2012 11:33 AM, Andreas Färber wrote: Don't assume zeroed cpuid_model[] fields. This doesn't break anything yet but QOM properties should be able to set the value to something else without setting an intermediate zero string. Signed-off-by: Andreas Färberafaer...@suse.de Reviewed-by:

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Stefan Hajnoczi
On Tue, Apr 24, 2012 at 10:46 AM, Pavel Hrdina phrd...@redhat.com wrote: On 04/24/2012 11:06 AM, Stefan Hajnoczi wrote: On Mon, Apr 23, 2012 at 5:06 PM, Pavel Hrdina phrd...@redhat.com wrote: Hi, this is the patch to fix incorrect handling of IDE floppy drive controller emulation s/IDE//

Re: [Qemu-devel] [PATCH v2 01/15] target-i386: Fix x86_cpuid_set_model_id()

2012-04-24 Thread Andreas Färber
Am 24.04.2012 13:32, schrieb Igor Mammedov: On 04/24/2012 11:33 AM, Andreas Färber wrote: Don't assume zeroed cpuid_model[] fields. This doesn't break anything yet but QOM properties should be able to set Should've read didn't. I sure hope it doesn't. :) the value to something else without

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Amit Shah
On (Tue) 24 Apr 2012 [14:21:36], Michael S. Tsirkin wrote: On Tue, Apr 24, 2012 at 04:44:10PM +0530, Amit Shah wrote: On (Tue) 24 Apr 2012 [13:49:53], Michael S. Tsirkin wrote: On Tue, Apr 24, 2012 at 03:56:44PM +0530, Amit Shah wrote: On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin

Re: [Qemu-devel] [PATCH] xen_disk: remove syncwrite option

2012-04-24 Thread Stefano Stabellini
On Tue, 24 Apr 2012, Kevin Wolf wrote: Am 24.04.2012 13:22, schrieb Stefano Stabellini: Use the BDRV_O_CACHE_* flags instead. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Doesn't apply to qemu.git because... --- hw/xen_disk.c |8 +--- 1 files

Re: [Qemu-devel] [PATCH] xen_disk: remove syncwrite option

2012-04-24 Thread Kevin Wolf
Am 24.04.2012 13:22, schrieb Stefano Stabellini: Use the BDRV_O_CACHE_* flags instead. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Doesn't apply to qemu.git because... --- hw/xen_disk.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v3] spice_info: add mouse_mode

2012-04-24 Thread Gerd Hoffmann
On 03/29/12 23:23, Alon Levy wrote: Add mouse_mode, either server or mouse, to qmp and hmp commands, based on spice_server_is_server_mouse added in spice-server 0.10.3. Patch added to spice patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Kevin Wolf
Am 24.04.2012 12:28, schrieb Pavel Hrdina: On 04/24/2012 12:23 PM, Kevin Wolf wrote: Am 24.04.2012 11:55, schrieb Pavel Hrdina: On 04/24/2012 11:32 AM, Kevin Wolf wrote: Am 23.04.2012 18:06, schrieb Pavel Hrdina: Hi, this is the patch to fix incorrect handling of IDE floppy drive

Re: [Qemu-devel] [PATCH] qcow2: Fix refcount block allocation during qcow2_allocate_cluster_at()

2012-04-24 Thread Kevin Wolf
Am 23.04.2012 20:30, schrieb Marcelo Tosatti: On Mon, Apr 23, 2012 at 02:33:49PM +0200, Kevin Wolf wrote: Am 23.04.2012 01:35, schrieb Marcelo Tosatti: On Sun, Apr 22, 2012 at 08:18:49PM -0300, Marcelo Tosatti wrote: On Fri, Apr 20, 2012 at 03:56:01PM +0200, Kevin Wolf wrote: Refcount block

Re: [Qemu-devel] [PATCH 2/4] block: use Error mechanism instead of -errno for block_job_set_speed()

2012-04-24 Thread Eric Blake
On 04/24/2012 03:01 AM, Paolo Bonzini wrote: Il 24/04/2012 10:49, Stefan Hajnoczi ha scritto: The error is specific to block job speeds so we can add a speed argument to block-stream in the future and clearly identify the invalid parameter. I added the new error to avoid having to change the

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-24 Thread Pavel Hrdina
On 04/24/2012 12:23 PM, Kevin Wolf wrote: Am 24.04.2012 11:55, schrieb Pavel Hrdina: On 04/24/2012 11:32 AM, Kevin Wolf wrote: Am 23.04.2012 18:06, schrieb Pavel Hrdina: Hi, this is the patch to fix incorrect handling of IDE floppy drive controller emulation when no media is present. If

[Qemu-devel] [PATCH] usb-uhci: update irq line on reset

2012-04-24 Thread Gerd Hoffmann
uhci_reset() clears irq mask and irq status registers, but doesn't update the irq line. Which may result in suspious IRQs after uhci reset. Fix it. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-uhci.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] xen_disk: remove syncwrite option

2012-04-24 Thread Stefano Stabellini
On Tue, 24 Apr 2012, Kevin Wolf wrote: That's because it is based on top of the following two patches: xen_disk: use bdrv_aio_flush instead of bdrv_flush http://marc.info/?l=qemu-develm=133434258008959w=2 xen_disk: implement BLKIF_OP_FLUSH_DISKCACHE, remove BLKIF_OP_WRITE_BARRIER

Re: [Qemu-devel] [PATCH] qxl: don't assert on guest create_guest_primary

2012-04-24 Thread Alon Levy
On Tue, Apr 24, 2012 at 12:17:15PM +0200, Gerd Hoffmann wrote: On 04/18/12 13:00, Alon Levy wrote: initiate the implicit destroy ourselves. What is the use case? Don't let guest crash the machine with bad driver. i.e. during testing I did this inadvertently. Allowing guests to do that

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: fix guest_connected init before driver init

2012-04-24 Thread Alon Levy
On Tue, Apr 24, 2012 at 01:23:53PM +0200, Andreas Färber wrote: Am 24.04.2012 12:26, schrieb Amit Shah: On (Tue) 24 Apr 2012 [13:17:16], Michael S. Tsirkin wrote: On Tue, Apr 24, 2012 at 02:55:26PM +0530, Amit Shah wrote: From: Alon Levy al...@redhat.com guest_connected should be false

Re: [Qemu-devel] copy benchmarks onto qemu

2012-04-24 Thread Xin Tong
i got it working with libguestfs. libguestfs is awesome at manipulating guest VM images. Xin On Tue, Apr 24, 2012 at 4:45 AM, Mulyadi Santosa mulyadi.sant...@gmail.com wrote: On Tue, Apr 24, 2012 at 02:09, Xin Tong xerox.time.t...@gmail.com wrote: I am not too sure what you mean by raw image.

[Qemu-devel] Assertion after chaning display resolution

2012-04-24 Thread Peter Lieven
Hi all, I saw the following assert after chaning display resolution. This might be the cause, but i am not sure. Threaded VNC is enabled. Anyone ever seen this? qemu-kvm-1.0: malloc.c:3096: sYSMALLOc: Assertion `(old_top == (((mbinptr) (((char *) ((av)-bins[((1) - 1) * 2])) -

[Qemu-devel] [PATCH v2 0/2] Updated fixes for block job cancellation

2012-04-24 Thread Paolo Bonzini
These patches fix the existing problems with synchronous job cancellation without adding a bdrv_drain_all in the asynchronous block_job_cancel. Paolo Bonzini (2): block: add block_job_sleep_ns block: wait for job callback in block_job_cancel_sync block.c| 47

[Qemu-devel] [PATCH v2 2/2] block: wait for job callback in block_job_cancel_sync

2012-04-24 Thread Paolo Bonzini
The limitation on not having I/O after cancellation cannot really be honored. Even streaming has a very small race window where you could cancel a job and have it report completion. If this window is hit, bdrv_change_backing_file() will yield and possibly cause accesses to dangling pointers etc.

  1   2   3   >