[Qemu-devel] [PATCH] the calculation of bytes_xfer in qemu_put_buffer() is wrong

2013-11-19 Thread Wangting (Kathy)
In qemu_put_buffer(), bytes_xfer += size is wrong, it will be more than expected, and should be bytes_xfer += l. Signed-off-by: zhangmin zhangm...@huawei.commailto:zhangm...@huawei.com --- savevm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/savevm.c b/savevm.c index

Re: [Qemu-devel] console muti-head some more design input

2013-11-19 Thread Gerd Hoffmann
Hi, So I felt I had a choice here for sharing a single output surface amongst outputs: a) have multiple QemuConsole reference multiple DisplaySurface wihch reference a single pixman image, This one. In either case we need to store, width/height of the console and x/y offset into the

Re: [Qemu-devel] [PATCH] the calculation of bytes_xfer in qemu_put_buffer() is wrong

2013-11-19 Thread Paolo Bonzini
Il 19/11/2013 06:53, Wangting (Kathy) ha scritto: In qemu_put_buffer(), bytes_xfer += size is wrong,it will be more than expected,and should be bytes_xfer += l. Signed-off-by: zhangmin zhangm...@huawei.com --- savevm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

Re: [Qemu-devel] [PULL 47/58] qdev-monitor: Unref device when device_add fails

2013-11-19 Thread Amos Kong
On Mon, Nov 18, 2013 at 03:35:20PM +0100, Andreas Färber wrote: Am 18.11.2013 13:29, schrieb Amos Kong: On Tue, Oct 08, 2013 at 07:44:45PM +0200, Andreas Färber wrote: From: Stefan Hajnoczi stefa...@redhat.com qdev_device_add() leaks the created device upon failure. I suspect this

Re: [Qemu-devel] [PATCH] qemu-iotests: Add -c cache-mode to check

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 04:40:39PM +0100, Kevin Wolf wrote: Am 18.11.2013 um 16:32 hat Stefan Hajnoczi geschrieben: On Thu, Nov 14, 2013 at 10:24:04AM +0800, Fam Zheng wrote: The default cache mode for drive options is changed to writethrough, and overridable with ./check -c mode.

Re: [Qemu-devel] [PATCH] virtio-net: fix the memory leak in rxfilter_notify()

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 05:20:41PM +0200, Michael S. Tsirkin wrote: On Mon, Nov 18, 2013 at 04:14:08PM +0100, Stefan Hajnoczi wrote: On Mon, Nov 18, 2013 at 09:47:25PM +0800, Amos Kong wrote: object_get_canonical_path() returns a gchar*, it should be freeed by the caller.

Re: [Qemu-devel] [PATCH v2] virtio-net: fix the memory leak in rxfilter_notify()

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 11:32:17PM +0800, Amos Kong wrote: object_get_canonical_path() returns a gchar*, it should be freeed by the caller. Signed-off-by: Amos Kong ak...@redhat.com --- v2: put gchar *path inside rxfilter_notify_enabled block --- hw/net/virtio-net.c | 8 1 file

Re: [Qemu-devel] [PATCH v2 for-1.7] qom: Fix memory leak in object_property_set_link()

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 04:52:02PM +0100, Andreas Färber wrote: Am 15.11.2013 18:09, schrieb Vlad Yasevich: Save the result of the call to object_get_cannonical_path() so we can free it. Signed-off-by: Vlad Yasevich vyase...@redhat.com Cc: qemu-sta...@nongnu.org Reviewed-by: Andreas

Re: [Qemu-devel] [PATCH for-1.7] qom: fix object_property_set_link() memory leak

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 04:11:43PM +0100, Andreas Färber wrote: Am 18.11.2013 16:10, schrieb Stefan Hajnoczi: object_get_canonical_path() returns a string that the caller is responsible for freeing. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com What's the difference to Vlad's v2?

Re: [Qemu-devel] [edk2] [edk2 PATCH 0/1] OvmfPkg: grab ACPI tables from QEMU

2013-11-19 Thread Gerd Hoffmann
Hi, ACPI PciWindow32: Base=0xA000 End=0xFEEF Length=0x5EF0 begin32=c000 end32=fec0 begin64=0 end64=0 qemu seabios pick a 32bit window size which allows to cover it with a single mtrr entry. Size must be a power of two for that to work. [root@fedora ~]# cat

Re: [Qemu-devel] [PATCH] qtest: Use -display none by default

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 05:54:33PM +0100, Andreas Färber wrote: Am 18.11.2013 17:48, schrieb Stefan Hajnoczi: On Mon, Nov 18, 2013 at 05:36:34PM +0100, Andreas Färber wrote: This avoids each test needing to add it to suppress windows popping up. Signed-off-by: Andreas Färber

Re: [Qemu-devel] [PATCH] qtest: Use -display none by default

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 05:36:34PM +0100, Andreas Färber wrote: This avoids each test needing to add it to suppress windows popping up. Signed-off-by: Andreas Färber afaer...@suse.de --- tests/boot-order-test.c | 2 +- tests/endianness-test.c | 6 +++--- tests/fw_cfg-test.c | 3 +--

Re: [Qemu-devel] [Bug 603872] Re: [Feature request] qemu-img image conversion does not show percentage

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 03:55:45PM -, Varad wrote: Incomplete patch. Usecase: `qemu-img convert` with -p now shows the write speed. 1. I'm calculating the speed using the time taken to run the for(;;) at qemu-img.c:1477. I figured that every time this loop runs, n1 sectors are

Re: [Qemu-devel] Are there any IOMMU emulation in QEMU for x86 platform

2013-11-19 Thread Paolo Bonzini
Il 19/11/2013 07:34, Jiang, Yunhong ha scritto: Hi, all I noticed there are several patchset has been sent out about IOMMU emulation like http://lists.gnu.org/archive/html/qemu-devel/2011-10/msg03764.html, http://lists.gnu.org/archive/html/qemu-devel/2011-01/msg03196.html . Also I noticed

[Qemu-devel] [Bug 1252009] Re: slow boot on USB drives

2013-11-19 Thread Paolo Bonzini
This is due to changes in the architecture of QEMU that do not fit very well with Windows. In the long term things should get better, but it may take a while and no one is working specifically on Windows performance. ** Changed in: qemu Status: New = Won't Fix -- You received this bug

Re: [Qemu-devel] [PATCH 0/2] COW: Speed up writes

2013-11-19 Thread Stefan Hajnoczi
On Fri, Nov 15, 2013 at 07:47:00PM +0100, Charlie Shepherd wrote: v4: - Rebase onto master - Fix compilation error v3: - Refix cow_update_bitmap and squash patches 1 3 together to ensuring that we only flush if necessary, patch 1 on its own would change this causing a

[Qemu-devel] vl.c: question on cpu core calculation in smp_parse

2013-11-19 Thread Peter Lieven
Hi, if I specify just e.g. -smp 4 then smp_parse computes the following values: cpus 4, cores 1, threads 1, sockets 1 shouldn't the number of cores in this case not be 4? Peter

[Qemu-devel] [PULL for-1.7 1/1] qom: Fix memory leak in object_property_set_link()

2013-11-19 Thread Andreas Färber
From: Vlad Yasevich vyase...@redhat.com Save the result of the call to object_get_canonical_path() so we can free it. Cc: qemu-sta...@nongnu.org Signed-off-by: Vlad Yasevich vyase...@redhat.com Reviewed-by: Amos Kong ak...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com

[Qemu-devel] [PULL for-1.7 0/1] QOM devices patch queue 2013-11-19

2013-11-19 Thread Andreas Färber
Hello Anthony, This is my QOM (devices) patch queue for 1.7. Please pull. Thanks, Andreas Cc: Anthony Liguori anth...@codemonkey.ws Cc: Vlad Yasevich vyase...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com The following changes since commit 5c5432e7d630592ddcc1876ac8a1505f8f14ef15:

Re: [Qemu-devel] [PATCH v2 0/2] Add cache mode option to qemu-iotests

2013-11-19 Thread Kevin Wolf
Am 19.11.2013 um 07:45 hat Fam Zheng geschrieben: The first patch adds -c mode option to ./check and convert -nocache to an alias to -c none. The mode is used in qemu-io. The second patch modifies iotests.py to use the cache mode option in qemu drive command line. Fam Zheng (2):

[Qemu-devel] [RFC] Architecture to connect a userspace ethernet switch to QEMU guests via Virtio

2013-11-19 Thread Antonios Motakis
Hello, There have been discussions before on these lists on the topic of connecting a QEMU guest running a virtio_net driver, with an external userspace ethernet switch (Snabbswitch in particular). The essential requirement in this is to put the virtio backend in the external userspace process.

Re: [Qemu-devel] [PATCH v2 0/2] Add cache mode option to qemu-iotests

2013-11-19 Thread Kevin Wolf
Am 19.11.2013 um 07:45 hat Fam Zheng geschrieben: The first patch adds -c mode option to ./check and convert -nocache to an alias to -c none. The mode is used in qemu-io. The second patch modifies iotests.py to use the cache mode option in qemu drive command line. Okay, I gave it some

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-19 Thread Peter Lieven
On 18.11.2013 17:11, Paolo Bonzini wrote: Il 18/11/2013 16:37, Peter Lieven ha scritto: If I specify: -smp 2,sockets=1,cores=2,threads=1 to a Windows 2012 R2 Server it crashes at boot time. -smp 2 works. for Linux /proc/cpuinfo reveals no cpu layout information (sibliings, cores, threads

Re: [Qemu-devel] [PULL 47/58] qdev-monitor: Unref device when device_add fails

2013-11-19 Thread Paolo Bonzini
Il 19/11/2013 09:31, Amos Kong ha scritto: I can reproduce by hotplugging virtio-net-pci NIC for i in `seq 3 9` a b c d e f 11 12 13 14 15 16 17 18 19 1a 1b 1c 1d 1e 1f;do for j in `seq 1 7` 0;do echo netdev_add tap,id=dev$i$j | nc -U /tmp/m echo device_add

Re: [Qemu-devel] [PATCH v2] spapr: add ibm, (get|set)-system-parameter

2013-11-19 Thread Alexander Graf
On 19.11.2013, at 02:23, Alexey Kardashevskiy a...@ozlabs.ru wrote: On 11/19/2013 07:58 AM, Alexander Graf wrote: On 17.11.2013, at 22:09, Alexey Kardashevskiy a...@ozlabs.ru wrote: This adds very basic handlers for ibm,get-system-parameter and ibm,set-system-parameter RTAS calls. The

Re: [Qemu-devel] [PATCH v3] target-ppc: move POWER7+ to a separate family

2013-11-19 Thread Alexander Graf
On 19.11.2013, at 02:39, Alexey Kardashevskiy a...@ozlabs.ru wrote: So far POWER7+ was a part of POWER7 family. However it has a different PVR base value so in order to support PVR masks, it needs a separate family class. This adds a new family class, PVR base and mask values and moves

Re: [Qemu-devel] [PATCH v3 2/2] spapr-rtas: add ibm, (get|set)-system-parameter

2013-11-19 Thread Alexander Graf
On 19.11.2013, at 05:28, Alexey Kardashevskiy a...@ozlabs.ru wrote: This adds very basic handlers for ibm,get-system-parameter and ibm,set-system-parameter RTAS calls. The only parameter handled at the moment is platform-processor-diagnostics-run-mode which is always disabled and does not

Re: [Qemu-devel] [PATCH v3 1/2] spapr-rtas: replace return code constants with macros

2013-11-19 Thread Alexander Graf
On 19.11.2013, at 05:28, Alexey Kardashevskiy a...@ozlabs.ru wrote: Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru Thanks, applied to ppc-next. Alex

Re: [Qemu-devel] [PATCH v3 2/2] spapr-rtas: add ibm, (get|set)-system-parameter

2013-11-19 Thread Alexander Graf
On 19.11.2013, at 05:28, Alexey Kardashevskiy a...@ozlabs.ru wrote: This adds very basic handlers for ibm,get-system-parameter and ibm,set-system-parameter RTAS calls. The only parameter handled at the moment is platform-processor-diagnostics-run-mode which is always disabled and does not

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 2/2] spapr-rtas: add ibm, (get|set)-system-parameter

2013-11-19 Thread Alexander Graf
On 19.11.2013, at 11:36, Alexander Graf ag...@suse.de wrote: On 19.11.2013, at 05:28, Alexey Kardashevskiy a...@ozlabs.ru wrote: This adds very basic handlers for ibm,get-system-parameter and ibm,set-system-parameter RTAS calls. The only parameter handled at the moment is

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-19 Thread Paolo Bonzini
Il 19/11/2013 11:25, Peter Lieven ha scritto: ~/git/qemu$ x86_64-softmmu/qemu-system-x86_64 -m 2048 -drive if=virtio,file=iscsi://172.21.200.45/iqn.2001-05.com.equallogic:0-8a0906-9d95c510a-344001d54795289f-2012-r2-1-7-0/0,format=raw,cache=writeback,aio=native -smp

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-19 Thread Paolo Bonzini
Il 18/11/2013 20:53, Peter Lieven ha scritto: The essential part is -enable-kvm -smp 2,sockets=1,cores=2,threads=1 -cpu host. I believe the corect fix could be to disabled the cache leave forwarding as soon as the user specifies his own socket/core/thread layout. Please test this: diff

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-19 Thread Peter Lieven
On 19.11.2013 11:47, Paolo Bonzini wrote: Il 19/11/2013 11:25, Peter Lieven ha scritto: ~/git/qemu$ x86_64-softmmu/qemu-system-x86_64 -m 2048 -drive

Re: [Qemu-devel] [PATCH] extend limit of physical sections number

2013-11-19 Thread Amos Kong
On Sat, Sep 28, 2013 at 12:49:20AM +0800, Amos Kong wrote: # qemu -drive file=/disk0,if=none,id=v0,format=qcow2 \ -device virtio-blk-pci,drive=v0,id=v00,multifunction=on,addr=0x04.0 Launching guest with more than 32 virtio-blk disks, qemu will crash, because there are too many BARs.

Re: [Qemu-devel] [PATCH V5 1/5] snapshot: distinguish id and name in load_tmp

2013-11-19 Thread Kevin Wolf
Am 10.11.2013 um 23:03 hat Wenchao Xia geschrieben: Since later this function will be used so improve it. The only caller of it now is qemu-img, and it is not impacted by introduce function bdrv_snapshot_load_tmp_by_id_or_name() that call bdrv_snapshot_load_tmp() twice to keep old search

Re: [Qemu-devel] [PATCH V5 2/5] qemu-nbd: support internal snapshot export

2013-11-19 Thread Kevin Wolf
Am 10.11.2013 um 23:03 hat Wenchao Xia geschrieben: Now it is possible to directly export an internal snapshot, which can be used to probe the snapshot's contents without qemu-img convert. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- block/snapshot.c | 18

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-19 Thread Peter Lieven
next question: is cache leaf forwarding a migration blocker?

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-19 Thread Paolo Bonzini
Il 19/11/2013 12:35, Peter Lieven ha scritto: next question: is cache leaf forwarding a migration blocker? -cpu host in general is interesting at migration time, so I would say no. Paolo

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-19 Thread Peter Lieven
On 19.11.2013 12:37, Paolo Bonzini wrote: Il 19/11/2013 12:35, Peter Lieven ha scritto: next question: is cache leaf forwarding a migration blocker? -cpu host in general is interesting at migration time, so I would say no. It works for for a long time as long as all cpu features that are

Re: [Qemu-devel] [PATCH for-1.7 v2 7/8] pc: s/INT64_MAX/UINT64_MAX/

2013-11-19 Thread Paolo Bonzini
Il 07/11/2013 11:41, Marcel Apfelbaum ha scritto: From: Paolo Bonzini pbonz...@redhat.com It doesn't make sense for a region to be INT64_MAX in size: memory core uses UINT64_MAX as a special value meaning all 64 bit this is what was meant here. While this should never affect the PC system

Re: [Qemu-devel] [PATCH for-1.7 v2 7/8] pc: s/INT64_MAX/UINT64_MAX/

2013-11-19 Thread Michael S. Tsirkin
On Tue, Nov 19, 2013 at 12:44:42PM +0100, Paolo Bonzini wrote: Il 07/11/2013 11:41, Marcel Apfelbaum ha scritto: From: Paolo Bonzini pbonz...@redhat.com It doesn't make sense for a region to be INT64_MAX in size: memory core uses UINT64_MAX as a special value meaning all 64 bit this is

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-19 Thread Peter Lieven
On 19.11.2013 11:47, Paolo Bonzini wrote: Il 19/11/2013 11:25, Peter Lieven ha scritto: ~/git/qemu$ x86_64-softmmu/qemu-system-x86_64 -m 2048 -drive

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 2/2] spapr-rtas: add ibm, (get|set)-system-parameter

2013-11-19 Thread Alexey Kardashevskiy
On 11/19/2013 09:43 PM, Alexander Graf wrote: On 19.11.2013, at 11:36, Alexander Graf ag...@suse.de wrote: On 19.11.2013, at 05:28, Alexey Kardashevskiy a...@ozlabs.ru wrote: This adds very basic handlers for ibm,get-system-parameter and ibm,set-system-parameter RTAS calls. The only

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-19 Thread Peter Lieven
On 19.11.2013 13:03, Peter Lieven wrote: On 19.11.2013 11:47, Paolo Bonzini wrote: Il 19/11/2013 11:25, Peter Lieven ha scritto: ~/git/qemu$ x86_64-softmmu/qemu-system-x86_64 -m 2048 -drive

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-19 Thread Paolo Bonzini
Il 19/11/2013 13:03, Peter Lieven ha scritto: Can you test which of these two work? But I agree it's best to disable cache-leaf forwarding. The first does make windows boot again and it calculates a correct combination of cpus, threads, cores and sockets. But I think the reason it boots is

Re: [Qemu-devel] [edk2] [edk2 PATCH 0/1] OvmfPkg: grab ACPI tables from QEMU

2013-11-19 Thread Laszlo Ersek
On 11/19/13 09:54, Gerd Hoffmann wrote: Hi, ACPI PciWindow32: Base=0xA000 End=0xFEEF Length=0x5EF0 begin32=c000 end32=fec0 begin64=0 end64=0 qemu seabios pick a 32bit window size which allows to cover it with a single mtrr entry. Size must be a power of two for

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-19 Thread Peter Lieven
On 19.11.2013 13:14, Paolo Bonzini wrote: Il 19/11/2013 13:03, Peter Lieven ha scritto: Can you test which of these two work? But I agree it's best to disable cache-leaf forwarding. The first does make windows boot again and it calculates a correct combination of cpus, threads, cores and

[Qemu-devel] [PULL for-1.7 0/1] Block patches

2013-11-19 Thread Stefan Hajnoczi
Fix for block qtest buildbot failure from Andreas. The following changes since commit 06d22aa36706a3d6051b74c8a183ab554a0cb808: block: Fail if requested driver is not available (2013-11-15 13:37:48 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git block

[Qemu-devel] [PULL for-1.7 1/1] qtest: Use -display none by default

2013-11-19 Thread Stefan Hajnoczi
From: Andreas Färber afaer...@suse.de This avoids each test needing to add it to suppress windows popping up. [Commit 7ceeedd016facf8d58e14a0d1417fa7225d71072 (blockdev-test: add test case for drive_add duplicate IDs) and commit 43cd209803d6cffb1e1a028c9ff2fd0ff4fce954 (qdev-monitor-test: add

[Qemu-devel] [PULL for-1.7 0/2] Net patches

2013-11-19 Thread Stefan Hajnoczi
Bug fixes for QEMU 1.7. The following changes since commit 5c5432e7d630592ddcc1876ac8a1505f8f14ef15: Merge remote-tracking branch 'luiz/queue/qmp' into staging (2013-11-13 11:49:27 -0800) are available in the git repository at: git://github.com/stefanha/qemu.git net for you to fetch

[Qemu-devel] [PULL for-1.7 2/2] virtio-net: fix the memory leak in rxfilter_notify()

2013-11-19 Thread Stefan Hajnoczi
From: Amos Kong ak...@redhat.com object_get_canonical_path() returns a gchar*, it should be freed by the caller. Signed-off-by: Amos Kong ak...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Vlad Yasevich vyase...@redhat.com Reviewed-by: Andreas Färber afaer...@suse.de

[Qemu-devel] [PULL for-1.7 1/2] smc91c111: Fix receive starvation

2013-11-19 Thread Stefan Hajnoczi
From: Sebastian Huber sebastian.hu...@embedded-brains.de In case the smc91c111 interface signals that it cannot receive more packets the packets are queued and further reception will be disabled. In case the interface is again ready to receive packets notify the upper layer. Signed-off-by:

Re: [Qemu-devel] [PATCH for-1.7] pci: unregister vmstate_pcibus on unplug

2013-11-19 Thread Andreas Färber
Am 06.11.2013 23:52, schrieb Bandan Das: PCIBus registers a vmstate during init. Unregister it upon removal/unplug. Signed-off-by: Bandan Das b...@redhat.com Michael, this patch looks good for 1.7 to me, are you planning to still pick it up? Only one small comment below. Cc:

Re: [Qemu-devel] [PATCH 0/2] qemu-iotests: Filter out qemu-io in all tests

2013-11-19 Thread Eric Blake
On 11/18/2013 11:50 PM, Fam Zheng wrote: The second patch is too big in size (over 10M), and rejected by list moderator. You can PULL from git branch: https://github.com/famz/qemu.git 035-filter-qemu-io I'm guessing the second patch consists of a tiny amount of code to turn on the

Re: [Qemu-devel] [PATCH V5 3/5] qemu-iotests: add 058 internal snapshot export with qemu-nbd case

2013-11-19 Thread Kevin Wolf
Am 10.11.2013 um 23:03 hat Wenchao Xia geschrieben: Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- tests/qemu-iotests/058 | 102 tests/qemu-iotests/058.out | 32 ++ tests/qemu-iotests/check |1 +

Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: Filter qemu-io output in 025

2013-11-19 Thread Eric Blake
On 11/18/2013 12:21 AM, Fam Zheng wrote: Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/025 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake ebl...@redhat.com diff --git a/tests/qemu-iotests/025 b/tests/qemu-iotests/025 index

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-19 Thread Paolo Bonzini
Il 19/11/2013 13:32, Peter Lieven ha scritto: + +/* We give out APIC IDs ourselves, so force bits 31..26 even for -cpu host. */ +if (cs-nr_cores 1) { +*eax |= (cs-nr_cores - 1) 26; } break; case 5: I already tried exactly this

Re: [Qemu-devel] [PATCH/RFC] qemu-img: show image conversion speed

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 07:25:09PM +0530, Varad Gautam wrote: Calculate and display write speed when converting image with the -p parameter. qemu-progress:qemu_progress_print() now takes speed parameter to print. How well does this approach work in your testing? Calculating a new speed for

[Qemu-devel] [PATCH 0/9] usb: redirection streams support + small fixes

2013-11-19 Thread Hans de Goede
Hi Gerd, Here are my outstanding qemu usb patches. Most of them have been send before and are just rebases. As before these depend on kernel / libusb streams support, which will hopefully go upstream for 3.14 . New this time around are: [PATCH 4/9] xhci: Add a few missing checks for

[Qemu-devel] [PATCH 1/9] usb: Add max_streams attribute to endpoint info

2013-11-19 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/core.c| 22 ++ hw/usb/desc.c| 2 ++ include/hw/usb.h | 3 +++ 3 files changed, 27 insertions(+) diff --git a/hw/usb/core.c b/hw/usb/core.c index cf59a1a..67ba7d6 100644 --- a/hw/usb/core.c +++

[Qemu-devel] [PATCH 2/9] usb: Add usb_device_alloc/free_streams

2013-11-19 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/bus.c | 18 ++ include/hw/usb.h | 12 2 files changed, 30 insertions(+) diff --git a/hw/usb/bus.c b/hw/usb/bus.c index ca329be..09848c6 100644 --- a/hw/usb/bus.c +++ b/hw/usb/bus.c @@ -203,6 +203,24 @@

[Qemu-devel] [PATCH 4/9] xhci: Add a few missing checks for disconnected devices

2013-11-19 Thread Hans de Goede
One of the reworks of qemu's usb core made changes to usb-port's disconnect handling. Now ports with a device will always have a non 0 dev member, but if the device is not attached (which is possible with usb redirection), dev-attached will be 0. So supplement all checks for dev to also check

[Qemu-devel] [PATCH 5/9] usb-host-libusb: Fill in endpoint max_streams when available

2013-11-19 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/host-libusb.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index fd320cd..0dd60b2 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -720,6 +720,9 @@ static

[Qemu-devel] [PATCH 3/9] xhci: Call usb_device_alloc/free_streams

2013-11-19 Thread Hans de Goede
Note this code is not as KISS as I would like, the reason for this is that the Linux kernel interface wants streams on eps belonging to one interface to be allocated in one call. Things will also work if we do this one ep at a time (as long as all eps support the same amount of streams), but lets

[Qemu-devel] [PATCH 7/9] usb-host-libusb: Set stream id when submitting bulk-stream transfers

2013-11-19 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/host-libusb.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index 894875b..3376b96 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@

[Qemu-devel] [PATCH 6/9] usb-host-libusb: Add alloc / free streams ops

2013-11-19 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/host-libusb.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index 0dd60b2..894875b 100644 --- a/hw/usb/host-libusb.c +++

[Qemu-devel] [V2 PATCH 00/14] target-ppc: VSX Stage 4

2013-11-19 Thread Tom Musta
This is the fourth and final series of patches that add emulation support to QEMU for the PowerPC Vector Scalar Extension (VSX). This series adds the instructions that were newly introduced with Power ISA V2.07. This includes 3 scalar load instructions, 2 scalar store instructions, 7 standard

[Qemu-devel] [V2 PATCH 01/14] target-ppc: VSX Stage 4: Add VSX 2.07 Flag

2013-11-19 Thread Tom Musta
This patch adds a flag to identify those VSX instructions that are new to Power ISA V2.07. The flag is added to the Power 8 processor initialization so that the P8 models understand how to decode and emulate instructions in this category. Signed-off-by: Tom Musta tommu...@gmail.com ---

[Qemu-devel] [PATCH 9/9] uas: s/ui/iu/

2013-11-19 Thread Hans de Goede
The various uas data structures are called IU-s, which is short for Information Unit, rather then UI-s. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/dev-uas.c | 76 1 file changed, 38 insertions(+), 38 deletions(-) diff

[Qemu-devel] [PATCH 8/9] usb-redir: Add support for bulk streams

2013-11-19 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/redirect.c | 137 -- 1 file changed, 132 insertions(+), 5 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 287a505..4c6187b 100644 --- a/hw/usb/redirect.c +++

[Qemu-devel] [V2 PATCH 03/14] target-ppc: VSX Stage 4: Add lxsiwax, lxsiwzx and lxsspx

2013-11-19 Thread Tom Musta
This patch adds the scalar load instructions introduced in ISA V2.07: - Load VSX Scalar as Integer Word Algebraic Indexd (lxsiwax) - Load VSX Scalar as Integer Word and Zero Indexed (lxsiwzx) - Load VSX Scalar Single-Precision Indexed (lxsspx) Signed-off-by: Tom Musta tommu...@gmail.com

[Qemu-devel] [V2 PATCH 04/14] target-ppc: VSX Stage 4: Refactor stxsdx

2013-11-19 Thread Tom Musta
This patch refactors the stxsdx instruction. Reusable code is extracted into a macro which will be used in subsequent patches in this series. Signed-off-by: Tom Musta tommu...@gmail.com --- target-ppc/translate.c | 27 +++ 1 files changed, 15 insertions(+), 12

[Qemu-devel] [V2 PATCH 09/14] target-ppc: VSX Stage 4: Add xsresp

2013-11-19 Thread Tom Musta
This patch adds the VSX Scalar Reciprocal Estimate Single Precision (xsresp) instruction. The existing VSX_RE macro is modified to support rounding of the intermediate double precision result to single precision. V2: Updated conversion to single precision range. Signed-off-by: Tom Musta

[Qemu-devel] [V2 PATCH 05/14] target-ppc: VSX Stage 4: Add stxsiwx and stxsspx

2013-11-19 Thread Tom Musta
This patch adds two store scalar instructions: - Store VSX Scalar as Integer Word Indexed (stxsiwx) - Store VSX Scalar Single-Precision Indexed (stxsspx) Signed-off-by: Tom Musta tommu...@gmail.com --- target-ppc/translate.c |4 1 files changed, 4 insertions(+), 0 deletions(-)

[Qemu-devel] [V2 PATCH 11/14] target-ppc: VSX Stage 4: add xsrsqrtesp

2013-11-19 Thread Tom Musta
This patch adds the VSX Scalar Reciprocal Square Root Estimate Single Precision (xsrsqrtesp) instruction. The existing VSX_RSQRTE() macro is modified to support rounding of the intermediate double-precision result to single precision. V2: Updated conversion to single precision range.

[Qemu-devel] [V2 PATCH 07/14] target-ppc: VSX Stage 4: Add xsmulsp

2013-11-19 Thread Tom Musta
This patch adds the VSX Scalar Multiply Single-Precision (xsmulsp) instruction. The existing VSX_MUL macro is modified to support rounding of the intermediate result to single precision. V2: Updated conversion to single precision. Signed-off-by: Tom Musta tommu...@gmail.com ---

[Qemu-devel] [V2 PATCH 13/14] target-ppc: VSX Stage 4: Add xscvsxdsp and xscvuxdsp

2013-11-19 Thread Tom Musta
This patch adds the VSX Scalar Convert Unsigned Integer Doubleword to Floating Point Format and Round to Single Precision (xscvuxdsp) and VSX Scalar Convert Signed Integer Douglbeword to Floating Point Format and Round to Single Precision (xscvsxdsp) instructions. The existing integer to floating

[Qemu-devel] [V2 PATCH 08/14] target-ppc: VSX Stage 4: Add xsdivsp

2013-11-19 Thread Tom Musta
This patch adds the VSX Scalar Divide Single Precision (xsdivsp) instruction. The existing VSX_DIV macro is modified to support rounding of the intermediate double precision result to single precision. V2: Updated conversion to single precision. Signed-off-by: Tom Musta tommu...@gmail.com ---

[Qemu-devel] [V2 PATCH 14/14] target-ppc: VSX Stage 4: Add xxleqv, xxlnand and xxlorc

2013-11-19 Thread Tom Musta
This patchs adds the VSX Logical instructions that are new with ISA V2.07: - VSX Logical Equivalence (xxleqv) - VSX Logical NAND (xxlnand) - VSX Logical ORC (xxlorc) Signed-off-by: Tom Musta tommu...@gmail.com --- target-ppc/translate.c |6 ++ 1 files changed, 6 insertions(+), 0

Re: [Qemu-devel] [PATCH 2/3] ui/vnc: optimize dirty bitmap tracking

2013-11-19 Thread Peter Lieven
On 18.11.2013 17:27, Anthony Liguori wrote: On Nov 18, 2013 12:20 AM, Peter Lieven p...@kamp.de mailto:p...@kamp.de wrote: vnc_update_client currently scans the dirty bitmap of each client bitwise which is a very costly operation if only few bits are dirty. vnc_refresh_server_surface does

Re: [Qemu-devel] [PATCH for-1.7] pci: unregister vmstate_pcibus on unplug

2013-11-19 Thread Michael S. Tsirkin
On Tue, Nov 19, 2013 at 01:51:58PM +0100, Andreas Färber wrote: Am 06.11.2013 23:52, schrieb Bandan Das: PCIBus registers a vmstate during init. Unregister it upon removal/unplug. Signed-off-by: Bandan Das b...@redhat.com Michael, this patch looks good for 1.7 to me, are you

Re: [Qemu-devel] [PATCH 2/3] ui/vnc: optimize dirty bitmap tracking

2013-11-19 Thread Peter Lieven
On 19.11.2013 14:48, Peter Lieven wrote: On 18.11.2013 17:27, Anthony Liguori wrote: On Nov 18, 2013 12:20 AM, Peter Lieven p...@kamp.de mailto:p...@kamp.de wrote: vnc_update_client currently scans the dirty bitmap of each client bitwise which is a very costly operation if only few bits

[Qemu-devel] [V2 PATCH 02/14] target-ppc: VSX Stage 4: Refactor lxsdx

2013-11-19 Thread Tom Musta
This patch refactors the lxsdx generator. Resuable code is isolated into a macro. The macro will be used in subsequent patches in this series to implement other scalar load instructions. Signed-off-by: Tom Musta tommu...@gmail.com --- target-ppc/translate.c | 31

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-19 Thread Peter Lieven
On 19.11.2013 14:21, Paolo Bonzini wrote: Il 19/11/2013 13:32, Peter Lieven ha scritto: + +/* We give out APIC IDs ourselves, so force bits 31..26 even for -cpu host. */ +if (cs-nr_cores 1) { +*eax |= (cs-nr_cores - 1) 26; } break;

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-19 Thread Paolo Bonzini
Il 19/11/2013 15:11, Peter Lieven ha scritto: I already tried exactly this fix. Its reading index 0x004 for increasing indexes until qemu aborts: Oops, it should be I guess if ((*eax 31) cs-nr_cores 1). Maybe, how should we continue. This should be fixed before 1.7 comes out. If this

Re: [Qemu-devel] [PATCH] virtio-net: don't update mac_table in error state

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 11, 2013 at 11:48:36AM +0800, Amos Kong wrote: mac_table was always cleaned up first in handling VIRTIO_NET_CTRL_MAC_TABLE_SET command, and we din't recover mac_table content in error state, it's not correct. This patch makes all the changes in temporal variables, only update

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-19 Thread Peter Lieven
On 19.11.2013 15:14, Paolo Bonzini wrote: if ((*eax 31) cs-nr_cores 1) at which position exactly do you want to put this condition and take which action? Peter

[Qemu-devel] [V2 PATCH 10/14] target-ppc: VSX Stage 4: Add xssqrtsp

2013-11-19 Thread Tom Musta
This patch adds the VSX Scalar Square Root Single Precision (xssqrtsp) instruction. The existing VSX_SQRT() macro is modified to support rounding of the intermediate double-precision result to single-precision. V2: Updated conversion to single precision range. Signed-off-by: Tom Musta

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-19 Thread Paolo Bonzini
Il 19/11/2013 15:17, Peter Lieven ha scritto: if ((*eax 31) cs-nr_cores 1) at which position exactly do you want to put this condition and take which action? Just replace if (cs-nr_cores 1) in the patch I posted, i.e. after the switch. Paolo -- 8 - From

Re: [Qemu-devel] dataplane, thread and gpu stuff

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 08:18:47AM -0800, Anthony Liguori wrote: On Nov 18, 2013 7:05 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Nov 18, 2013 at 02:52:53PM +1000, Dave Airlie wrote: So after talking to a few people at kvm forum I think the GPU code should probably use the

Re: [Qemu-devel] dataplane, thread and gpu stuff

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 05:37:20PM +0100, Paolo Bonzini wrote: Il 18/11/2013 16:03, Stefan Hajnoczi ha scritto: As of today, there are still two vring implementations in hw/virtio/virtio.c and hw/virtio/dataplane/vring.c. This means it isn't clean and easy to integrate into a new device

Re: [Qemu-devel] Multi-head support RFC

2013-11-19 Thread John Baboval
On 11/19/2013 1:57 AM, Gerd Hoffmann wrote: Hi, I think it would be better if the HwOps calls all took a QemuConsole instead of the opaque structure. The hw implementations can dig their opaque structure out from there. QemuConsole is private to ui/console.c though (and I prefer to keep it

[Qemu-devel] [V2 PATCH 12/14] target-ppc: VSX Stage 4: Add Scalar SP Fused Multiply-Adds

2013-11-19 Thread Tom Musta
This patch adds the Single Precision VSX Scalar Fused Multiply-Add instructions: xsmaddasp, xsmaddmsp, xssubasp, xssubmsp, xsnmaddasp, xsnmaddmsp, xsnmsubasp, xsnmsubmsp. The existing VSX_MADD() macro is modified to support rounding of the intermediate double precision result to single precision.

[Qemu-devel] [V2 PATCH 06/14] target-ppc: VSX Stage 4: Add xsaddsp and xssubsp

2013-11-19 Thread Tom Musta
This patch adds the VSX Scalar Add Single-Precision (xsaddsp) and VSX Scalar Subtract Single-Precision (xssubsp) instructions. The existing VSX_ADD_SUB macro is modified to support the rounding of the (intermediate) result to single-precision. V2: updated conversion of result to single

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-19 Thread Peter Lieven
On 19.11.2013 15:19, Paolo Bonzini wrote: Il 19/11/2013 15:17, Peter Lieven ha scritto: if ((*eax 31) cs-nr_cores 1) at which position exactly do you want to put this condition and take which action? Just replace if (cs-nr_cores 1) in the patch I posted, i.e. after the switch. This

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-19 Thread Paolo Bonzini
Il 19/11/2013 15:46, Peter Lieven ha scritto: Just replace if (cs-nr_cores 1) in the patch I posted, i.e. after the switch. This seems to work. What is in bits 0..5 of eax? It's the kind of cache. 0 means that there is no cache and the returned data is not valid. In theory, Intel says you

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-19 Thread Peter Lieven
On 19.11.2013 15:57, Paolo Bonzini wrote: Il 19/11/2013 15:46, Peter Lieven ha scritto: Just replace if (cs-nr_cores 1) in the patch I posted, i.e. after the switch. This seems to work. What is in bits 0..5 of eax? It's the kind of cache. 0 means that there is no cache and the returned data

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-19 Thread Paolo Bonzini
Il 19/11/2013 16:05, Peter Lieven ha scritto: What about the number of threads in count == 2? That's a property of the L2 cache. It's not related to APIC IDs. okay, but the contents could be wrong if the physical system has threads while the emulated vserver has not. does this matter? If

Re: [Qemu-devel] [PATCH v5 0/4] Use blkdebug to make test deterministic

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 03:01:47PM +0800, Fam Zheng wrote: This adds remove_break command to block, which removes a break point defined with break. It is used in iotests.py to pause and resume drive in block job cases to make the test deterministic. v5: Addressing Max's comments (thanks for

[Qemu-devel] [PATCH 1/2] block: Enable BDRV_O_SNAPSHOT with driver-specific options

2013-11-19 Thread Kevin Wolf
In the case of snapshot=on, don't rely on the backing file path in the temporary image any more, but override the backing file with the given set of options. This way, block drivers that don't use a file name can be accessed with snapshot=on, for example: -drive

  1   2   3   >