Re: [Qemu-devel] [Xen-devel] [PATCH v1] xenpt: Properly handle 64-bit bar with more than 4G size

2015-08-12 Thread Konrad Rzeszutek Wilk
On Wed, Aug 12, 2015 at 08:53:44AM +, Wu, Feng wrote: -Original Message- From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Wednesday, August 12, 2015 4:43 PM To: Wu, Feng Cc: stefano.stabell...@eu.citrix.com; xen-de...@lists.xensource.com; qemu-devel@nongnu.org

Re: [Qemu-devel] [PATCH] MAINTAINERS: list smbios maintainers

2015-08-12 Thread Wei Huang
On 8/12/15 04:20, Michael S. Tsirkin wrote: Now that smbios has its own directory, list its maintainers. Same people as ACPI so just reuse that entry. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH for-2.5 15/30] m68k: add more modes to movem

2015-08-12 Thread Richard Henderson
On 08/12/2015 01:07 AM, Andreas Schwab wrote: Richard Henderson r...@twiddle.net writes: On 08/09/2015 01:13 PM, Laurent Vivier wrote: +opsize = (insn 0x40) != 0 ? OS_LONG : OS_WORD; +incr = opsize_bytes(opsize); +if (!is_load (insn 070) == 040) { +for (i = 15; i =

Re: [Qemu-devel] [RFC PATCH V7 00/19] Multithread TCG.

2015-08-12 Thread Frederic Konrad
On 11/08/2015 15:59, Frederic Konrad wrote: On 11/08/2015 14:45, Paolo Bonzini wrote: On 10/08/2015 17:26, fred.kon...@greensocs.com wrote: From: KONRAD Frederic fred.kon...@greensocs.com This is the 7th round of the MTTCG patch series. Thanks to look at this. Here is a list of issues that

Re: [Qemu-devel] [PATCH v8 3/5] Introduce irqchip type specification for KVM

2015-08-12 Thread Eric Auger
On 08/12/2015 04:24 PM, Christoffer Dall wrote: On Wed, Aug 12, 2015 at 4:14 PM, Eric Auger eric.au...@linaro.org wrote: Hi, On 08/12/2015 03:23 PM, Christoffer Dall wrote: On Wed, Aug 12, 2015 at 2:59 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 12 August 2015 at 13:27, Pavel Fedin

Re: [Qemu-devel] [PATCH v8 3/5] Introduce irqchip type specification for KVM

2015-08-12 Thread Christoffer Dall
On Wed, Aug 12, 2015 at 4:14 PM, Eric Auger eric.au...@linaro.org wrote: Hi, On 08/12/2015 03:23 PM, Christoffer Dall wrote: On Wed, Aug 12, 2015 at 2:59 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 12 August 2015 at 13:27, Pavel Fedin p.fe...@samsung.com wrote: Hello! I still

Re: [Qemu-devel] [RFC v4 1/9] exec.c: Add new exclusive bitmap to ram_list

2015-08-12 Thread alvise rigo
On Wed, Aug 12, 2015 at 4:10 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 12/08/2015 16:04, alvise rigo wrote: clear algorithm: if bytemap[vaddr] == 254 bytemap[vaddr] = CPU_ID Isn't this also required for the clear algorithm? if bytemap[vaddr] 254 /* this can

Re: [Qemu-devel] [PATCH v8 3/5] Introduce irqchip type specification for KVM

2015-08-12 Thread Eric Auger
Hi, On 08/12/2015 03:23 PM, Christoffer Dall wrote: On Wed, Aug 12, 2015 at 2:59 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 12 August 2015 at 13:27, Pavel Fedin p.fe...@samsung.com wrote: Hello! I still think this is the wrong approach -- see my remarks in the previous round of

[Qemu-devel] [PATCH] sh4: Fix initramfs initialization for endiannes-mismatched targets

2015-08-12 Thread Guenter Roeck
If host and target endianness does not match, loding an initramfs does not work. Fix by writing boot parameters with appropriate endianness conversion. Signed-off-by: Guenter Roeck li...@roeck-us.net --- hw/sh4/r2d.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH] hw/misc/zynq_slcr: Change CPU clock rate

2015-08-12 Thread Guenter Roeck
The Linux kernel only accepts 34 Khz and 67 Khz clock rates, and may crash if the actual clock rate is too low. The clock rate used to be (ps-clk-frequency * 26 / 4), which resulted in a CPU frequency of 21 Khz if ps-clk-frequency was set to Hz. Change it to (ps-clk-frequency

Re: [Qemu-devel] [PATCH] Makefile.target: include top level build dir in vpath

2015-08-12 Thread Michael Marineau
On Aug 12, 2015 6:32 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 09/08/2015 09:02, Michael Marineau wrote: Using ccache with CCACHE_BASEDIR set to $(SRC_PATH) or a parent will rewrite all absolute paths to relative paths. This interacts poorly with QEMU's two-level build directory

Re: [Qemu-devel] [PATCH v2] target-cris: update CPU state save/load to use VMStateDescription

2015-08-12 Thread Edgar E. Iglesias
On Fri, Aug 07, 2015 at 05:02:14PM +0100, Peter Maydell wrote: From: Juan Quintela quint...@redhat.com Update the CRIS CPU state save/load to use a VMStateDescription struct rather than cpu_save/cpu_load functions. Have to define TLBSet struct. Multidimensional arrays in C are a mess,

Re: [Qemu-devel] [RFC PATCH V7 16/19] translate-all: introduces tb_flush_safe.

2015-08-12 Thread Paolo Bonzini
On 12/08/2015 16:11, Frederic Konrad wrote: You could also allocate a new code buffer and free the old one with call_rcu. This should simplify things a lot. Depending the size of the code buffer this might be a good idea. :). 32 megabytes. Paolo

Re: [Qemu-devel] [PATCH] linux-user: elfload: Still use TARGET_PAGE_SIZE for i386 guest

2015-08-12 Thread Richard Henderson
On 08/12/2015 12:59 AM, gchen gchen wrote: Nack. There's 99 problems with host page size guest page size. This solves none of them, and in the hackiest way possible. Under alpha virtual machine, if set i386 guest page size 8KB, it will cause failure directly (any dynamically linked

[Qemu-devel] [PATCH] block/raw-posix: Use raw_normalize_devicepath()

2015-08-12 Thread Max Reitz
The filename given to qemu_open() in block/raw-posix.c should generally have been processed by raw_normalize_devicepath(); unless we are only probing (in which case the caller often checks whether the file is a block device or not, and this property will be changed by raw_normalize_devicepath() on

Re: [Qemu-devel] [RFC PATCH V7 00/19] Multithread TCG.

2015-08-12 Thread Paolo Bonzini
On 12/08/2015 17:19, Frederic Konrad wrote: BTW that affect KVM as well. Seems this mechanism is used as well with qemu_cpu_kick_self().. Which is a little strange as it seems the SIGIPI trigger a dummy signal handler? memset(sigact, 0, sizeof(sigact)); sigact.sa_handler =

[Qemu-devel] [PATCH v3 0/5] block: Drop BDS.filename

2015-08-12 Thread Max Reitz
This series depends on [PATCH] block/raw-posix: Use raw_normalize_devicepath(). The BDS filename field is generally only used when opening disk images or emitting error or warning messages, the only exception to this rule is the map command of qemu-img. However, using exact_filename there

[Qemu-devel] [PATCH v3 5/5] iotests: Test changed Quorum filename

2015-08-12 Thread Max Reitz
After drive-mirror replacing a Quorum child, the filename of the Quorum BDS should reflect the change. This patch replaces the existing test for whether the operation did actually exchange the BDS (which simply tested whether the new BDS existed) by a test which examines the children list

[Qemu-devel] [PATCH v3 2/5] block: Avoid BlockDriverState.filename

2015-08-12 Thread Max Reitz
In places which directly pass a filename to the OS, we should not use the filename field at all but exact_filename instead (although the former currently equals the latter if that is set). In qemu-img's map command, we should be using the filename field; but since this commit prepares to remove

[Qemu-devel] [PATCH v3 1/5] block: Change bdrv_get_encrypted_filename()

2015-08-12 Thread Max Reitz
Instead of returning a pointer to the filename, copy it into a buffer specified by the caller. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 25 ++--- include/block/block.h | 2 +- monitor.c | 6 +- 3 files changed, 24 insertions(+),

[Qemu-devel] [PATCH v3 4/5] block: Drop BlockDriverState.filename

2015-08-12 Thread Max Reitz
That field is now only used during initialization of BlockDriverStates (opening images) and for error or warning messages. Performance is not that much of an issue here, so we can drop the field and replace its use by a call to bdrv_filename() or bdrv_filename_alloc(). By doing so we can ensure

[Qemu-devel] [PATCH v3 3/5] block: Add bdrv_filename()

2015-08-12 Thread Max Reitz
Split the part which actually refreshes the BlockDriverState.filename field off of bdrv_refresh_filename() into a more generic function bdrv_filename(), which first calls bdrv_refresh_filename() and then stores a qemu-usable filename into the given buffer instead of BlockDriverState.filename.

Re: [Qemu-devel] [PATCH 08/10] tcg: add memory barriers in page_find_alloc accesses

2015-08-12 Thread Emilio G. Cota
On Wed, Aug 12, 2015 at 18:41:00 +0200, Paolo Bonzini wrote: page_find is reading the radix tree outside all locks, so it has to use the RCU primitives. It does not need RCU critical sections because the PageDescs are never removed, so there is never a need to wait for the end of code

Re: [Qemu-devel] [RFC 1/3] monitor: split MonitorQAPIEventState

2015-08-12 Thread Eric Blake
On 08/12/2015 02:00 PM, Laszlo Ersek wrote: Assume there has been a long period of silence (no attempts to emit an event). Now some client code makes a call to emit the event. Will that event be emitted immediately, or will it be delayed to see if more are coming? I'd like to understand this

Re: [Qemu-devel] [PATCH for-2.5 08/30] m68k: update CPU flags management

2015-08-12 Thread Laurent Vivier
Le 12/08/2015 07:12, Richard Henderson a écrit : On 08/09/2015 01:13 PM, Laurent Vivier wrote: @@ -798,9 +796,9 @@ void HELPER(mac_set_flags)(CPUM68KState *env, uint32_t acc) } } -void HELPER(flush_flags)(CPUM68KState *env, uint32_t cc_op) +uint32_t

Re: [Qemu-devel] [PATCH for-2.5 30/30] m68k: add bitfield instructions

2015-08-12 Thread Richard Henderson
On 08/09/2015 01:13 PM, Laurent Vivier wrote: uint32_t HELPER(rol32)(uint32_t val, uint32_t shift) { uint32_t result; @@ -1227,6 +1241,53 @@ void HELPER(set_mac_extu)(CPUM68KState *env, uint32_t val, uint32_t acc) env-macc[acc + 1] = res; } +/* load from a bitfield */ +

Re: [Qemu-devel] [RFC 1/3] monitor: split MonitorQAPIEventState

2015-08-12 Thread Marc-André Lureau
Hi - Original Message - On 08/12/15 21:46, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau marcandre.lur...@redhat.com Create a seperate pending event structure MonitorQAPIEventPending. Use a MonitorQAPIEventDelay callback to handle the delaying. This allows other

Re: [Qemu-devel] [PATCH for-2.5 08/30] m68k: update CPU flags management

2015-08-12 Thread Laurent Vivier
Le 12/08/2015 23:19, Richard Henderson a écrit : On 08/12/2015 01:56 PM, Laurent Vivier wrote: -DEF_HELPER_2(flush_flags, void, env, i32) +DEF_HELPER_2(flush_flags, i32, env, i32) Modify to use DEF_HELPER_FLAGS while you're at it. At the moment it reads some globals, but doesn't write

[Qemu-devel] [PATCH] hw/misc: Add support for ADC controller in Xilinx Zynq 7000

2015-08-12 Thread Guenter Roeck
Add support for the Xilinx XADC core used in Zynq 7000. References: - Zynq-7000 All Programmable SoC Technical Reference Manual - 7 Series FPGAs and Zynq-7000 All Programmable SoC XADC Dual 12-Bit 1 MSPS Analog-to-Digital Converter Tested with Linux using qemu machine xilinx-zynq-a9 with

Re: [Qemu-devel] [PATCH for-2.5 20/30] m68k: add exg

2015-08-12 Thread Laurent Vivier
Le 12/08/2015 19:05, Richard Henderson a écrit : On 08/09/2015 01:13 PM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier laur...@vivier.eu --- target-m68k/translate.c | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH for-2.5 20/30] m68k: add exg

2015-08-12 Thread Richard Henderson
On 08/12/2015 03:43 PM, Laurent Vivier wrote: Le 12/08/2015 19:05, Richard Henderson a écrit : On 08/09/2015 01:13 PM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier laur...@vivier.eu --- target-m68k/translate.c | 34 +- 1 file changed, 33

Re: [Qemu-devel] [PATCH for-2.5 20/30] m68k: add exg

2015-08-12 Thread Laurent Vivier
Le 13/08/2015 01:09, Richard Henderson a écrit : On 08/12/2015 03:43 PM, Laurent Vivier wrote: Le 12/08/2015 19:05, Richard Henderson a écrit : On 08/09/2015 01:13 PM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier laur...@vivier.eu --- target-m68k/translate.c | 34

Re: [Qemu-devel] [PATCH for-2.5 27/30] m68k: add addx/subx/negx

2015-08-12 Thread Laurent Vivier
Le 12/08/2015 20:46, Richard Henderson a écrit : On 08/09/2015 01:13 PM, Laurent Vivier wrote: +return (op1 ~((1UL bits) - 1)) | res; \ deposit32(op1, res, bits, 0) You mean: deposit32(op1, 0, bits, res) ? Laurent

Re: [Qemu-devel] [PATCH for-2.5 08/30] m68k: update CPU flags management

2015-08-12 Thread Richard Henderson
On 08/12/2015 01:56 PM, Laurent Vivier wrote: -DEF_HELPER_2(flush_flags, void, env, i32) +DEF_HELPER_2(flush_flags, i32, env, i32) Modify to use DEF_HELPER_FLAGS while you're at it. At the moment it reads some globals, but doesn't write any, or have any other side effects. It writes

Re: [Qemu-devel] [PATCH v4 1/3] linux-headers: Add eeh.h

2015-08-12 Thread Gavin Shan
On Wed, Aug 12, 2015 at 12:00:35PM +1000, Alexey Kardashevskiy wrote: On 08/11/2015 07:11 PM, Peter Maydell wrote: On 10 August 2015 at 08:13, Gavin Shan gws...@linux.vnet.ibm.com wrote: The header file was introduced by following Linux upstream commits: commit ed3e81f (powerpc/eeh: Move PE

Re: [Qemu-devel] [PATCH for-2.5 00/30] 680x0 instructions emulation

2015-08-12 Thread Richard Henderson
On 08/09/2015 01:13 PM, Laurent Vivier wrote: m68k: allow to update flags with operation on words and bytes m68k: update CPU flags management m68k: add X flag helpers I wonder if we can talk about a different mechanism for tracking flags. The x86 scheme tracks flags with 3 words: {

Re: [Qemu-devel] [PATCH] linux-user: elfload: Still use TARGET_PAGE_SIZE for i386 guest

2015-08-12 Thread Alexander Graf
Am 13.08.2015 um 04:45 schrieb gchen gchen xili_gchen_5...@hotmail.com: On 2015年08月12日 23:06, Richard Henderson wrote: On 08/12/2015 12:59 AM, gchen gchen wrote: Nack. There's 99 problems with host page size guest page size. This solves none of them, and in the hackiest way possible.

Re: [Qemu-devel] [PATCH v6 0/2] vhost user: Add live migration

2015-08-12 Thread Ouyang, Changchun
-Original Message- From: Marc-André Lureau [mailto:marcandre.lur...@gmail.com] Sent: Wednesday, August 12, 2015 6:07 PM To: Michael S. Tsirkin Cc: Thibaut Collet; QEMU; stefa...@redhat.com; Jason Wang; Paolo Bonzini; Linhaifeng; Ouyang, Changchun Subject: Re: [PATCH v6 0/2] vhost

Re: [Qemu-devel] Qemu-devel Digest, Vol 149, Issue 266

2015-08-12 Thread Ouyang, Changchun
-Original Message- Date: Wed, 12 Aug 2015 14:15:54 +0300 From: Michael S. Tsirkin m...@redhat.com To: Marcel Apfelbaum mar...@redhat.com Cc: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [PATCH] virtio/vhost: drop unnecessary VHOST_SET_VRING call Message-ID:

[Qemu-devel] [v2 1/4] migration: do cleanup operation after completion

2015-08-12 Thread Liang Li
Because of the patch 3ea3b7fa9af067982f34b of kvm, now the migration_end() is a time consuming operation, which takes about dozens of milliseconds, and will prolong VM downtime. Such an operation should be done after migration completion. For a VM with 8G RAM, this patch can reduce the VM

[Qemu-devel] [v2 3/4] migration: rename cancel to cleanup in SaveVMHandles

2015-08-12 Thread Liang Li
'cleanup' seems more appropriate than 'cancel'. Signed-off-by: Liang Li liang.z...@intel.com --- include/migration/vmstate.h | 2 +- migration/block.c | 2 +- migration/ram.c | 2 +- migration/savevm.c | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-)

[Qemu-devel] [v2 2/4] migration: rename qemu_savevm_state_cancel

2015-08-12 Thread Liang Li
The function qemu_savevm_state_cancel is called after the migration in migration_thread, it seems strange to 'cancel' it after completion, rename it to qemu_savevm_state_cleanup looks better. Signed-off-by: Liang Li liang.z...@intel.com --- include/sysemu/sysemu.h | 2 +- migration/migration.c

[Qemu-devel] [v2 4/4] migration: code clean up

2015-08-12 Thread Liang Li
Just clean up code, no behavior change. Signed-off-by: Liang Li liang.z...@intel.com --- migration/block.c | 9 ++--- migration/ram.c | 9 ++--- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/migration/block.c b/migration/block.c index 55442bd..869798c 100644 ---

[Qemu-devel] [v2 0/4] Fix long vm downtime during live migration

2015-08-12 Thread Liang Li
Some cleanup operations take long time during the pause and copy stage, especially with the KVM patch 3ea3b7fa9af067, do these operations after the completion of live migration can help to reduce VM downtime. Ony the first patch changes the behavior, the rest 3 patches are for code cleanup.

[Qemu-devel] about the patch kvmclock Ensure proper env-tsc value for kvmclock_current_nsec calculation

2015-08-12 Thread Li, Liang Z
Hi Paolo Marcelo, Could please point out what issue the patch 317b0a6d8ba44e try to fix? I found in live migration the cpu_synchronize_all_states will be called twice, and it will take more than 1 ms sometimes. I try to do some optimization but lack the knowledge about the background.

Re: [Qemu-devel] [PATCH for-2.5 27/30] m68k: add addx/subx/negx

2015-08-12 Thread Richard Henderson
On 08/12/2015 05:11 PM, Laurent Vivier wrote: Le 12/08/2015 20:46, Richard Henderson a écrit : On 08/09/2015 01:13 PM, Laurent Vivier wrote: +return (op1 ~((1UL bits) - 1)) | res; \ deposit32(op1, res, bits, 0) You mean: deposit32(op1, 0, bits, res) ? Yes, sorry. The operand

Re: [Qemu-devel] [PATCH] monitor: remove QAPI_EVENT_VSERPORT_CHANGE throttle

2015-08-12 Thread Amit Shah
On (Tue) 11 Aug 2015 [20:21:18], Laszlo Ersek wrote: On 08/11/15 19:04, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau marcandre.lur...@redhat.com QAPI_EVENT_VSERPORT_CHANGE reports changes of a virtio serial port state. However, the events may be for different ports, but the

Re: [Qemu-devel] [PATCH v3 2/3] sPAPR: Support RTAS call ibm, {open, close}-errinjct

2015-08-12 Thread Gavin Shan
On Tue, Aug 11, 2015 at 11:54:08AM +1000, Alexey Kardashevskiy wrote: On 08/11/2015 10:57 AM, Gavin Shan wrote: On Mon, Aug 10, 2015 at 10:24:56PM +1000, David Gibson wrote: On Fri, Aug 07, 2015 at 01:33:32PM +1000, Gavin Shan wrote: The patch supports RTAS calls ibm,{open,close}-errinjct to

Re: [Qemu-devel] [PATCH v4 1/3] linux-headers: Add eeh.h

2015-08-12 Thread David Gibson
On Thu, Aug 13, 2015 at 11:30:37AM +1000, Gavin Shan wrote: On Wed, Aug 12, 2015 at 12:00:35PM +1000, Alexey Kardashevskiy wrote: On 08/11/2015 07:11 PM, Peter Maydell wrote: On 10 August 2015 at 08:13, Gavin Shan gws...@linux.vnet.ibm.com wrote: The header file was introduced by following

Re: [Qemu-devel] [PATCH] linux-user: elfload: Still use TARGET_PAGE_SIZE for i386 guest

2015-08-12 Thread gchen gchen
On 2015年08月12日 23:06, Richard Henderson wrote:brgt; On 08/12/2015 12:59 AM, gchen gchen wrote:brgt;gt;gt; Nack. There's 99 problems with host page sizegt; guest page size. Thisbrgt;gt;gt; solves none of them, and in the hackiest way possible.brgt;gt;gt;brgt;gt;brgt;gt; Under alpha virtual

[Qemu-devel] [Consult] linux-user: Let 8KB host support 4KB guest

2015-08-12 Thread gchen gchen
Hello All: For my company, it is useful to let qemu linux-user 8KB host support 4KB guest, it may have many issues, but I want to try to fix them (with the aid from qemu members). So I want to consult: - Is it valuable and possible to fix these issues? (I guess, it is valuable and possible,

Re: [Qemu-devel] [PATCH] linux-user: elfload: Still use TARGET_PAGE_SIZE for i386 guest

2015-08-12 Thread gchen gchen
On 2015年08月12日 23:06, Richard Henderson wrote: On 08/12/2015 12:59 AM, gchen gchen wrote: Nack. There's 99 problems with host page size guest page size. This solves none of them, and in the hackiest way possible. Under alpha virtual machine, if set i386 guest page size 8KB, it will cause

[Qemu-devel] [PATCH] linux-user: elfload: Still use TARGET_PAGE_SIZE for i386 guest

2015-08-12 Thread gchen gchen
Under Alpha host, for ubuntu12.04.5 i386 guest, it will cause failure: Invalid ELF image for this architecture. The related issue commit is a70daba linux-user: Tell guest about big host page sizes. Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- linux-user/elfload.c | 4 1 file

Re: [Qemu-devel] [PATCH v6 0/2] vhost user: Add live migration

2015-08-12 Thread Michael S. Tsirkin
On Thu, Aug 06, 2015 at 10:45:07AM +0200, Thibaut Collet wrote: v5-v6 1. First patch: remove a warning log 2. Second patch: rename some functions to be more explicit on the purpose of these functions. The first patch provides limited live migration: - guest without GUEST_ANNOUNCE

Re: [Qemu-devel] [PATCH for-2.5 0/4] vhost: cleanups and switching to sorted memory map

2015-08-12 Thread Michael S. Tsirkin
On Tue, Jul 28, 2015 at 04:52:49PM +0200, Igor Mammedov wrote: making memory map a sorted array helps to simplify and speed up lookup/insertion and deletion ops on it. It also makes insertion/deteletion code easier to read. I'm a bit confused by all the vhost patches you sent. Is this series

Re: [Qemu-devel] [Xen-devel] [PATCH v1] xenpt: Properly handle 64-bit bar with more than 4G size

2015-08-12 Thread Wu, Feng
-Original Message- From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Wednesday, August 12, 2015 4:43 PM To: Wu, Feng Cc: stefano.stabell...@eu.citrix.com; xen-de...@lists.xensource.com; qemu-devel@nongnu.org Subject: RE: [Qemu-devel] [Xen-devel] [PATCH v1] xenpt: Properly handle

Re: [Qemu-devel] [PATCH] linux-user: elfload: Still use TARGET_PAGE_SIZE for i386 guest

2015-08-12 Thread Richard Henderson
On 08/11/2015 11:03 PM, gchen gchen wrote: Under Alpha host, for ubuntu12.04.5 i386 guest, it will cause failure: Invalid ELF image for this architecture. The related issue commit is a70daba linux-user: Tell guest about big host page sizes. Signed-off-by: Chen Ganggang.chen.5...@gmail.com ---

Re: [Qemu-devel] [PATCH v2 2/6] hw/virtio/virtio-pci: Use pow2ceil() rather than hand-calculation

2015-08-12 Thread Michael S. Tsirkin
On Fri, Jul 24, 2015 at 01:33:08PM +0100, Peter Maydell wrote: Use the utility function pow2ceil() for rounding up to the next largest power of 2, rather than inline calculation. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Michael S. Tsirkin m...@redhat.com ---

Re: [Qemu-devel] [PATCH for-2.5 12/30] m68k: Manage divw overflow

2015-08-12 Thread Richard Henderson
On 08/09/2015 01:13 PM, Laurent Vivier wrote: Overflow may be detected and set before the instruction completes. If the instruction detects an overflow, it sets the overflow condition code, and the operands are unaffected. May also implies may not. I presume this is important for matching

[Qemu-devel] [PATCH v6 1/2] vhost-user: add multi queue support

2015-08-12 Thread Ouyang Changchun
Based on patch by Nikolay Nikolaev: Vhost-user will implement the multi queue support in a similar way to what vhost already has - a separate thread for each queue. To enable the multi queue functionality - a new command line parameter queues is introduced for the vhost-user netdev. The

[Qemu-devel] [PATCH v6 0/2] vhost-user multi queue support

2015-08-12 Thread Ouyang Changchun
Vhost-user will implement the multi queue support in a similar way to what vhost already has - a separate thread for each queue. To enable the multi queue functionality - a new command line parameter queues is introduced for the vhost-user netdev. Use new message VHOST_USER_SET_VRING_FLAG to

Re: [Qemu-devel] [PATCH] linux-user: elfload: Still use TARGET_PAGE_SIZE for i386 guest

2015-08-12 Thread gchen gchen
On 2015年08月12日 14:45, Richard Henderson wrote: On 08/11/2015 11:03 PM, gchen gchen wrote: Under Alpha host, for ubuntu12.04.5 i386 guest, it will cause failure: Invalid ELF image for this architecture. The related issue commit is a70daba linux-user: Tell guest about big host page sizes.

Re: [Qemu-devel] [PATCH for-2.5 15/30] m68k: add more modes to movem

2015-08-12 Thread Andreas Schwab
Richard Henderson r...@twiddle.net writes: On 08/09/2015 01:13 PM, Laurent Vivier wrote: +opsize = (insn 0x40) != 0 ? OS_LONG : OS_WORD; +incr = opsize_bytes(opsize); +if (!is_load (insn 070) == 040) { +for (i = 15; i = 0; i--, mask = 1) { This has got to be wrong.

Re: [Qemu-devel] [PATCH for-2.5 05/30] m68k: define operand sizes

2015-08-12 Thread Laurent Vivier
Le 12/08/2015 06:07, Richard Henderson a écrit : On 08/09/2015 01:13 PM, Laurent Vivier wrote: -#define OS_BYTE 0 -#define OS_WORD 1 -#define OS_LONG 2 -#define OS_SINGLE 4 -#define OS_DOUBLE 5 +#define OS_BYTE 1 +#define OS_WORD 2 +#define OS_LONG 3 +#define OS_SINGLE 4

[Qemu-devel] [PATCH v6 2/2] vhost-user: new protocol feature for multi queue

2015-08-12 Thread Ouyang Changchun
This patch is based on top of vhost-user: protocol updates series proposed earlier by Michael S. Tsirkin. Use new message VHOST_USER_SET_VRING_FLAG to enable and disable an actual virt queue, which is similar to attach/detach queue for tap device. virtio driver on guest doesn't have to use max

Re: [Qemu-devel] [PATCH v2 1/6] hw/pci: Use pow2ceil() rather than hand-calculation

2015-08-12 Thread Michael S. Tsirkin
On Fri, Jul 24, 2015 at 01:33:07PM +0100, Peter Maydell wrote: A couple of places in hw/pci use an inline calculation to round a size up to the next largest power of 2. We have a utility routine for this, so use it. (The behaviour of the old code is different if the size value is 0 -- it

Re: [Qemu-devel] [PATCH for-2.5 13/30] m68k: set Z and N on divu/muls overflow as a real 68040

2015-08-12 Thread Richard Henderson
On 08/09/2015 01:13 PM, Laurent Vivier wrote: This allows to compare simulation results with a real 68040. Signed-off-by: Laurent Vivierlaur...@vivier.eu --- target-m68k/op_helper.c | 38 ++ 1 file changed, 26 insertions(+), 12 deletions(-) A good

Re: [Qemu-devel] [Xen-devel] [PATCH v1] xenpt: Properly handle 64-bit bar with more than 4G size

2015-08-12 Thread Wu, Feng
-Original Message- From: qemu-devel-bounces+feng.wu=intel@nongnu.org [mailto:qemu-devel-bounces+feng.wu=intel@nongnu.org] On Behalf Of Jan Beulich Sent: Wednesday, August 12, 2015 2:59 PM To: Wu, Feng Cc: xen-de...@lists.xensource.com; qemu-devel@nongnu.org;

Re: [Qemu-devel] [RFC v4 1/9] exec.c: Add new exclusive bitmap to ram_list

2015-08-12 Thread alvise rigo
I think that tlb_flush_entry is not enough, since in theory another vCPU could have a different TLB address referring the same phys address. alvise On Tue, Aug 11, 2015 at 6:32 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 11/08/2015 18:11, alvise rigo wrote: Why flush the entire cache (I

Re: [Qemu-devel] [PATCH for-2.5 01/30] m68k: define m680x0 CPUs and features

2015-08-12 Thread Laurent Vivier
Le 12/08/2015 01:13, Richard Henderson a écrit : On 08/09/2015 01:13 PM, Laurent Vivier wrote: INSN(undef, , , CF_ISA_A); +INSN(undef, , , M68000); INSN(arith_im, 0080, fff8, CF_ISA_A); +INSN(arith_im, , ff00, M68000); +INSN(undef,

Re: [Qemu-devel] [PATCH COLO-Frame v8 00/34] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2015-08-12 Thread zhanghailiang
On 2015/8/5 19:24, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: This is the 8th version of COLO. Here is only COLO frame part, include: VM checkpoint, failover, proxy API, block replication API, not include block replication. The block part is treated

Re: [Qemu-devel] [Xen-devel] [PATCH v1] xenpt: Properly handle 64-bit bar with more than 4G size

2015-08-12 Thread Jan Beulich
On 12.08.15 at 09:10, feng...@intel.com wrote: -Original Message- From: qemu-devel-bounces+feng.wu=intel@nongnu.org [mailto:qemu-devel-bounces+feng.wu=intel@nongnu.org] On Behalf Of Jan Beulich Sent: Wednesday, August 12, 2015 2:59 PM To: Wu, Feng Cc:

Re: [Qemu-devel] [PATCH for-2.5 05/30] m68k: define operand sizes

2015-08-12 Thread Andreas Schwab
Laurent Vivier laur...@vivier.eu writes: Le 12/08/2015 06:07, Richard Henderson a écrit : Is there a reason you've skipped the 0 value when adding the new values? I think there is no reason, but if I change the value I have to update abdc_mem, sbcd_mem instructions as they use it as an

[Qemu-devel] [PATCH] user-exec: alpha-host: Add type cast to avoid compiling warning

2015-08-12 Thread gchen gchen
The related building warnings in alpha virtual machine: CCi386-linux-user/user-exec.o user-exec.c: In function 'cpu_x86_signal_handler': user-exec.c:363:20: error: initialization makes pointer from integer without a cast [-Werror=int-conversion] uint32_t *pc =

Re: [Qemu-devel] [Xen-devel] [PATCH v1] xenpt: Properly handle 64-bit bar with more than 4G size

2015-08-12 Thread Jan Beulich
On 05.08.15 at 04:02, feng...@intel.com wrote: @@ -491,8 +474,9 @@ static int xen_pt_bar_reg_write(XenPCIPassthroughState *s, XenPTReg *cfg_entry, bar_ro_mask = XEN_PT_BAR_IO_RO_MASK | (r_size - 1); break; case XEN_PT_BAR_FLAG_UPPER: +r =

Re: [Qemu-devel] [PATCH for-2.5 14/30] m68k: allow adda/suba to add/sub word

2015-08-12 Thread Richard Henderson
On 08/09/2015 01:13 PM, Laurent Vivier wrote: Signed-off-by: Laurent Vivierlaur...@vivier.eu --- target-m68k/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r...@twiddle.net r~

Re: [Qemu-devel] [PATCH for-2.5 15/30] m68k: add more modes to movem

2015-08-12 Thread Richard Henderson
On 08/09/2015 01:13 PM, Laurent Vivier wrote: +opsize = (insn 0x40) != 0 ? OS_LONG : OS_WORD; +incr = opsize_bytes(opsize); +if (!is_load (insn 070) == 040) { +for (i = 15; i = 0; i--, mask = 1) { This has got to be wrong. Just because it's pre-decrement doesn't mean

Re: [Qemu-devel] [PATCH] linux-user: elfload: Still use TARGET_PAGE_SIZE for i386 guest

2015-08-12 Thread gchen gchen
On 2015年08月12日 15:59, gchen gchen wrote: On 2015年08月12日 14:45, Richard Henderson wrote: On 08/11/2015 11:03 PM, gchen gchen wrote: Under Alpha host, for ubuntu12.04.5 i386 guest, it will cause failure: Invalid ELF image for this architecture. The related issue commit is a70daba linux-user:

Re: [Qemu-devel] [PATCH 1/2] migration: do cleanup operation after completion

2015-08-12 Thread Li, Liang Z
On 12/08/2015 23:04, Liang Li wrote: @@ -1008,8 +1009,10 @@ static void *migration_thread(void *opaque) } qemu_mutex_lock_iothread(); +end_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME); +qemu_savevm_state_cancel(); + You can remove the

[Qemu-devel] [PATCH 1/2] migration: do cleanup operation after completion

2015-08-12 Thread Liang Li
Because of the patch 3ea3b7fa9af067982f34b of kvm, now the migration_end() is a time consuming operation, which takes about dozens of milliseconds, and will prolong VM downtime. Such an operation should be done after migration completion. For a VM with 8G RAM, this patch can reduce the VM

[Qemu-devel] [PATCH 2/2] migration: rename qemu_savevm_state_cancel

2015-08-12 Thread Liang Li
The function qemu_savevm_state_cancel is called after the migration in migration_thread, it seems strange to 'cancel' it after completion, rename it to qemu_savevm_state_cleanup looks better. Signed-off-by: Liang Li liang.z...@intel.com --- include/sysemu/sysemu.h | 2 +- migration/migration.c

[Qemu-devel] [PATCH] MAINTAINERS: list smbios maintainers

2015-08-12 Thread Michael S. Tsirkin
Now that smbios has its own directory, list its maintainers. Same people as ACPI so just reuse that entry. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 978b717..a059d5d

Re: [Qemu-devel] [PATCH v6 0/2] vhost user: Add live migration

2015-08-12 Thread Marc-André Lureau
Hi On Wed, Aug 12, 2015 at 9:25 AM, Michael S. Tsirkin m...@redhat.com wrote: I think these patches need to be rebased on top of Marc Andre's ones, and use protocol flags to negotiate capabilities. Right? Correct. His patches should be applied before my migration tests, though. --

Re: [Qemu-devel] [PATCH 0/2] Fix long vm downtime during live migration

2015-08-12 Thread Paolo Bonzini
On 12/08/2015 23:04, Liang Li wrote: Some cleanup operations take long time during the pause and copy stage, especially with the KVM patch 3ea3b7fa9af067, do these operation after the completion of live migration can help to reduce VM downtime. Liang Li (2): migration: do cleanup

[Qemu-devel] [PATCH] virtio/vhost: drop unnecessary VHOST_SET_VRING call

2015-08-12 Thread Marcel Apfelbaum
No need to send VHOST_SET_VRING_CALL to backend before the negotiation with the guest is finished. Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- hw/virtio/vhost.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index

Re: [Qemu-devel] [PATCH] virtio/vhost: drop unnecessary VHOST_SET_VRING call

2015-08-12 Thread Michael S. Tsirkin
On Wed, Aug 12, 2015 at 01:19:51PM +0300, Marcel Apfelbaum wrote: No need to send VHOST_SET_VRING_CALL to backend before the negotiation with the guest is finished. Signed-off-by: Marcel Apfelbaum mar...@redhat.com Well - we do need to set it to the masked notifier initially to avoid losing

Re: [Qemu-devel] [ARM SMBIOS V3 PATCH 4/5] smbios: add smbios 3.0 support

2015-08-12 Thread Michael S. Tsirkin
On Tue, Aug 11, 2015 at 10:08:21PM -0400, Wei Huang wrote: This patch adds support for SMBIOS 3.0 entry point. When caller invokes smbios_set_defaults(), it can specify entry point as 2.1 or 3.0. Then smbios_get_tables() will return the entry point table in right format. Acked-by: Gabriel

[Qemu-devel] [PATCH 0/2] Fix long vm downtime during live migration

2015-08-12 Thread Liang Li
Some cleanup operations take long time during the pause and copy stage, especially with the KVM patch 3ea3b7fa9af067, do these operation after the completion of live migration can help to reduce VM downtime. Liang Li (2): migration: do cleanup operation after completion migration: rename

Re: [Qemu-devel] [RFC PATCH V7 09/19] Drop global lock during TCG code execution

2015-08-12 Thread Paolo Bonzini
On 11/08/2015 23:34, Frederic Konrad wrote: Also if qemu_cond_broadcast(qemu_io_proceeded_cond) is being dropped there is no point keeping the guff around in qemu_tcg_wait_io_event. Yes good point. BTW this leads to high consumption of host CPU eg: 100% per VCPU thread as the VCPUs

Re: [Qemu-devel] [PATCH] monitor: remove QAPI_EVENT_VSERPORT_CHANGE throttle

2015-08-12 Thread Daniel P. Berrange
On Tue, Aug 11, 2015 at 08:21:18PM +0200, Laszlo Ersek wrote: On 08/11/15 19:04, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau marcandre.lur...@redhat.com QAPI_EVENT_VSERPORT_CHANGE reports changes of a virtio serial port state. However, the events may be for different

Re: [Qemu-devel] [PATCH] virtio/vhost: drop unnecessary VHOST_SET_VRING call

2015-08-12 Thread Michael S. Tsirkin
On Wed, Aug 12, 2015 at 02:10:56PM +0300, Marcel Apfelbaum wrote: On 08/12/2015 01:34 PM, Michael S. Tsirkin wrote: On Wed, Aug 12, 2015 at 01:19:51PM +0300, Marcel Apfelbaum wrote: No need to send VHOST_SET_VRING_CALL to backend before the negotiation with the guest is finished.

Re: [Qemu-devel] [PATCH 1/2] migration: do cleanup operation after completion

2015-08-12 Thread Paolo Bonzini
On 12/08/2015 23:04, Liang Li wrote: @@ -1008,8 +1009,10 @@ static void *migration_thread(void *opaque) } qemu_mutex_lock_iothread(); +end_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME); +qemu_savevm_state_cancel(); + You can remove the qemu_savevm_state_cancel() call

Re: [Qemu-devel] [PATCH] virtio/vhost: drop unnecessary VHOST_SET_VRING call

2015-08-12 Thread Marcel Apfelbaum
On 08/12/2015 01:34 PM, Michael S. Tsirkin wrote: On Wed, Aug 12, 2015 at 01:19:51PM +0300, Marcel Apfelbaum wrote: No need to send VHOST_SET_VRING_CALL to backend before the negotiation with the guest is finished. Signed-off-by: Marcel Apfelbaum mar...@redhat.com Well - we do need to set it

Re: [Qemu-devel] [PATCH for-2.5 16/30] m68k: Add all access modes and data sizes to some 680x0 instructions

2015-08-12 Thread Richard Henderson
On 08/09/2015 01:13 PM, Laurent Vivier wrote: case 6: /* cmpi */ tcg_gen_mov_i32(dest, src1); tcg_gen_subi_i32(dest, dest, im); gen_update_cc_add(dest, tcg_const_i32(im)); -set_cc_op(s, CC_OP_SUB); +SET_CC_OP(opsize, SUB); break;

[Qemu-devel] [PATCH 02/10] cpus: remove tcg_halt_cond global variable.

2015-08-12 Thread Paolo Bonzini
From: KONRAD Frederic fred.kon...@greensocs.com This removes tcg_halt_cond global variable. We need one QemuCond per virtual cpu for multithread TCG. Signed-off-by: KONRAD Frederic fred.kon...@greensocs.com Message-Id: 1439220437-23957-9-git-send-email-fred.kon...@greensocs.com [Keep

[Qemu-devel] [PATCH 01/10] cpus: protect work list with work_mutex

2015-08-12 Thread Paolo Bonzini
From: KONRAD Frederic fred.kon...@greensocs.com Protect the list of queued work items with something other than the BQL, as a preparation for running the work items outside it. Signed-off-by: KONRAD Frederic fred.kon...@greensocs.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c

[Qemu-devel] [Bug 1297218] Re: guest hangs after live migration due to tsc jump

2015-08-12 Thread Serge Hallyn
Could someone confirm whether this is fixed in 15.04 and/or 15.10? ** Changed in: qemu (Ubuntu) Status: Triaged = Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1297218 Title:

Re: [Qemu-devel] [PATCH for-2.5 17/30] m68k: ori/andi/subi/addi/eori/cmpi can modify SR/CCR

2015-08-12 Thread Richard Henderson
On 08/09/2015 01:13 PM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier laur...@vivier.eu --- target-m68k/translate.c | 95 ++--- 1 file changed, 58 insertions(+), 37 deletions(-) diff --git a/target-m68k/translate.c

[Qemu-devel] [Bug 1163034] Re: linux-user mode can't handle guest setting RLIMIT_AS (hangs running gnutls28 configure check code)

2015-08-12 Thread Serge Hallyn
This will come in when implemented upstream. ** Changed in: qemu (Ubuntu) Importance: High = Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1163034 Title: linux-user mode can't handle

Re: [Qemu-devel] [PATCH for-2.5 19/30] m68k: add cmpm

2015-08-12 Thread Richard Henderson
On 08/09/2015 01:13 PM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier laur...@vivier.eu --- target-m68k/translate.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index ae57792..adf4521 100644 ---

  1   2   >