Re: [Qemu-devel] [PATCH qemu v15 07/17] spapr_iommu: Migrate full state

On Mon, Apr 04, 2016 at 07:33:36PM +1000, Alexey Kardashevskiy wrote: > The source guest could have reallocated the default TCE table and > migrate bigger/smaller table. This adds reallocation in post_load() > if the default table size is different on source and destination. > > This adds

Re: [Qemu-devel] [PATCH] spapr: Don't set the TM ibm, pa-features bit in PR KVM mode

On Tue, Apr 05, 2016 at 12:12:01PM +1000, Paul Mackerras wrote: > On Mon, Apr 04, 2016 at 09:09:28PM +1000, Anton Blanchard wrote: > > We don't support transactional memory in PR KVM, so don't tell > > the OS that we do. > > This assumes PR KVM won't ever support TM, which is hopefully not >

[Qemu-devel] [PATCH 00/10] tb hash improvements

This patchset is derived from my ongoing work on MTTCG, but does not depend on it and brings improvements that we can already benefit from. It applies cleanly on the current master and is checkpatch-clean. The key goal is to make the TB hash table faster, and while at it, scalable. Tested on two

[Qemu-devel] [PATCH 08/10] qht: QEMU's fast, resizable and scalable Hash Table

This is a hash table with optional auto-resizing and MRU promotion for reads and writes. Its implementation goal is to stay fast while scaling for read-mostly workloads. A hash table with these features will be necessary for the scalability of the ongoing MTTCG work; before those changes arrive

[Qemu-devel] [PATCH 06/10] include: add xxhash.h

xxhash is a fast, high-quality hashing function. The appended brings in the 32-bit version of it, with the small modification that it assumes the data to be hashed is made of 32-bit chunks; this increases speed slightly for the use-case we care about, i.e. tb-hash. The original algorithm, as well

[Qemu-devel] [PATCH 05/10] include: add spinlock wrapper

Wrap pthread_spin on POSIX, or QemuMutex on Windows. AFAIK there are is no off-the-shelf spinlock implementation for Windows, so we'll just use QemuMutex. Signed-off-by: Emilio G. Cota --- include/qemu/spinlock-posix.h | 60 +++

[Qemu-devel] [PATCH 03/10] seqlock: remove optional mutex

This option is unused; besides, it bloats the struct when not needed. Let's just let writers define their own locks elsewhere. Signed-off-by: Emilio G. Cota --- cpus.c | 2 +- include/qemu/seqlock.h | 10 +- 2 files changed, 2 insertions(+), 10

[Qemu-devel] [PATCH 04/10] seqlock: rename write_lock/unlock to write_begin/end

It is a more appropriate name, now that the mutex embedded in the seqlock is gone. Signed-off-by: Emilio G. Cota --- cpus.c | 28 ++-- include/qemu/seqlock.h | 4 ++-- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git

[Qemu-devel] [PATCH 07/10] tb hash: hash phys_pc, pc, and flags with xxhash

For some workloads such as arm bootup, tb_phys_hash is performance-critical. The is due to the high frequency of accesses to the hash table, originated by (frequent) TLB flushes that wipe out the cpu-private tb_jmp_cache's. More info:

[Qemu-devel] [PATCH 09/10] qht: add test program

Signed-off-by: Emilio G. Cota --- tests/.gitignore | 1 + tests/Makefile | 6 +++- tests/test-qht.c | 100 +++ 3 files changed, 106 insertions(+), 1 deletion(-) create mode 100644 tests/test-qht.c diff --git

[Qemu-devel] [PATCH 02/10] compiler.h: add QEMU_CACHELINE + QEMU_ALIGN() + QEMU_CACHELINE_ALIGNED

I'm assuming windows compilers don't support this attribute. Signed-off-by: Emilio G. Cota --- include/qemu/compiler.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h index 8f1cc7b..fb946f1 100644 ---

[Qemu-devel] [PATCH 10/10] tb hash: track translated blocks with qht

Having a fixed-size hash table for keeping track of all translation blocks is suboptimal: some workloads are just too big or too small to get maximum performance from the hash table. The MRU promotion policy helps improve performance when the hash table is a little undersized, but it cannot make

[Qemu-devel] [PATCH 01/10] translate-all: add missing fold of tb_ctx into tcg_ctx

Since 5e5f07e08 "TCG: Move translation block variables to new context inside tcg_ctx: tb_ctx" on Feb 1 2013, compilation of usermode + TB_DEBUG_CHECK has been broken. Fix it. Signed-off-by: Emilio G. Cota --- translate-all.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Qemu-devel] [Nbd] Is NBD_CMD_FLAG_FUA valid during NBD_CMD_FLUSH?

Am 01.04.2016 um 09:43 hat Paolo Bonzini geschrieben: > > > On 31/03/2016 22:17, Alex Bligh wrote: > >> > In qemu, read+FUA just triggers blk_co_flush() prior to reading; but > >> > that's the same function it calls for write+FUA. > > That's harmless, but unnecessary in the sense that current

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

Am 01.04.2016 um 13:20 hat Richard W.M. Jones geschrieben: > > My patch, plus the configuration and comments from your patch, > combined. Plus I tested it with libguestfs boot-analysis and it works > and is still fast. > > Integrating this so it happens automatically when the user adds >

Re: [Qemu-devel] [PULL 1/3] ppc: Rework POWER7 & POWER8 exception model

On Tue, Apr 05, 2016 at 12:19:50PM +1000, Benjamin Herrenschmidt wrote: > On Tue, 2016-04-05 at 12:17 +1000, David Gibson wrote: > > From: Cédric Le Goater > > > > From: Benjamin Herrenschmidt > > > > This patch fixes the current AIL implementation

Re: [Qemu-devel] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

Am 04.04.2016 um 18:39 hat Eric Blake geschrieben: > With the availability of sparse storage formats, it is often needed > to query status of a particular range and read only those blocks of > data that are actually present on the block device. > > To provide such information, the patch adds the

Re: [Qemu-devel] sheepdog's "CoQueue overlapping_queue;"

On Mon, Apr 4, 2016 at 10:04 PM, Paolo Bonzini wrote: > I am curious about why overlapping_queue is required for sheepdog. > Overlapping requests have unspecified outcome so the CoQueue is not > necessary as long as the server doesn't crash or return an error. > > Hitoshi,

[Qemu-devel] [PATCH v2] filter-buffer: fix segfault when starting qemu with status=off property

After commit 338d3f, we support 'status' property for filter object. The segfault can be triggered by starting qemu with 'status=off' property for filter, when the s->incoming_queue is NULL, we reference it directly in qemu_net_queue_flush() which was called in status_changed() callback function.

Re: [Qemu-devel] [PATCH v1 3/5] include/qemu/atomic.h: default to __atomic functions

On Mon, Apr 4, 2016 at 1:03 PM, Paolo Bonzini wrote: >> >> Quoting >> http://www.inf.pucrs.br/~flash/progeng2/cppreference/w/cpp/atomic/atomic_thread_fencehtml.html: >> >> "Establishes memory synchronization ordering of non-atomic and relaxed >> atomic accesses" > > You can

Re: [Qemu-devel] [PATCH for-2.7] hw/net/spapr_llan: Provide counter with dropped rx frames to the guest

On Mon, Apr 04, 2016 at 12:13:10PM +0200, Thomas Huth wrote: > The last 8 bytes of the receive buffer list page (that has been supplied > by the guest with the H_REGISTER_LOGICAL_LAN call) contain a counter > for frames that have been dropped because there was no suitable receive > buffer

Re: [Qemu-devel] [ RFC Patch v4 0/3] Support Receive-Segment-Offload(RSC) for WHQL

On 04/04/2016 03:25 AM, w...@redhat.com wrote: > From: Wei Xu > > Changes in V4: > - Add new host feature bit > - Replace using fixed header lenght with dynamic header lenght in VirtIONet > - Change ip/ip6 header union in NetRscUnit to void* pointer > - Add macro prefix,

Re: [Qemu-devel] [ RFC Patch v4 3/3] virtio-net rsc: support coalescing ipv6 tcp traffic

On 04/04/2016 03:25 AM, w...@redhat.com wrote: > From: Wei Xu > > Most things like ipv4 except there is a significant difference between ipv4 > and ipv6, the fragment lenght in ipv4 header includes itself, while it's not typo > included for ipv6, thus means ipv6 can carry a

Re: [Qemu-devel] [ RFC Patch v4 2/3] virtio-net rsc: support coalescing ipv4 tcp traffic

On 04/04/2016 03:25 AM, w...@redhat.com wrote: > From: Wei Xu > > All the data packets in a tcp connection will be cached to a big buffer > in every receive interval, and will be sent out via a timer, the > 'virtio_net_rsc_timeout' controls the interval, the value will influent

Re: [Qemu-devel] [PULL 1/3] ppc: Rework POWER7 & POWER8 exception model

On Tue, 2016-04-05 at 12:17 +1000, David Gibson wrote: > From: Cédric Le Goater > > From: Benjamin Herrenschmidt > > This patch fixes the current AIL implementation for POWER8. The > interrupt vector address can be calculated directly from LPCR when >

[Qemu-devel] [PULL 3/3] vl: Move cpu_synchronize_all_states() into qemu_system_reset()

There are currently 3 calls to qemu_system_reset() in vl.c. Two of them are immediately preceded by a cpu_synchronize_all_states9) and the remaining one should be. The one which doesn't is the very first reset called directly from main(). Without a cpu_synchronize_all_states(), kvm_vcpu_dirty is

Re: [Qemu-devel] [PATCH qemu v15 01/17] memory: Fix IOMMU replay base address

On Mon, Apr 04, 2016 at 07:33:30PM +1000, Alexey Kardashevskiy wrote: > Since a788f227 "memory: Allow replay of IOMMU mapping notifications" > when new VFIO listener is added, all existing IOMMU mappings are > replayed. However there is a problem that the base address of > an IOMMU memory region

[Qemu-devel] [PULL 1/3] ppc: Rework POWER7 & POWER8 exception model

From: Cédric Le Goater From: Benjamin Herrenschmidt This patch fixes the current AIL implementation for POWER8. The interrupt vector address can be calculated directly from LPCR when the exception is handled. The excp_prefix update becomes useless and

[Qemu-devel] [PULL 2/3] spapr_drc: enable immediate detach for unsignalled devices

From: Michael Roth Currently spapr doesn't support "aborting" hotplug of PCI devices by allowing device_del to immediately remove the device if we haven't signalled the presence of the device to the guest. In the past this wasn't an issue, since we always immediately

[Qemu-devel] [PULL 0/3] ppc-for-2.6 queue 20160405

The following changes since commit 2e3a76ae3e47d502f9f0c4424b719945fba9d459: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20160404' into staging (2016-04-04 17:43:39 +0100) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.6

[Qemu-devel] [Bug 1562653] Re: Ubuntu 15.10: QEMU VM hang if memory >= 1T

For cpus which have not EPT feature, should change CR3_L_MODE_RESERVED_BITS in arch/x86/include/asm/kvm_host.h: -#define CR3_L_MODE_RESERVED_BITS 0xFF00ULL +#define CR3_L_MODE_RESERVED_BITS 0xFE00ULL -- You received this bug notification because you are a member of qemu-

Re: [Qemu-devel] [PATCH] spapr: Don't set the TM ibm, pa-features bit in PR KVM mode

On Mon, Apr 04, 2016 at 09:09:28PM +1000, Anton Blanchard wrote: > We don't support transactional memory in PR KVM, so don't tell > the OS that we do. This assumes PR KVM won't ever support TM, which is hopefully not true. If PR KVM does get TM support in future, then QEMU will have no clear way

Re: [Qemu-devel] [ RFC Patch v4 1/3] virtio-net rsc: add a new host offload(rsc) feature bit

On 04/04/2016 03:25 AM, w...@redhat.com wrote: > From: Wei Xu > > A new feature bit 'VIRTIO_NET_F_GUEST_RSC' is introduced to support WHQL > Receive-Segment-Offload test, this feature will coalesce tcp packets in > IPv4/6 for userspace virtio-net driver. > > This feature can be

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

> On (Tue) 22 Mar 2016 [19:05:31], Dr. David Alan Gilbert wrote: > > * Liang Li (liang.z...@intel.com) wrote: > > > > b. Implement a new virtio device > > > Implementing a brand new virtio device to exchange information > > > between host and guest is another choice. It requires modifying the > >

Re: [Qemu-devel] [PATCH v2] util: retry getaddrinfo if getting EAI_BADFLAGS with AI_V4MAPPED

On 4 April 2016 at 16:22, Daniel P. Berrange wrote: > The FreeBSD header files define the AI_V4MAPPED but its > implementation of getaddrinfo() always returns an error > when that flag is set. eg > [...] > --- > > Changed in v2: > > - Fix test case usage of AI_V4MAPPED > -

Re: [Qemu-devel] [PATCH v2] block: Fix bdrv_drain in coroutine

On Mon, 04/04 12:57, Stefan Hajnoczi wrote: > On Fri, Apr 01, 2016 at 09:57:38PM +0800, Fam Zheng wrote: > > Using the nested aio_poll() in coroutine is a bad idea. This patch > > replaces the aio_poll loop in bdrv_drain with a BH, if called in > > coroutine. > > > > For example, the bdrv_drain()

Re: [Qemu-devel] [PATCH] crypto: fix nettle config check for running pbkdf test

On 4 April 2016 at 20:01, Bruce Rogers wrote: On 4/4/2016 at 09:24 AM, "Daniel P. Berrange" wrote: >> The pbkdf test is being built based on a check for CONFIG_NETTLE. >> As of fff2f982ab6ac0dd2b641d30303f72270a019f28, it should be >> instead checking

Re: [Qemu-devel] [PATCH] powerpc: Clear user CPU feature bits if TM is disabled at runtime

On Mon, Apr 04, 2016 at 09:11:12PM +1000, Anton Blanchard wrote: > In check_cpu_pa_features() we check a number of bits in the > ibm,pa-features array and set and clear CPU features based on what > we find. One of these bits is CPU_FTR_TM, the transactional memory > feature bit. > > If this does

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] spapr: compute interrupt vector address from LPCR

On Mon, Apr 04, 2016 at 04:47:53PM +0200, Cédric Le Goater wrote: > On 04/04/2016 06:16 AM, David Gibson wrote: > > On Sun, Apr 03, 2016 at 07:57:50PM +0200, Cédric Le Goater wrote: > >> On 04/01/2016 04:43 AM, David Gibson wrote: > >>> On Thu, Mar 31, 2016 at 08:13:09AM +0100, Mark Cave-Ayland

Re: [Qemu-devel] [PATCH] docs: fix typo in memory.txt

ping... Any feedback？ On Tue, 2016-03-22 at 17:45 +0800, Wei Jiangang wrote: > The scale line should align with A line's end, > and correct the range of vga-window example 0xa-0xb. > > Signed-off-by: Wei Jiangang > --- > docs/memory.txt | 6 +++--- > 1 file

Re: [Qemu-devel] [PATCH] rtl8139: using CP_TX_OWN for ownership transferring during tx

On 04/01/2016 10:53 AM, Jason Wang wrote: > Through CP_TX_OWN and CP_RX_OWN points to the same bit, we'd better use > CP_TX_OWN for tx descriptor handling. > > Signed-off-by: Jason Wang > --- > hw/net/rtl8139.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [Qemu-devel] [PATCH] filter-buffer: fix segfault while start qemu with status=off property

On 04/01/2016 05:33 PM, Hailiang Zhang wrote: > On 2016/4/1 17:10, Wen Congyang wrote: >> On 04/01/2016 04:24 PM, Hailiang Zhang wrote: >>> On 2016/4/1 15:39, Jason Wang wrote: On 04/01/2016 03:08 PM, zhanghailiang wrote: > After commit 338d3f, we support 'status' property for

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 04/04/2016 05:08 PM, Wouter Verhelst wrote: > On Mon, Apr 04, 2016 at 10:54:02PM +0300, Denis V. Lunev wrote: >> saying about dirtiness, we would soon come to the fact, that >> we can have several dirtiness states regarding different >> lines of incremental backups. This complexity is hidden >>

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On Mon, Apr 04, 2016 at 10:54:02PM +0300, Denis V. Lunev wrote: > saying about dirtiness, we would soon come to the fact, that > we can have several dirtiness states regarding different > lines of incremental backups. This complexity is hidden > inside QEMU and it would be very difficult to

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 04/04/2016 04:40 PM, Wouter Verhelst wrote: > Hi, > > Need to look into this in some detail, for which I don't have the time > (or the non-tiredness ;-) right now, but these two caught my eye: > >> +The payload is structured as a list of one or more descriptors, >> +each with this

[Qemu-devel] Question about hw/timer/hpet.c, hw/intc/ioapic.c and polarity

I'm testing some of the HPET handling code in VxWorks using QEMU 2.4.1 and I've encountered something which looks a little odd that I'm hoping someone can clarify for me. First, some background: The HPET timer supports three kinds of interrupt delivery: Legacy: HPET can use the same IRQs as

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

Hi, Need to look into this in some detail, for which I don't have the time (or the non-tiredness ;-) right now, but these two caught my eye: On Mon, Apr 04, 2016 at 10:39:10AM -0600, Eric Blake wrote: [...] > +* `NBD_REPLY_TYPE_BLOCK_STATUS` > + > +*length* MUST be a positive integer

Re: [Qemu-devel] [Nbd] [PATCH 2/2] NBD proto: add GET_LBA_STATUS extension

On Mon, Apr 04, 2016 at 12:18:37PM +0200, Markus Pargmann wrote: > Hi, > > back from my easter vacation. A bit surprised to find 200 mails in the > NBD mailing list ;). I'm sure you were :-) [...] > > Yes. This has been discussed on the nbd-general list in the past. There > > is also the

[Qemu-devel] [PATCH v2] doc: Allow NBD_CMD_FLAG_NO_HOLE during NBD_CMD_WRITE

qemu already has an existing server implementation option that will explicitly search the payload of NBD_CMD_WRITE for large blocks of zeroes, and punch holes in the underlying file. For old clients that don't know how to use the new NBD_CMD_WRITE_ZEROES, this is a workaround to keep the server's

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 4 Apr 2016, at 22:25, Eric Blake wrote: > On 04/04/2016 03:07 PM, Alex Bligh wrote: >> >> On 4 Apr 2016, at 21:26, Eric Blake wrote: >> >>> Huh? The current proposal _requires_ these to be separate queries. You >>> cannot query dirtiness at the same

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 04/05/2016 12:17 AM, Eric Blake wrote: On 04/04/2016 03:04 PM, Denis V. Lunev wrote: In v1 we have had 'status' field, which can have the following values for dirty request: + - `NBD_STATE_DIRTY` (0x0), LBA extent is dirty; + - `NBD_STATE_CLEAN` (0x1), LBA extent is clean. in the

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 04/04/2016 03:07 PM, Alex Bligh wrote: > > On 4 Apr 2016, at 21:26, Eric Blake wrote: > >> Huh? The current proposal _requires_ these to be separate queries. You >> cannot query dirtiness at the same time as allocation, because the value >> of NBD_CMD_FLAG_DIRTY is

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 04/04/2016 03:04 PM, Denis V. Lunev wrote: > In v1 we have had 'status' field, which can have the > following values for dirty request: > > + - `NBD_STATE_DIRTY` (0x0), LBA extent is dirty; > + - `NBD_STATE_CLEAN` (0x1), LBA extent is clean. > > in the extent structure: > > +

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 4 Apr 2016, at 22:04, Denis V. Lunev wrote: > and opinion of Alex was that all 3 bits could be set in reply to > NBD_CMD_BLOCK_STATUS > with NBD_CMD_FLAG_STATUS_DIRTY set. > > This confused him. This confuses me too. Yeah that was precisely how I got confused. -- Alex

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 4 Apr 2016, at 21:34, Eric Blake wrote: > The original design abused the 16-bit 'flags' field of each command to > instead try and treat that value as a bitmap number, instead of a > bitwise-or'd set of flags. That was one of the complaints against v1, > and was fixed in

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 4 Apr 2016, at 21:26, Eric Blake wrote: > Huh? The current proposal _requires_ these to be separate queries. You > cannot query dirtiness at the same time as allocation, because the value > of NBD_CMD_FLAG_DIRTY is distinct between the two queries. OK, so you can ask for

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 04/04/2016 11:34 PM, Eric Blake wrote: On 04/04/2016 02:08 PM, Denis V. Lunev wrote: This again makes me think this should be a different command from something which is obviously useful and comprehensible to more than one server/client (i.e. allocation). original design of this command

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 04/04/2016 11:45 PM, Eric Blake wrote: On 04/04/2016 02:27 PM, Denis V. Lunev wrote: On 04/04/2016 11:15 PM, Alex Bligh wrote: On 4 Apr 2016, at 21:13, Denis V. Lunev wrote: As far as I remember that text we have had a number in request specifying which bitmap to query

Re: [Qemu-devel] [PATCH] tci: Fix build regression

On 4 April 2016 at 21:40, Stefan Weil wrote: > Am 04.04.2016 um 20:06 schrieb Sergey Fedorov: >> On 04/04/16 20:50, Stefan Weil wrote: >>> -/* Defining NDEBUG disables assertions (which makes the code faster). */ >>> -#if !defined(CONFIG_DEBUG_TCG) && !defined(NDEBUG) >>> -#

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 04/04/2016 02:27 PM, Denis V. Lunev wrote: > On 04/04/2016 11:15 PM, Alex Bligh wrote: >> On 4 Apr 2016, at 21:13, Denis V. Lunev wrote: >> >>> As far as I remember that text we have had a number in request >>> specifying which bitmap to query and the server should reply with

Re: [Qemu-devel] [PATCH] tci: Fix build regression

Am 04.04.2016 um 20:06 schrieb Sergey Fedorov: > On 04/04/16 20:50, Stefan Weil wrote: >> -/* Defining NDEBUG disables assertions (which makes the code faster). */ >> -#if !defined(CONFIG_DEBUG_TCG) && !defined(NDEBUG) >> -# define NDEBUG >> +/* Enable TCI assertions only when debugging TCG (and

Re: [Qemu-devel] [Nbd] [PATCH 2/2] NBD proto: add GET_LBA_STATUS extension

On 04/04/2016 02:16 PM, Denis V. Lunev wrote: >> +The following request types are currently defined for the command: >> + >> +1. Block provisioning state >> + >> +Upon receiving an `NBD_CMD_GET_LBA_STATUS` command with command flags >> +field set to `NBD_FLAG_GET_ALLOCATED` (0x0),

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 04/04/2016 02:08 PM, Denis V. Lunev wrote: >> >> This again makes me think this should be a different >> command from something which is obviously useful and >> comprehensible to more than one server/client (i.e. >> allocation). >> > original design of this command has used 16 number > to

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 04/04/2016 11:15 PM, Alex Bligh wrote: On 4 Apr 2016, at 21:13, Denis V. Lunev wrote: As far as I remember that text we have had a number in request specifying which bitmap to query and the server should reply with one bitmap at a time. Would this work for you? I think

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 04/04/2016 02:08 PM, Alex Bligh wrote: > > On 4 Apr 2016, at 21:04, Denis V. Lunev wrote: > >>> Sure, but given you can't report dirtiness without also reporting >>> allocation, if they are are at different blocksize I'd rather they >>> were in different commands, because

Re: [Qemu-devel] [PATCH v3] hw: fix error reporting for missing option ROMs

Hi, Sorry for the long delay in reviewing this. On Fri, Mar 11, 2016 at 05:14:22PM +, Daniel P. Berrange wrote: > If QEMU fails to load any of the VGA ROMs, it prints a message > to stderr and then carries on as if everything was fine, despite > the VGA interface not being functional. This

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 04/04/2016 01:58 PM, Alex Bligh wrote: > Eric, > >> Nothing requires the two uses to report at the same granularity. THe >> NBD_REPLY_TYPE_BLOCK_STATUS allows the server to divide into descriptors >> as it sees fit (so it could report holes at a 4k granularity, but >> dirtiness only at a 64k

Re: [Qemu-devel] [PATCH] crypto: fix nettle config check for running pbkdf test

>>> On 4/4/2016 at 09:24 AM, "Daniel P. Berrange" wrote: > The pbkdf test is being built based on a check for CONFIG_NETTLE. > As of fff2f982ab6ac0dd2b641d30303f72270a019f28, it should be > instead checking CONFIG_NETTLE_KDF > > Reported-by: "Dr. David Alan Gilbert"

Re: [Qemu-devel] [PATCH 2/2] NBD proto: add GET_LBA_STATUS extension

On 03/23/2016 05:16 PM, Denis V. Lunev wrote: From: Pavel Borzenkov With the availability of sparse storage formats, it is often needed to query status of a particular LBA range and read only those blocks of data that are actually present on the block device. To

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 4 Apr 2016, at 21:13, Denis V. Lunev wrote: > As far as I remember that text we have had a number in request > specifying which bitmap to query and the server should reply with one > bitmap at a time. > > Would this work for you? I think that would be much better, yes,

Re: [Qemu-devel] [PATCH v1 3/5] include/qemu/atomic.h: default to __atomic functions

On 04/04/2016 19:03, Paolo Bonzini wrote: > I've looked at private email from that time and I was pointed to this > sentence in GCC's manual, which says the opposite: > > "Note that in the C++11 memory model, fences (e.g., > ‘__atomic_thread_fence’) take effect in combination with other

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 04/04/2016 11:08 PM, Alex Bligh wrote: On 4 Apr 2016, at 21:04, Denis V. Lunev wrote: Sure, but given you can't report dirtiness without also reporting allocation, if they are are at different blocksize I'd rather they were in different commands, because otherwise the code

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 04/04/2016 11:03 PM, Alex Bligh wrote: On 4 Apr 2016, at 20:54, Denis V. Lunev wrote: for now and for QEMU we want this to expose accumulated dirtiness of the block device, which is collected by the server. Yes, this requires external coordination. May be this COULD be the

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 4 Apr 2016, at 21:04, Denis V. Lunev wrote: >> Sure, but given you can't report dirtiness without also reporting >> allocation, if they are are at different blocksize I'd rather they >> were in different commands, because otherwise the code to report >> block size needs to

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 04/04/2016 10:58 PM, Alex Bligh wrote: Eric, Nothing requires the two uses to report at the same granularity. THe NBD_REPLY_TYPE_BLOCK_STATUS allows the server to divide into descriptors as it sees fit (so it could report holes at a 4k granularity, but dirtiness only at a 64k granularity)

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 4 Apr 2016, at 20:54, Denis V. Lunev wrote: > for now and for QEMU we want this to expose accumulated dirtiness > of the block device, which is collected by the server. Yes, this requires > external coordination. May be this COULD be the part of the protocol, > but QEMU will

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

Eric, > Nothing requires the two uses to report at the same granularity. THe > NBD_REPLY_TYPE_BLOCK_STATUS allows the server to divide into descriptors > as it sees fit (so it could report holes at a 4k granularity, but > dirtiness only at a 64k granularity) - all that matters is that when all >

Re: [Qemu-devel] [PATCH 1/2] softfloat: Enable run-time-configurable meaning of signaling NaN bit

On Mon, Apr 04, 2016 at 08:46:17PM +0100, Peter Maydell wrote: > On 4 April 2016 at 20:42, Eduardo Habkost wrote: > > On Mon, Apr 04, 2016 at 08:38:54PM +0100, Peter Maydell wrote: > >> On 4 April 2016 at 20:37, Eduardo Habkost wrote: > >> > On Mon, Apr

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 04/04/2016 10:34 PM, Eric Blake wrote: On 04/04/2016 12:06 PM, Alex Bligh wrote: On 4 Apr 2016, at 17:39, Eric Blake wrote: +This command is meant to operate in tandem with other (non-NBD) +channels to the server. Generally, a "dirty" block is a block +that

Re: [Qemu-devel] [PATCH 1/2] softfloat: Enable run-time-configurable meaning of signaling NaN bit

On 4 April 2016 at 20:42, Eduardo Habkost wrote: > On Mon, Apr 04, 2016 at 08:38:54PM +0100, Peter Maydell wrote: >> On 4 April 2016 at 20:37, Eduardo Habkost wrote: >> > On Mon, Apr 04, 2016 at 02:31:47PM +0100, Peter Maydell wrote: >> >> On 4 April

Re: [Qemu-devel] [PATCH 1/2] softfloat: Enable run-time-configurable meaning of signaling NaN bit

On Mon, Apr 04, 2016 at 08:38:54PM +0100, Peter Maydell wrote: > On 4 April 2016 at 20:37, Eduardo Habkost wrote: > > On Mon, Apr 04, 2016 at 02:31:47PM +0100, Peter Maydell wrote: > >> On 4 April 2016 at 14:21, Aleksandar Markovic > >> wrote:

Re: [Qemu-devel] [PATCH 1/2] softfloat: Enable run-time-configurable meaning of signaling NaN bit

On 4 April 2016 at 20:37, Eduardo Habkost wrote: > On Mon, Apr 04, 2016 at 02:31:47PM +0100, Peter Maydell wrote: >> On 4 April 2016 at 14:21, Aleksandar Markovic >> wrote: >> > B. arm - explicitely sets other fields of float_status, >> >

Re: [Qemu-devel] [PATCH v2 0/2] Fix for compile on FreeBSD/i386 (and others?)

On 4 April 2016 at 20:26, Alex Bennée wrote: > Ed Maste writes: > >> On 4 April 2016 at 10:35, Alex Bennée wrote: >>> Only the first patch has actually changed. Instead of moving the read >>> inside the write seqlock it is now

Re: [Qemu-devel] [PATCH 1/2] softfloat: Enable run-time-configurable meaning of signaling NaN bit

On Mon, Apr 04, 2016 at 02:31:47PM +0100, Peter Maydell wrote: > On 4 April 2016 at 14:21, Aleksandar Markovic > wrote: > > B. arm - explicitely sets other fields of float_status, > > explicit invocation of set_snan_bit_is_one(0) added > > We zero the

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 04/04/2016 12:06 PM, Alex Bligh wrote: > > On 4 Apr 2016, at 17:39, Eric Blake wrote: > >> +This command is meant to operate in tandem with other (non-NBD) >> +channels to the server. Generally, a "dirty" block is a block >> +that has been written to by

Re: [Qemu-devel] [PATCH v2 0/2] Fix for compile on FreeBSD/i386 (and others?)

Ed Maste writes: > On 4 April 2016 at 10:35, Alex Bennée wrote: >> Only the first patch has actually changed. Instead of moving the read >> inside the write seqlock it is now done using the seqlock_read_* >> primitives. >> >> Build tested on a

Re: [Qemu-devel] [PATCH] ps2kbd: default to scancode_set 2, as with KBD_CMD_RESET

On Wed, Mar 23, 2016 at 07:21:40AM +0100, Hervé Poussineau wrote: > This line has been added in commit ef74679a810fe6858f625b9d52b68cc3fc61eb3d > with > other initializations. However, scancode set 0 doesn't exist (only 1, 2, 3). > This works well as long as operating system is resetting

Re: [Qemu-devel] [RFC PATCH v1 1/2] target-arm: Update page size for aarch64

On Mon, Apr 4, 2016 at 7:14 PM, Peter Maydell wrote: > On 4 April 2016 at 14:39, wrote: >> From: Vijay >> >> Set target page size to minimum 4K for aarch64. >> This helps to reduce live migration downtime significantly.

Re: [Qemu-devel] [PATCH 3/3] ide: really restart pending and in-flight atapi dma

On 04/04/2016 12:54 PM, Pavel Butsykin wrote: > On 04.04.2016 19:24, John Snow wrote: >> >> >> On 04/04/2016 06:32 AM, Pavel Butsykin wrote: >>> On 02.04.2016 01:34, John Snow wrote: On 04/01/2016 10:32 AM, Denis V. Lunev wrote: > From: Pavel Butsykin

Re: [Qemu-devel] [PATCH v2 0/2] Fix for compile on FreeBSD/i386 (and others?)

On 4 April 2016 at 10:35, Alex Bennée wrote: > Only the first patch has actually changed. Instead of moving the read > inside the write seqlock it is now done using the seqlock_read_* > primitives. > > Build tested on a FreeBSB/i386 VM with these applied: > >

Re: [Qemu-devel] [PATCH] tci: Fix build with no '-DNDEBUG'

On 04/04/16 20:53, Stefan Weil wrote: > Am 04.04.2016 um 15:22 schrieb Sergey Fedorov: >> On 04/04/16 14:56, Stefan Weil wrote: > [...] >>> There is indeed a regression in the current code. Commit >>> d38ea87ac54af64ef611de434d07c12dc0399216 added an include statement >>> which includes assert.h

Re: [Qemu-devel] [PATCH] tci: Fix build regression

On 04/04/16 20:50, Stefan Weil wrote: > -/* Defining NDEBUG disables assertions (which makes the code faster). */ > -#if !defined(CONFIG_DEBUG_TCG) && !defined(NDEBUG) > -# define NDEBUG > +/* Enable TCI assertions only when debugging TCG (and without NDEBUG > defined). > + * Without assertions,

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 4 Apr 2016, at 17:39, Eric Blake wrote: > +This command is meant to operate in tandem with other (non-NBD) > +channels to the server. Generally, a "dirty" block is a block > +that has been written to by someone, but the exact meaning of "has > +been

Re: [Qemu-devel] best way to implement emulation of AArch64 tagged addresses

On 04/04/2016 09:31 AM, Peter Maydell wrote: On 4 April 2016 at 17:28, Richard Henderson wrote: On 04/04/2016 08:51 AM, Peter Maydell wrote: In particular I think if you just do the relevant handling of the tag bits in target-arm's get_phys_addr() and its subroutines then

[Qemu-devel] [PULL 1/3] .travis.yml: collapse the test matrix

Remove the concept of TARGETS and build the complete target list for each config combination. Now the matrix is just based on CONFIG stanzas and we use the additional stuff for: - things that only work on one compiler (sparse, gcov, gprof) - combos where "make check" fails Signed-off-by:

Re: [Qemu-devel] [PATCH] tci: Fix build with no '-DNDEBUG'

Am 04.04.2016 um 15:22 schrieb Sergey Fedorov: > On 04/04/16 14:56, Stefan Weil wrote: [...] >> There is indeed a regression in the current code. Commit >> d38ea87ac54af64ef611de434d07c12dc0399216 added an include statement >> which includes assert.h before NDEBUG is defined. This is wrong and >>

[Qemu-devel] [PATCH] tci: Fix build regression

Commit d38ea87ac54af64ef611de434d07c12dc0399216 cleaned the include statements which resulted in a wrong order of assert.h and the definition of NDEBUG in tci.c. Normally NDEBUG modifies the definition of the assert macro, but here this definition comes too late which results in a failing build.

[Qemu-devel] [PULL 2/3] .travis.yml: enable OSX builds

Travis has support for OSX builds. Making the setup work cleanly involves a little hacking about with the .travis.yml file but rather than make it too messy I've pushed all the "brew" install stuff into a support script called ./scripts/macosx-brew.sh. Currently only the default ./configure

[Qemu-devel] [PULL 0/3] Travis updates

The following changes since commit e31f0451876aa7ada74d60304aa241506a383797: net: fix missing include of qapi/error.h in netmap.c (2016-04-04 15:01:14 +0100) are available in the git repository at: https://github.com/stsquad/qemu.git tags/travis-pull-04042016 for you to fetch changes up

[Qemu-devel] [PULL 3/3] .travis.yml: make -j3

The move from Travis VMs to Containers came with a upgrade from 1.5 cores to 2. The received wisdom is -j N+1 means a core can be doing work while other threads wait for IO to complete. This is hard to test on the Travis infrastructure but an initial before/after eyeballing seems to confirm it is

  1   2   3   >