Re: [Qemu-devel] [PATCH v3 17/18] trace: pass trace-events to tracetool as a positional param

Daniel P Berrange writes: > Instead of reading the contents of 'trace-events' from stdin, > accept the filename as a positional parameter. This also > allows for reading from multiple files, though this facility > is not used at this time. > Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] [PATCH 1/1] block: add cache mode with direct IO and without flushes

On 09/16/2016 11:22 AM, Kevin Wolf wrote: > Am 16.09.2016 um 10:15 hat Denis V. Lunev geschrieben: >> On 09/16/2016 11:08 AM, Kevin Wolf wrote: >>> Am 15.09.2016 um 18:39 hat Denis V. Lunev geschrieben: On 09/15/2016 07:09 PM, Kevin Wolf wrote: > Am 15.09.2016 um 15:19 hat Denis V. Lunev

Re: [Qemu-devel] [PATCH v7 1/4] vfio: Mediated device Core driver

On Mon, 19 Sep 2016 22:59:34 +0530 Kirti Wankhede wrote: > On 9/12/2016 9:23 PM, Alex Williamson wrote: > > On Mon, 12 Sep 2016 13:19:11 +0530 > > Kirti Wankhede wrote: > > > >> On 9/12/2016 10:40 AM, Jike Song wrote: > >>> On 09/10/2016 03:55

Re: [Qemu-devel] [PATCH v3 08/18] trace: remove the TraceEventID and TraceEventVCPUID enums

Daniel P Berrange writes: > The TraceEventID and TraceEventVCPUID enums constants are > no longer actually used for anything critical. > The TRACE_EVENT_COUNT limit is used to determine the size > of the TraceEvents array, and can be removed if we just > NULL terminate the array instead. > The

Re: [Qemu-devel] [PULL 00/18] QAPI patches for 2016-09-19

On 19 September 2016 at 17:41, Markus Armbruster wrote: > The following changes since commit e3571ae30cd26d19efd4554c25e32ef64d6a36b3: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20160916' into > staging (2016-09-16 16:54:50 +0100) > > are available in the

Re: [Qemu-devel] [PATCH for-2.8 v4 0/6] Add support for Cadence GEM priority queues

On 28 July 2016 at 20:00, Alistair Francis wrote: > > This patch series adds initial priority queue support to the Cadence GEM > device. This is based on original work by Peter C, that has been ported > to the latest version of QEMU. > > There is more GEM work that

Re: [Qemu-devel] [RFC 7/8] util/qht: atomically set b->hashes

On Mon, Sep 19, 2016 at 16:51:38 +0100, Alex Bennée wrote: > ThreadSanitizer detects a possible race between reading/writing the > hashes. As ordering semantics are already documented for qht we just > need to ensure a race can't tear the hash value so we can use the > relaxed atomic_set/read

Re: [Qemu-devel] [PATCH 1/2] qapi: Stub out StringOutputVisitor struct support

* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Dr. David Alan Gilbert" writes: > >> > >> > * Markus Armbruster (arm...@redhat.com) wrote: > >> >> "Dr. David

Re: [Qemu-devel] [PATCH v3 13/18] trace: dynamically allocate event IDs at runtime

Daniel P Berrange writes: > Instead of having the code generator assign event IDs and > event VCPU IDs, assign them when the events are registered > at runtime. This will allow us allow code to be generated > from individual trace-events without having to figure out > globally unique numbering at

[Qemu-devel] [PATCH 5/6] iotests: chown LUKS device before qemu-io launches

On some distros, whenever you close a block device file descriptor there is a udev rule that resets the file permissions. This can race with the test script when we run qemu-io multiple times against the same block device. Occassionally the second qemu-io invokation will find udev has reset the

[Qemu-devel] [PATCH 0/6] Improve I/O tests coverage of LUKS

The main goal of this series is to get the I/O tests passing 100% with LUKS when run with './check -luks'. In testing this I noticed that test timings are cached across runs with different block backends which is very misleading. It adds a few more combinations to the LUKS/dmcrypt

Re: [Qemu-devel] [PATCH v3 12/18] trace: dynamically allocate trace_dstate in CPUState

Daniel P Berrange writes: > The CPUState struct has a bitmap tracking which VCPU > events are currently active. This is indexed based on > the event ID values, and sized according the maximum > TraceEventVCPUID enum value. > When we start dynamically assigning IDs at runtime, > we can't

Re: [Qemu-devel] [PATCH v3 00/10] virtio: avoid exit() when device enters invalid states

On Mon, Sep 19, 2016 at 06:07:40PM +0200, Cornelia Huck wrote: > On Tue, 12 Apr 2016 14:25:24 +0100 > Stefan Hajnoczi wrote: > > > v3: > > * Patch 1: Fix typo and clarify commit description [Markus] > > * Use virtio_set_status() instead of open coding assignment [Cornelia]

Re: [Qemu-devel] [PATCH v3 00/18] Refactor trace to allow modular build

Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PATCH v3 00/18] Refactor trace to allow modular build Message-id:

Re: [Qemu-devel] [PATCH] Avoid additional GET_FEATURES call on vhost-user

Thanks for the reminder. 2.8 is open now so I can integrate this. I would appreciate it if you could rebase this top of commit d1b4259f1ab18af24e6a297edb6a8f71691f3256 Author: Maxime Coquelin Date: Tue Sep 13 15:30:30 2016 +0200

[Qemu-devel] [PATCH 1/6] iotests: throw away test timings if args change

The 'check' program records timings for each test that is run. These timings are only valid, however, for a particular format/protocol combination. So if frequently running 'check' with a variety of different formats or protocols, the times printed can be very misleading. Record the

Re: [Qemu-devel] 答复： Re: [PATCH v2] object: Add 'help' option for all available backends and properties

Andreas Färber writes: > Hi Lin and Markus, > > Am 19.09.2016 um 13:58 schrieb Markus Armbruster: [...] >> You're messing with struct EnumProperty because you want more help than >> what ObjectPropertyInfo can provice. >> >> Digression on the meaning of ObjectPropertyInfo.

Re: [Qemu-devel] [PATCH v7 1/4] vfio: Mediated device Core driver

On 9/12/2016 9:23 PM, Alex Williamson wrote: > On Mon, 12 Sep 2016 13:19:11 +0530 > Kirti Wankhede wrote: > >> On 9/12/2016 10:40 AM, Jike Song wrote: >>> On 09/10/2016 03:55 AM, Kirti Wankhede wrote: On 9/10/2016 12:12 AM, Alex Williamson wrote: > On Fri, 9

[Qemu-devel] [PATCH 3/6] iotests: reduce PBKDF iterations when testing LUKS

By default the PBKDF algorithm used with LUKS is tuned based on the number of iterations to produce 1 second of running time. This makes running the I/O test with the LUKS format orders of magnitude slower than with qcow2/raw formats. When creating LUKS images, set the iteration time to a 10ms to

Re: [Qemu-devel] [PATCH v3 06/18] trace: break circular dependancy in event-internal.h

Typo in subject: dependancy -> dependency Daniel P Berrange writes: > Currently event-internal.h includes generated-events.h, > while generated-events.h includes event-internal.h > causing a circular dependency. > event-internal.h requires that the content of > generated-events.h comes first,

[Qemu-devel] [PATCH 4/6] iotests: add more LUKS hash combination tests

Add tests for sha224, sha512, sha384 and ripemd160 hash algorithms. Signed-off-by: Daniel P. Berrange --- tests/qemu-iotests/149 | 10 +- tests/qemu-iotests/149.out | 482 - 2 files changed, 484 insertions(+), 8 deletions(-)

Re: [Qemu-devel] [PULL v2 0/8] Merge qcrypto 2016/09/19

On 19 September 2016 at 16:33, Daniel P. Berrange wrote: > The following changes since commit 0f2fa73ba0ca19ebdaccf0d1785583d6601411b6: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2016-09-19 11:23:20 +0100) > > are available in the git

[Qemu-devel] [PATCH 2/6] iotests: fix remainining tests to work with LUKS

The tests 033, 120, 140, 145 and 157 were all broken when run with LUKS, since they did not correctly use the required image opts args syntax to specify the decryption secret. Signed-off-by: Daniel P. Berrange --- tests/qemu-iotests/033 | 16

Re: [Qemu-devel] [PATCH v2] virtio: add check for descriptor's mapped address

On 19/09/2016 18:59, Laszlo Ersek wrote: > On 09/19/16 17:55, Stefan Hajnoczi wrote: >> On Mon, Sep 19, 2016 at 02:36:11PM +0530, P J P wrote: >>> From: Prasad J Pandit >>> >>> virtio back end uses set of buffers to facilitate I/O operations. >>> If its size is too

[Qemu-devel] [PATCH 6/6] iotests: use _filter_qemu with test 140

When run on a loaded host, QEMU may print main-loop: WARNING: I/O thread spun for 10 iterations so we must take care to filter that message. Signed-off-by: Daniel P. Berrange --- tests/qemu-iotests/140 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH v3 04/18] trace: remove global 'uint16 dstate[]' array

Daniel P Berrange writes: > Instead of having a global dstate array, declare a single > 'uint16 TRACE_${EVENT_NAME}_DSTATE' variable for each > trace event. Record a pointer to this variable in the > TraceEvent struct too. > By turning trace_event_get_state_dynamic_by_id into a > macro, this

Re: [Qemu-devel] [PATCH v3 03/18] trace: remove some now unused functions

On Mon, Sep 19, 2016 at 07:00:26PM +0200, Lluís Vilanova wrote: > Daniel P Berrange writes: > > > The trace_event_count, trace_event_id and > > trace_event_pattern methods are no longer required > > now that everything is using the iterator APIs > > > The trace_event_set_state and

Re: [Qemu-devel] [PATCH v3 07/18] trace: give each trace event a named TraceEvent struct

Daniel P Berrange writes: > Currently we only expose a TraceEvent array, which must > be indexed via the TraceEventID enum constants. This > changes the generator to expose a named TraceEvent > instance for each event, with an _EV suffix. > Signed-off-by: Daniel P. Berrange

[Qemu-devel] [PATCH v4 1/2] block: reintroduce bdrv_flush_all

Commit fe1a9cbc moved the flush_all routine from the bdrv layer to the block-backend layer. In doing so, however, the semantics of the routine changed slightly such that flush_all now used blk_flush instead of bdrv_flush. blk_flush can fail if the attached device model reports that it is not

[Qemu-devel] [PATCH v2 00/10] block: Accept qdev IDs in device level QMP commands

In order to remove the necessity to use BlockBackend names in the external API, we already converted all block layer QMP commands on the node level to accept node names instead of BlockBackend names. This series converts the second part, device level commands, to allow qdev device names instead of

Re: [Qemu-devel] [PATCH v3 02/18] trace: convert code to use event iterators

Daniel P Berrange writes: > This converts the HMP/QMP monitor API implementations > and some internal trace control methods to use the new > trace event iterator APIs. > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Daniel P. Berrange > --- >

Re: [Qemu-devel] [PATCH v2] virtio: add check for descriptor's mapped address

On 09/19/16 19:16, Laurent Vivier wrote: > > > On 19/09/2016 18:59, Laszlo Ersek wrote: >> On 09/19/16 17:55, Stefan Hajnoczi wrote: >>> On Mon, Sep 19, 2016 at 02:36:11PM +0530, P J P wrote: From: Prasad J Pandit virtio back end uses set of buffers to

[Qemu-devel] [PATCH v2 07/10] block: Accept device model name for eject

In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts eject to accept a qdev device name. Signed-off-by: Kevin Wolf --- blockdev.c | 10 +++--- hmp.c

Re: [Qemu-devel] [PATCH v3 05/18] trace: remove duplicate control.h includes in generated-tracers.h

Daniel P Berrange writes: > The format/h.py file adds an include for control.h to > generated-tracers.h. ftrace, log and syslog, then > add more duplicate includes for control.h. > Signed-off-by: Daniel P. Berrange Reviewed-by: Lluís Vilanova > ---

Re: [Qemu-devel] [PATCH v2 2/3] target-i386: turn off CPU.l3-cache only for 2.7 and older machine types

On Mon, Sep 19, 2016 at 10:32:34AM +0200, Igor Mammedov wrote: > commit (14c985cff target-i386: present virtual L3 cache info for vcpus) > misplaced compat property putting it in new 2.8 machine type > which would effectively to disable feature until 2.9 is released. > Intent of commit probably

[Qemu-devel] [PATCH v2 02/10] qdev-monitor: Factor out find_device_state()

Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- qdev-monitor.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index e19617f..bc0213f 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c

Re: [Qemu-devel] [PATCH 1/2] qapi: Stub out StringOutputVisitor struct support

"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert" writes: >> >> > * Markus Armbruster (arm...@redhat.com) wrote: >> >> "Dr. David Alan Gilbert" writes: >> >> >> >> > *

Re: [Qemu-devel] [PATCH v2 1/3] pc: clean up COMPAT macroses chaining

On Mon, Sep 19, 2016 at 10:32:33AM +0200, Igor Mammedov wrote: > Since commit > bacc344c ("machine: add properties to compat_props incrementaly") > there is no need to chain per machine type compat macroses. > > Clean up places where it was done anyway so it will be > consistent and won't

[Qemu-devel] [PATCH v2 01/10] block: Add blk_by_dev()

This finds a BlockBackend given the device model that is attached to it. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- block/block-backend.c | 19 +++ include/sysemu/block-backend.h | 1 + 2 files changed, 20 insertions(+)

[Qemu-devel] [PATCH v4 2/2] qemu: use bdrv_flush_all for vm_stop et al

Reimplement bdrv_flush_all for vm_stop. In contrast to blk_flush_all, bdrv_flush_all does not have device model restrictions. This allows us to flush and halt unconditionally without error. This allows us to do things like migrate when we have a device with an open tray, but has a node that may

[Qemu-devel] [PATCH v2 06/10] block: Accept device model name for x-blockdev-remove-medium

In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts x-blockdev-remove-medium to accept a qdev device name. As the command is experimental, we can still remove the 'device' option that

[Qemu-devel] [PATCH v2 10/10] qemu-iotests/118: Test media change with qdev name

We just added the option to use qdev device names in all device related block QMP commands. This patch converts some of the test cases in 118 to use qdev device names instead of BlockBackend names to cover the new way. It converts cases for each of the media change commands, but only for CD-ROM

Re: [Qemu-devel] [PATCH v3 03/18] trace: remove some now unused functions

Daniel P Berrange writes: > The trace_event_count, trace_event_id and > trace_event_pattern methods are no longer required > now that everything is using the iterator APIs > The trace_event_set_state and trace_event_set_vcpu_state > macros were also unused. Wouldn't it make more sense to fold

[Qemu-devel] [PATCH v2 05/10] block: Accept device model name for x-blockdev-insert-medium

In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts x-blockdev-insert-medium to accept a qdev device name. As the command is experimental, we can still remove the 'device' option that

Re: [Qemu-devel] [PATCH v2] virtio: add check for descriptor's mapped address

On 09/19/16 17:55, Stefan Hajnoczi wrote: > On Mon, Sep 19, 2016 at 02:36:11PM +0530, P J P wrote: >> From: Prasad J Pandit >> >> virtio back end uses set of buffers to facilitate I/O operations. >> If its size is too large, 'cpu_physical_memory_map' could return >> a null

[Qemu-devel] [PATCH v2 09/10] block: Accept device model name for block_set_io_throttle

In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts block_set_io_throttle to accept a qdev device name. Signed-off-by: Kevin Wolf --- blockdev.c | 12

[Qemu-devel] [PATCH v2 08/10] block: Accept device model name for blockdev-change-medium

In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts blockdev-change-medium to accept a qdev device name. Signed-off-by: Kevin Wolf --- blockdev.c | 18

[Qemu-devel] [PATCH v2 03/10] qdev-monitor: Add blk_by_qdev_id()

This finds the BlockBackend attached to the device model identified by its qdev ID. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- include/sysemu/block-backend.h | 1 + qdev-monitor.c | 18 ++ 2 files changed, 19

[Qemu-devel] [PULL 05/18] monitor: register gen:false commands manually

From: Marc-André Lureau Since a few commands are using 'gen': false, they are not registered automatically by the generator. Register manually instead. This is in preparation for removal of qapi 'middle' mode generation. Note that qmp_init_marshal() function isn't

[Qemu-devel] [PULL 11/18] monitor: remove mhandler.cmd_new

From: Marc-André Lureau This is no longer necessary now that we aren't using middle mode anymore. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake Message-Id:

[Qemu-devel] [PULL 16/18] build-sys: remove qmp-commands-old.h

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake Message-Id: <20160912091913.15831-17-marcandre.lur...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by:

[Qemu-devel] [PULL 01/18] build-sys: define QEMU_VERSION_{MAJOR, MINOR, MICRO}

From: Marc-André Lureau There are better chances to find what went wrong at build time than a later assert in qmp_query_version Signed-off-by: Marc-André Lureau Message-Id: <20160912091913.15831-2-marcandre.lur...@redhat.com>

[Qemu-devel] [PULL 18/18] Replace qmp-commands.hx by docs/qmp-commands.txt

From: Marc-André Lureau The only remaining function of qmp-commands.hx is to let us generate qmp-commands.txt from it. Replace qmp-commands.hx by qmp-commands.txt. We intend to move the documentation into the QAPI schema and generate qapi-commands.txt from it, but

[Qemu-devel] [PULL 09/18] monitor: use qmp_find_command() (using generated qapi code)

From: Marc-André Lureau Stop using the so-called 'middle' mode. Instead, use qmp_find_command() from generated qapi commands registry. Update and fix the documentation too. Signed-off-by: Marc-André Lureau Message-Id:

[Qemu-devel] [PULL 07/18] qmp: Hack to keep commands configuration-specific

From: Marc-André Lureau We currently define QMP commands in two places: the QAPI schema and qmp-commands.hx. The latter is preprocessed, the former is not. We use the preprocessor to suppress configuration-specific commands. For instance, query-spice is only

[Qemu-devel] [PATCH v2 04/10] block: Accept device model name for blockdev-open/close-tray

In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts blockdev-open/close-tray to accept a qdev device name. Signed-off-by: Kevin Wolf --- blockdev.c | 61

[Qemu-devel] [PULL 02/18] qapi-schema: use generated marshaller for 'qmp_capabilities'

From: Marc-André Lureau qapi'fy the 'qmp_capabilities' command, makes the command visible in query-qmp-schema. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster

[Qemu-devel] [PULL 13/18] qapi: check invalid arguments on no-args commands

From: Marc-André Lureau The generated marshal functions do not visit arguments from commands that take no arguments. Thus they fail to catch invalid members. Visit the arguments, if provided, to throw an error in case of invalid members. Currently,

[Qemu-devel] [PULL 10/18] monitor: implement 'qmp_query_commands' without qmp_cmds

From: Marc-André Lureau One step towards getting rid of the static qmp_cmds table. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake Message-Id: <20160912091913.15831-11-marcandre.lur...@redhat.com>

[Qemu-devel] [PATCH v4 0/2] block: allow flush on devices with open tray

Final re-send for wording. The move to blk_flush altered the behavior of migration and flushing nodes that are not reachable via the guest, but are still reachable via QEMU and may or may not need to be flushed. This is likely the simplest solution for now until we nail down our policy a bit

[Qemu-devel] [PULL 00/18] QAPI patches for 2016-09-19

The following changes since commit e3571ae30cd26d19efd4554c25e32ef64d6a36b3: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20160916' into staging (2016-09-16 16:54:50 +0100) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2016-09-19 for

[Qemu-devel] [PULL 12/18] qapi: remove the "middle" mode

From: Marc-André Lureau Now that the register function is always generated, we can remove the so-called "middle" mode from the generator script. Signed-off-by: Marc-André Lureau Message-Id:

[Qemu-devel] [PULL 08/18] qapi: export the marshallers

From: Marc-André Lureau Make it possible to call marshallers manually, without going through qmp_dispatch(). (this is currently only possible in middle-mode, but it's also useful in general) Signed-off-by: Marc-André Lureau Message-Id:

[Qemu-devel] [PULL 15/18] monitor: use qmp_dispatch()

From: Marc-André Lureau Replace the old manual dispatch and validation code by the generic one provided by qapi common code. Note that it is now possible to call the following commands that used to be disabled by compile-time conditionals: - dump-skeys - query-spice

[Qemu-devel] [PULL 03/18] qapi-schema: add 'device_add'

From: Marc-André Lureau Even though device_add is not fully qapi'fied, we may add it to the json schema with 'gen': false, so registration and documentation can be generated. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake

[Qemu-devel] [PULL 06/18] qapi: Support unregistering QMP commands

Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau Message-Id: <20160912091913.15831-7-marcandre.lur...@redhat.com> --- include/qapi/qmp/dispatch.h | 1 + qapi/qmp-registry.c | 8 2 files changed, 9 insertions(+)

[Qemu-devel] [PULL 04/18] monitor: simplify invalid_qmp_mode()

From: Marc-André Lureau handle_qmp_command() will switch to use qmp_dispatch(). It won't have a pointer to the marshaller function anymore, but only the name of the command to invoke. Simplify invalid_qmp_mode() so it can just be called with the command name.

[Qemu-devel] [PULL 17/18] qmp-commands.hx: fix some styling

From: Marc-André Lureau Add some missing lines, remove superflous @ in command name, remove trailing spaces. Signed-off-by: Marc-André Lureau Message-Id: <20160912091913.15831-18-marcandre.lur...@redhat.com> Reviewed-by: Markus

[Qemu-devel] [PULL 14/18] tests: add a test to check invalid args

From: Marc-André Lureau Check that invalid args on commands without arguments returns an error. Signed-off-by: Marc-André Lureau Message-Id: <20160912091913.15831-15-marcandre.lur...@redhat.com> Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v3 01/18] trace: add trace event iterator APIs

Daniel P Berrange writes: > Currently methods which want to iterate over trace events, > do so using the trace_event_count() and trace_event_id() > methods. This leaks the concept of a single ID enum to > the callers. There is an alternative trace_event_pattern() > method which can be used in an

Re: [Qemu-devel] [PATCH qemu] spapr_pci: Add numa node id

Quoting Alexey Kardashevskiy (2016-09-14 04:39:10) > On 14/09/16 09:29, Michael Roth wrote: > > Quoting Alexey Kardashevskiy (2016-07-27 03:03:38) > >> This adds a numa id property to a PHB to allow linking passed PCI device > >> to CPU/memory. It is up to the management stack to do CPU/memory

Re: [Qemu-devel] [PATCH v3 00/10] virtio: avoid exit() when device enters invalid states

On Tue, 12 Apr 2016 14:25:24 +0100 Stefan Hajnoczi wrote: > v3: > * Patch 1: Fix typo and clarify commit description [Markus] > * Use virtio_set_status() instead of open coding assignment [Cornelia] > * Add live migration > > v2: > * Add VIRTIO_CONFIG_S_NEEDS_RESET

Re: [Qemu-devel] [PATCH v7 00/16] cpu-exec: Safe work in quiescent state

Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v7 00/16] cpu-exec: Safe work in quiescent state Message-id:

Re: [Qemu-devel] [PATCH v3 00/18] Refactor trace to allow modular build

On Mon, Sep 19, 2016 at 08:54:50AM -0700, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > Hi, > > Your series seems to have some coding style problems. See output below for > more information: > > Type: series > Subject: [Qemu-devel] [PATCH v3 00/18] Refactor trace to allow modular

Re: [Qemu-devel] [PATCH v7 1/2] libs/gnttab: introduce grant copy interface

On Mon, Sep 19, 2016 at 04:58:23PM +0100, Wei Liu wrote: > On Wed, Sep 14, 2016 at 09:10:02PM +0200, Paulina Szubarczyk wrote: > > In a linux part an ioctl(gntdev, IOCTL_GNTDEV_GRANT_COPY, ..) > > system call is invoked. In mini-os the operation is yet not > > implemented. For the OSs that does

Re: [Qemu-devel] [PATCH v3 14/18] trace: get rid of generated-events.h/generated-events.c

On 09/19/2016 09:49 AM, Daniel P. Berrange wrote: > Currently the generated-events.[ch] files contain the > event dstates, constants and TraceEvent structs, while the > generated-tracers.[ch] files contain the actual trace > probe logic. With the removal of usage of the event enums > from the API

Re: [Qemu-devel] [PATCH 1/6] tests/tcg: Move i386 tests to arch specific folder

Marc-André Lureau writes: >> index 000..15f77af >> --- /dev/null >> +++ b/tests/tcg/i386/Makefile >> @@ -0,0 +1,88 @@ >> +BUILD_DIR=../../../build/ >> > > Looks like you are hardcoding a custom path here. Missed this one. Will fix it up. > > There are many Makefile changes that I think you

Re: [Qemu-devel] [PATCH v3 0/6] Clean up TCG tests

Hi Marc, Marc-André Lureau writes: > Hi Pranith > > On Sat, Sep 17, 2016 at 6:05 PM Pranith Kumar wrote: > >> Hello, >> >> This patch series cleans up the tcg tests in tests/tcg folder. >> >> > Incidentally, I was also looking at reorganizing tests/tcg last week. I >

Re: [Qemu-devel] [Bug 1625216] [NEW] memory writes via gdb don't work for memory mapped hardware

Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [Bug 1625216] [NEW] memory writes via gdb don't work for memory mapped hardware Message-id: 20160919143701.1959.82839.malone...@soybean.canonical.com === TEST

Re: [Qemu-devel] [PATCH v7 1/2] libs/gnttab: introduce grant copy interface

On Wed, Sep 14, 2016 at 09:10:02PM +0200, Paulina Szubarczyk wrote: > In a linux part an ioctl(gntdev, IOCTL_GNTDEV_GRANT_COPY, ..) > system call is invoked. In mini-os the operation is yet not > implemented. For the OSs that does not implement gnttab the > call of the grant copy operation causes

Re: [Qemu-devel] 答复： Re: [PATCH v2] object: Add 'help' option for all available backends and properties

Hi Lin and Markus, Am 19.09.2016 um 13:58 schrieb Markus Armbruster: > This is about QOM use. Cc: Andreas in case he has smart ideas. > Andreas, you may want to skip ahead to "EnumProperty". > > "Lin Ma" writes: > > Markus Armbruster 2016/9/12 星期一 下午

Re: [Qemu-devel] (no subject)

Hi Fam Thanks! Yes gdb provides one approach but I was wondering if there was something built in to QEMU monitor. Another application I can see for this would be to inject errors into the memory, This will be useful for testing new NVDIMM-P technology that builds NVDIMMs out of material that

Re: [Qemu-devel] [PULL v1 0/8] Merge qcrypto 2016/09/19

On Mon, Sep 19, 2016 at 03:50:00PM +0100, Daniel P. Berrange wrote: > On Mon, Sep 19, 2016 at 03:36:38PM +0100, Peter Maydell wrote: > > On 19 September 2016 at 12:44, Daniel P. Berrange > > wrote: > > > The following changes since commit > > >

[Qemu-devel] [RFC 7/8] util/qht: atomically set b->hashes

ThreadSanitizer detects a possible race between reading/writing the hashes. As ordering semantics are already documented for qht we just need to ensure a race can't tear the hash value so we can use the relaxed atomic_set/read functions. Signed-off-by: Alex Bennée ---

Re: [Qemu-devel] [PATCH v2] virtio: add check for descriptor's mapped address

On Mon, Sep 19, 2016 at 02:36:11PM +0530, P J P wrote: > From: Prasad J Pandit > > virtio back end uses set of buffers to facilitate I/O operations. > If its size is too large, 'cpu_physical_memory_map' could return > a null address. This would result in a null

[Qemu-devel] [RFC 4/8] seqlock: use atomic writes for the sequence

From: Paolo Bonzini There is a data race if the sequence is written concurrently to the read. In C11 this has undefined behavior. Use atomic_set; the read side is already using atomic_read. Reported-by: Alex Bennée Signed-off-by: Paolo Bonzini

[Qemu-devel] [RFC 3/8] new: blacklist.tsan

A list of blacklists for tsan instrumentation. One hopes more can be removed over time as tsan improves. The path needs to be absolute so it doesn't break when directories change during the build: ./configure --with-coroutine=gthread --disable-pie \ --extra-cflags="-g3 -O0

Re: [Qemu-devel] [PATCH 0/2] improve aio_poll performance

On Wed, Sep 14, 2016 at 07:03:37AM -0400, Yaowei Bai wrote: > This patchset change to check epoll's enablement first before nodes > iteration to improve aio_poll()'s performance. > > Also fix a wrong comment of mirror_start(). > > Yaowei Bai (2): > block: mirror: fix wrong comment of

[Qemu-devel] [RFC 1/8] ui/vnc-enc-tight: add abort() for unexpected default

When enabling the sanitizer build it will complain about control reaching a non-void function. Normally the compiler should detect that there is only one possible exit given a static VNC_SERVER_FB_BYTES. As we should never get here I added an abort() rather than a default return value.

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

On Fri 16 Sep 2016 10:33:36 AM CEST, Pradeep Jagadeesh wrote: Hi, first of all, sorry for the late reply! Here are my comments: > --- a/fsdev/qemu-fsdev-opts.c > +++ b/fsdev/qemu-fsdev-opts.c > @@ -37,6 +37,82 @@ static QemuOptsList qemu_fsdev_opts = { > }, { > .name =

[Qemu-devel] [RFC 5/8] qom/object: update class cache atomically

The idiom CPU_GET_CLASS(cpu) is fairly extensively used in various threads and trips of ThreadSanitizer due to the fact it updates obj->class->object_cast_cache behind the scenes. As this is just a fast-path cache there is no need to lock updates just ensure that we don't get torn-updates from two

Re: [Qemu-devel] [PATCH v3 00/18] Refactor trace to allow modular build

Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v3 00/18] Refactor trace to allow modular build Message-id: 1474296549-29171-1-git-send-email-berra...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [RFC 0/8] A couple of fixes for ThreadSanitizer

Hi, As a precursor to next set of MTTCG reviews in my inbox I had a quick look at the current state of using ThreadSanitizer with QEMU. There are a number of patches here: 1,2,3: workarounds for the compiler when tsan enabled 4,5,6,7: various fixes using atomic_set/read() 8: defend the

[Qemu-devel] [RFC 6/8] cpu: atomically modify cpu->exit_request

ThreadSanitizer picks up potential races although we already use barriers to ensure things are in the correct order when processing exit requests. For now we just use the relaxed atomic_set/atomic_read semantics to reassure tsan that we can't tear the value. Signed-off-by: Alex Bennée

Re: [Qemu-devel] [PULL v2 0/8] Merge qcrypto 2016/09/19

Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PULL v2 0/8] Merge qcrypto 2016/09/19 Message-id: 1474299237-1054-1-git-send-email-berra...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH v3 04/18] trace: remove global 'uint16 dstate[]' array

On 09/19/2016 09:48 AM, Daniel P. Berrange wrote: > Instead of having a global dstate array, declare a single > 'uint16 TRACE_${EVENT_NAME}_DSTATE' variable for each > trace event. Record a pointer to this variable in the > TraceEvent struct too. > > By turning trace_event_get_state_dynamic_by_id

[Qemu-devel] [RFC 8/8] .travis.yml: add gcc sanitizer build

As it seems easy to break the ThreadSanitizer build we should defend it to ensure that fixes get applied when it breaks. We use the Ubuntu GCC PPA to get the latest GCC goodness. Signed-off-by: Alex Bennée --- .travis.yml | 16 1 file changed, 16

[Qemu-devel] [RFC 2/8] tcg/optimize: move default return out of if statement

This is to appease sanitizer builds which complain that: "error: control reaches end of non-void function" Signed-off-by: Alex Bennée --- tcg/optimize.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index

[Qemu-devel] [PULL v2 2/8] crypto: make PBKDF iterations configurable for LUKS format

As protection against bruteforcing passphrases, the PBKDF algorithm is tuned by counting the number of iterations needed to produce 1 second of running time. If the machine that the image will be used on is much faster than the machine where the image is created, it can be desirable to raise the

Re: [Qemu-devel] [PATCH 1/2] qapi: Stub out StringOutputVisitor struct support

* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Dr. David Alan Gilbert" writes: > >> > >> > * Markus Armbruster (arm...@redhat.com) wrote: > >> >> "Dr. David

<    1   2   3   4   5   >